GNU bug report logs - #58955
[PATCH] gnu: pd: Update to 0.53-0, unbundle oss and portaudio

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58955 in the body.
You can then email your comments to 58955 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sughosha <Sughosha <at> proton.me>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: pd: Update to 0.53-0, unbundle oss and portaudio
Date: Wed, 02 Nov 2022 01:28:21 +0000

* gnu/packages/music.scm (pd): Update to 0.53-0.
[arguments]: Unbundle oss and portaudio.
[inputs]: Add portaudio.
---
 gnu/packages/music.scm | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/music.scm b/gnu/packages/music.scm
index ca400e8..b018c8e 100644
--- a/gnu/packages/music.scm
+++ b/gnu/packages/music.scm
@@ -2693,24 +2693,26 @@ export.")
 (define-public pd
   (package
     (name "pd")
-    (version "0.52-2")
+    (version "0.53-0")
     (source (origin
               (method url-fetch)
               (uri
                (string-append "http://msp.ucsd.edu/Software/pd-"
                               version ".src.tar.gz"))
               (sha256
                (base32
-                "04fcsfgnv2r7g7p8vk9s9n3wba1bx4xgqw5mhwv09xbw9s3gapg9"))))
+                "01zcgw4bg4r422ikqa0d4s7vpgjjz76scnm4l1msnm35y7pzknns"))))
     (build-system gnu-build-system)
     (arguments
      (let ((wish (string-append "wish" (version-major+minor
                                         (package-version tk)))))
        (list
         #:tests? #f                     ; no "check" target
         #:configure-flags
         #~(list
+           "--disable-oss"
            "--enable-jack"
+           "--without-local-portaudio"
            (string-append "--with-wish="
                           (search-input-file %build-inputs
                                              (string-append "/bin/" #$wish))))
@@ -2724,7 +2726,7 @@ export.")
     (native-inputs
      (list autoconf automake libtool gettext-minimal pkg-config))
     (inputs
-     (list tk alsa-lib jack-1))
+     (list tk alsa-lib jack-1 portaudio))
     (home-page "https://puredata.info")
     (synopsis "Visual programming language for artistic performances")
     (description
--
libgit2 1.4.3

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Sughosha <Sughosha <at> proton.me>
Cc: 58955 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#58955] [PATCH] gnu: pd: Update to 0.53-0, unbundle oss and
 portaudio
Date: Thu, 03 Nov 2022 18:27:48 +0100

[Message part 1 (text/plain, inline)]

Sughosha via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/music.scm (pd): Update to 0.53-0.
> [arguments]: Unbundle oss and portaudio.
> [inputs]: Add portaudio.
> ---
>  gnu/packages/music.scm | 8 +++++---
>  1 file changed, 5 insertions(+), 3 deletions(-)

Hey Sughosha,

I'm having a bit of trouble matching up the commit message with the
changes being made.

From the diff, it looks like oss is being disabled, rather than
unbundled. What's the reasoning behind disabling it?

Adding portaudio as an input seems fine I guess, but it might be good to
remove the portaudio files from the source (through a snippet) if there
are some there.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Message #16 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sughosha <Sughosha <at> proton.me>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 58955 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#58955] [PATCH] gnu: pd: Update to 0.53-0,
 unbundle oss and portaudio
Date: Fri, 04 Nov 2022 13:29:14 +0000

Hi Christopher,

Thanks for reviewing the patch.

> From the diff, it looks like oss is being disabled, rather than
> unbundled. What's the reasoning behind disabling it?
OSS is not needed since it was superseded by ALSA and it does the job.
I disabled it because it's not at all used in Guix and also not needed
as we have ALSA. Sorry for not being accurate in the message.
> 
> Adding portaudio as an input seems fine I guess, but it might be good to
> remove the portaudio files from the source (through a snippet) if there
> are some there.
I tried it but autoconf or automake looks for it and gives error, before
starting building.

Message #24 received at 58955-done <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> envs.net>
To: Sughosha <Sughosha <at> proton.me>
Cc: 58955-done <at> debbugs.gnu.org, Christopher Baines <mail <at> cbaines.net>
Subject: Re: bug#58955: [PATCH] gnu: pd: Update to 0.53-0, unbundle oss and
 portaudio
Date: Sun, 29 Jan 2023 14:56:57 +0800

Sughosha <Sughosha <at> proton.me> writes:

> Hi Christopher,
>
> Thanks for reviewing the patch.
>
>> From the diff, it looks like oss is being disabled, rather than
>> unbundled. What's the reasoning behind disabling it?
> OSS is not needed since it was superseded by ALSA and it does the job.
> I disabled it because it's not at all used in Guix and also not needed
> as we have ALSA. Sorry for not being accurate in the message.
>> 
>> Adding portaudio as an input seems fine I guess, but it might be good to
>> remove the portaudio files from the source (through a snippet) if there
>> are some there.
> I tried it but autoconf or automake looks for it and gives error, before
> starting building.

Pushed with adjusted commit message, thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.