GNU bug report logs - #58979
treesitter-regression with json-mode

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 58979 in the body.
You can then email your comments to 58979 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Johann Höchtl <johann.hoechtl <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: treesitter-regression with json-mode
Date: Wed, 2 Nov 2022 17:16:08 +0100

[Message part 1 (text/plain, inline)]

When I open a large json file (about 3_000_000 lines, about 72Mb,
pretty-printed) Emacs 29.0.50 opens the file just fine in `js-json-mode`
and when using regexp-based font locking, it works well.

When I force this buffer into javascript-mode, Emacs hangs. Memory
consumption as reported by Windows task manager "dances" around 2Gb, yet
even after waiting for three minutes, Emacs doesn't get responsive any more.

I consider this an unfortunately regression as recent commits to Emacs 29
(long lines patches) actually makes working with such large files with long
lines absolutely pleasant, yet as it seems the interaction with tree-sitter
destroys this gains.

[Message part 2 (text/html, inline)]

Message #8 received at 58979 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Johann Höchtl <johann.hoechtl <at> gmail.com>
Cc: Yuan Fu <casouri <at> gmail.com>, 58979 <at> debbugs.gnu.org
Subject: Re: bug#58979: treesitter-regression with json-mode
Date: Sat, 12 Nov 2022 12:34:03 -0800

Johann Höchtl <johann.hoechtl <at> gmail.com> writes:

> When I open a large json file (about 3_000_000 lines, about 72Mb,
> pretty-printed) Emacs 29.0.50 opens the file just fine in
> `js-json-mode` and when using regexp-based font locking, it works
> well.
>
> When I force this buffer into javascript-mode, Emacs hangs. Memory
> consumption as reported by Windows task manager "dances" around 2Gb,
> yet even after waiting for three minutes, Emacs doesn't get responsive
> any more.
>
> I consider this an unfortunately regression as recent commits to Emacs
> 29 (long lines patches) actually makes working with such large files
> with long lines absolutely pleasant, yet as it seems the interaction
> with tree-sitter destroys this gains.

Copying in Yuan Fu.

Message #11 received at 58979 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: johann.hoechtl <at> gmail.com, 58979 <at> debbugs.gnu.org
Subject: Re: bug#58979: treesitter-regression with json-mode
Date: Mon, 21 Nov 2022 23:44:10 -0800

Stefan Kangas <stefankangas <at> gmail.com> writes:

> Johann Höchtl <johann.hoechtl <at> gmail.com> writes:
>
>> When I open a large json file (about 3_000_000 lines, about 72Mb,
>> pretty-printed) Emacs 29.0.50 opens the file just fine in
>> `js-json-mode` and when using regexp-based font locking, it works
>> well.
>>
>> When I force this buffer into javascript-mode, Emacs hangs. Memory
>> consumption as reported by Windows task manager "dances" around 2Gb,
>> yet even after waiting for three minutes, Emacs doesn't get responsive
>> any more.
>>
>> I consider this an unfortunately regression as recent commits to Emacs
>> 29 (long lines patches) actually makes working with such large files
>> with long lines absolutely pleasant, yet as it seems the interaction
>> with tree-sitter destroys this gains.
>
> Copying in Yuan Fu.

Again, sorry for the delay, I just saw this report :-)

Since your previous report is actually about emacs-tree-sitter, I think
this one is too?

Anyway, since tree-sitter is merged into master now, if you rebuild
master and turn on json-ts-mode, you should be in tree-sitter backed
JSON mode. I’d give that a try and see if works fine.

Thanks,
Yuan

Message #18 received at 58979-done <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: 58979-done <at> debbugs.gnu.org
Subject: Re: bug#58979: treesitter-regression with json-mode
Date: Sat, 7 Jan 2023 15:10:14 -0800

Yuan Fu <casouri <at> gmail.com> writes:

> Stefan Kangas <stefankangas <at> gmail.com> writes:
>
>> Johann Höchtl <johann.hoechtl <at> gmail.com> writes:
>>
>>> When I open a large json file (about 3_000_000 lines, about 72Mb,
>>> pretty-printed) Emacs 29.0.50 opens the file just fine in
>>> `js-json-mode` and when using regexp-based font locking, it works
>>> well.
>>>
>>> When I force this buffer into javascript-mode, Emacs hangs. Memory
>>> consumption as reported by Windows task manager "dances" around 2Gb,
>>> yet even after waiting for three minutes, Emacs doesn't get responsive
>>> any more.
>>>
>>> I consider this an unfortunately regression as recent commits to Emacs
>>> 29 (long lines patches) actually makes working with such large files
>>> with long lines absolutely pleasant, yet as it seems the interaction
>>> with tree-sitter destroys this gains.
>>
>> Copying in Yuan Fu.
>
> Again, sorry for the delay, I just saw this report :-)
>
> Since your previous report is actually about emacs-tree-sitter, I think
> this one is too?
>
> Anyway, since tree-sitter is merged into master now, if you rebuild
> master and turn on json-ts-mode, you should be in tree-sitter backed
> JSON mode. I’d give that a try and see if works fine.
>
> Thanks,
> Yuan

Closing this report since I think there’s nothing to do. Feel free to
reopen.

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.