GNU bug report logs - #59011
29.0.50; change to vc-git-working-revision breaks vc-git-mode-line-string

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Jonas Bernoulli <jonas@HIDDEN>; merged with #59257; Done: Sean Whitton <spwhitton@HIDDEN>; Maintainer for emacs is bug-gnu-emacs@HIDDEN.
Forcibly Merged 59011 59257. Request was from Sean Whitton <spwhitton@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 59011-done <at> debbugs.gnu.org:


Received: (at 59011-done) by debbugs.gnu.org; 10 Mar 2025 07:10:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Mar 10 03:10:26 2025
Received: from localhost ([127.0.0.1]:36149 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1trXHN-0006uI-P0
	for submit <at> debbugs.gnu.org; Mon, 10 Mar 2025 03:10:26 -0400
Received: from sendmail.purelymail.com ([34.202.193.197]:54380)
 by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.84_2) (envelope-from <spwhitton@HIDDEN>)
 id 1trXHK-0006tw-SI
 for 59011-done <at> debbugs.gnu.org; Mon, 10 Mar 2025 03:10:23 -0400
DKIM-Signature: a=rsa-sha256;
 b=Qe8diVtPNHkZJbS+Ja0A7ZyxPhuXKwe35gwjgRyZ22yBXIjio4D8Wov4/PjWMMCvVuvQFUW0ejO0lStdYHdKc81TWgtmkUsKToEsXGtI5socHRKT7I3DVRnDO4QQkVpKF3bRI6SxECJLKfBPi+grD+WMcVp5hH5GpdzQlhYc0o9m8IvCLHBRbTefjpDm7t2l4qosajkRcZKlrBPsxKoP9KO/ax0oV097ikBIenfVGkk0jpWKjC5wwXgjAa+Ron0psCUPKzgamSlXHT4/P7l5tFpEeJVgDnktFJqTuAgBWvnfS06spPYe5WzLoHFnZfGSivH0loyg42pwwOkyiRG4hw==;
 s=purelymail3; d=spwhitton.name; v=1;
 bh=pogfvhIitLyCY/KRDusEpu3tTXKSNdNfpTpeYyAWdc4=;
 h=Received:Received:From:To:Subject:Date; 
DKIM-Signature: a=rsa-sha256;
 b=MnYgQPSb5oHxnmMGogx7hameWZW2uDlPjgM5K+vPe0kiKZSM9MSidi90/M9g9Z382ifTszv5DIqJMQ1ak3Z8S9Yu4LizG3LLdm11ouVsBbd0DC+gWZ1jfSaD40Bzyp3pLdIN6JXXmzx60N+vA7vPHv7pqzyw2emhzYawLvd5V9njdAMmw80WwODdEGP9RcOdDUqlD99XWRmr1dCdXWpuVIVs5TyweEinEfwW39CTg20eszWiPZCzVD8d5xpJSyAq53iSioFqMOGyDk/APviWe3jxbJa7BrcPFF4ZCxFjvtHjF3OfvGXX2dHhOiOyh2U1WRLnJqoQLi4RMrESxOMJ0A==;
 s=purelymail3; d=purelymail.com; v=1;
 bh=pogfvhIitLyCY/KRDusEpu3tTXKSNdNfpTpeYyAWdc4=;
 h=Feedback-ID:Received:Received:From:To:Subject:Date; 
Feedback-ID: 20115:3760:null:purelymail
X-Pm-Original-To: 59011-done <at> debbugs.gnu.org
Received: by smtp.purelymail.com (Purelymail SMTP) with ESMTPSA id 1167995553
 for <59011-done <at> debbugs.gnu.org>
 (version=TLSv1.3 cipher=TLS_AES_256_GCM_SHA384);
 Mon, 10 Mar 2025 07:10:15 +0000 (UTC)
Received: by melete.silentflame.com (Postfix, from userid 1000)
 id D091E7EDCCA; Mon, 10 Mar 2025 15:10:11 +0800 (CST)
From: Sean Whitton <spwhitton@HIDDEN>
To: 59011-done <at> debbugs.gnu.org
Subject: Re: bug#59011: 29.0.50; change to vc-git-working-revision breaks
 vc-git-mode-line-string
In-Reply-To: <87leoq7k69.fsf@HIDDEN>
References: <875yfvw6pv.fsf@HIDDEN> <87leoq7k69.fsf@HIDDEN>
Date: Mon, 10 Mar 2025 15:10:11 +0800
Message-ID: <87msdtl5t8.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 59011-done
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello,

On Fri 04 Nov 2022 at 04:34pm GMT, Philip Kaludercic wrote:

> This was already touched on in bug#58709, and I believe it is best to
> revert the change for now.

This was done.

-- 
Sean Whitton




Notification sent to Jonas Bernoulli <jonas@HIDDEN>:
bug acknowledged by developer. Full text available.
Reply sent to Sean Whitton <spwhitton@HIDDEN>:
You have taken responsibility. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 4 Nov 2022 16:34:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 04 12:34:56 2022
Received: from localhost ([127.0.0.1]:54669 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oqzei-0003nw-C9
	for submit <at> debbugs.gnu.org; Fri, 04 Nov 2022 12:34:56 -0400
Received: from lists.gnu.org ([209.51.188.17]:44782)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <philipk@HIDDEN>) id 1oqzee-0003nm-B4
 for submit <at> debbugs.gnu.org; Fri, 04 Nov 2022 12:34:54 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <philipk@HIDDEN>)
 id 1oqzee-0003Lx-0f
 for bug-gnu-emacs@HIDDEN; Fri, 04 Nov 2022 12:34:52 -0400
Received: from mout01.posteo.de ([185.67.36.65])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <philipk@HIDDEN>)
 id 1oqzeb-0003FA-AS
 for bug-gnu-emacs@HIDDEN; Fri, 04 Nov 2022 12:34:51 -0400
Received: from submission (posteo.de [185.67.36.169]) 
 by mout01.posteo.de (Postfix) with ESMTPS id 9C0D0240026
 for <bug-gnu-emacs@HIDDEN>; Fri,  4 Nov 2022 17:34:40 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017;
 t=1667579682; bh=Udqg0LcbjgYxp0gVPC4e/z4b7j14fF5reL3BJGVlaT4=;
 h=From:To:Cc:Subject:Autocrypt:Date:From;
 b=RTGenQYQOScfn8JsORO9LG+1+h1bX/AwS3u2AbqFRh/DokPpUT2dIstHB53BkHgDI
 xryZtuuT3s/ZVbTvKcshfjSyUIXXS0t3K9AttKeSgor6ZdCVABPG7SgEE7E8Oxq16g
 sGtSqP3GN8fX9RK6iSDnSmU4Jg7vBZYKtd3zNSUr1tUMxB+UWiJ0ugUArdr4xjk7g8
 Mw9XylkeRNgOTXrE6F9v2p7ClznXBCb6lAh2F84zkNnF6ade222RUfcseMZxJjhKhy
 iBI0pGiHgbDIaaQdm2AX/tO2R278pDZv/MtxlIjnme/Z91mgl90/ne518PZhED1cbG
 k41KxbspZ71Yg==
Received: from customer (localhost [127.0.0.1])
 by submission (posteo.de) with ESMTPSA id 4N3mS02Z69z9rxV;
 Fri,  4 Nov 2022 17:34:40 +0100 (CET)
From: Philip Kaludercic <philipk@HIDDEN>
To: Jonas Bernoulli <jonas@HIDDEN>
Subject: Re: 29.0.50; change to vc-git-working-revision breaks
 vc-git-mode-line-string
In-Reply-To: <875yfvw6pv.fsf@HIDDEN> (Jonas Bernoulli's message of "Fri,
 04 Nov 2022 07:53:48 +0100")
References: <875yfvw6pv.fsf@HIDDEN>
Autocrypt: addr=philipk@HIDDEN; keydata=
 mQGNBGLfygUBDADVznbke6w0n9nE42xb+ZggbBy0IYRkkru/K+NA67523YTl2DoR2a5OMW90w7L9
 KDtX2Mp34JN/6jVOSVC07VUbHVu6/exoGKixkiTpGhBPy5tUUJoxQKqLrzVQhN3fIyvg1oyHXKZm
 QGkUeevV0wjj4++xfjmcP235YvDh3TF8HC9t5KxIQIbhWnQm4ZyDkpWWS2CmdNttlj2+eH+51WLL
 bgx2bcwTmqrs079Q3hgF3yh44bBEmp9MgFjiZldOY2my0/ZSeucRxYmiM0vbJEBQgZV/MvA3gTxe
 7ibV3ii7AyoYA8FiFDP98S/R2y5Nfq3ez9B7qeqtpSNseQHOU7h8Y5VV01a71ZszENAmbbwsldb9
 j+HRLke7rn6mswDZl1qA/9ZFRzliFOdQtS1878XjraY+h5jfjvxaFVK23prGGVrrKv0LPWavoFUr
 nsjeHEZhYezBKhC2PwvRtXm01S3rkNbwm9pj0tfLSDW+1pT+6eZWptfQCXF2oEvgfKSTASUAEQEA
 AbQmUGhpbGlwIEthbHVkZXJjaWMgPHBoaWxpcGtAcG9zdGVvLm5ldD6JAdQEEwEKAD4WIQRxJuHe
 LwzjXHcL7QHyw8xRPbifZgUCYt/KBQIbAwUJA8JnAAULCQgHAgYVCgkICwIEFgIDAQIeAQIXgAAK
 CRDyw8xRPbifZkH+DACmCKmhrYgcv2i6dj3vRCVINaLtKUODTna/wAmP20WRKPhqvqvKNUx/wzpT
 aZrXIxpxOU2xawRWeHhWUktxS+W9L3xTACeR0gf5gomCxD9RuBTIohzWDkQt5rk8QwLqx5rAy5zo
 feXujnDCXkZtodo1m54cY2kUFF/WIYRrciL/EBzpcizybMJFwx4HxSBlGRkdwnSH9Dzo+4U+8ctB
 xDfTvQ7cK/0+Qz/TvKjUK8LXLN1/rJTmqpRDv+Odx9LaxutGGoXeLwmhhgpRhvUS8EsqHGF37Zxe
 AV/ybdVU4NHXVecZAhSgOXX4EHDa7NjhTihx9Id478aQycOKf3CiI6Z8AgcR/iKE4bD4osh2cqQB
 +JIBtktImxJ1vFsehdQVjdLPWqlr/1weMHM4xH/4VtCLOl5mO3K+fUWxQ/DGLXeQVZ+hilITSKMl
 YVH/7he26WGd9FRJR25t9uTSgL2YIG8xYppKXueyK/5zjHq05UZRFKiFuPTE4Daoemqx86vYlui5
 AY0EYt/KBQEMANvhe1fPQ3BHBcE2GfdX9kVXV0uAP+2Be2DxKWPJI1SqZbrS4wSUsDdd2+2m4YMX
 E3d+K9Z6IqBcr5gMFSN9QKGEo91FYYgnqvtnd6n9sEAScfNri2GVJzlmXAtEAWeVlv83cu0v0Gsw
 rSKkxZfMxt+EodtN0aswf5SAy77t28NZUw4fk/0o0AlIMjByVcDkipn7N02gLHjYsvMGFFtM3Zqg
 Fps8ix3XytSg3Pf8hIVhXFGkBs/iN6dGeIs8wVWBsB7azdqE84uUSRAcS4ymqUE6KxsbNo4x8RAx
 9Pt2fcL5bWURAZB+83dk8NVmoQdtY+d4JUV9RAKM/Qg/qtE0fVxcZnj8YmxB1NzLf0UxgHuGYtaq
 HWrB80CROxMzK7fH8yDRnQKHT2gJYMMQjzMwakSSk8bNJDGBTvAbnxSbYMUC3FR4Pz3pSAbsaSz6
 LY0QHDRlroBpyJHatrtKh9Uf9nV0wPIKgZfaH2mhiU17/N6wx0W12cBhrTDRoSnTYIgvQQARAQAB
 iQG8BBgBCgAmFiEEcSbh3i8M41x3C+0B8sPMUT24n2YFAmLfygUCGwwFCQPCZwAACgkQ8sPMUT24
 n2b4ogv/Z5HKvWT2hB238G0ZrUxBptNdQHSG3VwfghN30KH7AEW8ZxsDn3zckn/jXxob4VyhUC8d
 zZdBQstsNgl+NZ7S2JYRUEsIpoRiHnQFJnfPpt6YZMVNYHJkuh7zRIQGji4OoS8j9QdUHsJnQDia
 xElXx2vwcBTRZBybcNC+3scGgFBzAcrI4AhYjKZBj5lvKMTrWhK+o4bVdFaYTJDIq37MM3IQLzFF
 oPIB1C525V916wVYSVl7+RQ1T/mf9oX9kZcYVTC0g4KBEEDI4SGK0i5sKDLfBp4c91AFlUo/J8nC
 hUMWblnpfCC7epUEbrms0ZQE7RFLgy7YCLZ9Fx2JfV6gx9n9vH7kI605uLnTHgkw3uED/CKfVlbW
 v0Yrtvi0rUMunLnlySIpXItkSIK+PCqTMdLJ3rBe0ALPgbKN6Lu+yxfe0eaAmFbrNZFI0xp40403
 gDwhwoq742fLwbxPSldSeb8A93KRg/8e92CMwKVYtxoADeoksMq10iid4POQl2vw
Date: Fri, 04 Nov 2022 16:34:38 +0000
Message-ID: <87leoq7k69.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=185.67.36.65; envelope-from=philipk@HIDDEN;
 helo=mout01.posteo.de
X-Spam_score_int: -43
X-Spam_score: -4.4
X-Spam_bar: ----
X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
Cc: bug-gnu-emacs@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

Jonas Bernoulli <jonas@HIDDEN> writes:

> Since 307ad210040251ea0de2e7f453350c4497bda874 `vc-git-working-revision'
> may return the name of a reference (aka symbolic commit) instead of the
> full sha1 hash, as it used to always do.
>
> When that name is shorter than seven characters, then that change breaks
> `vc-git-mode-line-string', which expects to be able to extract the first
> seven characters of the string returned by `vc-git-working-revision'.

This was already touched on in bug#58709, and I believe it is best to
revert the change for now.

The motivation for the change was to make selecting revisions for the
new `vc-prepare-patch' command, but perhaps it would be better to handle
the issue somewhere else like in vc-*-revision-table.

> (By the way, it is not correct to abbreviate a commit hash to the first
> N characters using (substring hash 0 N).  Even in a small repository
> there is a risk that such a naive abbreviation is ambiguous.  Instead of
> doing that, one should use Git to perform the abbreviation; that way one
> can request an abbreviation of a certain length, and Git will comply --
> unless doing that would be ambiguous, in which case it returns a longer
> abbreviation.)

If this is only done in the mode line, then I don't think there is too
much harm in doing so (it isn't fed back into git at any point), though
using a proper abbreviation would technically preferable.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#59011; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 4 Nov 2022 06:54:05 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 04 02:54:05 2022
Received: from localhost ([127.0.0.1]:51466 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oqqaa-00086f-S6
	for submit <at> debbugs.gnu.org; Fri, 04 Nov 2022 02:54:05 -0400
Received: from lists.gnu.org ([209.51.188.17]:43774)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jonas@HIDDEN>) id 1oqqaY-00086X-49
 for submit <at> debbugs.gnu.org; Fri, 04 Nov 2022 02:54:03 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <jonas@HIDDEN>) id 1oqqaX-0005jT-Ly
 for bug-gnu-emacs@HIDDEN; Fri, 04 Nov 2022 02:54:01 -0400
Received: from mail.hostpark.net ([212.243.197.30])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <jonas@HIDDEN>) id 1oqqaV-00070F-Pe
 for bug-gnu-emacs@HIDDEN; Fri, 04 Nov 2022 02:54:01 -0400
Received: from localhost (localhost [127.0.0.1])
 by mail.hostpark.net (Postfix) with ESMTP id C9F4C16614;
 Fri,  4 Nov 2022 07:53:50 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=bernoul.li; h=
 content-type:content-type:mime-version:message-id:date:date
 :subject:subject:from:from:received:received; s=sel2011a; t=
 1667544830; bh=566RKC+zXrv3j2yo/izQEcmdPetNmrYaPudFJYgQ6nE=; b=b
 ErdoPRbjwn06Iki1zZjG/+jGc+syovFSAKqXIm5/aO7eySf//wrP3fRMoK4bS0TB
 uy1gOhbOZLJaPpXOYNvrEaZi3KBN8H9tn/F11+FEoXHxDpPyLGZNb/mLKUUHbWRJ
 WcikLIMqjYcPFXzU+iZs/+c2o4B/bjakcP0NP03j8w=
X-Virus-Scanned: by Hostpark/NetZone Mailprotection at hostpark.net
Received: from mail.hostpark.net ([127.0.0.1])
 by localhost (mail0.hostpark.net [127.0.0.1]) (amavisd-new, port 10224)
 with ESMTP id qxSIyr37qApF; Fri,  4 Nov 2022 07:53:50 +0100 (CET)
Received: from customer (localhost [127.0.0.1])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest
 SHA256) (No client certificate requested)
 by mail.hostpark.net (Postfix) with ESMTPSA id 9B9FD1637E;
 Fri,  4 Nov 2022 07:53:50 +0100 (CET)
From: Jonas Bernoulli <jonas@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 29.0.50; change to vc-git-working-revision breaks
 vc-git-mode-line-string
Date: Fri, 04 Nov 2022 07:53:48 +0100
Message-ID: <875yfvw6pv.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: none client-ip=212.243.197.30; envelope-from=jonas@HIDDEN;
 helo=mail.hostpark.net
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: submit
Cc: Philip Kaludercic <philipk@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

Since 307ad210040251ea0de2e7f453350c4497bda874 `vc-git-working-revision'
may return the name of a reference (aka symbolic commit) instead of the
full sha1 hash, as it used to always do.

When that name is shorter than seven characters, then that change breaks
`vc-git-mode-line-string', which expects to be able to extract the first
seven characters of the string returned by `vc-git-working-revision'.

(By the way, it is not correct to abbreviate a commit hash to the first
N characters using (substring hash 0 N).  Even in a small repository
there is a risk that such a naive abbreviation is ambiguous.  Instead of
doing that, one should use Git to perform the abbreviation; that way one
can request an abbreviation of a certain length, and Git will comply --
unless doing that would be ambiguous, in which case it returns a longer
abbreviation.)




Acknowledgement sent to Jonas Bernoulli <jonas@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#59011; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 10 Mar 2025 07:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.