GNU bug report logs - #59032
CC Mode 5.35.1 (C/*l); Incorrect fontification of `subsurface' during typing

Previous Next

Package: cc-mode;

Reported by: Po Lu <luangruo <at> yahoo.com>

Date: Sat, 5 Nov 2022 01:36:02 UTC

Severity: normal

Done: Alan Mackenzie <acm <at> muc.de>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59032 in the body.
You can then email your comments to 59032 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-cc-mode <at> gnu.org:
bug#59032; Package cc-mode. (Sat, 05 Nov 2022 01:36:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Po Lu <luangruo <at> yahoo.com>:
New bug report received and forwarded. Copy sent to bug-cc-mode <at> gnu.org. (Sat, 05 Nov 2022 01:36:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: bug-gnu-emacs <at> gnu.org
Subject: CC Mode 5.35.1 (C/*l); Incorrect fontification of `subsurface'
 during typing
Date: Sat, 05 Nov 2022 09:34:41 +0800
Package: cc-mode

Start with the following code in a c-mode buffer:

static struct test_subsurface *
make_test_subsurface (void)
{
  struct test_subsurface *subsurface;

  subsurface = malloc (sizeof *subsurface);

  if (!subsurface)
    goto error_1;

  subsurface->surface
    = wl_compositor_create_surface (display->compositor);

  if (!subsurface->surface)
    goto error_2;

  subsurface->subsurface
    = wl_subcompositor_get_subsurface (subcompositor,
				       wayland_surface,
				       display->surface);
  
 error_2:
  free (subsurface);
 error_1:
  return NULL;
}

move point to the end of the line before "error_2".  Type:

  s u b s u r f a c e - >

then, hesitate for 1 second, and type:

  <backspace> <backspace>

wait 1 more second, then type:

  <up>

every occurrence of "subsurface" above will become fontified as a type,
and will be stuck that way until you make an edit above that occurrence.

Emacs  : GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu)
 of 2022-10-29
Package: CC Mode 5.35.1 (C/*l)
Buffer Style: gnu
c-emacs-features: (pps-extended-state col-0-paren posix-char-classes gen-string-delim gen-comment-delim syntax-properties category-properties 1-bit)

current state:
==============
(setq
 c-basic-offset 2
 c-comment-only-line-offset '(0 . 0)
 c-indent-comment-alist '((anchored-comment column . 0) (end-block space . 1) (cpp-end-block space . 2))
 c-indent-comments-syntactically-p nil
 c-block-comment-prefix ""
 c-comment-prefix-regexp '((pike-mode . "//+!?\\|\\**") (awk-mode . "#+") (other . "//+\\|\\**"))
 c-doc-comment-style '((java-mode . javadoc) (pike-mode . autodoc) (c-mode . gtkdoc) (c++-mode . gtkdoc))
 c-cleanup-list '(scope-operator)
 c-hanging-braces-alist '((substatement-open before after) (arglist-cont-nonempty))
 c-hanging-colons-alist nil
 c-hanging-semi&comma-criteria '(c-semi&comma-inside-parenlist)
 c-backslash-column 48
 c-backslash-max-column 72
 c-special-indent-hook '(t c-gnu-impose-minimum)
 c-label-minimum-indentation 1
 c-offsets-alist '((inexpr-class . +)
		   (inexpr-statement . +)
		   (lambda-intro-cont . +)
		   (inlambda . 0)
		   (template-args-cont c-lineup-template-args +)
		   (incomposition . +)
		   (inmodule . +)
		   (innamespace . +)
		   (inextern-lang . +)
		   (composition-close . 0)
		   (module-close . 0)
		   (namespace-close . 0)
		   (extern-lang-close . 0)
		   (composition-open . 0)
		   (module-open . 0)
		   (namespace-open . 0)
		   (extern-lang-open . 0)
		   (objc-method-call-cont c-lineup-ObjC-method-call-colons c-lineup-ObjC-method-call +)
		   (objc-method-args-cont . c-lineup-ObjC-method-args)
		   (objc-method-intro . [0])
		   (friend . 0)
		   (cpp-define-intro c-lineup-cpp-define +)
		   (cpp-macro-cont . +)
		   (cpp-macro . [0])
		   (inclass . +)
		   (stream-op . c-lineup-streamop)
		   (arglist-cont-nonempty c-lineup-gcc-asm-reg c-lineup-arglist)
		   (arglist-cont c-lineup-gcc-asm-reg 0)
		   (comment-intro c-lineup-knr-region-comment c-lineup-comment)
		   (catch-clause . 0)
		   (else-clause . 0)
		   (do-while-closure . 0)
		   (access-label . -)
		   (case-label . 0)
		   (substatement . +)
		   (statement-case-intro . +)
		   (statement . 0)
		   (brace-entry-open . 0)
		   (brace-list-entry . 0)
		   (brace-list-close . 0)
		   (block-close . 0)
		   (block-open . 0)
		   (inher-cont . c-lineup-multi-inher)
		   (inher-intro . +)
		   (member-init-cont . c-lineup-multi-inher)
		   (member-init-intro . +)
		   (annotation-var-cont . +)
		   (annotation-top-cont . 0)
		   (topmost-intro . 0)
		   (knr-argdecl . 0)
		   (func-decl-cont . +)
		   (inline-close . 0)
		   (class-close . 0)
		   (class-open . 0)
		   (defun-block-intro . +)
		   (defun-close . 0)
		   (defun-open . 0)
		   (c . c-lineup-C-comments)
		   (string . c-lineup-dont-change)
		   (topmost-intro-cont first c-lineup-topmost-intro-cont c-lineup-gnu-DEFUN-intro-cont)
		   (brace-list-intro first c-lineup-2nd-brace-entry-in-arglist c-lineup-class-decl-init-+ +)
		   (brace-list-open . +)
		   (inline-open . 0)
		   (arglist-close . c-lineup-arglist)
		   (arglist-intro . c-lineup-arglist-intro-after-paren)
		   (statement-cont . +)
		   (statement-case-open . +)
		   (label . 0)
		   (substatement-label . 0)
		   (substatement-open . +)
		   (knr-argdecl-intro . 5)
		   (statement-block-intro . +)
		   )
 c-buffer-is-cc-mode 'c-mode
 c-tab-always-indent t
 c-syntactic-indentation t
 c-syntactic-indentation-in-macros t
 c-ignore-auto-fill '(string cpp code)
 c-auto-align-backslashes t
 c-backspace-function 'backward-delete-char-untabify
 c-delete-function 'delete-char
 c-electric-pound-behavior nil
 c-default-style '((java-mode . "java") (awk-mode . "awk") (other . "gnu"))
 c-enable-xemacs-performance-kludge-p nil
 c-old-style-variable-behavior nil
 defun-prompt-regexp nil
 tab-width 8
 comment-column 32
 parse-sexp-ignore-comments t
 parse-sexp-lookup-properties t
 auto-fill-function nil
 comment-multi-line t
 comment-start-skip "\\(?://+\\|/\\*+\\)\\s *"
 fill-prefix nil
 fill-column 70
 paragraph-start "[ 	]*\\(//+\\|\\**\\)[ 	]*$\\|^\f"
 adaptive-fill-mode t
 adaptive-fill-regexp "[ 	]*\\(//+\\|\\**\\)[ 	]*\\([ 	]*\\([-–!|#%;>*·•‣⁃◦]+[ 	]*\\)*\\)"
 )




Information forwarded to bug-cc-mode <at> gnu.org:
bug#59032; Package cc-mode. (Mon, 07 Nov 2022 20:50:01 GMT) Full text and rfc822 format available.

Message #8 received at 59032 <at> debbugs.gnu.org (full text, mbox):

From: Alan Mackenzie <acm <at> muc.de>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 59032 <at> debbugs.gnu.org
Subject: Re: bug#59032: CC Mode 5.35.1 (C/*l); Incorrect fontification of
 `subsurface' during typing
Date: Mon, 7 Nov 2022 20:49:34 +0000
Hello, Po.

Thanks for yet another bug.

On Sat, Nov 05, 2022 at 09:34:41 +0800, Po Lu via CC-Mode-help wrote:
> Package: cc-mode

> Start with the following code in a c-mode buffer:

> static struct test_subsurface *
> make_test_subsurface (void)
> {
>   struct test_subsurface *subsurface;

>   subsurface = malloc (sizeof *subsurface);

>   if (!subsurface)
>     goto error_1;

>   subsurface->surface
>     = wl_compositor_create_surface (display->compositor);

>   if (!subsurface->surface)
>     goto error_2;

>   subsurface->subsurface
>     = wl_subcompositor_get_subsurface (subcompositor,
> 				       wayland_surface,
> 				       display->surface);
  
>  error_2:
>   free (subsurface);
>  error_1:
>   return NULL;
> }

> move point to the end of the line before "error_2".  Type:

>   s u b s u r f a c e - >

> then, hesitate for 1 second, and type:

>   <backspace> <backspace>

> wait 1 more second, then type:

>   <up>

> every occurrence of "subsurface" above will become fontified as a type,
> and will be stuck that way until you make an edit above that occurrence.

I have a fix for this, I think, but it overlaps with an earlier fix to
bug #58883.  I sent you a patch on Sunday 2022-10-30 for this earlier
bug.  Did you get this patch?  If so, have you any reaction to it?

It would help me keep things straight if we could commit that patch to
#58883, and then create another patch for the current bug.

Thanks!

> Emacs  : GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu)
>  of 2022-10-29
> Package: CC Mode 5.35.1 (C/*l)
> Buffer Style: gnu
> c-emacs-features: (pps-extended-state col-0-paren posix-char-classes gen-string-delim gen-comment-delim syntax-properties category-properties 1-bit)

[ .... ]

-- 
Alan Mackenzie (Nuremberg, Germany).




Information forwarded to bug-cc-mode <at> gnu.org:
bug#59032; Package cc-mode. (Tue, 08 Nov 2022 00:26:02 GMT) Full text and rfc822 format available.

Message #11 received at 59032 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Alan Mackenzie <acm <at> muc.de>
Cc: 59032 <at> debbugs.gnu.org
Subject: Re: bug#59032: CC Mode 5.35.1 (C/*l); Incorrect fontification of
 `subsurface' during typing
Date: Tue, 08 Nov 2022 08:25:31 +0800
Alan Mackenzie <acm <at> muc.de> writes:

> Hello, Po.
>
> Thanks for yet another bug.
>
> On Sat, Nov 05, 2022 at 09:34:41 +0800, Po Lu via CC-Mode-help wrote:
>> Package: cc-mode
>
>> Start with the following code in a c-mode buffer:
>
>> static struct test_subsurface *
>> make_test_subsurface (void)
>> {
>>   struct test_subsurface *subsurface;
>
>>   subsurface = malloc (sizeof *subsurface);
>
>>   if (!subsurface)
>>     goto error_1;
>
>>   subsurface->surface
>>     = wl_compositor_create_surface (display->compositor);
>
>>   if (!subsurface->surface)
>>     goto error_2;
>
>>   subsurface->subsurface
>>     = wl_subcompositor_get_subsurface (subcompositor,
>> 				       wayland_surface,
>> 				       display->surface);
>   
>>  error_2:
>>   free (subsurface);
>>  error_1:
>>   return NULL;
>> }
>
>> move point to the end of the line before "error_2".  Type:
>
>>   s u b s u r f a c e - >
>
>> then, hesitate for 1 second, and type:
>
>>   <backspace> <backspace>
>
>> wait 1 more second, then type:
>
>>   <up>
>
>> every occurrence of "subsurface" above will become fontified as a type,
>> and will be stuck that way until you make an edit above that occurrence.
>
> I have a fix for this, I think, but it overlaps with an earlier fix to
> bug #58883.  I sent you a patch on Sunday 2022-10-30 for this earlier
> bug.  Did you get this patch?  If so, have you any reaction to it?

I think it got lost in the bulk mail folder (but I can't find it there
either, so maybe a mailer screwup?)

So would you please send it again?  TIA.




Reply sent to Alan Mackenzie <acm <at> muc.de>:
You have taken responsibility. (Tue, 08 Nov 2022 15:02:02 GMT) Full text and rfc822 format available.

Notification sent to Po Lu <luangruo <at> yahoo.com>:
bug acknowledged by developer. (Tue, 08 Nov 2022 15:02:02 GMT) Full text and rfc822 format available.

Message #16 received at 59032-done <at> debbugs.gnu.org (full text, mbox):

From: Alan Mackenzie <acm <at> muc.de>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 59032-done <at> debbugs.gnu.org
Subject: Re: bug#59032: CC Mode 5.35.1 (C/*l); Incorrect fontification of
 `subsurface' during typing
Date: Tue, 8 Nov 2022 15:01:36 +0000
Hello, Po.

> > On Sat, Nov 05, 2022 at 09:34:41 +0800, Po Lu via CC-Mode-help wrote:
> >> Package: cc-mode

> >> Start with the following code in a c-mode buffer:

> >> static struct test_subsurface *
> >> make_test_subsurface (void)
> >> {
> >>   struct test_subsurface *subsurface;

> >>   subsurface = malloc (sizeof *subsurface);

> >>   if (!subsurface)
> >>     goto error_1;

> >>   subsurface->surface
> >>     = wl_compositor_create_surface (display->compositor);

> >>   if (!subsurface->surface)
> >>     goto error_2;

> >>   subsurface->subsurface
> >>     = wl_subcompositor_get_subsurface (subcompositor,
> >> 				       wayland_surface,
> >> 				       display->surface);

> >>  error_2:
> >>   free (subsurface);
> >>  error_1:
> >>   return NULL;
> >> }

> >> move point to the end of the line before "error_2".  Type:

> >>   s u b s u r f a c e - >

> >> then, hesitate for 1 second, and type:

> >>   <backspace> <backspace>

> >> wait 1 more second, then type:

> >>   <up>

> >> every occurrence of "subsurface" above will become fontified as a type,
> >> and will be stuck that way until you make an edit above that occurrence.

The bug is now fixed.  I'm closing it with this post.

-- 
Alan Mackenzie (Nuremberg, Germany).




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 07 Dec 2022 12:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 112 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.