GNU bug report logs - #59052
[PATCH] gnu: sbcl-triads: Install binary executable.

Previous Next

Package: guix-patches;

Reported by: jgart <jgart <at> dismail.de>

Date: Sat, 5 Nov 2022 14:54:01 UTC

Severity: normal

Tags: patch

Done: Guillaume Le Vaillant <glv <at> posteo.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59052 in the body.
You can then email your comments to 59052 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#59052; Package guix-patches. (Sat, 05 Nov 2022 14:54:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to jgart <jgart <at> dismail.de>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sat, 05 Nov 2022 14:54:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: Guillaume Le Vaillant <glv <at> posteo.net>,
 Charles <charles.b.jackson <at> protonmail.com>, jgart <jgart <at> dismail.de>
Subject: [PATCH] gnu: sbcl-triads: Install binary executable.
Date: Sat,  5 Nov 2022 09:49:26 -0500
* gnu/packages/lisp-xyz.scm (sbcl-triads): Install binary executable.
[arguments]: Install the triads binary executable in a phase.

Co-authored-by: Charles <charles.b.jackson <at> protonmail.com>

Hi Guillaume,

I forgot to add in this phase.

thanks in advance,

jgart
---
 gnu/packages/lisp-xyz.scm | 38 +++++++++++++++++++++++++++-----------
 1 file changed, 27 insertions(+), 11 deletions(-)

diff --git a/gnu/packages/lisp-xyz.scm b/gnu/packages/lisp-xyz.scm
index 98860f131c..34ad0af1fb 100644
--- a/gnu/packages/lisp-xyz.scm
+++ b/gnu/packages/lisp-xyz.scm
@@ -24527,20 +24527,36 @@ (define-public sbcl-triads
          (file-name (git-file-name "cl-triads" version))
          (sha256
           (base32 "146mwshynhdw82m2nxrcjvf1nk0z3fn6ywcd2vqxkly5qricc53w"))))
-      (build-system asdf-build-system/sbcl)
-      (arguments
-       '(#:asd-systems '("charje.triads")))
-      (inputs
-       (list sbcl-cl-str
-             sbcl-serapeum
-             sbcl-trivia))
-      (home-page "https://github.com/charJe/triads")
-      (synopsis "Music composition tool to convert roman numerals into triads")
-      (description "Triads is a simple command line tool that reads roman
+    (build-system asdf-build-system/sbcl)
+    (arguments
+      `(#:asd-systems '("charje.triads")
+        #:phases
+        (modify-phases %standard-phases
+          (replace 'build
+            (lambda* (#:key outputs #:allow-other-keys)
+              (setenv "HOME" (getcwd))
+              (system*
+               "sbcl" "--no-userinit"
+               "--eval" "(require :asdf)"
+               "--eval" (string-append
+                         "(require :charje.triads \""
+                         (getcwd) "/charje.triads.asd\")")
+               "--eval" "(asdf:make :charje.triads)")
+              (install-file (string-append (getcwd) "/triads")
+                            (string-append (assoc-ref outputs "out") "/bin"))))
+          (delete 'check)
+          (delete 'create-asdf-configuration))))
+    (inputs
+      (list sbcl-cl-str
+            sbcl-serapeum
+            sbcl-trivia))
+    (home-page "https://github.com/charJe/triads")
+    (synopsis "Music composition tool to convert roman numerals into triads")
+    (description "Triads is a simple command line tool that reads roman
 numeral notation from standard input (or a file) and an musical key and outputs
 the roman numeral in addition to the notes of the triad associated with that
 roman numeral given in the key.")
-      (license license:gpl3))))
+    (license license:gpl3))))
 
 (define-public cl-triads
   (sbcl-package->cl-source-package sbcl-triads))
-- 
2.38.1





Information forwarded to guix-patches <at> gnu.org:
bug#59052; Package guix-patches. (Sat, 05 Nov 2022 19:09:01 GMT) Full text and rfc822 format available.

Message #8 received at 59052 <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: jgart <jgart <at> dismail.de>
Cc: Charles <charles.b.jackson <at> protonmail.com>, 59052 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: sbcl-triads: Install binary executable.
Date: Sat, 05 Nov 2022 19:02:06 +0000
[Message part 1 (text/plain, inline)]
Hi,

If triads is supposed to be used as a standalone program and not as
a library, it may be better to remove "cl-triads" and "ecl-triads", and
to rename "sbcl-triads" to "triads" and move it to "music.scm".
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#59052; Package guix-patches. (Sat, 05 Nov 2022 19:16:02 GMT) Full text and rfc822 format available.

Message #11 received at 59052 <at> debbugs.gnu.org (full text, mbox):

From: Charles <charles.b.jackson <at> protonmail.com>
To: glv <at> posteo.net, jgart <at> dismail.de
Cc: 59052 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: sbcl-triads: Install binary executable.
Date: Sat, 05 Nov 2022 19:15:06 +0000
[Message part 1 (text/plain, inline)]
It is meant to be a stand alone program, but it could also be used as a library if someone wants the same functionality as part of a larger program.

My personal thought is that there should be the 3 *cl-triads in lisp-xyz.scm and then a triads in music.scm that is installs a binary. I'm not sure what guix standard is about this.

-------- Original Message --------
On Nov 5, 2022, 2:02 PM, Guillaume Le Vaillant wrote:

> Hi, If triads is supposed to be used as a standalone program and not as a library, it may be better to remove "cl-triads" and "ecl-triads", and to rename "sbcl-triads" to "triads" and move it to "music.scm".
[Message part 2 (text/html, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#59052; Package guix-patches. (Sat, 05 Nov 2022 19:18:01 GMT) Full text and rfc822 format available.

Message #14 received at 59052 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: "Charles" <charles.b.jackson <at> protonmail.com>, <glv <at> posteo.net>,
 <jgart <at> dismail.de>
Cc: 59052 <at> debbugs.gnu.org
Subject: Re: [bug#59052] [PATCH] gnu: sbcl-triads: Install binary executable.
Date: Sat, 05 Nov 2022 19:17:50 +0000
On Sat Nov 5, 2022 at 7:15 PM GMT, Charles via Guix-patches via wrote:
> My personal thought is that there should be the 3 *cl-triads in lisp-xyz.scm and then a triads in music.scm that is installs a binary. I'm not sure what guix standard is about this.

How about an output; ``cl-triads:bin''?

    -- (




Information forwarded to guix-patches <at> gnu.org:
bug#59052; Package guix-patches. (Sat, 05 Nov 2022 19:22:01 GMT) Full text and rfc822 format available.

Message #17 received at 59052 <at> debbugs.gnu.org (full text, mbox):

From: Charles <charles.b.jackson <at> protonmail.com>
To: paren <at> disroot.org, glv <at> posteo.net, jgart <at> dismail.de
Cc: 59052 <at> debbugs.gnu.org
Subject: Re: [bug#59052] [PATCH] gnu: sbcl-triads: Install binary executable.
Date: Sat, 05 Nov 2022 19:21:43 +0000
[Message part 1 (text/plain, inline)]
That could work too. sbcl-triads:bin makes more sense though because the tested binary is built with sbcl.
-------- Original Message --------
On Nov 5, 2022, 2:17 PM, ( wrote:

> On Sat Nov 5, 2022 at 7:15 PM GMT, Charles via Guix-patches via wrote: > My personal thought is that there should be the 3 *cl-triads in lisp-xyz.scm and then a triads in music.scm that is installs a binary. I'm not sure what guix standard is about this. How about an output; ``cl-triads:bin''? -- (
[Message part 2 (text/html, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#59052; Package guix-patches. (Sun, 06 Nov 2022 17:25:01 GMT) Full text and rfc822 format available.

Message #20 received at 59052 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: Charles <charles.b.jackson <at> protonmail.com>
Cc: glv <at> posteo.net, paren <at> disroot.org, 59052 <at> debbugs.gnu.org
Subject: Re: [bug#59052] [PATCH] gnu: sbcl-triads: Install binary executable.
Date: Sun, 6 Nov 2022 11:24:21 -0600
On Sat, 05 Nov 2022 19:21:43 +0000 Charles <charles.b.jackson <at> protonmail.com> wrote:
> > On Sat Nov 5, 2022 at 7:15 PM GMT, Charles via Guix-patches via wrote: > My personal thought is that there should be the 3 *cl-triads in lisp-xyz.scm and then a triads in music.scm that is installs a binary. I'm not sure what guix standard is about this. How about an output; ``cl-triads:bin''? -- (

> I'm not sure what guix standard is about this.

Hi, how would we like to proceed?

I'm fine with either approach. Charles, would you like to send an update
patch for your approach? I might need about a weekish to get back to this.




Information forwarded to guix-patches <at> gnu.org:
bug#59052; Package guix-patches. (Wed, 14 Dec 2022 05:08:02 GMT) Full text and rfc822 format available.

Message #23 received at 59052 <at> debbugs.gnu.org (full text, mbox):

From: Charles <Charles.b.jackson <at> proton.me>
To: "59052 <at> debbugs.gnu.org" <59052 <at> debbugs.gnu.org>
Subject: Add sbcl-triads:bin patch
Date: Wed, 14 Dec 2022 05:06:48 +0000
[Message part 1 (text/plain, inline)]
It seems like a :bin suffix is the usuall way. This also opens up the possibility of ecl-triads:bin, and even ccl-triads:bin, clasp-triads:bin, abcl-triads:bin.
[0001-gnu-sbcl-triads-Add-bin-output.patch (text/x-patch, attachment)]

Reply sent to Guillaume Le Vaillant <glv <at> posteo.net>:
You have taken responsibility. (Mon, 19 Dec 2022 13:27:02 GMT) Full text and rfc822 format available.

Notification sent to jgart <jgart <at> dismail.de>:
bug acknowledged by developer. (Mon, 19 Dec 2022 13:27:02 GMT) Full text and rfc822 format available.

Message #28 received at 59052-done <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: Charles <Charles.b.jackson <at> proton.me>
Cc: 59052-done <at> debbugs.gnu.org
Subject: Re: [bug#59052] Add sbcl-triads:bin patch
Date: Mon, 19 Dec 2022 13:25:03 +0000
[Message part 1 (text/plain, inline)]
Patch pushed as 89a8534b425817640c3e168399543b7f6e10b5a7.
Thanks.
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 17 Jan 2023 12:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 71 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.