GNU bug report logs - #59070
CC Mode 5.35.1 (C/*l); Failure to completely fontify struct type

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59070 in the body.
You can then email your comments to 59070 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: bug-gnu-emacs <at> gnu.org
Subject: CC Mode 5.35.1 (C/*l); Failure to completely fontify struct type
Date: Sun, 06 Nov 2022 15:56:15 +0800

Package: cc-mode

Start with the following text in a c-mode buffer:

static const struct test_seat_controller_interface seat_controller_impl =
  {
    .destroy = DestroyTestSeatController,
    .bind_seat = BindSeat,
    .get_XIModifierState = GetXIModifierState,
    .get_XIButtonState = GetXIButtonState,
    .get_XIValuatorState = GetXIValuatorState,
    .dispatch_XI_Enter = DispatchXIEnter,
    .dispatch_XI_Leave = DispatchXILeave,
    .dispatch_XI_Motion = DispatchXIMotion,
    .dispatch_XI_ButtonPress = DispatchXIButtonPress,
    .dispatch_XI_ButtonRelease = DispatchXIButtonRelease,
  };

move point to the end of the line reading ".dispatch_XI_ButtonPress =
DispatchXIButtonRelease", and then type RET.  At that point,
"test_seat_controller_interface" will no longer be completely fontified
as a type.

Emacs  : GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu)
 of 2022-10-29
Package: CC Mode 5.35.1 (C/*l)
Buffer Style: gnu
c-emacs-features: (pps-extended-state col-0-paren posix-char-classes gen-string-delim gen-comment-delim syntax-properties category-properties 1-bit)

current state:
==============
(setq
 c-basic-offset 2
 c-comment-only-line-offset '(0 . 0)
 c-indent-comment-alist '((anchored-comment column . 0) (end-block space . 1) (cpp-end-block space . 2))
 c-indent-comments-syntactically-p nil
 c-block-comment-prefix ""
 c-comment-prefix-regexp '((pike-mode . "//+!?\\|\\**") (awk-mode . "#+") (other . "//+\\|\\**"))
 c-doc-comment-style '((java-mode . javadoc) (pike-mode . autodoc) (c-mode . gtkdoc) (c++-mode . gtkdoc))
 c-cleanup-list '(scope-operator)
 c-hanging-braces-alist '((substatement-open before after) (arglist-cont-nonempty))
 c-hanging-colons-alist nil
 c-hanging-semi&comma-criteria '(c-semi&comma-inside-parenlist)
 c-backslash-column 48
 c-backslash-max-column 72
 c-special-indent-hook '(t c-gnu-impose-minimum)
 c-label-minimum-indentation 1
 c-offsets-alist '((inexpr-class . +)
		   (inexpr-statement . +)
		   (lambda-intro-cont . +)
		   (inlambda . 0)
		   (template-args-cont c-lineup-template-args +)
		   (incomposition . +)
		   (inmodule . +)
		   (innamespace . +)
		   (inextern-lang . +)
		   (composition-close . 0)
		   (module-close . 0)
		   (namespace-close . 0)
		   (extern-lang-close . 0)
		   (composition-open . 0)
		   (module-open . 0)
		   (namespace-open . 0)
		   (extern-lang-open . 0)
		   (objc-method-call-cont c-lineup-ObjC-method-call-colons c-lineup-ObjC-method-call +)
		   (objc-method-args-cont . c-lineup-ObjC-method-args)
		   (objc-method-intro . [0])
		   (friend . 0)
		   (cpp-define-intro c-lineup-cpp-define +)
		   (cpp-macro-cont . +)
		   (cpp-macro . [0])
		   (inclass . +)
		   (stream-op . c-lineup-streamop)
		   (arglist-cont-nonempty c-lineup-gcc-asm-reg c-lineup-arglist)
		   (arglist-cont c-lineup-gcc-asm-reg 0)
		   (comment-intro c-lineup-knr-region-comment c-lineup-comment)
		   (catch-clause . 0)
		   (else-clause . 0)
		   (do-while-closure . 0)
		   (access-label . -)
		   (case-label . 0)
		   (substatement . +)
		   (statement-case-intro . +)
		   (statement . 0)
		   (brace-entry-open . 0)
		   (brace-list-entry . 0)
		   (brace-list-close . 0)
		   (block-close . 0)
		   (block-open . 0)
		   (inher-cont . c-lineup-multi-inher)
		   (inher-intro . +)
		   (member-init-cont . c-lineup-multi-inher)
		   (member-init-intro . +)
		   (annotation-var-cont . +)
		   (annotation-top-cont . 0)
		   (topmost-intro . 0)
		   (knr-argdecl . 0)
		   (func-decl-cont . +)
		   (inline-close . 0)
		   (class-close . 0)
		   (class-open . 0)
		   (defun-block-intro . +)
		   (defun-close . 0)
		   (defun-open . 0)
		   (c . c-lineup-C-comments)
		   (string . c-lineup-dont-change)
		   (topmost-intro-cont first c-lineup-topmost-intro-cont c-lineup-gnu-DEFUN-intro-cont)
		   (brace-list-intro first c-lineup-2nd-brace-entry-in-arglist c-lineup-class-decl-init-+ +)
		   (brace-list-open . +)
		   (inline-open . 0)
		   (arglist-close . c-lineup-arglist)
		   (arglist-intro . c-lineup-arglist-intro-after-paren)
		   (statement-cont . +)
		   (statement-case-open . +)
		   (label . 0)
		   (substatement-label . 0)
		   (substatement-open . +)
		   (knr-argdecl-intro . 5)
		   (statement-block-intro . +)
		   )
 c-buffer-is-cc-mode 'c-mode
 c-tab-always-indent t
 c-syntactic-indentation t
 c-syntactic-indentation-in-macros t
 c-ignore-auto-fill '(string cpp code)
 c-auto-align-backslashes t
 c-backspace-function 'backward-delete-char-untabify
 c-delete-function 'delete-char
 c-electric-pound-behavior nil
 c-default-style '((java-mode . "java") (awk-mode . "awk") (other . "gnu"))
 c-enable-xemacs-performance-kludge-p nil
 c-old-style-variable-behavior nil
 defun-prompt-regexp nil
 tab-width 8
 comment-column 32
 parse-sexp-ignore-comments t
 parse-sexp-lookup-properties t
 auto-fill-function nil
 comment-multi-line t
 comment-start-skip "\\(?://+\\|/\\*+\\)\\s *"
 fill-prefix nil
 fill-column 70
 paragraph-start "[ 	]*\\(//+\\|\\**\\)[ 	]*$\\|^\f"
 adaptive-fill-mode t
 adaptive-fill-regexp "[ 	]*\\(//+\\|\\**\\)[ 	]*\\([ 	]*\\([-–!|#%;>*·•‣⁃◦]+[ 	]*\\)*\\)"
 )

Message #8 received at 59070 <at> debbugs.gnu.org (full text, mbox):

From: Alan Mackenzie <acm <at> muc.de>
To: Po Lu <luangruo <at> yahoo.com>
Cc: acm <at> muc.de, 59070 <at> debbugs.gnu.org
Subject: Re: bug#59070: CC Mode 5.35.1 (C/*l); Failure to completely fontify
 struct type
Date: Wed, 9 Nov 2022 12:45:34 +0000

[Message part 1 (text/plain, inline)]

Hello, Po.

On Sun, Nov 06, 2022 at 15:56:15 +0800, Po Lu via CC-Mode-help wrote:
> Package: cc-mode

> Start with the following text in a c-mode buffer:

> static const struct test_seat_controller_interface seat_controller_impl =
>   {
>     .destroy = DestroyTestSeatController,
>     .bind_seat = BindSeat,
>     .get_XIModifierState = GetXIModifierState,
>     .get_XIButtonState = GetXIButtonState,
>     .get_XIValuatorState = GetXIValuatorState,
>     .dispatch_XI_Enter = DispatchXIEnter,
>     .dispatch_XI_Leave = DispatchXILeave,
>     .dispatch_XI_Motion = DispatchXIMotion,
>     .dispatch_XI_ButtonPress = DispatchXIButtonPress,
>     .dispatch_XI_ButtonRelease = DispatchXIButtonRelease,
>   };

> move point to the end of the line reading ".dispatch_XI_ButtonPress =
> DispatchXIButtonRelease", and then type RET.  At that point,
> "test_seat_controller_interface" will no longer be completely fontified
> as a type.

Yes.  The position inside that identifier where the fontification
stopped was exactly 500 characters back from the start of the new line.
This made it easy to locate a 500 in the Lisp source causing it.  It
turned out to be an off-by-one error.

Would you please apply the attached patch, and confirm the bug is fixed
(or say what's still wrong).

Thanks!

> Emacs  : GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu)
>  of 2022-10-29
> Package: CC Mode 5.35.1 (C/*l)
> Buffer Style: gnu
> c-emacs-features: (pps-extended-state col-0-paren posix-char-classes gen-string-delim gen-comment-delim syntax-properties category-properties 1-bit)

[ .... ]

-- 
Alan Mackenzie (Nuremberg, Germany).

[diff.20221109.diff (text/plain, attachment)]

Message #11 received at 59070 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Alan Mackenzie <acm <at> muc.de>
Cc: 59070 <at> debbugs.gnu.org
Subject: Re: bug#59070: CC Mode 5.35.1 (C/*l); Failure to completely fontify
 struct type
Date: Thu, 10 Nov 2022 10:54:23 +0800

Alan Mackenzie <acm <at> muc.de> writes:

> Hello, Po.
>
> On Sun, Nov 06, 2022 at 15:56:15 +0800, Po Lu via CC-Mode-help wrote:
>> Package: cc-mode
>
>> Start with the following text in a c-mode buffer:
>
>> static const struct test_seat_controller_interface seat_controller_impl =
>>   {
>>     .destroy = DestroyTestSeatController,
>>     .bind_seat = BindSeat,
>>     .get_XIModifierState = GetXIModifierState,
>>     .get_XIButtonState = GetXIButtonState,
>>     .get_XIValuatorState = GetXIValuatorState,
>>     .dispatch_XI_Enter = DispatchXIEnter,
>>     .dispatch_XI_Leave = DispatchXILeave,
>>     .dispatch_XI_Motion = DispatchXIMotion,
>>     .dispatch_XI_ButtonPress = DispatchXIButtonPress,
>>     .dispatch_XI_ButtonRelease = DispatchXIButtonRelease,
>>   };
>
>> move point to the end of the line reading ".dispatch_XI_ButtonPress =
>> DispatchXIButtonRelease", and then type RET.  At that point,
>> "test_seat_controller_interface" will no longer be completely fontified
>> as a type.
>
> Yes.  The position inside that identifier where the fontification
> stopped was exactly 500 characters back from the start of the new line.
> This made it easy to locate a 500 in the Lisp source causing it.  It
> turned out to be an off-by-one error.
>
> Would you please apply the attached patch, and confirm the bug is fixed
> (or say what's still wrong).
>
> Thanks!
>
>> Emacs  : GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu)
>>  of 2022-10-29
>> Package: CC Mode 5.35.1 (C/*l)
>> Buffer Style: gnu
>> c-emacs-features: (pps-extended-state col-0-paren posix-char-classes gen-string-delim gen-comment-delim syntax-properties category-properties 1-bit)
>
> [ .... ]

That seems to work here, thanks.

Message #16 received at 59070-done <at> debbugs.gnu.org (full text, mbox):

From: Alan Mackenzie <acm <at> muc.de>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 59070-done <at> debbugs.gnu.org
Subject: Re: bug#59070: CC Mode 5.35.1 (C/*l); Failure to completely fontify
 struct type
Date: Thu, 10 Nov 2022 10:19:29 +0000

Hello, Po.

On Thu, Nov 10, 2022 at 10:54:23 +0800, Po Lu wrote:
> Alan Mackenzie <acm <at> muc.de> writes:

> > On Sun, Nov 06, 2022 at 15:56:15 +0800, Po Lu via CC-Mode-help wrote:

[ .... ]

> > Would you please apply the attached patch, and confirm the bug is fixed
> > (or say what's still wrong).

> > Thanks!

[ .... ]

> That seems to work here, thanks.

Thanks!  I've committed the patch, and I'm closing the bug with this
post.

-- 
Alan Mackenzie (Nuremberg, Germany).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.