GNU bug report logs - #59092
[PATCH] gnu: Add motif

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59092 in the body.
You can then email your comments to 59092 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add motif
Date: Sun, 6 Nov 2022 21:02:25 -0800

[Message part 1 (text/plain, inline)]

[0001-gnu-Add-motif.patch (text/x-patch, attachment)]

Message #10 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Andy Tai <atai <at> atai.org>
Cc: 59092 <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#59092] [PATCH] gnu: Add motif
Date: Thu, 17 Nov 2022 11:35:20 +0000

[Message part 1 (text/plain, inline)]

Andy Tai <atai <at> atai.org> writes:

Subject: [PATCH] gnu: Add motif

> * gnu/packages/lesstif.scm (motif): New variable
> ---
>  gnu/packages/lesstif.scm | 40 +++++++++++++++++++++++++++++++++++++++-
>  1 file changed, 39 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/lesstif.scm b/gnu/packages/lesstif.scm
> index 8f017f41be..7a53c1a9ee 100644
> --- a/gnu/packages/lesstif.scm
> +++ b/gnu/packages/lesstif.scm
> @@ -1,5 +1,6 @@
>  ;;; GNU Guix --- Functional package management for GNU
>  ;;; Copyright © 2013 Andreas Enge <andreas <at> enge.fr>
> +;;; Copyright © 2022 Andy Tai <atai <at> atai.org>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -21,7 +22,15 @@ (define-module (gnu packages lesstif)
>    #:use-module (guix packages)
>    #:use-module (guix download)
>    #:use-module (guix build-system gnu)
> -  #:use-module (gnu packages xorg))
> +  #:use-module (guix git-download)
> +  #:use-module (gnu packages autotools)
> +  #:use-module (gnu packages c)
> +  #:use-module (gnu packages flex)
> +  #:use-module (gnu packages fontutils)
> +  #:use-module (gnu packages pkg-config)
> +  #:use-module (gnu packages xorg)
> +
> +  )

There's a needless line here.

>  (define-public lesstif
> @@ -46,3 +55,32 @@ (define-public lesstif
>      (synopsis "Clone of the Motif toolkit for the X window system")
>      (description "Clone of the Motif toolkit for the X window system.")
>      (license license:gpl2+))) ; some files are lgpl2.1+ or x11
> +
> +
> +(define-public motif
> +  (let ((commit   "59858b0811e8d9dfaeb142f2b5a96f55482be1ed")
> +        (revision "0"))
> +      (package
> +        (name "motif")
> +        (version (git-version "2.3.8" revision commit))
> +        (source
> +          (origin
> +            (method git-fetch)
> +            (uri (git-reference
> +                    (url "https://git.code.sf.net/p/motif/code")
> +                    (commit commit)))
> +            (file-name (git-file-name name version))
> +            (sha256
> +              (base32
> +                "0yycq0vzga9qmgbfzn2d02ilpwxixwdv2j1d8sddl4dripcrg21m"))))
> +        (build-system gnu-build-system)
> +        (inputs
> +          (list libx11 xorgproto ))

I'd remove the space after xorgproto.

> +        (propagated-inputs
> +          (list fontconfig freetype libxext libxft libxpm libxt xbitmaps))
> +        (native-inputs
> +            (list autoconf automake byacc flex  libtool pkg-config))
> +        (home-page "https://motif.ics.com/motif")
> +        (synopsis "Motif toolkit for the X window system")
> +        (description "The Motif toolkit for the X window system.")

Would you be able to write a different description? It's nice if it
doesn't just repeat the synopsis.

Thanks,

Chris

[signature.asc (application/pgp-signature, inline)]

Message #18 received at 59092 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <lichengtai <at> gmail.com>
To: 59092 <at> debbugs.gnu.org
Subject: updated patch
Date: Thu, 22 Dec 2022 22:34:35 -0800

[Message part 1 (text/plain, inline)]

comments addressed

[0001-gnu-Add-motif.patch (text/x-patch, attachment)]

Message #23 received at 59092 <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: Andy Tai <lichengtai <at> gmail.com>
Cc: 59092 <at> debbugs.gnu.org
Subject: Re: bug#59092: [PATCH] gnu: Add motif
Date: Mon, 09 Jan 2023 13:19:02 +0100

Hi,

The recipe LGTM but

 1. I have not tried to build it,
 2. I have not given a quick look to the source.
 

On jeu., 22 déc. 2022 at 22:34, Andy Tai <lichengtai <at> gmail.com> wrote:
> +(define-public motif
> +  (let ((commit   "59858b0811e8d9dfaeb142f2b5a96f55482be1ed")
> +        (revision "0"))
> +      (package
> +        (name "motif")
> +        (version (git-version "2.3.8" revision commit))

Maybe it could helpful for later update to mention with a comment why
this commit is required and the release version is not enough.

> +        (source
> +          (origin
> +            (method git-fetch)
> +            (uri (git-reference
> +                    (url "https://git.code.sf.net/p/motif/code")
> +                    (commit commit)))
> +            (file-name (git-file-name name version))
> +            (sha256
> +              (base32
> +                "0yycq0vzga9qmgbfzn2d02ilpwxixwdv2j1d8sddl4dripcrg21m"))))
> +        (build-system gnu-build-system)
> +        (inputs
> +          (list libx11 xorgproto))
> +        (propagated-inputs
> +          (list fontconfig freetype libxext libxft libxpm libxt xbitmaps))
> +        (native-inputs
> +            (list autoconf automake byacc flex  libtool pkg-config))
                                                --^
                                       Extra space

Here, an extra space. :-)

> +        (home-page "https://motif.ics.com/motif")
> +        (synopsis "Motif toolkit for the X window system")
> +        (description "Motif is the industry standard graphical user interface, (as

Usually, we try to avoid such “the industry” and instead only “Motif is
a standard graphical user interface, …”

And the linter [1] complains about «description Validate package
descriptions sentences in description should be followed by two spaces;
possible infractions at 155, 343».

1: <https://qa.guix.gnu.org/issue/59092>

Cheers,
simon

Message #26 received at 59092 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: 59092 <at> debbugs.gnu.org
Subject: Re: bug#59092: [PATCH] gnu: Add motif
Date: Tue, 10 Jan 2023 12:35:40 -0800

Thanks for the review.  The "industry standard" wording was copied
from the upstream description.  Unsure of what is Guix's policy of
using upstream wordings as they are or these should be changed per our
opinion.  In this case I will follow your suggestion

On Mon, Jan 9, 2023 at 4:20 AM Simon Tournier <zimon.toutoune <at> gmail.com> wrote:
>
>
> > +        (home-page "https://motif.ics.com/motif")
> > +        (synopsis "Motif toolkit for the X window system")
> > +        (description "Motif is the industry standard graphical user interface, (as
>
> Usually, we try to avoid such “the industry” and instead only “Motif is
> a standard graphical user interface, …”
>

Message #29 received at 59092 <at> debbugs.gnu.org (full text, mbox):

From: Andy Tai <atai <at> atai.org>
To: Simon Tournier <zimon.toutoune <at> gmail.com>
Cc: 59092 <at> debbugs.gnu.org
Subject: Re: bug#59092: [PATCH] gnu: Add motif
Date: Tue, 10 Jan 2023 21:46:45 +0000

[Message part 1 (text/plain, inline)]

updated patch

[0001-gnu-Add-motif.patch (text/x-patch, attachment)]

Message #34 received at 59092-done <at> debbugs.gnu.org (full text, mbox):

From: Simon Tournier <zimon.toutoune <at> gmail.com>
To: Andy Tai <atai <at> atai.org>
Cc: 59092-done <at> debbugs.gnu.org
Subject: Re: [bug#59092] [PATCH] gnu: Add motif
Date: Wed, 11 Jan 2023 15:51:47 +0100

Hi,

On mar., 10 janv. 2023 at 21:46, Andy Tai <atai <at> atai.org> wrote:

> From afd23adac9ba2165cc28afcc6b0de088c8b17dc2 Mon Sep 17 00:00:00 2001
> From: Andy Tai <atai <at> atai.org>
> Date: Tue, 10 Jan 2023 21:42:15 +0000
> Subject: [PATCH] gnu: Add motif
>
> * gnu/packages/lesstif.scm (motif): New variable

Close because included with [PATCH v2] of #59093.

Cheers,
simon

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.