GNU bug report logs - #59138
Eglot support for java-language-server

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59138 in the body.
You can then email your comments to 59138 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Robert Brown <robert.brown <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: Eglot support for java-language-server
Date: Tue, 8 Nov 2022 19:34:35 -0500

[Message part 1 (text/plain, inline)]

The attached patch adds Eglot support for Java LSP server
https://github.com/georgewfraser/java-language-server

[0001-Support-for-java-language-server.patch (text/x-patch, attachment)]

Message #8 received at 59138 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Robert Brown <robert.brown <at> gmail.com>, 59138 <at> debbugs.gnu.org
Cc: joaotavora <at> gmail.com
Subject: Re: bug#59138: Eglot support for java-language-server
Date: Wed, 9 Nov 2022 07:14:54 -0800

Robert Brown <robert.brown <at> gmail.com> writes:

> The attached patch adds Eglot support for Java LSP server
> https://github.com/georgewfraser/java-language-server
> From 8c874c0f277e2e1b85126120da9dcc54e4a938f8 Mon Sep 17 00:00:00 2001
> From: Robert Brown <robert.brown <at> gmail.com>
> Date: Tue, 8 Nov 2022 19:23:10 -0500
> Subject: [PATCH] Support for java-language-server
>
>  * lisp/progmodes/eglot.el (eglot-server-programs): Add support for
>    Java server https://github.com/georgewfraser/java-language-server
> ---
>  lisp/progmodes/eglot.el | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
> index ce989b5611..199c832f6b 100644
> --- a/lisp/progmodes/eglot.el
> +++ b/lisp/progmodes/eglot.el
> @@ -209,7 +209,8 @@ eglot-server-programs
>                                  (go-mode . ("gopls"))
>                                  ((R-mode ess-r-mode) . ("R" "--slave" "-e"
>                                                          "languageserver::run()"))
> -                                (java-mode . ("jdtls"))
> +                                (java-mode
> +                                 . ,(eglot-alternatives '("jdtls" "java-language-server")))

Thanks for the patch.

Is there any particular reason why we should prefer jdtls to
java-language-server?

>                                  (dart-mode . ("dart" "language-server"
>                                                "--client-id" "emacs.eglot-dart"))
>                                  (elixir-mode . ("language_server.sh"))
> --
> 2.25.1

Message #11 received at 59138 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Robert Brown <robert.brown <at> gmail.com>, 59138 <at> debbugs.gnu.org
Cc: joaotavora <at> gmail.com
Subject: Re: bug#59138: Eglot support for java-language-server
Date: Wed, 9 Nov 2022 08:07:29 -0800

[Please use "Reply to all" so that the discussion is recorded in the bug
tracker.]

Robert Brown <robert.brown <at> gmail.com> writes:

> I don't know what the relative popularity is.  I found j-l-s to be
> easier to compile and configure for environments that are not Maven or
> Gradle.  I think jdtls may have more features.

Thanks, that's good enough for me.

Have you signed the copyright assignment?  I see one previous change
from you, so I'm not sure if this latest patch would take us over the
limit for what we could accept without one.  Eli, any comments?

commit 96db005527ef9d9c45c5ec8e91b01e91ee37a7fd
Author: Robert Brown (tiny change) <robert.brown <at> gmail.com>
Date:   Thu Jun 19 10:03:45 2014 -0400

    * etc/NEWS: New Tramp method "nc".

    * lisp/emacs-lisp/lisp-mode.el (lisp-string-after-doc-keyword-p): New fun.
    (lisp-string-in-doc-position-p): New function, extracted from
    lisp-font-lock-syntactic-face-function.
    (lisp-font-lock-syntactic-face-function): Use them.

    Fixes: debbugs:9130

 etc/NEWS                     |  3 +++
 lisp/ChangeLog               |  7 +++++++
 lisp/emacs-lisp/lisp-mode.el | 64
++++++++++++++++++++++++++++++++++++++--------------------------
 3 files changed, 48 insertions(+), 26 deletions(-)

Message #14 received at 59138 <at> debbugs.gnu.org (full text, mbox):

From: Robert Brown <robert.brown <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 59138 <at> debbugs.gnu.org,
 João Távora <joaotavora <at> gmail.com>
Subject: Re: bug#59138: Eglot support for java-language-server
Date: Wed, 9 Nov 2022 11:25:40 -0500

[Message part 1 (text/plain, inline)]

Not sure if I have signed a copyright assignment.  Would have been a long
time ago.  My email address would have been @bibliotech.com.


On Wed, Nov 9, 2022, 11:07 AM Stefan Kangas <stefankangas <at> gmail.com> wrote:

> [Please use "Reply to all" so that the discussion is recorded in the bug
> tracker.]
>
> Robert Brown <robert.brown <at> gmail.com> writes:
>
> > I don't know what the relative popularity is.  I found j-l-s to be
> > easier to compile and configure for environments that are not Maven or
> > Gradle.  I think jdtls may have more features.
>
> Thanks, that's good enough for me.
>
> Have you signed the copyright assignment?  I see one previous change
> from you, so I'm not sure if this latest patch would take us over the
> limit for what we could accept without one.  Eli, any comments?
>
> commit 96db005527ef9d9c45c5ec8e91b01e91ee37a7fd
> Author: Robert Brown (tiny change) <robert.brown <at> gmail.com>
> Date:   Thu Jun 19 10:03:45 2014 -0400
>
>     * etc/NEWS: New Tramp method "nc".
>
>     * lisp/emacs-lisp/lisp-mode.el (lisp-string-after-doc-keyword-p): New
> fun.
>     (lisp-string-in-doc-position-p): New function, extracted from
>     lisp-font-lock-syntactic-face-function.
>     (lisp-font-lock-syntactic-face-function): Use them.
>
>     Fixes: debbugs:9130
>
>  etc/NEWS                     |  3 +++
>  lisp/ChangeLog               |  7 +++++++
>  lisp/emacs-lisp/lisp-mode.el | 64
> ++++++++++++++++++++++++++++++++++++++--------------------------
>  3 files changed, 48 insertions(+), 26 deletions(-)
>

[Message part 2 (text/html, inline)]

Message #17 received at 59138 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Robert Brown <robert.brown <at> gmail.com>
Cc: 59138 <at> debbugs.gnu.org, Stefan Kangas <stefankangas <at> gmail.com>
Subject: Re: bug#59138: Eglot support for java-language-server
Date: Wed, 9 Nov 2022 16:58:08 +0000

[Message part 1 (text/plain, inline)]

I can search for that address later in the copyright file. Your very simple
patch can go in regardless, marked as "Copyright-paperwork-exempt: Yes".

João

On Wed, Nov 9, 2022, 16:25 Robert Brown <robert.brown <at> gmail.com> wrote:

> Not sure if I have signed a copyright assignment.  Would have been a long
> time ago.  My email address would have been @bibliotech.com.
>
>
> On Wed, Nov 9, 2022, 11:07 AM Stefan Kangas <stefankangas <at> gmail.com>
> wrote:
>
>> [Please use "Reply to all" so that the discussion is recorded in the bug
>> tracker.]
>>
>> Robert Brown <robert.brown <at> gmail.com> writes:
>>
>> > I don't know what the relative popularity is.  I found j-l-s to be
>> > easier to compile and configure for environments that are not Maven or
>> > Gradle.  I think jdtls may have more features.
>>
>> Thanks, that's good enough for me.
>>
>> Have you signed the copyright assignment?  I see one previous change
>> from you, so I'm not sure if this latest patch would take us over the
>> limit for what we could accept without one.  Eli, any comments?
>>
>> commit 96db005527ef9d9c45c5ec8e91b01e91ee37a7fd
>> Author: Robert Brown (tiny change) <robert.brown <at> gmail.com>
>> Date:   Thu Jun 19 10:03:45 2014 -0400
>>
>>     * etc/NEWS: New Tramp method "nc".
>>
>>     * lisp/emacs-lisp/lisp-mode.el (lisp-string-after-doc-keyword-p): New
>> fun.
>>     (lisp-string-in-doc-position-p): New function, extracted from
>>     lisp-font-lock-syntactic-face-function.
>>     (lisp-font-lock-syntactic-face-function): Use them.
>>
>>     Fixes: debbugs:9130
>>
>>  etc/NEWS                     |  3 +++
>>  lisp/ChangeLog               |  7 +++++++
>>  lisp/emacs-lisp/lisp-mode.el | 64
>> ++++++++++++++++++++++++++++++++++++++--------------------------
>>  3 files changed, 48 insertions(+), 26 deletions(-)
>>
>

[Message part 2 (text/html, inline)]

Message #20 received at 59138 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Robert Brown <robert.brown <at> gmail.com>
Cc: 59138 <at> debbugs.gnu.org, stefankangas <at> gmail.com, joaotavora <at> gmail.com
Subject: Re: bug#59138: Eglot support for java-language-server
Date: Wed, 09 Nov 2022 19:00:13 +0200

> Cc: 59138 <at> debbugs.gnu.org,
>  João Távora <joaotavora <at> gmail.com>
> From: Robert Brown <robert.brown <at> gmail.com>
> Date: Wed, 9 Nov 2022 11:25:40 -0500
> 
> Not sure if I have signed a copyright assignment.  Would have been a long time ago.  My email address
> would have been @bibliotech.com.

I see an old disclaimer for you, but without any email address, and
only for a single source file.

I think it is best to start the assignment process now, if it's okay
with you.  If instead you'd like first to find out what is the status
of that old disclaimer, please write to Craig Topham
<copyright-clerk <at> fsf.org> and ask him.

Thanks.

Message #27 received at 59138 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 59138 <at> debbugs.gnu.org, Robert Brown <robert.brown <at> gmail.com>,
 joaotavora <at> gmail.com
Subject: Re: bug#59138: Eglot support for java-language-server
Date: Fri, 25 Nov 2022 00:15:02 -0800

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: 59138 <at> debbugs.gnu.org,
>>  João Távora <joaotavora <at> gmail.com>
>> From: Robert Brown <robert.brown <at> gmail.com>
>> Date: Wed, 9 Nov 2022 11:25:40 -0500
>>
>> Not sure if I have signed a copyright assignment.  Would have been a long time ago.  My email address
>> would have been @bibliotech.com.
>
> I see an old disclaimer for you, but without any email address, and
> only for a single source file.
>
> I think it is best to start the assignment process now, if it's okay
> with you.  If instead you'd like first to find out what is the status
> of that old disclaimer, please write to Craig Topham
> <copyright-clerk <at> fsf.org> and ask him.

That was two weeks ago.  Robert, what do you think?

Message #30 received at 59138 <at> debbugs.gnu.org (full text, mbox):

From: Robert Brown <robert.brown <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 59138 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>, joaotavora <at> gmail.com
Subject: Re: bug#59138: Eglot support for java-language-server
Date: Fri, 2 Dec 2022 20:06:24 -0500

Please forward copyright assignment forms to me or send me a pointer
to the specific agreement you'd like me to sign.
Thanks!

On Fri, Nov 25, 2022 at 3:15 AM Stefan Kangas <stefankangas <at> gmail.com> wrote:
>
> Eli Zaretskii <eliz <at> gnu.org> writes:
>
> >> Cc: 59138 <at> debbugs.gnu.org,
> >>  João Távora <joaotavora <at> gmail.com>
> >> From: Robert Brown <robert.brown <at> gmail.com>
> >> Date: Wed, 9 Nov 2022 11:25:40 -0500
> >>
> >> Not sure if I have signed a copyright assignment.  Would have been a long time ago.  My email address
> >> would have been @bibliotech.com.
> >
> > I see an old disclaimer for you, but without any email address, and
> > only for a single source file.
> >
> > I think it is best to start the assignment process now, if it's okay
> > with you.  If instead you'd like first to find out what is the status
> > of that old disclaimer, please write to Craig Topham
> > <copyright-clerk <at> fsf.org> and ask him.
>
> That was two weeks ago.  Robert, what do you think?

Message #33 received at 59138 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Robert Brown <robert.brown <at> gmail.com>
Cc: 59138 <at> debbugs.gnu.org, Eli Zaretskii <eliz <at> gnu.org>, joaotavora <at> gmail.com
Subject: Re: bug#59138: Eglot support for java-language-server
Date: Fri, 2 Dec 2022 19:14:40 -0800

Robert Brown <robert.brown <at> gmail.com> writes:

> Please forward copyright assignment forms to me or send me a pointer
> to the specific agreement you'd like me to sign.
> Thanks!

Great!  See below.


Please email the following information to assign <at> gnu.org, and we
will send you the assignment form for your past and future changes.

Please use your full legal name (in ASCII characters) as the subject
line of the message.
----------------------------------------------------------------------
REQUEST: SEND FORM FOR PAST AND FUTURE CHANGES

[What is the name of the program or package you're contributing to?]
Emacs

[Did you copy any files or text written by someone else in these changes?
Even if that material is free software, we need to know about it.]

[Do you have an employer who might have a basis to claim to own
your changes?  Do you attend a school which might make such a claim?]

[For the copyright registration, what country are you a citizen of?]

[What year were you born?]

[Please write your email address here.]

[Please write your postal address here.]

[Which files have you changed so far, and which new files have you written
so far?]

Message #40 received at 59138-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Robert Brown <robert.brown <at> gmail.com>
Cc: 59138-done <at> debbugs.gnu.org
Subject: Re: bug#59138: Eglot support for java-language-server
Date: Tue, 11 Feb 2025 19:23:35 -0800

Version: 30.1

Robert Brown <robert.brown <at> gmail.com> writes:

> The attached patch adds Eglot support for Java LSP server
> https://github.com/georgewfraser/java-language-server

Installed on emacs-30 as commit 316893ca387.

I'm therefore closing this bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.