GNU bug report logs - #59206
rmail-summary-apply-filters-consecutively causes wrong-type-argument error

Previous Next

To reply to this bug, email your comments to 59206 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graner <nicolas <at> graner.name>
To: bug-gnu-emacs <at> gnu.org
Subject: rmail-summary-apply-filters-consecutively causes
 wrong-type-argument error
Date: Fri, 11 Nov 2022 23:49:22 +0100

When the variable rmail-summary-apply-filters-consecutively is non-nil,
if you execute one of the rmail-summary-by-* commands when there is no
existing summary, you get an error.

This is because those commands call
rmail-summary-fill-displayed-messages, which assumes
rmail-summary-buffer is a buffer, but in this case it is nil.

Example (starting from emacs -Q):

C-u M-x rmail [any rmail file]
M-: (setq rmail-summary-apply-filters-consecutively t)<RET>
M-x rmail-summary-from-senders<RET>testing<RET>

Debugger entered--Lisp error: (wrong-type-argument stringp nil)
  rmail-summary-fill-displayed-messages()
  rmail-summary-by-senders("testing")
  funcall-interactively(rmail-summary-by-senders "testing")
  call-interactively(rmail-summary-by-senders record nil)
  command-execute(rmail-summary-by-senders record)
  execute-extended-command(nil "rmail-summary-by-senders" "rmail-summary-by-senders")
  funcall-interactively(execute-extended-command nil "rmail-summary-by-senders" "rmail-summary-by-senders")
  call-interactively(execute-extended-command nil nil)
  command-execute(execute-extended-command)

Message #8 received at 59206 <at> debbugs.gnu.org (full text, mbox):

From: Richard Stallman <rms <at> gnu.org>
To: Nicolas Graner <nicolas <at> graner.name>
Cc: 59206 <at> debbugs.gnu.org
Subject: Re: bug#59206: rmail-summary-apply-filters-consecutively causes
 wrong-type-argument error
Date: Fri, 11 Nov 2022 22:38:17 -0500

[[[ To any NSA and FBI agents reading my email: please consider    ]]]
[[[ whether defending the US Constitution against all enemies,     ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]

  > When the variable rmail-summary-apply-filters-consecutively is non-nil,
  > if you execute one of the rmail-summary-by-* commands when there is no
  > existing summary, you get an error.

In that kind of case, it ought to apply the newly specified filter to
the whole contents of the buffer, just as it always did in the past.

-- 
Dr Richard Stallman (https://stallman.org)
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)

Message #11 received at 59206 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Nicolas Graner <nicolas <at> graner.name>,
 Andrea Monaco <andrea.monaco <at> autistici.org>
Cc: 59206 <at> debbugs.gnu.org
Subject: Re: bug#59206: rmail-summary-apply-filters-consecutively causes
 wrong-type-argument error
Date: Sat, 12 Nov 2022 11:07:55 +0200

> From: Nicolas Graner <nicolas <at> graner.name>
> Date: Fri, 11 Nov 2022 23:49:22 +0100
> 
> When the variable rmail-summary-apply-filters-consecutively is non-nil,
> if you execute one of the rmail-summary-by-* commands when there is no
> existing summary, you get an error.
> 
> This is because those commands call
> rmail-summary-fill-displayed-messages, which assumes
> rmail-summary-buffer is a buffer, but in this case it is nil.
> 
> Example (starting from emacs -Q):
> 
> C-u M-x rmail [any rmail file]
> M-: (setq rmail-summary-apply-filters-consecutively t)<RET>
> M-x rmail-summary-from-senders<RET>testing<RET>
> 
> Debugger entered--Lisp error: (wrong-type-argument stringp nil)
>   rmail-summary-fill-displayed-messages()
>   rmail-summary-by-senders("testing")
>   funcall-interactively(rmail-summary-by-senders "testing")
>   call-interactively(rmail-summary-by-senders record nil)
>   command-execute(rmail-summary-by-senders record)
>   execute-extended-command(nil "rmail-summary-by-senders" "rmail-summary-by-senders")
>   funcall-interactively(execute-extended-command nil "rmail-summary-by-senders" "rmail-summary-by-senders")
>   call-interactively(execute-extended-command nil nil)
>   command-execute(execute-extended-command)

Thanks.

This part of Rmail is currently being worked on, and there's an
uninstalled patch in the queue.  If that patch doesn't fix this
problem, I'm sure Andrea (CC'ed) will do that as part of the updated
patch, when we finish discussions of his last patch.

Message #14 received at 59206 <at> debbugs.gnu.org (full text, mbox):

From: Andrea Monaco <andrea.monaco <at> autistici.org>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 59206 <at> debbugs.gnu.org, nicolas <at> graner.name
Subject: Re: bug#59206: rmail-summary-apply-filters-consecutively causes
 wrong-type-argument error
Date: Sat, 12 Nov 2022 18:49:50 +0100

> When the variable rmail-summary-apply-filters-consecutively is
> non-nil, if you execute one of the rmail-summary-by-* commands when
> there is no existing summary, you get an error.
> 
> This is because those commands call
> rmail-summary-fill-displayed-messages, which assumes
> rmail-summary-buffer is a buffer, but in this case it is nil.

The last patch I sent fixes exactly that (plus it changes the custom
variable name).  Thanks for testing Nicolas!



Andrea Monaco

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.