GNU logs - #59212, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#59212: 29.0.50; [PATCH] Set default value of bookmark Type
Resent-From: Gabriel <gabriel376@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 12 Nov 2022 08:57:01 +0000
Resent-Message-ID: <handler.59212.B.166824339710603 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 59212 <at> debbugs.gnu.org
From: Gabriel <gabriel376@HIDDEN>
Date: Sat, 12 Nov 2022 05:56:22 -0300
Message-ID: <SJ0PR06MB8609CD4B8715E9DA35BA90AF8B039@HIDDEN>
Content-Type: multipart/mixed; boundary="=-=-="
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR06MB8609:EE_|SJ0PR06MB8389:EE_
X-MS-Office365-Filtering-Correlation-Id: 7556b668-ac5a-4ded-0f60-08dac48bc9c4
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: 1TkY3iAsboyp/VKO/aDIhFGw69ENqHxojGZNNUjR97pUMuBBck8lJgM+Hj9Ug+5ygHRZ7XwV2oD/7apelVy17NBlDQ7lBlbUxsRhmM/+aH4wZdQEU8SzV1OSx2BDtD19SWYzZwemT4+MGhG+ZQ3WTbfrZnjz3DZMkjjvUNbReZ71q4dmt+JHbat1BQtu/pF3VJaKQIMuZhbtOMcw3lZWHsL2nRlBUjhu3jbpQb2qo1+QhdVyOF+BLx/XX9d3x+AfkVoKOdKKGDtTawlyj0vb5/s14OV9ZJqV4Qi73ZoVNIxdhwxqghmYnKTQ69R+o/nFX7QrSsEUDXpmLcCMyMi95Rn1q+LQOqOMeVQWUpFiMxDdBgDq5eVn5rEeBkNzG78f7JYbQG4G+tSzjbouoaLJCfMqqwX0zchQptMWbLkuDOyAGCfyS4H21ku7y/kH94gyMy9l/br2cCCAVuZG9RlhfAW+whHfIlsOXjnh+BjEOOc+hh46k7ofMfnkhpFZ2jP2QtwBnZc+yeqew08zMbmcrl5nL+NSNvKp/CLKm6qzbd2/0KkXDjTtm3FDj1E2WYStmWVeKxXUDEv4gtUTzE8XoujJ+yMNC4qoisM+1HBJQvnQe75KZANl6bu5pFvsGCL6Xp0+rT0tG06YyrAbuDtjKw==
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: T02JYQB25jrAI9BQCITbWUYjYsxK3ZFLUeb/eJWbZksLWl8vZT2EuHmV4CcyGnji18qlLkgf9ZdS+q7eNgmCWYIdKCJ3jOEB3VsCkcMKEuW3VMebwFQLbPz5VpOIg535WWAKQhLdZnHmtm1jCLYDVw7LGs9FmceE46r/AR7SYZkyAs34xxBAKLLIvSzQG+XqJXdl2AfzChHQO+wOd4514PXTZuxNk16CD702NCudwxpqW8NU6yfYr5bLc8buYgpO557fr174qasWl70tGKjJLrRImVrO60hq9Kf457Io5FQigzXgGaYviPNqTecqIuQEW6nOilINgPl+xaY4k/kphJ0PiXQrovvzWuBEQo4u/k+1cnfPKDyWfvWsKwRmF6TwnnaYeo9evpALyj4Grkoz8MLeF9lX88Q3Qg1SRv2M75e3PBCTpP6RgMBjqlMpKvA4wQ7a2K3sqrlw9f3eT8DxqeaOOWzMoRHN9xGBfBAd1XvVL+7bgn6tmwNfyV2QGAVS/dasssev7jj/B81UdoYqTBK/24QL9w6m5U7tAZRgoqIF6VclV48tGhwEL2nM4xcSees8eoqH46Caiep0YzKJs+PzWM6kLiX1cwYTTcYgiaPlaXsrOzbVIs0jfb3qixq8yQPeB41tS3hVQnXbTnPZrGUOtLvAhbCQoztIn3fEc90o4bmZq82KPD93ST6Lj9/DwAaK4FG4Bkz6KBnUDQkp+Y/d8KcMZHLKG3OqAzJhFTTouOPAROkKkNSdGKjn8G/o8wB3jfGOkOjIYTvOxduxNbGHCh5/hm/AftqaMvWE5JIcKWZQqvDu0ARb7QWTD5+2dRaQKAmEpooyMGG9HI6Zfduy6cCphuWb65JsRNoJwGOU883EeTk6twegaMamk1Oav43YnsmTL4yFyFdqDFefkZTZ/3PSj+nrHYAo3IdJn7oKaTDJdFgPGAyKK9cpM5y73UBwwIHqEHZTZ/DLDW/uwYBKbKakEjguuX+KA0SNnAzrKKdwkytS2v0agirWoSNuTWz+7UwrUfaneb2e97AZhV4lvkojGEN0OWCq6dE0T1f1MqunD2iNUVHS9M2293ULrK77w6Z1d44EaoweNI14jpwhhgD5VqhKGEu4Ph4Lm5Vy/Oz6KrHryvpIQd5fiIaFnrRIalkvmnY6KFT5pMTWLSTm9kQ7CZL8ptu0o39pW1TosgKtRKuwLTbkkbgzwp7qwX51Uj4chpN4p75o3dR8G9raOlXUHb+2whFh3+s9YNGRfRJyhxhXNtCCc6oyUJFio29DcI2g8cB23m2qMGkb5sjW+3hKWJC6g+KjBGl+5BZuB2HH4ucFena0mbcWv4VTaDiMTYzI7Rii2IZgzoARUA==
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-89723.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 7556b668-ac5a-4ded-0f60-08dac48bc9c4
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR06MB8609.namprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Nov 2022 08:56:29.5756 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR06MB8389
Received-SPF: pass client-ip=40.92.46.33; envelope-from=gabriel376@HIDDEN;
 helo=NAM04-MW2-obe.outbound.protection.outlook.com
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -0.4 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.1 (--)

--=-=-=
Content-Type: text/plain

Description:
Not a bug per se, but a suggestion for improvement in how Bookmark
displays the Type (added by commit 7c995264359824cc1aca40ca37201db5ed44e659).

Currently, bookmark-bmenu-list (C-x r l) displays a column named Type,
which has a proper value for all handlers (e.g.: Eshell, VC, EWW etc)
except for regular files, in which an empty string is displayed. I
believe the current behavior could be improved by displaying a default
value ("Files") to make the interface more uniform, explicit and to
avoid confusion.

Steps:
1) emacs -Q
2) M-x eshell
3) C-x r m <RET>
4) C-x C-f ~/foo.bar
5) C-x r m <RET>
6) C-x r b

These steps will add two bookmarks (eshell and foo.bar) and will open
the Bookmarks list. The Type column will have values "" and
"Eshell". After the patch below is applied, the Type column will have
values "File" and "Eshell".


--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment;
 filename=0001-Set-default-value-of-bookmark-Type.patch

From 0d9379e2d470239e2da6369d27979672ab10a719 Mon Sep 17 00:00:00 2001
From: Gabriel do Nascimento Ribeiro <gabriel376@HIDDEN>
Date: Sat, 12 Nov 2022 05:13:36 -0300
Subject: [PATCH 1/1] Set default value of bookmark Type

* lisp/bookmark.el (bookmark-type-from-full-record): Return default
  value "File" when type handler is missing.
  (bookmark-bmenu--revert): Remove conditional around type.
---
 lisp/bookmark.el | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/lisp/bookmark.el b/lisp/bookmark.el
index b57ad12986..ad1a1f1acf 100644
--- a/lisp/bookmark.el
+++ b/lisp/bookmark.el
@@ -372,9 +372,9 @@ bookmark-type-from-full-record
   (let ((handler (bookmark-get-handler bookmark-record)))
     (when (autoloadp (symbol-function handler))
       (autoload-do-load (symbol-function handler)))
-    (if (symbolp handler)
-        (get handler 'bookmark-handler-type)
-     "")))
+    (or (and (symbolp handler)
+             (get handler 'bookmark-handler-type))
+        "File")))
 
 (defun bookmark-all-names ()
   "Return a list of all current bookmark names."
@@ -1889,7 +1889,7 @@ bookmark-bmenu--revert
                                   'follow-link t
                                   'help-echo "mouse-2: go to this bookmark in other window")
                     name)
-                 ,(or type "")
+                 ,type
                  ,@(if bookmark-bmenu-toggle-filenames
                        (list location))])
               entries)))
-- 
2.34.1


--=-=-=
Content-Type: text/plain


---
Gabriel


--=-=-=--

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Gabriel <gabriel376@HIDDEN>
Subject: bug#59212: Acknowledgement (29.0.50; [PATCH] Set default value of
 bookmark Type)
Message-ID: <handler.59212.B.166824339710603.ack <at> debbugs.gnu.org>
References: <SJ0PR06MB8609CD4B8715E9DA35BA90AF8B039@HIDDEN>
X-Gnu-PR-Message: ack 59212
X-Gnu-PR-Package: emacs
X-Gnu-PR-Keywords: patch
Reply-To: 59212 <at> debbugs.gnu.org
Date: Sat, 12 Nov 2022 08:57:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 59212 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
59212: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D59212
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#59212: 29.0.50; [PATCH] Set default value of bookmark Type
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 12 Nov 2022 09:04:02 +0000
Resent-Message-ID: <handler.59212.B59212.166824382311361 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Gabriel <gabriel376@HIDDEN>, Karl Fogel <kfogel@HIDDEN>
Cc: 59212 <at> debbugs.gnu.org
Date: Sat, 12 Nov 2022 11:03:39 +0200
Message-Id: <83iljko87o.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <SJ0PR06MB8609CD4B8715E9DA35BA90AF8B039@HIDDEN>
 (message from Gabriel on Sat, 12 Nov 2022 05:56:22 -0300)
References: <SJ0PR06MB8609CD4B8715E9DA35BA90AF8B039@HIDDEN>
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

> From: Gabriel <gabriel376@HIDDEN>
> Date: Sat, 12 Nov 2022 05:56:22 -0300
> 
> Description:
> Not a bug per se, but a suggestion for improvement in how Bookmark
> displays the Type (added by commit 7c995264359824cc1aca40ca37201db5ed44e659).
> 
> Currently, bookmark-bmenu-list (C-x r l) displays a column named Type,
> which has a proper value for all handlers (e.g.: Eshell, VC, EWW etc)
> except for regular files, in which an empty string is displayed. I
> believe the current behavior could be improved by displaying a default
> value ("Files") to make the interface more uniform, explicit and to
> avoid confusion.
> 
> Steps:
> 1) emacs -Q
> 2) M-x eshell
> 3) C-x r m <RET>
> 4) C-x C-f ~/foo.bar
> 5) C-x r m <RET>
> 6) C-x r b
> 
> These steps will add two bookmarks (eshell and foo.bar) and will open
> the Bookmarks list. The Type column will have values "" and
> "Eshell". After the patch below is applied, the Type column will have
> values "File" and "Eshell".

Thanks.

Karl, any comments?

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#59212: 29.0.50; [PATCH] Set default value of bookmark Type
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 12 Nov 2022 10:11:02 +0000
Resent-Message-ID: <handler.59212.B59212.166824781117502 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Eli Zaretskii <eliz@HIDDEN>, Gabriel <gabriel376@HIDDEN>,  Karl Fogel <kfogel@HIDDEN>
Cc: 59212 <at> debbugs.gnu.org
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <83iljko87o.fsf@HIDDEN>
References: <SJ0PR06MB8609CD4B8715E9DA35BA90AF8B039@HIDDEN>
 <83iljko87o.fsf@HIDDEN>
MIME-Version: 1.0
Date: Sat, 12 Nov 2022 02:10:02 -0800
Message-ID: <CADwFkm=tHH2hOsamauF9uO2cTHxyFHpW9SbQ_tcCOMSTp9vmRA@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

severity 59212 wishlist
thanks

Eli Zaretskii <eliz@HIDDEN> writes:

>> From: Gabriel <gabriel376@HIDDEN>
>> Date: Sat, 12 Nov 2022 05:56:22 -0300
>>
>> Description:
>> Not a bug per se, but a suggestion for improvement in how Bookmark
>> displays the Type (added by commit 7c995264359824cc1aca40ca37201db5ed44e659).
>>
>> Currently, bookmark-bmenu-list (C-x r l) displays a column named Type,
>> which has a proper value for all handlers (e.g.: Eshell, VC, EWW etc)
>> except for regular files, in which an empty string is displayed. I
>> believe the current behavior could be improved by displaying a default
>> value ("Files") to make the interface more uniform, explicit and to
>> avoid confusion.
>>
>> Steps:
>> 1) emacs -Q
>> 2) M-x eshell
>> 3) C-x r m <RET>
>> 4) C-x C-f ~/foo.bar
>> 5) C-x r m <RET>
>> 6) C-x r b
>>
>> These steps will add two bookmarks (eshell and foo.bar) and will open
>> the Bookmarks list. The Type column will have values "" and
>> "Eshell". After the patch below is applied, the Type column will have
>> values "File" and "Eshell".
>
> Thanks.
>
> Karl, any comments?

I'm not Karl, but I've experimented with something similar before and I
found two things:

1. I had to add a type for Dired bookmarks (which are not Files) to
   avoid confusion.

2. Using a default name (I also used "Files", IIRC), just made my long
   list of bookmarks more busy with little benefit.  If anything, it
   made it harder to navigate, as it was harder to make out the
   "special" types of bookmarks.

So all in all, I was not a huge fan of the change.

If we want to add this, I suggest adding a defcustom so that users can
enable or disable this functionality to their liking (or change "Files"
into something else).  I might prefer to disable it, for example.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 12 Nov 2022 10:10:11 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 12 05:10:11 2022
Received: from localhost ([127.0.0.1]:47360 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1otnSk-0004YF-Vo
	for submit <at> debbugs.gnu.org; Sat, 12 Nov 2022 05:10:11 -0500
Received: from mail-ot1-f42.google.com ([209.85.210.42]:45689)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1otnSj-0004Xr-36
 for control <at> debbugs.gnu.org; Sat, 12 Nov 2022 05:10:09 -0500
Received: by mail-ot1-f42.google.com with SMTP id
 94-20020a9d0067000000b0066c8d13a33dso4074414ota.12
 for <control <at> debbugs.gnu.org>; Sat, 12 Nov 2022 02:10:09 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:from:to:cc:subject:date:message-id:reply-to;
 bh=qI5F5qZxT/Po5KwXpeu535T+XDtyoF7OOpY3QYSxUjY=;
 b=nzVOhrz87P5nroZNTgqIwz/b5M+1Mw6Y3MhgdkRuN0JMgP/N/mWugkFAAil229W84G
 nyL3MLmX2WGOFBIMUJFrD2qb+oMyg6DyPko3NFxW3S9yvkwPoSUye1hUzIOyrpx3J5AJ
 P2TPhFiox8z9EoGaygB4G8u4jzZ2vhrZmTugVLS3XxpkUZrdOvDrQcSD0CYiacI5Jmde
 SoEKLT12sUwhuRg8Limtk+ALJQhwGVoVVL9OQ3XpOGNthJH9tdgMKxLumw/BjfZ4v7wa
 Dj7JlC6qUjSHdurazrf6uUKK4m7HuWyRO1eozYeuJFBFKLL2W8nDx+/s5Dt2icpCRdQy
 cEMQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
 :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
 bh=qI5F5qZxT/Po5KwXpeu535T+XDtyoF7OOpY3QYSxUjY=;
 b=h/nnm+FoKuWSPNKAQILnD18DmtITswXeWTpcwuEei+hj7066Me3PxweJP9PugUpMhA
 cQ3gZkALAK2s6pvFHDVpDqfAx09ZlsIClK9ICWx6tXGYVZEiSyz81wZlCws6Yk0u8Z9e
 GZXoA7bZ8pF1i1zNA69a2O0wPBFOiv2ZmCTCfXgboeOmMfrneplK7pyQzTHi79k3u3vW
 gLMGBfjhaQEuALWZrVC6qnsJZvyl7X1t1CXDv+83ftT1/pFHf8sjDrkOXVhV8a40B0E5
 VD/Tap6fFSE+24vdHDnbLgFFEAk86+J4R3EMRdYGDzcG2so2jnp47BpBLZOVW50tMV6U
 fMQw==
X-Gm-Message-State: ANoB5pmmYeagZ+bW9a4rH25T0f4ATRxbLN87MfO3xRz06r3UHqM6IIqC
 5IiO0yY936WgdWZcwRsQHJOa8dIhQ8otK+/Tmxs=
X-Google-Smtp-Source: AA0mqf4p2WGcRaHRflp7Iz98N7ji9BxrmNfQuLN2iSaUu8XMAbQamvfegGUXE+NqQUBlhYWLStZipBhWv2kTq4pMWUY=
X-Received: by 2002:a9d:6399:0:b0:661:c48b:12db with SMTP id
 w25-20020a9d6399000000b00661c48b12dbmr2948538otk.105.1668247803464; Sat, 12
 Nov 2022 02:10:03 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sat, 12 Nov 2022 02:10:02 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <83iljko87o.fsf@HIDDEN>
References: <SJ0PR06MB8609CD4B8715E9DA35BA90AF8B039@HIDDEN>
 <83iljko87o.fsf@HIDDEN>
X-Hashcash: 1:20:221112:gabriel376@HIDDEN::7B7BOIyXBHQUzalV:3h5l
MIME-Version: 1.0
Date: Sat, 12 Nov 2022 02:10:02 -0800
Message-ID: <CADwFkm=tHH2hOsamauF9uO2cTHxyFHpW9SbQ_tcCOMSTp9vmRA@HIDDEN>
Subject: Re: bug#59212: 29.0.50; [PATCH] Set default value of bookmark Type
To: Eli Zaretskii <eliz@HIDDEN>, Gabriel <gabriel376@HIDDEN>, 
 Karl Fogel <kfogel@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Bcc: control <at> debbugs.gnu.org
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
Cc: 59212 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

severity 59212 wishlist
thanks

Eli Zaretskii <eliz@HIDDEN> writes:

>> From: Gabriel <gabriel376@HIDDEN>
>> Date: Sat, 12 Nov 2022 05:56:22 -0300
>>
>> Description:
>> Not a bug per se, but a suggestion for improvement in how Bookmark
>> displays the Type (added by commit 7c995264359824cc1aca40ca37201db5ed44e659).
>>
>> Currently, bookmark-bmenu-list (C-x r l) displays a column named Type,
>> which has a proper value for all handlers (e.g.: Eshell, VC, EWW etc)
>> except for regular files, in which an empty string is displayed. I
>> believe the current behavior could be improved by displaying a default
>> value ("Files") to make the interface more uniform, explicit and to
>> avoid confusion.
>>
>> Steps:
>> 1) emacs -Q
>> 2) M-x eshell
>> 3) C-x r m <RET>
>> 4) C-x C-f ~/foo.bar
>> 5) C-x r m <RET>
>> 6) C-x r b
>>
>> These steps will add two bookmarks (eshell and foo.bar) and will open
>> the Bookmarks list. The Type column will have values "" and
>> "Eshell". After the patch below is applied, the Type column will have
>> values "File" and "Eshell".
>
> Thanks.
>
> Karl, any comments?

I'm not Karl, but I've experimented with something similar before and I
found two things:

1. I had to add a type for Dired bookmarks (which are not Files) to
   avoid confusion.

2. Using a default name (I also used "Files", IIRC), just made my long
   list of bookmarks more busy with little benefit.  If anything, it
   made it harder to navigate, as it was harder to make out the
   "special" types of bookmarks.

So all in all, I was not a huge fan of the change.

If we want to add this, I suggest adding a defcustom so that users can
enable or disable this functionality to their liking (or change "Files"
into something else).  I might prefer to disable it, for example.

Message sent to bug-gnu-emacs@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: bug#59212: 29.0.50; [PATCH] Set default value of bookmark Type
In-Reply-To: <SJ0PR06MB8609CD4B8715E9DA35BA90AF8B039@HIDDEN>
Resent-From: Gabriel <gabriel376@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 12 Nov 2022 21:06:02 +0000
Resent-Message-ID: <handler.59212.B.16682871107229 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 59212
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: 59212 <at> debbugs.gnu.org
X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.16682871107229
          (code B ref -1); Sat, 12 Nov 2022 21:06:02 +0000
Received: (at submit) by debbugs.gnu.org; 12 Nov 2022 21:05:10 +0000
Received: from localhost ([127.0.0.1]:49393 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1otxgb-0001sU-Q4
	for submit <at> debbugs.gnu.org; Sat, 12 Nov 2022 16:05:10 -0500
Received: from lists.gnu.org ([209.51.188.17]:39710)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1otxga-0001sN-GL
 for submit <at> debbugs.gnu.org; Sat, 12 Nov 2022 16:05:08 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1otxga-0003YL-9w
 for bug-gnu-emacs@HIDDEN; Sat, 12 Nov 2022 16:05:08 -0500
Received: from ciao.gmane.io ([116.202.254.214])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1otxgW-0005pL-EN
 for bug-gnu-emacs@HIDDEN; Sat, 12 Nov 2022 16:05:06 -0500
Received: from list by ciao.gmane.io with local (Exim 4.92)
 (envelope-from <geb-bug-gnu-emacs@HIDDEN>)
 id 1otxgU-0003ZL-4q
 for bug-gnu-emacs@HIDDEN; Sat, 12 Nov 2022 22:05:02 +0100
X-Injected-Via-Gmane: http://gmane.org/
From: Gabriel <gabriel376@HIDDEN>
Date: Sat, 12 Nov 2022 17:55:41 -0300
Message-ID: <877czzao4y.fsf@HIDDEN>
References: <SJ0PR06MB8609CD4B8715E9DA35BA90AF8B039@HIDDEN>
 <83iljko87o.fsf@HIDDEN>
 <CADwFkm=tHH2hOsamauF9uO2cTHxyFHpW9SbQ_tcCOMSTp9vmRA@HIDDEN>
Mime-Version: 1.0
Content-Type: text/plain
User-Agent: Gnus/5.13 (Gnus v5.13)
Cancel-Lock: sha1:ROSyLvwjj/CZ5wWRHn/8J+SHWvg=
Received-SPF: pass client-ip=116.202.254.214;
 envelope-from=geb-bug-gnu-emacs@HIDDEN; helo=ciao.gmane.io
X-Spam_score_int: -4
X-Spam_score: -0.5
X-Spam_bar: /
X-Spam_report: (-0.5 / 5.0 requ) BAYES_00=-1.9, FORGED_HOTMAIL_RCVD2=0.874,
 FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001,
 HEADER_FROM_DIFFERENT_DOMAINS=0.25, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=no autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.3 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)

Stefan Kangas <stefankangas@HIDDEN> writes:
> I'm not Karl, but I've experimented with something similar before and I
> found two things:
>
> 1. I had to add a type for Dired bookmarks (which are not Files) to
>    avoid confusion.
>
> 2. Using a default name (I also used "Files", IIRC), just made my long
>    list of bookmarks more busy with little benefit.  If anything, it
>    made it harder to navigate, as it was harder to make out the
>    "special" types of bookmarks.
>
> So all in all, I was not a huge fan of the change.
>
> If we want to add this, I suggest adding a defcustom so that users can
> enable or disable this functionality to their liking (or change "Files"
> into something else).  I might prefer to disable it, for example.

1. Good point about Dired. Would be nice to have a Type for regular
files and another one for directories. Is there any approach to
differentiate files from directories that do not rely on IO calls? Some
kind of portable string-check, I guess. I am aware of 'file-directory-p'
and 'file-regular-p', but both will try to read FILENAME, which could
degrade performance in case of long Bookmark lists (and there is also
Tramp).

2. Thanks for the inputs. It's not clear for me what do you mean by
"more busy" or "harder to navigate". How do you normally navigate in
long Bookmark lists? What are the use-cases where a visual distinction
between empty and non-empty strings of the Type column is useful? What
about the distinction between Types Eshell, DocView and VC, where the
user has to read the contents of the Type column?

I am against adding a new defcustom for such trivial thing, Emacs has
already too much. I think this proposed change is a better default to
novices, and advanced users can add an advice around
bookmark-type-from-full-record. If we want to customize this behavior, I
propose something like a defcustom that offers an alist of
'((TYPE . DISPLAY-STRING)).

I also suggest to add a new 'type choice to bookmark-sort-flag, which I
can do in a new wishlist.

---
Gabriel

Last modified: Sat, 12 Nov 2022 21:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.