GNU bug report logs - #59229
[PATCH] Add tree-sitter-based major modes to eglot-server-programs

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59229 in the body.
You can then email your comments to 59229 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <leungbk <at> posteo.net>
To: bug-gnu-emacs <at> gnu.org
Cc: Stefan Kangas <stefankangas <at> gmail.com>
Subject: [PATCH] Add tree-sitter-based major modes to eglot-server-programs
Date: Sat, 12 Nov 2022 22:35:38 +0000

[Message part 1 (text/plain, inline)]

Tags: patch

This adds several to-be-merged tree-sitter-based major modes to eglot.



In GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
version 1.16.0, Xaw3d scroll bars)
Repository revision: be1745606354e8b34325bc9526c9bad9f7302cce
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12014000
System Description: NixOS 22.11 (Raccoon)

Configured using:
 'configure
 --prefix=/nix/store/09jwzp79mqnhzarmaik6y4lybgkwpg1h-emacs-git-20221111.0
 --disable-build-details --with-modules --with-x-toolkit=lucid
 --with-xft --with-cairo --with-native-compilation'

[0001-Add-tree-sitter-based-major-modes-to-eglot-server-pr.patch (text/patch, attachment)]

Message #10 received at 59229 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Brian Leung <leungbk <at> posteo.net>
Cc: 59229 <at> debbugs.gnu.org, stefankangas <at> gmail.com
Subject: Re: bug#59229: [PATCH] Add tree-sitter-based major modes to
 eglot-server-programs
Date: Sun, 13 Nov 2022 08:29:39 +0200

> Cc: Stefan Kangas <stefankangas <at> gmail.com>
> From: Brian Leung <leungbk <at> posteo.net>
> Date: Sat, 12 Nov 2022 22:35:38 +0000
> 
> This adds several to-be-merged tree-sitter-based major modes to eglot.

Thanks, but please hold your horses on the C/C++/Java modes, as we
didn't yet finalize their integration into Emacs.  It is possible they
will not be major modes after all.

Not sure about JSON and CSS modes, but they might share the same fate.

Bottom line: this is too soon for such change, we should wait at least
until the tree-sitter branch lands on master.

Message #13 received at 59229 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>, Brian Leung <leungbk <at> posteo.net>
Cc: 59229 <at> debbugs.gnu.org
Subject: Re: bug#59229: [PATCH] Add tree-sitter-based major modes to
 eglot-server-programs
Date: Sun, 13 Nov 2022 05:58:54 -0800

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: Stefan Kangas <stefankangas <at> gmail.com>
>> From: Brian Leung <leungbk <at> posteo.net>
>> Date: Sat, 12 Nov 2022 22:35:38 +0000
>>
>> This adds several to-be-merged tree-sitter-based major modes to eglot.
>
> Thanks, but please hold your horses on the C/C++/Java modes, as we
> didn't yet finalize their integration into Emacs.  It is possible they
> will not be major modes after all.
>
> Not sure about JSON and CSS modes, but they might share the same fate.
>
> Bottom line: this is too soon for such change, we should wait at least
> until the tree-sitter branch lands on master.

Agreed.  We can keep this bug open as a reminder to add them once that
branch is merged though.

Message #16 received at 59229 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 59229 <at> debbugs.gnu.org, Brian Leung <leungbk <at> posteo.net>
Subject: Re: bug#59229: [PATCH] Add tree-sitter-based major modes to
 eglot-server-programs
Date: Thu, 24 Nov 2022 10:44:17 -0800

close 59229 29.1
thanks

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: Stefan Kangas <stefankangas <at> gmail.com>
>> From: Brian Leung <leungbk <at> posteo.net>
>> Date: Sat, 12 Nov 2022 22:35:38 +0000
>>
>> This adds several to-be-merged tree-sitter-based major modes to eglot.
>
> Thanks, but please hold your horses on the C/C++/Java modes, as we
> didn't yet finalize their integration into Emacs.  It is possible they
> will not be major modes after all.
>
> Not sure about JSON and CSS modes, but they might share the same fate.
>
> Bottom line: this is too soon for such change, we should wait at least
> until the tree-sitter branch lands on master.

AFAICT, these modes have all landed on master, so I've pushed the patch
and I'm closing the bug.  Thanks.

Message #23 received at 59229 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 59229 <at> debbugs.gnu.org, Brian Leung <leungbk <at> posteo.net>,
 Eli Zaretskii <eliz <at> gnu.org>
Subject: Re: bug#59229: [PATCH] Add tree-sitter-based major modes to
 eglot-server-programs
Date: Thu, 24 Nov 2022 11:41:46 -0800

> On Nov 24, 2022, at 10:44 AM, Stefan Kangas <stefankangas <at> gmail.com> wrote:
> 
> close 59229 29.1
> thanks
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
>>> Cc: Stefan Kangas <stefankangas <at> gmail.com>
>>> From: Brian Leung <leungbk <at> posteo.net>
>>> Date: Sat, 12 Nov 2022 22:35:38 +0000
>>> 
>>> This adds several to-be-merged tree-sitter-based major modes to eglot.
>> 
>> Thanks, but please hold your horses on the C/C++/Java modes, as we
>> didn't yet finalize their integration into Emacs.  It is possible they
>> will not be major modes after all.
>> 
>> Not sure about JSON and CSS modes, but they might share the same fate.
>> 
>> Bottom line: this is too soon for such change, we should wait at least
>> until the tree-sitter branch lands on master.
> 
> AFAICT, these modes have all landed on master, so I've pushed the patch
> and I'm closing the bug.  Thanks.
> 

Thank you!

Yuan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.