GNU bug report logs - #59234
CC Mode 5.35.2 (ObjC//l); Random fontification of nsterm.m

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59234 in the body.
You can then email your comments to 59234 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: bug-gnu-emacs <at> gnu.org
Subject: CC Mode 5.35.2 (ObjC//l); Random fontification of nsterm.m
Date: Sun, 13 Nov 2022 11:13:02 +0800

Package: cc-mode

If you go to src/nsterm.m, around line 4020 there should be the
following code:

static void
ns_draw_stretch_glyph_string (struct glyph_string *s)
{
  struct face *face;
  NSColor *fg_color;

  if (s->hl == DRAW_CURSOR
      && !x_stretch_cursor_p)
    {
      /* If `x-stretch-cursor' is nil, don't draw a block cursor as
	 wide as the stretch glyph.  */
      int width, background_width = s->background_width;
      int x = s->x;

      if (!s->row->reversed_p)
	{
	  int left_x = window_box_left_offset (s->w, TEXT_AREA);

	  if (x < left_x)
	    {
	      background_width -= left_x - x;
	      x = left_x;
	    }
	}
      else
	{

in it, "width" and "background_width" are seemingly randomly fontified
as types.  Then, if you scroll up to line 3658, you will see the
following code:


      if (left_p && top_p)
	[NSBezierPath fillRect: NSMakeRect (NSMinX (outer),
					    NSMinY (outer),
					    1, 1)];

      if (right_p && top_p)
	[NSBezierPath fillRect: NSMakeRect (NSMaxX (outer) - 1,
					    NSMinY (outer),
					    1, 1)];

      if (right_p && bottom_p)
	[NSBezierPath fillRect: NSMakeRect (NSMaxX (outer) - 1,
					    NSMaxY (outer) - 1,
					    1, 1)];

      if (left_p && bottom_p)
	[NSBezierPath fillRect: NSMakeRect (NSMinX (outer),
					    NSMaxY (outer) - 1,
					    1, 1)];

NSBezierPath is a type, and is correctly fontified, but NSMinX and
NSMaxX (and their Y variants) are functions, yet are fontified as types.

Thanks.

Emacs  : GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu)
 of 2022-11-12
Package: CC Mode 5.35.2 (ObjC//l)
Buffer Style: GNU
c-emacs-features: (pps-extended-state col-0-paren posix-char-classes gen-string-delim gen-comment-delim syntax-properties category-properties 1-bit)

current state:
==============
(setq
 c-basic-offset 2
 c-comment-only-line-offset '(0 . 0)
 c-indent-comment-alist '((anchored-comment column . 0) (end-block space . 1) (cpp-end-block space . 2))
 c-indent-comments-syntactically-p nil
 c-block-comment-prefix ""
 c-comment-prefix-regexp '((pike-mode . "//+!?\\|\\**") (awk-mode . "#+") (other . "//+\\|\\**"))
 c-doc-comment-style '((java-mode . javadoc) (pike-mode . autodoc) (c-mode . gtkdoc) (c++-mode . gtkdoc))
 c-cleanup-list '(scope-operator)
 c-hanging-braces-alist '((substatement-open before after) (arglist-cont-nonempty))
 c-hanging-colons-alist nil
 c-hanging-semi&comma-criteria '(c-semi&comma-inside-parenlist)
 c-backslash-column 48
 c-backslash-max-column 72
 c-special-indent-hook '(t c-gnu-impose-minimum)
 c-label-minimum-indentation 1
 c-offsets-alist '((inexpr-class . +)
		   (inexpr-statement . +)
		   (lambda-intro-cont . +)
		   (inlambda . 0)
		   (template-args-cont c-lineup-template-args +)
		   (incomposition . +)
		   (inmodule . +)
		   (innamespace . +)
		   (inextern-lang . +)
		   (composition-close . 0)
		   (module-close . 0)
		   (namespace-close . 0)
		   (extern-lang-close . 0)
		   (composition-open . 0)
		   (module-open . 0)
		   (namespace-open . 0)
		   (extern-lang-open . 0)
		   (objc-method-call-cont c-lineup-ObjC-method-call-colons c-lineup-ObjC-method-call +)
		   (objc-method-args-cont . c-lineup-ObjC-method-args)
		   (objc-method-intro . [0])
		   (friend . 0)
		   (cpp-define-intro c-lineup-cpp-define +)
		   (cpp-macro-cont . +)
		   (cpp-macro . [0])
		   (inclass . +)
		   (stream-op . c-lineup-streamop)
		   (arglist-cont-nonempty c-lineup-gcc-asm-reg c-lineup-arglist)
		   (arglist-cont c-lineup-gcc-asm-reg 0)
		   (comment-intro c-lineup-knr-region-comment c-lineup-comment)
		   (catch-clause . 0)
		   (else-clause . 0)
		   (do-while-closure . 0)
		   (access-label . -)
		   (case-label . 0)
		   (substatement . +)
		   (statement-case-intro . +)
		   (statement . 0)
		   (brace-entry-open . 0)
		   (brace-list-entry . 0)
		   (brace-list-close . 0)
		   (block-close . 0)
		   (block-open . 0)
		   (inher-cont . c-lineup-multi-inher)
		   (inher-intro . +)
		   (member-init-cont . c-lineup-multi-inher)
		   (member-init-intro . +)
		   (annotation-var-cont . +)
		   (annotation-top-cont . 0)
		   (topmost-intro . 0)
		   (knr-argdecl . 0)
		   (func-decl-cont . +)
		   (inline-close . 0)
		   (class-close . 0)
		   (class-open . 0)
		   (defun-block-intro . +)
		   (defun-close . 0)
		   (defun-open . 0)
		   (c . c-lineup-C-comments)
		   (string . c-lineup-dont-change)
		   (topmost-intro-cont first c-lineup-topmost-intro-cont c-lineup-gnu-DEFUN-intro-cont)
		   (brace-list-intro first c-lineup-2nd-brace-entry-in-arglist c-lineup-class-decl-init-+ +)
		   (brace-list-open . +)
		   (inline-open . 0)
		   (arglist-close . c-lineup-arglist)
		   (arglist-intro . c-lineup-arglist-intro-after-paren)
		   (statement-cont . +)
		   (statement-case-open . +)
		   (label . 0)
		   (substatement-label . 0)
		   (substatement-open . +)
		   (knr-argdecl-intro . 5)
		   (statement-block-intro . +)
		   )
 c-buffer-is-cc-mode 'objc-mode
 c-tab-always-indent t
 c-syntactic-indentation t
 c-syntactic-indentation-in-macros t
 c-ignore-auto-fill '(string cpp code)
 c-auto-align-backslashes t
 c-backspace-function 'backward-delete-char-untabify
 c-delete-function 'delete-char
 c-electric-pound-behavior nil
 c-default-style '((java-mode . "java") (awk-mode . "awk") (other . "gnu"))
 c-enable-xemacs-performance-kludge-p nil
 c-old-style-variable-behavior nil
 defun-prompt-regexp nil
 tab-width 8
 comment-column 32
 parse-sexp-ignore-comments t
 parse-sexp-lookup-properties t
 auto-fill-function nil
 comment-multi-line t
 comment-start-skip "\\(?://+\\|/\\*+\\)\\s *"
 fill-prefix nil
 fill-column 70
 paragraph-start "[ 	]*\\(//+\\|\\**\\)[ 	]*$\\|^\f"
 adaptive-fill-mode t
 adaptive-fill-regexp "[ 	]*\\(//+\\|\\**\\)[ 	]*\\([ 	]*\\([-–!|#%;>*·•‣⁃◦]+[ 	]*\\)*\\)"
 )

Message #8 received at 59234 <at> debbugs.gnu.org (full text, mbox):

From: Alan Mackenzie <acm <at> muc.de>
To: Po Lu <luangruo <at> yahoo.com>
Cc: 59234 <at> debbugs.gnu.org
Subject: Re: bug#59234: CC Mode 5.35.2 (ObjC//l); Random fontification of
 nsterm.m
Date: Sun, 13 Nov 2022 19:46:44 +0000

Hello, Po.

On Sun, Nov 13, 2022 at 11:13:02 +0800, Po Lu via CC-Mode-help wrote:
> Package: cc-mode

> If you go to src/nsterm.m, around line 4020 there should be the
> following code:

> static void
> ns_draw_stretch_glyph_string (struct glyph_string *s)
> {
>   struct face *face;
>   NSColor *fg_color;

>   if (s->hl == DRAW_CURSOR
>       && !x_stretch_cursor_p)
>     {
>       /* If `x-stretch-cursor' is nil, don't draw a block cursor as
> 	 wide as the stretch glyph.  */
>       int width, background_width = s->background_width;
>       int x = s->x;

>       if (!s->row->reversed_p)
> 	{
> 	  int left_x = window_box_left_offset (s->w, TEXT_AREA);

> 	  if (x < left_x)
> 	    {
> 	      background_width -= left_x - x;
> 	      x = left_x;
> 	    }
> 	}
>       else
> 	{

> in it, "width" and "background_width" are seemingly randomly fontified
> as types.  Then, if you scroll up to line 3658, you will see the
> following code:


>       if (left_p && top_p)
> 	[NSBezierPath fillRect: NSMakeRect (NSMinX (outer),
> 					    NSMinY (outer),
> 					    1, 1)];

>       if (right_p && top_p)
> 	[NSBezierPath fillRect: NSMakeRect (NSMaxX (outer) - 1,
> 					    NSMinY (outer),
> 					    1, 1)];

>       if (right_p && bottom_p)
> 	[NSBezierPath fillRect: NSMakeRect (NSMaxX (outer) - 1,
> 					    NSMaxY (outer) - 1,
> 					    1, 1)];

>       if (left_p && bottom_p)
> 	[NSBezierPath fillRect: NSMakeRect (NSMinX (outer),
> 					    NSMaxY (outer) - 1,
> 					    1, 1)];

> NSBezierPath is a type, and is correctly fontified, but NSMinX and
> NSMaxX (and their Y variants) are functions, yet are fontified as types.

The problem here is the setting of the customisable variable
objc-font-lock-extra-types.  In Objective C's case, it causes all
identifiers beginning with an upper case letter and containing a lower
case letter to be recognised as types.

This is clearly not satisfactory, even if it was OK a long time ago.

I would recommend you to customize this variable to nil.  Note that CC
Mode internal stuff gets set up at an early stage of Objective C Mode's
initialisation, before buffer local variables or .dir-local.el get
processed.  So trying to change it in these places won't work (believe
me, I've tried ;-).

I'll try and think up a more satisfactory solution.

> Thanks.

> Emacs  : GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu)
>  of 2022-11-12
> Package: CC Mode 5.35.2 (ObjC//l)
> Buffer Style: GNU
> c-emacs-features: (pps-extended-state col-0-paren posix-char-classes gen-string-delim gen-comment-delim syntax-properties category-properties 1-bit)

[ .... ]

-- 
Alan Mackenzie (Nuremberg, Germany).

Message #11 received at 59234 <at> debbugs.gnu.org (full text, mbox):

From: Po Lu <luangruo <at> yahoo.com>
To: Alan Mackenzie <acm <at> muc.de>
Cc: 59234 <at> debbugs.gnu.org
Subject: Re: bug#59234: CC Mode 5.35.2 (ObjC//l); Random fontification of
 nsterm.m
Date: Mon, 14 Nov 2022 08:20:45 +0800

Alan Mackenzie <acm <at> muc.de> writes:

> Hello, Po.
>
> On Sun, Nov 13, 2022 at 11:13:02 +0800, Po Lu via CC-Mode-help wrote:
>> Package: cc-mode
>
>> If you go to src/nsterm.m, around line 4020 there should be the
>> following code:
>
>> static void
>> ns_draw_stretch_glyph_string (struct glyph_string *s)
>> {
>>   struct face *face;
>>   NSColor *fg_color;
>
>>   if (s->hl == DRAW_CURSOR
>>       && !x_stretch_cursor_p)
>>     {
>>       /* If `x-stretch-cursor' is nil, don't draw a block cursor as
>> 	 wide as the stretch glyph.  */
>>       int width, background_width = s->background_width;
>>       int x = s->x;
>
>>       if (!s->row->reversed_p)
>> 	{
>> 	  int left_x = window_box_left_offset (s->w, TEXT_AREA);
>
>> 	  if (x < left_x)
>> 	    {
>> 	      background_width -= left_x - x;
>> 	      x = left_x;
>> 	    }
>> 	}
>>       else
>> 	{
>
>> in it, "width" and "background_width" are seemingly randomly fontified
>> as types.  Then, if you scroll up to line 3658, you will see the
>> following code:
>
>
>>       if (left_p && top_p)
>> 	[NSBezierPath fillRect: NSMakeRect (NSMinX (outer),
>> 					    NSMinY (outer),
>> 					    1, 1)];
>
>>       if (right_p && top_p)
>> 	[NSBezierPath fillRect: NSMakeRect (NSMaxX (outer) - 1,
>> 					    NSMinY (outer),
>> 					    1, 1)];
>
>>       if (right_p && bottom_p)
>> 	[NSBezierPath fillRect: NSMakeRect (NSMaxX (outer) - 1,
>> 					    NSMaxY (outer) - 1,
>> 					    1, 1)];
>
>>       if (left_p && bottom_p)
>> 	[NSBezierPath fillRect: NSMakeRect (NSMinX (outer),
>> 					    NSMaxY (outer) - 1,
>> 					    1, 1)];
>
>> NSBezierPath is a type, and is correctly fontified, but NSMinX and
>> NSMaxX (and their Y variants) are functions, yet are fontified as types.
>
> The problem here is the setting of the customisable variable
> objc-font-lock-extra-types.  In Objective C's case, it causes all
> identifiers beginning with an upper case letter and containing a lower
> case letter to be recognised as types.
>
> This is clearly not satisfactory, even if it was OK a long time ago.
>
> I would recommend you to customize this variable to nil.  Note that CC
> Mode internal stuff gets set up at an early stage of Objective C Mode's
> initialisation, before buffer local variables or .dir-local.el get
> processed.  So trying to change it in these places won't work (believe
> me, I've tried ;-).
>
> I'll try and think up a more satisfactory solution.
>
>> Thanks.
>
>> Emacs  : GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu)
>>  of 2022-11-12
>> Package: CC Mode 5.35.2 (ObjC//l)
>> Buffer Style: GNU
>> c-emacs-features: (pps-extended-state col-0-paren posix-char-classes gen-string-delim gen-comment-delim syntax-properties category-properties 1-bit)
>
> [ .... ]

Thank you.

Message #16 received at 59234-done <at> debbugs.gnu.org (full text, mbox):

From: Alan Mackenzie <acm <at> muc.de>
To: Po Lu <luangruo <at> yahoo.com>
Cc: acm <at> muc.de, 59234-done <at> debbugs.gnu.org
Subject: Re: bug#59234: CC Mode 5.35.2 (ObjC//l); Random fontification of
 nsterm.m
Date: Mon, 23 Jan 2023 21:34:51 +0000

Hello, Po.

On Mon, Nov 14, 2022 at 08:20:45 +0800, Po Lu wrote:
> Alan Mackenzie <acm <at> muc.de> writes:

> > Hello, Po.
> >
> > On Sun, Nov 13, 2022 at 11:13:02 +0800, Po Lu via CC-Mode-help wrote:
> >> Package: cc-mode
> >
> >> If you go to src/nsterm.m, around line 4020 there should be the
> >> following code:
> >
> >> static void
> >> ns_draw_stretch_glyph_string (struct glyph_string *s)
> >> {
> >>   struct face *face;
> >>   NSColor *fg_color;
> >
> >>   if (s->hl == DRAW_CURSOR
> >>       && !x_stretch_cursor_p)
> >>     {
> >>       /* If `x-stretch-cursor' is nil, don't draw a block cursor as
> >> 	 wide as the stretch glyph.  */
> >>       int width, background_width = s->background_width;
> >>       int x = s->x;
> >
> >>       if (!s->row->reversed_p)
> >> 	{
> >> 	  int left_x = window_box_left_offset (s->w, TEXT_AREA);
> >
> >> 	  if (x < left_x)
> >> 	    {
> >> 	      background_width -= left_x - x;
> >> 	      x = left_x;
> >> 	    }
> >> 	}
> >>       else
> >> 	{
> >
> >> in it, "width" and "background_width" are seemingly randomly fontified
> >> as types.  Then, if you scroll up to line 3658, you will see the
> >> following code:
> >
> >
> >>       if (left_p && top_p)
> >> 	[NSBezierPath fillRect: NSMakeRect (NSMinX (outer),
> >> 					    NSMinY (outer),
> >> 					    1, 1)];
> >
> >>       if (right_p && top_p)
> >> 	[NSBezierPath fillRect: NSMakeRect (NSMaxX (outer) - 1,
> >> 					    NSMinY (outer),
> >> 					    1, 1)];
> >
> >>       if (right_p && bottom_p)
> >> 	[NSBezierPath fillRect: NSMakeRect (NSMaxX (outer) - 1,
> >> 					    NSMaxY (outer) - 1,
> >> 					    1, 1)];
> >
> >>       if (left_p && bottom_p)
> >> 	[NSBezierPath fillRect: NSMakeRect (NSMinX (outer),
> >> 					    NSMaxY (outer) - 1,
> >> 					    1, 1)];
> >
> >> NSBezierPath is a type, and is correctly fontified, but NSMinX and
> >> NSMaxX (and their Y variants) are functions, yet are fontified as types.
> >
> > The problem here is the setting of the customisable variable
> > objc-font-lock-extra-types.  In Objective C's case, it causes all
> > identifiers beginning with an upper case letter and containing a lower
> > case letter to be recognised as types.
> >
> > This is clearly not satisfactory, even if it was OK a long time ago.
> >
> > I would recommend you to customize this variable to nil.  Note that CC
> > Mode internal stuff gets set up at an early stage of Objective C Mode's
> > initialisation, before buffer local variables or .dir-local.el get
> > processed.  So trying to change it in these places won't work (believe
> > me, I've tried ;-).
> >
> > I'll try and think up a more satisfactory solution.
> >
> >> Thanks.
> >
> >> Emacs  : GNU Emacs 29.0.50 (build 1, x86_64-pc-linux-gnu)
> >>  of 2022-11-12
> >> Package: CC Mode 5.35.2 (ObjC//l)
> >> Buffer Style: GNU
> >> c-emacs-features: (pps-extended-state col-0-paren posix-char-classes gen-string-delim gen-comment-delim syntax-properties category-properties 1-bit)
> >
> > [ .... ]

> Thank you.

I've set the default value of objc-font-lock-extra-types to nil, and
committed the fix to the release branch.  I'm closing the bug with this
post.

-- 
Alan Mackenzie (Nuremberg, Germany).

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.