GNU bug report logs - #59235
[PATCH] gnu: %options: Add short flag -R for --list-transitive option.

Previous Next

Package: guix-patches;

Reported by: jgart <jgart <at> dismail.de>

Date: Sun, 13 Nov 2022 03:30:01 UTC

Severity: normal

Tags: patch

To reply to this bug, email your comments to 59235 AT debbugs.gnu.org.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#59235; Package guix-patches. (Sun, 13 Nov 2022 03:30:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to jgart <jgart <at> dismail.de>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Sun, 13 Nov 2022 03:30:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH] gnu: %options: Add short flag -R for --list-transitive option.
Date: Sat, 12 Nov 2022 21:28:33 -0600
* guix/scripts/refresh.scm (%options): Add short flag -R.
---
 guix/scripts/refresh.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/guix/scripts/refresh.scm b/guix/scripts/refresh.scm
index 14329751f8..aff32c13de 100644
--- a/guix/scripts/refresh.scm
+++ b/guix/scripts/refresh.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2019 Ricardo Wurmus <rekado <at> elephly.net>
 ;;; Copyright © 2020 Simon Tournier <zimon.toutoune <at> gmail.com>
 ;;; Copyright © 2021 Sarah Morgensen <iskarian <at> mgsn.dev>
+;;; Copyright © 2022 jgart <jgart <at> dismail.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -99,7 +100,7 @@ (define %options
         (option '(#\r "recursive") #f #f
                 (lambda (opt name arg result)
                   (alist-cons 'recursive? #t result)))
-        (option '("list-transitive") #f #f
+        (option '(#\R "list-transitive") #f #f
                 (lambda (opt name arg result)
                   (alist-cons 'list-transitive? #t result)))
 
@@ -157,7 +158,7 @@ (define (show-help)
   (display (G_ "
   -r, --recursive        check the PACKAGE and its inputs for upgrades"))
   (display (G_ "
-      --list-transitive  list all the packages that PACKAGE depends on"))
+  -R, --list-transitive  list all the packages that PACKAGE depends on"))
   (newline)
   (display (G_ "
       --keyring=FILE     use FILE as the keyring of upstream OpenPGP keys"))
-- 
2.38.1





Information forwarded to guix-patches <at> gnu.org:
bug#59235; Package guix-patches. (Sun, 13 Nov 2022 07:57:01 GMT) Full text and rfc822 format available.

Message #8 received at 59235 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: "jgart" <jgart <at> dismail.de>, <59235 <at> debbugs.gnu.org>
Subject: Re: [bug#59235] [PATCH] gnu: %options: Add short flag -R for
 --list-transitive option.
Date: Sun, 13 Nov 2022 07:56:03 +0000
On Sun Nov 13, 2022 at 3:28 AM GMT, jgart via Guix-patches via wrote:
> gnu: %options: ...

This should be:

  scripts: refresh: ...

> * guix/scripts/refresh.scm (%options): Add short flag -R.

Other than that, LGTM! :)

    -- (




Information forwarded to guix-patches <at> gnu.org:
bug#59235; Package guix-patches. (Sun, 13 Nov 2022 15:08:02 GMT) Full text and rfc822 format available.

Message #11 received at 59235 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 59235 <at> debbugs.gnu.org
Cc: "\(" <paren <at> disroot.org>, jgart <jgart <at> dismail.de>
Subject: [PATCH v2] guix: scripts: refresh: Add short flag -R for
 --list-transitive option.
Date: Sun, 13 Nov 2022 09:05:20 -0600
* guix/scripts/refresh.scm (%options): Add short flag -R.

Here's v2 with your requests. Thanks for the review, paren.

all best,

jgart
---
 guix/scripts/refresh.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/guix/scripts/refresh.scm b/guix/scripts/refresh.scm
index 14329751f8..aff32c13de 100644
--- a/guix/scripts/refresh.scm
+++ b/guix/scripts/refresh.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2019 Ricardo Wurmus <rekado <at> elephly.net>
 ;;; Copyright © 2020 Simon Tournier <zimon.toutoune <at> gmail.com>
 ;;; Copyright © 2021 Sarah Morgensen <iskarian <at> mgsn.dev>
+;;; Copyright © 2022 jgart <jgart <at> dismail.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -99,7 +100,7 @@ (define %options
         (option '(#\r "recursive") #f #f
                 (lambda (opt name arg result)
                   (alist-cons 'recursive? #t result)))
-        (option '("list-transitive") #f #f
+        (option '(#\R "list-transitive") #f #f
                 (lambda (opt name arg result)
                   (alist-cons 'list-transitive? #t result)))
 
@@ -157,7 +158,7 @@ (define (show-help)
   (display (G_ "
   -r, --recursive        check the PACKAGE and its inputs for upgrades"))
   (display (G_ "
-      --list-transitive  list all the packages that PACKAGE depends on"))
+  -R, --list-transitive  list all the packages that PACKAGE depends on"))
   (newline)
   (display (G_ "
       --keyring=FILE     use FILE as the keyring of upstream OpenPGP keys"))
-- 
2.38.1





Information forwarded to guix-patches <at> gnu.org:
bug#59235; Package guix-patches. (Sun, 13 Nov 2022 15:39:01 GMT) Full text and rfc822 format available.

Message #14 received at 59235 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 59235 <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH v3 1/2] guix: scripts: refresh: Add short flag -R for
 --list-transitive option.
Date: Sun, 13 Nov 2022 09:38:04 -0600
* guix/scripts/refresh.scm (%options): Add short flag -R.

Here's v3 adding a doc entry.

all best,

jgart
---
 guix/scripts/refresh.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/guix/scripts/refresh.scm b/guix/scripts/refresh.scm
index 14329751f8..aff32c13de 100644
--- a/guix/scripts/refresh.scm
+++ b/guix/scripts/refresh.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2019 Ricardo Wurmus <rekado <at> elephly.net>
 ;;; Copyright © 2020 Simon Tournier <zimon.toutoune <at> gmail.com>
 ;;; Copyright © 2021 Sarah Morgensen <iskarian <at> mgsn.dev>
+;;; Copyright © 2022 jgart <jgart <at> dismail.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -99,7 +100,7 @@ (define %options
         (option '(#\r "recursive") #f #f
                 (lambda (opt name arg result)
                   (alist-cons 'recursive? #t result)))
-        (option '("list-transitive") #f #f
+        (option '(#\R "list-transitive") #f #f
                 (lambda (opt name arg result)
                   (alist-cons 'list-transitive? #t result)))
 
@@ -157,7 +158,7 @@ (define (show-help)
   (display (G_ "
   -r, --recursive        check the PACKAGE and its inputs for upgrades"))
   (display (G_ "
-      --list-transitive  list all the packages that PACKAGE depends on"))
+  -R, --list-transitive  list all the packages that PACKAGE depends on"))
   (newline)
   (display (G_ "
       --keyring=FILE     use FILE as the keyring of upstream OpenPGP keys"))
-- 
2.38.1





Information forwarded to guix-patches <at> gnu.org:
bug#59235; Package guix-patches. (Sun, 13 Nov 2022 15:39:02 GMT) Full text and rfc822 format available.

Message #17 received at 59235 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 59235 <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH v3 2/2] doc: Mention --list-transitive short flag in the
 manual.
Date: Sun, 13 Nov 2022 09:38:05 -0600
* doc/guix.texi (Invoking guix refresh): Mention -R short flag.
---
 doc/guix.texi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/doc/guix.texi b/doc/guix.texi
index 3f76184495..b7f0775ae4 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -109,6 +109,7 @@ Copyright @copyright{} 2022 Reily Siegel@*
 Copyright @copyright{} 2022 Simon Streit@*
 Copyright @copyright{} 2022 (@*
 Copyright @copyright{} 2022 John Kehayias@*
+Copyright @copyright{} 2022 jgart@*
 
 Permission is granted to copy, distribute and/or modify this document
 under the terms of the GNU Free Documentation License, Version 1.3 or
@@ -14135,6 +14136,7 @@ for compatibility with an upgraded @code{flex} package.
 @table @code
 
 @item --list-transitive
+@itemx -R
 List all the packages which one or more packages depend upon.
 
 @example
-- 
2.38.1





Information forwarded to guix-patches <at> gnu.org:
bug#59235; Package guix-patches. (Sun, 13 Nov 2022 16:03:02 GMT) Full text and rfc822 format available.

Message #20 received at 59235 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: "jgart" <jgart <at> dismail.de>, <59235 <at> debbugs.gnu.org>
Subject: Re: [bug#59235] [PATCH v3 1/2] guix: scripts: refresh: Add short
 flag -R for --list-transitive option.
Date: Sun, 13 Nov 2022 16:01:59 +0000
On Sun Nov 13, 2022 at 3:38 PM GMT, jgart via Guix-patches via wrote:
> guix: scripts: refresh: ...

Nitpick again: it's just ``scripts: refresh: ...'' ;)

    -- (




Information forwarded to guix-patches <at> gnu.org:
bug#59235; Package guix-patches. (Sun, 13 Nov 2022 16:28:02 GMT) Full text and rfc822 format available.

Message #23 received at 59235 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 59235 <at> debbugs.gnu.org
Cc: "\(" <paren <at> disroot.org>, jgart <jgart <at> dismail.de>
Subject: [PATCH v4 1/2] scripts: refresh: Add short flag -R for
 --list-transitive option.
Date: Sun, 13 Nov 2022 10:27:00 -0600
* guix/scripts/refresh.scm (%options): Add short flag -R.

no probs, v4 thnx!
---
 guix/scripts/refresh.scm | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/guix/scripts/refresh.scm b/guix/scripts/refresh.scm
index 14329751f8..aff32c13de 100644
--- a/guix/scripts/refresh.scm
+++ b/guix/scripts/refresh.scm
@@ -9,6 +9,7 @@
 ;;; Copyright © 2019 Ricardo Wurmus <rekado <at> elephly.net>
 ;;; Copyright © 2020 Simon Tournier <zimon.toutoune <at> gmail.com>
 ;;; Copyright © 2021 Sarah Morgensen <iskarian <at> mgsn.dev>
+;;; Copyright © 2022 jgart <jgart <at> dismail.de>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -99,7 +100,7 @@ (define %options
         (option '(#\r "recursive") #f #f
                 (lambda (opt name arg result)
                   (alist-cons 'recursive? #t result)))
-        (option '("list-transitive") #f #f
+        (option '(#\R "list-transitive") #f #f
                 (lambda (opt name arg result)
                   (alist-cons 'list-transitive? #t result)))
 
@@ -157,7 +158,7 @@ (define (show-help)
   (display (G_ "
   -r, --recursive        check the PACKAGE and its inputs for upgrades"))
   (display (G_ "
-      --list-transitive  list all the packages that PACKAGE depends on"))
+  -R, --list-transitive  list all the packages that PACKAGE depends on"))
   (newline)
   (display (G_ "
       --keyring=FILE     use FILE as the keyring of upstream OpenPGP keys"))
-- 
2.38.1





Information forwarded to guix-patches <at> gnu.org:
bug#59235; Package guix-patches. (Sun, 13 Nov 2022 16:29:02 GMT) Full text and rfc822 format available.

Message #26 received at 59235 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 59235 <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH v4 2/2] doc: Mention --list-transitive short flag in the
 manual.
Date: Sun, 13 Nov 2022 10:27:01 -0600
* doc/guix.texi (Invoking guix refresh): Mention -R short flag.
---
 doc/guix.texi | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/doc/guix.texi b/doc/guix.texi
index 3f76184495..b7f0775ae4 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -109,6 +109,7 @@ Copyright @copyright{} 2022 Reily Siegel@*
 Copyright @copyright{} 2022 Simon Streit@*
 Copyright @copyright{} 2022 (@*
 Copyright @copyright{} 2022 John Kehayias@*
+Copyright @copyright{} 2022 jgart@*
 
 Permission is granted to copy, distribute and/or modify this document
 under the terms of the GNU Free Documentation License, Version 1.3 or
@@ -14135,6 +14136,7 @@ for compatibility with an upgraded @code{flex} package.
 @table @code
 
 @item --list-transitive
+@itemx -R
 List all the packages which one or more packages depend upon.
 
 @example
-- 
2.38.1





This bug report was last modified 1 year and 163 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.