GNU logs - #59239, boring messages

Message sent to rekado@HIDDEN, guix-patches@HIDDEN:

Subject: [bug#59239] [PATCH] gnu: Add python-synapseclient.
Resent-From: =?UTF-8?Q?M=C4=83d=C4=83lin?= Ionel =?UTF-8?Q?Patra=C8=99cu?= <madalinionel.patrascu@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: rekado@HIDDEN, guix-patches@HIDDEN
Resent-Date: Sun, 13 Nov 2022 05:44:02 +0000
Resent-Message-ID: <handler.59239.B.166831822216532 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 59239 <at> debbugs.gnu.org
Cc: rekado@HIDDEN
From: =?UTF-8?Q?M=C4=83d=C4=83lin?= Ionel =?UTF-8?Q?Patra=C8=99cu?=
 <madalinionel.patrascu@HIDDEN>
Date: Sun, 13 Nov 2022 06:43:08 +0100
Message-ID: <20221113054308.5582-1-madalinionel.patrascu@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Content-Type: text/plain
Received-SPF: pass client-ip=194.95.234.172;
 envelope-from=MadalinIonel.Patrascu@HIDDEN; helo=b2062.mx.srv.dfn.de
X-Spam_score_int: -43
X-Spam_score: -4.4
X-Spam_bar: ----
X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

* gnu/packages/python-xyz.scm (python-synapseclient): New variable.
---
 gnu/packages/python-xyz.scm | 60 +++++++++++++++++++++++++++++++++++++
 1 file changed, 60 insertions(+)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index e26656fa32..b599a2e4ed 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -10383,6 +10383,66 @@ (define-public python-sympy
 as possible in order to be comprehensible and easily extensible.")
     (license license:bsd-3)))
 
+(define-public python-synapseclient
+  (package
+    (name "python-synapseclient")
+    (version "2.7.0")
+    (source (origin
+              ;; git version contains tests
+              (method git-fetch)
+              (uri (git-reference
+                    (url
+                     "https://github.com/Sage-Bionetworks/synapsePythonClient")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "0v2yyjpmxlxmbn1xbxzx1l1bs45ir9p4i51dlf847irnrrmifxcd"))))
+              ;;(method url-fetch)
+              ;;(uri (pypi-uri "synapseclient" version))
+              ;;(sha256
+              ;; (base32
+              ;;  "1g2n5bbq5vkvprk4ap3sbz2q39cjwl8igy3krlskg34c1q7if7r4"))))
+    (build-system python-build-system)
+    (arguments
+     '(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'relax-version-requirements
+           (lambda _
+             (substitute* "setup.py"
+               (("keyring>=15,<23\\.5") "keyring>=15")
+               (("keyrings\\.alt==3\\.1") "keyrings.alt>=3.1"))))
+         (add-before 'build 'set-homeless-shelter
+           (lambda _
+             ;; could not create '/homeless-shelter': Permission denied
+             (setenv "HOME" "/tmp")))
+         (replace 'check
+           (lambda* (#:key tests? #:allow-other-keys)
+             (when tests?
+               ;; these tests require server authentification  SynapseNoCredentialsError
+               (delete-file-recursively "tests/integration/synapseclient")
+               (delete-file-recursively "tests/integration/synapseutils")
+               (invoke "pytest")))))))
+    (propagated-inputs
+     (list python-deprecated
+           python-keyring
+           python-keyrings.alt
+           python-requests))
+    (native-inputs
+     (list python-boto3
+           python-flake8-3.8
+           python-pandas
+           python-psutil
+           python-pytest
+           python-pytest-mock
+           python-pytest-xdist-next))
+    (home-page "https://www.synapse.org")
+    (synopsis "Client for Synapse, a collaborative compute space")
+    (description
+     "This package provides a client for @code{Synapse}, a collaborative compute
+space that allows scientists to share and analyze data together.")
+    (license license:asl2.0)))
+
 (define-public python-q
   (package
     (name "python-q")

base-commit: c4025af8c11c3e9ea0c2747b6c475c916fb61d80
-- 
2.38.1

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: =?UTF-8?Q?M=C4=83d=C4=83lin?= Ionel =?UTF-8?Q?Patra=C8=99cu?=
 <madalinionel.patrascu@HIDDEN>
Subject: bug#59239: Acknowledgement ([PATCH] gnu: Add python-synapseclient.)
Message-ID: <handler.59239.B.166831822216532.ack <at> debbugs.gnu.org>
References: <20221113054308.5582-1-madalinionel.patrascu@HIDDEN>
X-Gnu-PR-Message: ack 59239
X-Gnu-PR-Package: guix-patches
X-Gnu-PR-Keywords: patch
Reply-To: 59239 <at> debbugs.gnu.org
Date: Sun, 13 Nov 2022 05:44:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

As you requested using X-Debbugs-CC, your message was also forwarded to
  rekado@HIDDEN
(after having been given a bug report number, if it did not have one).

Your message has been sent to the package maintainer(s):
 guix-patches@HIDDEN

If you wish to submit further information on this problem, please
send it to 59239 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
59239: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D59239
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to guix-patches@HIDDEN:

Subject: [bug#59239] [PATCH] gnu: Add python-synapseclient.
References: <20221113054308.5582-1-madalinionel.patrascu@HIDDEN>
In-Reply-To: <20221113054308.5582-1-madalinionel.patrascu@HIDDEN>
Resent-From: Jonathan Brielmaier <jonathan.brielmaier@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 17 Nov 2022 10:16:02 +0000
Resent-Message-ID: <handler.59239.B59239.166868010313140 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 59239 <at> debbugs.gnu.org
Message-ID: <3b11534b-362d-288c-92d8-a590798cfacf@HIDDEN>
Date: Thu, 17 Nov 2022 11:14:52 +0100
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.1
Content-Language: de-DE
From: Jonathan Brielmaier <jonathan.brielmaier@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
UI-OutboundReport: notjunk:1;M01:P0:mOy9cIAuQJ0=;mKK/mK1SY+dxLvMP/7ogsv0bic8
 fkarYbHPeS0vspe5DNfeFF9K5XNpqw5TM2d7xa7a6kuBurJdEm/fQYBjdPtUjR9Gv7uZmMr6h
 /rokO+k5W0pzkkPjgmcAt5bq/3dsQC2nTgJiSNM2QFkhqcv4uu3M+E+h9/Sx5S7s2z9djM61p
 4xn6rpnpKhsRbRyeX2oituMxJo8VDT0gN4CMPG+/kgr0GL3lREbK5jGKeWEHfu5I3iTHizxxY
 5lx+u089NjKKNH7Cq1oD7E40d1fwsBDE449Nqe4+AWM6ePv8VfHCsi6K0cCQB+YGY6jcLHGOy
 Z3tgSRltw9gE58ATMzfwX+uNZafoofYfAAc6jFZidXna/+ZKdDPxpPRpsQy6/onE8C+k7UKwA
 /4Z7+mRROpI2yvc3+gulYsn9L8HVYOBPIr7jiA6dLWdw3/xRvA6rETNjBElUEG4J8QJ7L+dlw
 pLG+hD6Z9M7nQxw/n2hcMTiHJukJzVpYJi/Js3cCOB32SueZDF6tlLAlVsLhDxMttpEw1hrEs
 fA1tIaOAhUQH739SaiZnUcqcyeXFYspYoL90Rwk2T4pCZEpJ4t0NsyJIcvX0LYlZ2/RaQnq0w
 tbWLhpWAFAMHs53oniIcui27OESIM/kxoEg2NL/7Q3lrb9ZDxtlhNvcBKgwZobt6mBPvJDXfo
 0k4KVBdPS7NKpiR0fGRe5cHT1xkoImCVUP/ZcEco64l5HI8NOb0v2bf1CKV6tHvDPKG/8wfEZ
 lSv06OxbESk7NAGqSZ6phbbVilr4koFMWhQ/nPuzGXJrnOcw0d/XHoc2iTQPk379SiuTMOCnk
 UVEHEOOY5uP1qsN0WRIbIk5fwlYdwpvLIQlOz/V+54k3A2/F/WMUqqkZxL5qmsOKo7gfmxwV0
 tB0rL54q92tffr8pcjEdM2Cvyl1IOZhzw+Q2AbDSr0VAnGjn+/V763qS5mb5hGPa+1zQ7L+UY
 ABymYA==
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi Mandalin,

I think there are some leftovers included in the patch:
https://issues.guix.gnu.org/59239#0-lineno29

~Jonathan

Message sent to guix-patches@HIDDEN:

Subject: [bug#59239] [PATCH] gnu: Add python-synapseclient.
Resent-From: Ricardo Wurmus <rekado@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Thu, 17 Nov 2022 11:29:01 +0000
Resent-Message-ID: <handler.59239.B59239.166868453121075 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: =?UTF-8?Q?M=C4=83d=C4=83lin?= Ionel =?UTF-8?Q?Patra=C8=99cu?= <madalinionel.patrascu@HIDDEN>
Cc: 59239 <at> debbugs.gnu.org
References: <20221113054308.5582-1-madalinionel.patrascu@HIDDEN>
User-agent: mu4e 1.8.9; emacs 28.1
From: Ricardo Wurmus <rekado@HIDDEN>
Date: Thu, 17 Nov 2022 12:24:27 +0100
In-reply-to: <20221113054308.5582-1-madalinionel.patrascu@HIDDEN>
Message-ID: <87v8ndu8ew.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Hi M=C4=83d=C4=83lin,

> * gnu/packages/python-xyz.scm (python-synapseclient): New variable.
[=E2=80=A6]

> +              ;;(method url-fetch)
> +              ;;(uri (pypi-uri "synapseclient" version))
> +              ;;(sha256
> +              ;; (base32
> +              ;;  "1g2n5bbq5vkvprk4ap3sbz2q39cjwl8igy3krlskg34c1q7if7r4"=
))))

Please remove this commented code.

> +    (build-system python-build-system)
> +    (arguments
> +     '(#:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'relax-version-requirements
> +           (lambda _
> +             (substitute* "setup.py"
> +               (("keyring>=3D15,<23\\.5") "keyring>=3D15")

Is this really a good idea?  Upper bounds usually exist for a reason.
We currently have version 23.9.  Can you please clear this with upstream
first?

> +               (("keyrings\\.alt=3D=3D3\\.1") "keyrings.alt>=3D3.1"))))
> +         (add-before 'build 'set-homeless-shelter
> +           (lambda _
> +             ;; could not create '/homeless-shelter': Permission denied
> +             (setenv "HOME" "/tmp")))

We=E2=80=99re setting HOME, not homeless-shelter.

> +         (replace 'check
> +           (lambda* (#:key tests? #:allow-other-keys)
> +             (when tests?
> +               ;; these tests require server authentification  SynapseNo=
CredentialsError
> +               (delete-file-recursively "tests/integration/synapseclient=
")
> +               (delete-file-recursively "tests/integration/synapseutils")
> +               (invoke "pytest")))))))

typo: =E2=80=9Cauthentication=E2=80=9D.  What exactly does this error mean?=
  Does it
talk to the internet?  How are these tests supposed to be run?

Is it possible to disable these tests with an option to pytest?  That
would seem better than conditionally deleting them.

Finally, I think the test files should be deleted unconditionally, so
that =E2=80=9Ctests?=E2=80=9D only governs whether the tests are *run* inst=
ead of also
causing other side effects.

--=20
Ricardo

Message sent to guix-patches@HIDDEN:

X-Loop: help-debbugs@HIDDEN
Subject: [bug#59239] [PATCH] gnu: Add python-synapseclient.
Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 21 Mar 2023 13:07:01 +0000
Resent-Message-ID: <handler.59239.B59239.167940397824195 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 59239
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: Ricardo Wurmus <rekado@HIDDEN>
Cc: 59239 <at> debbugs.gnu.org, =?UTF-8?Q?M=C4=83d=C4=83lin?= Ionel =?UTF-8?Q?Patra=C8=99cu?= <madalinionel.patrascu@HIDDEN>
Received: via spool by 59239-submit <at> debbugs.gnu.org id=B59239.167940397824195
          (code B ref 59239); Tue, 21 Mar 2023 13:07:01 +0000
Received: (at 59239) by debbugs.gnu.org; 21 Mar 2023 13:06:18 +0000
Received: from localhost ([127.0.0.1]:57877 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pebgw-0006IB-3j
	for submit <at> debbugs.gnu.org; Tue, 21 Mar 2023 09:06:18 -0400
Received: from mail-qt1-f176.google.com ([209.85.160.176]:45939)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1pebgu-0006Hy-Je
 for 59239 <at> debbugs.gnu.org; Tue, 21 Mar 2023 09:06:16 -0400
Received: by mail-qt1-f176.google.com with SMTP id t19so3577533qta.12
 for <59239 <at> debbugs.gnu.org>; Tue, 21 Mar 2023 06:06:16 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20210112; t=1679403971;
 h=content-transfer-encoding:mime-version:user-agent:message-id
 :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=kzrtCevSCIXeippk59wY2rFQLaUp5mZ2veQy9aLuX78=;
 b=VS0yNidoDNfPKCYMjD1FCU8cTC4UdpA90R2a1b5I/pFkhRb6CXWH9eMqXZVILzh3++
 nbqTtcYvbuz1eGM05hdpWYUjngDcW0jpQStIuxejNUEHvFDmXmbykYAH8nV6T2PbYcwJ
 WsjrXAwl0M4y1kVSzHG+R8ZYn1o6EeCKiJl09YhAFFnx3ippSiVFzEd33CtHOGPhypXz
 h+IZCZvRROc/w4UMvjMzpTf8Swvqi7S4WhiY0G5qlkKrmX6rlOlCUCYAZMIyv7yEKZIU
 GtguQTfUv45LaN2Lbk/5ewrloeHm/pGl+dLaN3GtG48TxOuozF1oTMje2K494UnOsf7z
 9jfQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112; t=1679403971;
 h=content-transfer-encoding:mime-version:user-agent:message-id
 :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=kzrtCevSCIXeippk59wY2rFQLaUp5mZ2veQy9aLuX78=;
 b=fY5g6nmOwrJB9lB7tFGUrXOWBdvSpe5MfXHI01rMnS35gcjlcdfgjHnf9mztefRI7d
 kFDl59O4Q/L2rviSuVrUaO9iO3P6qz1+e/2aHs/npzQwJcXQE7SEFB0yhlGzJaF4DDAy
 lSxzk8Tk7pgKIXoeYom5QTwzqIfcQW6iMLm0d5ryicraWN1Gz8lSlr27v/EWBjmrHslr
 QMrj+3ik0RWJlBj4mUUqKyII6hCuktxa1ysKLk2iEMYVWHTpflts+bbdKEXvLJhzdr0X
 CisUkLP8wDS284FwbUFcYWQuJuLZuRxWxQFVcBOg8ZS0B7RMVGsFQ7W03n8Wa9zuue0w
 n+nQ==
X-Gm-Message-State: AO0yUKU0wHjQxew1RNO8sFnygC9g4gdgTD6ZHrc0LJyJrwGKjX5c51v2
 qhpa8lV0lXrbuy6yEP9wCETGZCeApMB+yw==
X-Google-Smtp-Source: AK7set8gyagrgOSf+RsMIW6oJBpwMCSDOH803v1cJ2OoAunIfO2KsRCobPCT+Gs+5aOz5Ru+g/yyXQ==
X-Received: by 2002:a05:622a:1a86:b0:3b3:7d5:a752 with SMTP id
 s6-20020a05622a1a8600b003b307d5a752mr3813417qtc.50.1679403970971; 
 Tue, 21 Mar 2023 06:06:10 -0700 (PDT)
Received: from hurd (dsl-10-130-195.b2b2c.ca. [72.10.130.195])
 by smtp.gmail.com with ESMTPSA id
 i18-20020ac84f52000000b003d621964626sm8363391qtw.8.2023.03.21.06.06.10
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 21 Mar 2023 06:06:10 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
References: <20221113054308.5582-1-madalinionel.patrascu@HIDDEN>
 <87v8ndu8ew.fsf@HIDDEN>
Date: Tue, 21 Mar 2023 09:06:09 -0400
In-Reply-To: <87v8ndu8ew.fsf@HIDDEN> (Ricardo Wurmus's message of "Thu,
 17 Nov 2022 12:24:27 +0100")
Message-ID: <87edpis18e.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hello M=C4=83d=C4=83lin,

Ricardo Wurmus <rekado@HIDDEN> writes:

> Hi M=C4=83d=C4=83lin,
>
>> * gnu/packages/python-xyz.scm (python-synapseclient): New variable.
> [=E2=80=A6]
>
>> +              ;;(method url-fetch)
>> +              ;;(uri (pypi-uri "synapseclient" version))
>> +              ;;(sha256
>> +              ;; (base32
>> +              ;;  "1g2n5bbq5vkvprk4ap3sbz2q39cjwl8igy3krlskg34c1q7if7r4=
"))))
>
> Please remove this commented code.
>
>> +    (build-system python-build-system)
>> +    (arguments
>> +     '(#:phases
>> +       (modify-phases %standard-phases
>> +         (add-after 'unpack 'relax-version-requirements
>> +           (lambda _
>> +             (substitute* "setup.py"
>> +               (("keyring>=3D15,<23\\.5") "keyring>=3D15")
>
> Is this really a good idea?  Upper bounds usually exist for a reason.
> We currently have version 23.9.  Can you please clear this with upstream
> first?
>
>> +               (("keyrings\\.alt=3D=3D3\\.1") "keyrings.alt>=3D3.1"))))
>> +         (add-before 'build 'set-homeless-shelter
>> +           (lambda _
>> +             ;; could not create '/homeless-shelter': Permission denied
>> +             (setenv "HOME" "/tmp")))
>
> We=E2=80=99re setting HOME, not homeless-shelter.
>
>> +         (replace 'check
>> +           (lambda* (#:key tests? #:allow-other-keys)
>> +             (when tests?
>> +               ;; these tests require server authentification  SynapseN=
oCredentialsError
>> +               (delete-file-recursively "tests/integration/synapseclien=
t")
>> +               (delete-file-recursively "tests/integration/synapseutils=
")
>> +               (invoke "pytest")))))))
>
> typo: =E2=80=9Cauthentication=E2=80=9D.  What exactly does this error mea=
n?  Does it
> talk to the internet?  How are these tests supposed to be run?
>
> Is it possible to disable these tests with an option to pytest?  That
> would seem better than conditionally deleting them.
>
> Finally, I think the test files should be deleted unconditionally, so
> that =E2=80=9Ctests?=E2=80=9D only governs whether the tests are *run* in=
stead of also
> causing other side effects.

Genle ping.  Could you please send a v2 with the above suggested
changes?

--=20
Thanks,
Maxim

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 21 Mar 2023 19:51:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Mar 21 15:51:15 2023
Received: from localhost ([127.0.0.1]:60774 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pei0p-0003eX-Ht
	for submit <at> debbugs.gnu.org; Tue, 21 Mar 2023 15:51:15 -0400
Received: from mail-qt1-f170.google.com ([209.85.160.170]:35484)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1pei0n-0003eK-NY
 for control <at> debbugs.gnu.org; Tue, 21 Mar 2023 15:51:13 -0400
Received: by mail-qt1-f170.google.com with SMTP id ga7so578452qtb.2
 for <control <at> debbugs.gnu.org>; Tue, 21 Mar 2023 12:51:13 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20210112; t=1679428268;
 h=subject:from:to:message-id:date:from:to:cc:subject:date:message-id
 :reply-to; bh=w4C+PP9UtnomG74lcAZTP/Wvzq79SndmhXZ+1bdjHfc=;
 b=lZHwiugzV2lG7Bgjw5r5kyUbYRh/oblWo2w0KOBXtc4u80knbUdbOec/ihI1FuUgkR
 FIYy5NXTJw2tJWVCqujBvbDQes0ely7hGUokN0CfJ9Wn9kU8Q9Iydj0YuyhzPL1e/kod
 kPPL5GVA4hGtloyNfJnlDin3ZNJ7a9k8QePJslUnpIvck59zlS1oFJK1m3S34i9i5bJD
 ACfHhgfE5vLsTtQ98fxMb455vn2h27+NoVdpYl5gQuKtd5tPrz3EJhkyjFe2dF2rROMi
 2GeLMG4/olVnyZnDfpaVl8oReOeXjjXt/NyBSjJlBDHUMhdqUIa6LTpu4KV1v8GbTUiw
 V63Q==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112; t=1679428268;
 h=subject:from:to:message-id:date:x-gm-message-state:from:to:cc
 :subject:date:message-id:reply-to;
 bh=w4C+PP9UtnomG74lcAZTP/Wvzq79SndmhXZ+1bdjHfc=;
 b=soYnk/oVyqDr/fgQJ32pXaFk+n64HrU1Vlv8TTK4DyU5ps2Z0T+qyfi8wYlGoiJ4jq
 AKCCltsfgCvbOSTrfMUxKWicxtFhzhEK9w1VU+1Wc451ZO/YXYMOgTolnrwWDoqa01TA
 dHDBIogFLt1aermTMDkzD3E4MklKEqqm+TwC+O0FGR6gxxO5D33/mXMufmkgi7J1Q2pl
 LZiUlF1bKkZ4d72flvtRl2BJlPYesXlyPsTJwaIz2L78x8+gNd7kFizy9jGYVMLNIQ22
 fDKKVXzVMZvBJGtgh05/1QiK6B0lkkDQcun69AvQJ4JUSoGXzJXglx7RYv64eNfdsUrh
 4/qw==
X-Gm-Message-State: AO0yUKU1hHhNrcAh7T/QLT9Ijt+QHYGtZUhwIDN/QWNKccKcDCVp5FQE
 b4OaVfdDmxOTbX+RoMqF+KSek7P4NKaSDA==
X-Google-Smtp-Source: AK7set/5hyjYpx01AOv8gGOHzgCIKfwL1Y3TD8is8e9vIY6g29E4PuWRqfd8eDtLKEGJt/mpitDrrg==
X-Received: by 2002:a05:622a:1745:b0:3bd:db4:b967 with SMTP id
 l5-20020a05622a174500b003bd0db4b967mr1761824qtk.58.1679428268084; 
 Tue, 21 Mar 2023 12:51:08 -0700 (PDT)
Received: from hurd (dsl-10-130-195.b2b2c.ca. [72.10.130.195])
 by smtp.gmail.com with ESMTPSA id
 207-20020a3703d8000000b007468ec2e5dcsm3645432qkd.87.2023.03.21.12.51.07
 for <control <at> debbugs.gnu.org>
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Tue, 21 Mar 2023 12:51:07 -0700 (PDT)
Date: Tue, 21 Mar 2023 15:51:06 -0400
Message-Id: <87cz51nas5.fsf@HIDDEN>
To: control <at> debbugs.gnu.org
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Subject: control message for bug #59239
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

tags 59239 + moreinfo
quit

Last modified: Tue, 21 Mar 2023 20:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.