GNU bug report logs - #59252
29.0.50; Add new ts-modes to eglot-server-programs

Previous Next

Package: emacs;

Reported by: Theodor Thornhill <theo <at> thornhill.no>

Date: Sun, 13 Nov 2022 20:58:01 UTC

Severity: normal

Tags: patch

Merged with 59229

Found in version 29.0.50

Fixed in version 29.1

Done: Stefan Kangas <stefankangas <at> gmail.com>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59252 in the body.
You can then email your comments to 59252 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#59252; Package emacs. (Sun, 13 Nov 2022 20:58:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Theodor Thornhill <theo <at> thornhill.no>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Sun, 13 Nov 2022 20:58:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.50; Add new ts-modes to eglot-server-programs
Date: Sun, 13 Nov 2022 21:56:57 +0100
[Message part 1 (text/plain, inline)]
Hi there!

It seems my new ts-mode was already added to the eglot-server-programs,
so why not also add the others that were added to feature/tree-sitter?

This patch fixes that :-)

Theo

[0001-Add-new-ts-modes-to-eglot-server-programs.patch (text/x-diff, attachment)]

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#59252; Package emacs. (Mon, 14 Nov 2022 03:26:01 GMT) Full text and rfc822 format available.

Message #8 received at 59252 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: 59252 <at> debbugs.gnu.org
Subject: Re: bug#59252: 29.0.50; Add new ts-modes to eglot-server-programs
Date: Mon, 14 Nov 2022 05:25:06 +0200
> Date: Sun, 13 Nov 2022 21:56:57 +0100
> From:  Theodor Thornhill via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> It seems my new ts-mode was already added to the eglot-server-programs,
> so why not also add the others that were added to feature/tree-sitter?

Because I asked to wait with this until tree-sitter lands on master.
As you yourself know, we are still debating whether to make these
modes separate major modes or minor variations of existing modes.
There's no need to rush with trivial changes that will need to be
undone later.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#59252; Package emacs. (Mon, 14 Nov 2022 06:23:01 GMT) Full text and rfc822 format available.

Message #11 received at 59252 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 59252 <at> debbugs.gnu.org
Subject: Re: bug#59252: 29.0.50; Add new ts-modes to eglot-server-programs
Date: Mon, 14 Nov 2022 07:21:54 +0100

On 14 November 2022 04:25:06 CET, Eli Zaretskii <eliz <at> gnu.org> wrote:
>> Date: Sun, 13 Nov 2022 21:56:57 +0100
>> From:  Theodor Thornhill via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> 
>> It seems my new ts-mode was already added to the eglot-server-programs,
>> so why not also add the others that were added to feature/tree-sitter?
>
>Because I asked to wait with this until tree-sitter lands on master.
>As you yourself know, we are still debating whether to make these
>modes separate major modes or minor variations of existing modes.
>There's no need to rush with trivial changes that will need to be
>undone later.

Sure :-)
You can close this then.





Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#59252; Package emacs. (Mon, 14 Nov 2022 13:11:02 GMT) Full text and rfc822 format available.

Message #14 received at 59252 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: 59252 <at> debbugs.gnu.org
Subject: Re: bug#59252: 29.0.50; Add new ts-modes to eglot-server-programs
Date: Mon, 14 Nov 2022 15:10:11 +0200
> Date: Mon, 14 Nov 2022 07:21:54 +0100
> From: Theodor Thornhill <theo <at> thornhill.no>
> CC: 59252 <at> debbugs.gnu.org
> 
> 
> 
> On 14 November 2022 04:25:06 CET, Eli Zaretskii <eliz <at> gnu.org> wrote:
> >> Date: Sun, 13 Nov 2022 21:56:57 +0100
> >> From:  Theodor Thornhill via "Bug reports for GNU Emacs,
> >>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> >> 
> >> It seems my new ts-mode was already added to the eglot-server-programs,
> >> so why not also add the others that were added to feature/tree-sitter?
> >
> >Because I asked to wait with this until tree-sitter lands on master.
> >As you yourself know, we are still debating whether to make these
> >modes separate major modes or minor variations of existing modes.
> >There's no need to rush with trivial changes that will need to be
> >undone later.
> 
> Sure :-)
> You can close this then.

Let's wait until the branch lands, and revisit this then.

Thanks.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#59252; Package emacs. (Mon, 14 Nov 2022 14:29:02 GMT) Full text and rfc822 format available.

Message #17 received at 59252 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 59252 <at> debbugs.gnu.org
Subject: Re: bug#59252: 29.0.50; Add new ts-modes to eglot-server-programs
Date: Mon, 14 Nov 2022 15:28:12 +0100
Eli Zaretskii <eliz <at> gnu.org> writes:

>> Date: Mon, 14 Nov 2022 07:21:54 +0100
>> From: Theodor Thornhill <theo <at> thornhill.no>
>> CC: 59252 <at> debbugs.gnu.org
>> 
>> 
>> 
>> On 14 November 2022 04:25:06 CET, Eli Zaretskii <eliz <at> gnu.org> wrote:
>> >> Date: Sun, 13 Nov 2022 21:56:57 +0100
>> >> From:  Theodor Thornhill via "Bug reports for GNU Emacs,
>> >>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> >> 
>> >> It seems my new ts-mode was already added to the eglot-server-programs,
>> >> so why not also add the others that were added to feature/tree-sitter?
>> >
>> >Because I asked to wait with this until tree-sitter lands on master.
>> >As you yourself know, we are still debating whether to make these
>> >modes separate major modes or minor variations of existing modes.
>> >There's no need to rush with trivial changes that will need to be
>> >undone later.
>> 
>> Sure :-)
>> You can close this then.
>
> Let's wait until the branch lands, and revisit this then.
>
> Thanks.

Sure!




Added tag(s) patch. Request was from Stefan Kangas <stefankangas <at> gmail.com> to control <at> debbugs.gnu.org. (Thu, 24 Nov 2022 18:38:04 GMT) Full text and rfc822 format available.

Forcibly Merged 59229 59252. Request was from Stefan Kangas <stefankangas <at> gmail.com> to control <at> debbugs.gnu.org. (Thu, 24 Nov 2022 19:20:03 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#59252; Package emacs. (Sat, 26 Nov 2022 20:16:02 GMT) Full text and rfc822 format available.

Message #24 received at 59252 <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 59252 <at> debbugs.gnu.org,
 João Távora <joaotavora <at> gmail.com>
Subject: Re: bug#59252: 29.0.50; Add new ts-modes to eglot-server-programs
Date: Sat, 26 Nov 2022 21:15:05 +0100
[Message part 1 (text/plain, inline)]
Hi again!

>>> 
>>> Sure :-)
>>> You can close this then.
>>
>> Let's wait until the branch lands, and revisit this then.
>>

It seems like js-ts-mode is the only one missing, so here's a new patch
adding that.

Theo

[0001-Add-js-ts-mode-to-eglot-server-programs.patch (text/x-diff, attachment)]

Reply sent to Stefan Kangas <stefankangas <at> gmail.com>:
You have taken responsibility. (Sun, 27 Nov 2022 07:05:01 GMT) Full text and rfc822 format available.

Notification sent to Theodor Thornhill <theo <at> thornhill.no>:
bug acknowledged by developer. (Sun, 27 Nov 2022 07:05:01 GMT) Full text and rfc822 format available.

Message #29 received at 59252-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Theodor Thornhill <theo <at> thornhill.no>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 59252-done <at> debbugs.gnu.org,
 João Távora <joaotavora <at> gmail.com>
Subject: Re: bug#59252: 29.0.50; Add new ts-modes to eglot-server-programs
Date: Sat, 26 Nov 2022 23:04:52 -0800
Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife
of text editors" <bug-gnu-emacs <at> gnu.org> writes:

> It seems like js-ts-mode is the only one missing, so here's a new patch
> adding that.

Thanks, pushed (commit 40ff40198d) and closing this bug.

> From 2d179dd436f410bba30790fad60b04f9b338cc7b Mon Sep 17 00:00:00 2001
> From: Theodor Thornhill <theo <at> thornhill.no>
> Date: Sat, 26 Nov 2022 21:12:51 +0100
> Subject: [PATCH] Add js-ts-mode to eglot-server-programs
>
> * lisp/progmodes/eglot.el (eglot-server-programs): Add js-ts-mode as
> an alternative.

Please remember to add the bug number, like this:

* lisp/progmodes/eglot.el (eglot-server-programs): Add js-ts-mode as
an alternative.  (Bug#59252)

(I did that for you before pushing.)




Reply sent to Stefan Kangas <stefankangas <at> gmail.com>:
You have taken responsibility. (Sun, 27 Nov 2022 07:05:02 GMT) Full text and rfc822 format available.

Notification sent to Brian Leung <leungbk <at> posteo.net>:
bug acknowledged by developer. (Sun, 27 Nov 2022 07:05:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#59252; Package emacs. (Sun, 27 Nov 2022 07:12:02 GMT) Full text and rfc822 format available.

Message #37 received at 59252-done <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Stefan Kangas <stefankangas <at> gmail.com>, Eli Zaretskii <eliz <at> gnu.org>
Cc: 59252-done <at> debbugs.gnu.org,
 João Távora <joaotavora <at> gmail.com>
Subject: Re: bug#59252: 29.0.50; Add new ts-modes to eglot-server-programs
Date: Sun, 27 Nov 2022 08:11:00 +0100

On 27 November 2022 08:04:52 CET, Stefan Kangas <stefankangas <at> gmail.com> wrote:
>Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife
>of text editors" <bug-gnu-emacs <at> gnu.org> writes:
>
>> It seems like js-ts-mode is the only one missing, so here's a new patch
>> adding that.
>
>Thanks, pushed (commit 40ff40198d) and closing this bug.
>
>> From 2d179dd436f410bba30790fad60b04f9b338cc7b Mon Sep 17 00:00:00 2001
>> From: Theodor Thornhill <theo <at> thornhill.no>
>> Date: Sat, 26 Nov 2022 21:12:51 +0100
>> Subject: [PATCH] Add js-ts-mode to eglot-server-programs
>>
>> * lisp/progmodes/eglot.el (eglot-server-programs): Add js-ts-mode as
>> an alternative.
>
>Please remember to add the bug number, like this:
>
>* lisp/progmodes/eglot.el (eglot-server-programs): Add js-ts-mode as
>an alternative.  (Bug#59252)
>
>(I did that for you before pushing.)

Thanks - I can start creating the bug before the patch, so that I know what the bug number will be. It just often take a really long time before I get the acknowledge for the bug :)




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#59252; Package emacs. (Sun, 27 Nov 2022 07:24:02 GMT) Full text and rfc822 format available.

Message #40 received at 59252-done <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Theodor Thornhill <theo <at> thornhill.no>
Cc: 59252-done <at> debbugs.gnu.org, stefankangas <at> gmail.com, joaotavora <at> gmail.com
Subject: Re: bug#59252: 29.0.50; Add new ts-modes to eglot-server-programs
Date: Sun, 27 Nov 2022 09:23:29 +0200
> Date: Sun, 27 Nov 2022 08:11:00 +0100
> From: Theodor Thornhill <theo <at> thornhill.no>
> CC: 59252-done <at> debbugs.gnu.org,
>  João Távora <joaotavora <at> gmail.com>
> 
> >Please remember to add the bug number, like this:
> >
> >* lisp/progmodes/eglot.el (eglot-server-programs): Add js-ts-mode as
> >an alternative.  (Bug#59252)
> >
> >(I did that for you before pushing.)
> 
> Thanks - I can start creating the bug before the patch, so that I know what the bug number will be. It just often take a really long time before I get the acknowledge for the bug :)

If you send only a single message to the bug tracker, and include the patch
there, you indeed don't know the number, and then the person who pushed the
commit needs to add that.  This is okay.  There's no need to send the patch
in two parts (although you can do this if you feel like it).

But if you send an updated patch, and already know the bug number, please
add it.

Thanks.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#59252; Package emacs. (Sun, 27 Nov 2022 07:29:01 GMT) Full text and rfc822 format available.

Message #43 received at 59252-done <at> debbugs.gnu.org (full text, mbox):

From: Theodor Thornhill <theo <at> thornhill.no>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 59252-done <at> debbugs.gnu.org, stefankangas <at> gmail.com, joaotavora <at> gmail.com
Subject: Re: bug#59252: 29.0.50; Add new ts-modes to eglot-server-programs
Date: Sun, 27 Nov 2022 08:28:14 +0100

On 27 November 2022 08:23:29 CET, Eli Zaretskii <eliz <at> gnu.org> wrote:
>> Date: Sun, 27 Nov 2022 08:11:00 +0100
>> From: Theodor Thornhill <theo <at> thornhill.no>
>> CC: 59252-done <at> debbugs.gnu.org,
>>  João Távora <joaotavora <at> gmail.com>
>> 
>> >Please remember to add the bug number, like this:
>> >
>> >* lisp/progmodes/eglot.el (eglot-server-programs): Add js-ts-mode as
>> >an alternative.  (Bug#59252)
>> >
>> >(I did that for you before pushing.)
>> 
>> Thanks - I can start creating the bug before the patch, so that I know what the bug number will be. It just often take a really long time before I get the acknowledge for the bug :)
>
>If you send only a single message to the bug tracker, and include the patch
>there, you indeed don't know the number, and then the person who pushed the
>commit needs to add that.  This is okay.  There's no need to send the patch
>in two parts (although you can do this if you feel like it).
>
>But if you send an updated patch, and already know the bug number, please
>add it.
>
>Thanks.

Thanks, I forgot I sent an updated patch on this issue, as I sent several patches yesterday!

Will do that in the future :)
Theo




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 25 Dec 2022 12:24:07 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 94 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.