Stefan Kangas <stefankangas@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 59328) by debbugs.gnu.org; 25 Nov 2022 11:55:40 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 25 06:55:40 2022 Received: from localhost ([127.0.0.1]:33768 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oyXIy-0000uM-43 for submit <at> debbugs.gnu.org; Fri, 25 Nov 2022 06:55:40 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56374) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1oyXIv-0000u8-ME for 59328 <at> debbugs.gnu.org; Fri, 25 Nov 2022 06:55:38 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oyXIo-0003h7-Tb; Fri, 25 Nov 2022 06:55:30 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=wvLry783UEyeQkVwcWdCGvYI+Waqi7huXNc9dibQY1E=; b=msRJdZ9ArnnQ I6SJkSQGuTEMIp7K0lBEryPeyNhecjsb6iwpLJ3ccGG/tO2bwrJPy6rCETJMbJJtN6zc9+aYY9796 jKCAe9Dd2Qz/TLsmpLutuvxdFMwqo9Q8UxZqBBYlBpdMtboRl2WmzSOq6OoNvJaSKMVTvyhcAF2p4 wsSdr382OsIm91XYMEdddhHRPYHXdvPvhCYJVLJJ1TQZm9ZHblaGZwY6sMXNUltDQduVp16o8XoBF ArqxZQQIpnk5Pjsuzq6DL8o42vUVZ08ta4kfXI4J+I29OiLRnq1vdiNbGm0uQvgahcc01x5wa9eU+ IlJSP16FrUs2SfyigVQPRA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oyXIW-00069N-T7; Fri, 25 Nov 2022 06:55:21 -0500 Date: Fri, 25 Nov 2022 13:55:34 +0200 Message-Id: <83ilj3uu2x.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Michael Heerdegen <michael_heerdegen@HIDDEN> In-Reply-To: <87wn7jfjrg.fsf@HIDDEN> (message from Michael Heerdegen on Fri, 25 Nov 2022 10:47:31 +0100) Subject: Re: bug#59328: 29.0.50; `seq-keep' implementation only valid for lists References: <87wn7ujpdh.fsf@HIDDEN> <83edtz84wl.fsf@HIDDEN> <87pmdctsf8.fsf@HIDDEN> <83edtswi35.fsf@HIDDEN> <87fse8tona.fsf@HIDDEN> <83cz9cwg5z.fsf@HIDDEN> <87bkowtmmr.fsf@HIDDEN> <83a64gwfhv.fsf@HIDDEN> <877czktlvr.fsf@HIDDEN> <838rk0wak3.fsf@HIDDEN> <87wn7jfjrg.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59328 Cc: larsi@HIDDEN, jonas@HIDDEN, 59328 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Michael Heerdegen <michael_heerdegen@HIDDEN> > Cc: 59328 <at> debbugs.gnu.org, larsi@HIDDEN, jonas@HIDDEN > Date: Fri, 25 Nov 2022 10:47:31 +0100 > > Eli Zaretskii <eliz@HIDDEN> writes: > > > Can tests for this be written in a way that they are only run if the > > relevant packages are available on the user's system? If so, I'd > > prefer to have that than no tests at all. > > I don't know. AFAIK, 'require' can return nil if asked not to error out. > Alternatively we could implement `seq-map' for an ad-hoc defined > sequence type and test using that type, e.g. this expression: > > #+begin_src emacs-lisp > (progn > (defvar gensym) > (let ((gensym (make-symbol "foo"))) > (eval `(cl-defmethod seq-map (function (thing (head ,gensym))) > (append (list (car thing) (cadr thing)) (seq-map function (cddr thing)))) > t) > (equal (list gensym nil 4 46) > (seq-keep (lambda (x) (and (integerp x) (* 2 x))) > (list gensym nil 2 'x gensym 23))))) > #+end_src > > returns t with my patch installed and nil else and works without relying > on something external. I'm not sure if defining methods (for seq-map in > this case) that are globally visible is allowed in tests, so I > implemented the example above in a way that the change of the generic > function is not visible from the outside (thus the "secret" gensym). > > Would something like that be acceptable? > > Sorry for my ignorance, I didn't write much tests before. Sounds like over-engineering to me. Like I said: it's your call. If you see too many complications to adding a test, and my suggestions don't convince you, I won't object to installing your original proposal without a test. Thanks.
bug-gnu-emacs@HIDDEN:bug#59328; Package emacs.
Full text available.Received: (at 59328) by debbugs.gnu.org; 25 Nov 2022 11:34:57 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 25 06:34:57 2022 Received: from localhost ([127.0.0.1]:33734 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oyWyv-0000OI-2F for submit <at> debbugs.gnu.org; Fri, 25 Nov 2022 06:34:57 -0500 Received: from mail-oi1-f181.google.com ([209.85.167.181]:40717) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1oyWyt-0000O5-La for 59328 <at> debbugs.gnu.org; Fri, 25 Nov 2022 06:34:55 -0500 Received: by mail-oi1-f181.google.com with SMTP id n186so4112068oih.7 for <59328 <at> debbugs.gnu.org>; Fri, 25 Nov 2022 03:34:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=HO9H08x/LHZF6bBeIMyaG5hqKbRbT+UJTWvqE3A/iYc=; b=HDiJ2mJiU2fwnyBDUP2qXrGNliF0IhyQGtj2CqEvkR3bkm21AMSHq3Lhyvbgnly9+/ kgJkUsgNNBUpzbL2IVmQ4ScZ/CqSf3CC6n8QvxL+Ka2d6/+RRnREhuwu+dE1t5dv0GA8 rL5Sv2vHpk26g2EUPpHLcSXq0PDNFHV4V8DIPOCw5I50uG7s6Air3w3xW0iiSi43WRko EdhADEFvBCmF01f7x59iqnyBwo4gcVzRdSNJsq5qykkIFjHCeFuR7An0fayrf0dxSQhf PkevD+M//DZIWI69pCHQi11YPlePmE+IkgelFPFqzMbVYMqfiVSDa/XUWYA5BFMsnYAA ClzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=HO9H08x/LHZF6bBeIMyaG5hqKbRbT+UJTWvqE3A/iYc=; b=V2O6wAawTNoVKJ3K2h06V8v61T1t01BqTVgFZm4MM2O7bMPbpY3b+XijN6KQ6Sfc4A g8NGmhq4DK8jMzD5DOMKBcdlArnLwVNQaxP5723ztJEiTad0C3QCleNmmzLhf42gDRiE PeoWzWNahu9vZwndus2piIkZHCXzeFOAzo6WwTcle6PXKzg5XuiO2pOM31A9MGYlnahI 19EGGMEk5bboQUvyZYYghK5RYth5IwcncY9qqMWDWL6xYeKebtWAAq6kOYd4aUp/volf BuPzlbEhy8YUF2bsllI6vHExONp1e+KADP6wnQ9ku+MvbvlSEa8eKX08YRpfZuh0e73i 35wQ== X-Gm-Message-State: ANoB5pnHS1V7dIj5eHa7teDj1UOJpwinltPzoZcc7HvWqwhZ2DgU4Fdq 7C9Z5kZyeGZcIW9Kf7fQTU37p7JqHTY4Ks5jEms= X-Google-Smtp-Source: AA0mqf45GjycRLgH6Up/ch2nTMmkszZ0EGWkM/qCCo8CV0qs77bm0jVeXkWjjMJbF4aoHuiWKhfOd+LlUtFBKrUliwg= X-Received: by 2002:a05:6808:1287:b0:359:dc32:4f9e with SMTP id a7-20020a056808128700b00359dc324f9emr9708193oiw.92.1669376089863; Fri, 25 Nov 2022 03:34:49 -0800 (PST) MIME-Version: 1.0 References: <87wn7ujpdh.fsf@HIDDEN> <83edtz84wl.fsf@HIDDEN> <87pmdctsf8.fsf@HIDDEN> <83edtswi35.fsf@HIDDEN> <87fse8tona.fsf@HIDDEN> <83cz9cwg5z.fsf@HIDDEN> <87bkowtmmr.fsf@HIDDEN> <83a64gwfhv.fsf@HIDDEN> <877czktlvr.fsf@HIDDEN> <838rk0wak3.fsf@HIDDEN> <87wn7jfjrg.fsf@HIDDEN> In-Reply-To: <87wn7jfjrg.fsf@HIDDEN> From: Stefan Kangas <stefankangas@HIDDEN> Date: Fri, 25 Nov 2022 12:34:38 +0100 Message-ID: <CADwFkm=ASjCQAMwXD9Qxb0jb19xpUg7wQtegkN9w=GbARhXFKg@HIDDEN> Subject: Re: bug#59328: 29.0.50; `seq-keep' implementation only valid for lists To: Michael Heerdegen <michael_heerdegen@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59328 Cc: Eli Zaretskii <eliz@HIDDEN>, jonas@HIDDEN, 59328 <at> debbugs.gnu.org, larsi@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Michael Heerdegen <michael_heerdegen@HIDDEN> writes: > #+begin_src emacs-lisp > (progn > (defvar gensym) > (let ((gensym (make-symbol "foo"))) > (eval `(cl-defmethod seq-map (function (thing (head ,gensym))) > (append (list (car thing) (cadr thing)) (seq-map function (cddr thing)))) > t) > (equal (list gensym nil 4 46) > (seq-keep (lambda (x) (and (integerp x) (* 2 x))) > (list gensym nil 2 'x gensym 23))))) > #+end_src > > returns t with my patch installed and nil else and works without relying > on something external. I'm not sure if defining methods (for seq-map in > this case) that are globally visible is allowed in tests, so I > implemented the example above in a way that the change of the generic > function is not visible from the outside (thus the "secret" gensym). We allow things that are globally visible, yes, as that will only affect testing sessions. So I think dropping the gensym will be an improvement. > Would something like that be acceptable? Makes sense to me. Perhaps we should do something similar for other seq.el tests.
bug-gnu-emacs@HIDDEN:bug#59328; Package emacs.
Full text available.
Received: (at 59328) by debbugs.gnu.org; 25 Nov 2022 09:47:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 25 04:47:42 2022
Received: from localhost ([127.0.0.1]:33544 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oyVJ7-0003g6-QN
for submit <at> debbugs.gnu.org; Fri, 25 Nov 2022 04:47:42 -0500
Received: from mout.web.de ([212.227.15.4]:35377)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <michael_heerdegen@HIDDEN>) id 1oyVJ5-0003fq-Oc
for 59328 <at> debbugs.gnu.org; Fri, 25 Nov 2022 04:47:40 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273;
t=1669369652; bh=miAtC+62jY5ayWQYBFmmxA4d6JdnlsyMr8sJaKUND60=;
h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date;
b=kj4NlBEADJXqdkXeA1FHzUrdFcjod8N+8VTpa/61QjKHfra5L58KnwXcjVvRleeaK
Ya4UKfZia7IffBQOV/p79HJ11rnN+2daM4qi2nQfs2VNeM447YR383FR6GuDZGL404
XPeWe6O72D+aGa/3x8mDmVs6pZ6Z6WoT6AHQDHU8JfG2bFyHgLshxNAyJqKyuj4l/c
lZbg9oKMEAyJ9NjSeQpHgWq1NTdWJ21oms88nCL9nNmHVRRJAMbOedSJAocvbnUCbQ
QwyrDeyhZTLdBCSmXH285GZ8P8BYs9D5Hvj33HXCKtE8jN4BUGO13vdNfgYHp813yQ
gYbp5YUk7MJqg==
X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6
Received: from drachen.dragon ([92.76.229.140]) by smtp.web.de (mrweb005
[213.165.67.108]) with ESMTPSA (Nemesis) id 1MYLig-1pTyD823hC-00VMul; Fri, 25
Nov 2022 10:47:32 +0100
From: Michael Heerdegen <michael_heerdegen@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#59328: 29.0.50; `seq-keep' implementation only valid for lists
In-Reply-To: <838rk0wak3.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 24 Nov
2022 19:02:04 +0200")
References: <87wn7ujpdh.fsf@HIDDEN> <83edtz84wl.fsf@HIDDEN>
<87pmdctsf8.fsf@HIDDEN> <83edtswi35.fsf@HIDDEN>
<87fse8tona.fsf@HIDDEN> <83cz9cwg5z.fsf@HIDDEN>
<87bkowtmmr.fsf@HIDDEN> <83a64gwfhv.fsf@HIDDEN>
<877czktlvr.fsf@HIDDEN> <838rk0wak3.fsf@HIDDEN>
Date: Fri, 25 Nov 2022 10:47:31 +0100
Message-ID: <87wn7jfjrg.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Provags-ID: V03:K1:WLZmBXHVdzO10zfMlibjqeWz34QaJOR8bc/qY/PvJ1LhDGlLsq0
ULpdpkkRCaINXe8P8xPtWIZOfsJx7BpKijrvJZrU0uSgFOODwXPu6GIjxr5O/jDfEnuZzax
rifrIMLcixS56F4SHiY76IQiTdFduqthpJ2gNRV4m25O6b/7ZLIOa8XilHbTds7z/xip4Z6
KxfUJyhZ1ysS3DxsOF24A==
X-Spam-Flag: NO
UI-OutboundReport: notjunk:1;M01:P0:PVYG0SpLuc8=;3zYSkV+KryqCw7+KTffgOJKfj6p
f6NerJJZ+lMWSQqbPhqqGKweHrcjI/gPXwKsIokbHnrEEWu+c+TFUzj8pVv1HszDE1e5fgTM0
d0dI9fwrAq+c7iJNW0Z/BbVfhWCOLYiEUqqGRomwInLegGpqEMKCEhhSIOSPpNgGPn11fUIcY
p11eWX78WvOBk3H5XFA0OikArjtGFpZ9B9jcE55boRnllYFategCCTAqwgvS1ypA2VupzA97E
qnUWRbjUIKHgW/W1F4ASzUeRwQOXZ+mfYnfRGGYJTIoWw8iflhkiJ4wpdfbE/xywU2if4acR6
5GDZ6q/oXFm9YmjPXPqIJhEtazVviFyvVeV8WAKkPEa1/RarBZHdBrvfkNBr8SbCDJ4Ie0gkf
DNfKfsk/kK4piV73jwUun8gPbUU7s9APGiJxc4vyY9fQXeYwxJ3Llz+FilBygbua4i2em/UBq
iEXUn7vYYLSB+Dhe+jUrCZxvYR1WmUk22DkhHFDdwfQ2x7W0cwga2KN+FhgmNo04F4ZRS0DKV
XfGZYKrVfceumqzvfdUteUzqJY14+v8zkx913qRlTlYADtQnnAL0DACR9Ppj8I7GXH4kq8j/G
XpaNkxQntSHKO42LOH9PfizUFnK6XWhWdRCnpzkG1QzkpQGrL89wh+QXvc0Flj3DuX0nsZ0A8
vWqb4oO3ll6Ca5gMWRa5xO1cg1hzVv9U2Yxo2hZMYy/UGaQ3G5x8buBIAflGufLkzkrqJL5o9
7tWQTrC/nf7coAZLbH9FP5Jp1kMsh3KOfDiN+NND/Z+dkeKP1TLp5Et58hV/NxLGkM5QRW8xJ
QGkk//Pwee3c8RgB44uw+nsfJL0Mk3dLwHfqSgw7y5J7fvPLxV9S8lkJkAMhPLSvtcaFe9pVw
gEiptVM+BKK7XU7m0uYRjA8UQEh1gvnjeNkANLP6JB/mqmv5Ksb4zZmMoSlLORKkDfpP5izN1
ogytKgJjK6vdV0MoJiLvKy0ibIc=
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 59328
Cc: larsi@HIDDEN, jonas@HIDDEN, 59328 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Eli Zaretskii <eliz@HIDDEN> writes:
> Can tests for this be written in a way that they are only run if the
> relevant packages are available on the user's system? If so, I'd
> prefer to have that than no tests at all.
I don't know.
Alternatively we could implement `seq-map' for an ad-hoc defined
sequence type and test using that type, e.g. this expression:
#+begin_src emacs-lisp
(progn
(defvar gensym)
(let ((gensym (make-symbol "foo")))
(eval `(cl-defmethod seq-map (function (thing (head ,gensym)))
(append (list (car thing) (cadr thing)) (seq-map function (cddr thing))))
t)
(equal (list gensym nil 4 46)
(seq-keep (lambda (x) (and (integerp x) (* 2 x)))
(list gensym nil 2 'x gensym 23)))))
#+end_src
returns t with my patch installed and nil else and works without relying
on something external. I'm not sure if defining methods (for seq-map in
this case) that are globally visible is allowed in tests, so I
implemented the example above in a way that the change of the generic
function is not visible from the outside (thus the "secret" gensym).
Would something like that be acceptable?
Sorry for my ignorance, I didn't write much tests before.
TIA,
Michael.
bug-gnu-emacs@HIDDEN:bug#59328; Package emacs.
Full text available.Received: (at 59328) by debbugs.gnu.org; 24 Nov 2022 17:01:56 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 24 12:01:56 2022 Received: from localhost ([127.0.0.1]:59932 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oyFbo-0004jN-9Y for submit <at> debbugs.gnu.org; Thu, 24 Nov 2022 12:01:56 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59418) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1oyFbm-0004jA-1D for 59328 <at> debbugs.gnu.org; Thu, 24 Nov 2022 12:01:55 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oyFbf-00087d-Pz; Thu, 24 Nov 2022 12:01:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=CFlGJrNqugad19m6r/hL2TtvIQqtSV0MjgKKYsGZT1w=; b=ch6GyK/6g9DD 5NMjyyNBl7U8U7G9pvz87glJRULJgNMHoXAAKYVhN1TX+3Z/77gSf+nHUnQm8XTRdEnY8qB5K3CNv PpDBcGFLr5ttshrQ0Zxm5v0Dz9AP5/KNmAHtXRPedj86OoZZFW/Cemxho9vohHIhYNLah0lpb5Nhm hIuizeeJmP5f1C0OUfZFlw6RGbPWd/MbbgIUZCcgffrCTb0imMm9+fHhZhGMgoYXXg6xv82IeXNx5 5fEMa3Yz6EtLye/JJKu392kAKIchwekEOzskIpIVYlPTWzmyyb/0DFUEInljQM+xRrcDO7imTePnp 8Bjx3TKI3oRGX96yHjKalQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oyFbc-0003hF-Oc; Thu, 24 Nov 2022 12:01:47 -0500 Date: Thu, 24 Nov 2022 19:02:04 +0200 Message-Id: <838rk0wak3.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Michael Heerdegen <michael_heerdegen@HIDDEN> In-Reply-To: <877czktlvr.fsf@HIDDEN> (message from Michael Heerdegen on Thu, 24 Nov 2022 16:25:44 +0100) Subject: Re: bug#59328: 29.0.50; `seq-keep' implementation only valid for lists References: <87wn7ujpdh.fsf@HIDDEN> <83edtz84wl.fsf@HIDDEN> <87pmdctsf8.fsf@HIDDEN> <83edtswi35.fsf@HIDDEN> <87fse8tona.fsf@HIDDEN> <83cz9cwg5z.fsf@HIDDEN> <87bkowtmmr.fsf@HIDDEN> <83a64gwfhv.fsf@HIDDEN> <877czktlvr.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59328 Cc: larsi@HIDDEN, jonas@HIDDEN, 59328 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Michael Heerdegen <michael_heerdegen@HIDDEN> > Cc: 59328 <at> debbugs.gnu.org, larsi@HIDDEN, jonas@HIDDEN > Date: Thu, 24 Nov 2022 16:25:44 +0100 > > Eli Zaretskii <eliz@HIDDEN> writes: > > > > Without that change `seq-keep' would error for sequence types like > > > streams. Try for example > > > > > > #+begin_src emacs-lisp > > > (require 'stream) > > > (seq-keep > > > (lambda (x) (and (<= 0 x) x)) > > > (stream (list -1 2 -3 4))) > > > #+end_src > > > > Didn't you just say that 'stream' is not in Emacs? If I try the above, the > > debugger kicks in right on the 'require' line. > > Yes. > > But seq-keep is not a generic function, so it would be broken for > sequence types defined elsewhere, and there is no way for those other > sequence types to fix this. Defining a generic interface for sequences > would not make much sense if it then only supports lists (and maybe > vectors). > > So we want to support cases like streams. Can tests for this be written in a way that they are only run if the relevant packages are available on the user's system? If so, I'd prefer to have that than no tests at all. Your call. Thanks.
bug-gnu-emacs@HIDDEN:bug#59328; Package emacs.
Full text available.Received: (at 59328) by debbugs.gnu.org; 24 Nov 2022 15:25:54 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 24 10:25:54 2022 Received: from localhost ([127.0.0.1]:59827 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oyE6s-0008Qr-DV for submit <at> debbugs.gnu.org; Thu, 24 Nov 2022 10:25:54 -0500 Received: from mout.web.de ([212.227.15.3]:54303) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <michael_heerdegen@HIDDEN>) id 1oyE6q-0008Qa-NA for 59328 <at> debbugs.gnu.org; Thu, 24 Nov 2022 10:25:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1669303545; bh=HgL62QdvT6lGRM28Krat+mqUkiWXDide4zeC1BACMLc=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=RIxvrGh48A1M5M2y9t0O5ceGfJsRj/wiXSwchMKnROr+ZXiRDNIx6OcLGQO444ZZ6 YmO0Qtqxru9fsyJAn4vTtSZgFYeDdSiJuLRvCzCmHJ5zuUKu7MmNbc+kODfx+WH1xI ochrBC8k4U8ZzfkIzYf+DrCBIu4KNMvk1+cUSHgzt7LBW2n1x+M8H95A8RH0czNM1Q hbpMzTqDTcHrN55md2guH4r+9H6TBGhPwUU0W2SdjZdJEqPo5b+bI/IPbW6NXDcJ9S UTE89pZ6Vl/4lfh4cI8iCHE8YGUTlxpPCYaqlr3c2uMgOSnbG/UxudRzHucSkb2uLg P7WhHqVYhlRwQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([92.76.229.140]) by smtp.web.de (mrweb005 [213.165.67.108]) with ESMTPSA (Nemesis) id 1M9ISh-1oruyk0bZ9-006Ruh; Thu, 24 Nov 2022 16:25:45 +0100 From: Michael Heerdegen <michael_heerdegen@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#59328: 29.0.50; `seq-keep' implementation only valid for lists In-Reply-To: <83a64gwfhv.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 24 Nov 2022 17:15:24 +0200") References: <87wn7ujpdh.fsf@HIDDEN> <83edtz84wl.fsf@HIDDEN> <87pmdctsf8.fsf@HIDDEN> <83edtswi35.fsf@HIDDEN> <87fse8tona.fsf@HIDDEN> <83cz9cwg5z.fsf@HIDDEN> <87bkowtmmr.fsf@HIDDEN> <83a64gwfhv.fsf@HIDDEN> Date: Thu, 24 Nov 2022 16:25:44 +0100 Message-ID: <877czktlvr.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:ZQtBNHqRicjOwrAFZcLBIMb9Tat7QdaOq8b0CPLOoaJ5DyRdxyL 2W+Ra682ZWFeCpzRYUo9JERiZwRn77aZypq0JJUGrKEPcd/XjLIGr6N7IE/rkGm6rxlGGSo N3Eoqohp7Du2ywjmAwAvsg2qjmTOpMOhBMJeydOJJXoCJXJ1pqiUSpx+t9R4M0K+AO9Np/P 5HdzR/M0S1kPY1o4cs+IQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:i9y+3p5oymM=;Lez+9GpuMUnaQV7zwl2eVJnBKbv YZQe7/aSUWpKKOMxNoc/BuIWYkTZLZPNXLyuC4UOWl72IEJcwroZgPyUveqp4cZrmjEhQVmGn EUpE9+Q+6+srEDzU0LL2JcoalPctl8EAuypeZy3oLwoEFcfM5Wfp/L7zD5jD7YBpjkUVAwcsw hkZpmkWXjkBozpqg6pFfXfdG905m24uK1jc5uN3b3Sv5a+o6cn8yC86l24FLH7NnQMZK+XlMl 7Lik9+s9gsXncI71N0PXdqndibgiBM3KT874DRmZvEmKl4cPCF/9dCV2pK9YplOcc4j4WrkeA eHQhnfRFF0m/ODQplCXz05DfJkvhWfdvCjVx1wAsFda5uJ5eA6ovcprwLLCIe7n29udeJItHu pl+7LghIwz8eOVUMAfGHf/z6usWXWvRHHMk0exGk6AMkcwcr0iDx9SeDNhYYmSH2t/oOLF6D0 4v5vPQK/IXxNC0dpHmiuZcV8f6cSZu2sEEM2iAKMNgBr3nefbqedMnQBo7vrpv9zfxVGEKYED 7/+wmABFBdkwZfuZwW1Eizn5J26eY0uhLLNJUzQ8E/2ujfPaW5/g7kS5md3/rRNc5mxnlgx7i c7ZlA4esblT/w4jWl7AU0uPO4TIY7vyYLpUgFFG1zwfQuQ+V59qCJbmzJf9XFxqkAxy50m5wx Mq/9F9KOP8e6cm/js5BcrKeeC2R4DKhYmMcpxqLvafKYHSoRwVI7mNTBpSHX0aBxISlKWe45D TSXpvGZEcWvKrcKQSfS7dBapEhdAA+yqfP0Zuzf+WmNWCRTPzltPL9YLixPCaITJa/yub9Olh 91ZGNk4SXUoNe474Q+ol9o7WL4fnw1PYv2YFfqvexh9dkObJLGOks/NrXu7p6atIkhmiJYmh+ AQMb+wqYnTvrgNbb1t4z7DRhB/M/MDy0yTJsxLaXLkEpFSDbEU6IzkNGJpjYdnjok6JxwlLjJ zE1phrOxif8JQLvUu3xDCNNynYo= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59328 Cc: larsi@HIDDEN, jonas@HIDDEN, 59328 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Eli Zaretskii <eliz@HIDDEN> writes: > > Without that change `seq-keep' would error for sequence types like > > streams. Try for example > > > > #+begin_src emacs-lisp > > (require 'stream) > > (seq-keep > > (lambda (x) (and (<=3D 0 x) x)) > > (stream (list -1 2 -3 4))) > > #+end_src > > Didn't you just say that 'stream' is not in Emacs? If I try the above, = the > debugger kicks in right on the 'require' line. Yes. But seq-keep is not a generic function, so it would be broken for sequence types defined elsewhere, and there is no way for those other sequence types to fix this. Defining a generic interface for sequences would not make much sense if it then only supports lists (and maybe vectors). So we want to support cases like streams. Since seq-keep can be expressed and is semantically equivalent a simple concetanation of existing sequence operations there is probably no need to define it as generic function. We just need to implement it correctly to support any otherwise supported type of sequences. Michael.
bug-gnu-emacs@HIDDEN:bug#59328; Package emacs.
Full text available.Received: (at 59328) by debbugs.gnu.org; 24 Nov 2022 15:15:17 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 24 10:15:16 2022 Received: from localhost ([127.0.0.1]:59812 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oyDwa-00085X-K3 for submit <at> debbugs.gnu.org; Thu, 24 Nov 2022 10:15:16 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58004) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1oyDwY-00085E-Oz for 59328 <at> debbugs.gnu.org; Thu, 24 Nov 2022 10:15:15 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oyDwS-0004Zk-Um; Thu, 24 Nov 2022 10:15:08 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=yZi4iK+3SRQ5epvNHbIs8CD9IsM2xvU06EU0oYpq1eM=; b=G4OjvF+wI3vc 3qVhn5CFtsCMQrAMuR9fVa6+qYC0yCHawXLLHImCh+DnrjetTsYwaFewqISYMimbrQjrhH/QFzI8z fTCjEeZm2xbWJUzPW5T+K72URLQ6OMxA209IIFOVdD1FuMMrKo7f7UHvijIvrtTWGj5lEQukqT91Y o/uBGv6zmS65yXQ9AMflP8DFv1w5hPhBKLEJXpT4PRqCgGV+7VGJeLcVELGwcOUSKMyTgI65KI1HU Yx3LtEJrbfX2yvFqLs0YQM0nqJH/rvIh2twIHE9SBVK0ARhPcM8pwA5fsYYu6YvFii54C7cNC/9ov grpkaF6G3/BnaxpM+2A0oQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oyDwQ-00045K-PT; Thu, 24 Nov 2022 10:15:08 -0500 Date: Thu, 24 Nov 2022 17:15:24 +0200 Message-Id: <83a64gwfhv.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Michael Heerdegen <michael_heerdegen@HIDDEN> In-Reply-To: <87bkowtmmr.fsf@HIDDEN> (message from Michael Heerdegen on Thu, 24 Nov 2022 16:09:32 +0100) Subject: Re: bug#59328: 29.0.50; `seq-keep' implementation only valid for lists References: <87wn7ujpdh.fsf@HIDDEN> <83edtz84wl.fsf@HIDDEN> <87pmdctsf8.fsf@HIDDEN> <83edtswi35.fsf@HIDDEN> <87fse8tona.fsf@HIDDEN> <83cz9cwg5z.fsf@HIDDEN> <87bkowtmmr.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59328 Cc: larsi@HIDDEN, jonas@HIDDEN, 59328 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Michael Heerdegen <michael_heerdegen@HIDDEN> > Cc: 59328 <at> debbugs.gnu.org, larsi@HIDDEN, jonas@HIDDEN > Date: Thu, 24 Nov 2022 16:09:32 +0100 > > Eli Zaretskii <eliz@HIDDEN> writes: > > > OK, then just install this, though now I wonder why we need this change... > > Without that change `seq-keep' would error for sequence types like > streams. Try for example > > #+begin_src emacs-lisp > (require 'stream) > (seq-keep > (lambda (x) (and (<= 0 x) x)) > (stream (list -1 2 -3 4))) > #+end_src Didn't you just say that 'stream' is not in Emacs? If I try the above, the debugger kicks in right on the 'require' line.
bug-gnu-emacs@HIDDEN:bug#59328; Package emacs.
Full text available.Received: (at 59328) by debbugs.gnu.org; 24 Nov 2022 15:09:44 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 24 10:09:44 2022 Received: from localhost ([127.0.0.1]:59802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oyDrE-0007sD-Cf for submit <at> debbugs.gnu.org; Thu, 24 Nov 2022 10:09:44 -0500 Received: from mout.web.de ([212.227.15.4]:53565) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <michael_heerdegen@HIDDEN>) id 1oyDrC-0007rt-H6 for 59328 <at> debbugs.gnu.org; Thu, 24 Nov 2022 10:09:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1669302573; bh=EFpPqbQubx24a3Jn+GEZ8miPoLoarHLZL9FQnQ+40WU=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=mwatXJa1y2liLfDqEwQTexWSA3KzwUSs0jkucFSIdxxFCIilHeSpYPLTBRy9uNgLx vV/ts/jXoRlvpNqilg1lKM1ukmHjA8ebgSZCpUTQNZaoiPKmr8YSl4sRIaN4ezf1vp Tby7C3O489nZfDyPITqJzZX7Jq3L3RhVE0SctsSfWz5d74o3ZI08jddiD6gEe4kF30 8UbyoD4cudmnxnZJ+pht5OVgq1XId4DUGDq4WGka8Z4UO4GWtWK2zwoMJ6dtpTKiAN M9p0LxL8OGfN7lQG1KTNECnE4q26x9IKPhZ9JGWyHha1JCLNFpmXIT+rER05KJeZp+ fg74h+tSgbkuQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([92.76.229.140]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1M8Bvz-1ot13u1t11-005EnC; Thu, 24 Nov 2022 16:09:33 +0100 From: Michael Heerdegen <michael_heerdegen@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#59328: 29.0.50; `seq-keep' implementation only valid for lists In-Reply-To: <83cz9cwg5z.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 24 Nov 2022 17:00:56 +0200") References: <87wn7ujpdh.fsf@HIDDEN> <83edtz84wl.fsf@HIDDEN> <87pmdctsf8.fsf@HIDDEN> <83edtswi35.fsf@HIDDEN> <87fse8tona.fsf@HIDDEN> <83cz9cwg5z.fsf@HIDDEN> Date: Thu, 24 Nov 2022 16:09:32 +0100 Message-ID: <87bkowtmmr.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:HPr48Q4WDvGcEN2SAmjroHbWH03lZlgLmuosSeZdVCe9dWYsDzF KbwyuTV7HLfxSwMSilCo4l/PZGfSiTTkBdluaUVePkXQAc3sjgcESSKbKr2k6Hz9rtDbgX9 GZtMRScA7ewQg90+wMqizOKQ7PGeCOZAmIiEWKIhSxzQzTPNO+hRA/n67ucL1YTOf64wIgM kDM+F+8sK8KXcPhl4wdaw== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:aRxJQMXbEJg=;a4GoY7YH/J6evR5CJTjH+8wH1A0 HBFRVNf5nmVDld3rD1IqCpEybswnexo3AuMo1HMnZ5rxBWfSPbHq/KZoL2UUKj8R9OhZA4D6c 9fXeg9TqkHHxIMR0qZZ4ZR2W3OOhH8vJrZBw/Bw/9z1+MbklRnZIqHqqjU8HdfDO72BTWR9cG XdPcSxke2wprrZPf9OjfyjIp1HVnOthX8qszqEGbo03Yg6nOBVdNX2EcTeyQNTexc74dr8/lh 2/UPj6AgFL0S9gmmIXzURPBqbXU7DBJW1/Jpv2uAEAzdZUgeWeeanN0pqLlT6AEFk9FPBMA9t 54xVXKmkTC/+osIOStoJIEh2iZ2fzeqbWfEcjEak5HYnAm4NSxPxMa6comeHRK9VNmFW4c/6c XZvt02HrHCU7HFlf6V5rcmQw7IKHFCCbTiGKBdjYWUjDM4n7HNcm7oe5168ndEJHbBG2xWiov 4J1+J6Lb1EFJEFuknGZACoXecY7QMow+VwyF258WW5yEfO1g1CU2Pj9EcK7mKso5Xkkc0bD54 nGss+WZbZglHlQyLpcqi3iQAxTT2glp2WohvXtfUQNzQmo8iNEwVY5ju8CAAkZ4Sqs/IgB4Vz kOv/+fcs1w/g1KeA1accLc+4dtdGCLvCDB9XtRZOZLHJQASM4ebuGXiu1ifm6ZWE+wiLgTjQr ggp8w7m4I36OuQKCpabiK/eFNUehWH4iWBK+hGt7D37g7z8pIGTraJeZa0qIwzyy9TTa+4gZJ Hr/g6+J6e4AAV7DZ+6Mrz5WIxm50BI1uNnzXGWQl0BicVMdrHxRwrhoSpYJ3yh1kiPWgpyI3G 0oGlZvbZwUKIgGROnmSR1+bTStfUcvXV82lX0FVw6nrYfCoxc/3U8zPXz5PELa1YgawZKk6Zz rKytvLOZq9pXsS+w8Luh5iBAl+DlFkr6xQwodlcQx/u3fBgna7z5PaQhoBtpdP9xVAckE/N2Y 2t2D80wBeJNL8nH+oIEZVG7+Xd8= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59328 Cc: larsi@HIDDEN, jonas@HIDDEN, 59328 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Eli Zaretskii <eliz@HIDDEN> writes: > > Every kind of sequence (in the sense of seq.el) that exists in Emacs is > > not affected by the bug. A test makes only sense for types that are, > > but those are defined in libraries that are not in Gnu Emacs, only in > > Gnu Elpa. But I can't make the test depend on them. > > I see I was confused by the Subject of your bug report. > > OK, then just install this, though now I wonder why we need this change... Without that change `seq-keep' would error for sequence types like streams. Try for example #+begin_src emacs-lisp (require 'stream) (seq-keep (lambda (x) (and (<= 0 x) x)) (stream (list -1 2 -3 4))) #+end_src That errors without the proposed change but it's a legitimate call (and it should return a stream of course). Michael.
bug-gnu-emacs@HIDDEN:bug#59328; Package emacs.
Full text available.Received: (at 59328) by debbugs.gnu.org; 24 Nov 2022 15:00:52 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 24 10:00:52 2022 Received: from localhost ([127.0.0.1]:59792 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oyDid-0007et-TO for submit <at> debbugs.gnu.org; Thu, 24 Nov 2022 10:00:52 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1oyDib-0007eg-Tc for 59328 <at> debbugs.gnu.org; Thu, 24 Nov 2022 10:00:50 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oyDiV-0003tQ-Q1; Thu, 24 Nov 2022 10:00:43 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=9V0BKMVYQrN0Dyi663EzkLAwp7ROCdIRPbMsWHkpnEI=; b=Cj8miG9V+QTy Ph+wo6LgnZcTWLRAODkG9BSNQBZP343xY3g0UlTHIb4mSV5kiCBKg9//2D7RmKdHKqol0479PXr5r 1fbZdFML+g4z7CVZp//cjWC2JGnBWUZFDIdMR6fX//PWIxlr8pL+nzJGn3g6Tc377jUaIAjDFpZPw r7e38dRNr4Dy5tmd66LJ8CQFDGtCpUgUtFvDpWJcSH0tTdPsgYj8HffZeNvCCWWnOQ77P2w+Tjep2 /Y+AqnDGzaQXzadH8jMYSlbCbM222hKZphEnm2I1ePXMKMh2QCpnhiCu+z736wcD9rDp5H21GKEm1 1J6kcXicbMjwAbRPwezR2Q==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oyDiO-0004ab-Kd; Thu, 24 Nov 2022 10:00:43 -0500 Date: Thu, 24 Nov 2022 17:00:56 +0200 Message-Id: <83cz9cwg5z.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Michael Heerdegen <michael_heerdegen@HIDDEN> In-Reply-To: <87fse8tona.fsf@HIDDEN> (message from Michael Heerdegen on Thu, 24 Nov 2022 15:26:01 +0100) Subject: Re: bug#59328: 29.0.50; `seq-keep' implementation only valid for lists References: <87wn7ujpdh.fsf@HIDDEN> <83edtz84wl.fsf@HIDDEN> <87pmdctsf8.fsf@HIDDEN> <83edtswi35.fsf@HIDDEN> <87fse8tona.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59328 Cc: larsi@HIDDEN, jonas@HIDDEN, 59328 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Michael Heerdegen <michael_heerdegen@HIDDEN> > Cc: 59328 <at> debbugs.gnu.org, larsi@HIDDEN, jonas@HIDDEN > Date: Thu, 24 Nov 2022 15:26:01 +0100 > > Eli Zaretskii <eliz@HIDDEN> writes: > > > I don't understand: why cannot we add a test to Emacs, even though > > other tests are elsewhere? > > Every kind of sequence (in the sense of seq.el) that exists in Emacs is > not affected by the bug. A test makes only sense for types that are, > but those are defined in libraries that are not in Gnu Emacs, only in > Gnu Elpa. But I can't make the test depend on them. I see I was confused by the Subject of your bug report. OK, then just install this, though now I wonder why we need this change...
bug-gnu-emacs@HIDDEN:bug#59328; Package emacs.
Full text available.Received: (at 59328) by debbugs.gnu.org; 24 Nov 2022 14:26:13 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 24 09:26:13 2022 Received: from localhost ([127.0.0.1]:57814 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oyDB6-0006JE-LP for submit <at> debbugs.gnu.org; Thu, 24 Nov 2022 09:26:12 -0500 Received: from mout.web.de ([217.72.192.78]:43387) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <michael_heerdegen@HIDDEN>) id 1oyDB5-0006J1-5S for 59328 <at> debbugs.gnu.org; Thu, 24 Nov 2022 09:26:11 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1669299962; bh=KaY9WoicMryg2q/LuJGoc8phh7G2wTCW60Rbiy9MQi0=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=wm6tSUoYDZp9rg9mblKFbwH463lxTYS+eo2IccwISjhp47BZtqvsUt/z+lX8cpFYn R+xE1uio0+owyo6YjWqrZwet1X0nqm39S2wPg/QgPnzZan3xCki3oycyke4R4Me5nc spQsSJ4PX4LogjKXp1gf/Ligg0xwLZPXrKF4JBzqDWRCUpfIk23DEo4k9I4UKBZpD/ YK74Zo2xXtKT9/qPlqqnje5qy//PMKTO6ZW3mOWY/D/+3/bcIJyo+C4LYP2DX3SLzU pH0nh/sSuFDuus54SNcuCIR1SETD2qz7r2CaRUwMMo43pmTUKc68b6Zse1tS62vae7 tO37edJ/uFh0Q== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([92.76.229.140]) by smtp.web.de (mrweb105 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MXXRF-1oP9bp07xP-00Ysc5; Thu, 24 Nov 2022 15:26:02 +0100 From: Michael Heerdegen <michael_heerdegen@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#59328: 29.0.50; `seq-keep' implementation only valid for lists In-Reply-To: <83edtswi35.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 24 Nov 2022 16:19:26 +0200") References: <87wn7ujpdh.fsf@HIDDEN> <83edtz84wl.fsf@HIDDEN> <87pmdctsf8.fsf@HIDDEN> <83edtswi35.fsf@HIDDEN> Date: Thu, 24 Nov 2022 15:26:01 +0100 Message-ID: <87fse8tona.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:H+elbSrTX9nwkTyiU14cHhoaIV9vMnPc2QiWkD/Gp3S1jcwlGK2 elsBd8ejobPDPAl3aySEUn6w2mlSveVNAJD446x7zEphetn6jRVe5H9+DNqbF5Gc+giL06x bZt9tZHH/LS6/R9jdgDQPguryyY6rXsYJg6/S8AiUiYmTeER+WFMkjmqhG9rmBH4YzAAfkm XmKoQtJ0AeKwATdWh6LCQ== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:iVak1lAVv+I=;vq2883ddkOHwJFbA7k2SYBzZJdZ 3tl63texjaK3W7D+3uPkCvMpW49+I4pFwlmGuN3W47HMqw1SOVEbnH7B7Lmir8sKR3KWJspA3 9JJ7YPrhIfDtM8EnytiVFyCWF6sBXtx6eFULREEwv4f0q/Xkw40YADnn1QX2fgoZk7mwWFN6x HB82S9dKLL1iSacQFJnEkF+n3WXcELqp1hmC61CoZLt/CCBH9NjsC4uhS2Aj/mj9L7RwEB1Fb QHywsUKTQRWB38o3li9ToBOftFyJXqt5Ddmt1rbmXjskq8QrxOoR0as+kM4nGG8Vb4pgMnMl4 VCSzdFxGztnPtPt35ztCBqNi30kFXB+jXrEmeaob5c6qdCLsi3c0QjKWH2FqwsZVq7L+TBb89 njcDvM/S6Wa3pXCoSR1WCVmb4mwcUuUPK+SvngjgHCrQbraCtNVuW3ENT3WvwKnJfdwn3AUrD If79Fuh7QFpmPivaXq7v5jqWcgIzdhFOuRrgcYLChHvpv7zmoA7v5IBUkR9Wr3VgVs2wx850e auCZI2oMu9Fj2FP3jpCi5A537uV5kFpLzMuxFuwSJGfuCMq+wQYtVhPw3w/JC2nYqV9GgUdxH r7INRaciSEhfFGEYNpMHudPSTaCPATr3y7LlU8mIQiEskZ+VH8nObeaDah9hSdUUoU2UkrLub oLlRoLzaEajuEcaETIMBA4EjOC0ioxSoz5Z3ricxt3h+55IoeScE7iXRRRhYKwrxVsYPyXneD 8ltULLcmcrsnkf3KfxH7R2XM4coUfRMPU+DdaAG7rDIFVlpAvXNO9noAvYL/sqxuR4PFbXp68 rGWQ2SnXmnSunwzNVuq2kP6ameQF7yvqP7MZhfFL6731U5AG5Jq1fSwcY/c4E+p6r0+iJSNnF Lqjw5E8TI/OI8L+v1FtgHzwqrNA3rC+FI6BUDp2YDAo2/76ed+Jk45xH6/1JigRhjXw3zwC6o YZ0DERDdnHNHBXLjmBjcVgq1YXs= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59328 Cc: larsi@HIDDEN, jonas@HIDDEN, 59328 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Eli Zaretskii <eliz@HIDDEN> writes: > I don't understand: why cannot we add a test to Emacs, even though > other tests are elsewhere? Every kind of sequence (in the sense of seq.el) that exists in Emacs is not affected by the bug. A test makes only sense for types that are, but those are defined in libraries that are not in Gnu Emacs, only in Gnu Elpa. But I can't make the test depend on them. Michael.
bug-gnu-emacs@HIDDEN:bug#59328; Package emacs.
Full text available.Received: (at 59328) by debbugs.gnu.org; 24 Nov 2022 14:19:15 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 24 09:19:15 2022 Received: from localhost ([127.0.0.1]:57791 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oyD4N-000685-JN for submit <at> debbugs.gnu.org; Thu, 24 Nov 2022 09:19:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:47028) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1oyD4L-00067t-3r for 59328 <at> debbugs.gnu.org; Thu, 24 Nov 2022 09:19:13 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oyD4E-0008QR-Vh; Thu, 24 Nov 2022 09:19:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=RnALz+lsYI3gKPPRIAy52rlPVRsrs90ugEQe1dDyjYc=; b=jyjAHO3LTHQM tGccM9Ikuduvi7r91iZZSl6f2ogWGyDixT1F5mv6kLrUJu8pz3oWZI+OIYeCCZyoh9bdbHzeCc287 P4J2ZLaxmSXyVhVucC311oZAl8UafBYkMPDwpMLR+HtWJB9W3iA8mBwEhN7An2QXhLGF2wUykMvqX ZbCjqwBh+bIboXMzTeBjYDJShlULbNkQWGGUBbebfAqZZ60Xs0gXCVr+VNHHsCZpbtJY3x3tS5d2T XB1bhA0Rb89ccIRnUv/wm4WBF2BplFXpM0YF5rpjLD+MY7wqe0f4+kimUZRlBDV8mJMO9aKbDzNML THw5BhJGaPk6h0HsQpNlZw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1oyD4E-0001lc-6r; Thu, 24 Nov 2022 09:19:06 -0500 Date: Thu, 24 Nov 2022 16:19:26 +0200 Message-Id: <83edtswi35.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Michael Heerdegen <michael_heerdegen@HIDDEN> In-Reply-To: <87pmdctsf8.fsf@HIDDEN> (message from Michael Heerdegen on Thu, 24 Nov 2022 14:04:27 +0100) Subject: Re: bug#59328: 29.0.50; `seq-keep' implementation only valid for lists References: <87wn7ujpdh.fsf@HIDDEN> <83edtz84wl.fsf@HIDDEN> <87pmdctsf8.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59328 Cc: larsi@HIDDEN, jonas@HIDDEN, 59328 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Michael Heerdegen <michael_heerdegen@HIDDEN> > Cc: 59328 <at> debbugs.gnu.org, larsi@HIDDEN, jonas@HIDDEN > Date: Thu, 24 Nov 2022 14:04:27 +0100 > > Eli Zaretskii <eliz@HIDDEN> writes: > > > > #+begin_src emacs-lisp > > > (defun seq-keep (function sequence) > > > (seq-filter #'identity (seq-map function sequence))) > > > #+end_src > > > > This makes sense to me, so please go ahead and install, preferably > > with a test for non-list cases. > > I don't think adding a test case to Emacs is possible - all currently > existing counterexamples I found (stream.el, myers.el) are in Elpa or > somewhere else, but not in the Emacs repo. I don't understand: why cannot we add a test to Emacs, even though other tests are elsewhere? > So I guess it's ok to go without a test? It's okay, but I'd prefer to have a test.
bug-gnu-emacs@HIDDEN:bug#59328; Package emacs.
Full text available.Received: (at 59328) by debbugs.gnu.org; 24 Nov 2022 13:04:40 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 24 08:04:40 2022 Received: from localhost ([127.0.0.1]:57681 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oyBuB-0004H4-Pz for submit <at> debbugs.gnu.org; Thu, 24 Nov 2022 08:04:40 -0500 Received: from mout.web.de ([212.227.15.4]:59125) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <michael_heerdegen@HIDDEN>) id 1oyBu9-0004Gq-LP for 59328 <at> debbugs.gnu.org; Thu, 24 Nov 2022 08:04:39 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1669295069; bh=1BAl0bJrlpup9bHVeEKgibOGgheuJgvhGAT7OSgyR8k=; h=X-UI-Sender-Class:From:To:Cc:Subject:In-Reply-To:References:Date; b=SaqV9McaQsnoNh2rY5DZYfnTxBaGIDEQgXlxrhC9TsHYOykkYcc09A+2nWp8Rgcfl HIV9TrNVXDMa6w9y301A+oONyuwAhkJ8ICkLui7ELm76oWop3fTEdkeE6m1lRpSY02 ZYj+NbrBMod6v2HPn+XBVMCHO7ZkVo0TU32b9yLNy6yfNA8xI/oXK8eCbxNjE+QQPn qb9rFiJlqcapNDK2xybPDze6nKQcUHEv8v/7dMFRco8P9DgPOUo/lNdgaznUiWl/nf MI6yeUcCkti8tSoDBKUeUkQ+dxyBmS+yTbTVNYXd9rOky92uo0wOxgAxNEH/dZMrgm c7q8GQ2BPUZwQ== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([92.76.229.140]) by smtp.web.de (mrweb006 [213.165.67.108]) with ESMTPSA (Nemesis) id 1M7Nmq-1oqVKC3QFg-007hRY; Thu, 24 Nov 2022 14:04:28 +0100 From: Michael Heerdegen <michael_heerdegen@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#59328: 29.0.50; `seq-keep' implementation only valid for lists In-Reply-To: <83edtz84wl.fsf@HIDDEN> (Eli Zaretskii's message of "Sat, 19 Nov 2022 15:12:10 +0200") References: <87wn7ujpdh.fsf@HIDDEN> <83edtz84wl.fsf@HIDDEN> Date: Thu, 24 Nov 2022 14:04:27 +0100 Message-ID: <87pmdctsf8.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:XloQOO+UjI4OnuwtdczMTk1PK7HxKBqLXXewJaXNlEaJS0KbydX rnMrPYUxqfA/EsscBdSq2ol7eqIR30cWQHGtVA1KdVgI6vI11Nz7qAieItjHOx6srW894Fm /PYOJFMi918pGkLav9QmczstFjc2wRYB3e16gyMCG6nvrdseMYdJbPItMroJIxGkFKkfw2D q6+X8w+knjGsn6MqxGA2Q== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:3chVWuBCR7s=;VL6n9g/chDwi899NCMyA3aE2+q+ j2zUZYKfgG5l00/qIoRaiqWbCdKdXyn6xHS7U5XL3aZcqKhmDiXPUTPpHmJqLS7wgKCL9FDtv /r9SKC9rdLwLut72cgvH0w8kC36gM3aDY4pA/IRypgFdelZJplpjNvLCViPMYqjMml/iM1Mlp AkPvtBieDapiqUrs5WimqOb0hddr7H87JYLpuV+YWnHaonVt1/HZdtgJmwgA9gW25RLVwW07E UkXGvCde4w6elgAXqIoZq489+/u4HkcpXS9qlqVyG6uu3GLwXtmSDQh+Q+OkKoICQWbhzFiwF vUYSn6tg4uZMyeJdq/8Y3AaVi5aB2965td5rP/2JG6JhrHZBZQSO+rPAzwx2dVnbuVZavNrua lFAn7j8UOPsw0rHhTdP+ShPduLRDcO/+h5s+dmyrppE3OaFmgriosXPZHRpfRc4biSJV5EM6l OrUS2WsMPW/sJ2ZU88ESUzh/cQeUq3GvRwv3oaMyLDbLCRmtzT9sah6AJ3qkOeZ6pUMfVrqBu cDUzs/txB7QwcIYTgOodcmSEXXFXiS6bplChvteBN+kHVdI7scti9jwJ3VTGzpq8LvamoUCMP Zb/OZYLU7qAhCrKWUp5DyoLeLnLdoAow4Kbqf35fs1G91P5xObo7YKNNCGzVerAJhDyeNpFVh 7OiYUqDWwdvT5uw39IgzawNf9E30IMbxxmmlhU+nxVZr6YCqFqKW0OvCuuQ5VTskp2bSow1kU M7cTFnjNEaq+qdfAljNdT9AeKBgHZkgPYIjpPv7E3SiwA9GhkeCu95S25yAFcxWR6xBYzGzAV /ZvmOqm5xmuFX22NRaq4uRaXKmqDZioNJ7RL9G8pYor/L0ipQEdgd9LaxGZEJvJXOU4zwUMIb EKYwQKEtKAlh4JoxiyV5zMu5E9u50vdiFPN7k1ELwrMhQtgmcWljBMccJo1skvbbEKsq6nLoM ij5wOzLqsFvI0XngrrHkkXYQvvs= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 59328 Cc: larsi@HIDDEN, jonas@HIDDEN, 59328 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Eli Zaretskii <eliz@HIDDEN> writes: > > #+begin_src emacs-lisp > > (defun seq-keep (function sequence) > > (seq-filter #'identity (seq-map function sequence))) > > #+end_src > > This makes sense to me, so please go ahead and install, preferably > with a test for non-list cases. I don't think adding a test case to Emacs is possible - all currently existing counterexamples I found (stream.el, myers.el) are in Elpa or somewhere else, but not in the Emacs repo. So I guess it's ok to go without a test? Michael.
bug-gnu-emacs@HIDDEN:bug#59328; Package emacs.
Full text available.Received: (at 59328) by debbugs.gnu.org; 19 Nov 2022 13:12:17 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 19 08:12:17 2022 Received: from localhost ([127.0.0.1]:39229 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1owNdp-00058Y-8M for submit <at> debbugs.gnu.org; Sat, 19 Nov 2022 08:12:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:37956) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1owNdi-00058H-VT for 59328 <at> debbugs.gnu.org; Sat, 19 Nov 2022 08:12:15 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1owNdd-00038L-JR; Sat, 19 Nov 2022 08:12:05 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=/kr3Wvve7OLT9vZMHjIQWDpCpA1bulw8nB74VB1CLA8=; b=F3vj7L5+jCPk M3ME8C7AxWzMi4LGC+AXk6QKsbyxdnUcxZ9zRtDWN0JH09/YYWlkqpRwBJnd+3wdL/P9t36cT/5fo T5qSP8uKJzHKTwk84oPCAH8R9pfV3XjZSjlOIuskFv7m0fvyJuDG9Esx/gsryB9IIebFXodvZlvx5 kNOJqhFWglKCwG4ZsqkgCi2Kcf97ysjb0Mcd8WCjQQl08ypYCP420VAbtaKXHpwoj7OL40bG/nudd A8eqc8KZG7ywb/qrXJX3dB9UUT++g56Z8GwVWYSYGau+lJ9hrh4ifh19diPobSou8tZn0bf30gAX9 PVUMZOOGEY2FEHQLDqWxLQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1owNdc-0004Ar-Sf; Sat, 19 Nov 2022 08:12:05 -0500 Date: Sat, 19 Nov 2022 15:12:10 +0200 Message-Id: <83edtz84wl.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Michael Heerdegen <michael_heerdegen@HIDDEN> In-Reply-To: <87wn7ujpdh.fsf@HIDDEN> (message from Michael Heerdegen on Thu, 17 Nov 2022 03:17:46 +0100) Subject: Re: bug#59328: 29.0.50; `seq-keep' implementation only valid for lists References: <87wn7ujpdh.fsf@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59328 Cc: larsi@HIDDEN, jonas@HIDDEN, 59328 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: Lars Ingebrigtsen <larsi@HIDDEN>, Jonas Bernoulli <jonas@HIDDEN> > From: Michael Heerdegen <michael_heerdegen@HIDDEN> > Date: Thu, 17 Nov 2022 03:17:46 +0100 > > The current implementation of the (non-generic!) function `seq-keep': > > #+begin_src emacs-lisp > (defun seq-keep (function sequence) > (delq nil (seq-map function sequence))) > ;; ^^^^ > #+end_src > > obviously only works when `seq-map' returns a list. This is the case > for the default implementation of the generic function `seq-map' but not > necessarily for other implementations of `seq-map'. > > We need to filter out the `nil' elements with a way appropriate for any > sequence type supported by "seq.el" (i.e. with a generic function > defined in this lib), e.g. > > #+begin_src emacs-lisp > (defun seq-keep (function sequence) > (seq-filter #'identity (seq-map function sequence))) > #+end_src This makes sense to me, so please go ahead and install, preferably with a test for non-list cases. > BTW, is the name a good one? Why "keep"? It returns a sequence of > potentially all completely different elements. And is the function that > useful and a good abstraction at all (I don't have thought about it > too long...)? FWIW, "keep" doesn't sound problematic to me. Thanks.
bug-gnu-emacs@HIDDEN:bug#59328; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 17 Nov 2022 02:18:05 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 16 21:18:05 2022 Received: from localhost ([127.0.0.1]:58638 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1ovUTc-0005ij-NX for submit <at> debbugs.gnu.org; Wed, 16 Nov 2022 21:18:04 -0500 Received: from lists.gnu.org ([209.51.188.17]:44338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <michael_heerdegen@HIDDEN>) id 1ovUTb-0005ic-HK for submit <at> debbugs.gnu.org; Wed, 16 Nov 2022 21:18:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <michael_heerdegen@HIDDEN>) id 1ovUTb-00053C-D7 for bug-gnu-emacs@HIDDEN; Wed, 16 Nov 2022 21:18:03 -0500 Received: from mout.web.de ([217.72.192.78]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <michael_heerdegen@HIDDEN>) id 1ovUTZ-0005zY-BI for bug-gnu-emacs@HIDDEN; Wed, 16 Nov 2022 21:18:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=s29768273; t=1668651467; bh=5fRdlI37yC5j8+WqtaemOrzo5lNjbKxoAxZyuULkLd0=; h=X-UI-Sender-Class:From:To:Cc:Subject:Date; b=Rm2M1ZJcUDXypfR36CEQ9V4C5umKiyKeAiy/DLmfffFrQi1xIlrA/khafrQaNdYfM 615sYJs6OFNA9Q1sRkk9lOXzKnzAWC/tDMwiwCDVjoR08gnF/HdZ3CnH705eykR2ID 9QJI1O4wXrRfmoAYEM32ZqSIJRcYQ1eEO2dBEBtgR1ctdarRWMWt+QPrVxqRFNVxeN TMix2Iqad5GjFhRBtpYwnFfqqNlog5PkauGfvOVM+12KlB72DZ+LY4c5d7KOCLmGT0 vDylG5Ei77PSSxKHzzA1fc2uorSbEh5Li5WL3Rd3drtePIsaklV44YBeKey2seiZi/ EeGyZm/kvXneg== X-UI-Sender-Class: 814a7b36-bfc1-4dae-8640-3722d8ec6cd6 Received: from drachen.dragon ([88.66.71.129]) by smtp.web.de (mrweb106 [213.165.67.124]) with ESMTPSA (Nemesis) id 1MMGyK-1odPtF1ce6-00JTgO; Thu, 17 Nov 2022 03:17:47 +0100 From: Michael Heerdegen <michael_heerdegen@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: 29.0.50; `seq-keep' implementation only valid for lists Date: Thu, 17 Nov 2022 03:17:46 +0100 Message-ID: <87wn7ujpdh.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:kIGBWBBgGAF4KTqEgcIflPPQzuOYPxQ5sIKZ5g1GLX2wzqIKv7u GcGVrE9jk9O7j/tIdpXBdHlXeyGSW/KcEY1hgSFku2k+cQCTY6jk478/XauWRvq3jjM5JX+ M1F4+fzCHuNlRyNqQXfuILLlqsOblrBN/4KAflYtwTsw4Cr/Fdkd/SYVxnnk1DOdJ8lQOsN MvTu4KUeK/5F/+BniFB9g== X-Spam-Flag: NO UI-OutboundReport: notjunk:1;M01:P0:tgLRvF7w9rE=;NWV0CtSC6r+m2iXc3itKLhi4DLc oARmRQjSCoeEGvHs+bdafDwaAMu7/DN55mGpMcD9ZIBi78Jb34TcXQ0LJcVg7+D4AC0whE0mK lgNdPYHH8bS3kBjOZ+Dcp9d+oJWfhilCchZiDrM+vtwB6Er1hIkvNyNigfb2s1vcPrnaYuww/ XfBrkD8WeqczZCY5OvN4iSD9ixuoJhLBtCLaX40Vm4ARHOiTXu5X4SbVEhbgaNPOXPuiJwsn2 bk30oKePSvW+UKmHa0d3RFLMyov+IV5mCSjdOc7bpc4OPHLGx/QNg/i0uAO6TJk+b049fMQv+ Oo+eaYMvwU9s2odGiDMl++SJjB1Qzmqw10ejalkQHqpRgyu50XXF1a2mv2LpWz22q8eulTX1w yDw/NvLpqsz0zjyogMQCM+egm7G42TGhqMXSrCQPH50uGv2qemuj2qVoHu3xp8GFFd9/VJcax 9lZofYImRVzfFv0+ikpE4sedsdzHhwV8Nvj+tph/Et+1kuVdF+BpJ8krWJT7JQfro9X492SDy orkrs9yZiSvUTy80otbkE5XyWMXQtkF4IGdlMCAPdKxetmJITuBb7sQgKq6KZulxraCUpvxEX 7Vd1nVJoLTq0Pa1kHB6VmnDAtK7zgP9mQof6ja79M0AI9SsCbWMVWfc5AJjdC0Val3ecs687A 0R8SPMJBUqx8gNZl4k14xsWc/u3Gktul0Olek4h/zFqpEkbHONbFAHRyWSK8mkvBbhBBvIen4 C1/L003ytXWFadEW5tyEmbHZ6t7nDtjNIcb7dsshtWv4bWe5j90RG+GmEGZy3UMev3A0211aa e0k/thGmnD+AFV1d58z3naAaXq8ovd/x+rH/EAuELsEEb9y68O/4oKviBwNZtMOpvWcQleJY4 MGo1ckI/Hr51V9NK8jVsmtXswtokzUpCoswTytSiCkwg14W692VOvDBh8BLzjhyf8TB8cHRlS YcGxyQ== Received-SPF: pass client-ip=217.72.192.78; envelope-from=michael_heerdegen@HIDDEN; helo=mout.web.de X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.4 (-) X-Debbugs-Envelope-To: submit Cc: Lars Ingebrigtsen <larsi@HIDDEN>, Jonas Bernoulli <jonas@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.4 (--) Hello, [FWIW I tried to reopen 58278 but it seemed to...complicated for me] The current implementation of the (non-generic!) function `seq-keep': #+begin_src emacs-lisp (defun seq-keep (function sequence) (delq nil (seq-map function sequence))) ;; ^^^^ #+end_src obviously only works when `seq-map' returns a list. This is the case for the default implementation of the generic function `seq-map' but not necessarily for other implementations of `seq-map'. We need to filter out the `nil' elements with a way appropriate for any sequence type supported by "seq.el" (i.e. with a generic function defined in this lib), e.g. #+begin_src emacs-lisp (defun seq-keep (function sequence) (seq-filter #'identity (seq-map function sequence))) #+end_src BTW, is the name a good one? Why "keep"? It returns a sequence of potentially all completely different elements. And is the function that useful and a good abstraction at all (I don't have thought about it too long...)? TIA, Michael.
Michael Heerdegen <michael_heerdegen@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#59328; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.