GNU bug report logs - #59372
[PATCH] gnu: peek: Add missing input.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: jgart <jgart@HIDDEN>; Keywords: moreinfo patch; dated Sat, 19 Nov 2022 01:29:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.
Added tag(s) moreinfo. Request was from Christopher Baines <mail@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 19 Nov 2022 09:52:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 19 04:52:24 2022
Received: from localhost ([127.0.0.1]:39053 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1owKWN-000427-KQ
	for submit <at> debbugs.gnu.org; Sat, 19 Nov 2022 04:52:23 -0500
Received: from lists.gnu.org ([209.51.188.17]:33608)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@HIDDEN>) id 1owKWL-00041y-2S
 for submit <at> debbugs.gnu.org; Sat, 19 Nov 2022 04:52:22 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <me@HIDDEN>) id 1owKWH-00070A-Hp
 for guix-patches@HIDDEN; Sat, 19 Nov 2022 04:52:20 -0500
Received: from tobias.gr ([2a02:c205:2020:6054::1])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <me@HIDDEN>) id 1owKW8-0002X9-L5
 for guix-patches@HIDDEN; Sat, 19 Nov 2022 04:52:12 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=KgN9NrQhwgn/C
 YDof/va5IN0RPdctyEykQ7K4qqGNmo=;
 h=in-reply-to:date:subject:cc:to:
 from:references; d=tobias.gr; b=Q1YMrfx2GSf4pjkbNtUJnaB6Fu46HPNmM+bbOa
 brEomNkPkzudbjlaaYYZXSgIZGFQzTBdZlB6F1NPEMJruJhRIm+Cp2+HTegK/cwbyg2Ln1
 PqPbdZOHAZ7Th+5Llhzl4c8CBtNtVrEJddcytvsKCGUmL4a/gXGH2Dmk2rL+V6GG63TNFh
 x/6r2/mh71yIQedbtniWB7ap1f7pmqnjE94yt2zxY29LAP2M/fCspmCfrhrRr2XdCpU8UV
 CQVFp1KfbyGtnpT7DkN5WIfB42+nOxMRQBxyMBI4a+quRgfZRiZxGswJxkSuWTm4gKOp8Y
 q2WcORrb2lkvefGgBqUcQUgw==
Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 7369a6f1
 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); 
 Sat, 19 Nov 2022 09:51:45 +0000 (UTC)
References: <20221119012744.30470-1-jgart@HIDDEN> <87sfifabuy.fsf@nckx>
 <20221118220730.GB6211@HIDDEN>
From: Tobias Geerinckx-Rice <me@HIDDEN>
To: jgart <jgart@HIDDEN>
Subject: Re: [bug#59372] [PATCH] gnu: peek: Add missing input.
Date: Sat, 19 Nov 2022 10:38:26 +0100
In-reply-to: <20221118220730.GB6211@HIDDEN>
BIMI-Selector: v=BIMI1; s=default;
Message-ID: <87o7t39sql.fsf@nckx>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@HIDDEN;
 helo=tobias.gr
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.6 (-)
X-Debbugs-Envelope-To: submit
Cc: 59372 <at> debbugs.gnu.org, guix-patches@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

--=-=-=
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

jgart =E5=86=99=E9=81=93=EF=BC=9A
> It was complaining on Ubuntu when I started it that either=20
> ffmpeg needs
> to be installed or a gnome-shell needs to be running. I didn't=20
> log the
> exact error message but that was more or less it.

And how does this patch provide ffmpeg?  It adds it to the build=20
environment, but what happens then?

We know it doesn't add a reference to the final =E2=80=98peek=E2=80=99 outp=
ut (you=20
can verify this yourself, assuming peek builds reproducibly).  It=20
doesn't change any code in the peek binary.

So what's the mechanism by which it would work?  It will need to=20
be documented.

>> How are you invoking both peeks, and testing the difference?
>
> When I add ffmpeg it worked without the warning and actually=20
> started
> recording my screen as expected. After pressing the record=20
> button of
> course ;()

But how exactly?  Please provide exact steps and commands.

( =E5=86=99=E9=81=93=EF=BC=9A
> Could you also update the inputs/arguments style to gexp form?

=E2=80=A6but in a separate patch, please.)

Kind regards,

T G-R

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCY3inQg0cbWVAdG9iaWFz
LmdyAAoJEA2w/4hPVW15KJwA/iGHamjzaV80qY5dJyWxcPnpkH+gPmhUh3VQLjZY
PubCAQDvuMbWAP9PHqIIDU8Fk0Ji5aTiSmtHL+YpZCxLwXmzAA==
=vnc1
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#59372; Package guix-patches. Full text available.

Message received at 59372 <at> debbugs.gnu.org:


Received: (at 59372) by debbugs.gnu.org; 19 Nov 2022 09:51:59 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 19 04:51:59 2022
Received: from localhost ([127.0.0.1]:39049 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1owKVz-000417-97
	for submit <at> debbugs.gnu.org; Sat, 19 Nov 2022 04:51:59 -0500
Received: from tobias.gr ([80.241.217.52]:40172)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@HIDDEN>) id 1owKVw-00040x-Jk
 for 59372 <at> debbugs.gnu.org; Sat, 19 Nov 2022 04:51:58 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=KgN9NrQhwgn/C
 YDof/va5IN0RPdctyEykQ7K4qqGNmo=;
 h=in-reply-to:date:subject:cc:to:
 from:references; d=tobias.gr; b=Q1YMrfx2GSf4pjkbNtUJnaB6Fu46HPNmM+bbOa
 brEomNkPkzudbjlaaYYZXSgIZGFQzTBdZlB6F1NPEMJruJhRIm+Cp2+HTegK/cwbyg2Ln1
 PqPbdZOHAZ7Th+5Llhzl4c8CBtNtVrEJddcytvsKCGUmL4a/gXGH2Dmk2rL+V6GG63TNFh
 x/6r2/mh71yIQedbtniWB7ap1f7pmqnjE94yt2zxY29LAP2M/fCspmCfrhrRr2XdCpU8UV
 CQVFp1KfbyGtnpT7DkN5WIfB42+nOxMRQBxyMBI4a+quRgfZRiZxGswJxkSuWTm4gKOp8Y
 q2WcORrb2lkvefGgBqUcQUgw==
Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 7369a6f1
 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); 
 Sat, 19 Nov 2022 09:51:45 +0000 (UTC)
References: <20221119012744.30470-1-jgart@HIDDEN> <87sfifabuy.fsf@nckx>
 <20221118220730.GB6211@HIDDEN>
From: Tobias Geerinckx-Rice <me@HIDDEN>
To: jgart <jgart@HIDDEN>
Subject: Re: [bug#59372] [PATCH] gnu: peek: Add missing input.
Date: Sat, 19 Nov 2022 10:38:26 +0100
In-reply-to: <20221118220730.GB6211@HIDDEN>
BIMI-Selector: v=BIMI1; s=default;
Message-ID: <87o7t39sql.fsf@nckx>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 59372
Cc: 59372 <at> debbugs.gnu.org, guix-patches@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

jgart =E5=86=99=E9=81=93=EF=BC=9A
> It was complaining on Ubuntu when I started it that either=20
> ffmpeg needs
> to be installed or a gnome-shell needs to be running. I didn't=20
> log the
> exact error message but that was more or less it.

And how does this patch provide ffmpeg?  It adds it to the build=20
environment, but what happens then?

We know it doesn't add a reference to the final =E2=80=98peek=E2=80=99 outp=
ut (you=20
can verify this yourself, assuming peek builds reproducibly).  It=20
doesn't change any code in the peek binary.

So what's the mechanism by which it would work?  It will need to=20
be documented.

>> How are you invoking both peeks, and testing the difference?
>
> When I add ffmpeg it worked without the warning and actually=20
> started
> recording my screen as expected. After pressing the record=20
> button of
> course ;()

But how exactly?  Please provide exact steps and commands.

( =E5=86=99=E9=81=93=EF=BC=9A
> Could you also update the inputs/arguments style to gexp form?

=E2=80=A6but in a separate patch, please.)

Kind regards,

T G-R

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCY3inQg0cbWVAdG9iaWFz
LmdyAAoJEA2w/4hPVW15KJwA/iGHamjzaV80qY5dJyWxcPnpkH+gPmhUh3VQLjZY
PubCAQDvuMbWAP9PHqIIDU8Fk0Ji5aTiSmtHL+YpZCxLwXmzAA==
=vnc1
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#59372; Package guix-patches. Full text available.

Message received at 59372 <at> debbugs.gnu.org:


Received: (at 59372) by debbugs.gnu.org; 19 Nov 2022 09:13:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 19 04:13:13 2022
Received: from localhost ([127.0.0.1]:38989 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1owJuR-000312-1O
	for submit <at> debbugs.gnu.org; Sat, 19 Nov 2022 04:13:13 -0500
Received: from knopi.disroot.org ([178.21.23.139]:53654)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <paren@HIDDEN>) id 1owJuL-00030q-MM
 for 59372 <at> debbugs.gnu.org; Sat, 19 Nov 2022 04:13:09 -0500
Received: from localhost (localhost [127.0.0.1])
 by disroot.org (Postfix) with ESMTP id CF16340DC4;
 Sat, 19 Nov 2022 10:13:03 +0100 (CET)
X-Virus-Scanned: SPAM Filter at disroot.org
Received: from knopi.disroot.org ([127.0.0.1])
 by localhost (disroot.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id yoTDxbrNi9R5; Sat, 19 Nov 2022 10:13:02 +0100 (CET)
Mime-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=disroot.org; s=mail;
 t=1668849182; bh=Keea3wSUIjpiWgJQL+dw+2L8KQteYfCE7DokUxVwsTQ=;
 h=Date:Subject:From:To:References:In-Reply-To:From;
 b=dHsBpk0dvMD6ttMunvC525le11mXbnA0i0s1DIrxOmmBTWUJQoKwdomfgocAB6nBp
 t1DvhzUzuxADszMY5J0Itudn6nJa1WDsBcOuPAueYErQqMcPe1ZgS1fSt+pUJiVAsF
 uBXPEAbaHOwcVzz5Q3+1J2JF2V33m7hsA4p0QwCIoApLYdY+uoLsDRs0YkP2lcCAmU
 fICJYZznaeAFUQcAzG/iNmJW7fDPx2HbCUzgN2jcGt+rXJdBVEGwjUcLvjUPAkUXB5
 sBeCQoX+8qM6rjzCo4sWXXxUiMmOlU/mgMDUrtq1BfrWw9542J8Qq7e2/aJYBbkxt6
 xOcxAX4kvq9sQ==
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Sat, 19 Nov 2022 09:13:02 +0000
Message-Id: <COG5NUH2AL8O.ZEQDQS240I2H@guix-framework>
Subject: Re: [bug#59372] [PATCH] gnu: peek: Add missing input.
From: "(" <paren@HIDDEN>
To: "jgart" <jgart@HIDDEN>, <59372 <at> debbugs.gnu.org>
References: <20221119012744.30470-1-jgart@HIDDEN>
In-Reply-To: <20221119012744.30470-1-jgart@HIDDEN>
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 59372
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Heya,

On Sat Nov 19, 2022 at 1:27 AM GMT, jgart via Guix-patches via wrote:
> * gnu/packages/video.scm (peek): Add missing input.
> [inputs]: Add ffmpeg so that Peek will not fail to run on a foreign
> distro.

> diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
> index c394c65442..4f38d4432c 100644
> --- a/gnu/packages/video.scm
> +++ b/gnu/packages/video.scm
> @@ -5369,6 +5369,8 @@ (define-public peek
>      (arguments '(#:glib-or-gtk? #t))
>      (inputs
>       `(("gtk+" ,gtk+)
> +       ;; Peek fails to run on a foreign distro without ffmpeg.
> +       ("ffmpeg" ,ffmpeg)
>         ("python" ,python-wrapper)))
>      (native-inputs
>       `(("desktop-file-utils" ,desktop-file-utils) ; for update-desktop-d=
atabase

I don't think this will be enough; does the program call the ``ffmpeg''
executable? If so, you'll need to patch the call to ``ffmpeg'' to point to
/gnu/store/.../bin/ffmpeg directly.

Could you also update the inputs/arguments style to gexp form?

    -- (




Information forwarded to guix-patches@HIDDEN:
bug#59372; Package guix-patches. Full text available.

Message received at 59372 <at> debbugs.gnu.org:


Received: (at 59372) by debbugs.gnu.org; 19 Nov 2022 04:07:48 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 18 23:07:48 2022
Received: from localhost ([127.0.0.1]:38645 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1owF8u-0001Jm-CL
	for submit <at> debbugs.gnu.org; Fri, 18 Nov 2022 23:07:48 -0500
Received: from mx2.dismail.de ([159.69.191.136]:40882)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jgart@HIDDEN>) id 1owF8s-0001JR-15
 for 59372 <at> debbugs.gnu.org; Fri, 18 Nov 2022 23:07:47 -0500
Received: from mx2.dismail.de (localhost [127.0.0.1])
 by mx2.dismail.de (OpenSMTPD) with ESMTP id 2061d018;
 Sat, 19 Nov 2022 05:07:39 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=date
 :message-id:from:to:cc:subject:in-reply-to:references
 :mime-version:content-type:content-transfer-encoding; s=
 20190914; bh=oWTom6qOVvfkio0oU0h0jh8KFwrmFGhEio5afvooACI=; b=jP+
 4whVBtRDW4fe5CgJFLsxmyqG1eujKRKheGZVKjcvZU3KRpZnFq+1XxBfEoi9iQ0x
 GZExOtq36DLoSNvf+aZjPCBi+IIu2umkRKK4VinxN0g+WtKljaZ+2ADKgZFpQ7xy
 nfoyeWCwW3lq/dSOmO5WgB/oPUklH6isk2eb91xarGVGVc7YeQtz6xe9sHRpUm69
 vXWGvGjt/84HuGIw4ZjNUG82F0toqpk1VWU3rJwClB5cgTOeDQdvRWMZMB9FmDG0
 SilW59/0wylN3+wxvgbny5qSVvbvPbCPrxzzvZNHXwMCCM9Ch2mS6QLiJP1q2Zst
 py+YXrnkClJDsc8PoGA==
Received: from smtp2.dismail.de (<unknown> [10.240.26.12])
 by mx2.dismail.de (OpenSMTPD) with ESMTP id 1c2a9437;
 Sat, 19 Nov 2022 05:07:38 +0100 (CET)
Received: from smtp2.dismail.de (localhost [127.0.0.1])
 by smtp2.dismail.de (OpenSMTPD) with ESMTP id ffd212e6;
 Sat, 19 Nov 2022 05:07:38 +0100 (CET)
Received: by dismail.de (OpenSMTPD) with ESMTPSA id a7fb8d22
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Sat, 19 Nov 2022 05:07:37 +0100 (CET)
Date: Fri, 18 Nov 2022 22:07:30 -0600
Message-ID: <20221118220730.GB6211@HIDDEN>
From: jgart <jgart@HIDDEN>
To: Tobias Geerinckx-Rice <me@HIDDEN>
Subject: Re: [bug#59372] [PATCH] gnu: peek: Add missing input.
In-Reply-To: <87sfifabuy.fsf@nckx>
References: <20221119012744.30470-1-jgart@HIDDEN> <87sfifabuy.fsf@nckx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 59372
Cc: 59372 <at> debbugs.gnu.org, guix-patches@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

On Sat, 19 Nov 2022 03:50:05 +0100 Tobias Geerinckx-Rice <me@HIDDEN> wrote:
> As far as I can tell, this change doesn't affect the peek 
> package's output at all.  Am I mistaken?  What should the 
> observable difference be, beyond ‘working’?

It was complaining on Ubuntu when I started it that either ffmpeg needs
to be installed or a gnome-shell needs to be running. I didn't log the
exact error message but that was more or less it.

> How are you invoking both peeks, and testing the difference?

When I add ffmpeg it worked without the warning and actually started
recording my screen as expected. After pressing the record button of
course ;()

I tested once without ffmpeg and once with ffmpeg. 

The former failed to record.

> Are they both running in the exact same environment, back-to-back?

Yup I tested both in Ubuntu.

Let me know if you'd like any more info or if I wasn't precise enough
in my description.

all best,

jgart





Information forwarded to guix-patches@HIDDEN:
bug#59372; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 19 Nov 2022 04:07:52 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 18 23:07:52 2022
Received: from localhost ([127.0.0.1]:38647 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1owF8x-0001Jw-MZ
	for submit <at> debbugs.gnu.org; Fri, 18 Nov 2022 23:07:52 -0500
Received: from lists.gnu.org ([209.51.188.17]:53626)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jgart@HIDDEN>) id 1owF8q-0001JW-HF
 for submit <at> debbugs.gnu.org; Fri, 18 Nov 2022 23:07:48 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <jgart@HIDDEN>) id 1owF8q-00029O-B9
 for guix-patches@HIDDEN; Fri, 18 Nov 2022 23:07:44 -0500
Received: from mx2.dismail.de ([159.69.191.136])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <jgart@HIDDEN>) id 1owF8o-00031q-5h
 for guix-patches@HIDDEN; Fri, 18 Nov 2022 23:07:44 -0500
Received: from mx2.dismail.de (localhost [127.0.0.1])
 by mx2.dismail.de (OpenSMTPD) with ESMTP id 2061d018;
 Sat, 19 Nov 2022 05:07:39 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=date
 :message-id:from:to:cc:subject:in-reply-to:references
 :mime-version:content-type:content-transfer-encoding; s=
 20190914; bh=oWTom6qOVvfkio0oU0h0jh8KFwrmFGhEio5afvooACI=; b=jP+
 4whVBtRDW4fe5CgJFLsxmyqG1eujKRKheGZVKjcvZU3KRpZnFq+1XxBfEoi9iQ0x
 GZExOtq36DLoSNvf+aZjPCBi+IIu2umkRKK4VinxN0g+WtKljaZ+2ADKgZFpQ7xy
 nfoyeWCwW3lq/dSOmO5WgB/oPUklH6isk2eb91xarGVGVc7YeQtz6xe9sHRpUm69
 vXWGvGjt/84HuGIw4ZjNUG82F0toqpk1VWU3rJwClB5cgTOeDQdvRWMZMB9FmDG0
 SilW59/0wylN3+wxvgbny5qSVvbvPbCPrxzzvZNHXwMCCM9Ch2mS6QLiJP1q2Zst
 py+YXrnkClJDsc8PoGA==
Received: from smtp2.dismail.de (<unknown> [10.240.26.12])
 by mx2.dismail.de (OpenSMTPD) with ESMTP id 1c2a9437;
 Sat, 19 Nov 2022 05:07:38 +0100 (CET)
Received: from smtp2.dismail.de (localhost [127.0.0.1])
 by smtp2.dismail.de (OpenSMTPD) with ESMTP id ffd212e6;
 Sat, 19 Nov 2022 05:07:38 +0100 (CET)
Received: by dismail.de (OpenSMTPD) with ESMTPSA id a7fb8d22
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Sat, 19 Nov 2022 05:07:37 +0100 (CET)
Date: Fri, 18 Nov 2022 22:07:30 -0600
Message-ID: <20221118220730.GB6211@HIDDEN>
From: jgart <jgart@HIDDEN>
To: Tobias Geerinckx-Rice <me@HIDDEN>
Subject: Re: [bug#59372] [PATCH] gnu: peek: Add missing input.
In-Reply-To: <87sfifabuy.fsf@nckx>
References: <20221119012744.30470-1-jgart@HIDDEN> <87sfifabuy.fsf@nckx>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=159.69.191.136; envelope-from=jgart@HIDDEN;
 helo=mx2.dismail.de
X-Spam_score_int: -43
X-Spam_score: -4.4
X-Spam_bar: ----
X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
Cc: 59372 <at> debbugs.gnu.org, guix-patches@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

On Sat, 19 Nov 2022 03:50:05 +0100 Tobias Geerinckx-Rice <me@HIDDEN> wrote:
> As far as I can tell, this change doesn't affect the peek 
> package's output at all.  Am I mistaken?  What should the 
> observable difference be, beyond ‘working’?

It was complaining on Ubuntu when I started it that either ffmpeg needs
to be installed or a gnome-shell needs to be running. I didn't log the
exact error message but that was more or less it.

> How are you invoking both peeks, and testing the difference?

When I add ffmpeg it worked without the warning and actually started
recording my screen as expected. After pressing the record button of
course ;()

I tested once without ffmpeg and once with ffmpeg. 

The former failed to record.

> Are they both running in the exact same environment, back-to-back?

Yup I tested both in Ubuntu.

Let me know if you'd like any more info or if I wasn't precise enough
in my description.

all best,

jgart





Information forwarded to guix-patches@HIDDEN:
bug#59372; Package guix-patches. Full text available.

Message received at 59372 <at> debbugs.gnu.org:


Received: (at 59372) by debbugs.gnu.org; 19 Nov 2022 02:58:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 18 21:58:45 2022
Received: from localhost ([127.0.0.1]:38621 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1owE45-000849-1I
	for submit <at> debbugs.gnu.org; Fri, 18 Nov 2022 21:58:45 -0500
Received: from tobias.gr ([80.241.217.52]:52768)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@HIDDEN>) id 1owE42-00083x-93
 for 59372 <at> debbugs.gnu.org; Fri, 18 Nov 2022 21:58:43 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=Rtn3I/H4P6fh+
 JpTVn1uG2b1Pi7Bo9ScEW2dlqGG+aw=;
 h=in-reply-to:date:subject:cc:to:
 from:references; d=tobias.gr; b=iMQgsTNgSgzZ7f6V3KyTW/tESCb1DvxPtHvn2b
 /oi8WoXOrxves5iYzqDoE3z+PTr/fTV8qJd7tjx1qTpHHsLqQ4Ig6M7QBC8JZoD4rkoCKN
 nFkDFuKsOOEK9oe1vKMTxhENMwKzoeKViHgt5ZZRawwYJFEOmyvMoElJgGbW7v4UZH/WIe
 XUP+DQQux/75b5WTXxvqoBhGXtYTHpchJxcum5n5s6Dh2teJ9ihfjaiFPZY58wMiXEdjFR
 n7GGfgOV7MCnkKc9qKZ/+8VDA5pfIzG+eNY/yMFqoFOt0hiYWMv1ldwXEFjgoiGjoHw1WX
 7t035mWQQPQnhNvG5UMj77/g==
Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 61fab645
 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); 
 Sat, 19 Nov 2022 02:58:31 +0000 (UTC)
References: <20221119012744.30470-1-jgart@HIDDEN>
From: Tobias Geerinckx-Rice <me@HIDDEN>
To: jgart <jgart@HIDDEN>
Subject: Re: [bug#59372] [PATCH] gnu: peek: Add missing input.
Date: Sat, 19 Nov 2022 03:50:05 +0100
In-reply-to: <20221119012744.30470-1-jgart@HIDDEN>
BIMI-Selector: v=BIMI1; s=default;
Message-ID: <87sfifabuy.fsf@nckx>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 59372
Cc: 59372 <at> debbugs.gnu.org, guix-patches@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Hi jgart,

jgart via Guix-patches via =E5=86=99=E9=81=93=EF=BC=9A
> hi, peek fails to run on a foreign distro without ffmpeg as an=20
> input.
>
> this patch fixes that.

Thanks!

As far as I can tell, this change doesn't affect the peek=20
package's output at all.  Am I mistaken?  What should the=20
observable difference be, beyond =E2=80=98working=E2=80=99?

How are you invoking both peeks, and testing the difference?  Are=20
they both running in the exact same environment, back-to-back?

Kind regards,

T G-R

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCY3hGdg0cbWVAdG9iaWFz
LmdyAAoJEA2w/4hPVW15OaUA/3VWEbXSYSgU/LEJvon3SP2c1d9I/sohmxpp+MEQ
suvoAQCOQ1/5HGCeVE/MjfOJdIkfM6RbU/YkKR0OD5UrW7uNDg==
=yKTm
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#59372; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 19 Nov 2022 02:58:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 18 21:58:51 2022
Received: from localhost ([127.0.0.1]:38624 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1owE4B-00084S-Ba
	for submit <at> debbugs.gnu.org; Fri, 18 Nov 2022 21:58:51 -0500
Received: from lists.gnu.org ([209.51.188.17]:52638)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <me@HIDDEN>) id 1owE47-00084I-Fc
 for submit <at> debbugs.gnu.org; Fri, 18 Nov 2022 21:58:49 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <me@HIDDEN>) id 1owE47-0008TX-3i
 for guix-patches@HIDDEN; Fri, 18 Nov 2022 21:58:47 -0500
Received: from tobias.gr ([2a02:c205:2020:6054::1])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <me@HIDDEN>) id 1owE44-0003AW-VZ
 for guix-patches@HIDDEN; Fri, 18 Nov 2022 21:58:46 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=Rtn3I/H4P6fh+
 JpTVn1uG2b1Pi7Bo9ScEW2dlqGG+aw=;
 h=in-reply-to:date:subject:cc:to:
 from:references; d=tobias.gr; b=iMQgsTNgSgzZ7f6V3KyTW/tESCb1DvxPtHvn2b
 /oi8WoXOrxves5iYzqDoE3z+PTr/fTV8qJd7tjx1qTpHHsLqQ4Ig6M7QBC8JZoD4rkoCKN
 nFkDFuKsOOEK9oe1vKMTxhENMwKzoeKViHgt5ZZRawwYJFEOmyvMoElJgGbW7v4UZH/WIe
 XUP+DQQux/75b5WTXxvqoBhGXtYTHpchJxcum5n5s6Dh2teJ9ihfjaiFPZY58wMiXEdjFR
 n7GGfgOV7MCnkKc9qKZ/+8VDA5pfIzG+eNY/yMFqoFOt0hiYWMv1ldwXEFjgoiGjoHw1WX
 7t035mWQQPQnhNvG5UMj77/g==
Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id 61fab645
 (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); 
 Sat, 19 Nov 2022 02:58:31 +0000 (UTC)
References: <20221119012744.30470-1-jgart@HIDDEN>
From: Tobias Geerinckx-Rice <me@HIDDEN>
To: jgart <jgart@HIDDEN>
Subject: Re: [bug#59372] [PATCH] gnu: peek: Add missing input.
Date: Sat, 19 Nov 2022 03:50:05 +0100
In-reply-to: <20221119012744.30470-1-jgart@HIDDEN>
BIMI-Selector: v=BIMI1; s=default;
Message-ID: <87sfifabuy.fsf@nckx>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@HIDDEN;
 helo=tobias.gr
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.6 (-)
X-Debbugs-Envelope-To: submit
Cc: 59372 <at> debbugs.gnu.org, guix-patches@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

--=-=-=
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: quoted-printable

Hi jgart,

jgart via Guix-patches via =E5=86=99=E9=81=93=EF=BC=9A
> hi, peek fails to run on a foreign distro without ffmpeg as an=20
> input.
>
> this patch fixes that.

Thanks!

As far as I can tell, this change doesn't affect the peek=20
package's output at all.  Am I mistaken?  What should the=20
observable difference be, beyond =E2=80=98working=E2=80=99?

How are you invoking both peeks, and testing the difference?  Are=20
they both running in the exact same environment, back-to-back?

Kind regards,

T G-R

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCY3hGdg0cbWVAdG9iaWFz
LmdyAAoJEA2w/4hPVW15OaUA/3VWEbXSYSgU/LEJvon3SP2c1d9I/sohmxpp+MEQ
suvoAQCOQ1/5HGCeVE/MjfOJdIkfM6RbU/YkKR0OD5UrW7uNDg==
=yKTm
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#59372; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 19 Nov 2022 01:28:57 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 18 20:28:57 2022
Received: from localhost ([127.0.0.1]:38573 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1owCfA-0005rH-NH
	for submit <at> debbugs.gnu.org; Fri, 18 Nov 2022 20:28:56 -0500
Received: from lists.gnu.org ([209.51.188.17]:34970)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <jgart@HIDDEN>) id 1owCf7-0005r5-Dc
 for submit <at> debbugs.gnu.org; Fri, 18 Nov 2022 20:28:56 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <jgart@HIDDEN>) id 1owCf7-000205-7h
 for guix-patches@HIDDEN; Fri, 18 Nov 2022 20:28:53 -0500
Received: from mx1.dismail.de ([78.46.223.134])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <jgart@HIDDEN>) id 1owCf3-0002Ge-F9
 for guix-patches@HIDDEN; Fri, 18 Nov 2022 20:28:52 -0500
Received: from mx1.dismail.de (localhost [127.0.0.1])
 by mx1.dismail.de (OpenSMTPD) with ESMTP id dae82449
 for <guix-patches@HIDDEN>; Sat, 19 Nov 2022 02:28:45 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed; d=dismail.de; h=from:to:cc
 :subject:date:message-id:mime-version:content-transfer-encoding;
 s=20190914; bh=09JeObtkpTs50x1Rn3oJJghQjlmru1T3BnolCnPeZwM=; b=
 Qoi4068DmbD7CmIg/0sAnVoDjpaTCX/1GlhTQLd4VfNFYBzC+TLbJYWbSVln+yi3
 +qnLb1/WZtGpJwSDD3UsJ4qLifp3Wsh0OjrJ6ec8OCALyf6L+a8ZLQpxNXnlWiAd
 jg7oreBpno/lfEdGOyFBK744y6N5l55+cBczxddbPJncffcqpPHU5k1HRslBGgNk
 G83aoTQLXzMV5QlZMGP5gClo88EQ0Hp0jSbPOEqadt98hzDt3SsP6HSZ9erWPOMX
 zVn9UWrCRo+4RmE4uIU4eHQ68bUILMp3TqwqvHnKVYOeIsYfj7gFfPwt7uMv4Xy5
 3TarMf7yD0XVVy9o7YJwHA==
Received: from smtp2.dismail.de (<unknown> [10.240.26.12])
 by mx1.dismail.de (OpenSMTPD) with ESMTP id 969c12f6
 for <guix-patches@HIDDEN>; Sat, 19 Nov 2022 02:28:45 +0100 (CET)
Received: from smtp2.dismail.de (localhost [127.0.0.1])
 by smtp2.dismail.de (OpenSMTPD) with ESMTP id 75560c85
 for <guix-patches@HIDDEN>; Sat, 19 Nov 2022 02:28:45 +0100 (CET)
Received: by dismail.de (OpenSMTPD) with ESMTPSA id 105d50dc
 (TLSv1.3:TLS_AES_256_GCM_SHA384:256:NO); 
 Sat, 19 Nov 2022 02:28:44 +0100 (CET)
From: jgart <jgart@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] gnu: peek: Add missing input.
Date: Fri, 18 Nov 2022 19:27:46 -0600
Message-Id: <20221119012744.30470-1-jgart@HIDDEN>
X-Mailer: git-send-email 2.38.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=78.46.223.134; envelope-from=jgart@HIDDEN;
 helo=mx1.dismail.de
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
Cc: jgart <jgart@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

* gnu/packages/video.scm (peek): Add missing input.
[inputs]: Add ffmpeg so that Peek will not fail to run on a foreign
distro.

hi, peek fails to run on a foreign distro without ffmpeg as an input.

this patch fixes that.

all best,

jgart
---
 gnu/packages/video.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm
index c394c65442..4f38d4432c 100644
--- a/gnu/packages/video.scm
+++ b/gnu/packages/video.scm
@@ -5369,6 +5369,8 @@ (define-public peek
     (arguments '(#:glib-or-gtk? #t))
     (inputs
      `(("gtk+" ,gtk+)
+       ;; Peek fails to run on a foreign distro without ffmpeg.
+       ("ffmpeg" ,ffmpeg)
        ("python" ,python-wrapper)))
     (native-inputs
      `(("desktop-file-utils" ,desktop-file-utils) ; for update-desktop-database
-- 
2.38.1





Acknowledgement sent to jgart <jgart@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#59372; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 21 Nov 2022 13:15:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.