GNU bug report logs - #59414
29.0.50; Have vc-git-expanded-log-entry pass --stat

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Reported by: Sean Whitton <spwhitton@HIDDEN>; Done: Sean Whitton <spwhitton@HIDDEN>; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 59414 <at> debbugs.gnu.org:


Received: (at 59414) by debbugs.gnu.org; 5 Dec 2022 12:29:28 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Dec 05 07:29:28 2022
Received: from localhost ([127.0.0.1]:35727 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1p2Ab9-0006RL-Ow
	for submit <at> debbugs.gnu.org; Mon, 05 Dec 2022 07:29:28 -0500
Received: from eggs.gnu.org ([209.51.188.92]:42078)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1p2Ab7-0006RF-O4
 for 59414 <at> debbugs.gnu.org; Mon, 05 Dec 2022 07:29:26 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1p2Ab1-0001rU-DU; Mon, 05 Dec 2022 07:29:19 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From:
 Date; bh=LKDhInGpaF1j6n24xYYiqIOjoxFtDPBz19C7BWUQkkI=; b=BMtfuWKxaIRuY+qAIaU5
 rbnRl9mQtuPyOf9HlI58pygcfIAm/LQvY9Bgff2Er/HjC7omBrd62ySYY00grwMghcr2mZzM3pGWN
 1I9J8dldhnZBK002lVoXFDtXFoGqN8lDREK4C2hsmphxaQTxernaddYKlYsZVPobKnMlR1GJXRcyb
 Ymsqeopltu+iTJQLFbxkwivW3B/Z5M1Ysq5jswlILaxTv4Ru9XnhrkFR6vHhyYOBpd+Y46q2fudaP
 5j4C4HT3lc2SRYntvIzXbVxbZFPEwer2B2wtXYUmOFw/kOOY8XjTigOQtbQpl52jyTD/iJEI9i6ji
 5gkOWRQzSBmuNg==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1p2Ab0-0002wj-No; Mon, 05 Dec 2022 07:29:19 -0500
Date: Mon, 05 Dec 2022 14:29:01 +0200
Message-Id: <835yeq9gqa.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Sean Whitton <spwhitton@HIDDEN>
In-Reply-To: <877cz6zsi7.fsf@HIDDEN> (message from Sean
 Whitton on Sun, 04 Dec 2022 15:57:52 -0700)
Subject: Re: bug#59414: 29.0.50; Have vc-git-expanded-log-entry pass --stat
References: <874jutjzqj.fsf@HIDDEN>
 <86ilj9wm14.fsf@HIDDEN>
 <878rk5i8zx.fsf@HIDDEN>
 <87sfhxynm6.fsf@HIDDEN>
 <86h6ybgf40.fsf@HIDDEN> <877cz6zsi7.fsf@HIDDEN>
MIME-version: 1.0
Content-type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: 8bit
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 59414
Cc: 59414 <at> debbugs.gnu.org, dgutov@HIDDEN, juri@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Sean Whitton <spwhitton@HIDDEN>
> Date: Sun, 04 Dec 2022 15:57:52 -0700
> 
> @@ -1340,16 +1348,16 @@ vc-git-print-log
>  
>  (defun vc-git-log-outgoing (buffer remote-location)
>    (vc-setup-buffer buffer)
> -  (vc-git-command
> -   buffer 'async nil
> -   "log"
> -   "--no-color" "--graph" "--decorate" "--date=short"
> -   (format "--pretty=tformat:%s" (car vc-git-root-log-format))
> -   "--abbrev-commit"
> -   (concat (if (string= remote-location "")
> -	       "@{upstream}"
> -	     remote-location)
> -	   "..HEAD")))
> +  (apply #'vc-git-command buffer 'async nil
> +         `("log"
> +           "--no-color" "--graph" "--decorate" "--date=short"
> +           ,(format "--pretty=tformat:%s" (car vc-git-root-log-format))
> +           "--abbrev-commit"
> +           ,@(ensure-list vc-git-shortlog-switches)
> +           ,(concat (if (string= remote-location "")
> +	                "@{upstream}"
> +	              remote-location)
> +	            "..HEAD"))))

Why the change from vc-git-command to 'apply'?  The former took care for
setting up the I/O encoding for the Git command, while the latter just uses
the process defaults, which are not necessarily right for the underlying
system and locale.

In general, I'd prefer that invocations of all the Git commands went through
a single function, so that we could make sure the encoding/decoding stuff,
which is entirely non-trivial with Git, is done correctly in a single place
that is easy to audit and maintain.  I know that not all the commands are
invoked through there, but making more of them do so is going in the
direction that is 180 opposite to what we should strive to.

Thanks.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#59414; Package emacs. Full text available.

Message received at 59414-done <at> debbugs.gnu.org:


Received: (at 59414-done) by debbugs.gnu.org; 5 Dec 2022 05:15:56 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Dec 05 00:15:56 2022
Received: from localhost ([127.0.0.1]:33619 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1p23pc-0007ge-A6
	for submit <at> debbugs.gnu.org; Mon, 05 Dec 2022 00:15:56 -0500
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:50821)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <spwhitton@HIDDEN>) id 1p23pZ-0007gY-QY
 for 59414-done <at> debbugs.gnu.org; Mon, 05 Dec 2022 00:15:54 -0500
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id 1D8155C0084;
 Mon,  5 Dec 2022 00:09:04 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute4.internal (MEProxy); Mon, 05 Dec 2022 00:09:04 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name;
 h=cc:cc:content-type:date:date:from:from:in-reply-to
 :in-reply-to:message-id:mime-version:references:reply-to:sender
 :subject:subject:to:to; s=fm3; t=1670216944; x=1670303344; bh=+S
 0LS7WvfFyY8WT0ZeXHByLckR5YQvyKBdUtb5LTP3g=; b=scAuQh1Je82ZuWk87a
 LI7pHhhR359f3GdnRbMOL13PsXSzldsBLj1VeNQzEZ/sSi/21NvSHzvyKiMgncYa
 ZyykUcnGcfPvGAurYonl5wBGQaVULjWcikqe9UKIM2oFgEeCO8T0XuYw1sF27Ol0
 vnWPDN/lnbHnXoqQ/Kq+5iMd/rzRR4bCelA618hw8lnoF0A25fI8VgxXxO825xU0
 4Sqi53CvETyjwGi9U9p6qFFZmw6ZjO0NF6mOTOyt8HCJWlJ2ifaIQXC0CXLCVxCg
 Gqlfa0Eccuvihya+3tNxTdwS7zAcyHF4ys0gAKau3eVH1I6Ot7tsIVNG7otOeNse
 2Uzw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
 :feedback-id:from:from:in-reply-to:in-reply-to:message-id
 :mime-version:references:reply-to:sender:subject:subject:to:to
 :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
 fm1; t=1670216944; x=1670303344; bh=+S0LS7WvfFyY8WT0ZeXHByLckR5Y
 QvyKBdUtb5LTP3g=; b=wPyaKooVnHziyU4WQYKcl47sy4zWl0WVbN6zz7+CWqrr
 x0grQWXVO/nrUxbIjuo15f2+sMypZSWu+F+55wAdvmStdzeI+ST2e+TJwoLzhfVx
 gtxbDnxzU+kYuvG2tNBU2z4pbSeo++t5/x4jOZje1DxAxg7rs7cNH6szhEM26D/Y
 AS2Im7dZI98pubPXXOQ4QlJiUI4aJxd38cnI3wDZXiG7DOyLTaDClrcgdMsBGwmj
 RtmNSb8xXjMExUkvM46PVJ7lrHBXFhc6sKAZL7bmLxmcUPLSJESE3PImsDYInbKW
 4TeOfEzqJFwkq4+U/vZpIjnkzsdo2hz5saXguSLDrA==
X-ME-Sender: <xms:73yNY7v9-4ttociprdyIBxR7xpcKmBdaAGVtKN0hVsv9u-JLlhPk8A>
 <xme:73yNY8cmm1o0p8jIK90BGttis1guHbGbeCL-yf_Pdve8U_pDx6i8lPX4n-Dboyw0I
 3VnifWT11W8bYgEoQ>
X-ME-Received: <xmr:73yNY-ykukF94NiRgUmxWzVgQEGqXu8EciKcTqOn43dVtnPbwZHDdq7t--n7sq1BvLXwUaHcVIPJVlcQUU3UELNWoOEvjkl_ewO2EpiVUJxdFCZr6w>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudefgdektdcutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
 fjughrpefhvfevufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggrnhcu
 hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne
 cuggftrfgrthhtvghrnheptdffvdffueeluedvteekvdevhefghedvgeevgffhvedukeeg
 geelveegjeekteeknecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh
 hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv
X-ME-Proxy: <xmx:73yNY6OsF6Mpa6JklcQvARaCIgm2uGtc-N2NtKfzR32OXgATp60W3Q>
 <xmx:73yNY7-3tnJ-UWbvLMUxawf9pceAsvvZAMKW2ym-JLQOlq7dA7t2YQ>
 <xmx:73yNY6Vy3IfBUkvbzENsEFFW0GCywlKwPsM8EWq82jNfba5LeLN9GQ>
 <xmx:8HyNY1mJLAbyTM5xGczNUpyu6d5LmlhS-DSwdSnzFILEDurCILxrTw>
Feedback-ID: i23c04076:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 5 Dec 2022 00:09:03 -0500 (EST)
Received: by melete.silentflame.com (Postfix, from userid 1000)
 id 3BE467E76AF; Sun,  4 Dec 2022 22:09:01 -0700 (MST)
From: Sean Whitton <spwhitton@HIDDEN>
To: Dmitry Gutov <dgutov@HIDDEN>, 59414-done <at> debbugs.gnu.org
Subject: Re: bug#59414: 29.0.50; Have vc-git-expanded-log-entry pass --stat
In-Reply-To: <efc7f45c-9013-8355-d87f-feef6bbbe678@HIDDEN> (Dmitry Gutov's
 message of "Mon, 5 Dec 2022 02:54:04 +0200")
References: <874jutjzqj.fsf@HIDDEN>
 <86ilj9wm14.fsf@HIDDEN>
 <878rk5i8zx.fsf@HIDDEN>
 <87sfhxynm6.fsf@HIDDEN>
 <86h6ybgf40.fsf@HIDDEN>
 <877cz6zsi7.fsf@HIDDEN>
 <efc7f45c-9013-8355-d87f-feef6bbbe678@HIDDEN>
Date: Sun, 04 Dec 2022 22:09:01 -0700
Message-ID: <87h6yaxwr6.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 59414-done
Cc: Juri Linkov <juri@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hello,

Thanks for looking it over.  Installed.

-- 
Sean Whitton




Notification sent to Sean Whitton <spwhitton@HIDDEN>:
bug acknowledged by developer. Full text available.
Reply sent to Sean Whitton <spwhitton@HIDDEN>:
You have taken responsibility. Full text available.

Message received at 59414 <at> debbugs.gnu.org:


Received: (at 59414) by debbugs.gnu.org; 5 Dec 2022 00:54:14 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 04 19:54:14 2022
Received: from localhost ([127.0.0.1]:60768 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1p1zkM-0005Lr-G8
	for submit <at> debbugs.gnu.org; Sun, 04 Dec 2022 19:54:14 -0500
Received: from mail-wr1-f50.google.com ([209.85.221.50]:42622)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <raaahh@HIDDEN>) id 1p1zkK-0005Ll-FJ
 for 59414 <at> debbugs.gnu.org; Sun, 04 Dec 2022 19:54:12 -0500
Received: by mail-wr1-f50.google.com with SMTP id w15so16403857wrl.9
 for <59414 <at> debbugs.gnu.org>; Sun, 04 Dec 2022 16:54:12 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=content-transfer-encoding:in-reply-to:from:references:to
 :content-language:subject:user-agent:mime-version:date:message-id
 :sender:from:to:cc:subject:date:message-id:reply-to;
 bh=GmlKlWrJenk+qhxKi6oFEbqVhcuHcmgFXHpJcnp5xn4=;
 b=TAsGjBGT59hId8jyQhjO4L7lPM7p9+8Gq0ZYGGFKoHgO+PZt4YuiS9VCHMYC+y6XQS
 0UAuF/pwxcCRy2rDmNU7eGSX8y2g1rgyhEJszPGJ5SWii0uaTjBsUdMr6C9uGHmTIOqN
 Udo3yDZrZCHwYClr5iuhchfHnOH6pI0t2c0jNlw/4XR4KA6CYbY6a23RDoyj8dyoir06
 vdFYBwP4isqn82d3plPaWY68OCU6k3Pc3e/YlKMJ5EwOWai69cfyw7ocl0wMXGLbnA9z
 iNP52qGRXopOTmw/zE3f6X66FhNYTB/ZFjca5pTzPvvGRCyheG4LdtyvaeGjmUMtzFFk
 XH6w==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=content-transfer-encoding:in-reply-to:from:references:to
 :content-language:subject:user-agent:mime-version:date:message-id
 :sender:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=GmlKlWrJenk+qhxKi6oFEbqVhcuHcmgFXHpJcnp5xn4=;
 b=SqlfwGNRVJ+Bj+RhDuIf46/ud6zoK36OR6NkJHJwYF6L7jkkY5RrhueqIOh9pQfVUr
 K4uP9HvM3Z8s1n9zeAP8w2IaIalsl7f+6Zky+gCOi+ZczO5sr1yGRJ1vxyokmAVLtzSw
 c9sfCoCRY+iRFokCCBaGKXPMAO6GbXgY0cA8c1XwSZU00Ft3kilITg/Bc2HJqUTYPwK/
 vhyEp+ZCfv1DfvI3tgLKfQPJpG0xazrAOLkwn3Gv74Wtew6bkHJ4and6u7NUKEZrGOUr
 yonCG4QHcKbGkm+53vxF76zXXksvzAfb5LodIksSMXRPog0KBOnnJF1Pecm6Brq1HvPk
 RnzQ==
X-Gm-Message-State: ANoB5pmsdWvk8t13MR6LqE/D7kMKGbP1VlmEQO3O28R8nWbXvPcp5nEz
 /w2rHsN2cpoD3NDVl3/JUF0=
X-Google-Smtp-Source: AA0mqf54Ixkr/W6FYi5SeJnmsU3dV9bAFfBVCD9W+6CGeji8v3hQT0PQ8IIuUxCUzhPZzgaQ07Q7gA==
X-Received: by 2002:a05:6000:886:b0:241:b933:34a1 with SMTP id
 ca6-20020a056000088600b00241b93334a1mr39296223wrb.550.1670201646508; 
 Sun, 04 Dec 2022 16:54:06 -0800 (PST)
Received: from [192.168.0.6] ([46.251.119.176])
 by smtp.googlemail.com with ESMTPSA id
 bg28-20020a05600c3c9c00b003cfa3a12660sm24882061wmb.1.2022.12.04.16.54.05
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 04 Dec 2022 16:54:06 -0800 (PST)
Message-ID: <efc7f45c-9013-8355-d87f-feef6bbbe678@HIDDEN>
Date: Mon, 5 Dec 2022 02:54:04 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Subject: Re: bug#59414: 29.0.50; Have vc-git-expanded-log-entry pass --stat
Content-Language: en-US
To: Sean Whitton <spwhitton@HIDDEN>, Juri Linkov <juri@HIDDEN>,
 59414 <at> debbugs.gnu.org
References: <874jutjzqj.fsf@HIDDEN>
 <86ilj9wm14.fsf@HIDDEN> <878rk5i8zx.fsf@HIDDEN>
 <87sfhxynm6.fsf@HIDDEN> <86h6ybgf40.fsf@HIDDEN>
 <877cz6zsi7.fsf@HIDDEN>
From: Dmitry Gutov <dgutov@HIDDEN>
In-Reply-To: <877cz6zsi7.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: 59414
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)

On 05/12/2022 00:57, Sean Whitton wrote:
> Hello,
> 
> Thanks.  Here's a patch.

Thank you.

Looks good, please install.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#59414; Package emacs. Full text available.

Message received at 59414 <at> debbugs.gnu.org:


Received: (at 59414) by debbugs.gnu.org; 4 Dec 2022 22:58:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 04 17:58:02 2022
Received: from localhost ([127.0.0.1]:60286 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1p1xvt-0003nf-Ie
	for submit <at> debbugs.gnu.org; Sun, 04 Dec 2022 17:58:02 -0500
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:32953)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <spwhitton@HIDDEN>) id 1p1xvr-0003nR-6s
 for 59414 <at> debbugs.gnu.org; Sun, 04 Dec 2022 17:58:00 -0500
Received: from compute6.internal (compute6.nyi.internal [10.202.2.47])
 by mailout.nyi.internal (Postfix) with ESMTP id 012F75C0086;
 Sun,  4 Dec 2022 17:57:54 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute6.internal (MEProxy); Sun, 04 Dec 2022 17:57:53 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name;
 h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to
 :message-id:mime-version:references:reply-to:sender:subject
 :subject:to:to; s=fm3; t=1670194673; x=1670281073; bh=cWSbNTxCS1
 AFiBkMfv3o18bREPDVHafVwMFlhVEiWkw=; b=NPnyJc0sU8ABgvQ9IwHOKPLLu3
 ARkq1U6bmY/DJjCSHpC5LfNdt82SY3yFeo78PAx7tA2hnYkdJJOatzNcWzIZSGUZ
 Vo81OPDpr4ryZkRcrpnPBM5bpKha+nRPblt5KqXO4N27RvPeCYZoas+00N55Npjw
 qZd7FqWhhNSYxp1mwLMaRdG5goWr33eTqPhFVP1o5QWVkjqIou2jEwWC//B/PiNk
 KfKWp4iTfirOpLpfe/LpeDZohykcDV0PMQ2IHaYPqjJi8W1Ix5qBloJeYdM1AAMV
 GQ9wfLNKQSSPWClbmweQjuYLwDybGTl5FwqrRMWxiEWRp9RwYCC6tZW60Ymw==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-type:date:date:feedback-id
 :feedback-id:from:from:in-reply-to:in-reply-to:message-id
 :mime-version:references:reply-to:sender:subject:subject:to:to
 :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
 fm1; t=1670194673; x=1670281073; bh=cWSbNTxCS1AFiBkMfv3o18bREPDV
 HafVwMFlhVEiWkw=; b=mHvfL9xq9WMEgU8q09O8M5/1n9SJW8yOyDQHQHh3w/vC
 Qualuo3MxI9ZWwEqkOuGoEnLEZv9o7WqqnYDjwevqAXj7okCfs8qFrJ+HzWjyv/A
 f7FgjPtF9bFc31/GjkGpwj7kXGhuJEmS+qtiHsbEERcJMkNKG/SBmN2pBcj4tGcP
 UyWNs5V4YXFluIO/lLt0spBEyLQn3iikJVrmQZMBFz9z9R3Z8i2WBr1CJB8HxEs5
 mDdJlcs5cToXxMxh5D291GRkL1lcvxVLCP/K7qo2wRDbwEvG+A36VVIK89JpbBG0
 5Ie7tfQQl7J5lNBfKCii0QQem9VIhz8te6nNjZJ7cw==
X-ME-Sender: <xms:8SWNYxWUmhsMtHBLDjFPT-3_m2QeOWaSLK_vu_W0x92D4FRlJoQo3Q>
 <xme:8SWNYxkHLqMNbaPyYaJ4HPaZb2hksE4yBC4GGo13YM8x1rUMzoGYEtw6RFJaAglHd
 GD6uYkKso576Rs21Q>
X-ME-Received: <xmr:8SWNY9bTZQU_pBdWl3OERK2QAujwa_WaQfvhkiHl6dDjfTk0WFOeRPmFznCuQRPIvE1NvUkrmt8_mY-aN5i0GKv81IK59zy1uTMvfEO-2_uVLGOtlg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudefgddtgecutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc
 fjughrpefhvffujghffffkfgggtgesmhdttdertdertdenucfhrhhomhepufgvrghnucgh
 hhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqeenuc
 ggtffrrghtthgvrhhnpeekveelffehteelheetleduteejheefhefgteetfedttdejjeej
 vdevvefggefhheenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh
 hrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg
X-ME-Proxy: <xmx:8SWNY0Xi2Orh2rP91wPDn_Nj8E0go5SswdYVe6-Lg-FfYBN8SfELpA>
 <xmx:8SWNY7kZgoNwjy9NAo7Bhe-7x1HAjftBMui6gNFB-PnMsyW5ZkkA_A>
 <xmx:8SWNYxfG84ZKAoV1U29nSt-cG8Y915t83Zp-PY9bDORI3EdFeCwzjA>
 <xmx:8SWNYzsRzqSa9wVDuyXlS1FTyQQSl2RDYEffwHKUyHw_7WIXOo_APQ>
Feedback-ID: i23c04076:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
 4 Dec 2022 17:57:53 -0500 (EST)
Received: by melete.silentflame.com (Postfix, from userid 1000)
 id 9A6CF7E7143; Sun,  4 Dec 2022 15:57:52 -0700 (MST)
From: Sean Whitton <spwhitton@HIDDEN>
To: Juri Linkov <juri@HIDDEN>, Dmitry Gutov <dgutov@HIDDEN>,
 59414 <at> debbugs.gnu.org
Subject: Re: bug#59414: 29.0.50; Have vc-git-expanded-log-entry pass --stat
In-Reply-To: <86h6ybgf40.fsf@HIDDEN> (Juri Linkov's message of "Sun, 
 04 Dec 2022 21:19:51 +0200")
References: <874jutjzqj.fsf@HIDDEN>
 <86ilj9wm14.fsf@HIDDEN>
 <878rk5i8zx.fsf@HIDDEN>
 <87sfhxynm6.fsf@HIDDEN>
 <86h6ybgf40.fsf@HIDDEN>
Date: Sun, 04 Dec 2022 15:57:52 -0700
Message-ID: <877cz6zsi7.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 59414
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

--=-=-=
Content-Type: text/plain

Hello,

Thanks.  Here's a patch.

-- 
Sean Whitton

--=-=-=
Content-Type: text/x-patch
Content-Disposition: attachment;
 filename=0001-Improve-passing-user-switches-to-Git-log-commands.patch

From 868141665504d689f8f02bc8c67391b63d8962b2 Mon Sep 17 00:00:00 2001
From: Sean Whitton <spwhitton@HIDDEN>
Date: Sun, 4 Dec 2022 15:56:35 -0700
Subject: [PATCH] Improve passing user switches to Git log commands

* lisp/vc/vc-git.el (vc-git-log-switches): Revise docstring.
(vc-git-shortlog-switches): New defcustom.
(vc-git-print-log): Use vc-git-log-switches or
vc-git-shortlog-switches depending on whether printing a shortlog.
(vc-git-log-outgoing, vc-git-log-incoming): Use
vc-git-shortlog-switches.
(vc-git-log-search, vc-git-expanded-log-entry): Use
vc-git-log-switches.
* etc/NEWS: Document the new defcustom.
---
 etc/NEWS          |  7 ++++++
 lisp/vc/vc-git.el | 57 +++++++++++++++++++++++++++++------------------
 2 files changed, 42 insertions(+), 22 deletions(-)

diff --git a/etc/NEWS b/etc/NEWS
index 9b8edde5155..8f5b17fb4af 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -41,6 +41,13 @@ connection.
 
 * Changes in Specialized Modes and Packages in Emacs 30.1
 
+** VC
+
+---
+*** New user option 'vc-git-shortlog-switches'
+String or list of strings giving Git log switches for shortlogs, such
+as 'C-x v L'.  'vc-git-log-switches' is no longer used for shortlogs.
+
 
 * New Modes and Packages in Emacs 30.1
 
diff --git a/lisp/vc/vc-git.el b/lisp/vc/vc-git.el
index 38e9d5f9c91..59dfb6c1252 100644
--- a/lisp/vc/vc-git.el
+++ b/lisp/vc/vc-git.el
@@ -136,12 +136,19 @@ vc-git-annotate-switches
 ;;;###autoload(put 'vc-git-annotate-switches 'safe-local-variable (lambda (switches) (equal switches "-w")))
 
 (defcustom vc-git-log-switches nil
-  "String or list of strings specifying switches for Git log under VC."
+  "String or list of strings giving Git log switches for non-shortlogs."
   :type '(choice (const :tag "None" nil)
                  (string :tag "Argument String")
                  (repeat :tag "Argument List" :value ("") string))
   :version "28.1")
 
+(defcustom vc-git-shortlog-switches nil
+  "String or list of strings giving Git log switches for shortlogs."
+  :type '(choice (const :tag "None" nil)
+                 (string :tag "Argument String")
+                 (repeat :tag "Argument List" :value ("") string))
+  :version "30.1")
+
 (defcustom vc-git-resolve-conflicts t
   "When non-nil, mark conflicted file as resolved upon saving.
 That is performed after all conflict markers in it have been
@@ -1325,7 +1332,8 @@ vc-git-print-log
                     ,(format "--pretty=tformat:%s"
                              (car vc-git-root-log-format))
                     "--abbrev-commit"))
-                (ensure-list vc-git-log-switches)
+                (ensure-list
+                 (if shortlog vc-git-shortlog-switches vc-git-log-switches))
                 (when (numberp limit)
                   (list "-n" (format "%s" limit)))
 		(when start-revision
@@ -1340,16 +1348,16 @@ vc-git-print-log
 
 (defun vc-git-log-outgoing (buffer remote-location)
   (vc-setup-buffer buffer)
-  (vc-git-command
-   buffer 'async nil
-   "log"
-   "--no-color" "--graph" "--decorate" "--date=short"
-   (format "--pretty=tformat:%s" (car vc-git-root-log-format))
-   "--abbrev-commit"
-   (concat (if (string= remote-location "")
-	       "@{upstream}"
-	     remote-location)
-	   "..HEAD")))
+  (apply #'vc-git-command buffer 'async nil
+         `("log"
+           "--no-color" "--graph" "--decorate" "--date=short"
+           ,(format "--pretty=tformat:%s" (car vc-git-root-log-format))
+           "--abbrev-commit"
+           ,@(ensure-list vc-git-shortlog-switches)
+           ,(concat (if (string= remote-location "")
+	                "@{upstream}"
+	              remote-location)
+	            "..HEAD"))))
 
 (defun vc-git-log-incoming (buffer remote-location)
   (vc-setup-buffer buffer)
@@ -1359,15 +1367,15 @@ vc-git-log-incoming
                     ;; so remove everything except a repository name.
                     (replace-regexp-in-string
                      "/.*" "" remote-location)))
-  (vc-git-command
-   buffer 'async nil
-   "log"
-   "--no-color" "--graph" "--decorate" "--date=short"
-   (format "--pretty=tformat:%s" (car vc-git-root-log-format))
-   "--abbrev-commit"
-   (concat "HEAD.." (if (string= remote-location "")
-			"@{upstream}"
-		      remote-location))))
+  (apply #'vc-git-command buffer 'async nil
+         `("log"
+           "--no-color" "--graph" "--decorate" "--date=short"
+           ,(format "--pretty=tformat:%s" (car vc-git-root-log-format))
+           "--abbrev-commit"
+           ,@(ensure-list vc-git-shortlog-switches)
+           ,(concat "HEAD.." (if (string= remote-location "")
+			         "@{upstream}"
+		               remote-location)))))
 
 (defun vc-git-log-search (buffer pattern)
   "Search the log of changes for PATTERN and output results into BUFFER.
@@ -1378,6 +1386,7 @@ vc-git-log-search
 With a prefix argument, ask for a command to run that will output
 log entries."
   (let ((args `("log" "--no-color" "-i"
+                ,@(ensure-list vc-git-log-switches)
                 ,(format "--grep=%s" (or pattern "")))))
     (when current-prefix-arg
       (setq args (cdr (split-string
@@ -1462,7 +1471,11 @@ vc-git-show-log-entry
 
 (defun vc-git-expanded-log-entry (revision)
   (with-temp-buffer
-    (apply #'vc-git-command t nil nil (list "log" revision "-1"  "--no-color" "--"))
+    (apply #'vc-git-command t nil nil
+           `("log"
+             ,revision
+             "-1"  "--no-color" ,@(ensure-list vc-git-log-switches)
+             "--"))
     (goto-char (point-min))
     (unless (eobp)
       ;; Indent the expanded log entry.
-- 
2.30.2


--=-=-=--




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#59414; Package emacs. Full text available.

Message received at 59414 <at> debbugs.gnu.org:


Received: (at 59414) by debbugs.gnu.org; 4 Dec 2022 19:30:17 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 04 14:30:17 2022
Received: from localhost ([127.0.0.1]:59341 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1p1ugq-0007xJ-Ua
	for submit <at> debbugs.gnu.org; Sun, 04 Dec 2022 14:30:17 -0500
Received: from relay4-d.mail.gandi.net ([217.70.183.196]:52657)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1p1ugo-0007wx-Pl
 for 59414 <at> debbugs.gnu.org; Sun, 04 Dec 2022 14:30:15 -0500
Received: (Authenticated sender: juri@HIDDEN)
 by mail.gandi.net (Postfix) with ESMTPSA id 349F7E0002;
 Sun,  4 Dec 2022 19:30:06 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Sean Whitton <spwhitton@HIDDEN>
Subject: Re: bug#59414: 29.0.50; Have vc-git-expanded-log-entry pass --stat
In-Reply-To: <87sfhxynm6.fsf@HIDDEN> (Sean Whitton's message
 of "Sat, 03 Dec 2022 00:04:17 -0700")
Organization: LINKOV.NET
References: <874jutjzqj.fsf@HIDDEN>
 <86ilj9wm14.fsf@HIDDEN>
 <878rk5i8zx.fsf@HIDDEN>
 <87sfhxynm6.fsf@HIDDEN>
Date: Sun, 04 Dec 2022 21:19:51 +0200
Message-ID: <86h6ybgf40.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/30.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 59414
Cc: 59414 <at> debbugs.gnu.org, Dmitry Gutov <dgutov@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

> - vc-git-print-log -- should choose which defcustom to include based on
>                       its SHORTLOG parameter
> - vc-git-log-outgoing -- vc-git-shortlog-switches
> - vc-git-log-incoming -- vc-git-shortlog-switches
> - vc-git-log-search -- vc-git-log-switches
> - vc-git-expanded-log-entry -- vc-git-log-switches
>
> This is because some options are incompatible with shortlogs, such as
> --stat.  So, the proposed change is to add the new defcustom, change
> vc-git-print-log to use both defcustoms, and change all the other
> functions to use one of them.  How does    this sound?

Your classification correctly reflects the current situation
where two types of logs are in use by these commands.  So I think
two defcustoms as the minimal number of customization knobs
is a good idea.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#59414; Package emacs. Full text available.

Message received at 59414 <at> debbugs.gnu.org:


Received: (at 59414) by debbugs.gnu.org; 3 Dec 2022 07:04:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Dec 03 02:04:27 2022
Received: from localhost ([127.0.0.1]:51295 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1p1MZW-0005gR-S4
	for submit <at> debbugs.gnu.org; Sat, 03 Dec 2022 02:04:27 -0500
Received: from out4-smtp.messagingengine.com ([66.111.4.28]:40493)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <spwhitton@HIDDEN>) id 1p1MZU-0005gK-90
 for 59414 <at> debbugs.gnu.org; Sat, 03 Dec 2022 02:04:25 -0500
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.nyi.internal (Postfix) with ESMTP id BD05F5C0079;
 Sat,  3 Dec 2022 02:04:18 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute5.internal (MEProxy); Sat, 03 Dec 2022 02:04:18 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name;
 h=cc:content-type:date:date:from:from:in-reply-to:in-reply-to
 :message-id:mime-version:references:reply-to:sender:subject
 :subject:to:to; s=fm3; t=1670051058; x=1670137458; bh=JZAqQ/MHCh
 TE1S02DzkdSWiezknmNvl3BpC5I/ztGbI=; b=Ijtw+X7lyWugkc5hBhJlUlLw5u
 gk8BsI9sLaaltFmA/RrNOHa4ztU1Bh5RvW7ANzuKBBxTQ+u9RT8TESR3DfLz2i/K
 ezTm5lVU6cMuZplvJnIyEmrMtUfQ1iAoNlCf4yMWB7bFlNyNSHO5HGhDs0wlkyte
 MaC9LY1KQGFpDrynis5a0CibMSr57rU3mUdSNb17q4R+HbdEB3uCEEosbGfyLTlz
 JrnL3bjsGRyF5WNIMgvxR/Vk/n4mJ41j7HAM3EHi65N30rxx8RoRHAxX5M+AWSB5
 +CsGkGLawsQp9as+owzmTqlmssImMNOCJpJhjY4euOeFnu3HnRK2JJqBbcew==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-type:date:date:feedback-id
 :feedback-id:from:from:in-reply-to:in-reply-to:message-id
 :mime-version:references:reply-to:sender:subject:subject:to:to
 :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
 fm1; t=1670051058; x=1670137458; bh=JZAqQ/MHChTE1S02DzkdSWiezknm
 Nvl3BpC5I/ztGbI=; b=X2+watjQnfwytnb95tITsYNYp2LEzI7i4646hdo4ZnxX
 mEiBoQQY3uV6SkzLG8StLO6fjqC5pxoyrN7XpekR6CKJLACboVHeof+/lnRWSQ/1
 XGwCPWB3Ztmg0/S/lt4fiCV6NEdq6YURhSavfp4yLk4BdeQHWAjrMtj5qktuiSDO
 MhOJktWLeEc0tc2XtIU7A35U4UybZg0N2XPEuUbYExM9PZkpdojuEXdIs1nzjnO8
 pP8N+5zUpQ5dtkzkiC5OIzobrt0s2hrcuzpUggVHqEkMMvPyo1qs6cwSWSXn43AM
 mmTnmQUblalAYOB45KmVH7r6XSQWN/R8Sw/scrcLeQ==
X-ME-Sender: <xms:8vSKY6WfWspICHpE8gvxTwwuOxggsGEO03zkNhDF--U9WvxKOqMj8A>
 <xme:8vSKY2lTFh5D_JtPccC7zZl-np6rTrNou_vZ28L9lfDBQ_f2LLqgUVKq-ZTsJTYuY
 qp4PoqYvcebyfpc-A>
X-ME-Received: <xmr:8vSKY-Yxnsg10jA1QIY9Ad-cRJCe2fjCnhYbHpbWS7MbEwAOxbSTh2hadHcEvTckmRqr23ukktPB1znpUIEgEA0MyX6cbyTRfOejA2aeKaFxm0WloA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrtdelgddutdefucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvufgjfhffkfgfgggtsehttddttddtredtnecuhfhrohhmpefuvggrnhcu
 hghhihhtthhonhcuoehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvgeqne
 cuggftrfgrthhtvghrnhepffeutedtfedvtdetvefgueefjefggedugfefuddtgeefteek
 heduvdefjeejieefnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilh
 hfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgv
X-ME-Proxy: <xmx:8vSKYxVPG0WpQxJBsLCXMoUhJhIn1GM1Q9e8RRh8lsc5ZpxNeSygIQ>
 <xmx:8vSKY0lOTU9Y7Nsp8Ek46nYkYg3mniAZUdntcQLLDEMYk4dMy6GqWg>
 <xmx:8vSKY2eHcjJ7dJH7VrS4pBd01ypoFWFa0i56LHXet6sLZSHwuH1n2A>
 <xmx:8vSKYwtIA3OnPA9Aztn9LdbUoH13M2tQW5_R0-lhSvLHBN-px0_wmg>
Feedback-ID: i23c04076:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat,
 3 Dec 2022 02:04:18 -0500 (EST)
Received: by melete.silentflame.com (Postfix, from userid 1000)
 id 758117EB95B; Sat,  3 Dec 2022 00:04:17 -0700 (MST)
From: Sean Whitton <spwhitton@HIDDEN>
To: Juri Linkov <juri@HIDDEN>, Dmitry Gutov <dgutov@HIDDEN>,
 59414 <at> debbugs.gnu.org
Subject: Re: bug#59414: 29.0.50; Have vc-git-expanded-log-entry pass --stat
In-Reply-To: <878rk5i8zx.fsf@HIDDEN> (Sean Whitton's message
 of "Sun, 20 Nov 2022 14:58:10 -0700")
References: <874jutjzqj.fsf@HIDDEN>
 <86ilj9wm14.fsf@HIDDEN>
 <878rk5i8zx.fsf@HIDDEN>
Date: Sat, 03 Dec 2022 00:04:17 -0700
Message-ID: <87sfhxynm6.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 59414
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hello,

On Sun 20 Nov 2022 at 02:58PM -07, Sean Whitton wrote:

> We already have vc-git-log-switches.  git-log(1) gets called *without*
> it in (at least) the following places:
>
> - vc-git-log-outgoing
> - vc-git-log-incoming
> - vc-git-log-search
> - vc-git-expanded-log-entry
> - vc-git-region-history
>
> I guess that the first three should probably use vc-git-log-switches if
> anything?  And so we would want a separate option for
> vc-git-expanded-log-entry.  Not sure about vc-git-region-history.

I think that we actually need two defcustoms for the regular logs and
shortlogs:

- vc-git-print-log -- should choose which defcustom to include based on
                      its SHORTLOG parameter
- vc-git-log-outgoing -- vc-git-shortlog-switches
- vc-git-log-incoming -- vc-git-shortlog-switches
- vc-git-log-search -- vc-git-log-switches
- vc-git-expanded-log-entry -- vc-git-log-switches

This is because some options are incompatible with shortlogs, such as
--stat.  So, the proposed change is to add the new defcustom, change
vc-git-print-log to use both defcustoms, and change all the other
functions to use one of them.  How does    this sound?

-- 
Sean Whitton




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#59414; Package emacs. Full text available.

Message received at 59414 <at> debbugs.gnu.org:


Received: (at 59414) by debbugs.gnu.org; 21 Nov 2022 20:29:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 21 15:29:18 2022
Received: from localhost ([127.0.0.1]:48953 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oxDPq-0005qE-7d
	for submit <at> debbugs.gnu.org; Mon, 21 Nov 2022 15:29:18 -0500
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:43509)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <spwhitton@HIDDEN>) id 1oxDPm-0005pt-Br
 for 59414 <at> debbugs.gnu.org; Mon, 21 Nov 2022 15:29:17 -0500
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.nyi.internal (Postfix) with ESMTP id F052C5C0085;
 Mon, 21 Nov 2022 15:29:08 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute5.internal (MEProxy); Mon, 21 Nov 2022 15:29:08 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name;
 h=cc:cc:content-type:date:date:from:from:in-reply-to
 :in-reply-to:message-id:mime-version:references:reply-to:sender
 :subject:subject:to:to; s=fm3; t=1669062548; x=1669148948; bh=ge
 UDiLLyV8UEGOWOWOwIyJ0T1+OB46KzdlzQ+At5WYs=; b=JQr5bImAsuphL/xAtx
 LdF83Inz8O8bR8z7ODEvxrx2FB+Fw+sV/1rTt24g60DLCCDEMOmLJJx8b9Cp1tZq
 0m5kYFhNI3G5GAuFQdeK7CaInv6NhO7rx3lkv4tNB/EZszDCWcGKGv6SJ5hdVG/q
 3O4EjvoTXA5sL2vwrufk5wVlrOdBT01MlshvdAGtdPMnUYzqXUwlgvVbk9M6U0Lr
 HOEuHXKsVEh1buUAJkgH/xrn7VBdU7jmE0Ic3mqxxVhiv2cUEVQm6Q1xwLVUDfr7
 139ticPc2ZauhzvSHv7rLvo7pTHk1htlYeSI4yiUsPD/ur6r7epopydtZOBvFzqX
 TS5A==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
 :feedback-id:from:from:in-reply-to:in-reply-to:message-id
 :mime-version:references:reply-to:sender:subject:subject:to:to
 :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
 fm1; t=1669062548; x=1669148948; bh=geUDiLLyV8UEGOWOWOwIyJ0T1+OB
 46KzdlzQ+At5WYs=; b=m2N8gu4CH8lJi6bxnV84MhG6PEIUKg5/mVHJYqihlYNp
 kbmCHcJgNMc5XBMWfCFOv+XZcF8BtZoyHVpSO7zOlXH/nWns5/q1qdKRUtsGl6iT
 X+wn08UQweet3aeUKjs4XK2EpJa2J//dIeN77WWXRCXzmFoWXn2OJmQnyxugnaUQ
 wTstLyvH1T5pF9t3v/z4wThkC7okvsccJG1TlAlzLwJ4qlLU2mL/DqluxPmBS0y/
 YeLWJAo1s5Lubq9jXhUiawOlefY2rAZ4FK0+bgeah1vVYRJTVGr7iNaaI73f9/sv
 n62dOGBd0h6Y7HUr2KQmRSDzBo0a4KLb1SE/PWsuwg==
X-ME-Sender: <xms:lN97Y56RbmSLqskwdDPD7NH3A0D3q59VPVEmiyMQLVFAFSLxr8WAPw>
 <xme:lN97Y24QhqMixDj4NojqzVESP1mjAzA9wLd0Y-nnq_n8wZF-_kuxF2hVCSZ63KFv3
 EbFG3KEh5YVcO9HaQ>
X-ME-Received: <xmr:lN97YwcroJPfBMPeWsalAIfcmu7LpC7IRURN4plhNMWWuYKazOsOVZiXlwpAXEhJiujHeB11sys--6TTQsACUmgbhyCFiYW8omUVwAClpE-zRyCnrw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrheeigddufeekucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvvefujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn
 ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe
 enucggtffrrghtthgvrhhnpedtffdvffeuleeuvdetkedvveehgfehvdegvefghfevudek
 geegleevgeejkeetkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih
 hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg
X-ME-Proxy: <xmx:lN97YyIIMsPRnqhY6mJg4yrfM4loqgeW8w2WB6O5hq868e7XoVpiAA>
 <xmx:lN97Y9LGN0fosXKAu8kkmQxYaXAHBqID7jW5MkHygDCGfe-UsWiQfA>
 <xmx:lN97Y7zv3lWK23n2yG5yu0BRC6tjKajmkphPt3MGm73d9Wb6RGfFRQ>
 <xmx:lN97Y7g1waJFHCWN9uawGi61aeMKoEXX_Qcoo0pW5H_WO1COVcCWuQ>
Feedback-ID: i23c04076:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon,
 21 Nov 2022 15:29:08 -0500 (EST)
Received: by melete.silentflame.com (Postfix, from userid 1000)
 id B23827EA687; Mon, 21 Nov 2022 13:29:07 -0700 (MST)
From: Sean Whitton <spwhitton@HIDDEN>
To: Dmitry Gutov <dgutov@HIDDEN>
Subject: Re: bug#59414: 29.0.50; Have vc-git-expanded-log-entry pass --stat
In-Reply-To: <349e7ac9-03bd-671f-9419-b1fcbc584ed3@HIDDEN> (Dmitry Gutov's
 message of "Mon, 21 Nov 2022 00:11:57 +0200")
References: <874jutjzqj.fsf@HIDDEN>
 <86ilj9wm14.fsf@HIDDEN>
 <878rk5i8zx.fsf@HIDDEN>
 <349e7ac9-03bd-671f-9419-b1fcbc584ed3@HIDDEN>
Date: Mon, 21 Nov 2022 13:29:07 -0700
Message-ID: <878rk4uk4s.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 59414
Cc: 59414 <at> debbugs.gnu.org, Juri Linkov <juri@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hello,

On Mon 21 Nov 2022 at 12:11AM +02, Dmitry Gutov wrote:

> On 20.11.2022 23:58, Sean Whitton wrote:
>> And so we would want a separate option for
>> vc-git-expanded-log-entry.
>
> Do we anticipate people using different switches for it from the first three?
> Like, do you want to add --stat only there and not in those other cases?

Yes: if you add --stat to vc-git-log-switches it simply breaks Log View.

-- 
Sean Whitton




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#59414; Package emacs. Full text available.

Message received at 59414 <at> debbugs.gnu.org:


Received: (at 59414) by debbugs.gnu.org; 20 Nov 2022 22:12:07 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 20 17:12:07 2022
Received: from localhost ([127.0.0.1]:44826 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1owsXn-0003dK-Hn
	for submit <at> debbugs.gnu.org; Sun, 20 Nov 2022 17:12:07 -0500
Received: from mail-wr1-f44.google.com ([209.85.221.44]:44804)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <raaahh@HIDDEN>) id 1owsXm-0003co-0h
 for 59414 <at> debbugs.gnu.org; Sun, 20 Nov 2022 17:12:06 -0500
Received: by mail-wr1-f44.google.com with SMTP id v1so17293723wrt.11
 for <59414 <at> debbugs.gnu.org>; Sun, 20 Nov 2022 14:12:05 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=content-transfer-encoding:in-reply-to:from:references:cc:to
 :content-language:subject:user-agent:mime-version:date:message-id
 :sender:from:to:cc:subject:date:message-id:reply-to;
 bh=+7rd5PPHw+9E7BM/eh7hvhPyi9FKlIU2DlB2bgSVsAE=;
 b=igXEVB2k8ADYjmJWhZXneTxGEKAEz768qH4kXdtKwP9QpJAO5H8NCk6mNv/ker/ZTe
 Fkl4jBL0pOtevS+op0sMbON64q8AyzHJ0vOnEP/yfjnQDzWyVSRaLbedG3gbdC9z9b6s
 ojct0HjlnWVZv8C+pjGcnWzxDPMtdYTLQ1BnrRARAPvqSAyQ5m9WjNWvaazcrgy/C5dD
 XkiRAYqXB4Ot28y/NSfPpqwOpfelmB6oWSpVv/uygm2ZkxCyyP80/UWgftY0VmLWoCnc
 NnMbnSqJNcMJQTmy4qR1fGR0uGxITDNwGkOqurKYSQ7OhceCUJaQHbC+yT079AvJ0+d1
 3mMw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=content-transfer-encoding:in-reply-to:from:references:cc:to
 :content-language:subject:user-agent:mime-version:date:message-id
 :sender:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=+7rd5PPHw+9E7BM/eh7hvhPyi9FKlIU2DlB2bgSVsAE=;
 b=5iaM1uZ5fcbf5RF4pXW3siQ91y64taGLIZHPcYTSjLl5PCc94OcbCDHLrZUtQpEh/E
 gqIuPwmmxxv/0ClN7QBqV1GZAnia23Mt8RXyQyQfBFNMYNzVoo2p0nud47WYGyRxpgDt
 n0qiyI4zhhgu5/xEwOJPGMFEZwvF5m+ryObLK5g/hP3dY3fLsyZro7y7s3pFJ4YZjzcO
 Ufrft4a6g8/oYXzCmbJkl1zrbgWU1m/T+gKS/XiqOGP1k0dh/lHhBO8G2o0KOW1EXI1B
 BC/VtF7cO0xkqCp1F648jHLuS8vgXtvYCx7V/WFv9coF0n0dnSpBGVEhr3QTppR2EKkh
 lxjQ==
X-Gm-Message-State: ANoB5plTGGOo6Khmhsc3HUJGaFGUX9xStEb8MhGAhwi3MMZTaSoaV+V5
 SE93yNGbopD/3s6kpJFOLRg=
X-Google-Smtp-Source: AA0mqf6u189BCLXM6jXhJ7QljctWeWbyLZdbWmo0esNLoHWpqLans08KH0QWgg73L3kF+eabvCdTVw==
X-Received: by 2002:a05:6000:1147:b0:238:fb27:fb53 with SMTP id
 d7-20020a056000114700b00238fb27fb53mr8791609wrx.203.1668982319831; 
 Sun, 20 Nov 2022 14:11:59 -0800 (PST)
Received: from [192.168.0.6] ([46.251.119.176])
 by smtp.googlemail.com with ESMTPSA id
 o5-20020a05600c510500b003b4ff30e566sm24384947wms.3.2022.11.20.14.11.58
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 20 Nov 2022 14:11:59 -0800 (PST)
Message-ID: <349e7ac9-03bd-671f-9419-b1fcbc584ed3@HIDDEN>
Date: Mon, 21 Nov 2022 00:11:57 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: bug#59414: 29.0.50; Have vc-git-expanded-log-entry pass --stat
Content-Language: en-US
To: Sean Whitton <spwhitton@HIDDEN>, Juri Linkov <juri@HIDDEN>
References: <874jutjzqj.fsf@HIDDEN>
 <86ilj9wm14.fsf@HIDDEN> <878rk5i8zx.fsf@HIDDEN>
From: Dmitry Gutov <dgutov@HIDDEN>
In-Reply-To: <878rk5i8zx.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: 1.5 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 Content preview:  On 20.11.2022 23:58, Sean Whitton wrote: > And so we would
 want a separate option for > vc-git-expanded-log-entry. Do we anticipate
 people using different switches for it from the first three? Like, do you
 want to add --stat only there and not in those other cases? 
 Content analysis details:   (1.5 points, 10.0 required)
 pts rule name              description
 ---- ---------------------- --------------------------------------------------
 1.3 RCVD_IN_VALIDITY_RPBL  RBL: Relay in Validity RPBL,
 https://senderscore.org/blocklistlookup/
 [209.85.221.44 listed in bl.score.senderscore.com]
 0.0 SPF_HELO_NONE          SPF: HELO does not publish an SPF Record
 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level
 mail domains are different
 0.0 FREEMAIL_FROM          Sender email is commonly abused enduser mail
 provider (raaahh[at]gmail.com)
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.0 RCVD_IN_DNSWL_NONE     RBL: Sender listed at https://www.dnswl.org/,
 no trust [209.85.221.44 listed in list.dnswl.org]
 -0.0 RCVD_IN_MSPIKE_H2      RBL: Average reputation (+2)
 [209.85.221.44 listed in wl.mailspike.net]
 0.0 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and
 EnvelopeFrom freemail headers are different
 -0.0 NICE_REPLY_A           Looks like a legit reply (A)
X-Debbugs-Envelope-To: 59414
Cc: 59414 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.5 (/)

On 20.11.2022 23:58, Sean Whitton wrote:
> And so we would want a separate option for
> vc-git-expanded-log-entry.

Do we anticipate people using different switches for it from the first 
three? Like, do you want to add --stat only there and not in those other 
cases?

vc-git-region-history - no, probably not, since it comes with the diffs 
already.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#59414; Package emacs. Full text available.

Message received at 59414 <at> debbugs.gnu.org:


Received: (at 59414) by debbugs.gnu.org; 20 Nov 2022 21:58:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 20 16:58:23 2022
Received: from localhost ([127.0.0.1]:44816 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1owsKV-0003HA-EL
	for submit <at> debbugs.gnu.org; Sun, 20 Nov 2022 16:58:23 -0500
Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:36861)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <spwhitton@HIDDEN>) id 1owsKS-0003Gu-GC
 for 59414 <at> debbugs.gnu.org; Sun, 20 Nov 2022 16:58:21 -0500
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.west.internal (Postfix) with ESMTP id AC3EB32002D8;
 Sun, 20 Nov 2022 16:58:12 -0500 (EST)
Received: from mailfrontend2 ([10.202.2.163])
 by compute4.internal (MEProxy); Sun, 20 Nov 2022 16:58:12 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name;
 h=cc:cc:content-type:date:date:from:from:in-reply-to
 :in-reply-to:message-id:mime-version:references:reply-to:sender
 :subject:subject:to:to; s=fm3; t=1668981492; x=1669067892; bh=R0
 kJ18LtZstontPl7D7tUBtnlPAV9Wj5NzpbTsIVoUo=; b=MuNt0DzP9I2SLt6KMK
 U37gJvErtNO5RLj8r0iCKUCOv2tcz2uhhOn9f/g1uT2Cxp5V5F9UN1Hm/OzfUpVZ
 HdVO+Wr51pC+FxhXVg+W3dh+ngeKuM+Ic0L2eKQljkWLupdNDXmud169BfJE71nb
 z/VlAOvE3Xf7EFl+4cSJG08/NjENz7AiPoE0TWIFjzssfMI/qqDEhsX6SjpV5P61
 y4WLA+RX1zEnF7DCDPvKeIGTcBCLNBkAEuEzVZsByhkKIAhS+5X/QFystG8o6/kd
 inCyI2OiBNb3T4p3l08lBszr9jaTgyxZxOdlX9kChJ3KYYe2PgMEdziQuQYRXKvY
 BrHQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:cc:content-type:date:date:feedback-id
 :feedback-id:from:from:in-reply-to:in-reply-to:message-id
 :mime-version:references:reply-to:sender:subject:subject:to:to
 :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=
 fm1; t=1668981492; x=1669067892; bh=R0kJ18LtZstontPl7D7tUBtnlPAV
 9Wj5NzpbTsIVoUo=; b=HpCYwh5/L4ihXjo8L6d8/0o9uDVp01LbC7tSDM82YN7I
 Dx3tGUqt29nle7FoWT56j8QnYvD2bAaQlEZnT3N1aat7nenJWVucbYf5BsoRqm8S
 SlP6ggNJkwZsyjQKIZxsh++eyBwOszANvFK4/aeAWxohRcAXXXSguXJCCC5jD5sI
 l9O4QeOsv+y0O7MNC/TizeeX+xmD7AJvP9Caz1J5blCVKFt+rXMCOM90Vb2e2V2R
 lAraLWzwi9bNoediuSIw/vYiAYirb4VnhJAWVkFqbLTgxxMcduF2WX6m6J1qT3so
 TsVqPGYjM9D78/uNYFdFGhvc473qu50l0jOzDPUMEA==
X-ME-Sender: <xms:9KJ6Y_rNF2Vlm4CMhgiAsD1anE7tpX8X_G61HspCWmgsuZU3V8qdSg>
 <xme:9KJ6Y5prn2QHd_oaNo8OFsv_GMEKuFNjP-ixDL8ddWfNxgFE_IGqbZfl8meXUfPjc
 n76-w3nOAYt4cL2ow>
X-ME-Received: <xmr:9KJ6Y8OE5ccpdrZ1ywXbQ7yA1XJLwX0JBFz4YnQllrujo2JobeC8drHV-fdX_ckQIM6vjZ7onvctgGlN3FzN9f1-mupxxF1zWpmqPYO134vTXqi->
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrheeggddufeefucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhephffvvefujghffffkfgggtgesthdttddttdertdenucfhrhhomhepufgvrghn
 ucghhhhithhtohhnuceoshhpfihhihhtthhonhesshhpfihhihhtthhonhdrnhgrmhgvqe
 enucggtffrrghtthgvrhhnpedtffdvffeuleeuvdetkedvveehgfehvdegvefghfevudek
 geegleevgeejkeetkeenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrih
 hlfhhrohhmpehsphifhhhithhtohhnsehsphifhhhithhtohhnrdhnrghmvg
X-ME-Proxy: <xmx:9KJ6Yy4lqBSjkqr73cMsqUvXYcCPE9zCJMb7EDTSMvdkK4OwW9X-Tw>
 <xmx:9KJ6Y-7sqkPSGUzY4AiT4xwgwoCuizqEEGtew2zPJ-FPUnfWFuCkag>
 <xmx:9KJ6Y6hR87D5SJhhmewiQRZOibZVLlT-9kPtz6Suw7QGnqKPSYKcvQ>
 <xmx:9KJ6YzhXh8cgRCK8ZI_eJY5X8qAkBSsX0MW3BvB5G46uv2Vlk6rhKQ>
Feedback-ID: i23c04076:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sun,
 20 Nov 2022 16:58:11 -0500 (EST)
Received: by melete.silentflame.com (Postfix, from userid 1000)
 id C778C7EA263; Sun, 20 Nov 2022 14:58:10 -0700 (MST)
From: Sean Whitton <spwhitton@HIDDEN>
To: Juri Linkov <juri@HIDDEN>
Subject: Re: bug#59414: 29.0.50; Have vc-git-expanded-log-entry pass --stat
In-Reply-To: <86ilj9wm14.fsf@HIDDEN> (Juri Linkov's message of "Sun, 
 20 Nov 2022 19:52:55 +0200")
References: <874jutjzqj.fsf@HIDDEN>
 <86ilj9wm14.fsf@HIDDEN>
Date: Sun, 20 Nov 2022 14:58:10 -0700
Message-ID: <878rk5i8zx.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 59414
Cc: 59414 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hello,

On Sun 20 Nov 2022 at 07:52PM +02, Juri Linkov wrote:

>> I would like to add --stat to the list of options passed to git-log(1)
>> by vc-git-expanded-log-entry.  I think it makes VC root logs for Git
>> repositories much more informative with little disadvantage.  Any comments?
>
> Not sure about adding --stat by default since often it produces too long
> multi-line output.  But definitely the options should be customizable
> to avoid adding such cruft to config files:

We already have vc-git-log-switches.  git-log(1) gets called *without*
it in (at least) the following places:

- vc-git-log-outgoing
- vc-git-log-incoming
- vc-git-log-search
- vc-git-expanded-log-entry
- vc-git-region-history

I guess that the first three should probably use vc-git-log-switches if
anything?  And so we would want a separate option for
vc-git-expanded-log-entry.  Not sure about vc-git-region-history.

-- 
Sean Whitton




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#59414; Package emacs. Full text available.

Message received at 59414 <at> debbugs.gnu.org:


Received: (at 59414) by debbugs.gnu.org; 20 Nov 2022 20:14:42 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 20 15:14:42 2022
Received: from localhost ([127.0.0.1]:44717 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1owqiA-0000gO-8d
	for submit <at> debbugs.gnu.org; Sun, 20 Nov 2022 15:14:42 -0500
Received: from mail-wm1-f44.google.com ([209.85.128.44]:43662)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <raaahh@HIDDEN>) id 1owqi8-0000gC-Gf
 for 59414 <at> debbugs.gnu.org; Sun, 20 Nov 2022 15:14:41 -0500
Received: by mail-wm1-f44.google.com with SMTP id
 a11-20020a05600c2d4b00b003cf6f5fd9f1so7732721wmg.2
 for <59414 <at> debbugs.gnu.org>; Sun, 20 Nov 2022 12:14:40 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=content-transfer-encoding:in-reply-to:from:references:cc:to
 :content-language:subject:user-agent:mime-version:date:message-id
 :sender:from:to:cc:subject:date:message-id:reply-to;
 bh=idCVGZBo6YUy/9rmqmnjPewgoltyNotmdwb9w8uB6NA=;
 b=ZURbdY1r/gcdPN0ZLEbrYfBu3IPsnMHwtzPe/hZoeYi4VXY6cD/bpLYd2w6tt596lL
 JELSmQyQ5ld5vmUY7A3/S+tZat+Fk29Xlm9gueoGd8ZqTPei1/XOoQm8hI0K/JS91AKL
 e1KKrEOJAyy9J3VKRyAQ7OaXvgqdDBq5gUs7k9EKKf/m2LDX0vHrH4QMsDY7pcbgbstO
 XgeYiAcgAuXbMDcXLrc+VBAA07Acu43kmOx+tbohXW2kfVksVxyXKlrBplbBsXguelVa
 5pbZjqTCapL8mqlBVg8thynSyEyovKmE2qKXgBmzhYKaM7QhLjo1HApxpIZggHvhKE+V
 IPQg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=content-transfer-encoding:in-reply-to:from:references:cc:to
 :content-language:subject:user-agent:mime-version:date:message-id
 :sender:x-gm-message-state:from:to:cc:subject:date:message-id
 :reply-to;
 bh=idCVGZBo6YUy/9rmqmnjPewgoltyNotmdwb9w8uB6NA=;
 b=CrCybsnNNTErwEb2qi3aUK/oMRYpf6tjtsQD4Tnsr1NNvqeuvR1aAwR7OnEZPXJeGs
 WtQf7YnD+ayJUv812Z0jxQ5M4MxBf+8gRJogMeAnruEXARUvyw6eXi21iHSDxftC6rFo
 ClmepblRqvSmDecNIfRjblPs/XypHg7BbpFT6XL86TEq6i6o8l4iQQOjRXbeGMjCvYw4
 Uh2qPl91kJhExiXW+ubZoY3iYQVSsr/5t0ueyREq9pR2ibj1b8FwcMWKpjgrhPnJMhG1
 7iv3PInw++BDto8+YxWYOnvaz08wmK8k2+pGvxk2c60TnMEtdvCTmwsEXzFqyAQKWUT8
 LEAA==
X-Gm-Message-State: ANoB5plan6iLL4MGsAzxIXYkhsBRW53GLjzPR1+njhcn06fw8k5Bujg8
 rFHOGx3B3iOd4eiflXthWWQ=
X-Google-Smtp-Source: AA0mqf6izkFA7xrs++rw7ah1xS5Euqdz4BBkDyOnqashAqNScdWcwH7ZaTrN3iNQ9MqkPNZseZiGrQ==
X-Received: by 2002:a05:600c:1f16:b0:3cf:66a2:d440 with SMTP id
 bd22-20020a05600c1f1600b003cf66a2d440mr10403372wmb.108.1668975274493; 
 Sun, 20 Nov 2022 12:14:34 -0800 (PST)
Received: from [192.168.0.6] ([46.251.119.176])
 by smtp.googlemail.com with ESMTPSA id
 c1-20020adffb01000000b0023657e1b980sm9331849wrr.53.2022.11.20.12.14.33
 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);
 Sun, 20 Nov 2022 12:14:34 -0800 (PST)
Message-ID: <0c7183a4-9a82-8bf4-3593-f8e790a8b884@HIDDEN>
Date: Sun, 20 Nov 2022 22:14:31 +0200
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.2.2
Subject: Re: bug#59414: 29.0.50; Have vc-git-expanded-log-entry pass --stat
Content-Language: en-US
To: Juri Linkov <juri@HIDDEN>, Sean Whitton <spwhitton@HIDDEN>
References: <874jutjzqj.fsf@HIDDEN>
 <86ilj9wm14.fsf@HIDDEN>
From: Dmitry Gutov <dgutov@HIDDEN>
In-Reply-To: <86ilj9wm14.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.2 (/)
X-Debbugs-Envelope-To: 59414
Cc: 59414 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.8 (/)

On 20.11.2022 19:52, Juri Linkov wrote:
>> I would like to add --stat to the list of options passed to git-log(1)
>> by vc-git-expanded-log-entry.  I think it makes VC root logs for Git
>> repositories much more informative with little disadvantage.  Any comments?
> Not sure about adding --stat by default since often it produces too long
> multi-line output.  But definitely the options should be customizable
> to avoid adding such cruft to config files:

Some new -switches variable could work. One should also ask themselves 
whether they want to apply the new switches to the "full" log as well -- 
one you get by pressing 'C-x v l'.




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#59414; Package emacs. Full text available.

Message received at 59414 <at> debbugs.gnu.org:


Received: (at 59414) by debbugs.gnu.org; 20 Nov 2022 18:04:18 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 20 13:04:18 2022
Received: from localhost ([127.0.0.1]:44538 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1owofx-0005nx-Sf
	for submit <at> debbugs.gnu.org; Sun, 20 Nov 2022 13:04:18 -0500
Received: from relay11.mail.gandi.net ([217.70.178.231]:35609)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <juri@HIDDEN>) id 1owofv-0005ng-Dr
 for 59414 <at> debbugs.gnu.org; Sun, 20 Nov 2022 13:04:16 -0500
Received: (Authenticated sender: juri@HIDDEN)
 by mail.gandi.net (Postfix) with ESMTPSA id BDA56100004;
 Sun, 20 Nov 2022 18:04:05 +0000 (UTC)
From: Juri Linkov <juri@HIDDEN>
To: Sean Whitton <spwhitton@HIDDEN>
Subject: Re: bug#59414: 29.0.50; Have vc-git-expanded-log-entry pass --stat
In-Reply-To: <874jutjzqj.fsf@HIDDEN> (Sean Whitton's message
 of "Sun, 20 Nov 2022 10:35:16 -0700")
Organization: LINKOV.NET
References: <874jutjzqj.fsf@HIDDEN>
Date: Sun, 20 Nov 2022 19:52:55 +0200
Message-ID: <86ilj9wm14.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 59414
Cc: 59414 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

> I would like to add --stat to the list of options passed to git-log(1)
> by vc-git-expanded-log-entry.  I think it makes VC root logs for Git
> repositories much more informative with little disadvantage.  Any comments?

Not sure about adding --stat by default since often it produces too long
multi-line output.  But definitely the options should be customizable
to avoid adding such cruft to config files:

  (with-eval-after-load 'vc-git
    ;; OVERRIDDEN AND ADDED "--pretty=fuller"
    (defun vc-git-expanded-log-entry (revision)
      (with-temp-buffer
        (apply 'vc-git-command t nil nil (list "log" revision "-1" "--pretty=fuller" "--"))
        (goto-char (point-min))
        (unless (eobp)
          ;; Indent the expanded log entry.
          (while (re-search-forward "^  " nil t)
            (replace-match "")
            (forward-line))
          (buffer-string)))))




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#59414; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 20 Nov 2022 17:35:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun Nov 20 12:35:27 2022
Received: from localhost ([127.0.0.1]:44493 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1owoE2-0002oZ-UI
	for submit <at> debbugs.gnu.org; Sun, 20 Nov 2022 12:35:27 -0500
Received: from lists.gnu.org ([209.51.188.17]:46076)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <spwhitton@HIDDEN>) id 1owoDy-0002oP-PJ
 for submit <at> debbugs.gnu.org; Sun, 20 Nov 2022 12:35:26 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <spwhitton@HIDDEN>)
 id 1owoDy-0004jF-KO
 for bug-gnu-emacs@HIDDEN; Sun, 20 Nov 2022 12:35:22 -0500
Received: from out1-smtp.messagingengine.com ([66.111.4.25])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <spwhitton@HIDDEN>)
 id 1owoDw-0001EX-V2
 for bug-gnu-emacs@HIDDEN; Sun, 20 Nov 2022 12:35:22 -0500
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.nyi.internal (Postfix) with ESMTP id 9BD655C0124
 for <bug-gnu-emacs@HIDDEN>; Sun, 20 Nov 2022 12:35:17 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute5.internal (MEProxy); Sun, 20 Nov 2022 12:35:17 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=spwhitton.name;
 h=cc:content-type:date:date:from:from:in-reply-to:message-id
 :mime-version:reply-to:sender:subject:subject:to:to; s=fm3; t=
 1668965717; x=1669052117; bh=WRccrAXgQ0y1w4oeydrZm/rhtn9NXP1D/Kh
 bG9kZV5I=; b=NMsVd6G9DBlegc2HV5AiFSoOFogqVeaw/42CgdZD2wO8YNxxd04
 m74rCaLGGZ2uB4a4GjF51ltdqH50R6tcMOO/rrhrgSEB08Qtfh8MwrRfH+++NNDm
 GRNjbCF0Dckej73VUE1VWLw4B3m+rB96IX66mrXlMWK9t67lpLUyLOcyN/e25mxU
 w09H3nIzcroOY24ALIZXXS7q7r/bycveptfXwHCBRrtxuZuN69jZmT37Bht+NnzB
 YLdlGcZsMp6BpFrGWnDEAuqs0dvRelv2vIn9blqjQS5mw0pGCAWsFlSOnfFxXnbC
 UwWR8ytcq6qs43AEnMsr6IcSIqm0VS7EkkQ==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-type:date:date:feedback-id
 :feedback-id:from:from:in-reply-to:message-id:mime-version
 :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy
 :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1668965717; x=
 1669052117; bh=WRccrAXgQ0y1w4oeydrZm/rhtn9NXP1D/KhbG9kZV5I=; b=U
 /QE4xnBLfyAX6wex5pk7zTFvLIuqIg/ll96MhyNffdUJqeUXcDmwdJDAMsAHWIE3
 0v6QHMRmUpTs/HFR1p0XyHNQbEFEU00z5AwedHGsOt3glc4dAvwpmOqt7pfswyUj
 vB6bz1bXeY9lXItFLQ9uSXdmm1oGMlqYA5F+0GejDM3r/kLNV9BqiyuBc571oi+9
 bvR9RQmY3oUX+7Fd6CCX7NBmPqtCSk/K0fFimPUCVhywJEUCaNvMpbjQsrhVTz1h
 XZYZxrzXMcW5CcLF7RghTEwkWW1B2kOxp4VJtN9kSGf/7P2YVCSE2DZW1D4TsGUG
 Ug5dv515D6ojbnRW9YSPQ==
X-ME-Sender: <xms:VWV6Yw5KfGgDWcgolOWC8UXFMnVY8gHD88W8sghPm9tIW9XDwol5hg>
 <xme:VWV6Yx44Uth4bCDIsgl73gmcH7NlO4-gkRC1CnBZYNlCs9ulunjL7ngqUQDqjHEfN
 mckHvSBv0GQ0qTBYA>
X-ME-Received: <xmr:VWV6Y_cwdbC1UGB5W-scW5bg0V6F8tO0gkNClnS-z081Mhcrs9Wi88BjZDix3ai1Sp_36hmkuGSA_Tm4Ssbj80ZV1x1oGot46pHHd3fYxO5VjU5fuA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvgedrheeggdejkecutefuodetggdotefrodftvf
 curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu
 uegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkfgfgggtsehttddttddtre
 dtnecuhfhrohhmpefuvggrnhcuhghhihhtthhonhcuoehsphifhhhithhtohhnsehsphif
 hhhithhtohhnrdhnrghmvgeqnecuggftrfgrthhtvghrnhepfffgheeggffgheeuvdethf
 ekuddtgffgtdeukeegkedttefftdeghfdvgfdtjeelnecuvehluhhsthgvrhfuihiivgep
 tdenucfrrghrrghmpehmrghilhhfrhhomhepshhpfihhihhtthhonhesshhpfihhihhtth
 honhdrnhgrmhgv
X-ME-Proxy: <xmx:VWV6Y1IvewbpAgw43bzLovweGv1UiovG32Chqj9frkqoe_dlfyQtfw>
 <xmx:VWV6Y0KW0mb_OdMQDBJTD6KgmXVBWzwVW9NKHcUQ8OVu4_qhHWbjfQ>
 <xmx:VWV6Y2ziZzwGEREPNAEoC01jYBjxcWFUp4NqM63jfqOBn3ma_UZIQA>
 <xmx:VWV6Y7kQjiEx880MEXx16jmjzDevk9pL2penuatBFE546fdPVAaT3g>
Feedback-ID: i23c04076:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA for
 <bug-gnu-emacs@HIDDEN>; Sun, 20 Nov 2022 12:35:17 -0500 (EST)
Received: by melete.silentflame.com (Postfix, from userid 1000)
 id 15FFF7E6DDA; Sun, 20 Nov 2022 10:35:16 -0700 (MST)
From: Sean Whitton <spwhitton@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 29.0.50; Have vc-git-expanded-log-entry pass --stat
Date: Sun, 20 Nov 2022 10:35:16 -0700
Message-ID: <874jutjzqj.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=66.111.4.25;
 envelope-from=spwhitton@HIDDEN; helo=out1-smtp.messagingengine.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.6 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)

Hello,

I would like to add --stat to the list of options passed to git-log(1)
by vc-git-expanded-log-entry.  I think it makes VC root logs for Git
repositories much more informative with little disadvantage.  Any comments?

-- 
Sean Whitton




Acknowledgement sent to Sean Whitton <spwhitton@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to bug-gnu-emacs@HIDDEN:
bug#59414; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Mon, 5 Dec 2022 12:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.