Received: (at 59438) by debbugs.gnu.org; 7 Sep 2023 21:07:19 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Sep 07 17:07:19 2023 Received: from localhost ([127.0.0.1]:41519 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1qeMDf-0007ft-Ck for submit <at> debbugs.gnu.org; Thu, 07 Sep 2023 17:07:19 -0400 Received: from mail-lf1-x12c.google.com ([2a00:1450:4864:20::12c]:58721) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1qeMDc-0007fd-R2 for 59438 <at> debbugs.gnu.org; Thu, 07 Sep 2023 17:07:17 -0400 Received: by mail-lf1-x12c.google.com with SMTP id 2adb3069b0e04-501bd7711e8so2433722e87.1 for <59438 <at> debbugs.gnu.org>; Thu, 07 Sep 2023 14:07:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1694120829; x=1694725629; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=vM0x687fy5RaKTKbRavxxrdTLuwCutn8czrcft0iu+0=; b=jJgXXF2/gyrpiy0ZCAXKT56f5eUZOdbWjUi2aad2P0abom9MnE9+sH54Hnu6XxLHll nlEYJX+ge72b4qOe/ElfeB8WvSPdIoXovY/peLMNwVknSyYq3zei0jZFCvKRJ9dGIsoB c2pNnM8TidSY8A9qt+8iikhhOe/Fkxdn21WCkyEMa1qlOrdRgFSBqf4K32wIQqpib0+h ziT2Pet0TVJ/iIbbvAvoPGTe3K84PPv8klWBDvwJrpr5m5Eu45Ruwrltydmiz18WOL9S v0qBCr8nMZqE1XzgcmdRgQfzoUBYu2ns9RPOZv+ji/phszWMxsxo9Mx3mIOi0OMcG+eG wzYw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694120829; x=1694725629; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vM0x687fy5RaKTKbRavxxrdTLuwCutn8czrcft0iu+0=; b=a5pndOR58MZVcnsn4mjiXuzfr0RweiDkHAldANkjMt9uQgqFxjxz32pegR0DvG97Hv OfoufUZuwTz41O0TdDl2t+XuKib6KS4mE+HBBYgBfFeoAi9cZS/ApYOL/B7wp6psh6/H x4eM6dfW98YgcMt+VbTN2LZ5jty3BrnO0aGHAXwUZbRMUcL9kBRWnOvjzGeM6egENs+W ANRw0R7/xVj7tuWXe3B27/WSBm/8eWV5E/qG8S2FFe3OtqQ4xD1YpGV2sXLRtRpbhVSe Cvn25wS+Pm+cBGtNyJgKYoPZLOVu9MnihQK/Ch+Z1xc9sSi1JR+MoIgwB0GcmB82+07o /TCA== X-Gm-Message-State: AOJu0YwBXG/GTmA3Nf8H6IjxBQOyxRnKdYb2hCKP0f25Kd+MhHrA93sz JmzOuWKZMvnsxmIhoDTHHDuCoyonD0UAdXwJap8= X-Google-Smtp-Source: AGHT+IEHaVCtWwJ7g+f6q+OrYxpwFnBuWLbsAvr2QijYBW1JnvVvoI3Ib87huKNe/ACh6wESK3C0ANln0HYpSuYXQ70= X-Received: by 2002:a05:6512:3d8e:b0:500:8d17:1992 with SMTP id k14-20020a0565123d8e00b005008d171992mr493504lfv.22.1694120828791; Thu, 07 Sep 2023 14:07:08 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 7 Sep 2023 14:07:08 -0700 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <CADwFkm=74_r2ddOw_ebexBG1PG2J_SGgDeZNfMMjyYTF5Rvxug@HIDDEN> (Stefan Kangas's message of "Thu, 24 Nov 2022 17:15:56 -0800") References: <SJ0PR06MB860970919EE7F0B0A8E645708B0A9@HIDDEN> <CADwFkm=74_r2ddOw_ebexBG1PG2J_SGgDeZNfMMjyYTF5Rvxug@HIDDEN> MIME-Version: 1.0 Date: Thu, 7 Sep 2023 14:07:08 -0700 Message-ID: <CADwFkmm=kpLwEdQkM2SOKdjwUe0REEm83+Uet2X6ZY_FYjadWA@HIDDEN> Subject: Re: bug#59438: 29.0.50; [PATCH] Make defvar's into defcustom's in tab-line To: Gabriel <gabriel376@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59438 Cc: 59438 <at> debbugs.gnu.org, Juri Linkov <juri@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Stefan Kangas <stefankangas@HIDDEN> writes: > Gabriel <gabriel376@HIDDEN> writes: > >> Please find attached a patch that proposes the following minor changes >> to tab-line. I can refactor the patch if we decide that some change are >> not worth or if it's better to split it into smaller patches. >> >> 1) Turn the following defvar's into defcustom's: >> >> - `tab-line-tabs-buffer-group-function' >> - `tab-line-tabs-buffer-group-sort-function' >> - `tab-line-tabs-buffer-groups-sort-function' >> >> 2) Add conditional around function call of >> `tab-line-tabs-buffer-groups-sort-function', in >> `tab-line-tabs-buffer-groups'. This guards against nil values, similar >> to how `tab-line-tabs-buffer-group-sort-function is handled, making the >> behavior more consistent across these two (similar) variables. >> >> Should we announce these "new" defcustom's in NEWS? > > Juri, thoughts? Ping. Does anyone have any comments?
bug-gnu-emacs@HIDDEN:bug#59438; Package emacs.
Full text available.Received: (at 59438) by debbugs.gnu.org; 25 Nov 2022 01:16:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 24 20:16:04 2022 Received: from localhost ([127.0.0.1]:60675 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oyNJz-0008UD-Vp for submit <at> debbugs.gnu.org; Thu, 24 Nov 2022 20:16:04 -0500 Received: from mail-oi1-f176.google.com ([209.85.167.176]:36630) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1oyNJy-0008TZ-S1 for 59438 <at> debbugs.gnu.org; Thu, 24 Nov 2022 20:16:03 -0500 Received: by mail-oi1-f176.google.com with SMTP id s206so3045323oie.3 for <59438 <at> debbugs.gnu.org>; Thu, 24 Nov 2022 17:16:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=UjSiYtj5svcqrJyWVUbqoqzqwnij4NjI0+qaqkOiBJ0=; b=Wpt8UPxVjiI00kjteP4hmdxlnansFYducrriYFetsxUlom6tbJOCWVSe6xWx9rsFU2 XTKDJeI7LPrKGLTc+2kW7TpbHflJB2lBw2ZRF9Wcaimma3CrupT7e6c0H1FZ+YLR4oj9 QL+gz0VtEn4HliR34Wphfsjyrv8wPINN24Vw/EuuCEA8+enCbGGhlB2gttMoP7SIPNtX goo7ludw7e8eX7es0RAvsCKc8/AfTa7eQk0G7UAAc7aldM8t6KrWs2BGlUHCSk0EoNVd jM1TqD9U9Em7by0/LiTsqwEvbcRl0Wj6FAZG5LOPeoEqvIqm1M6rmJcuCTOfi2qQwI/j yATA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UjSiYtj5svcqrJyWVUbqoqzqwnij4NjI0+qaqkOiBJ0=; b=lCAV4YrQ7K4c2+Qa0deCooA2JNof4CXRRZT9fmqMCUBPBxYYQtRT6I/V92d7zaO3JZ L8JqZaQ/Ukj2wZeQTwPiT87aWhXq+qZaVtk9YYa9e6u/Uwj1V9v7CYHh16XqJKMWU7VO v0YnImJw/oViiFU/SBr+Q19phTDLksh/kJTyEC3mlry2jVq4OFT2lBo+RxKZao0xfDRm PhTJqnOtsjp5I2rtXxmJ579mtcxVjaiJpTGrGB2NLFWVBR0oCJJixr8EDsiHZrV5JwIl 0GpKyeJ79zi/kkgC9Kbj8LZ1KRJKdiA+kdCV+Bhaxpv5dubmdgvk05Kqe+dIqHs+W9ei IJEg== X-Gm-Message-State: ANoB5pnLPejQbsgY07p439JEFeewtFzp10S4xx7B9lCGc/MMHWiA+9O2 eaz3OCoh4WbQRiWGLgkIc0wgyGgH1rdJmsCiGnA= X-Google-Smtp-Source: AA0mqf4T4HCIoLC3LeKbJ+6/AXjEomIliI3Rpjk2HqiTPqs65lk3cXxU+395gohXX82sCGteG02CY0VikfRhsJ55Uzo= X-Received: by 2002:a05:6808:2229:b0:35b:2b17:af81 with SMTP id bd41-20020a056808222900b0035b2b17af81mr8007073oib.199.1669338957336; Thu, 24 Nov 2022 17:15:57 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 24 Nov 2022 17:15:56 -0800 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <SJ0PR06MB860970919EE7F0B0A8E645708B0A9@HIDDEN> (Gabriel's message of "Mon, 21 Nov 2022 06:25:17 -0300") References: <SJ0PR06MB860970919EE7F0B0A8E645708B0A9@HIDDEN> X-Hashcash: 1:20:221125:juri@HIDDEN::JBwDVW0CQbj9xbRD:QWB MIME-Version: 1.0 Date: Thu, 24 Nov 2022 17:15:56 -0800 Message-ID: <CADwFkm=74_r2ddOw_ebexBG1PG2J_SGgDeZNfMMjyYTF5Rvxug@HIDDEN> Subject: Re: bug#59438: 29.0.50; [PATCH] Make defvar's into defcustom's in tab-line To: Gabriel <gabriel376@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 59438 Cc: 59438 <at> debbugs.gnu.org, Juri Linkov <juri@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Gabriel <gabriel376@HIDDEN> writes: > Please find attached a patch that proposes the following minor changes > to tab-line. I can refactor the patch if we decide that some change are > not worth or if it's better to split it into smaller patches. > > 1) Turn the following defvar's into defcustom's: > > - `tab-line-tabs-buffer-group-function' > - `tab-line-tabs-buffer-group-sort-function' > - `tab-line-tabs-buffer-groups-sort-function' > > 2) Add conditional around function call of > `tab-line-tabs-buffer-groups-sort-function', in > `tab-line-tabs-buffer-groups'. This guards against nil values, similar > to how `tab-line-tabs-buffer-group-sort-function is handled, making the > behavior more consistent across these two (similar) variables. > > Should we announce these "new" defcustom's in NEWS? Juri, thoughts?
bug-gnu-emacs@HIDDEN:bug#59438; Package emacs.
Full text available.Stefan Kangas <stefankangas@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at submit) by debbugs.gnu.org; 21 Nov 2022 09:29:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 21 04:29:13 2022
Received: from localhost ([127.0.0.1]:45440 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ox373-0004PT-5U
for submit <at> debbugs.gnu.org; Mon, 21 Nov 2022 04:29:13 -0500
Received: from lists.gnu.org ([209.51.188.17]:44938)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <gabriel376@HIDDEN>) id 1ox36x-0004PI-Pl
for submit <at> debbugs.gnu.org; Mon, 21 Nov 2022 04:29:11 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <gabriel376@HIDDEN>)
id 1ox36x-0002VJ-7H
for bug-gnu-emacs@HIDDEN; Mon, 21 Nov 2022 04:29:07 -0500
Received: from mail-bn8nam04olkn2108.outbound.protection.outlook.com
([40.92.47.108] helo=NAM04-BN8-obe.outbound.protection.outlook.com)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <gabriel376@HIDDEN>)
id 1ox36q-0001FM-Ha
for bug-gnu-emacs@HIDDEN; Mon, 21 Nov 2022 04:29:06 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=TTd//uUGajIn8njrWZ1xpkcvO5+WGsqDomJu6F9zg+6EQnbRVTPMNIfeFzE81cbMAyhrz1b3RsmbMV8SjXTrySmGoMLZVmjaxPDcb+ImVvV4qdRnechYlGMxAOHj8+R9w1K1i6BnfmJr66GO1XCmc7yGOerfkap9aiu63erLIaRLtEcNE2YsVEvjLR2zMDPg6HCYj5ODYjaLBnsChSiqSSNd5FVmHaADUexPEYo/eV7IcjpMz7dS9WSH2YYmp9l2yYg8q3Du+u0JbhCJf1TgkBDr6PzJFQgOc0ISzx8esXzZnUFCn8Ce0vVKTV0tk4D99nXmEIV5nDbKepyiseTxyw==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=MTJ5Tf/znQ/0Kc0nMD2fVgZw81rGIFZN8euc0/agVHg=;
b=WIqceF9U15nF5JBa+PjMw0KDFRvM6uu73nOA6pS3YbfbFO0r+9RtDKMRdK985AcLAosyfi31cNOweUOxzKv+SpxwNeJb6GE4wu2s6y1njamKeHx5LN9s6sTz95jX6Bpw/Xpx4bCyL3DZ2cYbnqspbP4ZQYIgzC1eu6qviZ8PzTSf4sbEWwNa9z47a3apcyw+/ere4vLc2tnBJTSty5zlPNbqOoRObiVKzt9/9Dv1il+cW/c8iz/VxIYXubA9ZLuiI4hTHaD9+78sPXr4hzH4HA4l4XYQmeaD5RbCh8WuIGUPQiScFXlanS+d/1eTm/lEpI1s9TyWMeTy2CKbOcqPHQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=MTJ5Tf/znQ/0Kc0nMD2fVgZw81rGIFZN8euc0/agVHg=;
b=s4wSxRYXYZlhDXp+ZVfou3JP9kt4qZLoCERd8d15rXsO0FscjkLxbh9LgUjD/DCyqf5M30dAyZpZ1/Twarv+hCF97t+HbIMGrZlOBAmOtSMpD4xzOJRD/1Ku3/VihvzCWEUYt5RtFq5q4L0PtlL7TsXvgxH1T2TlxsdOkRlEGIcs6sqqOgzbK3rOc2uHolXBGHj9ImuerEhHTM5w5lkchoSHuQ6Iq0dIUJEe5YJwixCUp51CVX4/xtZ95wiFJxMuCx9z+Oth1o43x/Tvg2sGGJZJ5PjGPMjs9cAb5Xjt1i5H4VFEvkNC0aX8jqAkUOb+Z0o7kyPVN8eTE2ZzTNnfZw==
Received: from SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11)
by SJ0PR06MB7471.namprd06.prod.outlook.com (2603:10b6:a03:32d::22)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Mon, 21 Nov
2022 09:25:24 +0000
Received: from SJ0PR06MB8609.namprd06.prod.outlook.com
([fe80::33ae:d3a7:24ae:5c6f]) by SJ0PR06MB8609.namprd06.prod.outlook.com
([fe80::33ae:d3a7:24ae:5c6f%4]) with mapi id 15.20.5857.017; Mon, 21 Nov 2022
09:25:24 +0000
From: Gabriel <gabriel376@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 29.0.50; [PATCH] Make defvar's into defcustom's in tab-line
Date: Mon, 21 Nov 2022 06:25:17 -0300
Message-ID: <SJ0PR06MB860970919EE7F0B0A8E645708B0A9@HIDDEN>
Content-Type: multipart/mixed; boundary="=-=-="
X-TMN: [iQ+vraUXZ5IjxuIWGxejnx3J1UdHS9UCkqVLxzY/0zxRdgMm/phm5Nlye/r3kc4A]
X-ClientProxiedBy: CPYP284CA0025.BRAP284.PROD.OUTLOOK.COM
(2603:10d6:103:69::12) To SJ0PR06MB8609.namprd06.prod.outlook.com
(2603:10b6:a03:40c::11)
X-Microsoft-Original-Message-ID: <87leo4acci.fsf@HIDDEN>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR06MB8609:EE_|SJ0PR06MB7471:EE_
X-MS-Office365-Filtering-Correlation-Id: c3f0aa96-7cca-4a55-f0bf-08dacba251b3
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: YVX6KGD+00N1TNNkrKu+YWvg3PDWe4zQFpPEdQG2Zx0tjEkiP6+dk/m6Qbxu/jlQPQXjDHQSbYx74caOSgfs19XT/1hlkIxUcQYaMKNELPI3WkAIJc0aTntkifH/h6Hyc646m86mAFxuM3BqVpre5Ueelj9w45XaKekHIM3r3Ur2wSWev6Vxp9O/a67ZT01CJbuZJweqhhG7cpqJjNB0o/QglBmBgw4hsX/PktN/m2rDfNa2HsZyaWWrzShkZ1bcF828qDvxx9RkrpbiIWqIPf2KrY/3MAqh0GfNIJQnjcQQlyNjW1DdHMFxJH8nNofLDTLTfpdCmav9vyv6CkPzfovqRs8IXdKD09oBT4XmLdNYV+TkeuY/8TLG1bPSBSso+mZa0ZnwOOFpA6BkgcrE6sGNmerEt6Fa9nCZ/TW82RkbSgAbd2mKdI3b7+//7CfrfiPxv02Q/f7Gj5n/gRDlfd0/hRZJ4J1Ns8fNkeUwEVlyrc63Cl/hTcunn/jWfC6Z9Nn4Gc29BMhPWvvpx6m4V73wmTLccNzwv+O/8aeb47M2DHD7fcN81myp1L4ogWVJ4YWRsK7U5BUYhZvjy/PKNt/bttR8K5MoI8ExeTeBUcM=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?MyGU9lQ75wRzrD4e3Xb16MG31x+gruxNhZ0HTy5wysh+kKhUpvkoA5wh8y/S?=
=?us-ascii?Q?5YBnwP4JYLSo4RqbPlWcTiRkOhjMGMFj0/5hRPdQiE4PgE/VMA8tKWnR9eUV?=
=?us-ascii?Q?mKXxzmNZSaQlNKprbsr0lLnTZWWXWO798Q1jUmMuGEgRcJLTx88r8i3GrTbY?=
=?us-ascii?Q?TfPTCR4VF58TEfqPnEOCxGCSDnZMqILuNgSEeGO8s1o/7KmhUCO0MtTyrpDw?=
=?us-ascii?Q?K24w1aInQoiJXp7smja6ukOy2Ia4kd6o+tK9JDlZnETT0Fhz6G5qNNa71eE4?=
=?us-ascii?Q?U2QMZ8f8i+X7JoK12zeJ7qVk7ELVjH8YQhASvvxQEFhqeHRYfWC+vMBN0kE6?=
=?us-ascii?Q?b56GbeG9mlF7qc4BHht0l4VBRVPgueY/VYhTWtNXMbSqquei6/ZJn0sJ2cqW?=
=?us-ascii?Q?oF+ihL+KntWe0hPB+g1fB8NesbSKhWc+A3pZz/QdmpqT8PcpjzbvkifGjtJu?=
=?us-ascii?Q?AlINdREkYuzZYE7j6PXbFm0a3dEmJnJJrCRIBzHkhZqtmTVmSVxXjM0evP7+?=
=?us-ascii?Q?CBFu2fV/Yu+jVmljMEI2m9JIW56bAOUu/1FgsAqXZ2V7ljKRC3fdIvvkJ2TN?=
=?us-ascii?Q?Q1nE2uZh5aEV10YbOgNsbdM45rglUW7Q3qATPHX62lj4odjjEszR3El/UqP8?=
=?us-ascii?Q?ccr4oWu1b0n+SWmKGihDYTZndRLxEuCr/6NwxArCw2W7/k3pAtKyM3jyzoA2?=
=?us-ascii?Q?mlspQZejGZrj5LoLSTa20aW+sx8tXw/IHkkvZJ6OWLSN1y7sQ1OIiqHKinPo?=
=?us-ascii?Q?4JSzN8QBdkiRprWzVQn+HyWr23FPNST6wv8hxNp4O/kNcPSWfEeN1AUHt58V?=
=?us-ascii?Q?X0FDdT9AAFsm6nxbaKEHBxFzsMlgG+KfdUosSEMK5gIXYMLiGVTfk7R2lZg3?=
=?us-ascii?Q?4j8hMrNTYqJoUJkWBurY6e0sZQF0rcGZsS/wEbgu2vmavgyyHip1ZZmSD9cy?=
=?us-ascii?Q?W8FkAuNLBQD2d9ub6s/dgXklc185HnH2BII5YvE3Rg6YNKHl0rM+rVapmPXK?=
=?us-ascii?Q?ZSQSwfvKASenNaSftfygBicyj63RbsaLHNAsAE825/C7uSxAyfPtv4owg6rD?=
=?us-ascii?Q?tjRfRE5RButETLNDLPM7/nm9qcyoVmfh38T9C6njv6H9YmH8yZABZfa4IO7e?=
=?us-ascii?Q?xdQb065h6acs9PByisoxk0UXDEj2fU0ty19+Wp3wbJ9vzTaPBlOl1shPyzxf?=
=?us-ascii?Q?T15MtfZ6+Y5J6EtoJKnavR/Wm5QlgisNUIxmjUKs5S1e7igELToboYXIFz7a?=
=?us-ascii?Q?SNT5iPMTe9BMwSBjT+W2Fl2iV4tuQo2kF4ni7oTpGlFH25rYPvJUM+TBuuzZ?=
=?us-ascii?Q?2lDeYWjlBOGfUheO0gpPLOJBiZYRL8X090+BBHCb+wtnlA=3D=3D?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-89723.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: c3f0aa96-7cca-4a55-f0bf-08dacba251b3
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR06MB8609.namprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Nov 2022 09:25:24.8326 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR06MB7471
Received-SPF: pass client-ip=40.92.47.108; envelope-from=gabriel376@HIDDEN;
helo=NAM04-BN8-obe.outbound.protection.outlook.com
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.1 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.1 (--)
--=-=-=
Content-Type: text/plain
Description:
Please find attached a patch that proposes the following minor changes
to tab-line. I can refactor the patch if we decide that some change are
not worth or if it's better to split it into smaller patches.
1) Turn the following defvar's into defcustom's:
- `tab-line-tabs-buffer-group-function'
- `tab-line-tabs-buffer-group-sort-function'
- `tab-line-tabs-buffer-groups-sort-function'
2) Add conditional around function call of
`tab-line-tabs-buffer-groups-sort-function', in
`tab-line-tabs-buffer-groups'. This guards against nil values, similar
to how `tab-line-tabs-buffer-group-sort-function is handled, making the
behavior more consistent across these two (similar) variables.
Should we announce these "new" defcustom's in NEWS?
--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment;
filename=0001-Make-defvar-s-into-defcustom-s-in-tab-line.patch
From da1053e7211d8bb17769fe43650a9bcdd359aeab Mon Sep 17 00:00:00 2001
From: Gabriel do Nascimento Ribeiro <gabriel376@HIDDEN>
Date: Mon, 21 Nov 2022 06:17:49 -0300
Subject: [PATCH 1/1] Make defvar's into defcustom's in tab-line
* lisp/tab-line.el (tab-line-tabs-buffer-group-function)
(tab-line-tabs-buffer-group-sort-function)
(tab-line-tabs-buffer-groups-sort-function): Make into defcustom's.
(Make defvar's into defcustom's in tab-line): Handle case when
variable tab-line-tabs-buffer-groups-sort-function is nil.
---
lisp/tab-line.el | 51 ++++++++++++++++++++++++++++--------------------
1 file changed, 30 insertions(+), 21 deletions(-)
diff --git a/lisp/tab-line.el b/lisp/tab-line.el
index 99a785ee3e..9b1c101718 100644
--- a/lisp/tab-line.el
+++ b/lisp/tab-line.el
@@ -341,16 +341,26 @@ tab-line-tabs-mode-buffers
(derived-mode-p mode)))
(funcall tab-line-tabs-buffer-list-function)))))
-(defvar tab-line-tabs-buffer-group-function nil
+(defcustom tab-line-tabs-buffer-group-function nil
"Function to add a buffer to the appropriate group of tabs.
-Takes a buffer as arg and should return a group name as a string.
-If the return value is nil, the buffer should be filtered out.")
+Takes a buffer as argument and should return a group name as a
+string. If the return value is nil, the buffer should be
+ filtered out."
+ :type 'function
+ :group 'tab-line
+ :version "29.1")
-(defvar tab-line-tabs-buffer-group-sort-function nil
- "Function to sort buffers in a group.")
+(defcustom tab-line-tabs-buffer-group-sort-function nil
+ "Function to sort buffers in a group."
+ :type 'function
+ :group 'tab-line
+ :version "29.1")
-(defvar tab-line-tabs-buffer-groups-sort-function #'string<
- "Function to sort group names.")
+(defcustom tab-line-tabs-buffer-groups-sort-function #'string<
+ "Function to sort group names."
+ :type 'function
+ :group 'tab-line
+ :version "29.1")
(defvar tab-line-tabs-buffer-groups mouse-buffer-menu-mode-groups
"How to group various major modes together in the tab line.
@@ -378,13 +388,14 @@ tab-line-tabs-buffer-groups
generate the group name."
(if (window-parameter nil 'tab-line-groups)
(let* ((buffers (funcall tab-line-tabs-buffer-list-function))
- (groups
- (seq-sort tab-line-tabs-buffer-groups-sort-function
- (delq nil (mapcar #'car (seq-group-by
- (lambda (buffer)
- (tab-line-tabs-buffer-group-name
- buffer))
- buffers)))))
+ (groups (delq nil
+ (mapcar #'car
+ (seq-group-by #'tab-line-tabs-buffer-group-name
+ buffers))))
+ (sorted-groups (if (functionp tab-line-tabs-buffer-groups-sort-function)
+ (seq-sort tab-line-tabs-buffer-groups-sort-function
+ groups)
+ groups))
(selected-group (window-parameter nil 'tab-line-group))
(tabs
(mapcar (lambda (group)
@@ -395,9 +406,8 @@ tab-line-tabs-buffer-groups
(set-window-parameter nil 'tab-line-groups nil)
(set-window-parameter nil 'tab-line-group group)
(set-window-parameter nil 'tab-line-hscroll nil)))))
- groups)))
- tabs)
-
+ sorted-groups)))
+ tabs)
(let* ((window-parameter (window-parameter nil 'tab-line-group))
(group-name (tab-line-tabs-buffer-group-name (current-buffer)))
(group (prog1 (or window-parameter group-name "All")
@@ -410,10 +420,9 @@ tab-line-tabs-buffer-groups
(set-window-parameter nil 'tab-line-groups t)
(set-window-parameter nil 'tab-line-group group)
(set-window-parameter nil 'tab-line-hscroll nil)))))
- (buffers
- (seq-filter (lambda (b)
- (equal (tab-line-tabs-buffer-group-name b) group))
- (funcall tab-line-tabs-buffer-list-function)))
+ (buffers (seq-filter (lambda (b)
+ (equal (tab-line-tabs-buffer-group-name b) group))
+ (funcall tab-line-tabs-buffer-list-function)))
(sorted-buffers (if (functionp tab-line-tabs-buffer-group-sort-function)
(seq-sort tab-line-tabs-buffer-group-sort-function
buffers)
--
2.34.1
--=-=-=
Content-Type: text/plain
---
Gabriel
--=-=-=--
Gabriel <gabriel376@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#59438; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.