GNU bug report logs - #59513
[PATCH] doc: contributing: Tweak the Commit Policy.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Christopher Baines <mail@HIDDEN>; Keywords: patch moreinfo; dated Wed, 23 Nov 2022 10:50:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.
Added tag(s) moreinfo. Request was from Christopher Baines <mail@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 59513 <at> debbugs.gnu.org:


Received: (at 59513) by debbugs.gnu.org; 24 Nov 2022 08:59:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Nov 24 03:59:13 2022
Received: from localhost ([127.0.0.1]:57206 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oy84e-0001pP-P9
	for submit <at> debbugs.gnu.org; Thu, 24 Nov 2022 03:59:13 -0500
Received: from mira.cbaines.net ([212.71.252.8]:41970)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1oy84b-0001pC-DM
 for 59513 <at> debbugs.gnu.org; Thu, 24 Nov 2022 03:59:10 -0500
Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699])
 by mira.cbaines.net (Postfix) with ESMTPSA id 2BD4B27BBE9;
 Thu, 24 Nov 2022 08:59:08 +0000 (GMT)
Received: from felis (localhost [127.0.0.1])
 by localhost (OpenSMTPD) with ESMTP id d63786e3;
 Thu, 24 Nov 2022 08:59:07 +0000 (UTC)
References: <20221123104946.29480-1-mail@HIDDEN>
 <86tu2pfmbv.fsf@HIDDEN>
User-agent: mu4e 1.8.11; emacs 28.2
From: Christopher Baines <mail@HIDDEN>
To: zimoun <zimon.toutoune@HIDDEN>
Subject: Re: [bug#59513] [PATCH] doc: contributing: Tweak the Commit Policy.
Date: Thu, 24 Nov 2022 08:40:59 +0000
In-reply-to: <86tu2pfmbv.fsf@HIDDEN>
Message-ID: <871qps20fa.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 59513
Cc: 59513 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable


zimoun <zimon.toutoune@HIDDEN> writes:

> Hi Chris,

Hey! Thanks for taking a look.

> On Wed, 23 Nov 2022 at 10:49, Christopher Baines <mail@HIDDEN> wrote:
>
>> +For a minority of changes, it can be appropriate to push them directly
>> +without sending them for review.  This includes both trivial changes
>> +(e.g. fixing typos) but also reverting problomatic changes and
>                                               -^
>> +addressing regressions.
>
>
>> -For patches that just add a new package, and a simple one, it's OK to
>> -commit, if you're confident (which means you successfully built it in a
>> -chroot setup, and have done a reasonable copyright and license
>> -auditing).  Likewise for package upgrades, except upgrades that trigger
>> -a lot of rebuilds (for example, upgrading GnuTLS or GLib).  We have a
>> -mailing list for commit notifications (@email{guix-commits@@gnu.org}),
>> -so people can notice.  Before pushing your changes, make sure to run
>> -@code{git pull --rebase}.
>> +In general though, all changes should be posted to
>> +@email{guix-patches@@gnu.org}.  This mailing list fills the
>> +patch-tracking database (@pxref{Tracking Bugs and Patches}).  Leave time
>> +for a review, without committing anything (@pxref{Submitting Patches}).
>> +If you didn=E2=80=99t receive any reply after one week (two weeks for m=
ore
>> +significant changes), and if you're confident, it's OK to commit.
>
> I would write:
>
>         =E2=80=A6 changes), and if you're confident (which means you
>         successfully built it in a chroot setup, and have done a
>         reasonable copyright and license auditing), it=E2=80=99s OK to co=
mmit.

chroot setup doesn't really make sense to me, I'm not sure why that
needs specifying (like do we not want things for the Hurd pushing, since
the guix-daemon doesn't support build isolation there yet)?

Also, this guidance is very general, and I think it should be applicable
to all changes. We already trust people with commit access to know what
needs doing, I see this documentation as more about how, so I'd prefer
not to try and put a list here.

> and I would keep the =C2=ABtwo weeks=C2=BB instead of the =C2=ABone week =
except=C2=BB.

My reason for changing this is that I think waiting two weeks after
sending a simple patch is unreasonable. The value from the automated
testing will come after one to two days, I just put a week to avoid
changing it too much, but maybe the lower bound should be two days.

> I think it is also useful to provide the information about commit
> notifications (guix-commits mailing list).

Why though? What do we expect people with commit access to do when they
read about that here?

> For what it is worth, I find clearer the structure,
>
>     For patches that =E2=80=A6
>     For anything else, =E2=80=A6
>
> or
>
>     For a minority of changes, =E2=80=A6
>     For anything else, =E2=80=A6
>
> than =C2=ABIn general though, all changes =E2=80=A6=C2=BB.

That seems fine to me, I think "everything" maybe carries more weight
than "anything" though.

Thanks,

Chris

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmN/MllfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9Xco1BAAo8cViaAHyIRxSikHFBnTcOshRBK0350y
zwERyqUBZM7mibm4LLt2uxTpKSXFR38L0qzjHnsNNLj387pkvvRdYgp9JblkB0mX
Zw+6w9dinAMW/0YTnmkQJ/ecQqFBoYLRPw2k+qNavUg6r1AvuhGE9fej+pndItYO
XZUqtRyUBBOa1sShBIiqJEeWP1EWczrRBvkrDNoDinoALk/QE5dKW/jkpvxAm3dB
zugux7V8ihbaoOapaOJSLUnqApRzFAG+/6PBnYpqvw70TTkh+MdyUcH9RjdhV9aB
E65CvRiFKXZnVVf6Ej9y2+UO+bk3whBTrul0Df53bFwdSFSuw69X2H3p0F5NVpWx
NDf/8lJFid95P+JVW68HJrNOe2bM/aD9lxVjIE1arBsJ7LVvzf3WLshkM5P0x45E
fVqGxdHpnFdDGLh/C9cWF3HUtWbyoOhXeQRDULeXk1w6UVImFiING/LqGB0twHM+
tAQaE8Mk91KGNd0q3zKRGiL5pfLi3sNtz5YDQA9nXDEU4I1FPRa6s5Ewv+x/ZO5a
bB0uprax640DN35K0vRkM0VtxdM2p9YpKrxgQfhbU5IdAjjLnrkjTJUvRaAUsyVA
ggbWJRhjMzaVye1p7yv7WejisKThw1bz54syVejSh/6Kv53GvjPWFzk3En7r56Sx
JfNH6nVDTOE=
=JvxO
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#59513; Package guix-patches. Full text available.

Message received at 59513 <at> debbugs.gnu.org:


Received: (at 59513) by debbugs.gnu.org; 23 Nov 2022 20:50:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 23 15:50:20 2022
Received: from localhost ([127.0.0.1]:56393 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oxwhI-0007i4-Ay
	for submit <at> debbugs.gnu.org; Wed, 23 Nov 2022 15:50:20 -0500
Received: from mail-wr1-f41.google.com ([209.85.221.41]:35820)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zimon.toutoune@HIDDEN>) id 1oxwhG-0007hb-Oo
 for 59513 <at> debbugs.gnu.org; Wed, 23 Nov 2022 15:50:19 -0500
Received: by mail-wr1-f41.google.com with SMTP id b12so17425555wrn.2
 for <59513 <at> debbugs.gnu.org>; Wed, 23 Nov 2022 12:50:18 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=content-transfer-encoding:mime-version:message-id:date:references
 :in-reply-to:subject:to:from:from:to:cc:subject:date:message-id
 :reply-to; bh=xCpft4Ls2PLce4Uj4sX8CWsd4QRXdWwp7D6lAwo8UTo=;
 b=NexWQECiOrllr0DK9GUCsBuWcvKFVwe6GEYdrCnbvkRsz+M1w5GR3ztsEUuzzDEY5+
 hS7eed4oUghZ7MEGPtavl7VbEZvTW5tURXU6bCBlF1ILL4rDsfJ5PZtiMz0QmWLeUrTp
 Y5HbEO+whiX9fn0TisVMXNr8lY2peOnu0BQJihlVM+b2EoaEat/Bh8rM/7XeV9HTHmUf
 2WM0OIpH4ZYBJGuRDX7SZF/0rro1aG5GjS1qpesXckmh+uZn8TFLjVrQw7dK938yE5OR
 r0Y0SPMGCTNcG5BIRlIk9KuUUVcl6/6filT6fJ9/1pxBEPXWWvFuhY9uKj3Yb3P3NDAv
 IN8A==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=content-transfer-encoding:mime-version:message-id:date:references
 :in-reply-to:subject:to:from:x-gm-message-state:from:to:cc:subject
 :date:message-id:reply-to;
 bh=xCpft4Ls2PLce4Uj4sX8CWsd4QRXdWwp7D6lAwo8UTo=;
 b=KZk1oOUzh0d//Sz2px2PmscDu9E0LRzvCR0fbIFLuGVJxkO3KsisAdaiIgQ1n7TItk
 YVCNHpjh0hDVqBngbnpRRUHMHv2XTdTfiXjIF6RVGLho5Uv47ql7Ubjzp6tROSnDTHVA
 sMegvVFOmhRvv51tHky7iSN8q/IroYQRanJqcAebPI39F0S/PbMVa3Qrij+5qMAGIR/d
 mk00AHv+seq4DouraG/caeDTRzB3NKqYU+6Xie4cJ3JFyp2qVzy8Fj2HLCcUUOC3xPST
 YGoyupvqWpFg+XvPvGAwUzJnX8dW1T22wPyZZEF+mVNKyz0SgOwnK0hKi9tlIsfQF7Xu
 tuGQ==
X-Gm-Message-State: ANoB5plU5jz77hyxz0rkddPz/nwvPF/wNy16Cgs5oPb+cBgn4yOrZY5n
 ZjnBvl8EX6iVJsATYLMkf0HFTFpevmE=
X-Google-Smtp-Source: AA0mqf4x2jWIZ23dAEdQuVFazOj1wseFwA8gUmSKKCFy/61Kcu6xfsAqBP7TIJ4lgyGyU6Pz8YWM4A==
X-Received: by 2002:adf:a181:0:b0:241:bd28:f985 with SMTP id
 u1-20020adfa181000000b00241bd28f985mr16307441wru.686.1669236612917; 
 Wed, 23 Nov 2022 12:50:12 -0800 (PST)
Received: from lili ([2a01:e0a:59b:9120:65d2:2476:f637:db1e])
 by smtp.gmail.com with ESMTPSA id
 i19-20020a1c5413000000b003cfc02ab8basm3768975wmb.33.2022.11.23.12.50.12
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Wed, 23 Nov 2022 12:50:12 -0800 (PST)
From: zimoun <zimon.toutoune@HIDDEN>
To: Christopher Baines <mail@HIDDEN>, 59513 <at> debbugs.gnu.org
Subject: Re: [bug#59513] [PATCH] doc: contributing: Tweak the Commit Policy.
In-Reply-To: <20221123104946.29480-1-mail@HIDDEN>
References: <20221123104946.29480-1-mail@HIDDEN>
Date: Wed, 23 Nov 2022 21:27:32 +0100
Message-ID: <86tu2pfmbv.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 59513
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Hi Chris,

On Wed, 23 Nov 2022 at 10:49, Christopher Baines <mail@HIDDEN> wrote:

> +For a minority of changes, it can be appropriate to push them directly
> +without sending them for review.  This includes both trivial changes
> +(e.g. fixing typos) but also reverting problomatic changes and
                                              -^
> +addressing regressions.


> -For patches that just add a new package, and a simple one, it's OK to
> -commit, if you're confident (which means you successfully built it in a
> -chroot setup, and have done a reasonable copyright and license
> -auditing).  Likewise for package upgrades, except upgrades that trigger
> -a lot of rebuilds (for example, upgrading GnuTLS or GLib).  We have a
> -mailing list for commit notifications (@email{guix-commits@@gnu.org}),
> -so people can notice.  Before pushing your changes, make sure to run
> -@code{git pull --rebase}.
> +In general though, all changes should be posted to
> +@email{guix-patches@@gnu.org}.  This mailing list fills the
> +patch-tracking database (@pxref{Tracking Bugs and Patches}).  Leave time
> +for a review, without committing anything (@pxref{Submitting Patches}).
> +If you didn=E2=80=99t receive any reply after one week (two weeks for mo=
re
> +significant changes), and if you're confident, it's OK to commit.

I would write:

        =E2=80=A6 changes), and if you're confident (which means you
        successfully built it in a chroot setup, and have done a
        reasonable copyright and license auditing), it=E2=80=99s OK to comm=
it.

and I would keep the =C2=ABtwo weeks=C2=BB instead of the =C2=ABone week ex=
cept=C2=BB.

I think it is also useful to provide the information about commit
notifications (guix-commits mailing list).

For what it is worth, I find clearer the structure,

    For patches that =E2=80=A6
    For anything else, =E2=80=A6

or

    For a minority of changes, =E2=80=A6
    For anything else, =E2=80=A6

than =C2=ABIn general though, all changes =E2=80=A6=C2=BB.

Cheers,
simon




Information forwarded to guix-patches@HIDDEN:
bug#59513; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 23 Nov 2022 10:49:52 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Nov 23 05:49:52 2022
Received: from localhost ([127.0.0.1]:53815 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oxnKB-0007Ge-Og
	for submit <at> debbugs.gnu.org; Wed, 23 Nov 2022 05:49:52 -0500
Received: from lists.gnu.org ([209.51.188.17]:33296)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1oxnKA-0007GS-Nk
 for submit <at> debbugs.gnu.org; Wed, 23 Nov 2022 05:49:51 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <mail@HIDDEN>) id 1oxnKA-0001uw-8R
 for guix-patches@HIDDEN; Wed, 23 Nov 2022 05:49:50 -0500
Received: from mira.cbaines.net ([212.71.252.8])
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <mail@HIDDEN>) id 1oxnK8-0003Qi-C0
 for guix-patches@HIDDEN; Wed, 23 Nov 2022 05:49:50 -0500
Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699])
 by mira.cbaines.net (Postfix) with ESMTPSA id 4266227BBE9
 for <guix-patches@HIDDEN>; Wed, 23 Nov 2022 10:49:47 +0000 (GMT)
Received: from localhost (localhost [local])
 by localhost (OpenSMTPD) with ESMTPA id 4ddf9277
 for <guix-patches@HIDDEN>; Wed, 23 Nov 2022 10:49:47 +0000 (UTC)
From: Christopher Baines <mail@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] doc: contributing: Tweak the Commit Policy.
Date: Wed, 23 Nov 2022 10:49:46 +0000
Message-Id: <20221123104946.29480-1-mail@HIDDEN>
X-Mailer: git-send-email 2.38.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@HIDDEN;
 helo=mira.cbaines.net
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

Add more examples of when it can be appropriate to push changes without
review, as I think this can be appropriate in the case of trivial changes (as
mentioned before), but also non-trivial fixes.

No longer suggest pushing simple new packages or package upgrades (that don't
cause lots of rebuilds) without sending to guix-patches. Now there's some
automation for testing changes sent to guix-patches, sending changes there
before pushing can mean that more rigerious testing takes place and help speed
up substitutes becoming available. This is true, even if no human review takes
place.

Only suggest waiting one week for review for simpler changes, wait two weeks
for more significant changes.

Also, reorder some of the information in this section so it's grouped together
better.

* doc/contributing.texi (Commit Policy): Tweak.
---
 doc/contributing.texi | 38 ++++++++++++++++----------------------
 1 file changed, 16 insertions(+), 22 deletions(-)

diff --git a/doc/contributing.texi b/doc/contributing.texi
index 40ae33ecac..6f772961ea 100644
--- a/doc/contributing.texi
+++ b/doc/contributing.texi
@@ -1819,23 +1819,25 @@ It additionally calls @code{make check-channel-news} to be sure
 
 @subsection Commit Policy
 
-If you get commit access, please make sure to follow
-the policy below (discussions of the policy can take place on
+If you get commit access, please make sure to follow the policy below
+(discussions of the policy can take place on
 @email{guix-devel@@gnu.org}).
 
-Non-trivial patches should always be posted to
-@email{guix-patches@@gnu.org} (trivial patches include fixing typos,
-etc.).  This mailing list fills the patch-tracking database
-(@pxref{Tracking Bugs and Patches}).
+For a minority of changes, it can be appropriate to push them directly
+without sending them for review.  This includes both trivial changes
+(e.g. fixing typos) but also reverting problomatic changes and
+addressing regressions.
 
-For patches that just add a new package, and a simple one, it's OK to
-commit, if you're confident (which means you successfully built it in a
-chroot setup, and have done a reasonable copyright and license
-auditing).  Likewise for package upgrades, except upgrades that trigger
-a lot of rebuilds (for example, upgrading GnuTLS or GLib).  We have a
-mailing list for commit notifications (@email{guix-commits@@gnu.org}),
-so people can notice.  Before pushing your changes, make sure to run
-@code{git pull --rebase}.
+In general though, all changes should be posted to
+@email{guix-patches@@gnu.org}.  This mailing list fills the
+patch-tracking database (@pxref{Tracking Bugs and Patches}).  Leave time
+for a review, without committing anything (@pxref{Submitting Patches}).
+If you didn’t receive any reply after one week (two weeks for more
+significant changes), and if you're confident, it's OK to commit.
+
+That last part is subject to being adjusted, allowing individuals to
+commit directly on non-controversial changes on parts they’re familiar
+with.
 
 When pushing a commit on behalf of somebody else, please add a
 @code{Signed-off-by} line at the end of the commit log message---e.g.,
@@ -1850,14 +1852,6 @@ right before pushing:
 make check-channel-news
 @end example
 
-For anything else, please post to @email{guix-patches@@gnu.org} and
-leave time for a review, without committing anything (@pxref{Submitting
-Patches}).  If you didn’t receive any reply after two weeks, and if
-you're confident, it's OK to commit.
-
-That last part is subject to being adjusted, allowing individuals to commit
-directly on non-controversial changes on parts they’re familiar with.
-
 @subsection Addressing Issues
 
 Peer review (@pxref{Submitting Patches}) and tools such as
-- 
2.38.1





Acknowledgement sent to Christopher Baines <mail@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#59513; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Thu, 24 Nov 2022 09:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.