GNU bug report logs -
#5953
23.1.95; objc-mode doesn't fontify Objective-C 2.0 keywords @syntesize and @property correctly
Previous Next
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 5953 in the body.
You can then email your comments to 5953 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
owner <at> debbugs.gnu.org, bug-gnu-emacs <at> gnu.org
:
bug#5953
; Package
emacs
.
(Thu, 15 Apr 2010 15:23:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Aleksandr Skobelev <al.skobelev <at> gmail.com>
:
New bug report received and forwarded. Copy sent to
bug-gnu-emacs <at> gnu.org
.
(Thu, 15 Apr 2010 15:23:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
objc-mode doesn't know anything about the new Objective-C 2.0
keywords like @property and @syntesize, for example.
bug reassigned from package 'emacs' to 'emacs,cc-mode'.
Request was from
Glenn Morris <rgm <at> gnu.org>
to
control <at> debbugs.gnu.org
.
(Thu, 15 Apr 2010 18:30:05 GMT)
Full text and
rfc822 format available.
Severity set to 'wishlist' from 'normal'
Request was from
Glenn Morris <rgm <at> gnu.org>
to
control <at> debbugs.gnu.org
.
(Thu, 15 Apr 2010 18:30:05 GMT)
Full text and
rfc822 format available.
Information forwarded
to
bug-gnu-emacs <at> gnu.org, bug-cc-mode <at> gnu.org
:
bug#5953
; Package
emacs,cc-mode
.
(Wed, 22 Aug 2012 03:34:02 GMT)
Full text and
rfc822 format available.
Message #12 received at 5953 <at> debbugs.gnu.org (full text, mbox):
On 2010-04-15 23:00 +0800, Aleksandr Skobelev wrote:
> objc-mode doesn't know anything about the new Objective-C 2.0
> keywords like @property and @syntesize, for example.
Here is a list of OjbC2.0 directives with annotations:
http://maniacdev.com/cheatsheetobjccd.pdf
Leo
Information forwarded
to
bug-gnu-emacs <at> gnu.org, bug-cc-mode <at> gnu.org
:
bug#5953
; Package
emacs,cc-mode
.
(Wed, 22 Aug 2012 09:41:02 GMT)
Full text and
rfc822 format available.
Message #15 received at 5953 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
On 2012-08-22 11:32 +0800, Leo wrote:
> Here is a list of OjbC2.0 directives with annotations:
>
> http://maniacdev.com/cheatsheetobjccd.pdf
>
> Leo
I have compiled a patch to improve support for Objective C.
I am not sure where to add the following keywords so they live in
c-other-decl-kwds for now. Please review the patch. Thanks.
1. @property
: @property (attributes) Type propertyName;
2. @dynamic
: @dynamic aProperty, bProperty;
3. @synthesize
: @synthesize aProperty, bProperty, cProperty=_ivar;
4. @compatibility_alias
: @compatibility_alias AliasClassName ExistingClassName;
[0001-Add-ObjC-2.0-directives-support.patch (text/x-patch, inline)]
From 3ea4329978ebe2e5cb9d4bfd1e544277cf8e0352 Mon Sep 17 00:00:00 2001
From: Leo Liu <sdl.web <at> gmail.com>
Date: Wed, 22 Aug 2012 16:54:18 +0800
Subject: [PATCH] Add ObjC 2.0 directives support
---
lisp/progmodes/cc-langs.el | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/lisp/progmodes/cc-langs.el b/lisp/progmodes/cc-langs.el
index 78be8ac2..4aed2048 100644
--- a/lisp/progmodes/cc-langs.el
+++ b/lisp/progmodes/cc-langs.el
@@ -1884,7 +1884,8 @@ (c-lang-defconst c-other-decl-kwds
`c-<>-type-kwds', or `c-<>-arglist-kwds' then the associated clauses
will be handled."
t nil
- objc '("@class" "@end" "@defs")
+ objc '("@class" "@defs" "@end" "@property" "@dynamic" "@synthesize"
+ "@compatibility_alias")
java '("import" "package")
pike '("import" "inherit"))
@@ -2006,7 +2007,8 @@ (c-lang-defconst c-protection-kwds
"Access protection label keywords in classes."
t nil
c++ '("private" "protected" "public")
- objc '("@private" "@protected" "@public"))
+ objc '("@private" "@protected" "@package" "@public"
+ "@required" "@optional"))
(c-lang-defconst c-block-decls-with-vars
"Keywords introducing declarations that can contain a block which
@@ -2176,7 +2178,7 @@ (c-lang-defconst c-block-stmt-1-kwds
"Statement keywords followed directly by a substatement."
t '("do" "else")
c++ '("do" "else" "try")
- objc '("do" "else" "@finally" "@try")
+ objc '("do" "else" "@finally" "@try" "@autoreleasepool")
java '("do" "else" "finally" "try")
idl nil)
@@ -2292,7 +2294,8 @@ (c-lang-defconst c-constant-kwds
t nil
(c c++) '("NULL" ;; Not a keyword, but practically works as one.
"false" "true") ; Defined in C99.
- objc '("nil" "Nil" "YES" "NO" "NS_DURING" "NS_HANDLER" "NS_ENDHANDLER")
+ objc '("nil" "Nil" "YES" "NO" "IBAction" "IBOutlet"
+ "NS_DURING" "NS_HANDLER" "NS_ENDHANDLER")
idl '("TRUE" "FALSE")
java '("true" "false" "null") ; technically "literals", not keywords
pike '("UNDEFINED")) ;; Not a keyword, but practically works as one.
--
1.7.12
Forcibly Merged 5953 25066.
Request was from
Glenn Morris <rgm <at> gnu.org>
to
control <at> debbugs.gnu.org
.
(Wed, 30 Nov 2016 02:23:01 GMT)
Full text and
rfc822 format available.
Added tag(s) patch.
Request was from
Lars Ingebrigtsen <larsi <at> gnus.org>
to
control <at> debbugs.gnu.org
.
(Fri, 01 Nov 2019 16:11:02 GMT)
Full text and
rfc822 format available.
Information forwarded
to
bug-gnu-emacs <at> gnu.org, bug-cc-mode <at> gnu.org
:
bug#5953
; Package
emacs,cc-mode
.
(Fri, 01 Nov 2019 16:13:01 GMT)
Full text and
rfc822 format available.
Message #22 received at 5953 <at> debbugs.gnu.org (full text, mbox):
Leo <sdl.web <at> gmail.com> writes:
> On 2012-08-22 11:32 +0800, Leo wrote:
>> Here is a list of OjbC2.0 directives with annotations:
>>
>> http://maniacdev.com/cheatsheetobjccd.pdf
>>
>> Leo
>
> I have compiled a patch to improve support for Objective C.
>
> I am not sure where to add the following keywords so they live in
> c-other-decl-kwds for now. Please review the patch. Thanks.
>
> 1. @property
> : @property (attributes) Type propertyName;
> 2. @dynamic
> : @dynamic aProperty, bProperty;
> 3. @synthesize
> : @synthesize aProperty, bProperty, cProperty=_ivar;
> 4. @compatibility_alias
> : @compatibility_alias AliasClassName ExistingClassName;
[...]
> - objc '("@class" "@end" "@defs")
> + objc '("@class" "@defs" "@end" "@property" "@dynamic" "@synthesize"
> + "@compatibility_alias")
(etc)
It seems like this patch (from seven years ago) was never applied. I
know nothing about Objective C, though. Alan, could you have a look at
this?
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
Information forwarded
to
bug-gnu-emacs <at> gnu.org, bug-cc-mode <at> gnu.org
:
bug#5953
; Package
emacs,cc-mode
.
(Sat, 23 Nov 2019 13:16:03 GMT)
Full text and
rfc822 format available.
Message #25 received at 5953 <at> debbugs.gnu.org (full text, mbox):
Lars Ingebrigtsen <larsi <at> gnus.org> writes:
> It seems like this patch (from seven years ago) was never applied. I
> know nothing about Objective C, though. Alan, could you have a look at
> this?
Alan, did you find time to look at this patch? It looks fairly
straightforward to me, but my knowledge of Objective C is very
rudimentary.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
Information forwarded
to
bug-gnu-emacs <at> gnu.org, bug-cc-mode <at> gnu.org
:
bug#5953
; Package
emacs,cc-mode
.
(Mon, 04 May 2020 00:55:02 GMT)
Full text and
rfc822 format available.
Message #28 received at 5953 <at> debbugs.gnu.org (full text, mbox):
Lars Ingebrigtsen <larsi <at> gnus.org> writes:
> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
>
>> It seems like this patch (from seven years ago) was never applied. I
>> know nothing about Objective C, though. Alan, could you have a look at
>> this?
>
> Alan, did you find time to look at this patch? It looks fairly
> straightforward to me, but my knowledge of Objective C is very
> rudimentary.
That was 23 weeks ago. Alan, did you find any time to look at this
patch? Thanks in advance.
Best regards,
Stefan Kangas
Information forwarded
to
bug-gnu-emacs <at> gnu.org, bug-cc-mode <at> gnu.org
:
bug#5953
; Package
emacs,cc-mode
.
(Sun, 24 May 2020 19:25:02 GMT)
Full text and
rfc822 format available.
Message #31 received at 5953 <at> debbugs.gnu.org (full text, mbox):
Hello, Stefan.
Sorry for the long delay in answering.
On Mon, May 04, 2020 at 02:53:59 +0200, Stefan Kangas wrote:
> Lars Ingebrigtsen <larsi <at> gnus.org> writes:
> > Lars Ingebrigtsen <larsi <at> gnus.org> writes:
> >> It seems like this patch (from seven years ago) was never applied. I
> >> know nothing about Objective C, though. Alan, could you have a look at
> >> this?
> > Alan, did you find time to look at this patch? It looks fairly
> > straightforward to me, but my knowledge of Objective C is very
> > rudimentary.
> That was 23 weeks ago. Alan, did you find any time to look at this
> patch? Thanks in advance.
I've been trying to come to some sort of conclusion on this for quite a
long time now.
Somehow, adding nine keywords together with their semantics seems to go
outside the bounds of "trivial" for copyright purposes, even if they do
fit into the arbitrary maximum number of lines. Kudos to Martin
Stjernholm, my predecessor, who made such compact amendments possible.
I don't know if Leo Liu, the author of the patch, has signed copyright
papers, but I strongly suspect not.
As I say, I don't know what to do with this patch.
> Best regards,
> Stefan Kangas
--
Alan Mackenzie (Nuremberg, Germany).
Information forwarded
to
bug-gnu-emacs <at> gnu.org, bug-cc-mode <at> gnu.org
:
bug#5953
; Package
emacs,cc-mode
.
(Sun, 24 May 2020 19:41:02 GMT)
Full text and
rfc822 format available.
Message #34 received at 5953 <at> debbugs.gnu.org (full text, mbox):
On 24.05.2020 22:24, Alan Mackenzie wrote:
> I don't know if Leo Liu, the author of the patch, has signed copyright
> papers, but I strongly suspect not.
He has, quite a few years ago.
Also see: git log --author "Leo Liu"
Information forwarded
to
bug-gnu-emacs <at> gnu.org, bug-cc-mode <at> gnu.org
:
bug#5953
; Package
emacs,cc-mode
.
(Mon, 25 May 2020 04:35:01 GMT)
Full text and
rfc822 format available.
Message #37 received at 5953 <at> debbugs.gnu.org (full text, mbox):
[[[ To any NSA and FBI agents reading my email: please consider ]]]
[[[ whether defending the US Constitution against all enemies, ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]
> Somehow, adding nine keywords together with their semantics seems to go
> outside the bounds of "trivial" for copyright purposes, even if they do
> fit into the arbitrary maximum number of lines.
Would you like to show me the patch? That description suggests that
maybe it is trivial.
--
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)
Information forwarded
to
bug-gnu-emacs <at> gnu.org, bug-cc-mode <at> gnu.org
:
bug#5953
; Package
emacs,cc-mode
.
(Mon, 25 May 2020 04:53:02 GMT)
Full text and
rfc822 format available.
Message #40 received at 5953 <at> debbugs.gnu.org (full text, mbox):
On Mon, 2020-05-25 at 00:34 -0400, Richard Stallman wrote:
> [[[ To any NSA and FBI agents reading my email: please consider ]]]
> [[[ whether defending the US Constitution against all enemies, ]]]
> [[[ foreign or domestic, requires you to follow Snowden's example. ]]]
>
> > Somehow, adding nine keywords together with their semantics seems to go
> > outside the bounds of "trivial" for copyright purposes, even if they do
> > fit into the arbitrary maximum number of lines.
>
> Would you like to show me the patch? That description suggests that
> maybe it is trivial.
It's unfortunate that the SourceForge mailing list archives are so
gross. FYI, this is a link to the email from 2012 with the patch
attached:
https://sourceforge.net/p/cc-mode/mailman/message/29722632/
This is a link to download the patch:
https://sourceforge.net/p/cc-mode/mailman/attachment/m2sjbfi7tl.fsf%40gmail.com/1/
I've included the patch itself below if you prefer that instead of the
above links.
Cheers!
--------------------------------
>From 3ea4329978ebe2e5cb9d4bfd1e544277cf8e0352 Mon Sep 17 00:00:00 2001
From: Leo Liu <sdl.web <at> gmail.com>
Date: Wed, 22 Aug 2012 16:54:18 +0800
Subject: [PATCH] Add ObjC 2.0 directives support
---
lisp/progmodes/cc-langs.el | 11 +++++++----
1 file changed, 7 insertions(+), 4 deletions(-)
diff --git a/lisp/progmodes/cc-langs.el b/lisp/progmodes/cc-langs.el
index 78be8ac2..4aed2048 100644
--- a/lisp/progmodes/cc-langs.el
+++ b/lisp/progmodes/cc-langs.el
@@ -1884,7 +1884,8 @@ (c-lang-defconst c-other-decl-kwds
`c-<>-type-kwds', or `c-<>-arglist-kwds' then the associated clauses
will be handled."
t nil
- objc '("@class" "@end" "@defs")
+ objc '("@class" "@defs" "@end" "@property" "@dynamic" "@synthesize"
+ "@compatibility_alias")
java '("import" "package")
pike '("import" "inherit"))
@@ -2006,7 +2007,8 @@ (c-lang-defconst c-protection-kwds
"Access protection label keywords in classes."
t nil
c++ '("private" "protected" "public")
- objc '("@private" "@protected" "@public"))
+ objc '("@private" "@protected" "@package" "@public"
+ "@required" "@optional"))
(c-lang-defconst c-block-decls-with-vars
"Keywords introducing declarations that can contain a block which
@@ -2176,7 +2178,7 @@ (c-lang-defconst c-block-stmt-1-kwds
"Statement keywords followed directly by a substatement."
t '("do" "else")
c++ '("do" "else" "try")
- objc '("do" "else" "@finally" "@try")
+ objc '("do" "else" "@finally" "@try" "@autoreleasepool")
java '("do" "else" "finally" "try")
idl nil)
@@ -2292,7 +2294,8 @@ (c-lang-defconst c-constant-kwds
t nil
(c c++) '("NULL" ;; Not a keyword, but practically works as one.
"false" "true") ; Defined in C99.
- objc '("nil" "Nil" "YES" "NO" "NS_DURING" "NS_HANDLER" "NS_ENDHANDLER")
+ objc '("nil" "Nil" "YES" "NO" "IBAction" "IBOutlet"
+ "NS_DURING" "NS_HANDLER" "NS_ENDHANDLER")
idl '("TRUE" "FALSE")
java '("true" "false" "null") ; technically "literals", not keywords
pike '("UNDEFINED")) ;; Not a keyword, but practically works as one.
--
1.7.12
Information forwarded
to
bug-gnu-emacs <at> gnu.org, bug-cc-mode <at> gnu.org
:
bug#5953
; Package
emacs,cc-mode
.
(Tue, 26 May 2020 04:12:01 GMT)
Full text and
rfc822 format available.
Message #43 received at 5953 <at> debbugs.gnu.org (full text, mbox):
[[[ To any NSA and FBI agents reading my email: please consider ]]]
[[[ whether defending the US Constitution against all enemies, ]]]
[[[ foreign or domestic, requires you to follow Snowden's example. ]]]
This patch is trivial. Only 7 lines are changed, and the change
is directly controlled by the job to be done, so it has no
creativing.
IANAL, but as I understand US copyright law, there is nothing
copyrightable in this change.
So you can just install it.
--
Dr Richard Stallman
Chief GNUisance of the GNU Project (https://gnu.org)
Founder, Free Software Foundation (https://fsf.org)
Internet Hall-of-Famer (https://internethalloffame.org)
Information forwarded
to
bug-gnu-emacs <at> gnu.org, bug-cc-mode <at> gnu.org
:
bug#5953
; Package
emacs,cc-mode
.
(Tue, 26 May 2020 10:24:02 GMT)
Full text and
rfc822 format available.
Message #46 received at 5953 <at> debbugs.gnu.org (full text, mbox):
On 26.05.2020 07:11, Richard Stallman wrote:
> This patch is trivial. Only 7 lines are changed, and the change
> is directly controlled by the job to be done, so it has no
> creativing.
>
> IANAL, but as I understand US copyright law, there is nothing
> copyrightable in this change.
*And* the author has signed the copyright assignment papers long ago.
Good note about copyrightability, though.
Information forwarded
to
bug-gnu-emacs <at> gnu.org, bug-cc-mode <at> gnu.org
:
bug#5953
; Package
emacs,cc-mode
.
(Tue, 26 May 2020 18:32:01 GMT)
Full text and
rfc822 format available.
Message #49 received at 5953 <at> debbugs.gnu.org (full text, mbox):
Hello, Richard and Dmitry.
On Tue, May 26, 2020 at 13:23:36 +0300, Dmitry Gutov wrote:
> On 26.05.2020 07:11, Richard Stallman wrote:
> > This patch is trivial. Only 7 lines are changed, and the change
> > is directly controlled by the job to be done, so it has no
> > creativing.
OK, thanks for that.
> > IANAL, but as I understand US copyright law, there is nothing
> > copyrightable in this change.
That is good to know.
> *And* the author has signed the copyright assignment papers long ago.
That is also very good to know.
> Good note about copyrightability, though.
And if you're still around, Leo, thanks very much for the patch! I'll
commit it in the next day or so.
--
Alan Mackenzie (Nuremberg, Germany).
Information forwarded
to
bug-gnu-emacs <at> gnu.org, bug-cc-mode <at> gnu.org
:
bug#5953
; Package
emacs,cc-mode
.
(Tue, 26 May 2020 20:04:02 GMT)
Full text and
rfc822 format available.
Message #52 received at 5953 <at> debbugs.gnu.org (full text, mbox):
On Tue, 2020-05-26 at 18:31 +0000, Alan Mackenzie wrote:
> > *And* the author has signed the copyright assignment papers long
> > ago.
>
> That is also very good to know.
Curious as to how to find out this information?
I checked the copyright list available in /gd/gnuorg and did not see
any entry for "Leo Liu". There were plenty of other names containing
"Liu" (and some "Leo"'s) but I have no idea how to tell if one of them
is this same person.
Reply sent
to
Alan Mackenzie <acm <at> muc.de>
:
You have taken responsibility.
(Tue, 26 May 2020 20:22:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
Aleksandr Skobelev <al.skobelev <at> gmail.com>
:
bug acknowledged by developer.
(Tue, 26 May 2020 20:22:02 GMT)
Full text and
rfc822 format available.
Message #57 received at 5953-done <at> debbugs.gnu.org (full text, mbox):
Hello, all.
On Tue, May 26, 2020 at 18:31:05 +0000, Alan Mackenzie wrote:
> On Tue, May 26, 2020 at 13:23:36 +0300, Dmitry Gutov wrote:
> > On 26.05.2020 07:11, Richard Stallman wrote:
> > > This patch is trivial. Only 7 lines are changed, and the change
> > > is directly controlled by the job to be done, so it has no
> > > creativing.
> OK, thanks for that.
> > > IANAL, but as I understand US copyright law, there is nothing
> > > copyrightable in this change.
> That is good to know.
> > *And* the author has signed the copyright assignment papers long ago.
> That is also very good to know.
> > Good note about copyrightability, though.
> And if you're still around, Leo, thanks very much for the patch! I'll
> commit it in the next day or so.
I've committed the patch, and with this post, I'm closing the bug. Many
thanks to everybody who's been so patient.
> --
> Alan Mackenzie (Nuremberg, Germany).
Reply sent
to
Alan Mackenzie <acm <at> muc.de>
:
You have taken responsibility.
(Tue, 26 May 2020 20:22:02 GMT)
Full text and
rfc822 format available.
Notification sent
to
Yuriy Pitometsu <pitometsu <at> gmail.com>
:
bug acknowledged by developer.
(Tue, 26 May 2020 20:22:02 GMT)
Full text and
rfc822 format available.
Information forwarded
to
bug-gnu-emacs <at> gnu.org, bug-cc-mode <at> gnu.org
:
bug#5953
; Package
emacs,cc-mode
.
(Tue, 26 May 2020 20:24:01 GMT)
Full text and
rfc822 format available.
Message #65 received at 5953 <at> debbugs.gnu.org (full text, mbox):
On 26.05.2020 23:03, Paul Smith wrote:
> I checked the copyright list available in /gd/gnuorg and did not see
> any entry for "Leo Liu". There were plenty of other names containing
> "Liu" (and some "Leo"'s) but I have no idea how to tell if one of them
> is this same person.
Search the file for his email (specifically: the part before @). The
name written in the file is a bit different.
Information forwarded
to
bug-gnu-emacs <at> gnu.org, bug-cc-mode <at> gnu.org
:
bug#5953
; Package
emacs,cc-mode
.
(Wed, 27 May 2020 01:13:02 GMT)
Full text and
rfc822 format available.
Message #68 received at 5953 <at> debbugs.gnu.org (full text, mbox):
On 2020-05-26 18:31 +0000, Alan Mackenzie wrote:
>> Good note about copyrightability, though.
>
> And if you're still around, Leo, thanks very much for the patch! I'll
> commit it in the next day or so.
Yes. Thanks everyone to get this closed. I am still around and read the
emacs bug and devel mailing lists at lease once a week ;)
Leo
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Wed, 24 Jun 2020 11:24:04 GMT)
Full text and
rfc822 format available.
This bug report was last modified 3 years and 300 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.