X-Loop: help-debbugs@HIDDEN
Subject: [bug#59552] [PATCH] gnu: Add emacs-wakatime-mode.
Resent-From: Hilton Chain <hako@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Fri, 25 Nov 2022 01:17:02 +0000
Resent-Message-ID: <handler.59552.B.166933901432752 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 59552
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 59552 <at> debbugs.gnu.org
Cc: Hilton Chain <hako@HIDDEN>
X-Debbugs-Original-To: guix-patches@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.166933901432752
(code B ref -1); Fri, 25 Nov 2022 01:17:02 +0000
Received: (at submit) by debbugs.gnu.org; 25 Nov 2022 01:16:54 +0000
Received: from localhost ([127.0.0.1]:60691 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oyNKo-0008W7-8R
for submit <at> debbugs.gnu.org; Thu, 24 Nov 2022 20:16:54 -0500
Received: from lists.gnu.org ([209.51.188.17]:41712)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <hako@HIDDEN>) id 1oyNKm-0008Vr-0l
for submit <at> debbugs.gnu.org; Thu, 24 Nov 2022 20:16:52 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <hako@HIDDEN>)
id 1oyNKl-0003F3-Rw
for guix-patches@HIDDEN; Thu, 24 Nov 2022 20:16:51 -0500
Received: from mail.boiledscript.com ([144.168.59.46])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <hako@HIDDEN>)
id 1oyNKd-0002ek-6m
for guix-patches@HIDDEN; Thu, 24 Nov 2022 20:16:51 -0500
From: Hilton Chain <hako@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space;
s=dkim; t=1669338989;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:
content-transfer-encoding:content-transfer-encoding;
bh=5zxG4JCZwavlSImYYb3kItL/0PV7xSx6TYbramIMm1A=;
b=jdOqjJrFNwtsLmR2nLK9lBcQ7vhSnszQKg5iecTO4OTDoKk47SusIkjuE7T+Dw61tTT/74
lVHSUtQTccukvgz2S+1kaBCFR4gZAjg1/IubrGa/U8BWHzhsdAwqrBvGxEJ/88vxb/1eT6
EnQkXeCv8mOpjAT/ar34n2SDlaquNOF/7/yxDRGQLXHLkJTAwPSGO+VVlx3eGt+V13Io4h
rMBr6u5P4WFVG57zlZW2Gf/iXyKWgmoJVo5OL/MgkefWMTgMbIV+0b6hPphE+Ox+gHKE2l
PwSaXGB74lNxl1a6B8OVsM5l+3hoM6iyldLXMaJkOwtxVZ8RsHTdYy+NTrrLFA==
Date: Fri, 25 Nov 2022 09:15:30 +0800
Message-Id: <20221125011530.12585-1-hako@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Level: *
X-Spamd-Bar: +
Authentication-Results: mail.boiledscript.com;
auth=pass smtp.mailfrom=hako@HIDDEN
Received-SPF: pass client-ip=144.168.59.46; envelope-from=hako@HIDDEN;
helo=mail.boiledscript.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)
* gnu/packages/emacs-xyz.scm (emacs-wakatime-mode): New variable.
---
gnu/packages/emacs-xyz.scm | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index e941064d07..a6002efa51 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -34160,6 +34160,36 @@ (define-public emacs-semi-epg
EasyPG and latest Emacs.")
(license license:gpl2+))))
+(define-public emacs-wakatime-mode
+ ;; No release since May 5, 2015.
+ (let ((version "1.0.2") ;32a0154cd4bbd525d354997e6b12c6a9726d0b43, not tagged
+ (revision "55")
+ (commit "ef923829912c3854d230834f81083814b7c9d992"))
+ (package
+ (name "emacs-wakatime-mode")
+ (version (git-version version revision commit))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/wakatime/wakatime-mode")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0m29817s2din4n42pflvzg2538i91s0n06y78pf8q94qf0mfspcl"))))
+ (build-system emacs-build-system)
+ (arguments
+ (list #:phases
+ #~(modify-phases %standard-phases
+ ;; XXX: WakaTime hasn't packaged in Guix yet.
+ (delete 'patch-el-files))))
+ (home-page "https://wakatime.com/emacs")
+ (synopsis "Automatic time tracking extension for Emacs using WakaTime")
+ (description
+ "@code{wakatime-mode} is an Emacs plugin for automatic time tracking
+and metrics generated from your programming activity.")
+ (license license:gpl3+))))
+
(define-public emacs-wanderlust
;; No release since Jan 15, 2010.
;; FIXME: Building with emacs-next-pgtk would yield a void variable related
base-commit: 5eb2995c006283fc0b649f10a6d002580ccac8d6
--
2.38.1
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Hilton Chain <hako@HIDDEN> Subject: bug#59552: Acknowledgement ([PATCH] gnu: Add emacs-wakatime-mode.) Message-ID: <handler.59552.B.166933901432752.ack <at> debbugs.gnu.org> References: <20221125011530.12585-1-hako@HIDDEN> X-Gnu-PR-Message: ack 59552 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 59552 <at> debbugs.gnu.org Date: Fri, 25 Nov 2022 01:17:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): guix-patches@HIDDEN If you wish to submit further information on this problem, please send it to 59552 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 59552: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D59552 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN
Subject: [bug#59552] [PATCH] gnu: Add emacs-wakatime-mode.
Resent-From: Nicolas Goaziou <mail@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 26 Nov 2022 10:23:02 +0000
Resent-Message-ID: <handler.59552.B.166945812816409 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 59552
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 59552 <at> debbugs.gnu.org
Cc: hako@HIDDEN
X-Debbugs-Original-To: Hilton Chain via Guix-patches via <guix-patches@HIDDEN>
X-Debbugs-Original-Cc: Hilton Chain <hako@HIDDEN>, 59552 <at> debbugs.gnu.org
Received: via spool by submit <at> debbugs.gnu.org id=B.166945812816409
(code B ref -1); Sat, 26 Nov 2022 10:23:02 +0000
Received: (at submit) by debbugs.gnu.org; 26 Nov 2022 10:22:08 +0000
Received: from localhost ([127.0.0.1]:37890 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oysJz-0004Gb-Na
for submit <at> debbugs.gnu.org; Sat, 26 Nov 2022 05:22:08 -0500
Received: from lists.gnu.org ([209.51.188.17]:34554)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <mail@HIDDEN>) id 1oysJy-0004GO-1E
for submit <at> debbugs.gnu.org; Sat, 26 Nov 2022 05:22:06 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <mail@HIDDEN>)
id 1oysJx-0007Nr-PR
for guix-patches@HIDDEN; Sat, 26 Nov 2022 05:22:05 -0500
Received: from relay7-d.mail.gandi.net ([2001:4b98:dc4:8::227])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <mail@HIDDEN>)
id 1oysJu-00070H-T4
for guix-patches@HIDDEN; Sat, 26 Nov 2022 05:22:05 -0500
Received: (Authenticated sender: admin@HIDDEN)
by mail.gandi.net (Postfix) with ESMTPSA id 7B73A2000B;
Sat, 26 Nov 2022 10:21:55 +0000 (UTC)
From: Nicolas Goaziou <mail@HIDDEN>
References: <20221125011530.12585-1-hako@HIDDEN>
Date: Sat, 26 Nov 2022 11:21:53 +0100
In-Reply-To: <20221125011530.12585-1-hako@HIDDEN> (Hilton Chain via
Guix-patches via's message of "Fri, 25 Nov 2022 09:15:30 +0800")
Message-ID: <87edtqc8xq.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: pass client-ip=2001:4b98:dc4:8::227;
envelope-from=mail@HIDDEN; helo=relay7-d.mail.gandi.net
X-Spam_score_int: -25
X-Spam_score: -2.6
X-Spam_bar: --
X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7,
SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.6 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.6 (--)
Hello,
Hilton Chain via Guix-patches via <guix-patches@HIDDEN> writes:
> * gnu/packages/emacs-xyz.scm (emacs-wakatime-mode): New variable.
Thank you.
> +(define-public emacs-wakatime-mode
> + ;; No release since May 5, 2015.
> + (let ((version "1.0.2") ;32a0154cd4bbd525d354997e6b12c6a9726d0b43, not tagged
> + (revision "55")
> + (commit "ef923829912c3854d230834f81083814b7c9d992"))
You can insert "1.0.2" directly in `version' field below instead of
binding it beforehand.
> + (package
> + (name "emacs-wakatime-mode")
> + (version (git-version version revision commit))
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/wakatime/wakatime-mode")
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "0m29817s2din4n42pflvzg2538i91s0n06y78pf8q94qf0mfspcl"))))
> + (build-system emacs-build-system)
> + (arguments
> + (list #:phases
> + #~(modify-phases %standard-phases
> + ;; XXX: WakaTime hasn't packaged in Guix yet.
> + (delete 'patch-el-files))))
Wouldn't it make sense to package WakaTime first, then?
Could you also run tests?
> + (home-page "https://wakatime.com/emacs")
> + (synopsis "Automatic time tracking extension for Emacs using WakaTime")
> + (description
> + "@code{wakatime-mode} is an Emacs plugin for automatic time tracking
> +and metrics generated from your programming activity.")
WakaTime mode is an Emacs minor mode for automatic...
Regards,
--
Nicolas Goaziou
X-Loop: help-debbugs@HIDDEN
Subject: [bug#59552] [PATCH] gnu: Add emacs-wakatime-mode.
Resent-From: Nicolas Goaziou <mail@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sat, 26 Nov 2022 10:23:02 +0000
Resent-Message-ID: <handler.59552.B59552.166945813316422 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 59552
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch
To: 59552 <at> debbugs.gnu.org
Cc: hako@HIDDEN
X-Debbugs-Original-To: Hilton Chain via Guix-patches via <guix-patches@HIDDEN>
X-Debbugs-Original-Cc: Hilton Chain <hako@HIDDEN>, 59552 <at> debbugs.gnu.org
Received: via spool by 59552-submit <at> debbugs.gnu.org id=B59552.166945813316422
(code B ref 59552); Sat, 26 Nov 2022 10:23:02 +0000
Received: (at 59552) by debbugs.gnu.org; 26 Nov 2022 10:22:13 +0000
Received: from localhost ([127.0.0.1]:37892 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oysK5-0004Gn-35
for submit <at> debbugs.gnu.org; Sat, 26 Nov 2022 05:22:13 -0500
Received: from relay7-d.mail.gandi.net ([217.70.183.200]:51127)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <mail@HIDDEN>) id 1oysJv-0004Fs-8f
for 59552 <at> debbugs.gnu.org; Sat, 26 Nov 2022 05:22:06 -0500
Received: (Authenticated sender: admin@HIDDEN)
by mail.gandi.net (Postfix) with ESMTPSA id 7B73A2000B;
Sat, 26 Nov 2022 10:21:55 +0000 (UTC)
From: Nicolas Goaziou <mail@HIDDEN>
References: <20221125011530.12585-1-hako@HIDDEN>
Date: Sat, 26 Nov 2022 11:21:53 +0100
In-Reply-To: <20221125011530.12585-1-hako@HIDDEN> (Hilton Chain via
Guix-patches via's message of "Fri, 25 Nov 2022 09:15:30 +0800")
Message-ID: <87edtqc8xq.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -0.7 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
Hello,
Hilton Chain via Guix-patches via <guix-patches@HIDDEN> writes:
> * gnu/packages/emacs-xyz.scm (emacs-wakatime-mode): New variable.
Thank you.
> +(define-public emacs-wakatime-mode
> + ;; No release since May 5, 2015.
> + (let ((version "1.0.2") ;32a0154cd4bbd525d354997e6b12c6a9726d0b43, not tagged
> + (revision "55")
> + (commit "ef923829912c3854d230834f81083814b7c9d992"))
You can insert "1.0.2" directly in `version' field below instead of
binding it beforehand.
> + (package
> + (name "emacs-wakatime-mode")
> + (version (git-version version revision commit))
> + (source (origin
> + (method git-fetch)
> + (uri (git-reference
> + (url "https://github.com/wakatime/wakatime-mode")
> + (commit commit)))
> + (file-name (git-file-name name version))
> + (sha256
> + (base32
> + "0m29817s2din4n42pflvzg2538i91s0n06y78pf8q94qf0mfspcl"))))
> + (build-system emacs-build-system)
> + (arguments
> + (list #:phases
> + #~(modify-phases %standard-phases
> + ;; XXX: WakaTime hasn't packaged in Guix yet.
> + (delete 'patch-el-files))))
Wouldn't it make sense to package WakaTime first, then?
Could you also run tests?
> + (home-page "https://wakatime.com/emacs")
> + (synopsis "Automatic time tracking extension for Emacs using WakaTime")
> + (description
> + "@code{wakatime-mode} is an Emacs plugin for automatic time tracking
> +and metrics generated from your programming activity.")
WakaTime mode is an Emacs minor mode for automatic...
Regards,
--
Nicolas Goaziou
Received: (at control) by debbugs.gnu.org; 28 Nov 2022 09:02:09 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Nov 28 04:02:08 2022 Received: from localhost ([127.0.0.1]:47352 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oza1g-0005j3-Nk for submit <at> debbugs.gnu.org; Mon, 28 Nov 2022 04:02:08 -0500 Received: from mira.cbaines.net ([212.71.252.8]:41996) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <mail@HIDDEN>) id 1oza1d-0005ix-KG for control <at> debbugs.gnu.org; Mon, 28 Nov 2022 04:02:07 -0500 Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:54d1:d5d4:280e:f699]) by mira.cbaines.net (Postfix) with ESMTPSA id 8DB6727BBE9 for <control <at> debbugs.gnu.org>; Mon, 28 Nov 2022 09:02:04 +0000 (GMT) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id 82d1cad4 for <control <at> debbugs.gnu.org>; Mon, 28 Nov 2022 09:02:04 +0000 (UTC) From: Christopher Baines <mail@HIDDEN> To: control <at> debbugs.gnu.org Subject: tag 59552 moreinfo Date: Mon, 28 Nov 2022 09:02:04 +0000 Message-ID: <8735a3laer.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) tags 59552 + moreinfo quit
X-Loop: help-debbugs@HIDDEN
Subject: [bug#59552] [PATCH v2 0/1] gnu: Add emacs-wakatime-mode.
Resent-From: Hilton Chain <hako@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: andrew@HIDDEN, liliana.prikler@HIDDEN, guix-patches@HIDDEN
Resent-Date: Sat, 15 Jul 2023 15:05:01 +0000
Resent-Message-ID: <handler.59552.B59552.168943345532623 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 59552
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch moreinfo
To: 59552 <at> debbugs.gnu.org
Cc: Hilton Chain <hako@HIDDEN>, Nicolas Goaziou <mail@HIDDEN>, Andrew Tropin <andrew@HIDDEN>, Liliana Marie Prikler <liliana.prikler@HIDDEN>
X-Debbugs-Original-Xcc: Andrew Tropin <andrew@HIDDEN>, Liliana Marie Prikler <liliana.prikler@HIDDEN>
Received: via spool by 59552-submit <at> debbugs.gnu.org id=B59552.168943345532623
(code B ref 59552); Sat, 15 Jul 2023 15:05:01 +0000
Received: (at 59552) by debbugs.gnu.org; 15 Jul 2023 15:04:15 +0000
Received: from localhost ([127.0.0.1]:45754 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qKgog-0008U6-P0
for submit <at> debbugs.gnu.org; Sat, 15 Jul 2023 11:04:15 -0400
Received: from mail.boiledscript.com ([144.168.59.46]:34806)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <hako@HIDDEN>) id 1qKgoe-0008Tx-9O
for 59552 <at> debbugs.gnu.org; Sat, 15 Jul 2023 11:04:13 -0400
From: Hilton Chain <hako@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space;
s=dkim; t=1689433205;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=+LICoIeOeyo9JqqHeZ905kdZy+UzQMvI8YzofGeY/64=;
b=FiMpmcShCYYfElC+KfNsp7gGHWjW1j4zbHu7i+yAg0TwzbEZkKHTFVA+uL3Ge3jWLD/vYD
q67XWEI0SXWzHGyW8TUAVKhse74/Ccwd4l2l1SKI8FrdLOKB4GBvxKCweZkN7n4UOmSpwy
I+2ne0PK0SS3iPBV2xGG/+JYYkCeqfbo9yBdR1uivK6jDrWDgF26LO82lf0pW60p/k5Nk4
AQMAf8rgyjUL7GVGe5z4B2hKieF8/x5WqchLKP/h5vcUGYQBxL/Eavhb49rFUWuVpHCL8n
LqVQU62nIcnP43VvH+KuJZqd/ZW+CGsKLLGLeebf9ifnoNK5vKVODqsMiprNZg==
Date: Sat, 15 Jul 2023 23:01:40 +0800
Message-ID: <cover.1689427041.git.hako@HIDDEN>
In-Reply-To: <20221125011530.12585-1-hako@HIDDEN>
References: <20221125011530.12585-1-hako@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spamd-Bar: /
Authentication-Results: mail.boiledscript.com;
auth=pass smtp.mailfrom=hako@HIDDEN
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Hello Guix!
After looking through waktime-mode's source and Guix's build phases, I think
it's OK to add the package first without packaging the wakatime-cli program.
(Actually I managed to package all the dependencies of that go program locally,
but it eventually failed to build without a clear error...)
For the package definition itself, phase 'patch-el-files is still deleted
because of the following error:
--8<---------------cut here---------------start------------->8---
In guix/build/emacs-build-system.scm:
148:13 3 (loop (#(" ((file-exists-p (format \"/bin/%s\" …" …)) …)
In ice-9/boot-9.scm:
1685:16 2 (raise-exception _ #:continuable? _)
1685:16 1 (raise-exception _ #:continuable? _)
1685:16 0 (raise-exception _ #:continuable? _)
ice-9/boot-9.scm:1685:16: In procedure raise-exception:
patch-el-files: unable to locate "%s"
--8<---------------cut here---------------end--------------->8---
I added a comment before suggesting that wakatime-cli is not available, but
that was inaccurate. The real cause is that 'patch-el-files can't handle the
following code:
--8<---------------cut here---------------start------------->8---
(defun wakatime-find-binary (program)
"Find the full path to an executable program."
(cond
[...]
((file-exists-p (format "/bin/%s" program))
(format "/bin/%s" program))
[...]))
--8<---------------cut here---------------end--------------->8---
This seems to be a bug of the phase, as it shouldn't handle unformatted
"/bin/%s" at all. And for the function finding an executable, it's
unnecessary to patch it, then I think it's fine to delete the phase.
And finally, it's wakatime-mode-test.el, the cases are so outdated that none
of them could pass... There's no Makefile for 'check phase to run the test
either, so no need to adjust for it.
As a result, I think it's OK to add the package first without packaging the
wakatime-cli program.
Hilton Chain (1):
gnu: Add emacs-wakatime-mode.
gnu/packages/emacs-xyz.scm | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
base-commit: 01412c6c6a98e4da10676560638640d0f33e1a02
--
2.41.0
X-Loop: help-debbugs@HIDDEN
Subject: [bug#59552] [PATCH v2 1/1] gnu: Add emacs-wakatime-mode.
Resent-From: Hilton Chain <hako@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: andrew@HIDDEN, liliana.prikler@HIDDEN, guix-patches@HIDDEN
Resent-Date: Sat, 15 Jul 2023 15:06:02 +0000
Resent-Message-ID: <handler.59552.B59552.1689433531308 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 59552
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch moreinfo
To: "59552 <at> debbugs.gnu.org"
Cc: Hilton Chain <hako@HIDDEN>, Andrew Tropin <andrew@HIDDEN>, Liliana Marie Prikler <liliana.prikler@HIDDEN>
X-Debbugs-Original-Xcc: Andrew Tropin <andrew@HIDDEN>, Liliana Marie Prikler <liliana.prikler@HIDDEN>
Received: via spool by 59552-submit <at> debbugs.gnu.org id=B59552.1689433531308
(code B ref 59552); Sat, 15 Jul 2023 15:06:02 +0000
Received: (at 59552) by debbugs.gnu.org; 15 Jul 2023 15:05:31 +0000
Received: from localhost ([127.0.0.1]:45766 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qKgpu-00004u-SM
for submit <at> debbugs.gnu.org; Sat, 15 Jul 2023 11:05:31 -0400
Received: from mail.boiledscript.com ([144.168.59.46]:42820)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <hako@HIDDEN>) id 1qKgpo-0008W1-8e
for 59552 <at> debbugs.gnu.org; Sat, 15 Jul 2023 11:05:26 -0400
From: Hilton Chain <hako@HIDDEN>
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space;
s=dkim; t=1689433279;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=EoMTfp1BmaGZdFBTY1koZY9Qbw3U/N+2dpUyjkPN2OE=;
b=0ZLIOI2Cu7MHDkd7cINgQ6Jh4BoaC4ii7DCocUrkq2UzFcNXggVypfz4mILfkOUlMgitbv
S5ZfF/ERjEQSZYsDmFCXfCnTiLtGrYKae6FP6/4B6qezE6QeecOyPnaaxB9d1MDu/ZNbjI
Q4nFTxbGY0tIHEhBJEj2olR9w1hJcwpGFadAQ0tApxLZh6VWccHIPlpNpBRVWD1CksjiXx
vRpbTPOa7msDVt6/ssFGCBqafpSmSlqi6L0/ahKyir4StrlTo1HAuqyiuJwiCl3Af94Vew
Va2Sgb9VHYX1RU7CMCS5D+m3amGtQIvGQ5pe98fEm72q5Dn3vDJuizaAHyhaYg==
Date: Sat, 15 Jul 2023 23:05:16 +0800
Message-ID: <39e1399d86945de7920239aebabbb0894ad03f6e.1689427041.git.hako@HIDDEN>
In-Reply-To: <cover.1689427041.git.hako@HIDDEN>
References: <cover.1689427041.git.hako@HIDDEN>
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spamd-Bar: --
Authentication-Results: mail.boiledscript.com;
auth=pass smtp.mailfrom=hako@HIDDEN
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
* gnu/packages/emacs-xyz.scm (emacs-wakatime-mode): New variable.
---
gnu/packages/emacs-xyz.scm | 30 ++++++++++++++++++++++++++++++
1 file changed, 30 insertions(+)
diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 480096fb50..84baf7ea32 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -37153,6 +37153,36 @@ (define-public emacs-mpv
process via its IPC interface.")
(license license:gpl3+))))
+(define-public emacs-wakatime-mode
+ ;; No release since May 5, 2015.
+ (let ((commit "ef923829912c3854d230834f81083814b7c9d992")
+ (revision "55"))
+ (package
+ (name "emacs-wakatime-mode")
+ ;; 1.0.2 on commit 32a0154cd4bbd525d354997e6b12c6a9726d0b43, not tagged
+ (version (git-version "1.0.2" revision commit))
+ (source (origin
+ (method git-fetch)
+ (uri (git-reference
+ (url "https://github.com/wakatime/wakatime-mode")
+ (commit commit)))
+ (file-name (git-file-name name version))
+ (sha256
+ (base32
+ "0m29817s2din4n42pflvzg2538i91s0n06y78pf8q94qf0mfspcl"))))
+ (build-system emacs-build-system)
+ (arguments
+ (list #:phases
+ #~(modify-phases %standard-phases
+ ;; 'patch-el-files errors at "/bin/%s"
+ (delete 'patch-el-files))))
+ (home-page "https://wakatime.com/emacs")
+ (synopsis "Automatic time tracking extension for Emacs using WakaTime")
+ (description
+ "WakaTime mode is an Emacs minor mode for automatic time tracking and
+metrics generated from your programming activity.")
+ (license license:gpl3+))))
+
(define-public emacs-apel-lb
;; No release since Jun 15, 2010.
(let ((version "10.8") ;tag chise-base-0_25
--
2.41.0
X-Loop: help-debbugs@HIDDEN
Subject: [bug#59552] [PATCH v2 0/1] gnu: Add emacs-wakatime-mode.
Resent-From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Sun, 16 Jul 2023 07:18:02 +0000
Resent-Message-ID: <handler.59552.B59552.168949183225286 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 59552
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch moreinfo
To: Hilton Chain <hako@HIDDEN>, 59552 <at> debbugs.gnu.org
Cc: Nicolas Goaziou <mail@HIDDEN>, Andrew Tropin <andrew@HIDDEN>
Received: via spool by 59552-submit <at> debbugs.gnu.org id=B59552.168949183225286
(code B ref 59552); Sun, 16 Jul 2023 07:18:02 +0000
Received: (at 59552) by debbugs.gnu.org; 16 Jul 2023 07:17:12 +0000
Received: from localhost ([127.0.0.1]:46550 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qKw0G-0006Zl-37
for submit <at> debbugs.gnu.org; Sun, 16 Jul 2023 03:17:12 -0400
Received: from mail-ej1-x643.google.com ([2a00:1450:4864:20::643]:55662)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <liliana.prikler@HIDDEN>) id 1qKw0C-0006ZU-Rw
for 59552 <at> debbugs.gnu.org; Sun, 16 Jul 2023 03:17:10 -0400
Received: by mail-ej1-x643.google.com with SMTP id
a640c23a62f3a-99342a599e9so498554766b.3
for <59552 <at> debbugs.gnu.org>; Sun, 16 Jul 2023 00:17:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20221208; t=1689491823; x=1692083823;
h=mime-version:user-agent:content-transfer-encoding:references
:in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject
:date:message-id:reply-to;
bh=MNJ7ZOstEZhR8YfOMTGjj/rA1KnnTGpfj7N3Odu7CJ8=;
b=kmdqi9gX+4lmqlXmwE62SzKDE39iCuDnJVqfId/HEXERk75Bg0d5evQW2kcNiIH1zm
SrmCUJFSgNOLeX3SmX8PXIQ5b6K/RRbK0ctvIYZzN7Yx3Jni9fi6qTlEKcdX723imQ+z
wxKw0vJdGwq9aSvjrzIrjdBQbRG/eGjHVspVb06kStZhHy2DpTu/RmoBCyKqZh91VYT5
9riztL0uUSbHyIWRRBAKYaLasvNcXvFDH84Y9Ma0asCNyFrFgNednK8AZyRRj0r1d2yV
S3hE/eVcX8t9/mFJP0PzfHp4MZTMTbTZlugIbcuyT8X7CFIlpOYp0+hwAZbBgFpXEXV2
EXIA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20221208; t=1689491823; x=1692083823;
h=mime-version:user-agent:content-transfer-encoding:references
:in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state
:from:to:cc:subject:date:message-id:reply-to;
bh=MNJ7ZOstEZhR8YfOMTGjj/rA1KnnTGpfj7N3Odu7CJ8=;
b=X5Y6GX5pxdsbLEha7LOxAfLFzhV7QuF9N6uxy0GfA7x3xxDz1BI/c7+m5QVyRwi8Ma
m2AZCs6+wddVrQldWCz5O0ZIHaApdyYm7nscg9RhsTvbMqgGcRATu1w2ejmT88pSoEtQ
TdzYBiLEEO05DxAIt+31qIffjGd8feNmN1QhnO8lZnTX1ZbzGwwSuuREHSLHAYABMeg6
rlEOh1+msYns1dTDUaKJdtywxG4pQ+gDuKII/BgMpSMs4IrSCEARA9hUP7Ar8KNkM56d
YtKAf7G588DZff+sgmzsTEqoPJhZ6x3YZEqU1hBhaI0FvbxgTTDZNr3r08v4a4WgfM9t
AYwQ==
X-Gm-Message-State: ABy/qLaOM2teRoOT0cAU5oidZfigCmNL5fzsjI8sg01Wj+nKHGsG/g12
5Jni/tFHjl8c3sCj0atUycE=
X-Google-Smtp-Source: APBJJlGO78bLdVycICdEAMSrj81otJkGtAHKlygJSBXmErEMRawV5Z5XB/lc/3y2sdbhQoW+OGW3ig==
X-Received: by 2002:a17:906:7495:b0:991:e3c4:c129 with SMTP id
e21-20020a170906749500b00991e3c4c129mr8519836ejl.69.1689491822376;
Sun, 16 Jul 2023 00:17:02 -0700 (PDT)
Received: from lumine.fritz.box (85-127-52-93.dsl.dynamic.surfer.at.
[85.127.52.93]) by smtp.gmail.com with ESMTPSA id
t10-20020a1709066bca00b00993a37aebc5sm7521251ejs.50.2023.07.16.00.17.01
(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
Sun, 16 Jul 2023 00:17:01 -0700 (PDT)
Message-ID: <797011fcc7b4dc7f7b291e2a28e28b4e2f902017.camel@HIDDEN>
From: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Date: Sun, 16 Jul 2023 09:17:01 +0200
In-Reply-To: <cover.1689427041.git.hako@HIDDEN>
References: <20221125011530.12585-1-hako@HIDDEN>
<cover.1689427041.git.hako@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.46.4
MIME-Version: 1.0
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Am Samstag, dem 15.07.2023 um 23:01 +0800 schrieb Hilton Chain:
> --8<---------------cut here---------------start------------->8---
> (defun wakatime-find-binary (program)
> =C2=A0 "Find the full path to an executable program."
> =C2=A0 (cond
> =C2=A0=C2=A0=C2=A0 [...]
> =C2=A0=C2=A0=C2=A0 ((file-exists-p (format "/bin/%s" program))
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 (format "/bin/%s" program))
> =C2=A0=C2=A0=C2=A0 [...]))
> --8<---------------cut here---------------end--------------->8---
>=20
> This seems to be a bug of the phase, as it shouldn't handle
> unformatted
> "/bin/%s" at all.=C2=A0 And for the function finding an executable, it's
> unnecessary to patch it, then I think it's fine to delete the phase.
I think this should be=C2=A0
(or (executable-find program)=C2=A0
(cdr-safe (assoc program <some hardcoded table>))
where some hardcoded table contains stubs to fill in via=C2=A0
(search-input-file =E2=80=A6)
Cheers =20
X-Loop: help-debbugs@HIDDEN
Subject: [bug#59552] [PATCH v2 0/1] gnu: Add emacs-wakatime-mode.
Resent-From: Hilton Chain <hako@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: guix-patches@HIDDEN
Resent-Date: Tue, 18 Jul 2023 16:36:01 +0000
Resent-Message-ID: <handler.59552.B59552.16896981585362 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 59552
X-GNU-PR-Package: guix-patches
X-GNU-PR-Keywords: patch moreinfo
To: Liliana Marie Prikler <liliana.prikler@HIDDEN>
Cc: Hilton Chain <hako@HIDDEN>, 59552 <at> debbugs.gnu.org, Nicolas Goaziou <mail@HIDDEN>, Andrew Tropin <andrew@HIDDEN>
Received: via spool by 59552-submit <at> debbugs.gnu.org id=B59552.16896981585362
(code B ref 59552); Tue, 18 Jul 2023 16:36:01 +0000
Received: (at 59552) by debbugs.gnu.org; 18 Jul 2023 16:35:58 +0000
Received: from localhost ([127.0.0.1]:54101 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1qLng6-0001OQ-F4
for submit <at> debbugs.gnu.org; Tue, 18 Jul 2023 12:35:58 -0400
Received: from mail.boiledscript.com ([144.168.59.46]:59570)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <hako@HIDDEN>) id 1qLng3-0001OF-5s
for 59552 <at> debbugs.gnu.org; Tue, 18 Jul 2023 12:35:57 -0400
Date: Wed, 19 Jul 2023 00:35:25 +0800
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ultrarare.space;
s=dkim; t=1689697902;
h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
to:to:cc:cc:mime-version:mime-version:content-type:content-type:
content-transfer-encoding:content-transfer-encoding:
in-reply-to:in-reply-to:references:references;
bh=sLykz4vYeqD9htLi17bR+/hh4sWk4e1LRwjb1mtRm/4=;
b=oTyL4HXNP0gy10hwM0jrIL8s3J6S4cDe+EpGCb7HPMsj56gKA+LeyktKB7Avp6POVpkfsF
xdLXA0MAJ00m55Drh2phK0p+WPiELa7iAl3Scu7L6LivWAG9KW6t8naJ31+1olemDgVWhu
09jazVwlzR/cOM8WQRqRpOcZx2G2R8rLvVfUvU8eIEiun4RvOOQVP6/XvyFkiWeHzRhQSZ
X+LxuCTk5rkeQSyjCFh6efCOvaC4prJEhu3UnvonFl9AdBzUOLw2VctTkryt6W2TYB0vaX
OEQOSpXF2fBOhO+7Z+6o4qUxUoMKiIqaxgdrPUf7HEYspnfhAvPvn/waYLho/Q==
Message-ID: <875y6hyy7m.wl-hako@HIDDEN>
From: Hilton Chain <hako@HIDDEN>
In-Reply-To: <797011fcc7b4dc7f7b291e2a28e28b4e2f902017.camel@HIDDEN>
References: <20221125011530.12585-1-hako@HIDDEN>
<cover.1689427041.git.hako@HIDDEN>
<797011fcc7b4dc7f7b291e2a28e28b4e2f902017.camel@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
X-Spamd-Bar: ++
Authentication-Results: mail.boiledscript.com;
auth=pass smtp.mailfrom=hako@HIDDEN
X-Spam-Level: **
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
On Sun, 16 Jul 2023 15:17:01 +0800,
Liliana Marie Prikler wrote:
> I think this should be=C2=A0
> (or (executable-find program)=C2=A0
> (cdr-safe (assoc program <some hardcoded table>))
> where some hardcoded table contains stubs to fill in via=C2=A0
> (search-input-file =E2=80=A6)
Thank you for the suggestion!
Sorry for the incomplete information, the PROGRAM argument is actually
nonsense because `wakatime-find-binary' is not a user-facing function
and is called with a fixed value of "wakatime-cli", so it's not
appropriate to use an alist. =20
Other (hardcoded) values are actually handled as conditions within the
function.=20
I tried replacing the conditions with yours, except for the `cdr-safe'
line, which is replaced by a `locate-file', and it seems to work fine.
The new function does not contain a "/bin/[...]" so 'patch-el-files
won't handle it.
This may not be expected but I think it's enough to improve the
function itself.
I'll send a patch to upstream and send v3 later.
Thanks
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.