GNU bug report logs - #59560
[PATCH 1/2] gnu: Add emacs-function-args.

Previous Next

Package: guix-patches;

Reported by: jgart <jgart <at> dismail.de>

Date: Fri, 25 Nov 2022 03:06:02 UTC

Severity: normal

Tags: patch

Done: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59560 in the body.
You can then email your comments to 59560 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#59560; Package guix-patches. (Fri, 25 Nov 2022 03:06:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to jgart <jgart <at> dismail.de>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Fri, 25 Nov 2022 03:06:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH 1/2] gnu: Add emacs-function-args.
Date: Thu, 24 Nov 2022 21:04:39 -0600
hiya,

this updates emacs-lpy and adds a missing input of emacs-function-args




Information forwarded to guix-patches <at> gnu.org:
bug#59560; Package guix-patches. (Fri, 25 Nov 2022 03:08:02 GMT) Full text and rfc822 format available.

Message #8 received at 59560 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 59560 <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH 1/2] gnu: Add emacs-function-args.
Date: Thu, 24 Nov 2022 21:06:42 -0600
* gnu/packages/emacs-xyz.scm (emacs-function-args): New variable.
---
 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 5d6f4d040f..ec1d59931d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11083,6 +11083,32 @@ (define-public emacs-lispyville
 state and will work even without lispy being enabled.")
       (license license:gpl3+))))
 
+(define-public emacs-function-args
+  ;; The latest release is from August 21, 2017.
+  (let ((commit "beba049751fed78666c87bd146a6f1cf149bb819")
+        (revision "0"))
+    (package
+      (name "emacs-function-args")
+      (version (git-version "0.6.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/abo-abo/function-args")
+               (commit commit)))
+         (sha256
+          (base32
+           "1vxrjy6k030hcbclblgcaaw7h6k17kl3n9zla08527525c0gma01"))
+         (file-name (git-file-name name version))))
+      (propagated-inputs (list emacs-ivy))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/abo-abo/function-args")
+      (synopsis "C/C++ completion for GNU Emacs")
+      (description
+"GNU Emacs package for showing an inline arguments hint for the C/C++
+function at point.")
+      (license license:gpl3+))))
+
 (define-public emacs-lpy
   ;; There is no proper release/tag.
   (let ((commit "ce78a4613458790cc785c1687af7eed8f0d8d66c")
-- 
2.38.1





Information forwarded to guix-patches <at> gnu.org:
bug#59560; Package guix-patches. (Fri, 25 Nov 2022 03:08:03 GMT) Full text and rfc822 format available.

Message #11 received at 59560 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 59560 <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH 2/2] gnu: emacs-lpy: Update to fa95b11.
Date: Thu, 24 Nov 2022 21:06:43 -0600
* gnu/packages/emacs-xyz.scm (emacs-lpy): Update to fa95b11.
[propagated-inputs]: Add missing emacs-function-args.
---
 gnu/packages/emacs-xyz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ec1d59931d..fdb5b19477 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11111,7 +11111,7 @@ (define-public emacs-function-args
 
 (define-public emacs-lpy
   ;; There is no proper release/tag.
-  (let ((commit "ce78a4613458790cc785c1687af7eed8f0d8d66c")
+  (let ((commit "fa95b11e1023704510cc7dd2897bf8bcc3027cbb")
         (revision "5"))
     (package
       (name "emacs-lpy")
@@ -11127,7 +11127,7 @@ (define-public emacs-lpy
            "1vxrjy6k030hcbclblgcaaw7h6k17kl3n9zla08527525c0gma01"))
          (file-name (git-file-name name version))))
       (propagated-inputs
-       (list emacs-zoutline emacs-lispy))
+       (list emacs-zoutline emacs-lispy emacs-function-args))
       (build-system emacs-build-system)
       (home-page "https://github.com/abo-abo/lpy")
       (synopsis "Modal editing for Python")
-- 
2.38.1





Information forwarded to guix-patches <at> gnu.org:
bug#59560; Package guix-patches. (Fri, 25 Nov 2022 06:16:02 GMT) Full text and rfc822 format available.

Message #14 received at 59560 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 59560 <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH v2 1/2] gnu: Add emacs-function-args.
Date: Fri, 25 Nov 2022 00:14:26 -0600
* gnu/packages/emacs-xyz.scm (emacs-function-args): New variable.

Hi,

I forgut to include the hash update. Ignore v1 and use this v2 instead.

all best,

jgart
---
 gnu/packages/emacs-xyz.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index 5d6f4d040f..ec1d59931d 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11083,6 +11083,32 @@ (define-public emacs-lispyville
 state and will work even without lispy being enabled.")
       (license license:gpl3+))))
 
+(define-public emacs-function-args
+  ;; The latest release is from August 21, 2017.
+  (let ((commit "beba049751fed78666c87bd146a6f1cf149bb819")
+        (revision "0"))
+    (package
+      (name "emacs-function-args")
+      (version (git-version "0.6.0" revision commit))
+      (source
+       (origin
+         (method git-fetch)
+         (uri (git-reference
+               (url "https://github.com/abo-abo/function-args")
+               (commit commit)))
+         (sha256
+          (base32
+           "1vxrjy6k030hcbclblgcaaw7h6k17kl3n9zla08527525c0gma01"))
+         (file-name (git-file-name name version))))
+      (propagated-inputs (list emacs-ivy))
+      (build-system emacs-build-system)
+      (home-page "https://github.com/abo-abo/function-args")
+      (synopsis "C/C++ completion for GNU Emacs")
+      (description
+"GNU Emacs package for showing an inline arguments hint for the C/C++
+function at point.")
+      (license license:gpl3+))))
+
 (define-public emacs-lpy
   ;; There is no proper release/tag.
   (let ((commit "ce78a4613458790cc785c1687af7eed8f0d8d66c")
-- 
2.38.1





Information forwarded to guix-patches <at> gnu.org:
bug#59560; Package guix-patches. (Fri, 25 Nov 2022 06:16:02 GMT) Full text and rfc822 format available.

Message #17 received at 59560 <at> debbugs.gnu.org (full text, mbox):

From: jgart <jgart <at> dismail.de>
To: 59560 <at> debbugs.gnu.org
Cc: jgart <jgart <at> dismail.de>
Subject: [PATCH v2 2/2] gnu: emacs-lpy: Update to fa95b11.
Date: Fri, 25 Nov 2022 00:14:27 -0600
* gnu/packages/emacs-xyz.scm (emacs-lpy): Update to fa95b11.
[propagated-inputs]: Add missing emacs-function-args.
---
 gnu/packages/emacs-xyz.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm
index ec1d59931d..b4ab6ec5c3 100644
--- a/gnu/packages/emacs-xyz.scm
+++ b/gnu/packages/emacs-xyz.scm
@@ -11111,8 +11111,8 @@ (define-public emacs-function-args
 
 (define-public emacs-lpy
   ;; There is no proper release/tag.
-  (let ((commit "ce78a4613458790cc785c1687af7eed8f0d8d66c")
-        (revision "5"))
+  (let ((commit "fa95b11e1023704510cc7dd2897bf8bcc3027cbb")
+        (revision "0"))
     (package
       (name "emacs-lpy")
       (version (git-version "0.1.0" revision commit))
@@ -11124,10 +11124,10 @@ (define-public emacs-lpy
                (commit commit)))
          (sha256
           (base32
-           "1vxrjy6k030hcbclblgcaaw7h6k17kl3n9zla08527525c0gma01"))
+           "1j92ll2afvcp891fxra3sawxg000cs3ra01wxksiil2dg5zpzzkn"))
          (file-name (git-file-name name version))))
       (propagated-inputs
-       (list emacs-zoutline emacs-lispy))
+       (list emacs-zoutline emacs-lispy emacs-function-args))
       (build-system emacs-build-system)
       (home-page "https://github.com/abo-abo/lpy")
       (synopsis "Modal editing for Python")
-- 
2.38.1





Information forwarded to guix-patches <at> gnu.org:
bug#59560; Package guix-patches. (Sat, 26 Nov 2022 10:35:02 GMT) Full text and rfc822 format available.

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: jgart via Guix-patches via <guix-patches <at> gnu.org>
Cc: jgart <jgart <at> dismail.de>, 59560 <at> debbugs.gnu.org
Subject: Re: [bug#59560] [PATCH v2 1/2] gnu: Add emacs-function-args.
Date: Sat, 26 Nov 2022 11:33:56 +0100
Hello,

jgart via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-function-args): New variable.

Thank you.

> +         (sha256
> +          (base32
> +           "1vxrjy6k030hcbclblgcaaw7h6k17kl3n9zla08527525c0gma01"))
> +         (file-name (git-file-name name version))))

Nitpick: Usuallly the file-name field resides before sha256.

> +      (propagated-inputs (list emacs-ivy))
> +      (build-system emacs-build-system)

Other nitpick in the same vein: propagated-inputs usually come after
build-system field.

> +      (description
> +"GNU Emacs package for showing an inline arguments hint for the C/C++
> +function at point.")

This is not a complete sentence. I would also add that the package
extends C++ mode completion provided by CEDET. What about something
like:

  Function-args shows inline arguments hints exactly where the C/C++
  function call is, rather than in the minibuffer. It also extends C++
  mode completion provided by CEDET.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou




Information forwarded to guix-patches <at> gnu.org:
bug#59560; Package guix-patches. (Sat, 26 Nov 2022 10:35:03 GMT) Full text and rfc822 format available.

Information forwarded to guix-patches <at> gnu.org:
bug#59560; Package guix-patches. (Sat, 26 Nov 2022 10:36:01 GMT) Full text and rfc822 format available.

Message #26 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: jgart via Guix-patches via <guix-patches <at> gnu.org>
Cc: jgart <jgart <at> dismail.de>, 59560 <at> debbugs.gnu.org
Subject: Re: [bug#59560] [PATCH v2 2/2] gnu: emacs-lpy: Update to fa95b11.
Date: Sat, 26 Nov 2022 11:35:47 +0100
Hello,

jgart via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-lpy): Update to fa95b11.
> [propagated-inputs]: Add missing emacs-function-args.

Thanks.

> -  (let ((commit "ce78a4613458790cc785c1687af7eed8f0d8d66c")
> -        (revision "5"))
> +  (let ((commit "fa95b11e1023704510cc7dd2897bf8bcc3027cbb")
> +        (revision "0"))

You should reset revision only when bumping base version. The fact that
commit happen to be sorted in the right order is too subtle. I vote for
(revision "6").

>      (package
>        (name "emacs-lpy")
>        (version (git-version "0.1.0" revision commit))
> @@ -11124,10 +11124,10 @@ (define-public emacs-lpy
>                 (commit commit)))
>           (sha256
>            (base32
> -           "1vxrjy6k030hcbclblgcaaw7h6k17kl3n9zla08527525c0gma01"))
> +           "1j92ll2afvcp891fxra3sawxg000cs3ra01wxksiil2dg5zpzzkn"))
>           (file-name (git-file-name name version))))
>        (propagated-inputs
> -       (list emacs-zoutline emacs-lispy))
> +       (list emacs-zoutline emacs-lispy emacs-function-args))

While you're at it, could you sort inputs alphabetically, too?

Regards,
-- 
Nicolas Goaziou




Information forwarded to guix-patches <at> gnu.org:
bug#59560; Package guix-patches. (Sat, 26 Nov 2022 10:37:02 GMT) Full text and rfc822 format available.

Reply sent to Nicolas Goaziou <mail <at> nicolasgoaziou.fr>:
You have taken responsibility. (Tue, 04 Apr 2023 19:00:03 GMT) Full text and rfc822 format available.

Notification sent to jgart <jgart <at> dismail.de>:
bug acknowledged by developer. (Tue, 04 Apr 2023 19:00:03 GMT) Full text and rfc822 format available.

Message #34 received at 59560-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: 59560-done <at> debbugs.gnu.org
Subject: Re: [bug#59560] [PATCH v2 1/2] gnu: Add emacs-function-args.
Date: Tue, 04 Apr 2023 20:59:05 +0200
Closing. Patch already applied.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 03 May 2023 11:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 330 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.