GNU bug report logs - #59569
[PATCH 0/2] nheko: Support video calls

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59569 in the body.
You can then email your comments to 59569 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Martin Schmidt <martin.schmidt13 <at> gmx.de>
To: guix-patches <at> gnu.org
Cc: Martin Schmidt <martin.schmidt13 <at> gmx.de>
Subject: [PATCH 0/2] nheko: Support video calls
Date: Fri, 25 Nov 2022 08:11:26 +0100

Hi Guix,
2 patches for enabling video calls in nheko. Special thanks to "unmatched-paren" for the help and patience!

Martin Schmidt (2):
  gnu: Add gst-plugins-good-qt.
  gnu: nheko: Support video calls.

 gnu/packages/gstreamer.scm | 21 +++++++++++++++++++++
 gnu/packages/messaging.scm |  2 +-
 2 files changed, 22 insertions(+), 1 deletion(-)


base-commit: 8f3e10ae819aabbe8216bfee6cd3e7857bc27293
--
2.38.0

Message #8 received at 59569 <at> debbugs.gnu.org (full text, mbox):

From: Martin Schmidt <martin.schmidt13 <at> gmx.de>
To: 59569 <at> debbugs.gnu.org
Cc: Martin Schmidt <martin.schmidt13 <at> gmx.de>
Subject: [PATCH 1/2] gnu: Add gst-plugins-good-qt.
Date: Fri, 25 Nov 2022 12:13:12 +0100

* gnu/packages/gstreamer.scm (gst-plugins-good-qt): New variable.
---
 gnu/packages/gstreamer.scm | 21 +++++++++++++++++++++
 1 file changed, 21 insertions(+)

diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index a92588a9e2..323fdb6f28 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -734,6 +734,27 @@ (define libsoup
     (home-page "https://gstreamer.freedesktop.org/")
     (license license:lgpl2.0+)))

+(define-public gst-plugins-good-qt
+  (package (inherit gst-plugins-good)
+    (name "gst-plugins-good-qt")
+    (build-system meson-build-system)
+
+    (inputs
+     (modify-inputs (package-inputs gst-plugins-good)
+		    (prepend qtbase-5 qtdeclarative-5 qtx11extras qtwayland-5)))
+
+    (arguments
+     (substitute-keyword-arguments (package-arguments gst-plugins-good)
+				   ((#:configure-flags flags #~'())
+				    #~(list "-Dgst-plugins-good:qt5=enabled" ))
+
+
+))))
+
+
+
+
+
 (define-public gst-plugins-bad
   (package
     (name "gst-plugins-bad")
--
2.38.0

Message #11 received at 59569 <at> debbugs.gnu.org (full text, mbox):

From: Martin Schmidt <martin.schmidt13 <at> gmx.de>
To: 59569 <at> debbugs.gnu.org
Cc: Martin Schmidt <martin.schmidt13 <at> gmx.de>
Subject: [PATCH 2/2] gnu: nheko: Support video calls.
Date: Fri, 25 Nov 2022 12:13:13 +0100

* gnu/packages/messaging.scm (nheko)[inputs]: Replace
  GST-PLUGINS-GOOD with GST-PLUGINS-GOOD-QT to fix video
  calls.
---
 gnu/packages/messaging.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 9927c7c323..d23118cce8 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -2459,7 +2459,7 @@ (define-public nheko
            curl
            gst-plugins-base
            gst-plugins-bad              ; sdp & webrtc for voip
-           gst-plugins-good             ; rtpmanager for voip
+           gst-plugins-good-qt          ; rtpmanager for voip
            json-modern-cxx
            libevent
            libnice                      ; for voip
--
2.38.0

Message #14 received at 59569 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: "Martin Schmidt" <martin.schmidt13 <at> gmx.de>, <59569 <at> debbugs.gnu.org>
Subject: Re: [bug#59569] [PATCH 1/2] gnu: Add gst-plugins-good-qt.
Date: Fri, 25 Nov 2022 15:57:04 +0000

On Fri Nov 25, 2022 at 11:13 AM GMT, Martin Schmidt wrote:
> * gnu/packages/gstreamer.scm (gst-plugins-good-qt): New variable.

> --- a/gnu/packages/gstreamer.scm
> +++ b/gnu/packages/gstreamer.scm

> @@ -734,6 +734,27 @@ (define libsoup

> +(define-public gst-plugins-good-qt
> +  (package (inherit gst-plugins-good)
> +    (name "gst-plugins-good-qt")
> +    (build-system meson-build-system)
> +
> +    (inputs
> +     (modify-inputs (package-inputs gst-plugins-good)
> +		    (prepend qtbase-5 qtdeclarative-5 qtx11extras qtwayland-5)))
> +
> +    (arguments
> +     (substitute-keyword-arguments (package-arguments gst-plugins-good)
> +				   ((#:configure-flags flags #~'())
> +				    #~(list "-Dgst-plugins-good:qt5=enabled" ))

> +
> +
> +))))

Indentation is... a wee bit off :) Also, the build-system override is a no-op.

Try this instead:

  (define-public gst-plugins-good-qt
    (package
      (inherit gst-plugins-good)
      (arguments
       (substitute-keyword-arguments
           (package-arguments gst-plugins-good)
         ((#:configure-flags flags)
          #~(cons "-Dgst-plugins-good:qt5=enabled"
                  flags))))
      (inputs
       (modify-inputs (package-inputs gst-plugins-good)
         (prepend qtbase-5
                  qtdeclarative-5
                  qtwayland-5
                  qtx11extras)))))

    -- (

Message #17 received at 59569 <at> debbugs.gnu.org (full text, mbox):

From: "(" <paren <at> disroot.org>
To: "Martin Schmidt" <martin.schmidt13 <at> gmx.de>, <59569 <at> debbugs.gnu.org>
Subject: Re: [bug#59569] [PATCH 2/2] gnu: nheko: Support video calls.
Date: Fri, 25 Nov 2022 16:01:43 +0000

On Fri Nov 25, 2022 at 11:13 AM GMT, Martin Schmidt wrote:
> * gnu/packages/messaging.scm (nheko)[inputs]: Replace
>   GST-PLUGINS-GOOD with GST-PLUGINS-GOOD-QT to fix video
>   calls.

LGTM :)

    -- (

Message #20 received at 59569 <at> debbugs.gnu.org (full text, mbox):

From: Martin Schmidt <martin.schmidt13 <at> gmx.de>
To: 59569 <at> debbugs.gnu.org
Cc: Martin Schmidt <martin.schmidt13 <at> gmx.de>
Subject: [PATCH v2 1/2] gnu: Add gst-plugins-good-qt.
Date: Sat, 26 Nov 2022 18:35:54 +0100

* gnu/packages/gstreamer.scm (gst-plugins-good-qt): New variable.
---
 gnu/packages/gstreamer.scm | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/gnu/packages/gstreamer.scm b/gnu/packages/gstreamer.scm
index a92588a9e2..37e74b706b 100644
--- a/gnu/packages/gstreamer.scm
+++ b/gnu/packages/gstreamer.scm
@@ -734,6 +734,17 @@ (define libsoup
     (home-page "https://gstreamer.freedesktop.org/")
     (license license:lgpl2.0+)))

+(define-public gst-plugins-good-qt
+  (package
+    (inherit gst-plugins-good)
+    (name "gst-plugins-good-qt")
+    (inputs
+     (modify-inputs (package-inputs gst-plugins-good)
+       (prepend qtbase-5
+                qtdeclarative-5
+                qtwayland-5
+                qtx11extras)))))
+
 (define-public gst-plugins-bad
   (package
     (name "gst-plugins-bad")

base-commit: 8f3e10ae819aabbe8216bfee6cd3e7857bc27293
--
2.38.1

Message #23 received at 59569 <at> debbugs.gnu.org (full text, mbox):

From: Martin Schmidt <martin.schmidt13 <at> gmx.de>
To: 59569 <at> debbugs.gnu.org
Cc: Martin Schmidt <martin.schmidt13 <at> gmx.de>
Subject: [PATCH v2 2/2] gnu: nheko: Support video calls.
Date: Sat, 26 Nov 2022 18:35:55 +0100

* gnu/packages/messaging.scm (nheko)[inputs]: Replace
  GST-PLUGINS-GOOD with GST-PLUGINS-GOOD-QT to fix video
  calls.
---
 gnu/packages/messaging.scm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gnu/packages/messaging.scm b/gnu/packages/messaging.scm
index 9927c7c323..d23118cce8 100644
--- a/gnu/packages/messaging.scm
+++ b/gnu/packages/messaging.scm
@@ -2459,7 +2459,7 @@ (define-public nheko
            curl
            gst-plugins-base
            gst-plugins-bad              ; sdp & webrtc for voip
-           gst-plugins-good             ; rtpmanager for voip
+           gst-plugins-good-qt          ; rtpmanager for voip
            json-modern-cxx
            libevent
            libnice                      ; for voip
--
2.38.1

Message #26 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Martin Schmidt <martin.schmidt13 <at> gmx.de>
Cc: 59569-done <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#59569] [PATCH 0/2] nheko: Support video calls
Date: Tue, 13 Dec 2022 13:45:22 +0000

[Message part 1 (text/plain, inline)]

Martin Schmidt <martin.schmidt13 <at> gmx.de> writes:

> Hi Guix,
> 2 patches for enabling video calls in nheko. Special thanks to "unmatched-paren" for the help and patience!
>
> Martin Schmidt (2):
>   gnu: Add gst-plugins-good-qt.
>   gnu: nheko: Support video calls.
>
>  gnu/packages/gstreamer.scm | 21 +++++++++++++++++++++
>  gnu/packages/messaging.scm |  2 +-
>  2 files changed, 22 insertions(+), 1 deletion(-)

Thanks both, I've pushed these to master as
34cf5e06a9acd021d1233587e140759bba452b35.

Chris

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.