GNU bug report logs - #59580
29.0.50; [PATCH] Add new choices to bookmark-sort-flag

Message received at 59580 <at> debbugs.gnu.org:

Received: (at 59580) by debbugs.gnu.org; 19 Dec 2023 18:59:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Dec 19 13:59:15 2023
Received: from localhost ([127.0.0.1]:37402 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rFfJD-0003G9-GU
	for submit <at> debbugs.gnu.org; Tue, 19 Dec 2023 13:59:15 -0500
Received: from sanpietro.red-bean.com ([45.79.25.59]:35376)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <kfogel@HIDDEN>) id 1rFfJB-0003Fw-3F
 for 59580 <at> debbugs.gnu.org; Tue, 19 Dec 2023 13:59:13 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
 d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID:Date:
 Reply-To:References:In-Reply-To:Subject:Cc:To:From:Sender:
 Content-Transfer-Encoding:Content-ID:Content-Description;
 bh=1f8YVghahTDraQ9//aw0rCcR9uSEDP9tpmpkhYPzwAE=; t=1703012350; x=1704221950; 
 b=kf3OU5YlPFwbOER4MB08FhuZCabChXfezRT3Plh1rcf8q9Y1WXur61/cj/KBN0WMpTqFxrUWKXb
 QWZxjKScNpNaqa7EZKrXhrpKqtg9I4edWttdGLcOIqUfB4aAuQskhmzJBbJmHrfQQRSeYuTYVLEgz
 ROex61wQAXKSA7DOIrtGyyVt+LLvMMlXUs68rf+HNf8KRwIoJ4HW24P93CU+YE86aP7VZp326XlVT
 s+sXfpTqIQBEwML6+vEyj5mE9whqmGzUt1Psfob62Rbn1VuRtw1J4Wj9/vksk/N9NftS/QT00BYlp
 6vRnnpkdrM595ykexbG+ol73qxL5B1GGt8JQ==;
Received: from [2601:240:c400:76::5755] (port=35200 helo=libq)
 by sanpietro.red-bean.com with esmtpsa (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2)
 (envelope-from <kfogel@HIDDEN>)
 id 1rFfJ7-0019aO-82; Tue, 19 Dec 2023 18:59:09 +0000
From: Karl Fogel <kfogel@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#59580: 29.0.50; [PATCH] Add new choices to bookmark-sort-flag
In-Reply-To: <83le9qidl0.fsf@HIDDEN> (Eli Zaretskii's message of "Tue, 19 Dec
 2023 14:25:31 +0200")
References: <SJ0PR06MB8609C2D89667AC0EBADE93E48B0E9@HIDDEN>
 <83bkonilbm.fsf@HIDDEN> <87jzpbm6su.fsf@HIDDEN>
 <83le9qidl0.fsf@HIDDEN>
Date: Tue, 19 Dec 2023 12:59:07 -0600
Message-ID: <875y0urpc4.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; format=flowed
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 59580
Cc: 59580 <at> debbugs.gnu.org, gabriel376@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Reply-To: Karl Fogel <kfogel@HIDDEN>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On 19 Dec 2023, Eli Zaretskii wrote:
>> From: Karl Fogel <kfogel@HIDDEN>
>> Cc: Gabriel <gabriel376@HIDDEN>,  59580 <at> debbugs.gnu.org
>> Date: Mon, 18 Dec 2023 17:26:09 -0600
>> 
>> Regarding the use of `string-collate-lessp':
>> 
>> I think using `string-collate-lessp' makes sense here.  This is 
>> about sorted lists presented to the user, so the sorting should 
>> act according to locale (and when Emacs suspects that the 
>> locale 
>> wouldn't collate correctly, `string-collate-lessp' falls back 
>> to 
>> `string-lessp' anyway).
>
>It is IMO un-Emacsy to do things in locale-dependent manner. 
>Which
>other feature do you know of that sorts text in locale-dependent
>fashion?

I have no idea -- I doubt I would ever notice it if a feature did 
sort that way, since I'd be accustomed to that sorting behavior. 
I also don't see why such behavior is particularly un-Emacsy.  But 
I don't feel strongly about it; if you think `string-lessp' is 
better, let's use that.

Best regards,
-Karl

Message received at 59580 <at> debbugs.gnu.org:

Received: (at 59580) by debbugs.gnu.org; 19 Dec 2023 12:26:27 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Dec 19 07:26:27 2023
Received: from localhost ([127.0.0.1]:34550 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rFZB5-00083x-0f
	for submit <at> debbugs.gnu.org; Tue, 19 Dec 2023 07:26:27 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10]:46886)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1rFZB1-00083Q-UV
 for 59580 <at> debbugs.gnu.org; Tue, 19 Dec 2023 07:26:25 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1rFZAt-00021a-7i; Tue, 19 Dec 2023 07:26:15 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=X2yNDazWXB4nsZP94EX2/AEnmL+9aVKERemf2koVfZo=; b=Z4jgFNUMmN0p
 ryhgu5+oNQ3md1BFd8bo2tRYMBfWeYtmOWxfCRdyukGpW8WIIV/gHu0fSwqGytRDqq8xGr++UfmLq
 FgAESZjYoi2e0n7cpV5pDFahRe8Ekmv6VHu54HX32VgKojhHeCjG5PObENzu68VxE7yUuS0F4d6RV
 7Q32qxph9haAreUEvqjTEiFQBnRQcCC1PennGsEXt0x/mLeas/Ch+4DmMcX4s3A+00hhRTfNRCmUo
 a+P+2B7UvEmeolPpQZxDVTvd41O/Pkw/348bD4kRolC5uy+kq6CDmDBhSeqAw0EWE694h46TKi9nN
 OtAZE1zKfuMXTIvilCrbIA==;
Date: Tue, 19 Dec 2023 14:25:31 +0200
Message-Id: <83le9qidl0.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Karl Fogel <kfogel@HIDDEN>
In-Reply-To: <87jzpbm6su.fsf@HIDDEN> (message from Karl Fogel on Mon, 18
 Dec 2023 17:26:09 -0600)
Subject: Re: bug#59580: 29.0.50; [PATCH] Add new choices to bookmark-sort-flag
References: <SJ0PR06MB8609C2D89667AC0EBADE93E48B0E9@HIDDEN>
 <83bkonilbm.fsf@HIDDEN> <87jzpbm6su.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 59580
Cc: 59580 <at> debbugs.gnu.org, gabriel376@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Karl Fogel <kfogel@HIDDEN>
> Cc: Gabriel <gabriel376@HIDDEN>,  59580 <at> debbugs.gnu.org
> Date: Mon, 18 Dec 2023 17:26:09 -0600
> 
> Regarding the use of `string-collate-lessp':
> 
> I think using `string-collate-lessp' makes sense here.  This is 
> about sorted lists presented to the user, so the sorting should 
> act according to locale (and when Emacs suspects that the locale 
> wouldn't collate correctly, `string-collate-lessp' falls back to 
> `string-lessp' anyway).

It is IMO un-Emacsy to do things in locale-dependent manner.  Which
other feature do you know of that sorts text in locale-dependent
fashion?

So I still think using string-collate-lessp here is not the best idea.

Message received at 59580 <at> debbugs.gnu.org:

Received: (at 59580) by debbugs.gnu.org; 19 Dec 2023 00:45:07 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Dec 18 19:45:07 2023
Received: from localhost ([127.0.0.1]:33825 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rFOEM-0001LP-Qc
	for submit <at> debbugs.gnu.org; Mon, 18 Dec 2023 19:45:07 -0500
Received: from mx0a-00069f02.pphosted.com ([205.220.165.32]:9416)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <drew.adams@HIDDEN>) id 1rFOEJ-00017m-Lq
 for 59580 <at> debbugs.gnu.org; Mon, 18 Dec 2023 19:45:05 -0500
Received: from pps.filterd (m0333521.ppops.net [127.0.0.1])
 by mx0b-00069f02.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id
 3BJ0JGFt031066; Tue, 19 Dec 2023 00:45:00 GMT
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com;
 h=from : to : cc :
 subject : date : message-id : references : in-reply-to : content-type :
 content-transfer-encoding : mime-version; s=corp-2023-11-20;
 bh=aM0+OXp3PTK84x8B1mx0JYUJV95Ph19Q3vEgm70ejV8=;
 b=jztvQwhmrjuopD9YInKQGhpmSofqIEukRmLxpIhlrF35M/EeiS7LcsmxdroharJXz9ZJ
 djp8v00q1ItuMbpSJkepsypk5WI5i0Wekw9Ht8202d0+M8lIM0/TUwKvqGruIMaVBuDO
 P3EyslTS1VkmkpakzPJ7WV+/o8HWfVRCcv8rQNOlzVuPi3v4G49LzsV70hqWR6pw3egD
 T8kfSjLs7SV7G0obtT7IsvUvMkQC/1HzhdkdqvCObhl76DDjP76i9N4GU7Qm3sNg6nOp
 TkFr11G7jeE5dEeBfYj02NU2/jifrgPJd7j8q2YD8CfYeliThdvSl1af6oFFbg99z688 PA== 
Received: from phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com
 (phxpaimrmta03.appoci.oracle.com [138.1.37.129])
 by mx0b-00069f02.pphosted.com (PPS) with ESMTPS id 3v12tc4pky-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 19 Dec 2023 00:45:00 +0000
Received: from pps.filterd
 (phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com [127.0.0.1])
 by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (8.17.1.19/8.17.1.19)
 with ESMTP id 3BIMtWIk028994; Tue, 19 Dec 2023 00:44:59 GMT
Received: from nam10-mw2-obe.outbound.protection.outlook.com
 (mail-mw2nam10lp2101.outbound.protection.outlook.com [104.47.55.101])
 by phxpaimrmta03.imrmtpd1.prodappphxaev1.oraclevcn.com (PPS) with ESMTPS id
 3v12b5wsft-1
 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);
 Tue, 19 Dec 2023 00:44:59 +0000
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=cVTV9n0weJT4Vc25A2OF0i0cXG2U5cy4ZU89tvLwt1atfO0QnQzNGpWCA0i/7dInIvpxmFR2gNVmSc0Q5P2db5MyfzkBbM0SWhsrBOxHV8+H9sNsHnV4Yt31zYYn/BM2b00l51kfwFkt6FuETayUZVIa3f/qIWltM2Azr7sKH71EcycN3xbAdM+clopcGkaPvCwWD0fm8pxgtTP3KrgkGwP2jPb+9+JmntdgMpNSrVyEqAlfmqwpPVDoDXPjLgHoG4X60sDyEjb7x4pbsHE0tqGFmf7pRm9C4hXc5Gqsq0ubeMAmeIT292+nt+iCiLsxenkdoOKIrANDtz7GmmOV4A==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=aM0+OXp3PTK84x8B1mx0JYUJV95Ph19Q3vEgm70ejV8=;
 b=eYUwp7QnkoiS1DZmfbR2bnV/2R1MBDmFgggq8XajKGpntPdmb41KIIOlkpOaf6ZI6nij7k3sz4x3OUiA2e9flWPY7k1riVuqi0VgGwRA9khO4/kwPFOHRQ/vPf8+dtHAiMEApgW3OqA/0H6RDTkGYbHiqevGEO0o3qVoHCJmPco7ozWF01+t+Oxy0HUGs9hlRmuMofQH2VrLDnAru8CoGMT1MG8MDAAbiOwwiprBhnIse1RZ3guv1FYWJR7joBxLXSlFAp98jO2tps1CjraZohQQhC21BZiB3CWZ7Sc4ECaVH1tWu8waSPGqBi7OJc32nzTovnXxhYxVvsbD4OTe5A==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass
 smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com;
 dkim=pass header.d=oracle.com; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=aM0+OXp3PTK84x8B1mx0JYUJV95Ph19Q3vEgm70ejV8=;
 b=XHjK9fNwcUKQV/TF6+qRZyVmMrcnTMmH/nWSpgzrHotZSdn/KIFtIdFpTyZLwSB0WfpUoaTo4m9yVJdp2lUWb7lYRIjIJFvriajAJE+45TxEXp7i5N2vMQeeZWI+sSSbcuallfhh8KrY0yvac7oBndsHZLSnigJOkAMq9KL6SV0=
Received: from SJ0PR10MB5488.namprd10.prod.outlook.com (2603:10b6:a03:37e::19)
 by PH8PR10MB6526.namprd10.prod.outlook.com (2603:10b6:510:22a::20)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7091.37; Tue, 19 Dec
 2023 00:44:57 +0000
Received: from SJ0PR10MB5488.namprd10.prod.outlook.com
 ([fe80::3b4c:a669:c229:47b4]) by SJ0PR10MB5488.namprd10.prod.outlook.com
 ([fe80::3b4c:a669:c229:47b4%7]) with mapi id 15.20.7091.034; Tue, 19 Dec 2023
 00:44:57 +0000
From: Drew Adams <drew.adams@HIDDEN>
To: Karl Fogel <kfogel@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>
Subject: RE: [External] : bug#59580: 29.0.50; [PATCH] Add new choices to
 bookmark-sort-flag
Thread-Topic: [External] : bug#59580: 29.0.50; [PATCH] Add new choices to
 bookmark-sort-flag
Thread-Index: AQHaMgm/S5VwzDhaX0iHC0UaZ5FzYbCvwaMg
Date: Tue, 19 Dec 2023 00:44:57 +0000
Message-ID: <SJ0PR10MB5488544DCEB23E5A549D5211F397A@HIDDEN>
References: <SJ0PR06MB8609C2D89667AC0EBADE93E48B0E9@HIDDEN>
 <83bkonilbm.fsf@HIDDEN> <87jzpbm6su.fsf@HIDDEN>
In-Reply-To: <87jzpbm6su.fsf@HIDDEN>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: SJ0PR10MB5488:EE_|PH8PR10MB6526:EE_
x-ms-office365-filtering-correlation-id: 791009b2-9aac-4ac8-e5ea-08dc002bb972
x-ms-exchange-senderadcheck: 1
x-ms-exchange-antispam-relay: 0
x-microsoft-antispam: BCL:0;
x-microsoft-antispam-message-info: rZ/T10mG7PeqBFBuSwzxHk4k2ZDY1rVY6KdM5mE+qLcHHITqy+FmCoWXVFaJ+cTfhdHlhivwBT2sa8FbUheTlMrWwbt7Gvcn6EreVzLR/AlR9zJayWUeArXsogE2I8W2p6ssMjsep/LjRGcKckptIkHXRJHR4IP2n82UWA6YU587n1KszB5s5k3BNHS0V6wT5hXAR2TCZtCynua8DZ+qkFRui+O5z8laSGgaMVmROHbLM2+5FcrrWJ76r7jm5SeCT+QPiIog+u1SoOcWTpuEGByieaE7Ra6yv5ibtKzGyXECgohNm5/k5QbZu6NRfugvqkAdpMtIhNRj17Mc2UdTC/0tBcP38jc3HG3XwVFaGX2PJ378wAPbx8HtWUx2jMA/iLek9pMrKNbjUHH/1hcvW1q6tMDA0PVs5q1tJ/GkZCAtqlZDHtEk7JobelQWx/FcOJWyrTKTPQba3xu3ffiB9m0KxunLlqC6Tnsm/YcOjEZX9u11I0MyakVaKkFd79nEtf9g/d47puoNZzatiFZLVyulcLHe1i4HxesVi9pzC9LSa8gJiAWdU04ZtTPku308uoERXJhPqpnQZdwJxTWUm734u/b03/tud8F7vPtwquA=
x-forefront-antispam-report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;
 IPV:NLI; SFV:NSPM; H:SJ0PR10MB5488.namprd10.prod.outlook.com; PTR:; CAT:NONE;
 SFS:(13230031)(39860400002)(346002)(366004)(376002)(136003)(396003)(230922051799003)(451199024)(186009)(64100799003)(1800799012)(55016003)(38070700009)(54906003)(122000001)(86362001)(2906002)(4744005)(26005)(33656002)(6506007)(83380400001)(71200400001)(7696005)(38100700002)(9686003)(64756008)(966005)(66476007)(110136005)(5660300002)(41300700001)(66446008)(44832011)(316002)(52536014)(8936002)(478600001)(66556008)(66946007)(4326008)(8676002)(76116006);
 DIR:OUT; SFP:1101; 
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?6bHSSOPpiolC/VtkGrT8DC+zY17L5+8cZAT4IxqQFZLtWcumHl9/ATV/Uki3?=
 =?us-ascii?Q?WJXpjfl6U2/vdNhu0ARRQS4wvqQ3UZKWWv//t6M6eLyyDzxeRtfHCNUl+Mse?=
 =?us-ascii?Q?ja9TxBnuYHZIa9jYWv1Fy82gnoLgLCy8kbge9dbOvdlhdEPOVidwUwWHg9pA?=
 =?us-ascii?Q?wHgeAjNnQF1kEVM9eTmaYXiB8QeNZ27AP/FAox9AvyoRd/8PvXV7AdC2kco1?=
 =?us-ascii?Q?xvNqqCpikXQckcyEk36UBNV1K7TyEF3ASZLFxlyxAI+iiJDbCaQYQ8wO9qaM?=
 =?us-ascii?Q?jusu4yq6GsMEbH5ZaB5dSMoIKDCdey+3zJHzoB0y5HFrgDtXPMw+i/5GC8dY?=
 =?us-ascii?Q?fJFlE3you9qz3l5d9DvLu3+PdwJFlyC9mrOAJywSfwBDKKf4XQQX5l4LHwUq?=
 =?us-ascii?Q?BY/ZYlWgCGrfxI/xm6O4KS94piRIcQ2+85swdZPGkMpTVX6F/wxn1TNZrMoD?=
 =?us-ascii?Q?3Yg/+I4oP3vEqhpOOoSg0cdGvvpF1Yn1Nzs/YQWmbiwaA2aTCY8Il3RNwQU9?=
 =?us-ascii?Q?pFadkLd17Hp7lhOkkLLu1+mmkzxMcD2q1KsmguQRI6Iy7y8FRLeUQFKwfqGE?=
 =?us-ascii?Q?y4XegBbzITnCRoSLsazdvgSzNvP4lK7wi6TqioH92CsfQIJ23N30SKS58Ozd?=
 =?us-ascii?Q?jXEd1QPHXjygd5+TKJq688yjv+AEkZmuEtxiSL7eE4tquGEF/oEY6cbtxqY5?=
 =?us-ascii?Q?j46UbyES9ivKNE5/u49IgXiqnx65xeIil8JjXwSXwyemHZEqWUff5WfgQCyS?=
 =?us-ascii?Q?H1eM89re/BIRQSEJ1ME6EUIpxHlvOAmrjDlhMCVp0j0M9OiwsomqTfp22FIY?=
 =?us-ascii?Q?6QH9NSpxuR5BMA1wraAQac9htLSQzJQ+T3NSRNlZ2U7Feb+4gcaPk+Nm86Be?=
 =?us-ascii?Q?4I/Vf19i7soPX8DtiIWWzFU5O4U7BpujrWLHvlyndVJL4UqqDlC8BLI63+Sf?=
 =?us-ascii?Q?ETB/c2KVvG4zOY5swLNQgI0DY7DECYTd6DUpBdCn3UZtc8FHE/8mnxMCDQfD?=
 =?us-ascii?Q?hJHhA69TWxf+JcvWXzA0Z3ecXTA8aAp9f5bdMGQzDWsaD6fukMTVEnmJW9vZ?=
 =?us-ascii?Q?v1OgYFWiy9kA57V9YijAFCJUgyYDquRARSSEOQjyRzmKPCH01/fhkyWUSz12?=
 =?us-ascii?Q?XU9qKHeHqreWN6qC1skIaEUNyoTghIRCeEwqXdBPj7fZzyKJvgulYjLc7sH0?=
 =?us-ascii?Q?+7APZwSSje8Bfy1h/soj0H86MSiz3DTDbntmzz06lVOMl2eZuTVV1LZwcmyh?=
 =?us-ascii?Q?NE4PQEwk3lFqLkYULl6GSmCONkOIJI7zOKFH9zpxZSNuHT/Y+hu1tIyv3WyQ?=
 =?us-ascii?Q?Sc9L3rZm2BayQvy27AJY0N9mcatNbDn9oKV17X7VZ4Nw9T7sZyJEi0mWcfcH?=
 =?us-ascii?Q?AtU3P6tp62LXocAtoeQA2usi1rFbtoHVCK12uLJqF2iqzOi3r8w9AIDK9Ess?=
 =?us-ascii?Q?c+QVu+P2YExL+Ixu+AZYx1qwW8YsHuU5AQ3qfAc34+wBrPlKlDvGzCVL5f1P?=
 =?us-ascii?Q?iSGlNKd9Lgm/sxuizlWkOAZHbR+ohTbLOf/zEjh2JyPDL62uFfSNvbsLE1sz?=
 =?us-ascii?Q?4s/hp0Z9KHVMWpXjjJdR+qqHnCy/l9QG/ptoLtgR?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: pSyusJDXTqsKLOXANnDYB94E0zEYx1FfSY43FDHiu2BCPAOVu1iWA9CqjxIBC8xz6CZeB4hIYQcJM7SlUPomLajLDH668egx7XvDnIZiiyFiyx0+1/SU1h2NtgzDr30B8QS/v2j0Q8CTHirxJQB9MpIy+DpimNjGZJNKgcJ/8xFFnLgHXujeKHGT3eDEzDeUDKG5JlL+B3I2mkwN4B4sCCFb6XGevXH+KkPQyZ37wmDbLEDS/Ndk09P64t91oJ/HNtYzOVKy+7vCLrk6c+vzPKtq0TMQ2Q8APVKAcM/BJqmymI5V2uZ2rjRxTksTs/IwsLy7AA0bpc3rkgaPiwlx52nmeZ0gOGnEJsT+GE0xAi+X4wHzd2mIm1dFONXez6Us2tOVDHY7YQLv2HuGulSocO+1H76d1FCmB1geAO46kqXCkSnOCwOJs3cqr0t1Snn4eUo18RnidZCOdRuYoTwfL5RNNm9c+WMDGOuyUz01NyMmMJN9cKrYLGW3MOpBkPq4Ehg9ExT6+0exXeNiUOXdvRZobxdgepb66taBhLOlAwRkKNoOXhlv8pQUCUsc56dg/uhVXUYoiMVsTer/WgFlbdnxfniHsFXRqMhK/+8Pd/8=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR10MB5488.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 791009b2-9aac-4ac8-e5ea-08dc002bb972
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Dec 2023 00:44:57.4080 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: L3i6ocRJmp2CWa73XU63iRz/nYi9FBacFSUXfZXKhNK9HRnaJYhOkKJS/QcfcJ0rpA/AdY72DlCkl9BfoSr4sg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR10MB6526
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2023-12-18_15,2023-12-14_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=665
 adultscore=0
 malwarescore=0 phishscore=0 mlxscore=0 bulkscore=0 spamscore=0
 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2312190004
X-Proofpoint-ORIG-GUID: O8JcVEp_mJPpD9uYHSQixOIEchk0_W4B
X-Proofpoint-GUID: O8JcVEp_mJPpD9uYHSQixOIEchk0_W4B
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 59580
Cc: "59580 <at> debbugs.gnu.org" <59580 <at> debbugs.gnu.org>,
 Gabriel <gabriel376@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

FWIW -

An option name `*-flag' is explicitly
intended to signify a Boolean option.
"Adding more choices" to such an option
should entail renaming it.

As for bookmark sort orders, there are
many more that make sense - see here for
several that are predefined, and for how
users can easily combine them or define
their own:

https://www.emacswiki.org/emacs/BookmarkPlus#SortingBookmarks

(Related:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D39293#8)

Message received at 59580 <at> debbugs.gnu.org:

Received: (at 59580) by debbugs.gnu.org; 18 Dec 2023 23:26:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Dec 18 18:26:16 2023
Received: from localhost ([127.0.0.1]:33797 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1rFN04-0002LD-5m
	for submit <at> debbugs.gnu.org; Mon, 18 Dec 2023 18:26:16 -0500
Received: from sanpietro.red-bean.com ([45.79.25.59]:55514)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <kfogel@HIDDEN>) id 1rFN01-0002Kw-Gn
 for 59580 <at> debbugs.gnu.org; Mon, 18 Dec 2023 18:26:14 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
 d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID:Date:
 Reply-To:References:In-Reply-To:Subject:Cc:To:From:Sender:
 Content-Transfer-Encoding:Content-ID:Content-Description;
 bh=QOlKRJgw6WGTBQDlDsa2hXCpw4Vu8lrhbqHYoicyWvM=; t=1702941971; x=1704151571; 
 b=OxZR6DRMCvPXiERXlq/mzYAvtluAvyqy9hy4Rdjs09GhHgEUhslIdp1zqApwn17vhcod9Oq4f1U
 GVkOMT9ecbTG5+6CtR8cfjp6pGHYQ+iOJVq6vYMvFOwn/XlnbNuaCctLc1xvhVJ7xuuJUEnVjm9pL
 6/9tG3R8prtKrPIVpZ2ORFce/AYuuno5FCAnk/1R75RwrhsnGdQs4lYDH/cZ0fxQ7jhi/1K6qnYVR
 0iSgRFWJ9Hii/IELE+vWxpJN2aokGOPcB0sdq8XUYEirgkLl3tzOd3gkVWrL6khdXWKa1CZpu9U5X
 1R1bJIgDuFRK+mbpXolxLbRTtWJWRUprGNQw==;
Received: from [12.106.183.66] (port=38032 helo=hummy)
 by sanpietro.red-bean.com with esmtpsa (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2)
 (envelope-from <kfogel@HIDDEN>)
 id 1rFMzx-007hNx-SV; Mon, 18 Dec 2023 23:26:09 +0000
From: Karl Fogel <kfogel@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#59580: 29.0.50; [PATCH] Add new choices to bookmark-sort-flag
In-Reply-To: <83bkonilbm.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 01 Dec
 2022 10:23:41 +0200")
References: <SJ0PR06MB8609C2D89667AC0EBADE93E48B0E9@HIDDEN>
 <83bkonilbm.fsf@HIDDEN>
Date: Mon, 18 Dec 2023 17:26:09 -0600
Message-ID: <87jzpbm6su.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; format=flowed
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 59580
Cc: 59580 <at> debbugs.gnu.org, Gabriel <gabriel376@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Reply-To: Karl Fogel <kfogel@HIDDEN>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

On 01 Dec 2022, Eli Zaretskii wrote:
>> From: Gabriel <gabriel376@HIDDEN>
>> Date: Fri, 25 Nov 2022 15:26:49 -0300
>> 
>> Add new choices 'type and 'file to `bookmark-sort-flag'.  See 
>> [1].
>> 
>> Notes:
>> 
>> 1) It feels strange to have value t meaning 'name and value nil 
>> meaning
>> 'creation-time, but it's better to not change how things have 
>> been
>> working for many years.  A more flexible approach could offer a 
>> custom
>> function as a choice of `bookmark-sort-flag'.
>> 
>> 2) I took the liberty to update some comments and docstrings, 
>> please
>> review.
>> 
>> 3) I took the liberty to remove some code in 
>> `bookmark-bmenu-mode' that
>> seems to be unnecessary, please review.  Everything seems to be 
>> working
>> as expected according to my tests.  I can also write some 
>> tests.
>> 
>> 4) Used `string-collate-lessp' in `bookmark-maybe-sort-alist' 
>> to match
>> `bookmark-bmenu--*-predicate' functions.
>
>Is it really a good idea to use string-collate-lessp here?  Its 
>effect
>depends on the underlying OS and the user's locale, so it could 
>produce
>different and sometimes surprising results.  Why isn't 
>string-lessp
>sufficient?  IMO, at the very least, the fact that the sorting is
>locale-dependent should be prominently stated in the doc string. 
>Also, see
>the notes in the string-collate-lessp's doc string about 
>MS-Windows, and
>maybe do what it suggests (if we decide to keep 
>string-collate-lessp here).
>
>Karl, any comments?

I finally had a chance to look more closely at this.

First, overall very nice job on the patch, Gabriel.  You took care 
to strike a balance between, one the one hand, cleaning up things 
that directly touched your changes and, on the other hand, not 
causing unnecessary churn.

Regarding the use of `string-collate-lessp':

I think using `string-collate-lessp' makes sense here.  This is 
about sorted lists presented to the user, so the sorting should 
act according to locale (and when Emacs suspects that the locale 
wouldn't collate correctly, `string-collate-lessp' falls back to 
`string-lessp' anyway).

However, it would be good to:

  - Bind `w32-collate-ignore-punctuation' to non-nil

  - Pass optional arg IGNORE-CASE to `string-collate-lessp'

These two things would result in the behavior(s) that the user is 
most likely to expect, I believe.

If we later learn that people want more control over these 
behaviors, then we could make control variables -- something like, 
e.g., `bookmark-sort-w32-collate-ignore-punctuation' and 
`bookmark-sort-ignore-case'.  But it would be premature to offer 
those right now.  Let's start by choosing reasonable defaults and 
see if people are fine with that.

Thoughts?

The patch is a bit out-of-date now: The diff againt 'etc/NEWS' 
depends on context that has now moved to 'etc/NEWS.29'.  The diff 
against 'bookmark.el' applies cleanly, however, just with some new 
offsets due to things having shifted around.

Best regards,
-Karl

Message received at 59580 <at> debbugs.gnu.org:

Received: (at 59580) by debbugs.gnu.org; 19 Dec 2022 21:00:40 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Dec 19 16:00:39 2022
Received: from localhost ([127.0.0.1]:40372 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1p7NFX-0007UJ-IB
	for submit <at> debbugs.gnu.org; Mon, 19 Dec 2022 16:00:39 -0500
Received: from sanpietro.red-bean.com ([45.79.25.59]:39242)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <kfogel@HIDDEN>)
 id 1p7NFR-0007U3-Jp; Mon, 19 Dec 2022 16:00:37 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
 d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID:Date:
 Reply-To:References:In-Reply-To:Subject:Cc:To:From:Sender:
 Content-Transfer-Encoding:Content-ID:Content-Description;
 bh=DpCSEC1UBB6tofhAfNGMErW9TUvkrbPeMRNnoS791RI=; t=1671483633; x=1672693233; 
 b=Et1KVcFwemLGa/IIFHLewwAxNckppMIk9cQOcIE/0/WxDz4ZTlGhTdqUc+I3V5vTTvZnlSJ1tjT
 PGnmDt3+lbSQsgvOnUbnL17ZnaRResFLf2vwvgR7iowaOjKgBvWUVYJa46Sfb9WDAiI54Zasc9g/G
 6SfqF9L48LhB5Ez9/1fGURQ3T7Yky73dESYV3RHhGw+KwuZipM9mklHDb8bsftcQbkZ9RX4DTKsSD
 aXAPjR/zmveLMCH0m81n8H91cwtrgwqUeDXHKUGBk/wwcg6I3kdO4/DHRonhC8Vs3UpRylNyWk6LJ
 uz+V4ji2uN3HJ5tXDkA6TjQ3laNbBVXT6yxA==;
Received: from 99-112-125-163.lightspeed.cicril.sbcglobal.net
 ([99.112.125.163]:46434 helo=floss)
 by sanpietro.red-bean.com with esmtpsa (TLS1.3) tls
 TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2)
 (envelope-from <kfogel@HIDDEN>)
 id 1p7NFO-00Fkj6-Pz; Mon, 19 Dec 2022 21:00:30 +0000
From: Karl Fogel <kfogel@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#59580 and bug#59581
In-Reply-To: <83bkonilbm.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 01 Dec
 2022 10:23:41 +0200")
References: <SJ0PR06MB8609C2D89667AC0EBADE93E48B0E9@HIDDEN>
 <83bkonilbm.fsf@HIDDEN>
Date: Mon, 19 Dec 2022 15:00:26 -0600
Message-ID: <87wn6nhzx1.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; format=flowed
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 59580
Cc: 59580 <at> debbugs.gnu.org, Gabriel <gabriel376@HIDDEN>,
 59581 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Reply-To: Karl Fogel <kfogel@HIDDEN>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

I am just seeing tickets #59580 and #59581 now.  I will review the 
patches as soon as I can and reply back.  This won't be till the 
end of the week, however, as I am traveling before then and won't 
have much working time while on the road.

Thanks for the patches Gabriel, and thanks for the ping, Eli.

Best regards,
-Karl

Message received at 59580 <at> debbugs.gnu.org:

Received: (at 59580) by debbugs.gnu.org; 1 Dec 2022 08:24:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Dec 01 03:24:20 2022
Received: from localhost ([127.0.0.1]:38239 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1p0erj-0006Jd-VD
	for submit <at> debbugs.gnu.org; Thu, 01 Dec 2022 03:24:20 -0500
Received: from eggs.gnu.org ([209.51.188.92]:40352)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <eliz@HIDDEN>) id 1p0erh-0006JW-33
 for 59580 <at> debbugs.gnu.org; Thu, 01 Dec 2022 03:24:18 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1p0era-0005OE-Sd; Thu, 01 Dec 2022 03:24:10 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
 s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
 mime-version; bh=mGrtEXMdJYKOv4uTt6e1ldSAX3mANqeo3w5vQPdGfDg=; b=Dyu5ruKW9tXv
 1kSHALoSKi6IrUB69PEpq9NDJdDinbWKC/YJQnpGMbVTAxQ3CxIzFMD7Lx0TUepkuzTkllxYJchxS
 q7ciw11W8O4FHrUXlPJOVo3vl0UDMk7FQv9MOEkUdnDouU9QJCHw9W7j38Nbd4RXWWpGLT7H0lw9E
 9Cv5tYdzxX6wnZnIAlacnBtAD9tbGhvURzhhOSgPXsxUGn5HEjFvBgSzpk7htlPVHbFuFtb1DJ9Md
 C1Gis9p0zbCj37eAKkTQWjXYrR+kRmbLAlpOpIOIBqiA6ewPtk7+thq625PxoL43EG+M3KBx+TFZY
 BmYlXefEQsjOuJDKHxWokw==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
 by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
 id 1p0era-0006ad-AM; Thu, 01 Dec 2022 03:24:10 -0500
Date: Thu, 01 Dec 2022 10:23:41 +0200
Message-Id: <83bkonilbm.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
To: Gabriel <gabriel376@HIDDEN>, Karl Fogel <kfogel@HIDDEN>
In-Reply-To: <SJ0PR06MB8609C2D89667AC0EBADE93E48B0E9@HIDDEN>
 (message from Gabriel on Fri, 25 Nov 2022 15:26:49 -0300)
Subject: Re: bug#59580: 29.0.50; [PATCH] Add new choices to bookmark-sort-flag
References: <SJ0PR06MB8609C2D89667AC0EBADE93E48B0E9@HIDDEN>
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 59580
Cc: 59580 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

> From: Gabriel <gabriel376@HIDDEN>
> Date: Fri, 25 Nov 2022 15:26:49 -0300
> 
> Add new choices 'type and 'file to `bookmark-sort-flag'.  See [1].
> 
> Notes:
> 
> 1) It feels strange to have value t meaning 'name and value nil meaning
> 'creation-time, but it's better to not change how things have been
> working for many years.  A more flexible approach could offer a custom
> function as a choice of `bookmark-sort-flag'.
> 
> 2) I took the liberty to update some comments and docstrings, please
> review.
> 
> 3) I took the liberty to remove some code in `bookmark-bmenu-mode' that
> seems to be unnecessary, please review.  Everything seems to be working
> as expected according to my tests.  I can also write some tests.
> 
> 4) Used `string-collate-lessp' in `bookmark-maybe-sort-alist' to match
> `bookmark-bmenu--*-predicate' functions.

Is it really a good idea to use string-collate-lessp here?  Its effect
depends on the underlying OS and the user's locale, so it could produce
different and sometimes surprising results.  Why isn't string-lessp
sufficient?  IMO, at the very least, the fact that the sorting is
locale-dependent should be prominently stated in the doc string.  Also, see
the notes in the string-collate-lessp's doc string about MS-Windows, and
maybe do what it suggests (if we decide to keep string-collate-lessp here).

Karl, any comments?

Thanks.

Message received at submit <at> debbugs.gnu.org:

Received: (at submit) by debbugs.gnu.org; 25 Nov 2022 18:27:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Nov 25 13:27:06 2022
Received: from localhost ([127.0.0.1]:37139 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oydPl-0003R0-UX
	for submit <at> debbugs.gnu.org; Fri, 25 Nov 2022 13:27:06 -0500
Received: from lists.gnu.org ([209.51.188.17]:45364)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <gabriel376@HIDDEN>) id 1oydPh-0003Qd-K0
 for submit <at> debbugs.gnu.org; Fri, 25 Nov 2022 13:27:04 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <gabriel376@HIDDEN>)
 id 1oydPg-0008F8-IT
 for bug-gnu-emacs@HIDDEN; Fri, 25 Nov 2022 13:27:00 -0500
Received: from mail-bn8nam11olkn2010.outbound.protection.outlook.com
 ([40.92.20.10] helo=NAM11-BN8-obe.outbound.protection.outlook.com)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <gabriel376@HIDDEN>)
 id 1oydPe-0003du-6B
 for bug-gnu-emacs@HIDDEN; Fri, 25 Nov 2022 13:27:00 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
 b=YT2HadG+fwynudeZuATcRp6e03IaLYIZFxyr4ekaRwgvXuXKXuzXxsyKJlwL3LrchWU8phX1KIoa2m/CFb7ye2OyvWaOk2Fe14gItwIvMCnEwvYSwhND5cRBmyBMEcWbbEf2XTvDSnBN2edf4qKcwf7dAnokMaevEuuKpUi1iGu+z3QVk6IAPRCsCV8wTky4cIzUB4SY3wLyDGbkYWJHs1a7fsZyBSgMOh4y1Cn8Xool1ghU8eYIpYSNNrpEDLSRXJKIjT7kU3u9d7mLI272f+tTtPuq2XLcQNcVp+29u66KWsjgwD4/TnJjdRVg/bL3eAksjvqO5kC5HAefV1d4aA==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; 
 s=arcselector9901;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
 bh=FXwsf5cAXiCL0VkhjUQMZCAGvbX72Ohu7IcC6TJhFYk=;
 b=i425YuahzDGrAO4zNCmvomJ5cDan83ZyCmKxC2FZ8Hux0vr0v/Rj2vvNFpqYKADErnr5vCVP5SuL/6RvH7QPtlgBS3BYj0a2MIXQYi7UzaWZl9T8vBztgKxrewf4KBAHZcDNvQ0teGDmr8JP6/ZmtOt8EwRTQY5GxnrUHCj9C3HbbrCBgSPiOeaUacypu7/TEszU1umbXC84OK/SwE5QRKKz8ej5dC4blQt2y2bA8vCcn3WhmpZTWzyP/g32QVTsoj85yw6mgFsF0fQVzJQy20VQw1gHQWo4qVQ4vg9Yy2FxablzTI1qQMLvsHybJMKRaldUobNG3tGRx5TCLd7Rog==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
 dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com;
 s=selector1;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=FXwsf5cAXiCL0VkhjUQMZCAGvbX72Ohu7IcC6TJhFYk=;
 b=kLPXLXb9jOOWGMEk6hDhF49A7xv5mjETYQtfT4mn1d8T3VYTHuAvH6oaxpO4haEmmREv+GRbsovvpx5ZBRYwAJ8UJxCHhB22YIamtIOIarCcI6n74x9RsAihIp0cpFwMm7DiDA/3xgwls91qzT/Nb8WZaeuAV1BUHWcOhfjjEtZNoSKH+hZ5yU8wobCM5zQ6gvh8LHlX2UUeHzXPrKHybDy0YpKvPlFueUXpPDiAG4GV2IeckzYzJLYMh2koIqL6DC4DIxFidtwf7oPjeVNweBlguzAHLcmkQ3s1GjExNlALivTmwKEVIo1+LxI5zFPv/NvSxu9iCrfGbz9GjPOocg==
Received: from SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11)
 by BYAPR06MB4646.namprd06.prod.outlook.com (2603:10b6:a03:41::12)
 with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Fri, 25 Nov
 2022 18:26:55 +0000
Received: from SJ0PR06MB8609.namprd06.prod.outlook.com
 ([fe80::33ae:d3a7:24ae:5c6f]) by SJ0PR06MB8609.namprd06.prod.outlook.com
 ([fe80::33ae:d3a7:24ae:5c6f%5]) with mapi id 15.20.5880.005; Fri, 25 Nov 2022
 18:26:55 +0000
From: Gabriel <gabriel376@HIDDEN>
To: bug-gnu-emacs@HIDDEN
Subject: 29.0.50; [PATCH] Add new choices to bookmark-sort-flag
Date: Fri, 25 Nov 2022 15:26:49 -0300
Message-ID: <SJ0PR06MB8609C2D89667AC0EBADE93E48B0E9@HIDDEN>
Content-Type: multipart/mixed; boundary="=-=-="
X-TMN: [vvrsjYpo1S4CK0iOdepVYazHtJUI4rSuvX1srY8xxJfOQ4/VMIPLpf2PxYnpJjRt]
X-ClientProxiedBy: CP3P284CA0124.BRAP284.PROD.OUTLOOK.COM
 (2603:10d6:103:6a::9) To SJ0PR06MB8609.namprd06.prod.outlook.com
 (2603:10b6:a03:40c::11)
X-Microsoft-Original-Message-ID: <87wn7ic2l2.fsf@HIDDEN>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR06MB8609:EE_|BYAPR06MB4646:EE_
X-MS-Office365-Filtering-Correlation-Id: b9231a89-b3fe-45ee-fe70-08dacf12a125
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: mgFOYMDi7rdpH4KogVF2ZGyxLDZGqtVMY1pHEWVfLQff6MYNJ6l0DWi6IC5F28MGrstZED36xlUEivEsreDZeGF5xUQ3fyYRxC8H4a55BsnjvO9RegjwkLzXW2dgxFz+C2+tWt2rUzOWSbByShLUZZ2J5HfIRJnz5e0H2oXu9fHu++J7gcNNeBNQBL7FIvpWXCcyzKSbYnP8gHgmEyE56xLKc37mlFtgprB5ke+GE+i7y2TNfhthE80h0a0fmuL2etzcWNkQ/aQfKTJ9sy4mBYx+CQ4+D3VTxsupvFBoxFCgaTt9IGxb/+1wnljgJ6atleHwa47FBfOQmVwpzKuLROirU1ZRxeTPWuWlbRA6Ml2uJMoicz5WeG35hm0VYnepkIyzedOnCWNPOBZMeG4Ggs5I5agNKXQ6WNogG8VcZikwU9ZaBkEHFR/dfO4sslMMi9BhKKT8pbLf0y/mQy2Tc/lWqCr0yPSKF37FGgKCWOZ+VN4BnzmjB/Hxjd0gu9y41mfHYMedY5wNXARCESeyP0G0uui4hTHfstsMCpStmQovUVaqBXKDW0OwYpGyMFlPJT46JlGJJ8g5tzQiulKRMHox0ril1nl6eHHejvoBUag=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?TQv8XoPj0B7HLS3rmOCD+32t/zCY52NQPuXOLKiI5rybP525dqKT9ZypNObN?=
 =?us-ascii?Q?a5BqV0g5RpHDuGKvuRAINGOy8kC97r8xOMCQPPveei8VIblVDUecz9t1fIc4?=
 =?us-ascii?Q?UPG71Qw8r8ti2ib4+bBGWW6Srwdz4pIj2DVLQCrASshLyxOMET24FU4oNY2h?=
 =?us-ascii?Q?dcWM0ce4oC2CsPxTPpNmvrNcyYr17EnFGj3/EiC0tka7rL8+RUTjY6pro5IO?=
 =?us-ascii?Q?EMYame7n3BHgasegHjz+qK+2GlRQeUf3O9g7qed70gE7kVwxOfp2IXOiJZRW?=
 =?us-ascii?Q?GWx7mRBsQQ/RjPvGENDa/jbxtHx2NjPQl63ocdYOsP8031+zy4zL4DIEF29X?=
 =?us-ascii?Q?I7gCKnKHvxQy1dNneCmyEm+DVomp9rowO8bUU3C9KpiDJjWV04swUZcjwVMT?=
 =?us-ascii?Q?Qr0erhlZS0N6B+5ZSA63+YHCy2s/DddnHVh51/+wCd4UouqLzoNBfLEP9z5W?=
 =?us-ascii?Q?pAaybFe28GC6wuoJNdZKLcPd08wGaIy3V8O90vPS48Eldvo2jD5NeRkkBgg1?=
 =?us-ascii?Q?emxeLuO2DnIKvPeCL0o4o2XdYYDfN+z6Nohy1dJUSnI+2A95j7xPtLLyR01R?=
 =?us-ascii?Q?S4lW3Gi0nENyqFSvUGnDiQl2ZwQpQKOIuub25uaLiSG+7DAW+mbVrriv16+Y?=
 =?us-ascii?Q?xjER50XniIp1EWMHX+SYDgWtEN4lF44PMPV66Kp0V030M+mnooC9IOB/Jqcs?=
 =?us-ascii?Q?MM+WluDjHjWb1+IIcWwNmDrrusu5rrNaS9zR/EA527Dvt4GokCGIP7cEYSGn?=
 =?us-ascii?Q?DSuE/h22tXAsymBF/1j4u1FB2C6KBcBQV2bE1Sm23b3Gby9dQu8K4eCVHyzW?=
 =?us-ascii?Q?R/w/FNX+mp2EK2vKVuODkLQM0Z8dW976Wyc8zarDy8UQX+j+sWLvIu6bzqaX?=
 =?us-ascii?Q?L67nN3t0P3OJUW/e8CR5RP7l5WQbNTDiyrOAgTmTg5TWkHZGYPI7zz2ezBie?=
 =?us-ascii?Q?TiHBKHqS5Vmk9GKpHQYeniyj8QnwFgpI4EkKRdkf7jsVEA0+8dAqUVHKcDoG?=
 =?us-ascii?Q?ZDD9fwXNZWd/KXiKnYhkHA6X/bS/UQDVkWeWFNpbtCnBdNhWRngNsRmaNWS6?=
 =?us-ascii?Q?rFqu597W5m9iXUipfeawttODrM4JJGIsyEFIyAGM8x8foQJPCSBN2xflFwCp?=
 =?us-ascii?Q?g/RZS7hawztvMhIe5tbq7Q3pbsYppVcI5oxBJbwuu860M33eiQ5z7dOnFAMx?=
 =?us-ascii?Q?bm1A8kp8E6e7F9Dk0bz55D4Zxun4eVlkJeBX/X3l+PzulvvsSR2CwuQyjLad?=
 =?us-ascii?Q?bRIptLt3FdWReifo8WE/CnaQVmn5kvE9fxyy2q58PeLtkMZLypG3rp2txmxM?=
 =?us-ascii?Q?0KpIw/o2o9QCRPMALhZdLmAi9Gxxc1Fje9A2Re0jMZqyXQ=3D=3D?=
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-89723.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: b9231a89-b3fe-45ee-fe70-08dacf12a125
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR06MB8609.namprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2022 18:26:55.2295 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BYAPR06MB4646
Received-SPF: pass client-ip=40.92.20.10; envelope-from=gabriel376@HIDDEN;
 helo=NAM11-BN8-obe.outbound.protection.outlook.com
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.1 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.1 (--)

--=-=-=
Content-Type: text/plain

Severity: wishlist

Description:

Add new choices 'type and 'file to `bookmark-sort-flag'.  See [1].

Notes:

1) It feels strange to have value t meaning 'name and value nil meaning
'creation-time, but it's better to not change how things have been
working for many years.  A more flexible approach could offer a custom
function as a choice of `bookmark-sort-flag'.

2) I took the liberty to update some comments and docstrings, please
review.

3) I took the liberty to remove some code in `bookmark-bmenu-mode' that
seems to be unnecessary, please review.  Everything seems to be working
as expected according to my tests.  I can also write some tests.

4) Used `string-collate-lessp' in `bookmark-maybe-sort-alist' to match
`bookmark-bmenu--*-predicate' functions.

[1] https://lists.gnu.org/archive/html/emacs-devel/2022-11/msg00995.html


--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment;
 filename=0001-Add-more-choices-to-bookmark-sort-flag.patch

From c41d0990774a39a942e645aeaaec1126de419db1 Mon Sep 17 00:00:00 2001
From: Gabriel do Nascimento Ribeiro <gabriel376@HIDDEN>
Date: Fri, 25 Nov 2022 15:06:58 -0300
Subject: [PATCH 1/1] Add more choices to bookmark-sort-flag

* lisp/bookmark.el (bookmark-sort-flag): Add new choices 'type and
'file.
(bookmark-maybe-sort-alist, bookmark-bmenu-mode): Handle new choices
of `bookmark-sort-flag'.
(bookmark-bmenu-mode): Update docstring and remove unnecessary code.

* etc/NEWS: Announce the changes.
---
 etc/NEWS         |  5 ++--
 lisp/bookmark.el | 69 +++++++++++++++++++++++-------------------------
 2 files changed, 35 insertions(+), 39 deletions(-)

diff --git a/etc/NEWS b/etc/NEWS
index 0ffc849fec..acd0ed1d6e 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -2554,9 +2554,8 @@ Types are registered via a 'bookmark-handler-type' symbol property on
 the jumping function.
 
 +++
-*** 'bookmark-sort-flag' can now be set to 'last-modified'.
-This will display bookmark list from most recently set to least
-recently set.
+*** 'bookmark-sort-flag' now accepts more choices.
+It now accepts the values 'type', 'file' and 'last-modified'.
 
 ---
 *** When editing a bookmark annotation, 'C-c C-k' will now cancel.
diff --git a/lisp/bookmark.el b/lisp/bookmark.el
index 7f3a264f53..084f7450fe 100644
--- a/lisp/bookmark.el
+++ b/lisp/bookmark.el
@@ -38,13 +38,6 @@
 (require 'fringe) ; for builds --without-x
 (eval-when-compile (require 'cl-lib))
 
-;;; Misc comments:
-;;
-;; The bookmark list is sorted lexically by default, but you can turn
-;; this off by setting bookmark-sort-flag to nil.  If it is nil, then
-;; the list will be presented in the order it is recorded
-;; (chronologically), which is actually fairly useful as well.
-
 ;;; User Variables
 
 (defgroup bookmark nil
@@ -116,16 +109,16 @@ bookmark-completion-ignore-case
 
 
 (defcustom bookmark-sort-flag t
-  "This controls the bookmark display sorting.
-nil means they will be displayed in LIFO order (that is, most
-recently created ones come first, oldest ones come last).
-
-`last-modified' means that bookmarks will be displayed sorted
-from most recently modified to least recently modified.
+  "Controls the bookmark display sorting.
 
-Other values means that bookmarks will be displayed sorted by
-bookmark name."
+A value of t means to display bookmarks sorted by name.  A value
+of `type' means to display bookmarks sorted by type.  A value of
+`file' means to display bookmarks sorted by file.  A value of
+`last-modified' means to display bookmarks by modification time.
+A value of nil means to display bookmarks by creation time."
   :type '(choice (const :tag "By name" t)
+                 (const :tag "By type" type)
+                 (const :tag "By file" file)
                  (const :tag "By modified time" last-modified)
                  (const :tag "By creation time" nil)))
 
@@ -524,14 +517,22 @@ bookmark--remove-fringe-mark
                 (delete-overlay (setq found temp))))))))))
 
 (defun bookmark-maybe-sort-alist ()
-  "Return `bookmark-alist' for display.
-If `bookmark-sort-flag' is T, then return a sorted by name copy of the alist.
-If `bookmark-sort-flag' is LAST-MODIFIED, then return a sorted by last modified
-copy of the alist.  Otherwise, just return `bookmark-alist', which by default
-is ordered from most recently created to least recently created bookmark."
+  "Return a copy of `bookmark-alist' for display.
+
+The sort order is controlled by `bookmark-sort-flag'."
   (let ((copy (copy-alist bookmark-alist)))
     (cond ((eq bookmark-sort-flag t)
-           (sort copy (lambda (x y) (string-lessp (car x) (car y)))))
+           (sort copy (lambda (x y)
+                        (string-collate-lessp  (bookmark-name-from-full-record x)
+                                               (bookmark-name-from-full-record y)))))
+          ((eq bookmark-sort-flag 'type)
+           (sort copy (lambda (x y)
+                        (string-collate-lessp (bookmark-type-from-full-record x)
+                                              (bookmark-type-from-full-record y)))))
+          ((eq bookmark-sort-flag 'file)
+           (sort copy (lambda (x y)
+                        (string-collate-lessp (bookmark-location x)
+                                              (bookmark-location y)))))
           ((eq bookmark-sort-flag 'last-modified)
            (sort copy (lambda (x y)
                         (let ((tx (bookmark-get-last-modified x))
@@ -1903,6 +1904,12 @@ bookmark-bmenu--revert
     (cond ((eq bookmark-sort-flag t)
            (setq tabulated-list-sort-key '("Bookmark Name" . nil)
                  tabulated-list-entries entries))
+          ((eq bookmark-sort-flag 'type)
+           (setq tabulated-list-sort-key '("Type" . nil)
+                 tabulated-list-entries entries))
+          ((eq bookmark-sort-flag 'file)
+           (setq tabulated-list-sort-key '("File" . nil)
+                 tabulated-list-entries entries))
           ((or (null bookmark-sort-flag)
                (eq bookmark-sort-flag 'last-modified))
            (setq tabulated-list-sort-key nil)
@@ -1971,16 +1978,10 @@ bookmark-bmenu-mode
 Letters do not insert themselves; instead, they are commands.
 Bookmark names preceded by a \"*\" have annotations.
 
-If `bookmark-sort-flag' is non-nil, then sort the list by
-bookmark name (case-insensitively, in collation order); the
-direction of that sort can be reversed by using the column sort
-toggle for the bookmark name column.
-
-If `bookmark-sort-flag' is nil, then sort the list by bookmark
-creation order, with most recently created bookmarks on top.
-However, the column sort toggle will still activate (and
-thereafter toggle the direction of) lexical sorting by bookmark name.
-At any time you may use \\[revert-buffer] to go back to sorting by creation order.
+The sort order can be controlled with `bookmark-sort-flag'.  The
+sort direction can be reversed by using the column sort toggle
+for the bookmark name column.  At any time you may use
+\\[revert-buffer] to go back to the original sort order.
 
 \\<bookmark-bmenu-mode-map>
 \\[bookmark-bmenu-mark] -- mark bookmark to be displayed.
@@ -2015,8 +2016,7 @@ bookmark-bmenu-mode
 \\[bookmark-bmenu-show-all-annotations] -- show the annotations of all bookmarks in another buffer.
 \\[bookmark-bmenu-edit-annotation] -- edit the annotation for the current bookmark.
 \\[bookmark-bmenu-search] -- incrementally search for bookmarks.
-\\[revert-buffer] -- refresh the buffer, and thus refresh the sort order (useful
-  if `bookmark-sort-flag' is nil)."
+\\[revert-buffer] -- refresh the buffer, and thus refresh the sort order."
   (setq truncate-lines t)
   (setq buffer-read-only t)
   ;; FIXME: The header could also display the current default bookmark file
@@ -2029,9 +2029,6 @@ bookmark-bmenu-mode
           ,@(if bookmark-bmenu-toggle-filenames
                 '(("File" 0 bookmark-bmenu--file-predicate)))])
   (setq tabulated-list-padding bookmark-bmenu-marks-width)
-  (when (and bookmark-sort-flag
-             (not (eq bookmark-sort-flag 'last-modified)))
-    (setq tabulated-list-sort-key '("Bookmark Name" . nil)))
   (add-hook 'tabulated-list-revert-hook #'bookmark-bmenu--revert nil t)'
   (setq revert-buffer-function 'bookmark-bmenu--revert)
   (tabulated-list-init-header))
-- 
2.34.1


--=-=-=
Content-Type: text/plain


---
Gabriel

--=-=-=--