X-Loop: help-debbugs@HIDDEN Subject: bug#59581: 29.0.50; [PATCH] Add completions details to Bookmarks Resent-From: Gabriel <gabriel376@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Fri, 25 Nov 2022 19:20:02 +0000 Resent-Message-ID: <handler.59581.B.166940399226825 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 59581 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 59581 <at> debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN Received: via spool by submit <at> debbugs.gnu.org id=B.166940399226825 (code B ref -1); Fri, 25 Nov 2022 19:20:02 +0000 Received: (at submit) by debbugs.gnu.org; 25 Nov 2022 19:19:52 +0000 Received: from localhost ([127.0.0.1]:37174 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1oyeEp-0006yb-IX for submit <at> debbugs.gnu.org; Fri, 25 Nov 2022 14:19:52 -0500 Received: from lists.gnu.org ([209.51.188.17]:41482) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <gabriel376@HIDDEN>) id 1oyeEm-0006yR-Km for submit <at> debbugs.gnu.org; Fri, 25 Nov 2022 14:19:50 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <gabriel376@HIDDEN>) id 1oyeEm-00023S-FZ for bug-gnu-emacs@HIDDEN; Fri, 25 Nov 2022 14:19:48 -0500 Received: from mail-sn1nam02olkn2027.outbound.protection.outlook.com ([40.92.44.27] helo=NAM02-SN1-obe.outbound.protection.outlook.com) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <gabriel376@HIDDEN>) id 1oyeEk-0003k7-Gs for bug-gnu-emacs@HIDDEN; Fri, 25 Nov 2022 14:19:48 -0500 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=QAGAcHLtP65qHiZ3RNbMlz8JFJTBbqVQ8ZpGuk8zWFGaYQilP2o9JaVyVBwSUvzkICM0gZENKBV0nFt1//ZJiJuZgOHfnH3l05TTRUd+Q30OMCwUPGO9dA2scPdsi9ZK/0CMuTp0LasJxcZXDpKqzGxBIiP9pitnAaiNr7+GeZhMdc6xQyySN6edTD48QNyVEs4dfjPreWCm9mszuJYVXJSkHxEZM0p3XeM8fbu+p4tNV36j9/7AKBV+Reg/nBy0Mpq3RdkAL6IFjuuZmduT08vyFlHltd0Kjy8gp5ii5S+NzegJqW7dfV0JEPckSJFJcySsU3SR4PE8s5ctWsf4Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=4Ielg9uy8tul0EP9NqMbW2KzfuseMMbWV6t+Vo/2avM=; b=jpN9sjimp/05YgnwTJDDNoiCclmeDAiR01A6xhH+y+1NMl7dKw3k9IFJcbThAdWdXTOLQZKHQao100x5bBDDxQtqGu7IDUXmr8DylqLboaG8K1PVUyAkN7WiAcsVW88ynEH5bycoct0fxbM4UqjLpTMoSeVl2nR9eY2dLDHo4yQfQ7KmYhTZ/6Wd1EINAfxbLdqL7/u8l8Y9wTQtHK4rOoeJXj6trMbDhGXAEtpuKEFyCekE1qtOCMkbyjR3swZJV7ekD1oZPafmRVtpbmKrZdLN1kH4jLRkFNyQjhOV+IzMv/7dpacWenS9kOM2U70jy5znYWnEWjXx8CEht8jyQg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=4Ielg9uy8tul0EP9NqMbW2KzfuseMMbWV6t+Vo/2avM=; b=PFUlCZyUhj6FoMRrY71UqQoL0BQtfE1WH+5syRdBwF9/SM6ma9fMqrDR3M2cel0wU5zpffb8F5p+Ldk4h8Q2txKzlJu0vQi+nMnYNEh3pBOlSrH4p06+/4HcPoh+SS6S2xgpkySplbtePpkaAwVL4gk6fneIHpTVO+0qLsFlNF7YEJUrUjU75BowuYVfnBe97+XIjlyQBO3u7DHA43zwKtRvyS1gu2DCyNm/s+Th++Jv8Npk9CnFi0CdgXz7tyGCKUwOTcUXVaYInWFblDbhlTjFmQNp1Wa1DYSsdaD6N3GuDlK0GL3csPxEOjnNS5bpG3FqnHoKRCuHKhbbavIj9Q== Received: from SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) by BN8PR06MB5476.namprd06.prod.outlook.com (2603:10b6:408:40::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Fri, 25 Nov 2022 19:19:44 +0000 Received: from SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f]) by SJ0PR06MB8609.namprd06.prod.outlook.com ([fe80::33ae:d3a7:24ae:5c6f%5]) with mapi id 15.20.5880.005; Fri, 25 Nov 2022 19:19:43 +0000 From: Gabriel <gabriel376@HIDDEN> Date: Fri, 25 Nov 2022 16:19:38 -0300 Message-ID: <SJ0PR06MB86091171C1021EAC173EE5B88B0E9@HIDDEN> Content-Type: multipart/mixed; boundary="=-=-=" X-TMN: [2ITKBQG1GmUZEqzLStZByjPRAHR9asmvKLps/QizoFcQt59PR8FWj+Mic0cMWBYW] X-ClientProxiedBy: CP6P284CA0049.BRAP284.PROD.OUTLOOK.COM (2603:10d6:103:1ab::18) To SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11) X-Microsoft-Original-Message-ID: <875yf2zvsl.fsf@HIDDEN> MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ0PR06MB8609:EE_|BN8PR06MB5476:EE_ X-MS-Office365-Filtering-Correlation-Id: 86b991db-beee-43e1-2cbf-08dacf1a01df X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: MK5NpNe9PZ3nOm5ABC5nhVVAyWLrzRD6T/NtXKtPm75gqsNMBM3oVOCRvdHqryOlc6yYlpVqy9czrwwxDoaRC3etQ9eFDbA+eY7Ga0luDjrQo17SVrFKxMckOodrtjwZCA4UGV51HTB650qVjKw/j4yTzjYYyXGVBPhGlrCy+KSIFpJEJAB6rm25xbEivNf8qRjEKI/L1CA1Z5OXdiYQAgnF8AalLU8MZyYHo4G5qSZEW1ey1+ZZZJefJ03WqJ1QUSTgZ91LN3/R5CifZsSbl2zzXFlbyN85bjv5nNXeZmC/DRi227VZptKgpSnpZBeHH+VrTw2/iUd9IPSgzRPUH2v+rB50XirCZ7E3vLpBwNfgmm6V/rEAqz9mcLDKplJB3I8L5lGlrqDPlPBfs5Crkn7oWcylAyuf2RIq/vxhaT02934ke+vstdv7dMdabqrVgXbOktB7fD3WuAPw5HdAuGq9Z71HzKbrhcwnwv8mUl0L8HLUVQ4Epzre9WagTNYLBA4IpEHDBdEhOeQ09KHQtio+yHUi8l5oJaT1Rtfi25Qmx5EAowna5Z+Mk2Zog8Jx9xpjmDicEeOzi1dE6gmLAPcndbaPCAonEGmFhvAx5VU= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: vkM+uzXuRWLwhWHGxLwvm/lnxtGdP34LC3rq2hCJPgsjl4LElFvaXxxIWt+ZKLFhoAr11J3ShiW0dJoi+XZM+T7X3WZdKOXFO1GndilQEIMRbuREeHbU+C+oqiqF5/4KHMwnId5XcfDghD63Ly1jdEOO3jiWMIrhTxQfrYpH9uXS3bjSUl0lUrV3HmQdoBCT3GxjMhKkDmXQwMJnVlMCScG1QxrKLpL+uPkqeOhnaWEDkeJEJsj2/EzvzcXm/Zcl4EL8X0PBp738LTFpbz+SamEvgFZQB3drp2ILluXvcQRzhymh+YwMAcYMgfwcSy6XAOeJn7tIdJCwIDfxnk1SPLqDkEC4DKZ0eDEa8dKy3yr7wpQqX21TDJPtDGuTEkYHTWsmHCrL6YmJD1coNzf/BBMSAoZ5oPZh0BjoeeRXjggc6v2EkH0xXECAngQ983E7ZWHWFekqGej+0l8V9jnF772w/kfrNCP6SaffkYMGc517hPmbElO0N8OPO/i/3wDuCCv3j4JinuZemLtksY3RcXhAYq7p5fZVafBJPJqUFd0lFbH0OCkYRWiSjSdTlKu2mWjko8il3qoDIQbad8NK9I90upw8x8nCZliYo4Oo2SboG8wh2iqP6emPQhn7jh4cyoQ9bfI3Xmd8wFd9r8/yOWa2QnwVp4gHNlXzxc/60ddIxyIQYoMpLwFUgsK5mTH5Bo1tg6j7LrYVIF4OEQRZLfCi+XJvhBPgfxV6kjq7i9M8pX1hQ1asT0gKVI58Rk4eoZGC54UovmczgF1THLUGaWzDPzE38S/ABWAjsBF6cJipUO+iMG3/iXUOSkFtt7grg17Wa455h/TKNRsnPivvWfWGMRsmnWeqNk+M4ZEPRaHBYkkMh0v3mZP5rLZepm8UPbtf0R6W44WS5dHny/kb2Z9njpVUwdOyv33YNGsm4JYOLm/ev5zTCHJt70ivJx6jbfKiN1uPwNL+M9Ltw2mF4EsnCyNkKz5yqCgmnqoi0/pS9CAun9sesQSBwjsEdKIrSy3TR424S7SQqCIv4SgatpjwRgTmFpIxcVdD4ndyvBrVhrlDXaUYKo4d8JTt3eUjHX2qkXAM7HnBLcWgz6LBvOZtlvYkd7lc+C42MGe+zgS0RAie2jJ7cVrdC8Npb4K5pNNdUApsUp9P5PjEFvda7FDGLAx6JeAFirdLv8syRHoVGxtwXt/T4/NqTMzDNA//tIzPma8hpBJnbz8zqyPSVrvc+IAv/AbP573X5RS0WzCEi9dh0wxBtNd7priIzEDsIZP0AgBYybpymaD8IBaskRyDJPAtPGBxTLCx1xs3UTDDWGV3pV0Qi6Lhxf+OhgNX2NRpUQVengdm4MyXsq1NUg== X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-89723.templateTenant X-MS-Exchange-CrossTenant-Network-Message-Id: 86b991db-beee-43e1-2cbf-08dacf1a01df X-MS-Exchange-CrossTenant-AuthSource: SJ0PR06MB8609.namprd06.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2022 19:19:43.7754 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR06MB5476 Received-SPF: pass client-ip=40.92.44.27; envelope-from=gabriel376@HIDDEN; helo=NAM02-SN1-obe.outbound.protection.outlook.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.1 (-) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.1 (--) --=-=-= Content-Type: text/plain Severity: wishlist Description: Add completions details (see `completions-detailed') to Bookmarks. It affects all bookmark functions that make uses of `bookmark-completing-read' (e.g.: `bookmark-jump', `bookmark-relocate', `bookmark-insert-location', `bookmark-rename' etc). See also [1]. [1] https://lists.gnu.org/archive/html/emacs-devel/2022-11/msg00995.html --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-Add-completions-details-to-Bookmarks.patch From 188d924aaa8842c85a4d4206d6c71ca31727240e Mon Sep 17 00:00:00 2001 From: Gabriel do Nascimento Ribeiro <gabriel376@HIDDEN> Date: Fri, 25 Nov 2022 16:07:14 -0300 Subject: [PATCH 1/1] Add completions details to Bookmarks * lisp/bookmark.el (bookmark-completing-read--collection) (bookmark-completing-read--affixation-function): New auxiliary functions to add completion details to bookmark-completing-read. (bookmark-completing-read): Make use of new auxiliary function. --- lisp/bookmark.el | 24 ++++++++++++++++++------ 1 file changed, 18 insertions(+), 6 deletions(-) diff --git a/lisp/bookmark.el b/lisp/bookmark.el index 7f3a264f53..9050668f4f 100644 --- a/lisp/bookmark.el +++ b/lisp/bookmark.el @@ -541,6 +541,23 @@ bookmark-maybe-sort-alist (t (time-less-p ty tx))))))) (t copy)))) +(defun bookmark-completing-read--collection (string pred action) + (if (eq action 'metadata) + `(metadata (category . bookmark) + ,@(when completions-detailed + '((affixation-function . bookmark-completing-read--affixation-function)))) + (complete-with-action action bookmark-alist string pred))) + +(defun bookmark-completing-read--affixation-function (bookmarks) + (seq-map (lambda (record) + (list record + nil + (propertize (format " %-11s %s" + (or (bookmark-type-from-full-record record) "") + (bookmark-location record)) + 'face 'completions-annotations))) + bookmarks)) + (defun bookmark-completing-read (prompt &optional default) "Prompting with PROMPT, read a bookmark name in completion. PROMPT will get a \": \" stuck on the end no matter what, so you @@ -555,14 +572,9 @@ bookmark-completing-read (let* ((completion-ignore-case bookmark-completion-ignore-case) (default (unless (equal "" default) default))) (completing-read (format-prompt prompt default) - (lambda (string pred action) - (if (eq action 'metadata) - '(metadata (category . bookmark)) - (complete-with-action - action bookmark-alist string pred))) + #'bookmark-completing-read--collection nil 0 nil 'bookmark-history default)))) - (defmacro bookmark-maybe-historicize-string (string) "Put STRING into the bookmark prompt history, if caller non-interactive. We need this because sometimes bookmark functions are invoked -- 2.34.1 --=-=-= Content-Type: text/plain --- Gabriel --=-=-=--
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Gabriel <gabriel376@HIDDEN> Subject: bug#59581: Acknowledgement (29.0.50; [PATCH] Add completions details to Bookmarks) Message-ID: <handler.59581.B.166940399226825.ack <at> debbugs.gnu.org> References: <SJ0PR06MB86091171C1021EAC173EE5B88B0E9@HIDDEN> X-Gnu-PR-Message: ack 59581 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 59581 <at> debbugs.gnu.org Date: Fri, 25 Nov 2022 19:20:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 59581 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 59581: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D59581 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN Subject: bug#59581: 29.0.50; [PATCH] Add completions details to Bookmarks Resent-From: Eli Zaretskii <eliz@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Thu, 01 Dec 2022 08:46:02 +0000 Resent-Message-ID: <handler.59581.B59581.166988435125193 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 59581 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Gabriel <gabriel376@HIDDEN>, Karl Fogel <kfogel@HIDDEN> Cc: 59581 <at> debbugs.gnu.org Received: via spool by 59581-submit <at> debbugs.gnu.org id=B59581.166988435125193 (code B ref 59581); Thu, 01 Dec 2022 08:46:02 +0000 Received: (at 59581) by debbugs.gnu.org; 1 Dec 2022 08:45:51 +0000 Received: from localhost ([127.0.0.1]:38355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1p0fCY-0006YH-Pg for submit <at> debbugs.gnu.org; Thu, 01 Dec 2022 03:45:51 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59774) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1p0fCX-0006YB-4G for 59581 <at> debbugs.gnu.org; Thu, 01 Dec 2022 03:45:49 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1p0fCP-0007Hw-O7; Thu, 01 Dec 2022 03:45:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=eyYEggPTcjI2c3q2hIH6IBJBvzdTyzpMV8ZdpvDfvcU=; b=WOJtRKqZKMIr kt0Cmrs62yvknfJApSRaG7HvLQ4LfnIKf68UAJSFqGiom1vwmQcM6aYtxVIxHnvZgC8lMVK05J/yt h32PGwp8NWoPc7c20CFCuypMcx8XIsmI8iiOH2KBO9SVRrsrhJMbbKYX4zTRxsnIgDkhEN+ZjUS9R 1PGzh6/VKKbDXSiglmIX7ZV1E7FYFbRzQXR8tG2xe4YWNspX/6acXd+4G+MNUN/x2o7aYKv+6sX2l 6xUXMp8mMUtCIlW8bXr0unMjUzncLG30swnl1XYnM5IpdjPnuhsttq5Ej99o33FcPRzbgtIw+6Gy6 0KeUPFGI9EMd7ahb7s6dzQ==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1p0fCP-000812-6Y; Thu, 01 Dec 2022 03:45:41 -0500 Date: Thu, 01 Dec 2022 10:45:11 +0200 Message-Id: <83a647ikbs.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> In-Reply-To: <SJ0PR06MB86091171C1021EAC173EE5B88B0E9@HIDDEN> (message from Gabriel on Fri, 25 Nov 2022 16:19:38 -0300) References: <SJ0PR06MB86091171C1021EAC173EE5B88B0E9@HIDDEN> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Gabriel <gabriel376@HIDDEN> > Date: Fri, 25 Nov 2022 16:19:38 -0300 > > Description: > > Add completions details (see `completions-detailed') to Bookmarks. It > affects all bookmark functions that make uses of > `bookmark-completing-read' (e.g.: `bookmark-jump', `bookmark-relocate', > `bookmark-insert-location', `bookmark-rename' etc). See also [1]. > > [1] https://lists.gnu.org/archive/html/emacs-devel/2022-11/msg00995.html Karl, any comments to the patch?
X-Loop: help-debbugs@HIDDEN Subject: bug#59581: bug#59580 and bug#59581 Resent-From: Karl Fogel <kfogel@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Mon, 19 Dec 2022 21:01:02 +0000 Resent-Message-ID: <handler.59581.B59581.167148363928786 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 59581 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii <eliz@HIDDEN> Cc: 59580 <at> debbugs.gnu.org, Gabriel <gabriel376@HIDDEN>, 59581 <at> debbugs.gnu.org Reply-To: Karl Fogel <kfogel@HIDDEN> Received: via spool by 59581-submit <at> debbugs.gnu.org id=B59581.167148363928786 (code B ref 59581); Mon, 19 Dec 2022 21:01:02 +0000 Received: (at 59581) by debbugs.gnu.org; 19 Dec 2022 21:00:39 +0000 Received: from localhost ([127.0.0.1]:40370 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1p7NFX-0007UE-9k for submit <at> debbugs.gnu.org; Mon, 19 Dec 2022 16:00:39 -0500 Received: from sanpietro.red-bean.com ([45.79.25.59]:39242) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <kfogel@HIDDEN>) id 1p7NFR-0007U3-Jp; Mon, 19 Dec 2022 16:00:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID:Date: Reply-To:References:In-Reply-To:Subject:Cc:To:From:Sender: Content-Transfer-Encoding:Content-ID:Content-Description; bh=DpCSEC1UBB6tofhAfNGMErW9TUvkrbPeMRNnoS791RI=; t=1671483633; x=1672693233; b=Et1KVcFwemLGa/IIFHLewwAxNckppMIk9cQOcIE/0/WxDz4ZTlGhTdqUc+I3V5vTTvZnlSJ1tjT PGnmDt3+lbSQsgvOnUbnL17ZnaRResFLf2vwvgR7iowaOjKgBvWUVYJa46Sfb9WDAiI54Zasc9g/G 6SfqF9L48LhB5Ez9/1fGURQ3T7Yky73dESYV3RHhGw+KwuZipM9mklHDb8bsftcQbkZ9RX4DTKsSD aXAPjR/zmveLMCH0m81n8H91cwtrgwqUeDXHKUGBk/wwcg6I3kdO4/DHRonhC8Vs3UpRylNyWk6LJ uz+V4ji2uN3HJ5tXDkA6TjQ3laNbBVXT6yxA==; Received: from 99-112-125-163.lightspeed.cicril.sbcglobal.net ([99.112.125.163]:46434 helo=floss) by sanpietro.red-bean.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from <kfogel@HIDDEN>) id 1p7NFO-00Fkj6-Pz; Mon, 19 Dec 2022 21:00:30 +0000 From: Karl Fogel <kfogel@HIDDEN> In-Reply-To: <83bkonilbm.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 01 Dec 2022 10:23:41 +0200") References: <SJ0PR06MB8609C2D89667AC0EBADE93E48B0E9@HIDDEN> <83bkonilbm.fsf@HIDDEN> Date: Mon, 19 Dec 2022 15:00:26 -0600 Message-ID: <87wn6nhzx1.fsf_-_@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) I am just seeing tickets #59580 and #59581 now. I will review the patches as soon as I can and reply back. This won't be till the end of the week, however, as I am traveling before then and won't have much working time while on the road. Thanks for the patches Gabriel, and thanks for the ping, Eli. Best regards, -Karl
X-Loop: help-debbugs@HIDDEN Subject: bug#59581: 29.0.50; [PATCH] Add completions details to Bookmarks Resent-From: Karl Fogel <kfogel@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: bug-gnu-emacs@HIDDEN Resent-Date: Mon, 18 Dec 2023 23:52:01 +0000 Resent-Message-ID: <handler.59581.B59581.17029435071298 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 59581 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii <eliz@HIDDEN> Cc: Gabriel <gabriel376@HIDDEN>, 59581 <at> debbugs.gnu.org Reply-To: Karl Fogel <kfogel@HIDDEN> Received: via spool by 59581-submit <at> debbugs.gnu.org id=B59581.17029435071298 (code B ref 59581); Mon, 18 Dec 2023 23:52:01 +0000 Received: (at 59581) by debbugs.gnu.org; 18 Dec 2023 23:51:47 +0000 Received: from localhost ([127.0.0.1]:33802 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rFNOk-0000Ks-LK for submit <at> debbugs.gnu.org; Mon, 18 Dec 2023 18:51:47 -0500 Received: from sanpietro.red-bean.com ([45.79.25.59]:41432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <kfogel@HIDDEN>) id 1rFNOh-0000Ka-2w for 59581 <at> debbugs.gnu.org; Mon, 18 Dec 2023 18:51:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID:Date: Reply-To:References:In-Reply-To:Subject:Cc:To:From:Sender: Content-Transfer-Encoding:Content-ID:Content-Description; bh=oCdkENhOaiHYsUTLgdWOAqqJeT7kkGg/ft2FEhrDRKg=; t=1702943500; x=1704153100; b=R3Apmk7/369K0mVnCQH+tF0hIs37jgUirRaCPd+Jd1bE6r2viRw7jLZJeDcZfSyzGOQyOuk3LVD BpIMB35vB8Q0X5McniImIQ9f2Kg2YwbTyMrgnGVvzrUeobLbvCFlS+gH1ea488Iw9M5D8XXNYvtMy EDlYHgEeezuas5jEvsUHNcd/miFnn9TRkbDLM6MyYkV74rROVQsrO7PniSYiI1GqeYb449J0MycPK UczlZFZ6NDLKqW1QT63TAuAs70CDaQCH+0HD/S5WrcBP1rrMqosFeKSSiFylIqSnEVm0OXPiatTNX EcLHxHf7L+yQ7S8jiJ4/vAI8IGkRBUeLVp1A==; Received: from [12.106.183.66] (port=55605 helo=hummy) by sanpietro.red-bean.com with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from <kfogel@HIDDEN>) id 1rFNOd-007jVw-PN; Mon, 18 Dec 2023 23:51:39 +0000 From: Karl Fogel <kfogel@HIDDEN> In-Reply-To: <83a647ikbs.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 01 Dec 2022 10:45:11 +0200") References: <SJ0PR06MB86091171C1021EAC173EE5B88B0E9@HIDDEN> <83a647ikbs.fsf@HIDDEN> Date: Mon, 18 Dec 2023 17:51:39 -0600 Message-ID: <8734vzm5mc.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; format=flowed X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) On 01 Dec 2022, Eli Zaretskii wrote: >> From: Gabriel <gabriel376@HIDDEN> >> Date: Fri, 25 Nov 2022 16:19:38 -0300 >> >> Description: >> >> Add completions details (see `completions-detailed') to >> Bookmarks. It >> affects all bookmark functions that make uses of >> `bookmark-completing-read' (e.g.: `bookmark-jump', >> `bookmark-relocate', >> `bookmark-insert-location', `bookmark-rename' etc). See also >> [1]. >> >> [1] >> https://lists.gnu.org/archive/html/emacs-devel/2022-11/msg00995.html > >Karl, any comments to the patch? I applied this patch, reloaded bookmark.el, and then tested `M-x bookmark-jump' in two ways: 1) With `completions-detailed' == nil (my default) 2) With `completions-detailed' == t In case (1) I saw the expected default behavior. My bookmarks completed normally by name, and just their names were offered during completion. In case (2), though, things seemed broken. The "*Completions*" buffer says "19 possible completions:" at the top (as expected), but the buffer is otherwise blank. And when I hit SPC or TAB at the "Jump to bookmark:" prompt, I get "[Wrong type argument: stringp, nil]" in the minibuffer. My "*Messages*" buffer fills with messages like this: Making completion list... #<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_56>: \ Wrong type argument: stringp, nil Similar behavior happens for all the functions that depend on `bookmark-completing-read'. This is in Emacs 30.0.50 (built today from 'master', commit 1d5d2f16c330e). Gabriel, does the patch maybe need a bit of updating? I assume it worked for in the version of Emacs you originally wrote it in (which would be from a littl over a year ago now -- sorry for the delay; I wish I'd been able to follow up to this sooner). Best regards, -Karl
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.