X-Loop: help-debbugs@HIDDEN
Subject: bug#59581: 29.0.50; [PATCH] Add completions details to Bookmarks
Resent-From: Gabriel <gabriel376@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 25 Nov 2022 19:20:02 +0000
Resent-Message-ID: <handler.59581.B.166940399226825 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: report 59581
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: 59581 <at> debbugs.gnu.org
X-Debbugs-Original-To: bug-gnu-emacs@HIDDEN
Received: via spool by submit <at> debbugs.gnu.org id=B.166940399226825
(code B ref -1); Fri, 25 Nov 2022 19:20:02 +0000
Received: (at submit) by debbugs.gnu.org; 25 Nov 2022 19:19:52 +0000
Received: from localhost ([127.0.0.1]:37174 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1oyeEp-0006yb-IX
for submit <at> debbugs.gnu.org; Fri, 25 Nov 2022 14:19:52 -0500
Received: from lists.gnu.org ([209.51.188.17]:41482)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <gabriel376@HIDDEN>) id 1oyeEm-0006yR-Km
for submit <at> debbugs.gnu.org; Fri, 25 Nov 2022 14:19:50 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <gabriel376@HIDDEN>)
id 1oyeEm-00023S-FZ
for bug-gnu-emacs@HIDDEN; Fri, 25 Nov 2022 14:19:48 -0500
Received: from mail-sn1nam02olkn2027.outbound.protection.outlook.com
([40.92.44.27] helo=NAM02-SN1-obe.outbound.protection.outlook.com)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <gabriel376@HIDDEN>)
id 1oyeEk-0003k7-Gs
for bug-gnu-emacs@HIDDEN; Fri, 25 Nov 2022 14:19:48 -0500
ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;
b=QAGAcHLtP65qHiZ3RNbMlz8JFJTBbqVQ8ZpGuk8zWFGaYQilP2o9JaVyVBwSUvzkICM0gZENKBV0nFt1//ZJiJuZgOHfnH3l05TTRUd+Q30OMCwUPGO9dA2scPdsi9ZK/0CMuTp0LasJxcZXDpKqzGxBIiP9pitnAaiNr7+GeZhMdc6xQyySN6edTD48QNyVEs4dfjPreWCm9mszuJYVXJSkHxEZM0p3XeM8fbu+p4tNV36j9/7AKBV+Reg/nBy0Mpq3RdkAL6IFjuuZmduT08vyFlHltd0Kjy8gp5ii5S+NzegJqW7dfV0JEPckSJFJcySsU3SR4PE8s5ctWsf4Sg==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector9901;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=4Ielg9uy8tul0EP9NqMbW2KzfuseMMbWV6t+Vo/2avM=;
b=jpN9sjimp/05YgnwTJDDNoiCclmeDAiR01A6xhH+y+1NMl7dKw3k9IFJcbThAdWdXTOLQZKHQao100x5bBDDxQtqGu7IDUXmr8DylqLboaG8K1PVUyAkN7WiAcsVW88ynEH5bycoct0fxbM4UqjLpTMoSeVl2nR9eY2dLDHo4yQfQ7KmYhTZ/6Wd1EINAfxbLdqL7/u8l8Y9wTQtHK4rOoeJXj6trMbDhGXAEtpuKEFyCekE1qtOCMkbyjR3swZJV7ekD1oZPafmRVtpbmKrZdLN1kH4jLRkFNyQjhOV+IzMv/7dpacWenS9kOM2U70jy5znYWnEWjXx8CEht8jyQg==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=4Ielg9uy8tul0EP9NqMbW2KzfuseMMbWV6t+Vo/2avM=;
b=PFUlCZyUhj6FoMRrY71UqQoL0BQtfE1WH+5syRdBwF9/SM6ma9fMqrDR3M2cel0wU5zpffb8F5p+Ldk4h8Q2txKzlJu0vQi+nMnYNEh3pBOlSrH4p06+/4HcPoh+SS6S2xgpkySplbtePpkaAwVL4gk6fneIHpTVO+0qLsFlNF7YEJUrUjU75BowuYVfnBe97+XIjlyQBO3u7DHA43zwKtRvyS1gu2DCyNm/s+Th++Jv8Npk9CnFi0CdgXz7tyGCKUwOTcUXVaYInWFblDbhlTjFmQNp1Wa1DYSsdaD6N3GuDlK0GL3csPxEOjnNS5bpG3FqnHoKRCuHKhbbavIj9Q==
Received: from SJ0PR06MB8609.namprd06.prod.outlook.com (2603:10b6:a03:40c::11)
by BN8PR06MB5476.namprd06.prod.outlook.com (2603:10b6:408:40::17)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5857.17; Fri, 25 Nov
2022 19:19:44 +0000
Received: from SJ0PR06MB8609.namprd06.prod.outlook.com
([fe80::33ae:d3a7:24ae:5c6f]) by SJ0PR06MB8609.namprd06.prod.outlook.com
([fe80::33ae:d3a7:24ae:5c6f%5]) with mapi id 15.20.5880.005; Fri, 25 Nov 2022
19:19:43 +0000
From: Gabriel <gabriel376@HIDDEN>
Date: Fri, 25 Nov 2022 16:19:38 -0300
Message-ID: <SJ0PR06MB86091171C1021EAC173EE5B88B0E9@HIDDEN>
Content-Type: multipart/mixed; boundary="=-=-="
X-TMN: [2ITKBQG1GmUZEqzLStZByjPRAHR9asmvKLps/QizoFcQt59PR8FWj+Mic0cMWBYW]
X-ClientProxiedBy: CP6P284CA0049.BRAP284.PROD.OUTLOOK.COM
(2603:10d6:103:1ab::18) To SJ0PR06MB8609.namprd06.prod.outlook.com
(2603:10b6:a03:40c::11)
X-Microsoft-Original-Message-ID: <875yf2zvsl.fsf@HIDDEN>
MIME-Version: 1.0
X-MS-Exchange-MessageSentRepresentingType: 1
X-MS-PublicTrafficType: Email
X-MS-TrafficTypeDiagnostic: SJ0PR06MB8609:EE_|BN8PR06MB5476:EE_
X-MS-Office365-Filtering-Correlation-Id: 86b991db-beee-43e1-2cbf-08dacf1a01df
X-Microsoft-Antispam: BCL:0;
X-Microsoft-Antispam-Message-Info: MK5NpNe9PZ3nOm5ABC5nhVVAyWLrzRD6T/NtXKtPm75gqsNMBM3oVOCRvdHqryOlc6yYlpVqy9czrwwxDoaRC3etQ9eFDbA+eY7Ga0luDjrQo17SVrFKxMckOodrtjwZCA4UGV51HTB650qVjKw/j4yTzjYYyXGVBPhGlrCy+KSIFpJEJAB6rm25xbEivNf8qRjEKI/L1CA1Z5OXdiYQAgnF8AalLU8MZyYHo4G5qSZEW1ey1+ZZZJefJ03WqJ1QUSTgZ91LN3/R5CifZsSbl2zzXFlbyN85bjv5nNXeZmC/DRi227VZptKgpSnpZBeHH+VrTw2/iUd9IPSgzRPUH2v+rB50XirCZ7E3vLpBwNfgmm6V/rEAqz9mcLDKplJB3I8L5lGlrqDPlPBfs5Crkn7oWcylAyuf2RIq/vxhaT02934ke+vstdv7dMdabqrVgXbOktB7fD3WuAPw5HdAuGq9Z71HzKbrhcwnwv8mUl0L8HLUVQ4Epzre9WagTNYLBA4IpEHDBdEhOeQ09KHQtio+yHUi8l5oJaT1Rtfi25Qmx5EAowna5Z+Mk2Zog8Jx9xpjmDicEeOzi1dE6gmLAPcndbaPCAonEGmFhvAx5VU=
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: vkM+uzXuRWLwhWHGxLwvm/lnxtGdP34LC3rq2hCJPgsjl4LElFvaXxxIWt+ZKLFhoAr11J3ShiW0dJoi+XZM+T7X3WZdKOXFO1GndilQEIMRbuREeHbU+C+oqiqF5/4KHMwnId5XcfDghD63Ly1jdEOO3jiWMIrhTxQfrYpH9uXS3bjSUl0lUrV3HmQdoBCT3GxjMhKkDmXQwMJnVlMCScG1QxrKLpL+uPkqeOhnaWEDkeJEJsj2/EzvzcXm/Zcl4EL8X0PBp738LTFpbz+SamEvgFZQB3drp2ILluXvcQRzhymh+YwMAcYMgfwcSy6XAOeJn7tIdJCwIDfxnk1SPLqDkEC4DKZ0eDEa8dKy3yr7wpQqX21TDJPtDGuTEkYHTWsmHCrL6YmJD1coNzf/BBMSAoZ5oPZh0BjoeeRXjggc6v2EkH0xXECAngQ983E7ZWHWFekqGej+0l8V9jnF772w/kfrNCP6SaffkYMGc517hPmbElO0N8OPO/i/3wDuCCv3j4JinuZemLtksY3RcXhAYq7p5fZVafBJPJqUFd0lFbH0OCkYRWiSjSdTlKu2mWjko8il3qoDIQbad8NK9I90upw8x8nCZliYo4Oo2SboG8wh2iqP6emPQhn7jh4cyoQ9bfI3Xmd8wFd9r8/yOWa2QnwVp4gHNlXzxc/60ddIxyIQYoMpLwFUgsK5mTH5Bo1tg6j7LrYVIF4OEQRZLfCi+XJvhBPgfxV6kjq7i9M8pX1hQ1asT0gKVI58Rk4eoZGC54UovmczgF1THLUGaWzDPzE38S/ABWAjsBF6cJipUO+iMG3/iXUOSkFtt7grg17Wa455h/TKNRsnPivvWfWGMRsmnWeqNk+M4ZEPRaHBYkkMh0v3mZP5rLZepm8UPbtf0R6W44WS5dHny/kb2Z9njpVUwdOyv33YNGsm4JYOLm/ev5zTCHJt70ivJx6jbfKiN1uPwNL+M9Ltw2mF4EsnCyNkKz5yqCgmnqoi0/pS9CAun9sesQSBwjsEdKIrSy3TR424S7SQqCIv4SgatpjwRgTmFpIxcVdD4ndyvBrVhrlDXaUYKo4d8JTt3eUjHX2qkXAM7HnBLcWgz6LBvOZtlvYkd7lc+C42MGe+zgS0RAie2jJ7cVrdC8Npb4K5pNNdUApsUp9P5PjEFvda7FDGLAx6JeAFirdLv8syRHoVGxtwXt/T4/NqTMzDNA//tIzPma8hpBJnbz8zqyPSVrvc+IAv/AbP573X5RS0WzCEi9dh0wxBtNd7priIzEDsIZP0AgBYybpymaD8IBaskRyDJPAtPGBxTLCx1xs3UTDDWGV3pV0Qi6Lhxf+OhgNX2NRpUQVengdm4MyXsq1NUg==
X-OriginatorOrg: sct-15-20-4755-11-msonline-outlook-89723.templateTenant
X-MS-Exchange-CrossTenant-Network-Message-Id: 86b991db-beee-43e1-2cbf-08dacf1a01df
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR06MB8609.namprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Nov 2022 19:19:43.7754 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN8PR06MB5476
Received-SPF: pass client-ip=40.92.44.27; envelope-from=gabriel376@HIDDEN;
helo=NAM02-SN1-obe.outbound.protection.outlook.com
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001,
RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.1 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.1 (--)
--=-=-=
Content-Type: text/plain
Severity: wishlist
Description:
Add completions details (see `completions-detailed') to Bookmarks. It
affects all bookmark functions that make uses of
`bookmark-completing-read' (e.g.: `bookmark-jump', `bookmark-relocate',
`bookmark-insert-location', `bookmark-rename' etc). See also [1].
[1] https://lists.gnu.org/archive/html/emacs-devel/2022-11/msg00995.html
--=-=-=
Content-Type: text/x-diff
Content-Disposition: attachment;
filename=0001-Add-completions-details-to-Bookmarks.patch
From 188d924aaa8842c85a4d4206d6c71ca31727240e Mon Sep 17 00:00:00 2001
From: Gabriel do Nascimento Ribeiro <gabriel376@HIDDEN>
Date: Fri, 25 Nov 2022 16:07:14 -0300
Subject: [PATCH 1/1] Add completions details to Bookmarks
* lisp/bookmark.el (bookmark-completing-read--collection)
(bookmark-completing-read--affixation-function): New auxiliary
functions to add completion details to bookmark-completing-read.
(bookmark-completing-read): Make use of new auxiliary function.
---
lisp/bookmark.el | 24 ++++++++++++++++++------
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/lisp/bookmark.el b/lisp/bookmark.el
index 7f3a264f53..9050668f4f 100644
--- a/lisp/bookmark.el
+++ b/lisp/bookmark.el
@@ -541,6 +541,23 @@ bookmark-maybe-sort-alist
(t (time-less-p ty tx)))))))
(t copy))))
+(defun bookmark-completing-read--collection (string pred action)
+ (if (eq action 'metadata)
+ `(metadata (category . bookmark)
+ ,@(when completions-detailed
+ '((affixation-function . bookmark-completing-read--affixation-function))))
+ (complete-with-action action bookmark-alist string pred)))
+
+(defun bookmark-completing-read--affixation-function (bookmarks)
+ (seq-map (lambda (record)
+ (list record
+ nil
+ (propertize (format " %-11s %s"
+ (or (bookmark-type-from-full-record record) "")
+ (bookmark-location record))
+ 'face 'completions-annotations)))
+ bookmarks))
+
(defun bookmark-completing-read (prompt &optional default)
"Prompting with PROMPT, read a bookmark name in completion.
PROMPT will get a \": \" stuck on the end no matter what, so you
@@ -555,14 +572,9 @@ bookmark-completing-read
(let* ((completion-ignore-case bookmark-completion-ignore-case)
(default (unless (equal "" default) default)))
(completing-read (format-prompt prompt default)
- (lambda (string pred action)
- (if (eq action 'metadata)
- '(metadata (category . bookmark))
- (complete-with-action
- action bookmark-alist string pred)))
+ #'bookmark-completing-read--collection
nil 0 nil 'bookmark-history default))))
-
(defmacro bookmark-maybe-historicize-string (string)
"Put STRING into the bookmark prompt history, if caller non-interactive.
We need this because sometimes bookmark functions are invoked
--
2.34.1
--=-=-=
Content-Type: text/plain
---
Gabriel
--=-=-=--
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: Gabriel <gabriel376@HIDDEN> Subject: bug#59581: Acknowledgement (29.0.50; [PATCH] Add completions details to Bookmarks) Message-ID: <handler.59581.B.166940399226825.ack <at> debbugs.gnu.org> References: <SJ0PR06MB86091171C1021EAC173EE5B88B0E9@HIDDEN> X-Gnu-PR-Message: ack 59581 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 59581 <at> debbugs.gnu.org Date: Fri, 25 Nov 2022 19:20:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): bug-gnu-emacs@HIDDEN If you wish to submit further information on this problem, please send it to 59581 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 59581: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D59581 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN
Subject: bug#59581: 29.0.50; [PATCH] Add completions details to Bookmarks
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 01 Dec 2022 08:46:02 +0000
Resent-Message-ID: <handler.59581.B59581.166988435125193 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 59581
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Gabriel <gabriel376@HIDDEN>, Karl Fogel <kfogel@HIDDEN>
Cc: 59581 <at> debbugs.gnu.org
Received: via spool by 59581-submit <at> debbugs.gnu.org id=B59581.166988435125193
(code B ref 59581); Thu, 01 Dec 2022 08:46:02 +0000
Received: (at 59581) by debbugs.gnu.org; 1 Dec 2022 08:45:51 +0000
Received: from localhost ([127.0.0.1]:38355 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1p0fCY-0006YH-Pg
for submit <at> debbugs.gnu.org; Thu, 01 Dec 2022 03:45:51 -0500
Received: from eggs.gnu.org ([209.51.188.92]:59774)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <eliz@HIDDEN>) id 1p0fCX-0006YB-4G
for 59581 <at> debbugs.gnu.org; Thu, 01 Dec 2022 03:45:49 -0500
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1p0fCP-0007Hw-O7; Thu, 01 Dec 2022 03:45:41 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=eyYEggPTcjI2c3q2hIH6IBJBvzdTyzpMV8ZdpvDfvcU=; b=WOJtRKqZKMIr
kt0Cmrs62yvknfJApSRaG7HvLQ4LfnIKf68UAJSFqGiom1vwmQcM6aYtxVIxHnvZgC8lMVK05J/yt
h32PGwp8NWoPc7c20CFCuypMcx8XIsmI8iiOH2KBO9SVRrsrhJMbbKYX4zTRxsnIgDkhEN+ZjUS9R
1PGzh6/VKKbDXSiglmIX7ZV1E7FYFbRzQXR8tG2xe4YWNspX/6acXd+4G+MNUN/x2o7aYKv+6sX2l
6xUXMp8mMUtCIlW8bXr0unMjUzncLG30swnl1XYnM5IpdjPnuhsttq5Ej99o33FcPRzbgtIw+6Gy6
0KeUPFGI9EMd7ahb7s6dzQ==;
Received: from [87.69.77.57] (helo=home-c4e4a596f7)
by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1p0fCP-000812-6Y; Thu, 01 Dec 2022 03:45:41 -0500
Date: Thu, 01 Dec 2022 10:45:11 +0200
Message-Id: <83a647ikbs.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <SJ0PR06MB86091171C1021EAC173EE5B88B0E9@HIDDEN>
(message from Gabriel on Fri, 25 Nov 2022 16:19:38 -0300)
References: <SJ0PR06MB86091171C1021EAC173EE5B88B0E9@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Gabriel <gabriel376@HIDDEN>
> Date: Fri, 25 Nov 2022 16:19:38 -0300
>
> Description:
>
> Add completions details (see `completions-detailed') to Bookmarks. It
> affects all bookmark functions that make uses of
> `bookmark-completing-read' (e.g.: `bookmark-jump', `bookmark-relocate',
> `bookmark-insert-location', `bookmark-rename' etc). See also [1].
>
> [1] https://lists.gnu.org/archive/html/emacs-devel/2022-11/msg00995.html
Karl, any comments to the patch?
X-Loop: help-debbugs@HIDDEN
Subject: bug#59581: bug#59580 and bug#59581
Resent-From: Karl Fogel <kfogel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 19 Dec 2022 21:01:02 +0000
Resent-Message-ID: <handler.59581.B59581.167148363928786 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 59581
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Eli Zaretskii <eliz@HIDDEN>
Cc: 59580 <at> debbugs.gnu.org, Gabriel <gabriel376@HIDDEN>, 59581 <at> debbugs.gnu.org
Reply-To: Karl Fogel <kfogel@HIDDEN>
Received: via spool by 59581-submit <at> debbugs.gnu.org id=B59581.167148363928786
(code B ref 59581); Mon, 19 Dec 2022 21:01:02 +0000
Received: (at 59581) by debbugs.gnu.org; 19 Dec 2022 21:00:39 +0000
Received: from localhost ([127.0.0.1]:40370 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1p7NFX-0007UE-9k
for submit <at> debbugs.gnu.org; Mon, 19 Dec 2022 16:00:39 -0500
Received: from sanpietro.red-bean.com ([45.79.25.59]:39242)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <kfogel@HIDDEN>)
id 1p7NFR-0007U3-Jp; Mon, 19 Dec 2022 16:00:37 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID:Date:
Reply-To:References:In-Reply-To:Subject:Cc:To:From:Sender:
Content-Transfer-Encoding:Content-ID:Content-Description;
bh=DpCSEC1UBB6tofhAfNGMErW9TUvkrbPeMRNnoS791RI=; t=1671483633; x=1672693233;
b=Et1KVcFwemLGa/IIFHLewwAxNckppMIk9cQOcIE/0/WxDz4ZTlGhTdqUc+I3V5vTTvZnlSJ1tjT
PGnmDt3+lbSQsgvOnUbnL17ZnaRResFLf2vwvgR7iowaOjKgBvWUVYJa46Sfb9WDAiI54Zasc9g/G
6SfqF9L48LhB5Ez9/1fGURQ3T7Yky73dESYV3RHhGw+KwuZipM9mklHDb8bsftcQbkZ9RX4DTKsSD
aXAPjR/zmveLMCH0m81n8H91cwtrgwqUeDXHKUGBk/wwcg6I3kdO4/DHRonhC8Vs3UpRylNyWk6LJ
uz+V4ji2uN3HJ5tXDkA6TjQ3laNbBVXT6yxA==;
Received: from 99-112-125-163.lightspeed.cicril.sbcglobal.net
([99.112.125.163]:46434 helo=floss)
by sanpietro.red-bean.com with esmtpsa (TLS1.3) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2)
(envelope-from <kfogel@HIDDEN>)
id 1p7NFO-00Fkj6-Pz; Mon, 19 Dec 2022 21:00:30 +0000
From: Karl Fogel <kfogel@HIDDEN>
In-Reply-To: <83bkonilbm.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 01 Dec
2022 10:23:41 +0200")
References: <SJ0PR06MB8609C2D89667AC0EBADE93E48B0E9@HIDDEN>
<83bkonilbm.fsf@HIDDEN>
Date: Mon, 19 Dec 2022 15:00:26 -0600
Message-ID: <87wn6nhzx1.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; format=flowed
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
I am just seeing tickets #59580 and #59581 now. I will review the
patches as soon as I can and reply back. This won't be till the
end of the week, however, as I am traveling before then and won't
have much working time while on the road.
Thanks for the patches Gabriel, and thanks for the ping, Eli.
Best regards,
-Karl
X-Loop: help-debbugs@HIDDEN
Subject: bug#59581: 29.0.50; [PATCH] Add completions details to Bookmarks
Resent-From: Karl Fogel <kfogel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Mon, 18 Dec 2023 23:52:01 +0000
Resent-Message-ID: <handler.59581.B59581.17029435071298 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 59581
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Eli Zaretskii <eliz@HIDDEN>
Cc: Gabriel <gabriel376@HIDDEN>, 59581 <at> debbugs.gnu.org
Reply-To: Karl Fogel <kfogel@HIDDEN>
Received: via spool by 59581-submit <at> debbugs.gnu.org id=B59581.17029435071298
(code B ref 59581); Mon, 18 Dec 2023 23:52:01 +0000
Received: (at 59581) by debbugs.gnu.org; 18 Dec 2023 23:51:47 +0000
Received: from localhost ([127.0.0.1]:33802 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1rFNOk-0000Ks-LK
for submit <at> debbugs.gnu.org; Mon, 18 Dec 2023 18:51:47 -0500
Received: from sanpietro.red-bean.com ([45.79.25.59]:41432)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <kfogel@HIDDEN>) id 1rFNOh-0000Ka-2w
for 59581 <at> debbugs.gnu.org; Mon, 18 Dec 2023 18:51:44 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID:Date:
Reply-To:References:In-Reply-To:Subject:Cc:To:From:Sender:
Content-Transfer-Encoding:Content-ID:Content-Description;
bh=oCdkENhOaiHYsUTLgdWOAqqJeT7kkGg/ft2FEhrDRKg=; t=1702943500; x=1704153100;
b=R3Apmk7/369K0mVnCQH+tF0hIs37jgUirRaCPd+Jd1bE6r2viRw7jLZJeDcZfSyzGOQyOuk3LVD
BpIMB35vB8Q0X5McniImIQ9f2Kg2YwbTyMrgnGVvzrUeobLbvCFlS+gH1ea488Iw9M5D8XXNYvtMy
EDlYHgEeezuas5jEvsUHNcd/miFnn9TRkbDLM6MyYkV74rROVQsrO7PniSYiI1GqeYb449J0MycPK
UczlZFZ6NDLKqW1QT63TAuAs70CDaQCH+0HD/S5WrcBP1rrMqosFeKSSiFylIqSnEVm0OXPiatTNX
EcLHxHf7L+yQ7S8jiJ4/vAI8IGkRBUeLVp1A==;
Received: from [12.106.183.66] (port=55605 helo=hummy)
by sanpietro.red-bean.com with esmtpsa (TLS1.3) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2)
(envelope-from <kfogel@HIDDEN>)
id 1rFNOd-007jVw-PN; Mon, 18 Dec 2023 23:51:39 +0000
From: Karl Fogel <kfogel@HIDDEN>
In-Reply-To: <83a647ikbs.fsf@HIDDEN> (Eli Zaretskii's message of "Thu, 01 Dec
2022 10:45:11 +0200")
References: <SJ0PR06MB86091171C1021EAC173EE5B88B0E9@HIDDEN>
<83a647ikbs.fsf@HIDDEN>
Date: Mon, 18 Dec 2023 17:51:39 -0600
Message-ID: <8734vzm5mc.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; format=flowed
X-Spam-Score: -0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
On 01 Dec 2022, Eli Zaretskii wrote:
>> From: Gabriel <gabriel376@HIDDEN>
>> Date: Fri, 25 Nov 2022 16:19:38 -0300
>>
>> Description:
>>
>> Add completions details (see `completions-detailed') to
>> Bookmarks. It
>> affects all bookmark functions that make uses of
>> `bookmark-completing-read' (e.g.: `bookmark-jump',
>> `bookmark-relocate',
>> `bookmark-insert-location', `bookmark-rename' etc). See also
>> [1].
>>
>> [1]
>> https://lists.gnu.org/archive/html/emacs-devel/2022-11/msg00995.html
>
>Karl, any comments to the patch?
I applied this patch, reloaded bookmark.el, and then tested `M-x
bookmark-jump' in two ways:
1) With `completions-detailed' == nil (my default)
2) With `completions-detailed' == t
In case (1) I saw the expected default behavior. My bookmarks
completed normally by name, and just their names were offered
during completion.
In case (2), though, things seemed broken. The "*Completions*"
buffer says "19 possible completions:" at the top (as expected),
but the buffer is otherwise blank. And when I hit SPC or TAB at
the "Jump to bookmark:" prompt, I get "[Wrong type argument:
stringp, nil]" in the minibuffer. My "*Messages*" buffer fills
with messages like this:
Making completion list...
#<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_56>: \
Wrong type argument: stringp, nil
Similar behavior happens for all the functions that depend on
`bookmark-completing-read'.
This is in Emacs 30.0.50 (built today from 'master', commit
1d5d2f16c330e).
Gabriel, does the patch maybe need a bit of updating? I assume it
worked for in the version of Emacs you originally wrote it in
(which would be from a littl over a year ago now -- sorry for the
delay; I wish I'd been able to follow up to this sooner).
Best regards,
-Karl
X-Loop: help-debbugs@HIDDEN
Subject: bug#59581: 29.0.50; [PATCH] Add completions details to Bookmarks
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 12 Feb 2025 03:12:01 +0000
Resent-Message-ID: <handler.59581.B59581.17393298792429 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 59581
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Karl Fogel <kfogel@HIDDEN>
Cc: Gabriel <gabriel376@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>, 59581 <at> debbugs.gnu.org
Received: via spool by 59581-submit <at> debbugs.gnu.org id=B59581.17393298792429
(code B ref 59581); Wed, 12 Feb 2025 03:12:01 +0000
Received: (at 59581) by debbugs.gnu.org; 12 Feb 2025 03:11:19 +0000
Received: from localhost ([127.0.0.1]:59910 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1ti39i-0000d6-Or
for submit <at> debbugs.gnu.org; Tue, 11 Feb 2025 22:11:19 -0500
Received: from mail-ed1-x52a.google.com ([2a00:1450:4864:20::52a]:51666)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
(Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>)
id 1ti39g-0000ck-Gc
for 59581 <at> debbugs.gnu.org; Tue, 11 Feb 2025 22:11:17 -0500
Received: by mail-ed1-x52a.google.com with SMTP id
4fb4d7f45d1cf-5dc89df7eccso12015337a12.3
for <59581 <at> debbugs.gnu.org>; Tue, 11 Feb 2025 19:11:16 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=gmail.com; s=20230601; t=1739329870; x=1739934670; darn=debbugs.gnu.org;
h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
:from:from:to:cc:subject:date:message-id:reply-to;
bh=6dLEnbvIoYgl3oqoLd7JTTb68Myb3HphKB4gjs62H/w=;
b=R13eH0JnM/zEMeC0IICbReqXjFuGiEGfAIZhrpbsegPfvu2PKU4vmmLssSbNbbeOcm
DGpwSXfOf8+QZaf1MZ2ozVjUiu+LID7EOusM995b1ocAv9Lc6qsxtQV9nO3XbpGuE6/B
cauwrhEIPIn5c7OnNxo8C++1bPBtQ1k3HUNcu4+0PwrBZSj3sXz2D1vFGBZ5CRWWWy3Q
IyEHEtM5vJwv7B2Vvub5MTUj6gSKz16eSnAHf4NQDcEl0Rp8jIwrNtMcGYzS3rlKkCDi
AIMiraY3b/Um1rFOwthGeoNTYgz+Zee8S/VWt+zqam5aFDlj4LP+7pucnkTckeQccfnC
Waww==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20230601; t=1739329870; x=1739934670;
h=cc:to:subject:message-id:date:mime-version:references:in-reply-to
:from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;
bh=6dLEnbvIoYgl3oqoLd7JTTb68Myb3HphKB4gjs62H/w=;
b=nZcer1qFnvfVtP8aNweIDPcJ9gekry0541YL8JuXdFQqsKYR/JTEtC+73jenHhdwJ3
DeKHmCwh5zINIuMG1sY9PPH+U9NtOM6/UmxsepXMMeUvA/YbFdZs6p1OYFO8GpZlEROJ
xWCU3dJZHXRnkej5iaC2oXlyBCHtfGbq3ar2Z+9g6mrlBQUfxDtDdasUCesDT9J1eSqq
HE7M7ckmuh+H27iugneL5poxkfW65kuSByPT5dzUFu8ATIQ0P0Z0q2gqcJhlSWOjLcDF
6fDYV251HW8SljxRvMVqa3LMXy4Ua0WhKun6HHrFtunvRu4bfQz9WYYBWSimAVGov3ka
VDZg==
X-Forwarded-Encrypted: i=1;
AJvYcCWS5rxTc6MccNzrNqpUZH6s3JouHIGHZWitrbyTdUVMEdRSJdG6qlKf5VdH+KfC1nUWcSu18Q==@debbugs.gnu.org
X-Gm-Message-State: AOJu0Yz86LnNLeX8YMSge/4ECtNlROsdMUuilrsS0H8Mc0gpifNtVdwF
ptul6elK8tDwghsWF0/9XNrxyXEOhkrjGYo0PQBtoxXk964sWSNAu20dWrXz2f6tAlzxm7M3bjo
joXeAWyM0VzZP3ZJeJbX23SfOYGtQGWn66o7xCw==
X-Gm-Gg: ASbGncu64aXkIVjqksUJxXb8yFy3ALqY7o6TXFwTDs3uKZScYP5AojOgxViYb9Hil88
EdzgBgJj0hbkK8HyTKZ+uMnDaL1hpTuM7/hYMNt5362lr6xzaBjocSIJsILlF6fQFMdRzGfgj
X-Google-Smtp-Source: AGHT+IHLSNyAW89JVNul0Hm883hdt0eu54cYSBvRjZC32jXhHGFmDb9zTIWiq8DrCa5Z8dR2H9EBsPvc+uuy0NQBca4=
X-Received: by 2002:a05:6402:40c4:b0:5d1:f009:925e with SMTP id
4fb4d7f45d1cf-5deadd9d246mr1272455a12.16.1739329870060; Tue, 11 Feb 2025
19:11:10 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
HTTPREST; Tue, 11 Feb 2025 19:11:09 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <8734vzm5mc.fsf@HIDDEN>
References: <SJ0PR06MB86091171C1021EAC173EE5B88B0E9@HIDDEN>
<83a647ikbs.fsf@HIDDEN> <8734vzm5mc.fsf@HIDDEN>
MIME-Version: 1.0
Date: Tue, 11 Feb 2025 19:11:09 -0800
X-Gm-Features: AWEUYZnQowsjudABPYcSEvbd7Swo7ehHxVXBvfqZF2CgsT_RjhkVP-h-SfgWlB0
Message-ID: <CADwFkm=60odkdkO2eSD0=55ATYhFg9buNVe9x-Q+q39HQROnMg@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
Karl Fogel <kfogel@HIDDEN> writes:
> On 01 Dec 2022, Eli Zaretskii wrote:
>>> From: Gabriel <gabriel376@HIDDEN>
>>> Date: Fri, 25 Nov 2022 16:19:38 -0300
>>> Description:
>>> Add completions details (see `completions-detailed') to Bookmarks. It
>>> affects all bookmark functions that make uses of
>>> `bookmark-completing-read' (e.g.: `bookmark-jump', `bookmark-relocate',
>>> `bookmark-insert-location', `bookmark-rename' etc). See also [1].
>>> [1] https://lists.gnu.org/archive/html/emacs-devel/2022-11/msg00995.html
>>
>>Karl, any comments to the patch?
>
> I applied this patch, reloaded bookmark.el, and then tested `M-x bookmark-jump'
> in two ways:
>
> 1) With `completions-detailed' == nil (my default)
>
> 2) With `completions-detailed' == t
>
> In case (1) I saw the expected default behavior. My bookmarks completed
> normally by name, and just their names were offered during completion.
>
> In case (2), though, things seemed broken. The "*Completions*" buffer says "19
> possible completions:" at the top (as expected), but the buffer is otherwise
> blank. And when I hit SPC or TAB at the "Jump to bookmark:" prompt, I get
> "[Wrong type argument: stringp, nil]" in the minibuffer. My "*Messages*" buffer
> fills with messages like this:
>
> Making completion list...
> #<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_56>: \
> Wrong type argument: stringp, nil
>
> Similar behavior happens for all the functions that depend on
> `bookmark-completing-read'.
>
> This is in Emacs 30.0.50 (built today from 'master', commit 1d5d2f16c330e).
>
> Gabriel, does the patch maybe need a bit of updating? I assume it worked for in
> the version of Emacs you originally wrote it in (which would be from a littl
> over a year ago now -- sorry for the delay; I wish I'd been able to follow up to
> this sooner).
>
> Best regards,
> -Karl
Ping.
Gabriel, could you please look into the questions asked by Karl above?
X-Loop: help-debbugs@HIDDEN
Subject: bug#59581: 29.0.50; [PATCH] Add completions details to Bookmarks
Resent-From: Gabriel do Nascimento Ribeiro <gabriel376@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Wed, 27 Aug 2025 23:35:02 +0000
Resent-Message-ID: <handler.59581.B59581.175633767926761 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 59581
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Stefan Kangas <stefankangas@HIDDEN>, Karl Fogel <kfogel@HIDDEN>
Cc: "59581 <at> debbugs.gnu.org" <59581 <at> debbugs.gnu.org>, Eli Zaretskii <eliz@HIDDEN>
Received: via spool by 59581-submit <at> debbugs.gnu.org id=B59581.175633767926761
(code B ref 59581); Wed, 27 Aug 2025 23:35:02 +0000
Received: (at 59581) by debbugs.gnu.org; 27 Aug 2025 23:34:39 +0000
Received: from localhost ([127.0.0.1]:37374 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1urPf3-0006xL-L9
for submit <at> debbugs.gnu.org; Wed, 27 Aug 2025 19:34:39 -0400
Received: from mail-mw2nam04olkn2078.outbound.protection.outlook.com
([40.92.46.78]:61634 helo=NAM04-MW2-obe.outbound.protection.outlook.com)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <gabriel376@HIDDEN>)
id 1urPez-0006vn-FK
for 59581 <at> debbugs.gnu.org; Wed, 27 Aug 2025 19:34:35 -0400
ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none;
b=gigEB0ue4S1JnswnOt+JpZbfi4579bSzyAmnhqXCecGObCJRHKwvWhZ3s+HfxP8U5bK44mRxdeas92mBxkmN+7GeQVLclAW9A5YjkjSOCt1+Acp5sFhAOFXqlGviuvwgXokO+bZp5VErt+OeqjaZRLylLG8lVhoDAfj4cnQcUSInBunhNGzGLDawZr23ap2U+yN1DOr9TYtjst7E8Wk0oNcWGxclQvJ2DYctxc5srT8oLDuMfC2QIqJ+HxqvItOAJzhM5h3q6pcamROMYn5WtsBnw3Svkzt/LG4HZKATND2TW1mDiVjuNpi58315cQTFGN1qXwSHCtbckyzKO95ieQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;
s=arcselector10001;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;
bh=3Qjg+4z2//aRVutDoS9nvv9WEroPr1IdqkpjWSWVzeQ=;
b=kIUois+wsuxoWIFQZRfoWm0vC+5HKdyuFiAmxx007CnqMyfyrgFga0k/HvNL7+9x598uSJgCTZNX4FKiqHXorhxscMc/0PN/2Ktcxrw1D9NzJVV5wV8y8LlwmONlFEnUILwxeL6O2zRoiPfycmWrRB3/qt78lfmNq5n7lkaqL3hb5jg1gOWnIIzeO06WcsCjwoEjiv2qo459WLbh32M2ZJL43h6QAtSYme6jhomgpKWmF83ybidgsxETZIJYuSdMrW1K1EUmSIUUEkLiOF+MJPjueCaaND7c/rD6SrB97ddMS6HXEEWVyJ29HJ1RnNH3NRB0R0y4ytm1ahPglxVpDQ==
ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none;
dkim=none; arc=none
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hotmail.com;
s=selector1;
h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
bh=3Qjg+4z2//aRVutDoS9nvv9WEroPr1IdqkpjWSWVzeQ=;
b=WhgAUzM2Ox7i8mEUjsz7ZzLOuFTkxSx548gc9thyhDYxiJAeZ/WLL1cAZB7Q4F+kutWz8/YMtZkzv2R/yXAyl/xPnKeII3MV6N6jeUbyM53jb3fEJkkiHN90b7SP6sFw6oH0M7AzkmmTsW24JJHwFs2mevxoMHKVwlYJuDV11PrJcvRFVTTMGrV82dXxi6Fp8ZItGbP6kLrvEOXVZdHg+pQjDBmigVylx6D5PocNe3dFyWU5CZg4kJyVbFJygm/GjtYCsL/OJ1Ttz0dHeVVjhmu/mL/1lSJfGcHRkaVRaldw2d4CscziMF2aXmIGpPFtp0czmoBGKMgxx6OuMi4Kig==
Received: from SN6PR06MB3935.namprd06.prod.outlook.com (2603:10b6:805:21::11)
by SJ0PR06MB6862.namprd06.prod.outlook.com (2603:10b6:a03:285::22)
with Microsoft SMTP Server (version=TLS1_2,
cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9052.21; Wed, 27 Aug
2025 23:34:25 +0000
Received: from SN6PR06MB3935.namprd06.prod.outlook.com
([fe80::9f7:a06a:fd92:9751]) by SN6PR06MB3935.namprd06.prod.outlook.com
([fe80::9f7:a06a:fd92:9751%3]) with mapi id 15.20.9052.019; Wed, 27 Aug 2025
23:34:24 +0000
From: Gabriel do Nascimento Ribeiro <gabriel376@HIDDEN>
Thread-Topic: bug#59581: 29.0.50; [PATCH] Add completions details to Bookmarks
Thread-Index: AQHZAQLfit2l/LwGTEKbZM2ZEJkPEa5YwJQMhO808NiBNV3lFw==
Date: Wed, 27 Aug 2025 23:34:24 +0000
Message-ID: <SN6PR06MB39355FE9BD83B5B4BC2C84DE8B38A@HIDDEN>
References: <SJ0PR06MB86091171C1021EAC173EE5B88B0E9@HIDDEN>
<83a647ikbs.fsf@HIDDEN> <8734vzm5mc.fsf@HIDDEN>
<CADwFkm=60odkdkO2eSD0=55ATYhFg9buNVe9x-Q+q39HQROnMg@HIDDEN>
In-Reply-To: <CADwFkm=60odkdkO2eSD0=55ATYhFg9buNVe9x-Q+q39HQROnMg@HIDDEN>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach:
X-MS-TNEF-Correlator:
msip_labels:
x-ms-exchange-messagesentrepresentingtype: 1
x-ms-publictraffictype: Email
x-ms-traffictypediagnostic: SN6PR06MB3935:EE_|SJ0PR06MB6862:EE_
x-ms-office365-filtering-correlation-id: 1dfa2853-39d3-452a-f605-08dde5c241d9
x-ms-exchange-slblob-mailprops: Om8TgR6f4EA+wY5dTqkCaj8GWTVLO6Z0CSATnPCo4wpLFV6PPu0FKqUyqtZ0afHKzyayHG7ioU7k3RsGuOjZPafSMte5y0dOqgK1XjNpkPuBFKBKjz/niEPkxwWsJNhejWM4vbgD8tXU6VjLaq/O2A1BILSb6PYO5p92DWHbbTpx7UEfb8pB5gzBjRz61Su8FG9bNX8+vXMB/NI9dqLm2ykZClhotb8IFkk2LMxOLV3PJ25x8LukyoEz/S9fspcHksl5nZyKXFl42z11Vnyt8hjtJwuU280ou6qW0J+2LWIEADCebvYDbyPMPyjfhMkMKA1Wb5mgZT8dfnGlsRZIMYq9CPaWSjY7ngwtvj8mbi0oH6pa3WqWqbwD3Fr1QqfDiS7QSbhh3Igzupxj9Lbc/RXYdj7mZwyVCjxqI/1any+p3Cr2TDOfHkaghzHZ6MiBgHtU0apCYaLPhuR6GZcGG2sQ0h/cBIaKAxDyviJHUz1H60vL/nZyv7ikbc4mKpf6Wzr807G27VAMsNtNH+x/MQErqkTS98rb/0gaykT3s/q9OSYOhaADBxfJTgjtRUVm6SO7H/wJ3Lk+JdY3quh2uXIirDkK1y6Uw7f/tEftpbsf8I+Vt7lj5NGOFWJQEF8bYf5ihV/lotzg5PkmyiYVGwmzak7LrAjhpt7GPB0QuH1lbkRIxtkn1l5sS+gUTmCnwKHRr9Z29xvAKbdLJYzf8mNGcaGMZcUadSE1lHde5GsbkCH3HizWUVvxl4th+iFP3gR89vH9VujAMKdekaCPqjQMUXed6zGVOi5EhcuaOlrPbPSvEiY4a5xXTDJkujnnQLqhAQxIZlXzH9Jmef93r3ATA6fZWLr5
x-microsoft-antispam: BCL:0;
ARA:14566002|19110799012|15080799012|15030799006|31061999003|8060799015|8062599012|461199028|56899033|52005399003|40105399003|440099028|3412199025|10035399007|102099032;
x-microsoft-antispam-message-info: IqosgVcSKI7GivY+3Ndkk4mgTr/nQkdZdp2QnopaftJomZd6TKAel93ZhfyO99+av29rIwW6DQeh88g3wfG3+mOLbK1T5c9QIJ6T6PIsb6PrlIUZMbtmPq7v3iE5VISMepgal1at+klRrdI0bBFsT6gZQ0+b7/JkWBmgZHk1z5bviYDw78JjgaKS59WxssV/oxBwa5hUXJlqKN+kN+ayUzhzWOa839oH6wqmxWcdpw+Vf96GFYPmZClnoL3XSeWtVltHGPf2OG1Q/BGKmbXufCPxTrqvXEiEo+YVVT/Vcdf82tYTXyKF3MRgGh6CsUCHFvQZ+51NqU/fXDeWcC0ExEpD3h0xtGy7FcmMnubN70XJp39ItIX0F7+ERjxefR1App7XVXYAJmkNhfnc7cyoWySHkPD5qx0jMYfO51bLeugsm22kI8q2fWoRBsN13KRgUZ7M0JWgaAMpkmqCvbzr0K6j8ZP1c6aBUFHzic+AUbcLqFFr2iGaA+ykOffCCkj2ZD0l9XNdQPCGx1lb+dWzV+LqsYJvZn6ZJab3Kwkct+/m3SiYpHUtSNIfFRSn1l4pYd/ssfHOTSfVXZPIXBXdmieIySTZalYd+0an1nPj5esxZ6RT19o3Zjx6vuwdL4AcABLIuCDEZ92upXGjXP1yw0WEIorqPrY2Y7D8Sm4Op6sLO+hVqFVw2vR9wzEg6Vy1zGc0byzWSBkp+x6XWnC2GN2u+881/JL6A4//oRcx/RTS7g54h9DNXBbKN7zWkPDbIii/KZrrQCOOnUVsoy0YMyRVpK5eLHFbuFU2HpT9FZmpfoj780+4yC8m33QmZBcOisyKuxmiyUWxIvshjv/nw0/PxKm83a/jE6nZmra01UMMdGVu3P03tH2M20jiob9sLmhEsGzeVjKst44TbrhwafMFrysp6ukXpM3rbJXEXmbfh72KlYV90lX+5HVnB82ImNDuvKuf/+22CDtoTqoDjRXXgnnlL4t2+zUKt21HOksDKfN0TGCY2StAKtervdS5CZM11YCGWYo31NbPL/MmVKv0HrczRst8EhhzsqKMvwgUhxlYofxrEWa/dZ+W7qbs3VU2qqujC1YwjSY6KPlVbieNeUaUHZ8H+Kjph9lkhjTrJ7YcBZHjfCdVudPc6XbVEo2z85S6cqyAjCVhs5MbPuYwvUDgYDI4wCTkTxBneNfyCVKaUAlAF4ufaU3pnk6yRhaRzJm803uaH179IuDSgrRNClWrmow57rBGbWXNaek4S1Ir9Qg+5kk9Zrfb1oFRc6hhvcKayhwOQX44Mvlkug==
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: 0q00Z6UV7gsO8BM+hawIdqRoH4csyhegGORvXEeE187ozq2qLLFT5Mrf3ugaInK+Le34zm/yp2gwDOQXgRG+cauWMXvPFpVFcbUyWue373RsO+qq4RpZrJ7ug8DKrWH8S0G2Y4DSsXprziriSLOCy5VKzbLgVzVwnS2w2I0f29BgSXNCA0nFAFyUuQN5TQZKI3r/Fi03rm5MIjTRayWKCArp6Ub3JjXCxcGClGpb0dLQfJbLKdMAAYAEuiYNQMM3Rh1Bd2Z/HjL6fEazJk9xYp1keeWuzboJy3hPdpWpdYi2Z9Qf7Rtp5B5+kY9kmhTu2SY6BTesvfQLHrTVloHjGvnAWm+ixB8AMxiHODjAiW3MvZdZRiZnPn2idibRWk0/JmqHktvVhW/0KCcgBQow4VrBzXbIG9U5X5xMZQAfnsgPW8BPSiBtxQpsLLHbi/I9xKdeupMiAuISrYggbEFNeZuuSfRbd7K/ME2ELY+UDh7d+T1YbJoCQg4toayQIzLvkEo6bwGM/k3JJLMEFYGZpkLz1QNBOglJ6DaianO5Mu0jGul/ZTuE7tElfA/I2P6/qUl1H7fIoRhiSm//AGJwNMvnXDsIF85BbKYhM+s1GFgMO7HYzXCnp8bAely8oOtRsHPErlXJpYVJ4hEjDRVPpxvwwgrUgO27lYhjZk8vzgbzPJWtVa3J0sESX4WeSqBFEj5z5K/mi2AYKrQmvSkSszLYczVrxdB/gXOXJbTUSGdF86ou12ForD5Jaql5wYWM5L7zAMVu1BV7oTyCJmk+2KV0mtbcQxe+w2svLnv/MN/KbDLpWnbO69hJDudWUJB2ZP7Cpqxkfca1jPxONy+BTPOkt3InwbwGSF7knfcQ3nVIiLupj81wtDGw9ENcbpvHCtvGWeRDcPYm1pHDrE+4LwT2BEha6aMn1wY9jy3+9DXmKIobQbcEcSZQbvZ7EatqDl7TZv/q+dE+OhJI6tjzf/RLGR/U0YFUBMauBdrYf7ByONqDW2CzmtOkY23EbRzd85SfoSJRpfLe7bwcSv1lw1Tf06MNdW9rTRVb74rPk6TlHNvdBflkTdm/Xjv1DWhvFkmIgm3aPQlc+Apn0hTVnY/dtVWW/PgA65dWgW8jCGu0kSHsJvyIz0FS+G7s/skCFVO+DgN9gI10xmuV6TFbB3Q+mOyvuQeb7joRASGw/Yzz0kv0Dd/isgXoprBOoIIJrbNVwUHcGog0ZPGEfxDM+xy5ZrNlOQCzmWkD+wWBGQMRO6bZvtu/jMEYpGk2kKmvsMKmM5rMWhuDOgTXR4JWXFQut+siCo3vEgufGYefLjU=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-OriginatorOrg: sct-15-20-8534-20-msonline-outlook-a1430.templateTenant
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SN6PR06MB3935.namprd06.prod.outlook.com
X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-CrossTenant-Network-Message-Id: 1dfa2853-39d3-452a-f605-08dde5c241d9
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Aug 2025 23:34:24.7588 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa
X-MS-Exchange-CrossTenant-rms-persistedconsumerorg: 00000000-0000-0000-0000-000000000000
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR06MB6862
X-Spam-Score: 0.3 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.7 (/)
Indeed the original patch had some issues.
Here is an updated and working version of the original patch, tested agains=
t master.
From cd30b01d8e2ddb92398b2c890e50d0ab9903e0eb Mon Sep 17 00:00:00 2001
From: Gabriel Ribeiro <gabriel376@HIDDEN>
Date: Wed, 27 Aug 2025 20:25:25 -0300
Subject: [PATCH] Add completions-details to bookmark-completing-read
* lisp/bookmark.el (bookmark-completing-read--collection)
(bookmark-completing-read--affixation-function): New auxiliary
functions to add completions-details to bookmark-completing-read.
(bookmark-completing-read): Add completions-details.
---
lisp/bookmark.el | 33 +++++++++++++++++++++++++++++++--
1 file changed, 31 insertions(+), 2 deletions(-)
diff --git a/lisp/bookmark.el b/lisp/bookmark.el
index 344ad4ec7d0..e9ab8842eda 100644
--- a/lisp/bookmark.el
+++ b/lisp/bookmark.el
@@ -591,10 +591,39 @@ bookmark-completing-read
(let* ((completion-ignore-case bookmark-completion-ignore-case)
(default (unless (equal "" default) default)))
(completing-read (format-prompt prompt default)
- (completion-table-with-metadata
- bookmark-alist '((category . bookmark)))
+ #'bookmark-completing-read--collection
nil 0 nil 'bookmark-history default))))
+(defun bookmark-completing-read--collection (string pred action)
+ (if (eq action 'metadata)
+ `(metadata
+ (category . bookmark)
+ ,@(when completions-detailed
+ '((affixation-function . bookmark-completing-read--affixation-=
function))))
+ (complete-with-action action bookmark-alist string pred)))
+
+(defun bookmark-completing-read--affixation-function (bookmarks)
+ (let ((elements nil)
+ (result nil)
+ (spacing 2)
+ (pre-pad 0))
+ (dolist (name bookmarks)
+ (let* ((record (bookmark-get-bookmark name))
+ (type (or (bookmark-type-from-full-record record) ""))
+ (location (bookmark-location record)))
+ (push (list name type location) elements)
+ (setq pre-pad (max pre-pad (length type)))))
+ (pcase-dolist (`(,name ,type ,location) elements)
+ (push (list
+ name
+ (propertize (string-pad type (+ pre-pad spacing))
+ 'face 'completions-annotations)
+ (propertize (string-pad location
+ (+ (length location) spacing)
+ nil t)
+ 'face 'completions-annotations))
+ result))
+ result))
(defmacro bookmark-maybe-historicize-string (string)
"Put STRING into the bookmark prompt history, if caller non-interactive.
--
2.34.1
---
Gabriel
________________________________________
From: Stefan Kangas <stefankangas@HIDDEN>
Sent: Wednesday, February 12, 2025 12:11 AM
To: Karl Fogel
Cc: Eli Zaretskii; Gabriel; 59581 <at> debbugs.gnu.org
Subject: Re: bug#59581: 29.0.50; [PATCH] Add completions details to Bookmar=
ks
Karl Fogel <kfogel@HIDDEN> writes:
> On 01 Dec 2022, Eli Zaretskii wrote:
>>> From: Gabriel <gabriel376@HIDDEN>
>>> Date: Fri, 25 Nov 2022 16:19:38 -0300
>>> Description:
>>> Add completions details (see `completions-detailed') to Bookmarks. It
>>> affects all bookmark functions that make uses of
>>> `bookmark-completing-read' (e.g.: `bookmark-jump', `bookmark-relocate',
>>> `bookmark-insert-location', `bookmark-rename' etc). See also [1].
>>> [1] https://lists.gnu.org/archive/html/emacs-devel/2022-11/msg00995.htm=
l
>>
>>Karl, any comments to the patch?
>
> I applied this patch, reloaded bookmark.el, and then tested `M-x bookmark=
-jump'
> in two ways:
>
> 1) With `completions-detailed' =3D=3D nil (my default)
>
> 2) With `completions-detailed' =3D=3D t
>
> In case (1) I saw the expected default behavior. My bookmarks completed
> normally by name, and just their names were offered during completion.
>
> In case (2), though, things seemed broken. The "*Completions*" buffer sa=
ys "19
> possible completions:" at the top (as expected), but the buffer is otherw=
ise
> blank. And when I hit SPC or TAB at the "Jump to bookmark:" prompt, I ge=
t
> "[Wrong type argument: stringp, nil]" in the minibuffer. My "*Messages*"=
buffer
> fills with messages like this:
>
> Making completion list...
> #<subr F616e6f6e796d6f75732d6c616d626461_anonymous_lambda_56>: \
> Wrong type argument: stringp, nil
>
> Similar behavior happens for all the functions that depend on
> `bookmark-completing-read'.
>
> This is in Emacs 30.0.50 (built today from 'master', commit 1d5d2f16c330e=
).
>
> Gabriel, does the patch maybe need a bit of updating? I assume it worked=
for in
> the version of Emacs you originally wrote it in (which would be from a li=
ttl
> over a year ago now -- sorry for the delay; I wish I'd been able to follo=
w up to
> this sooner).
>
> Best regards,
> -Karl
Ping.
Gabriel, could you please look into the questions asked by Karl above?
X-Loop: help-debbugs@HIDDEN
Subject: bug#59581: 29.0.50; [PATCH] Add completions details to Bookmarks
Resent-From: Karl Fogel <kfogel@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 05 Sep 2025 20:59:02 +0000
Resent-Message-ID: <handler.59581.B59581.17571058818005 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 59581
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Gabriel do Nascimento Ribeiro <gabriel376@HIDDEN>
Cc: "59581 <at> debbugs.gnu.org" <59581 <at> debbugs.gnu.org>, Eli Zaretskii <eliz@HIDDEN>, Stefan Kangas <stefankangas@HIDDEN>
Reply-To: Karl Fogel <kfogel@HIDDEN>
Received: via spool by 59581-submit <at> debbugs.gnu.org id=B59581.17571058818005
(code B ref 59581); Fri, 05 Sep 2025 20:59:02 +0000
Received: (at 59581) by debbugs.gnu.org; 5 Sep 2025 20:58:01 +0000
Received: from localhost ([127.0.0.1]:57815 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1uudVQ-00024t-Q9
for submit <at> debbugs.gnu.org; Fri, 05 Sep 2025 16:58:01 -0400
Received: from sanpietro.red-bean.com ([45.79.25.59]:49186)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <kfogel@HIDDEN>)
id 1uudVM-00024f-Ng
for 59581 <at> debbugs.gnu.org; Fri, 05 Sep 2025 16:57:58 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
d=red-bean.com; s=202005newsp; h=Content-Type:MIME-Version:Message-ID:Date:
Reply-To:References:In-Reply-To:Subject:Cc:To:From:Sender:
Content-Transfer-Encoding:Content-ID:Content-Description;
bh=J0tIdSDo82WbPgk3oYhhXZklhTXXv3nzzEBsxMjTx+0=; t=1757105876; x=1758315476;
b=Lk06XlFexLOlMoLgpwBr0Szqfedr/0tt6mdZywneodaYSOpIsF7iFLpsK8HzIEKUUQ+/WxlPc57
56OQju64Cu5QDkXBdQYGH/1uQwAxszdvV88xaoasIslZr7FaLG2hKXODwkhzoSuvJFAS+sNsE8NNV
CpOubcdPWuqCdSdnsDAJSBOdiA1IJSl15G3lohlMaKCg1dibFFFLAdyNoSTX9+aReoyPR9akfDSGC
25x4+DEdIF7+4izV8+/sZ/nLJxr+lr9WCKopJ5GKCYVROn6x3jMvBwqsLnYAFEVzWT9zVVrC9nwda
V4BGJ+dSKW/K7gR8B+CsHRIMeaO7ItZaZ5+A==;
Received: from 99-112-125-163.lightspeed.cicril.sbcglobal.net
([99.112.125.163]:33820 helo=floss)
by sanpietro.red-bean.com with esmtpsa (TLS1.3) tls
TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96)
(envelope-from <kfogel@HIDDEN>) id 1uudVI-005ZAP-1G;
Fri, 05 Sep 2025 20:57:52 +0000
From: Karl Fogel <kfogel@HIDDEN>
In-Reply-To: <SN6PR06MB39355FE9BD83B5B4BC2C84DE8B38A@HIDDEN>
References: <SJ0PR06MB86091171C1021EAC173EE5B88B0E9@HIDDEN>
<83a647ikbs.fsf@HIDDEN> <8734vzm5mc.fsf@HIDDEN>
<CADwFkm=60odkdkO2eSD0=55ATYhFg9buNVe9x-Q+q39HQROnMg@HIDDEN>
<SN6PR06MB39355FE9BD83B5B4BC2C84DE8B38A@HIDDEN>
Date: Fri, 05 Sep 2025 15:57:50 -0500
Message-ID: <87ms7839dd.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13)
MIME-Version: 1.0
Content-Type: text/plain; format=flowed
X-Spam-Score: 0.0 (/)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)
On 27 Aug 2025, Gabriel do Nascimento Ribeiro wrote:
>Indeed the original patch had some issues.
>Here is an updated and working version of the original patch,
>tested against master.
Thank you, Gabriel.
I will be slow to review this, as I'm recovering from an
unexpected knee surgery, but it is in my queue and I will get to
it as soon as I can!
Best regards,
-Karl
X-Loop: help-debbugs@HIDDEN
Subject: bug#59581: 29.0.50; [PATCH] Add completions details to Bookmarks
Resent-From: Eli Zaretskii <eliz@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Sat, 27 Sep 2025 08:29:06 +0000
Resent-Message-ID: <handler.59581.B59581.175896172718862 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
X-GNU-PR-Message: followup 59581
X-GNU-PR-Package: emacs
X-GNU-PR-Keywords: patch
To: Karl Fogel <kfogel@HIDDEN>
Cc: gabriel376@HIDDEN, stefankangas@HIDDEN, 59581 <at> debbugs.gnu.org
Received: via spool by 59581-submit <at> debbugs.gnu.org id=B59581.175896172718862
(code B ref 59581); Sat, 27 Sep 2025 08:29:06 +0000
Received: (at 59581) by debbugs.gnu.org; 27 Sep 2025 08:28:47 +0000
Received: from localhost ([127.0.0.1]:38701 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1v2QIO-0004tl-3Q
for submit <at> debbugs.gnu.org; Sat, 27 Sep 2025 04:28:46 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:41460)
by debbugs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1v2QHR-0004i2-62
for 59581 <at> debbugs.gnu.org; Sat, 27 Sep 2025 04:27:47 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e])
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <eliz@HIDDEN>)
id 1v2QHK-0000LI-VZ; Sat, 27 Sep 2025 04:27:38 -0400
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org;
s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date:
mime-version; bh=P8meBQe4/6KMBseicaSwgwTKI68/M0PEMbcorqZIsoQ=; b=on51OkOt5rio
ayRgLO9bFXM+lYJXdUdF5xSm53vk400ukYUz5KLOqjC6jl4tO8uiEkvoZxpxajh56ugt2d6rYx7AB
BHnITXlBv94aEH1/xZOdrUvfk3b+Z4r6k47nWRn3L1xKPThBg66rW3bt5ipUh2IyjiWGl4RXBAGDH
2fh2NuunsN77tZ6xnZp3esNd30uGbrN3BnD878/zeqH3kBQ1DfKkVCRjM3cV9//gI78C8RPjVxmOK
1JQonz+P/8v2waOgmdq92+VEmfoRQWnXCxC9jAr5CIwdOBsFIn+2o9gfm9JGxQToRqJcM0Hb6BRAk
zfvBDW6MYKU1P0WCI4dnzQ==;
Date: Sat, 27 Sep 2025 11:27:33 +0300
Message-Id: <865xd49u6i.fsf@HIDDEN>
From: Eli Zaretskii <eliz@HIDDEN>
In-Reply-To: <87ms7839dd.fsf@HIDDEN> (message from Karl Fogel on Fri, 05
Sep 2025 15:57:50 -0500)
References: <SJ0PR06MB86091171C1021EAC173EE5B88B0E9@HIDDEN>
<83a647ikbs.fsf@HIDDEN> <8734vzm5mc.fsf@HIDDEN>
<CADwFkm=60odkdkO2eSD0=55ATYhFg9buNVe9x-Q+q39HQROnMg@HIDDEN>
<SN6PR06MB39355FE9BD83B5B4BC2C84DE8B38A@HIDDEN>
<87ms7839dd.fsf@HIDDEN>
X-Spam-Score: -2.3 (--)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
> From: Karl Fogel <kfogel@HIDDEN>
> Cc: Stefan Kangas <stefankangas@HIDDEN>, Eli Zaretskii <eliz@HIDDEN>,
> "59581 <at> debbugs.gnu.org" <59581 <at> debbugs.gnu.org>
> Date: Fri, 05 Sep 2025 15:57:50 -0500
>
> On 27 Aug 2025, Gabriel do Nascimento Ribeiro wrote:
> >Indeed the original patch had some issues.
> >Here is an updated and working version of the original patch,
> >tested against master.
>
> Thank you, Gabriel.
>
> I will be slow to review this, as I'm recovering from an
> unexpected knee surgery, but it is in my queue and I will get to
> it as soon as I can!
Did you have a chance to make some progress here?
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.