GNU bug report logs - #59601
29.0.50; csharp-mode variables missing prefix

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: emacs; Severity: wishlist; Reported by: Stefan Kangas <stefankangas@HIDDEN>; dated Sat, 26 Nov 2022 08:04:01 UTC; Maintainer for emacs is bug-gnu-emacs@HIDDEN.

Message received at 59601 <at> debbugs.gnu.org:


Received: (at 59601) by debbugs.gnu.org; 26 Nov 2022 19:17:13 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 26 14:17:12 2022
Received: from localhost ([127.0.0.1]:41452 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oz0fo-0003wC-Jz
	for submit <at> debbugs.gnu.org; Sat, 26 Nov 2022 14:17:12 -0500
Received: from out-109.mta0.migadu.com ([91.218.175.109]:60284)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <theo@HIDDEN>) id 1oz0fk-0003w5-79
 for 59601 <at> debbugs.gnu.org; Sat, 26 Nov 2022 14:17:11 -0500
X-Report-Abuse: Please report any abuse attempt to abuse@HIDDEN and
 include these headers.
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no;
 s=key1; t=1669490226;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 in-reply-to:in-reply-to:references:references;
 bh=H1XzB1ZuPdyB0xFSsKTlOj51eWWAFrYdPL0EWA9YXLs=;
 b=Un2ukrc7K7jOa5C7QIU9Xnj/DgC+ZdJTIpBUPBgHTH8/OZVuR/Vvb9X+5IZSghxFtHzrRs
 yuD50cUIhJEj9fCAqSJajGI0/PDS9YlaIKWZqgdRraGsCEYjw5aIvpj1NB2OwGa8C7Dgg+
 ss6WylBfronRrQ2PPONak2MiWAIDv55GMaJ84KQuox7njRNM33t4+cN5ljGmKvGz+eHYho
 Iph2m7W5kJ8448S2aQxoxJaZ0n/VYVB+uA80EDo4vpi/t33h54shk/VsaPPLDmWal+gJ8y
 QzgN/ohVXGWUNbxLY4IuRVPjZbhEkm9fFyXo/C3whf8dRA3C27LEWqIs0cDlWw==
From: Theodor Thornhill <theo@HIDDEN>
To: Stefan Kangas <stefankangas@HIDDEN>, 59601 <at> debbugs.gnu.org
Subject: Re: bug#59601: 29.0.50; csharp-mode variables missing prefix
In-Reply-To: <CADwFkm=ZaA7UHtswdXTt-EWGRg4c=0ws48ppjYgThE+cJcW3QA@HIDDEN>
References: <CADwFkm=ZaA7UHtswdXTt-EWGRg4c=0ws48ppjYgThE+cJcW3QA@HIDDEN>
Date: Sat, 26 Nov 2022 20:16:59 +0100
Message-ID: <87lenx4jbo.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain
X-Migadu-Flow: FLOW_OUT
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: 59601
Cc: acm@HIDDEN, Jostein =?utf-8?Q?Kj=C3=B8nigsen?= <jostein@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

Stefan Kangas <stefankangas@HIDDEN> writes:

> Severity: wishlist
>
> Should these variables have the prefix `csharp-'?
>
>     `codedoc-font-lock-doc-comments'
>     `codedoc-font-lock-keywords'
>
> I also see that `codedoc-font-lock-keywords' seems to be unused?

I believe they need to be like this, for some CC Mode magic reason. See
`javadoc-font-lock-keywords' and friends.  I believe CC Mode picks them
up and that they should follow that naming convention.  I've CC'd Alan
just to confirm.  If you agree Alan then they could be part of
cc-fonts.el now that csharp-mode is in core.  What do you think?

Theo




Information forwarded to bug-gnu-emacs@HIDDEN:
bug#59601; Package emacs. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 26 Nov 2022 08:04:00 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Nov 26 03:04:00 2022
Received: from localhost ([127.0.0.1]:37703 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1oyqAK-0000pi-JZ
	for submit <at> debbugs.gnu.org; Sat, 26 Nov 2022 03:04:00 -0500
Received: from lists.gnu.org ([209.51.188.17]:42906)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1oyqAG-0000pV-EA
 for submit <at> debbugs.gnu.org; Sat, 26 Nov 2022 03:03:58 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <stefankangas@HIDDEN>)
 id 1oyqAE-0002qs-Br
 for bug-gnu-emacs@HIDDEN; Sat, 26 Nov 2022 03:03:54 -0500
Received: from mail-oa1-x32.google.com ([2001:4860:4864:20::32])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <stefankangas@HIDDEN>)
 id 1oyqA8-0001iR-V6
 for bug-gnu-emacs@HIDDEN; Sat, 26 Nov 2022 03:03:50 -0500
Received: by mail-oa1-x32.google.com with SMTP id
 586e51a60fabf-13bd19c3b68so7556128fac.7
 for <bug-gnu-emacs@HIDDEN>; Sat, 26 Nov 2022 00:03:47 -0800 (PST)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=cuw/xTdagV6z5tzdygsZJ3UMyHeZjvbAl0ECNCJQeAQ=;
 b=LitSC7mDm9j38yCsos3jf0NrzijEX0QWFvShuDFQ0GTbJ6N6FOb0+NHiDMOJRCk/8D
 MKzX8PJ6s6EO+0A2jHk2MIU7gLLJ+UrDg0Cfw1B1CvdatTvukGpQPUVfIipTXddkqwWq
 3Eaf4MveoN7JU6LLfb/sH15m8kdIgltldpo/IgP52ui5wENnh0BK8lp1iNwSt+aFx3ag
 ZEAh/PapeJuPJFKPQO9JCwDYUdd+8bGB4iAGcRco4iZfnIdu5sWW0A6ivwCLkYac7OeE
 5NUYRlMsm3IX0gtL0ainXAMSKCY6hzxM0a4Mi3lbifftHgjqH+9KqNFO7XsyuOw6cVGT
 hsLQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=cuw/xTdagV6z5tzdygsZJ3UMyHeZjvbAl0ECNCJQeAQ=;
 b=0xeqmSfft/rnMAEI++0Hqbem2LL+v7rxbLtwkr1wIJ9ZC7QmPXEFE9vEXxE+VlSlw1
 OF92xqtGWlsouShcwqqNbbDhyHmDijNbbbgpq6YNp/zvji+Ww4iBlh1QlD72/IPSb1xC
 5J5VoRFdA3n0+xZYOcFCcE568u0jg8kkNPj92s8iHl3FC4U6yyO96AsLNVPsxlJP18zD
 mpF0jEf/7xf0ohQEZDRTkdkHmhFOU83nf2FQPiqPkdQ6nAFEn5mDT7d7vNVTtp6/vDBP
 JQfnPM8bRj9BXhQL2qHGoRUmCuIdjJVRewy7+nm9/IgyqX5nF1BKNRefGfG6sQ/2Fb/7
 iyoA==
X-Gm-Message-State: ANoB5pnHm3vek2C4g3eJzSu7uTDMJ63OqvQVKBcDZ66Fz/2l7U4hemWT
 NC8Dfzna6ofCBqeCfibkXZjw0LV+qQKCxprgaS0+nx+GAuA=
X-Google-Smtp-Source: AA0mqf5bKtj7GGcJDgC1IfUTm8lWlCrK2tjcT7TzgXM5cmbx2sC83IDnEKG3FGWcsz1XKr+VBomkwNFMl4kHcIl8IXU=
X-Received: by 2002:a05:6870:cc89:b0:12b:fbe7:b793 with SMTP id
 ot9-20020a056870cc8900b0012bfbe7b793mr25460913oab.92.1669449826340; Sat, 26
 Nov 2022 00:03:46 -0800 (PST)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Sat, 26 Nov 2022 00:03:45 -0800
From: Stefan Kangas <stefankangas@HIDDEN>
X-Debbugs-CC: =?UTF-8?Q?Theodor_Thornhill_=3Ctheo=40thornhill=2Eno=3E=2C_Jostein_?=
 =?UTF-8?Q?Kj=C3=B8nigsen_=3Cjostein=40kjonigsen=2Enet=3E?=
X-Hashcash: 1:20:221126:bug-gnu-emacs@HIDDEN::fiJTLsFGeuBH6jdZ:pXI
MIME-Version: 1.0
Date: Sat, 26 Nov 2022 00:03:45 -0800
Message-ID: <CADwFkm=ZaA7UHtswdXTt-EWGRg4c=0ws48ppjYgThE+cJcW3QA@HIDDEN>
Subject: 29.0.50; csharp-mode variables missing prefix
To: bug-gnu-emacs@HIDDEN
Content-Type: text/plain; charset="UTF-8"
Received-SPF: pass client-ip=2001:4860:4864:20::32;
 envelope-from=stefankangas@HIDDEN; helo=mail-oa1-x32.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

Severity: wishlist

Should these variables have the prefix `csharp-'?

    `codedoc-font-lock-doc-comments'
    `codedoc-font-lock-keywords'

I also see that `codedoc-font-lock-keywords' seems to be unused?




Acknowledgement sent to Stefan Kangas <stefankangas@HIDDEN>:
New bug report received and forwarded. Copy sent to theo@HIDDEN, jostein@HIDDEN, bug-gnu-emacs@HIDDEN. Full text available.
Report forwarded to theo@HIDDEN, jostein@HIDDEN, bug-gnu-emacs@HIDDEN:
bug#59601; Package emacs. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sat, 26 Nov 2022 19:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.