GNU bug report logs - #59648
[PATCH] gnu: icedove: Use native notifications when available

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59648 in the body.
You can then email your comments to 59648 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: SeerLite <seerlite <at> nixnet.email>
To: guix-patches <at> gnu.org
Cc: SeerLite <seerlite <at> nixnet.email>
Subject: [PATCH] gnu: icedove: Use native notifications when available
Date: Mon, 28 Nov 2022 01:54:09 -0300

* gnu/packages/gnuzilla.scm (icedove)[phases]{wrap-program}: Add libnotify
to LD_LIBRARY_PATH.
---
 gnu/packages/gnuzilla.scm | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/gnuzilla.scm b/gnu/packages/gnuzilla.scm
index feb80d81a2..6a8ee41a1e 100644
--- a/gnu/packages/gnuzilla.scm
+++ b/gnu/packages/gnuzilla.scm
@@ -1189,6 +1189,7 @@ (define (runpaths-of-input label)
                                         "eudev"
                                         "pulseaudio"
                                         ;; For the integration of native notifications
+                                        ;; (same reason as icedove)
                                         "libnotify"))))
                 (wrap-program (car (find-files lib "^icecat$"))
                   `("XDG_DATA_DIRS" prefix (,gtk-share))
@@ -1496,10 +1497,13 @@ (define-public icedove
                      (pulseaudio #$(this-package-input "pulseaudio"))
                      (pulseaudio-lib (string-append pulseaudio "/lib"))
                      (eudev #$(this-package-input "eudev"))
-                     (eudev-lib (string-append eudev "/lib")))
+                     (eudev-lib (string-append eudev "/lib"))
+                     ;; For the integration of native notifications (same reason as icecat)
+                     (libnotify #$(this-package-input "libnotify"))
+                     (libnotify-lib (string-append libnotify "/lib")))
                 (wrap-program (car (find-files lib "^icedove$"))
                   `("XDG_DATA_DIRS" prefix (,gtk-share))
-                  `("LD_LIBRARY_PATH" prefix (,pulseaudio-lib ,eudev-lib)))))))))
+                  `("LD_LIBRARY_PATH" prefix (,pulseaudio-lib ,eudev-lib ,libnotify-lib)))))))))
     (inputs
      (list alsa-lib
            bzip2
@@ -1519,6 +1523,7 @@ (define-public icedove
            libffi
            libgnome
            libjpeg-turbo
+           libnotify
            libpng-apng
            libvpx
            libxcomposite
-- 
2.38.1

Message #8 received at 59648 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: SeerLite <seerlite <at> nixnet.email>
Cc: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>, 59648 <at> debbugs.gnu.org
Subject: Re: bug#59648: [PATCH] gnu: icedove: Use native notifications when
 available
Date: Mon, 05 Dec 2022 17:17:24 +0100

Hi,

SeerLite <seerlite <at> nixnet.email> skribis:

> * gnu/packages/gnuzilla.scm (icedove)[phases]{wrap-program}: Add libnotify
> to LD_LIBRARY_PATH.

Jonathan: this one’s for you.  :-)

Ludo’.

Message #11 received at 59648 <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: 59648 <at> debbugs.gnu.org
Subject: [PATCH] gnu: icedove: Use native notifications when available
Date: Thu, 8 Dec 2022 16:09:36 +0100

Hello SeerNet,

hm, when I enable notifications in Thunderbird I get notifications from
my sway desktop:
I just enabled it via Settings -> General -> Incoming Messages -> When
new messages arrive -> [x] Show an alert.

This is without your patch applied...

~Jonathan

Message #16 received at 59648 <at> debbugs.gnu.org (full text, mbox):

From: SeerLite <seerlite <at> disroot.org>
To: 59648 <at> debbugs.gnu.org, jonathan.brielmaier <at> web.de
Subject: [PATCH] gnu: icedove: Use native notifications when available
Date: Sun, 19 Feb 2023 01:39:51 +0000

Hi! Sorry, I didn't receive this response when it was sent, and it 
wasn't in my inbox.

> Hello SeerNet,

It's SeerLite :s

> hm, when I enable notifications in Thunderbird I get notifications from
> my sway desktop:
> I just enabled it via Settings -> General -> Incoming Messages -> When
> new messages arrive -> [x] Show an alert.
> 
> This is without your patch applied...

Yes, that's the same for me as well. The issue is not that there aren't 
notifications, but that IceDove chooses to use its own fallback 
implementation of them rather than using the program configured to send 
them (in my case it's dunst). Without my patch I get large notifications 
inconsistent with my setup. With my patch I get my custom configured 
dunst notifications.

I'm pretty sure Icecat would use the same fallback notification 
implementation if it didn't have libnotify. That's how I found out about 
this issue back when I made the patch after all, but I can't remember 
the details anymore. All I can say is Icedove uses the right 
notifications on my machine with the patch applied.

I hope that explains the difference and maybe you're able to reproduce 
the issue.

PS: I was actually actively waiting for a response since I sent the 
patch (same as my other patch). Unfortunately I didn't check mumi 
earlier. I've also changed my E-mail provider as the server I was 
previously using was having a hard time getting to Debbugs.

Message #21 received at 59648-done <at> debbugs.gnu.org (full text, mbox):

From: Jonathan Brielmaier <jonathan.brielmaier <at> web.de>
To: 59648-done <at> debbugs.gnu.org
Subject: [PATCH] gnu: icedove: Use native notifications when available
Date: Wed, 12 Apr 2023 10:34:05 +0200

Hello SeerLite,

rebased and pushed as a3239ffd84e6ee9d9494085ddc3b875ebf43e225.

~Jonathan

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.