GNU bug report logs - #59688
[PATCH] gnu: Add zls

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59688 in the body.
You can then email your comments to 59688 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mája Tomášek <maya.tomasek <at> disroot.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add zls
Date: Tue, 29 Nov 2022 20:08:01 +0100

[Message part 1 (text/plain, inline)]

Hi,

this is a patch that adds the zls - zig language server. It is not currently
the most recent version, as the project follows versions of zig itself, which
is in guix one version behind. (as zig became self hosted)

Kind regards,
Maya

[0001-gnu-Add-zls.patch (text/x-patch, attachment)]

Message #8 received at 59688 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Mája Tomášek <maya.tomasek <at> disroot.org>
Cc: 59688 <at> debbugs.gnu.org
Subject: Re: bug#59688: [PATCH] gnu: Add zls
Date: Wed, 14 Dec 2022 12:08:28 +0100

Hi Mája,

Mája Tomášek <maya.tomasek <at> disroot.org> skribis:

> this is a patch that adds the zls - zig language server. It is not currently
> the most recent version, as the project follows versions of zig itself, which
> is in guix one version behind. (as zig became self hosted)

Could you resend the patch to 59688 <at> debbugs.gnu.org using ‘git
send-email’ so that https://qa.guix.gnu.org can pick it up?

> ---
>  gnu/packages/zig-xyz.scm | 70 ++++++++++++++++++++++++++++++++++++++++

Please add the new file to gnu/local.mk.

> +    (synopsis "Zig language server")
> +    (description "Zig Language Server is a language server for the @code{zig} programming language.")

Could you expound the description a bit?  For instance, by mentioning
“Language Server Protocol (LSP)” so that there’s no ambiguity as to the
kind of “language server” we’re talking about?

> +zig-zls

You can remove this line.

Thanks in advance!

Ludo’.

Message #11 received at 59688 <at> debbugs.gnu.org (full text, mbox):

From: Maya Tomasek <maya.tomasek <at> disroot.org>
To: 59688 <at> debbugs.gnu.org
Cc: Maya Tomasek <maya.omase <at> protonmail.com>
Subject: [PATCH] gnu: Add zls
Date: Sat, 17 Dec 2022 12:41:48 +0100

From: Maya Tomasek <maya.omase <at> protonmail.com>

---
 gnu/local.mk             |  1 +
 gnu/packages/zig-xyz.scm | 68 ++++++++++++++++++++++++++++++++++++++++
 2 files changed, 69 insertions(+)
 create mode 100644 gnu/packages/zig-xyz.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index 9120d7a263..ad47fcd216 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -641,6 +641,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/xorg.scm				\
   %D%/packages/xfce.scm				\
   %D%/packages/zig.scm				\
+  %D%/packages/zig-xyz.scm			\
   %D%/packages/zile.scm				\
   %D%/packages/zwave.scm			\
 						\
diff --git a/gnu/packages/zig-xyz.scm b/gnu/packages/zig-xyz.scm
new file mode 100644
index 0000000000..131d200ec7
--- /dev/null
+++ b/gnu/packages/zig-xyz.scm
@@ -0,0 +1,68 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2022 Maya Tomasek <maya.tomasek <at> disroot.org>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages zig-xyz)
+  #:use-module (guix packages)
+  #:use-module (guix git-download)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix build-system gnu)
+  #:use-module (guix gexp)
+  #:use-module (gnu packages)
+  #:use-module (gnu packages zig)
+  #:use-module (gnu packages python))
+
+(define-public zig-zls
+  (package
+    (name "zig-zls")
+    (version "0.9.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/zigtools/zls")
+                    (commit version)
+                    (recursive? #t)))
+              (sha256
+               (base32 "1hhs7dz9rpshfd1a7x5swmix2rmh53vsqskh3mzqlrj2lgb3cnii"))))
+    (build-system gnu-build-system)
+    (inputs (list zig python))
+    (arguments
+     (list
+      #:modules '((guix build gnu-build-system)
+                  (guix build utils))
+      #:phases
+      #~(modify-phases %standard-phases
+          (delete 'configure)
+          (replace 'build
+            (lambda* (#:key outputs #:allow-other-keys)
+              (let ((out (assoc-ref outputs "out"))
+                    (zig (string-append #$zig "/bin/zig")))
+                ;; zig defaults it's cache dir to subdir of $HOME, which is not defined in the build environment
+                (setenv "ZIG_GLOBAL_CACHE_DIR"
+                        (string-append (getcwd) "/zig-cache"))
+                ;; invoke the install target of the build command
+                (invoke zig "build" "install" "-Drelease-safe" "--prefix" out))))
+          (delete 'install)
+          (replace 'check
+            (lambda _
+              (let ((zig (string-append #$zig "/bin/zig")))
+                ;; run the test target
+                (invoke zig "build" "test")))))))
+    (synopsis "Zig language server")
+    (description "Zig Language Server is a language server implementing the Language Server Protocol (LSP) for the @code{zig} programming language.")
+    (home-page "https://github.com/zigtools/zls")
+    (license license:expat)))
-- 
2.38.1

Message #16 received at 59688-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Maya Tomasek <maya.tomasek <at> disroot.org>
Cc: Maya Tomasek <maya.omase <at> protonmail.com>, 59688-done <at> debbugs.gnu.org
Subject: Re: bug#59688: [PATCH] gnu: Add zls
Date: Thu, 05 Jan 2023 22:37:26 +0100

[Message part 1 (text/plain, inline)]

Hi,

Maya Tomasek <maya.tomasek <at> disroot.org> skribis:

> From: Maya Tomasek <maya.omase <at> protonmail.com>
>
> ---
>  gnu/local.mk             |  1 +
>  gnu/packages/zig-xyz.scm | 68 ++++++++++++++++++++++++++++++++++++++++

Finally applied with a commit log as well as simplifications and
cosmetic changes to address the ‘guix lint’ warnings (see below).

Thanks!

Ludo’.

[Message part 2 (text/x-patch, inline)]

diff --git a/gnu/packages/zig-xyz.scm b/gnu/packages/zig-xyz.scm
index 131d200ec7..3812aa0125 100644
--- a/gnu/packages/zig-xyz.scm
+++ b/gnu/packages/zig-xyz.scm
@@ -36,33 +36,30 @@ (define-public zig-zls
                     (url "https://github.com/zigtools/zls")
                     (commit version)
                     (recursive? #t)))
+              (file-name (git-file-name name version))
               (sha256
-               (base32 "1hhs7dz9rpshfd1a7x5swmix2rmh53vsqskh3mzqlrj2lgb3cnii"))))
+               (base32
+                "1hhs7dz9rpshfd1a7x5swmix2rmh53vsqskh3mzqlrj2lgb3cnii"))))
     (build-system gnu-build-system)
     (inputs (list zig python))
     (arguments
-     (list
-      #:modules '((guix build gnu-build-system)
-                  (guix build utils))
-      #:phases
-      #~(modify-phases %standard-phases
-          (delete 'configure)
-          (replace 'build
-            (lambda* (#:key outputs #:allow-other-keys)
-              (let ((out (assoc-ref outputs "out"))
-                    (zig (string-append #$zig "/bin/zig")))
-                ;; zig defaults it's cache dir to subdir of $HOME, which is not defined in the build environment
-                (setenv "ZIG_GLOBAL_CACHE_DIR"
-                        (string-append (getcwd) "/zig-cache"))
-                ;; invoke the install target of the build command
-                (invoke zig "build" "install" "-Drelease-safe" "--prefix" out))))
-          (delete 'install)
-          (replace 'check
-            (lambda _
-              (let ((zig (string-append #$zig "/bin/zig")))
-                ;; run the test target
-                (invoke zig "build" "test")))))))
+     (list #:phases #~(modify-phases %standard-phases
+                        (delete 'configure)
+                        (replace 'build
+                          (lambda* (#:key outputs #:allow-other-keys)
+                            (let ((out (assoc-ref outputs "out")))
+                              (setenv "ZIG_GLOBAL_CACHE_DIR"
+                                      (string-append (getcwd) "/zig-cache"))
+                              (invoke "zig" "build" "install"
+                                      "-Drelease-safe" "--prefix" out))))
+                        (delete 'install)
+                        (replace 'check
+                          (lambda* (#:key tests? #:allow-other-keys)
+                            (when tests?
+                              (invoke "zig" "build" "test")))))))
     (synopsis "Zig language server")
-    (description "Zig Language Server is a language server implementing the Language Server Protocol (LSP) for the @code{zig} programming language.")
+    (description
+     "Zig Language Server is a language server implementing the @acronym{LSP,
+Language Server Protocol} for the Zig programming language.")
     (home-page "https://github.com/zigtools/zls")
     (license license:expat)))

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.