GNU bug report logs - #59700
[DOCUMENTATION] [PATCH] doc: Move %facebook-host-aliases to operating-system.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59700 in the body.
You can then email your comments to 59700 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: guix-patches <at> gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH 0/1] doc: Move %facebook-host-aliases to operating-system.
Date: Tue, 29 Nov 2022 21:44:53 +0000

Looks misplaced among the various service definitions.

Bruno Victal (1):
  doc: Move %facebook-host-aliases to operating-system.

 doc/guix.texi | 58 +++++++++++++++++++++++++--------------------------
 1 file changed, 29 insertions(+), 29 deletions(-)


base-commit: aaf1f18b8044142515ff868bcbd2b72b81ced3ec
-- 
2.38.1

Message #8 received at 59700 <at> debbugs.gnu.org (full text, mbox):

From: mirai <at> makinata.eu
To: 59700 <at> debbugs.gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH 1/1] doc: Move %facebook-host-aliases to operating-system.
Date: Tue, 29 Nov 2022 21:47:13 +0000

From: Bruno Victal <mirai <at> makinata.eu>

---
 doc/guix.texi | 58 +++++++++++++++++++++++++--------------------------
 1 file changed, 29 insertions(+), 29 deletions(-)

diff --git a/doc/guix.texi b/doc/guix.texi
index 47b805dc7f..3636c45b29 100644
--- a/doc/guix.texi
+++ b/doc/guix.texi
@@ -16530,6 +16530,35 @@ It is an error to refer to @code{this-operating-system} outside an operating
 system definition.
 @end deffn
 
+@defvr {Scheme Variable} %facebook-host-aliases
+This variable contains a string for use in @file{/etc/hosts}
+(@pxref{Host Names,,, libc, The GNU C Library Reference Manual}).  Each
+line contains a entry that maps a known server name of the Facebook
+on-line service---e.g., @code{www.facebook.com}---to the local
+host---@code{127.0.0.1} or its IPv6 equivalent, @code{::1}.
+
+This variable is typically used in the @code{hosts-file} field of an
+@code{operating-system} declaration (@pxref{operating-system Reference,
+@file{/etc/hosts}}):
+
+@lisp
+(use-modules (gnu) (guix))
+
+(operating-system
+  (host-name "mymachine")
+  ;; ...
+  (hosts-file
+    ;; Create a /etc/hosts file with aliases for "localhost"
+    ;; and "mymachine", as well as for Facebook servers.
+    (plain-file "hosts"
+                (string-append (local-host-aliases host-name)
+                               %facebook-host-aliases))))
+@end lisp
+
+This mechanism can prevent programs running locally, such as Web
+browsers, from accessing Facebook.
+@end defvr
+
 @end deftp
 
 @node File Systems
@@ -20841,35 +20870,6 @@ Logging level.
 @end table
 @end deftp
 
-@defvr {Scheme Variable} %facebook-host-aliases
-This variable contains a string for use in @file{/etc/hosts}
-(@pxref{Host Names,,, libc, The GNU C Library Reference Manual}).  Each
-line contains a entry that maps a known server name of the Facebook
-on-line service---e.g., @code{www.facebook.com}---to the local
-host---@code{127.0.0.1} or its IPv6 equivalent, @code{::1}.
-
-This variable is typically used in the @code{hosts-file} field of an
-@code{operating-system} declaration (@pxref{operating-system Reference,
-@file{/etc/hosts}}):
-
-@lisp
-(use-modules (gnu) (guix))
-
-(operating-system
-  (host-name "mymachine")
-  ;; ...
-  (hosts-file
-    ;; Create a /etc/hosts file with aliases for "localhost"
-    ;; and "mymachine", as well as for Facebook servers.
-    (plain-file "hosts"
-                (string-append (local-host-aliases host-name)
-                               %facebook-host-aliases))))
-@end lisp
-
-This mechanism can prevent programs running locally, such as Web
-browsers, from accessing Facebook.
-@end defvr
-
 The @code{(gnu services avahi)} provides the following definition.
 
 @defvr {Scheme Variable} avahi-service-type
-- 
2.38.1

Message #13 received at 59700 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: mirai <at> makinata.eu
Cc: 59700 <at> debbugs.gnu.org
Subject: Re: bug#59700: [DOCUMENTATION] [PATCH] doc: Move
 %facebook-host-aliases to operating-system.
Date: Tue, 03 Jan 2023 17:01:09 -0500

Hi Bruno,

mirai <at> makinata.eu writes:

Putting a facebook related stanzas

> From: Bruno Victal <mirai <at> makinata.eu>
>
> ---
>  doc/guix.texi | 58 +++++++++++++++++++++++++--------------------------
>  1 file changed, 29 insertions(+), 29 deletions(-)

Please include a GNU Changelog commit message, it makes it easy to
comprehend the changes (see: info "(standards) Style of Change Logs"
from the 'standards' package).

Moving %facebook-hosts-aliases to under the 'operating-system Reference'
from network services doesn't seem an improvement to me (it seems even
more out of place to me).

I'd err on the side of the status quo.

What do you think?

Maxim

Message #18 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ryan Sundberg <ryan <at> arctype.co>
To: guix-patches <at> gnu.org
Subject: Re: [bug#59700] [DOCUMENTATION] [PATCH] doc: Move
 %facebook-host-aliases to operating-system.
Date: Tue, 3 Jan 2023 14:07:19 -0800

[Message part 1 (text/plain, inline)]

Hi Maxim, Bruno,

In my opinion, this entire Facebook blocklist is out of scope of the
core operating system, and it should be removed entirely to reduce the
maintenance burden, and any other future attempt to add other hosts to
it. I am not sure how many users out there are relying on this behavior.

--
Sincerely,
Ryan Sundberg

On 1/3/23 2:01 PM, Maxim Cournoyer wrote:
> Hi Bruno,
> 
> mirai <at> makinata.eu writes:
> 
> Putting a facebook related stanzas
> 
>> From: Bruno Victal <mirai <at> makinata.eu>
>>
>> ---
>>  doc/guix.texi | 58 +++++++++++++++++++++++++--------------------------
>>  1 file changed, 29 insertions(+), 29 deletions(-)
> 
> Please include a GNU Changelog commit message, it makes it easy to
> comprehend the changes (see: info "(standards) Style of Change Logs"
> from the 'standards' package).
> 
> Moving %facebook-hosts-aliases to under the 'operating-system Reference'
> from network services doesn't seem an improvement to me (it seems even
> more out of place to me).
> 
> I'd err on the side of the status quo.
> 
> What do you think?
> 
> Maxim

[OpenPGP_signature (application/pgp-signature, attachment)]

Message #21 received at 59700 <at> debbugs.gnu.org (full text, mbox):

From: mirai <mirai <at> makinata.eu>
To: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
Cc: 59700 <at> debbugs.gnu.org
Subject: Re: bug#59700: [DOCUMENTATION] [PATCH] doc: Move
 %facebook-host-aliases to operating-system.
Date: Thu, 5 Jan 2023 16:07:01 +0000

On 2023-01-03 22:01, Maxim Cournoyer wrote:
> Moving %facebook-hosts-aliases to under the 'operating-system Reference'
> from network services doesn't seem an improvement to me (it seems even
> more out of place to me).

I placed it under 'operating-system Reference' because of the proximity to 'hosts-file' field
and the usage example seems to suggest it's a better fit here.

> 
> I'd err on the side of the status quo.
> 
> What do you think?

I think its current location (Network services) is extremely strange as %facebook-host-aliases
is not a service and given the usage example it fits better elsewhere.


Bruno

Message #24 received at 59700 <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: mirai <mirai <at> makinata.eu>
Cc: 59700 <at> debbugs.gnu.org
Subject: Re: bug#59700: [DOCUMENTATION] [PATCH] doc: Move
 %facebook-host-aliases to operating-system.
Date: Thu, 05 Jan 2023 11:23:05 -0500

Hi,

mirai <mirai <at> makinata.eu> writes:

> On 2023-01-03 22:01, Maxim Cournoyer wrote:
>> Moving %facebook-hosts-aliases to under the 'operating-system Reference'
>> from network services doesn't seem an improvement to me (it seems even
>> more out of place to me).
>
> I placed it under 'operating-system Reference' because of the proximity to 'hosts-file' field
> and the usage example seems to suggest it's a better fit here.
>
>> 
>> I'd err on the side of the status quo.
>> 
>> What do you think?
>
> I think its current location (Network services) is extremely strange as %facebook-host-aliases
> is not a service and given the usage example it fits better elsewhere.

I gathered another opinion on #guix from civodul, which thought status
quo is appropriate, though they mentioned turning host-file into a
service would be nice to make it more extendable.  Perhaps you could
look into this, if you want to improve things in that direction?

-- 
Thanks,
Maxim

Message #29 received at 59700-done <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: 59700-done <at> debbugs.gnu.org
Date: Thu, 9 Feb 2023 01:02:48 +0000

Completed with #60735.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.