GNU logs - #59743, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#59743: Implement `command-line-args-left' for emacsclient --eval expressions
Resent-From: Max Nikulin <manikulin@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 01 Dec 2022 15:07:02 +0000
Resent-Message-ID: <handler.59743.B.166990717632653 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 59743 <at> debbugs.gnu.org
Message-ID: <438a7286-ee4c-74a1-c24b-d788a6507ad6@HIDDEN>
Date: Thu, 1 Dec 2022 22:06:00 +0700
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.4.2
Content-Language: en-US
From: Max Nikulin <manikulin@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Received-SPF: pass client-ip=2a00:1450:4864:20::22b;
 envelope-from=manikulin@HIDDEN; helo=mail-lj1-x22b.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

I propose to expand protocol of communication between emacsclient and 
server to allow passing of arbitrary arguments for --eval expression
that are not treated as files. The goal is to pass strings to evaluated 
expressions in a safe way without necessity of escaping double quotes 
and backslashes.

I suggest to add e,g, --args option of emacsclient that transfers 
everything after it (including arguments starting with dash) to server 
and causes let-binding the list to command-line-args-left (or another 
variable) before execution of preceding --eval options.

It was briefly discussed in the following thread: Max Nikulin to 
emacs-orgmode. Re: Lazy load of org-protocol. Mon, 7 Feb 2022 21:57:09 
+0700. https://list.orgmode.org/strc07$3o0$1@HIDDEN

Such feature will allow to avoid the following complications:
- A lot of backslashes are used to escape double quotes in
 
http://git.savannah.gnu.org/cgit/emacs.git/tree/etc/emacsclient-mail.desktop
        --eval \\\\(message-mailto\\\\ \\\\\\"%u\\\\\\"\\\\)
   and this file still relies on desktop environment protection
   against shell special characters in the value of %u
- org-protocol sets an advice to intercept file names containing
   components like org-protocol:/store-link?url=URL&title=TITLE
   It is a hack since current working directory is prepended
   when such URI is specified as an emacsclient argument.
   Autoloading currently is not implemented for this advice.
- There are enough unsafe suggestions on the web to directly inject
   argument into elisp expression without proper escaping.

Consider the following message: Gregory Heytings to emacs-devel. Re: How 
to get DISPLAY of emacsclient? Mon, 28 Nov 2022 17:15:28 +0000. 
https://lists.gnu.org/archive/html/emacs-devel/2022-11/msg01771.html 
mid:338f50d42149668a6b3a@HIDDEN

     emacsclient --eval '(progn (setq display "'$DISPLAY'") (princ 
display))'

Despite probability of such event is rather low, accidentally DISPLAY 
value may be corrupted causing undesired effects of unsafe usage of the 
variable:
- Word splitting is performed by shell after variable substitution.
- If $DISPLAY is additionally wrapped into shell double quotes
   then something unexpected may still be executed by emacs
        DISPLAY=':0") (do-something-else) (ignore "'

More examples of unsafe substitutions into evaluated expression:
- 
https://www.reddit.com/r/emacs/comments/hhbcg7/emacsclient_eval_with_command_line_arguments/
- 
https://stackoverflow.com/questions/8848819/emacs-eval-ediff-1-2-how-to-put-this-line-in-to-shell-script
the second link contains a recipe for proper quoting, but it is not
in the accepted answer
     quoted1=${1//\\/\\\\}; quoted1=${quoted1//\"/\\\"}

As an alternative, Jim Porter suggested an emacsclient option similar to 
emacs --funcall that should apply function to the following argument. I 
believe, if --args is implemented then it will be possible to define a 
helper function that combines function name and the 
command-line-args-left list. It will not require further extension of 
client-server protocol. Since the function to be applied must take 
strings arguments only, no integers or symbols are allowed, anyway 
wrapper functions to convert argument types will be required. That is 
why I do not expect real value of such apply feature.

I hope, the

     emacsclient --eval "(message-mailto (car command-line-args-left))" \
         --args mailto:bug-gnu-emacs@HIDDEN

feature will make it easier to pass arguments to the evaluated 
expressions in a safe way.

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Max Nikulin <manikulin@HIDDEN>
Subject: bug#59743: Acknowledgement (Implement `command-line-args-left'
 for emacsclient --eval expressions)
Message-ID: <handler.59743.B.166990717632653.ack <at> debbugs.gnu.org>
References: <438a7286-ee4c-74a1-c24b-d788a6507ad6@HIDDEN>
X-Gnu-PR-Message: ack 59743
X-Gnu-PR-Package: emacs
Reply-To: 59743 <at> debbugs.gnu.org
Date: Thu, 01 Dec 2022 15:07:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 59743 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
59743: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D59743
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#59743: Implement `command-line-args-left' for emacsclient --eval expressions
Resent-From: Jim Porter <jporterbugs@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Fri, 02 Dec 2022 02:17:01 +0000
Resent-Message-ID: <handler.59743.B59743.166994739718092 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Max Nikulin <manikulin@HIDDEN>, 59743 <at> debbugs.gnu.org
Message-ID: <29ab47d9-507a-08ae-9b40-0662168eb9cb@HIDDEN>
Date: Thu, 1 Dec 2022 18:16:25 -0800
MIME-Version: 1.0
Content-Language: en-US
References: <438a7286-ee4c-74a1-c24b-d788a6507ad6@HIDDEN>
From: Jim Porter <jporterbugs@HIDDEN>
In-Reply-To: <438a7286-ee4c-74a1-c24b-d788a6507ad6@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

On 12/1/2022 7:06 AM, Max Nikulin wrote:
> I propose to expand protocol of communication between emacsclient and 
> server to allow passing of arbitrary arguments for --eval expression
> that are not treated as files. The goal is to pass strings to evaluated 
> expressions in a safe way without necessity of escaping double quotes 
> and backslashes.
> 
> I suggest to add e,g, --args option of emacsclient that transfers 
> everything after it (including arguments starting with dash) to server 
> and causes let-binding the list to command-line-args-left (or another 
> variable) before execution of preceding --eval options.

I believe this is a duplicate of bug#57752, where I and several others 
previously discussed a few options to solve this.

Message received at control <at> debbugs.gnu.org:

Received: (at control) by debbugs.gnu.org; 4 Sep 2023 15:24:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Sep 04 11:24:50 2023
Received: from localhost ([127.0.0.1]:52305 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1qdBRa-0002rr-GK
	for submit <at> debbugs.gnu.org; Mon, 04 Sep 2023 11:24:50 -0400
Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]:53505)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <stefankangas@HIDDEN>) id 1qdBRY-0002rb-Uw
 for control <at> debbugs.gnu.org; Mon, 04 Sep 2023 11:24:49 -0400
Received: by mail-lf1-x131.google.com with SMTP id
 2adb3069b0e04-50091b91a83so2641084e87.3
 for <control <at> debbugs.gnu.org>; Mon, 04 Sep 2023 08:24:48 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=gmail.com; s=20221208; t=1693841083; x=1694445883; darn=debbugs.gnu.org;
 h=to:subject:message-id:date:mime-version:from:from:to:cc:subject
 :date:message-id:reply-to;
 bh=Au5yX2lP4WDKMFn4o7g1B5puciypHeAWIS4R8iDR08o=;
 b=W6w2LPCYNSjopImgUqpmjS0R01eJDro8vEgXeJh1Nc+kTDGaEJrbcXfRuMQxx41ji5
 pPx9rgqfZQ7jnvh164j4kfQICTRrSmVCBZpHTEhlSUsTr2uh/6JmbXpTnh2ryKgab6pE
 pval+ROc/5ED4FQ5k0pas7jsXwtMgHe2TdyZlAz1e4dx0HdXNbgSXXhvuY0JA6WGnrEw
 ONfCz5sOwOTFyVVpA3aSDHf8bN5iSQbUcuDuyZo0JIUp9AwV3tQAbRzmvLsX3YrGWL8q
 qg+J+rvOo5pBo1VP5kBVI0MeLqGmfM7bNRgvR96PbxTDWGKGEJZhaTzdLOwSSFvRZpeH
 aHbg==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20221208; t=1693841083; x=1694445883;
 h=to:subject:message-id:date:mime-version:from:x-gm-message-state
 :from:to:cc:subject:date:message-id:reply-to;
 bh=Au5yX2lP4WDKMFn4o7g1B5puciypHeAWIS4R8iDR08o=;
 b=GnSV8AFI83MoSwPh27Wz5UGFj2w+Wer8+kL9Acp6/z6hrqRT7fL964Obk2NbIKELoR
 hdaDHb2aJOnlCJ30QBhaE/diI7icaKMX/t8JN1sk5nB6u9vRgUdY0fYv3J+awi2yEN2d
 K2D+ZAfKW5WQkqSn48yVNGuUbva5h6OcW9uadS/LGjIS9rn+PWkuyiHkKylg7igmCV3S
 k8w6vWbuyfErYLkakbi4gpzkVMFwvkSP0j1lqVwMZfhALHzjd9+khcOy7bjKrgd2fPEJ
 Jlmg8+x0bRDERBudYGNJFq6X3Vwf8I4DFhET8zdoJtBHyO7fn0NCiZsTbHpR8Nvc0ANn
 VOtQ==
X-Gm-Message-State: AOJu0Yx2tzpDELdNeC3bvGw+NxUacxxPS+5QZ9lt0X6zw9oS2rETNzrC
 3vjRxKqcgFO129fN58ZKa7EZXW/yDNWFN5l4NfHGvcTf
X-Google-Smtp-Source: AGHT+IFp4KxtoBTd1A2JsRzzxlzKq+rYFvdabAQRS+OOlK/QWkkvOFQ/N5svOWujg20e+NNlgY0P9BWhu3+vXHvcp/M=
X-Received: by 2002:a19:670d:0:b0:500:c589:95fb with SMTP id
 b13-20020a19670d000000b00500c58995fbmr6964330lfc.55.1693841082877; Mon, 04
 Sep 2023 08:24:42 -0700 (PDT)
Received: from 753933720722 named unknown by gmailapi.google.com with
 HTTPREST; Mon, 4 Sep 2023 08:24:42 -0700
From: Stefan Kangas <stefankangas@HIDDEN>
MIME-Version: 1.0
Date: Mon, 4 Sep 2023 08:24:42 -0700
Message-ID: <CADwFkmnrQA47fD-FuVt7ZQOhXAB_NxqNhxOMuwpF-09_e8bWRg@HIDDEN>
Subject: control message for bug #59743
To: control <at> debbugs.gnu.org
Content-Type: text/plain; charset="UTF-8"
X-Spam-Score: 0.0 (/)
X-Debbugs-Envelope-To: control
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

forcemerge 59743 57752
quit

Last modified: Mon, 4 Sep 2023 15:30:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.