GNU bug report logs - #59747
[PATCH] services: configuration: rework alist? procedure

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59747 in the body.
You can then email your comments to 59747 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: mirai <at> makinata.eu
To: guix-patches <at> gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH] services: configuration: rework alist? procedure
Date: Thu,  1 Dec 2022 18:09:47 +0000

From: Bruno Victal <mirai <at> makinata.eu>

* gnu/services/configuration.scm: rework alist? procedure
---
 gnu/services/configuration.scm | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/gnu/services/configuration.scm b/gnu/services/configuration.scm
index dacfc52ba9..5bbb032c66 100644
--- a/gnu/services/configuration.scm
+++ b/gnu/services/configuration.scm
@@ -436,7 +436,11 @@ (define (list-of pred?)
 (define list-of-strings?
   (list-of string?))
 
-(define alist? list?)
+(define alist?
+  (match-lambda
+    (() #t)
+    ((and (= car head) (= cdr tail)) (and (pair? head) (alist? tail)))
+    (_ #f)))
 
 (define serialize-file-like empty-serializer)
 

base-commit: 748ec628826cea3faa3679074d87fae9bc810080
-- 
2.38.1

Message #10 received at 59747-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: mirai <at> makinata.eu
Cc: 59747-done <at> debbugs.gnu.org
Subject: Re: bug#59747: [PATCH] services: configuration: rework alist?
 procedure
Date: Thu, 08 Dec 2022 12:59:05 +0100

mirai <at> makinata.eu skribis:

> From: Bruno Victal <mirai <at> makinata.eu>
>
> * gnu/services/configuration.scm: rework alist? procedure

I simplified it a bit and applied.

Note that there are two other ‘*-alist?’ procedures…

But really, it’s the kind of predicate that shouldn’t be used because
there’s no disjoint alist data type in the first place.  It may be a
sign that we should use records instead in those places.

Thanks,
Ludo’.

Message #13 received at 59747 <at> debbugs.gnu.org (full text, mbox):

From: mirai <at> makinata.eu
To: 59747 <at> debbugs.gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH v2] services: configuration: rework alist? procedure
Date: Thu,  8 Dec 2022 12:07:06 +0000

From: Bruno Victal <mirai <at> makinata.eu>

* gnu/services/configuration.scm: rework alist? procedure
---
 gnu/services/configuration.scm | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/gnu/services/configuration.scm b/gnu/services/configuration.scm
index 2b3bd4c1f4..e0a5bd6728 100644
--- a/gnu/services/configuration.scm
+++ b/gnu/services/configuration.scm
@@ -436,7 +436,8 @@ (define (list-of pred?)
 (define list-of-strings?
   (list-of string?))
 
-(define alist? list?)
+(define alist?
+  (list-of pair?))
 
 (define serialize-file-like empty-serializer)
 

base-commit: fc774ece918d765f871d2fd079e622188e23f2da
-- 
2.38.1

Message #18 received at 59747 <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: 59747 <at> debbugs.gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH] services: configuration: simplify alist? procedure.
Date: Wed, 25 Jan 2023 16:37:53 +0000

* gnu/services/configuration.scm (alist?): simplify procedure.
---
 gnu/services/configuration.scm | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/gnu/services/configuration.scm b/gnu/services/configuration.scm
index 6b0291dc00..d4d9c3b1a6 100644
--- a/gnu/services/configuration.scm
+++ b/gnu/services/configuration.scm
@@ -437,10 +437,7 @@ (define list-of-strings?
   (list-of string?))
 
 (define alist?
-  (match-lambda
-    (() #t)
-    ((head . tail) (and (pair? head) (alist? tail)))
-    (_ #f)))
+  (list-of pair?))
 
 (define serialize-file-like empty-serializer)
 

base-commit: 0d713e0140f4c4a80de6cbfc58fae17cb69beb98
-- 
2.38.1

Message #21 received at 59747 <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: 59747 <at> debbugs.gnu.org
Cc: Bruno Victal <mirai <at> makinata.eu>
Subject: [PATCH v3] services: configuration: simplify alist? procedure.
Date: Wed, 25 Jan 2023 16:38:51 +0000

* gnu/services/configuration.scm (alist?): simplify procedure.
---

Last patch was sent without prefix.

 gnu/services/configuration.scm | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/gnu/services/configuration.scm b/gnu/services/configuration.scm
index 6b0291dc00..d4d9c3b1a6 100644
--- a/gnu/services/configuration.scm
+++ b/gnu/services/configuration.scm
@@ -437,10 +437,7 @@ (define list-of-strings?
   (list-of string?))
 
 (define alist?
-  (match-lambda
-    (() #t)
-    ((head . tail) (and (pair? head) (alist? tail)))
-    (_ #f)))
+  (list-of pair?))
 
 (define serialize-file-like empty-serializer)
 

base-commit: 0d713e0140f4c4a80de6cbfc58fae17cb69beb98
-- 
2.38.1

Message #24 received at 59747 <at> debbugs.gnu.org (full text, mbox):

From: Bruno Victal <mirai <at> makinata.eu>
To: 59747 <at> debbugs.gnu.org
Subject: Re: [PATCH v3] services: configuration: simplify alist? procedure.
Date: Sat, 18 Feb 2023 02:31:49 +0000

bump

Message #29 received at 59747-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Bruno Victal <mirai <at> makinata.eu>
Cc: 59747-done <at> debbugs.gnu.org
Subject: Re: bug#59747: [PATCH] services: configuration: rework alist?
 procedure
Date: Tue, 21 Mar 2023 09:52:02 -0400

Hi,

Bruno Victal <mirai <at> makinata.eu> writes:

> * gnu/services/configuration.scm (alist?): simplify procedure.
> ---
>
> Last patch was sent without prefix.
>
>  gnu/services/configuration.scm | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/gnu/services/configuration.scm b/gnu/services/configuration.scm
> index 6b0291dc00..d4d9c3b1a6 100644
> --- a/gnu/services/configuration.scm
> +++ b/gnu/services/configuration.scm
> @@ -437,10 +437,7 @@ (define list-of-strings?
>    (list-of string?))
>  
>  (define alist?
> -  (match-lambda
> -    (() #t)
> -    ((head . tail) (and (pair? head) (alist? tail)))
> -    (_ #f)))
> +  (list-of pair?))

Applied, thanks!

-- 
Thanks,
Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.