X-Loop: help-debbugs@HIDDEN Subject: [bug#59762] Add serial-studio Resent-From: phodina <phodina@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: guix-patches@HIDDEN Resent-Date: Fri, 02 Dec 2022 05:31:02 +0000 Resent-Message-ID: <handler.59762.B.166995900629870 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: report 59762 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: 59762 <at> debbugs.gnu.org X-Debbugs-Original-To: Guix Patches <guix-patches@HIDDEN> Received: via spool by submit <at> debbugs.gnu.org id=B.166995900629870 (code B ref -1); Fri, 02 Dec 2022 05:31:02 +0000 Received: (at submit) by debbugs.gnu.org; 2 Dec 2022 05:30:06 +0000 Received: from localhost ([127.0.0.1]:44239 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1p0ycd-0007ik-Hf for submit <at> debbugs.gnu.org; Fri, 02 Dec 2022 00:30:05 -0500 Received: from lists.gnu.org ([209.51.188.17]:56856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <phodina@HIDDEN>) id 1p0yca-0007hk-Av for submit <at> debbugs.gnu.org; Fri, 02 Dec 2022 00:30:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <phodina@HIDDEN>) id 1p0yca-0008GH-2t for guix-patches@HIDDEN; Fri, 02 Dec 2022 00:30:00 -0500 Received: from mail-4322.protonmail.ch ([185.70.43.22]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <phodina@HIDDEN>) id 1p0ycX-0003gT-EF for guix-patches@HIDDEN; Fri, 02 Dec 2022 00:29:59 -0500 Date: Fri, 02 Dec 2022 05:29:47 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com; s=protonmail3; t=1669958993; x=1670218193; bh=vgSsPl4hAZdI0P0Ve4htDBp905Zdi6igvCxfNTlZVkw=; h=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date: Subject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector; b=zYqe3PGA4g0gOqlHJDmJyaU3a/soFNJ+Ybc47VXtJ69jbPrMXqXz7Z5rsBVF848Fc QYRTviOKNWBf1S6ZbSy/DeBTp+5pfdRUgCEpnG59NqZu28INXMxelRXsY2IRpR7eya +8tapdWtWawlTZ7be3VRkuBJ5FkrQSqHrEWB9wc2Qf7W35SYYO1E1i9Ut0YIekeKq6 k7UaJiwib8cCKrExrLt/iJ3yAM5IAahPoJVn2cov/sTqWXCHtjKavPBKl9NhQsl+5g 446BCJOAclH1V+FrS4g/hrecDetdCL03AwZavGqNNmLb9A2qM/F/pDAw1PQSYwBnMK xPSVdOarMXlyw== From: phodina <phodina@HIDDEN> Message-ID: <FdB-RhExef-IOU04kHFAgSyRYyFcI76Ucn3z4Yt_-DmYQlFfBtgJClhjBbedMiC0spsbCItfpkC0oygW5EVNeu8BNx--m-JB5X30JsfWV8E=@protonmail.com> Feedback-ID: 14143818:user:proton MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="b1_ygtjZppUkfiTNLZLV4LIRAZrarDIyZNk6Lm2PhrqOZY" Received-SPF: pass client-ip=185.70.43.22; envelope-from=phodina@HIDDEN; helo=mail-4322.protonmail.ch X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, T_PDS_PRO_TLD=0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) This is a multi-part message in MIME format. --b1_ygtjZppUkfiTNLZLV4LIRAZrarDIyZNk6Lm2PhrqOZY Content-Type: multipart/alternative; boundary="b2_ygtjZppUkfiTNLZLV4LIRAZrarDIyZNk6Lm2PhrqOZY" --b2_ygtjZppUkfiTNLZLV4LIRAZrarDIyZNk6Lm2PhrqOZY Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: base64 SGksCgp0aGlzIGFkZHMgYSBuaWNlIEdVSSBwcm9ncmFtIHRvIG1vbml0b3IgY29tbXVuaWNhdGlv biBvbiBzZXJpYWwgaW50ZXJmYWNlcyAoZS5nLiBVQVJUKS4KCi0tLS0KUGV0cg== --b2_ygtjZppUkfiTNLZLV4LIRAZrarDIyZNk6Lm2PhrqOZY Content-Type: text/html; charset=utf-8 Content-Transfer-Encoding: base64 PGRpdiBzdHlsZT0iZm9udC1mYW1pbHk6IEFyaWFsOyBmb250LXNpemU6IDE0cHg7Ij5IaSw8YnI+ PGJyPnRoaXMgYWRkcyBhIG5pY2UgR1VJIHByb2dyYW0gdG8gbW9uaXRvciBjb21tdW5pY2F0aW9u IG9uIHNlcmlhbCBpbnRlcmZhY2VzIChlLmcuIFVBUlQpLjxicj48YnI+LS0tLTxicj5QZXRyPC9k aXY+PGRpdiBjbGFzcz0icHJvdG9ubWFpbF9zaWduYXR1cmVfYmxvY2siIHN0eWxlPSJmb250LWZh bWlseTogQXJpYWw7IGZvbnQtc2l6ZTogMTRweDsiPg0KPC9kaXY+DQo= --b2_ygtjZppUkfiTNLZLV4LIRAZrarDIyZNk6Lm2PhrqOZY-- --b1_ygtjZppUkfiTNLZLV4LIRAZrarDIyZNk6Lm2PhrqOZY Content-Type: text/x-patch; name=0004-gnu-Add-serial-studio.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0004-gnu-Add-serial-studio.patch RnJvbSBiMTM0Y2YxZDIwMGM4NjdjNmI2YzhhNzI5YTRhZDIxMjY4N2ExMDFkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRyIEhvZGluYSA8cGhvZGluYUBwcm90b25tYWlsLmNvbT4K RGF0ZTogRnJpLCAyMSBKYW4gMjAyMiAwNjozMDoyOCArMDEwMApTdWJqZWN0OiBbUEFUQ0ggNC80 XSBnbnU6IEFkZCBzZXJpYWwtc3R1ZGlvLgoKKiBnbnUvcGFja2FnZXMvcXQuc2NtIChzZXJpYWwt c3R1ZGlvKTogTmV3IHZhcmlhYmxlLgoqIGdudS9sb2NhbC5tazogQWRkIHBhdGNoLgoqIGdudS9w YWNrYWdlcy9wYXRjaGVzL3NlcmlhbC1zdHVkaW8tcmVtb3ZlLXFzaW1wbGUtdXBkYXRlci5wYXRj aDogTmV3IGZpbGUuCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL3BhdGNoZXMvc2VyaWFsLXN0 dWRpby1yZW1vdmUtcXNpbXBsZS11cGRhdGVyLnBhdGNoIGIvZ251L3BhY2thZ2VzL3BhdGNoZXMv c2VyaWFsLXN0dWRpby1yZW1vdmUtcXNpbXBsZS11cGRhdGVyLnBhdGNoCm5ldyBmaWxlIG1vZGUg MTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAuLmY4ZjkzMzY0ZDYKLS0tIC9kZXYvbnVsbAorKysgYi9n bnUvcGFja2FnZXMvcGF0Y2hlcy9zZXJpYWwtc3R1ZGlvLXJlbW92ZS1xc2ltcGxlLXVwZGF0ZXIu cGF0Y2gKQEAgLTAsMCArMSw4MCBAQAorRnJvbSAyMmIwYjUwMTRiZTc5MTE0MDZiMjYyYWViMDg2 NGQzNmYxZmJiYWI1IE1vbiBTZXAgMTcgMDA6MDA6MDAgMjAwMQorRnJvbTogUGV0ciBIb2RpbmEg PHBob2RpbmFAcHJvdG9ubWFpbC5jb20+CitEYXRlOiBXZWQsIDE5IEphbiAyMDIyIDE0OjUyOjA4 ICswMTAwCitTdWJqZWN0OiBbUEFUQ0hdIFJlbW92ZSBjb2RlIGRlcGVuZGVudCBvbiBRU2ltcGxl VXBkYXRlci4gRG9uJ3QgaW5jbHVkZQorIHF3dC5wcmksIHF0Y3N2LnByaSBhbmQgcW1xdHQucHJp LgorCisKK2RpZmYgLS1naXQgYS9TZXJpYWwtU3R1ZGlvLnBybyBiL1NlcmlhbC1TdHVkaW8ucHJv CitpbmRleCA0OWNiYjZlLi5mYjZhZWNhIDEwMDY0NAorLS0tIGEvU2VyaWFsLVN0dWRpby5wcm8K KysrKyBiL1NlcmlhbC1TdHVkaW8ucHJvCitAQCAtNTksNyArNTksNyBAQCBlcXVhbHMoUVRfTUFK T1JfVkVSU0lPTiwgNikgeworICAgICBRVCArPSBjb3JlNWNvbXBhdAorIH0KKyAKKy1ERUZJTkVT ICs9IFFUX0RJU0FCTEVfREVQUkVDQVRFRF9CRUZPUkU9MHgwNTBGMDAKKytERUZJTkVTICs9IFFU X0RJU0FCTEVfREVQUkVDQVRFRF9CRUZPUkU9MHgwNTBGMDAgRElTQUJMRV9RU1UKKyAKKyAjLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KKyAjIENvbXBpbGVyIG9wdGlvbnMKK2RpZmYg LS1naXQgYS9saWJzL0xpYnJhcmllcy5wcmkgYi9saWJzL0xpYnJhcmllcy5wcmkKK2luZGV4IDlh NTQ5NGMuLmQyZjZmMTIgMTAwNjQ0CistLS0gYS9saWJzL0xpYnJhcmllcy5wcmkKKysrKyBiL2xp YnMvTGlicmFyaWVzLnByaQorQEAgLTM2LDEyICszNiw4IEBAIElOQ0xVREVQQVRIICs9ICQkUFdE CisgIyBJbmNsdWRlICoucHJpIGZpbGVzCisgIy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KKyAKKy1p bmNsdWRlKCQkUFdEL3F3dC9xd3QucHJpKQorLWluY2x1ZGUoJCRQV0QvcXRjc3YvcXRjc3YucHJp KQorLWluY2x1ZGUoJCRQV0QvcW1xdHQvcW1xdHQucHJpKQorIGluY2x1ZGUoJCRQV0QvUU1hcENv bnRyb2wvUU1hcENvbnRyb2wucHJpKQorIGluY2x1ZGUoJCRQV0QvUVJlYWxGb3VyaWVyL1FSZWFs Rm91cmllci5wcmkpCistaW5jbHVkZSgkJFBXRC9RU2ltcGxlVXBkYXRlci9RU2ltcGxlVXBkYXRl ci5wcmkpCisgCisgbWFjeCogeworICAgICBERUZJTkVTICs9IEtETUFDVE9VQ0hCQVJfQlVJTERf S0RNQUNUT1VDSEJBUl9TUkMKK2RpZmYgLS1naXQgYS9zcmMvTWlzYy9Nb2R1bGVNYW5hZ2VyLmNw cCBiL3NyYy9NaXNjL01vZHVsZU1hbmFnZXIuY3BwCitpbmRleCA1MGFjNGMxLi5iZDAyMmYyIDEw MDY0NAorLS0tIGEvc3JjL01pc2MvTW9kdWxlTWFuYWdlci5jcHAKKysrKyBiL3NyYy9NaXNjL01v ZHVsZU1hbmFnZXIuY3BwCitAQCAtNTUsNyArNTUsNiBAQAorICNpbmNsdWRlIDxXaWRnZXRzL1Rl cm1pbmFsLmg+CisgCisgI2luY2x1ZGUgPFFRdWlja1dpbmRvdz4KKy0jaW5jbHVkZSA8UVNpbXBs ZVVwZGF0ZXIuaD4KKyAKKyAvKioKKyAgKiBDb25maWd1cmVzIHRoZSBhcHBsaWNhdGlvbiBmb250 LCBjcmVhdGVzIGEgc3BsYXNoIHNjcmVlbiBhbmQgY29uZmlndXJlcworQEAgLTEyMCwxMSArMTE5 LDYgQEAgdm9pZCBNaXNjOjpNb2R1bGVNYW5hZ2VyOjpjb25maWd1cmVVcGRhdGVyKCkKKyB7Cisg ICAgIGlmICghYXV0b1VwZGF0ZXJFbmFibGVkKCkpCisgICAgICAgICByZXR1cm47CistCistICAg IHNldFNwbGFzaFNjcmVlbk1lc3NhZ2UodHIoIkNvbmZpZ3VyaW5nIHVwZGF0ZXIuLi4iKSk7Cist ICAgIFFTaW1wbGVVcGRhdGVyOjpnZXRJbnN0YW5jZSgpLT5zZXROb3RpZnlPblVwZGF0ZShBUFBf VVBEQVRFUl9VUkwsIHRydWUpOworLSAgICBRU2ltcGxlVXBkYXRlcjo6Z2V0SW5zdGFuY2UoKS0+ c2V0Tm90aWZ5T25GaW5pc2goQVBQX1VQREFURVJfVVJMLCBmYWxzZSk7CistICAgIFFTaW1wbGVV cGRhdGVyOjpnZXRJbnN0YW5jZSgpLT5zZXRNYW5kYXRvcnlVcGRhdGUoQVBQX1VQREFURVJfVVJM LCBmYWxzZSk7CisgfQorIAorIC8qKgorQEAgLTE3MCw3ICsxNjQsNiBAQCB2b2lkIE1pc2M6Ok1v ZHVsZU1hbmFnZXI6OmluaXRpYWxpemVRbWxJbnRlcmZhY2UoKQorICAgICBjb25zdCBhdXRvIGNz dlBsYXllciA9IENTVjo6UGxheWVyOjpnZXRJbnN0YW5jZSgpOworICAgICBjb25zdCBhdXRvIGlv TWFuYWdlciA9IElPOjpNYW5hZ2VyOjpnZXRJbnN0YW5jZSgpOworICAgICBjb25zdCBhdXRvIGlv Q29uc29sZSA9IElPOjpDb25zb2xlOjpnZXRJbnN0YW5jZSgpOworLSAgICBjb25zdCBhdXRvIHVw ZGF0ZXIgPSBRU2ltcGxlVXBkYXRlcjo6Z2V0SW5zdGFuY2UoKTsKKyAgICAgY29uc3QgYXV0byBq c29uRWRpdG9yID0gSlNPTjo6RWRpdG9yOjpnZXRJbnN0YW5jZSgpOworICAgICBjb25zdCBhdXRv IG1xdHRDbGllbnQgPSBNUVRUOjpDbGllbnQ6OmdldEluc3RhbmNlKCk7CisgICAgIGNvbnN0IGF1 dG8gdWlEYXNoYm9hcmQgPSBVSTo6RGFzaGJvYXJkOjpnZXRJbnN0YW5jZSgpOworQEAgLTIxNSw3 ICsyMDgsNiBAQCB2b2lkIE1pc2M6Ok1vZHVsZU1hbmFnZXI6OmluaXRpYWxpemVRbWxJbnRlcmZh Y2UoKQorICAgICBjLT5zZXRDb250ZXh0UHJvcGVydHkoIkNwcF9Jc1dpbiIsIGlzV2luKTsKKyAg ICAgYy0+c2V0Q29udGV4dFByb3BlcnR5KCJDcHBfSXNNYWMiLCBpc01hYyk7CisgICAgIGMtPnNl dENvbnRleHRQcm9wZXJ0eSgiQ3BwX0lzTml4IiwgaXNOaXgpOworLSAgICBjLT5zZXRDb250ZXh0 UHJvcGVydHkoIkNwcF9VcGRhdGVyIiwgdXBkYXRlcik7CisgICAgIGMtPnNldENvbnRleHRQcm9w ZXJ0eSgiQ3BwX0lPX1NlcmlhbCIsIGlvU2VyaWFsKTsKKyAgICAgYy0+c2V0Q29udGV4dFByb3Bl cnR5KCJDcHBfQ1NWX0V4cG9ydCIsIGNzdkV4cG9ydCk7CisgICAgIGMtPnNldENvbnRleHRQcm9w ZXJ0eSgiQ3BwX0NTVl9QbGF5ZXIiLCBjc3ZQbGF5ZXIpOworLS0gCisyLjM0LjAKKwpkaWZmIC0t Z2l0IGEvZ251L3BhY2thZ2VzL3F0LnNjbSBiL2dudS9wYWNrYWdlcy9xdC5zY20KaW5kZXggNDYy MWRlMGRhZC4uZDA1MjFiNDg5NCAxMDA2NDQKLS0tIGEvZ251L3BhY2thZ2VzL3F0LnNjbQorKysg Yi9nbnUvcGFja2FnZXMvcXQuc2NtCkBAIC0zMDE3LDYgKzMwMTcsNzggQEAgKGRlZmluZSAoZGVs ZXRlLXVud2FudGVkLWZpbGVzIGNoaWxkIHN0YXQgZmxhZyBiYXNlIGxldmVsKQogc3lzdGVtIGxp YnJhcmllcy4iKQogICAgIChsaWNlbnNlIGxpY2Vuc2U6bGdwbDIuMSspKSkKIAorKGRlZmluZS1w dWJsaWMgc2VyaWFsLXN0dWRpbworICAocGFja2FnZQorICAgIChuYW1lICJzZXJpYWwtc3R1ZGlv IikKKyAgICAodmVyc2lvbiAiMS4xLjQiKQorICAgIChzb3VyY2UgKG9yaWdpbgorICAgICAgICAg ICAgICAobWV0aG9kIGdpdC1mZXRjaCkKKyAgICAgICAgICAgICAgKHVyaSAoZ2l0LXJlZmVyZW5j ZQorICAgICAgICAgICAgICAgICAgICAodXJsICJodHRwczovL2dpdGh1Yi5jb20vU2VyaWFsLVN0 dWRpby9TZXJpYWwtU3R1ZGlvIikKKyAgICAgICAgICAgICAgICAgICAgKGNvbW1pdCAoc3RyaW5n LWFwcGVuZCAidiIgdmVyc2lvbikpKSkKKyAgICAgICAgICAgICAgKGZpbGUtbmFtZSAoZ2l0LWZp bGUtbmFtZSBuYW1lIHZlcnNpb24pKQorICAgICAgICAgICAgICAocGF0Y2hlcyAoc2VhcmNoLXBh dGNoZXMKKyAgICAgICAgICAgICAgICAgICAgICAgICJzZXJpYWwtc3R1ZGlvLXJlbW92ZS1xc2lt cGxlLXVwZGF0ZXIucGF0Y2giKSkKKyAgICAgICAgICAgICAgKG1vZHVsZXMgJygoZ3VpeCBidWls ZCB1dGlscykgKGljZS05IGZ0dykKKyAgICAgICAgICAgICAgICAgICAgICAgICAoc3JmaSBzcmZp LTEpKSkKKyAgICAgICAgICAgICAgKHNuaXBwZXQgJyhiZWdpbgorICAgICAgICAgICAgICAgICAg ICAgICAgICAod2l0aC1kaXJlY3RvcnktZXhjdXJzaW9uICJsaWJzIgorICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChmb3ItZWFjaAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkZWxldGUtZmlsZS1y ZWN1cnNpdmVseQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAnKCJxd3QiICJxdGNzdiIgInFtcXR0IgorICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJRU2ltcGxlVXBkYXRlciIpKSkpKQorICAg ICAgICAgICAgICAoc2hhMjU2CisgICAgICAgICAgICAgICAoYmFzZTMyCisgICAgICAgICAgICAg ICAgIjBxd3cycG1idm1xM2NqeDN4azhyeHEwemY1NHkwYjBqOGJ5a240YXEzZDJkaWk0NG04NXki KSkpKQorICAgIChidWlsZC1zeXN0ZW0gcXQtYnVpbGQtc3lzdGVtKQorICAgIChhcmd1bWVudHMK KyAgICAgYCgjOnRlc3RzPyAjZiA7bm8gdGVzdCBzdWl0ZQorICAgICAgICM6cGhhc2VzCisgICAg ICAgKG1vZGlmeS1waGFzZXMgJXN0YW5kYXJkLXBoYXNlcworICAgICAgICAgKHJlcGxhY2UgJ2Nv bmZpZ3VyZQorICAgICAgICAgICAobGFtYmRhKiAoIzprZXkgb3V0cHV0cyBpbnB1dHMgIzphbGxv dy1vdGhlci1rZXlzKQorICAgICAgICAgICAgIChzdWJzdGl0dXRlKiAiU2VyaWFsLVN0dWRpby5w cm8iCisgICAgICAgICAgICAgICAoKCIvdXNyIikgKGFzc29jLXJlZiBvdXRwdXRzICJvdXQiKSkK KyAgICAgICAgICAgICAgICgoIklOQ0xVREVQQVRIIFxcKz0gc3JjIikgKHN0cmluZy1hcHBlbmQg IklOQ0xVREVQQVRIICs9IHNyYworSU5DTFVERVBBVEggKz0gIgorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoYXNzb2MtcmVmIGlucHV0cwor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICJxd3QiKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAiL2luY2x1ZGUvcXd0CisiCisgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJMSUJTICs9IC1MIgorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoYXNzb2MtcmVm IGlucHV0cworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICJxd3QiKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAiL2xpYiIKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIiAtbHF3dAorIgorICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiTElCUyArPSAtTCIK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KGFzc29jLXJlZiBpbnB1dHMKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAicXRjc3YiKQorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAiL2xpYiIKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIiAtbHF0Y3N2Cisi CisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICJMSUJTICs9IC1MIgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAoYXNzb2MtcmVmIGlucHV0cworICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJxbXF0dCIpCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICIvbGli IgorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAiIC1sUXQ1UW1xdHQiKSkpCisgICAgICAgICAgICAgKGludm9rZSAicW1ha2UiKSkpKSkpCisg ICAgKG5hdGl2ZS1pbnB1dHMgKGxpc3QgcXd0IHF0dG9vbHMgcGtnLWNvbmZpZykpCisgICAgKGlu cHV0cyAobGlzdCBxdGNzdgorICAgICAgICAgICAgICAgICAgcW1xdHQKKyAgICAgICAgICAgICAg ICAgIHF3dAorICAgICAgICAgICAgICAgICAgcXRiYXNlLTUKKyAgICAgICAgICAgICAgICAgIHF0 c2VyaWFscG9ydAorICAgICAgICAgICAgICAgICAgcXRzdmctNQorICAgICAgICAgICAgICAgICAg cXRkZWNsYXJhdGl2ZS01CisgICAgICAgICAgICAgICAgICBxdHF1aWNrY29udHJvbHMyLTUpKQor ICAgIChob21lLXBhZ2UgImh0dHBzOi8vZ2l0aHViLmNvbS9TZXJpYWwtU3R1ZGlvL1NlcmlhbC1T dHVkaW8iKQorICAgIChzeW5vcHNpcyAiTXVsdGktcHVycG9zZSBzZXJpYWwgZGF0YSB2aXN1YWxp emF0aW9uICYgcHJvY2Vzc2luZyBwcm9ncmFtIikKKyAgICAoZGVzY3JpcHRpb24KKyAgICAgIlRo aXMgcGFja2FnZSBwcm92aWRlcyBtdWx0aS1wdXJwb3NlIHNlcmlhbCBkYXRhIHZpc3VhbGl6YXRp b24KK2FuZCBwcm9jZXNzaW5nIEdVSSBwcm9ncmFtLiIpCisgICAgKGxpY2Vuc2UgbGljZW5zZTpl eHBhdCkpKQorCiAoZGVmaW5lLXB1YmxpYyBzaW5nbGUtYXBwbGljYXRpb24tcXQ1CiAgIDs7IENo YW5nZSBpbiBmdW5jdGlvbiBzaWduYXR1cmUsIG5oZWtvIHJlcXVpcmVzIGF0IGxlYXN0IHRoaXMg Y29tbWl0CiAgIChsZXQgKChjb21taXQgImRjODA0MmI1ZGI1OGYzNmUwNmJhNTRmMTZmMzhiMTZj NWVlYTkwNTMiKSkKLS0gCjIuMzguMQoK --b1_ygtjZppUkfiTNLZLV4LIRAZrarDIyZNk6Lm2PhrqOZY Content-Type: text/x-patch; name=0001-gnu-Add-qmqtt.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0001-gnu-Add-qmqtt.patch RnJvbSAzNjdkN2RhNGExNDM5NDlkMTFmYmM3NjQ5NWY5MzVkZmY3YTNmMjVjIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRyIEhvZGluYSA8cGhvZGluYUBwcm90b25tYWlsLmNvbT4K RGF0ZTogU3VuLCAxNiBKYW4gMjAyMiAxNzo1OToyMiArMDEwMApTdWJqZWN0OiBbUEFUQ0ggMS80 XSBnbnU6IEFkZCBxbXF0dC4KCiogZ251L3BhY2thZ2VzL3F0LnNjbSAocW1xdHQpOiBOZXcgdmFy aWFibGUuCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL3F0LnNjbSBiL2dudS9wYWNrYWdlcy9x dC5zY20KaW5kZXggMzBiZjQyOTg5Ny4uNmFhYTljNDdjMiAxMDA2NDQKLS0tIGEvZ251L3BhY2th Z2VzL3F0LnNjbQorKysgYi9nbnUvcGFja2FnZXMvcXQuc2NtCkBAIC0zMzYzLDYgKzMzNjMsNjgg QEAgKGRlZmluZS1wdWJsaWMgcHl0aG9uLXF0LnB5CiBiaW5kaW5ncyAoUHlTaWRlLCBQeVNpZGUy LCBQeVF0NCBhbmQgUHlRdDUpLiIpCiAgICAgKGxpY2Vuc2UgbGljZW5zZTpleHBhdCkpKQogCiso ZGVmaW5lLXB1YmxpYyBxbXF0dAorICAocGFja2FnZQorICAgIChuYW1lICJxbXF0dCIpCisgICAg KHZlcnNpb24gIjEuMC4wIikKKyAgICAoc291cmNlIChvcmlnaW4KKyAgICAgICAgICAgICAgKG1l dGhvZCBnaXQtZmV0Y2gpCisgICAgICAgICAgICAgICh1cmkgKGdpdC1yZWZlcmVuY2UKKyAgICAg ICAgICAgICAgICAgICAgKHVybCAiaHR0cHM6Ly9naXRodWIuY29tL2FsZXgtc3BhdGFydS9xbXF0 dCIpCisgICAgICAgICAgICAgICAgICAgIChjb21taXQgKHN0cmluZy1hcHBlbmQgInYiIHZlcnNp b24pKSkpCisgICAgICAgICAgICAgIChmaWxlLW5hbWUgKGdpdC1maWxlLW5hbWUgbmFtZSB2ZXJz aW9uKSkKKyAgICAgICAgICAgICAgKG1vZHVsZXMgJygoZ3VpeCBidWlsZCB1dGlscykgKGljZS05 IGZ0dykKKyAgICAgICAgICAgICAgICAgICAgICAgICAoc3JmaSBzcmZpLTEpKSkKKyAgICAgICAg ICAgICAgKHNuaXBwZXQgYChiZWdpbgorICAgICAgICAgICAgICAgICAgICAgICAgICAoZGVsZXRl LWZpbGUtcmVjdXJzaXZlbHkgInRlc3RzL2d0ZXN0L2d0ZXN0IikpKQorICAgICAgICAgICAgICAo c2hhMjU2CisgICAgICAgICAgICAgICAoYmFzZTMyCisgICAgICAgICAgICAgICAgIjFsOTZjc3Nh OWhqbWFiZHM5azluemlzeG56cjNuZGkzcjgybTNsZ3dxOWlwOTRrejA1bnciKSkpKQorICAgIChi dWlsZC1zeXN0ZW0gY21ha2UtYnVpbGQtc3lzdGVtKQorICAgIChhcmd1bWVudHMKKyAgICAgYCgj OnBoYXNlcyAobW9kaWZ5LXBoYXNlcyAlc3RhbmRhcmQtcGhhc2VzCisgICAgICAgICAgICAgICAg ICAocmVwbGFjZSAnY29uZmlndXJlCisgICAgICAgICAgICAgICAgICAgIChsYW1iZGEqICgjOmtl eSBvdXRwdXRzICM6YWxsb3ctb3RoZXIta2V5cykKKyAgICAgICAgICAgICAgICAgICAgICAoaW52 b2tlICJxbWFrZSIpKSkKKyAgICAgICAgICAgICAgICAgIChyZXBsYWNlICdpbnN0YWxsCisgICAg ICAgICAgICAgICAgICAgIChsYW1iZGEqICgjOmtleSBvdXRwdXRzIHNvdXJjZSAjOmFsbG93LW90 aGVyLWtleXMpCisgICAgICAgICAgICAgICAgICAgICAgKGxldCogKChvdXQgKGFzc29jLXJlZiBv dXRwdXRzICJvdXQiKSkgKGxpYiAoc3RyaW5nLWFwcGVuZAorICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIG91dCAiL2xpYiIp KQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAoaW5jbHVkZSAoc3RyaW5nLWFwcGVuZCBv dXQgIi9pbmNsdWRlIikpKQorICAgICAgICAgICAgICAgICAgICAgICAgKG1rZGlyLXAgbGliKQor ICAgICAgICAgICAgICAgICAgICAgICAgKG1rZGlyLXAgaW5jbHVkZSkKKyAgICAgICAgICAgICAg ICAgICAgICAgIChjaGRpciAiLi4iKSA7d2Ugd2VyZSBpbiBkaXIgdGVzdHMKKyAgICAgICAgICAg ICAgICAgICAgICAgIChjb3B5LXJlY3Vyc2l2ZWx5ICJsaWIiIGxpYikKKyAgICAgICAgICAgICAg ICAgICAgICAgIChjaGRpciAic3JjL21xdHQiKQorICAgICAgICAgICAgICAgICAgICAgICAgKGZv ci1lYWNoIChsYW1iZGEgKGZpbGUpCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAoaW5zdGFsbC1maWxlIChzdHJpbmctYXBwZW5kIGZpbGUpIGluY2x1ZGUpKQorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICcoInFtcXR0X2NsaWVudC5oIiAicW1xdHRfZnJhbWUu aCIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJxbXF0dF9nbG9iYWwuaCIK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJxbXF0dC5oIgorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgInFtcXR0X21lc3NhZ2UuaCIKKyAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICJxbXF0dF9uZXR3b3JraW50ZXJmYWNlLmgiCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAicW1xdHRfcm91dGVkbWVzc2FnZS5oIgor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgInFtcXR0X3JvdXRlci5oIgorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgInFtcXR0X3JvdXRlc3Vic2NyaXB0aW9u LmgiCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAicW1xdHRfc29ja2V0aW50 ZXJmYWNlLmgiCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAicW1xdHRfdGlt ZXJpbnRlcmZhY2UuaCIKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICJxbXF0 dF9tZXNzYWdlLmgiKSkpKSkKKyAgICAgICAgICAgICAgICAgIChyZXBsYWNlICdjaGVjaworICAg ICAgICAgICAgICAgICAgICAobGFtYmRhKiAoIzprZXkgdGVzdHM/IHRlc3Qtb3B0aW9ucyBwYXJh bGxlbC0gKworICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIzphbGxvdy1vdGhlci1rZXlz KQorICAgICAgICAgICAgICAgICAgICAgICsKKyAgICAgICAgICAgICAgICAgICAgICAod2hlbiB0 ZXN0cz8KKyAgICAgICAgICAgICAgICAgICAgICAgIChjaGRpciAidGVzdHMiKQorICAgICAgICAg ICAgICAgICAgICAgICAgKHN1YnN0aXR1dGUqICJndGVzdC9ndGVzdC5wcm8iCisgICAgICAgICAg ICAgICAgICAgICAgICAgICgoImd0ZXN0IikgIiIpKQorICAgICAgICAgICAgICAgICAgICAgICAg KGludm9rZSAicW1ha2UiKSkpKSkpKQorICAgIChuYXRpdmUtaW5wdXRzIChsaXN0IGdvb2dsZXRl c3QgcGVybCBweXRob24pKQorICAgIChpbnB1dHMgKGxpc3QgcXRiYXNlLTUgb3BlbnNzbCBxdHdl YnNvY2tldHMpKQorICAgIChob21lLXBhZ2UgImh0dHBzOi8vZ2l0aHViLmNvbS9hbGV4LXNwYXRh cnUvcW1xdHQiKQorICAgIChzeW5vcHNpcyAiTVFUVCBDbGllbnQiKQorICAgIChkZXNjcmlwdGlv biAiUHJvdmlkZXMgYW4gTVFUVCBDbGllbnQgd2l0aCBTU0wgc3VwcG9ydCBhbmQgV2Vic29ja2V0 cy4iKQorICAgIChsaWNlbnNlIGxpY2Vuc2U6ZXhwYXQpKSkKKwogKGRlZmluZS1wdWJsaWMgcXNj aW50aWxsYQogICAocGFja2FnZQogICAgIChuYW1lICJxc2NpbnRpbGxhIikKLS0gCjIuMzguMQoK --b1_ygtjZppUkfiTNLZLV4LIRAZrarDIyZNk6Lm2PhrqOZY Content-Type: text/x-patch; name=0003-gnu-qwt-Update-to-6.2.0.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0003-gnu-qwt-Update-to-6.2.0.patch RnJvbSBkNDg0NjY0N2I4MGYyOGY3MWY5YTBlNzc5YTk4NzE2ZjdlNTgyZjU2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRyIEhvZGluYSA8cGhvZGluYUBwcm90b25tYWlsLmNvbT4K RGF0ZTogRnJpLCAyMSBKYW4gMjAyMiAwNjozMToyMyArMDEwMApTdWJqZWN0OiBbUEFUQ0ggMy80 XSBnbnU6IHF3dDogVXBkYXRlIHRvIDYuMi4wLgoKKiBnbnUvcGFja2FnZXMvcXQuc2NtIChxd3Qp OiBVcGRhdGUgdG8gNi4yLjAuCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL3F0LnNjbSBiL2du dS9wYWNrYWdlcy9xdC5zY20KaW5kZXggNzFjOGFhZmUzYy4uNDYyMWRlMGRhZCAxMDA2NDQKLS0t IGEvZ251L3BhY2thZ2VzL3F0LnNjbQorKysgYi9nbnUvcGFja2FnZXMvcXQuc2NtCkBAIC0zNzMx LDcgKzM3MzEsNyBAQCAoZGVmaW5lLXB1YmxpYyBxdHNvbHV0aW9ucwogKGRlZmluZS1wdWJsaWMg cXd0CiAgIChwYWNrYWdlCiAgICAgKG5hbWUgInF3dCIpCi0gICAgKHZlcnNpb24gIjYuMS41IikK KyAgICAodmVyc2lvbiAiNi4yLjAiKQogICAgIChzb3VyY2UKICAgICAgIChvcmlnaW4KICAgICAg ICAgKG1ldGhvZCB1cmwtZmV0Y2gpCkBAIC0zNzM5LDcgKzM3MzksNyBAQCAoZGVmaW5lLXB1Ymxp YyBxd3QKICAgICAgICAgIChzdHJpbmctYXBwZW5kICJtaXJyb3I6Ly9zb3VyY2Vmb3JnZS9xd3Qv cXd0LyIKICAgICAgICAgICAgICAgICAgICAgICAgIHZlcnNpb24gIi9xd3QtIiB2ZXJzaW9uICIu dGFyLmJ6MiIpKQogICAgICAgICAoc2hhMjU2Ci0gICAgICAgICAoYmFzZTMyICIwaGYwbXBjYTI0 OHhscW43eG56a2ZqOGRyZjE5Z2R5ZzVzeXprbHZxOHBpYnhpaXh3eGowIikpKSkKKyAgICAgICAg IChiYXNlMzIgIjBjMG1ueXFhOHJ2czJieDk0Nm1ibWZiaDJpazRhMGJtaHdnbjAxcnp2bDJtNzU4 emQ1NGkiKSkpKQogICAoYnVpbGQtc3lzdGVtIGdudS1idWlsZC1zeXN0ZW0pCiAgIChpbnB1dHMK ICAgIChsaXN0IHF0YmFzZS01IHF0c3ZnLTUgcXR0b29scy01KSkKLS0gCjIuMzguMQoK --b1_ygtjZppUkfiTNLZLV4LIRAZrarDIyZNk6Lm2PhrqOZY Content-Type: text/x-patch; name=0002-gnu-Add-qtcsv.patch Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename=0002-gnu-Add-qtcsv.patch RnJvbSA2YjI1ZDA4OGJkMTU4YWQyYzViYWE3NTQ4YzQ5YTA0YmQwZjA5NjY0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBQZXRyIEhvZGluYSA8cGhvZGluYUBwcm90b25tYWlsLmNvbT4K RGF0ZTogV2VkLCAxOSBKYW4gMjAyMiAxMjowMToyMiArMDEwMApTdWJqZWN0OiBbUEFUQ0ggMi80 XSBnbnU6IEFkZCBxdGNzdi4KCiogZ251L3BhY2thZ2VzL3F0LnNjbSAocXRjc3YpOiBOZXcgdmFy aWFibGUuCgpkaWZmIC0tZ2l0IGEvZ251L3BhY2thZ2VzL3F0LnNjbSBiL2dudS9wYWNrYWdlcy9x dC5zY20KaW5kZXggNmFhYTljNDdjMi4uNzFjOGFhZmUzYyAxMDA2NDQKLS0tIGEvZ251L3BhY2th Z2VzL3F0LnNjbQorKysgYi9nbnUvcGFja2FnZXMvcXQuc2NtCkBAIC0xMjgzLDYgKzEyODMsNTgg QEAgKGRlZmluZS1wdWJsaWMgcXRjb25uZWN0aXZpdHkKICAgICAoZGVzY3JpcHRpb24gIlRoZSBR dCBDb25uZWN0aXZpdHkgbW9kdWxlcyBwcm92aWRlcyBtb2R1bGVzIGZvciBpbnRlcmFjdGluZwog d2l0aCBCbHVldG9vdGggYW5kIE5GQy4iKSkpCiAKKyhkZWZpbmUtcHVibGljIHF0Y3N2CisgIChw YWNrYWdlCisgICAgKG5hbWUgInF0Y3N2IikKKyAgICAodmVyc2lvbiAiMS42IikKKyAgICAoc291 cmNlIChvcmlnaW4KKyAgICAgICAgICAgICAgKG1ldGhvZCBnaXQtZmV0Y2gpCisgICAgICAgICAg ICAgICh1cmkgKGdpdC1yZWZlcmVuY2UKKyAgICAgICAgICAgICAgICAgICAgKHVybCAiaHR0cHM6 Ly9naXRodWIuY29tL2lhbWFudG9ueS9xdGNzdiIpCisgICAgICAgICAgICAgICAgICAgIChjb21t aXQgKHN0cmluZy1hcHBlbmQgInYiIHZlcnNpb24pKSkpCisgICAgICAgICAgICAgIChmaWxlLW5h bWUgKGdpdC1maWxlLW5hbWUgbmFtZSB2ZXJzaW9uKSkKKyAgICAgICAgICAgICAgKHNoYTI1Ngor ICAgICAgICAgICAgICAgKGJhc2UzMgorICAgICAgICAgICAgICAgICIxMDluYnNwbmhhY3ptODV3 cDFmcWF6bWFtZGoyYmg5d2Z2M2FubHNsdmxsNjA2bHJmZ2lyIikpKSkKKyAgICAoYnVpbGQtc3lz dGVtIGNtYWtlLWJ1aWxkLXN5c3RlbSkKKyAgICAoYXJndW1lbnRzCisgICAgIGAoIzpwaGFzZXMg KG1vZGlmeS1waGFzZXMgJXN0YW5kYXJkLXBoYXNlcworICAgICAgICAgICAgICAgICAgKHJlcGxh Y2UgJ2NvbmZpZ3VyZQorICAgICAgICAgICAgICAgICAgICAobGFtYmRhKiAoIzprZXkgb3V0cHV0 cyAjOmFsbG93LW90aGVyLWtleXMpCisgICAgICAgICAgICAgICAgICAgICAgKGludm9rZSAicW1h a2UiKSkpCisgICAgICAgICAgICAgICAgICAoYWRkLWFmdGVyICd1bnBhY2sgJ2ZpeC1pbnN0YWxs CisgICAgICAgICAgICAgICAgICAgIChsYW1iZGEqICgjOmtleSBvdXRwdXRzICM6YWxsb3ctb3Ro ZXIta2V5cykKKyAgICAgICAgICAgICAgICAgICAgICAobGV0KiAoKG91dCAoYXNzb2MtcmVmIG91 dHB1dHMgIm91dCIpKSkKKyAgICAgICAgICAgICAgICAgICAgICAgIChzdWJzdGl0dXRlKiAicXRj c3YucHJvIgorICAgICAgICAgICAgICAgICAgICAgICAgICAoKCIvdXNyIikgb3V0KQorICAgICAg ICAgICAgICAgICAgICAgICAgICAoKCJcXCRcXCRQV0QiKSBvdXQpKSkpKQorICAgICAgICAgICAg ICAgICAgKHJlcGxhY2UgJ2luc3RhbGwKKyAgICAgICAgICAgICAgICAgICAgKGxhbWJkYSogKCM6 a2V5IG91dHB1dHMgIzphbGxvdy1vdGhlci1rZXlzKQorICAgICAgICAgICAgICAgICAgICAgIChs ZXQqICgob3V0IChhc3NvYy1yZWYgb3V0cHV0cyAib3V0IikpIChsaWIgKHN0cmluZy1hcHBlbmQK KyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICBvdXQgIi9saWIiKSkKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGlu Y2x1ZGUgKHN0cmluZy1hcHBlbmQgb3V0ICIvaW5jbHVkZSIpKSkKKyAgICAgICAgICAgICAgICAg ICAgICAgIChta2Rpci1wIGluY2x1ZGUpCisgICAgICAgICAgICAgICAgICAgICAgICAobWtkaXIt cCBsaWIpCisgICAgICAgICAgICAgICAgICAgICAgICAoY2hkaXIgIi4uIikgO3dlIHdlcmUgaW4g ZGlyIHRlc3RzCisgICAgICAgICAgICAgICAgICAgICAgICAoY29weS1yZWN1cnNpdmVseSAiaW5j bHVkZSIgaW5jbHVkZSkKKyAgICAgICAgICAgICAgICAgICAgICAgIChmb3ItZWFjaCAobGFtYmRh IChmaWxlKQorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGluc3RhbGwtZmls ZSAoc3RyaW5nLWFwcGVuZCBmaWxlKSBsaWIpKQorICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICcoImxpYnF0Y3N2LnNvIiAibGlicXRjc3Yuc28uMSIKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICJsaWJxdGNzdi5zby4xLjYiICJsaWJxdGNzdi5zby4xLjYuMCIp KSkpKQorICAgICAgICAgICAgICAgICAgKHJlcGxhY2UgJ2NoZWNrCisgICAgICAgICAgICAgICAg ICAgIChsYW1iZGEqICgjOmtleSB0ZXN0cz8gdGVzdC1vcHRpb25zIHBhcmFsbGVsLXRlc3RzPwor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIzphbGxvdy1vdGhlci1rZXlzKQorICAgICAg ICAgICAgICAgICAgICAgICh3aGVuIHRlc3RzPworICAgICAgICAgICAgICAgICAgICAgICAgKGNo ZGlyICJ0ZXN0cyIpCisgICAgICAgICAgICAgICAgICAgICAgICAoaW52b2tlICJxbWFrZSIpKSkp KSkpCisgICAgKG5hdGl2ZS1pbnB1dHMgKGxpc3QgcGVybCBweXRob24pKQorICAgIChpbnB1dHMg KGxpc3QgcXRiYXNlLTUpKQorICAgIChob21lLXBhZ2UgImh0dHBzOi8vZ2l0aHViLmNvbS9pYW1h bnRvbnkvcXRjc3YiKQorICAgIChzeW5vcHNpcyAiTGlicmFyeSBmb3IgcmVhZGluZyBhbmQgd3Jp dGluZyBDU1YgZmlsZXMiKQorICAgIChkZXNjcmlwdGlvbiAiVGhpcyBwYWNrYWdlIHByb3ZpZGVz IGxpYnJhcnkgZm9yIHJlYWRpbmcgYW5kIHdyaXRpbmcgQ1NWCitmaWxlcy4iKQorICAgIChsaWNl bnNlIGxpY2Vuc2U6ZXhwYXQpKSkKKwogKGRlZmluZS1wdWJsaWMgcXR3ZWJzb2NrZXRzLTUKICAg KHBhY2thZ2UgKGluaGVyaXQgcXRzdmctNSkKICAgICAobmFtZSAicXR3ZWJzb2NrZXRzIikKLS0g CjIuMzguMQoK --b1_ygtjZppUkfiTNLZLV4LIRAZrarDIyZNk6Lm2PhrqOZY--
Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) Content-Type: text/plain; charset=utf-8 X-Loop: help-debbugs@HIDDEN From: help-debbugs@HIDDEN (GNU bug Tracking System) To: phodina <phodina@HIDDEN> Subject: bug#59762: Acknowledgement (Add serial-studio) Message-ID: <handler.59762.B.166995900629870.ack <at> debbugs.gnu.org> References: <FdB-RhExef-IOU04kHFAgSyRYyFcI76Ucn3z4Yt_-DmYQlFfBtgJClhjBbedMiC0spsbCItfpkC0oygW5EVNeu8BNx--m-JB5X30JsfWV8E=@protonmail.com> X-Gnu-PR-Message: ack 59762 X-Gnu-PR-Package: guix-patches Reply-To: 59762 <at> debbugs.gnu.org Date: Fri, 02 Dec 2022 05:31:02 +0000 Thank you for filing a new bug report with debbugs.gnu.org. This is an automatically generated reply to let you know your message has been received. Your message is being forwarded to the package maintainers and other interested parties for their attention; they will reply in due course. Your message has been sent to the package maintainer(s): guix-patches@HIDDEN If you wish to submit further information on this problem, please send it to 59762 <at> debbugs.gnu.org. Please do not send mail to help-debbugs@HIDDEN unless you wish to report a problem with the Bug-tracking system. --=20 59762: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D59762 GNU Bug Tracking System Contact help-debbugs@HIDDEN with problems
X-Loop: help-debbugs@HIDDEN Subject: [bug#59762] Add serial-studio Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: guix-patches@HIDDEN Resent-Date: Mon, 16 Jan 2023 14:26:01 +0000 Resent-Message-ID: <handler.59762.B59762.167387915423944 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 59762 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: phodina <phodina@HIDDEN> Cc: 59762 <at> debbugs.gnu.org Received: via spool by 59762-submit <at> debbugs.gnu.org id=B59762.167387915423944 (code B ref 59762); Mon, 16 Jan 2023 14:26:01 +0000 Received: (at 59762) by debbugs.gnu.org; 16 Jan 2023 14:25:54 +0000 Received: from localhost ([127.0.0.1]:60969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pHQQs-0006E7-7D for submit <at> debbugs.gnu.org; Mon, 16 Jan 2023 09:25:54 -0500 Received: from mail-qv1-f48.google.com ([209.85.219.48]:37480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>) id 1pHQQo-0006Do-MB for 59762 <at> debbugs.gnu.org; Mon, 16 Jan 2023 09:25:53 -0500 Received: by mail-qv1-f48.google.com with SMTP id u20so3325303qvq.4 for <59762 <at> debbugs.gnu.org>; Mon, 16 Jan 2023 06:25:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=sOhRwLx6KB6LcNl44TF5OhDQ+h4KsriQryoUJKbTZCE=; b=ji9Ifz1XUivkzBvxVJkfebCAmQJD3t/9boUfTTiLYKpUTl0In2lyzOK9oYcVb8l6ds e56e5M1z347gnnzXmd89VOf/9smKU9j43zcHtOn97NbtV89e+azZVjp72uqZUlgbR/gm amid0WUEhzJDAjDubthfm2pTDfxhJNxSQKItTYazzoZyODrPu+oaQMP+/A0pwXuPGPn7 0AjL034bBVi4LujpXbd4fzzrQtRUMK9MI/tXagq7HmwZJkPJCKM2NY/vHlRfER6F1bFG imv+Pn5FSI0fdy8AGmd1mDxCoedA/pmssw/rKG+laQGNkkl52K5BNzUcHxNwkWV6WAX+ tUiw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sOhRwLx6KB6LcNl44TF5OhDQ+h4KsriQryoUJKbTZCE=; b=oKK9sLRHi8Q+lnhKRNHJkiw7PrDD6q172PyZJfww9kNThXHWMQ1YGTnB7ZMCKBsTvJ LsLG1rya+AV8st21srgmNXg85oSdhkloljH/p847hATMyOgYwtXwhm1CLrS2cZpcTKl5 r91rNDVM+0OUbHYgDYSqyyZjFmY6DbOP4V/OV5ULhpVKw/0ZxWMl+AJrNbT8whIiIUEY sGPATR8L9wYCnO9UVVAoorJqfz7/GoTOVvcBGX8R3n48B68J4TrZ/vtnnCb3CjWaJaJA vOLa69pcvioFKZcqOEdwk/E005UaOxGnNdHTTuueNtHH3wBGtMcT48HkWJE+Ft5xZkkC eVcw== X-Gm-Message-State: AFqh2koA/GoScuxJMFkeF0HCkwTftOmS6JaCuHDtiAseiiOGI7lW8CAD DBjycbc/Nro09yT/eN3HoNUmvkwE1J+KdSZM X-Google-Smtp-Source: AMrXdXvTkw02Osr/MNVoNoy835S2y0xDdbN+cIWxmaVih0BEMyD2PcEssK5HoFsHAhMrKRanYrX52g== X-Received: by 2002:a05:6214:1186:b0:534:a801:112f with SMTP id t6-20020a056214118600b00534a801112fmr14449207qvv.46.1673879144814; Mon, 16 Jan 2023 06:25:44 -0800 (PST) Received: from hurd (dsl-10-130-209.b2b2c.ca. [72.10.130.209]) by smtp.gmail.com with ESMTPSA id s1-20020a05620a0bc100b006fa4ac86bfbsm18087733qki.55.2023.01.16.06.25.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 06:25:44 -0800 (PST) From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> References: <FdB-RhExef-IOU04kHFAgSyRYyFcI76Ucn3z4Yt_-DmYQlFfBtgJClhjBbedMiC0spsbCItfpkC0oygW5EVNeu8BNx--m-JB5X30JsfWV8E=@protonmail.com> Date: Mon, 16 Jan 2023 09:25:43 -0500 In-Reply-To: <FdB-RhExef-IOU04kHFAgSyRYyFcI76Ucn3z4Yt_-DmYQlFfBtgJClhjBbedMiC0spsbCItfpkC0oygW5EVNeu8BNx--m-JB5X30JsfWV8E=@protonmail.com> (phodina@HIDDEN's message of "Fri, 02 Dec 2022 05:29:47 +0000") Message-ID: <874jsqblp4.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Petr, phodina <phodina@HIDDEN> writes: > Hi, > > this adds a nice GUI program to monitor communication on serial interfaces (e.g. UART). > > ---- > Petr > From b134cf1d200c867c6b6c8a729a4ad212687a101d Mon Sep 17 00:00:00 2001 > From: Petr Hodina <phodina@HIDDEN> > Date: Fri, 21 Jan 2022 06:30:28 +0100 > Subject: [PATCH 4/4] gnu: Add serial-studio. > > * gnu/packages/qt.scm (serial-studio): New variable. > * gnu/local.mk: Add patch. > * gnu/packages/patches/serial-studio-remove-qsimple-updater.patch: New file. > > diff --git a/gnu/packages/patches/serial-studio-remove-qsimple-updater.patch b/gnu/packages/patches/serial-studio-remove-qsimple-updater.patch > new file mode 100644 > index 0000000000..f8f93364d6 > --- /dev/null > +++ b/gnu/packages/patches/serial-studio-remove-qsimple-updater.patch > @@ -0,0 +1,80 @@ > +From 22b0b5014be7911406b262aeb0864d36f1fbbab5 Mon Sep 17 00:00:00 2001 > +From: Petr Hodina <phodina@HIDDEN> > +Date: Wed, 19 Jan 2022 14:52:08 +0100 > +Subject: [PATCH] Remove code dependent on QSimpleUpdater. Don't include > + qwt.pri, qtcsv.pri and qmqtt.pri. Ideally, the disabling of QSimpleUpdater would be configurable at build time and upstreamed. The patch is not registered in gnu/local.mk in this commit, although the commit log says it should be. [...] > diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm > index 4621de0dad..d0521b4894 100644 > --- a/gnu/packages/qt.scm > +++ b/gnu/packages/qt.scm > @@ -3017,6 +3017,78 @@ (define (delete-unwanted-files child stat flag base level) > system libraries.") > (license license:lgpl2.1+))) > > +(define-public serial-studio > + (package > + (name "serial-studio") > + (version "1.1.4") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/Serial-Studio/Serial-Studio") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (patches (search-patches > + "serial-studio-remove-qsimple-updater.patch")) > + (modules '((guix build utils) (ice-9 ftw) > + (srfi srfi-1))) I think the only module you require in your snippet is (guix build utils). > + (snippet '(begin > + (with-directory-excursion "libs" > + (for-each > + delete-file-recursively > + '("qwt" "qtcsv" "qmqtt" > + "QSimpleUpdater"))))) > + (sha256 > + (base32 > + "0qww2pmbvmq3cjx3xk8rxq0zf54y0b0j8bykn4aq3d2dii44m85y")))) > + (build-system qt-build-system) > + (arguments > + `(#:tests? #f ;no test suite Please use (list #:tests? #f #:phases #~(modify-phases %standard-phases [...] for new packages definitions. > + #:phases > + (modify-phases %standard-phases > + (replace 'configure > + (lambda* (#:key outputs inputs #:allow-other-keys) > + (substitute* "Serial-Studio.pro" > + (("/usr") (assoc-ref outputs "out")) > + (("INCLUDEPATH \\+= src") (string-append "INCLUDEPATH += src > +INCLUDEPATH += " > + (assoc-ref inputs > + "qwt") > + "/include/qwt > +" > + "LIBS += -L" > + (assoc-ref inputs > + "qwt") > + "/lib" > + " -lqwt > +" > + "LIBS += -L" > + (assoc-ref inputs > + "qtcsv") > + "/lib" > + " -lqtcsv > +" > + "LIBS += -L" > + (assoc-ref inputs > + "qmqtt") > + "/lib" > + " -lQt5Qmqtt"))) The above indentation appears squashed right :-). I'd bring the (string-append "INCLUDEPATH += src [...] on a new line, which will help the rest fit more nicely. > + (invoke "qmake")))))) > + (native-inputs (list qwt qttools pkg-config)) Please sort inputs. > + (inputs (list qtcsv > + qmqtt > + qwt > + qtbase-5 > + qtserialport > + qtsvg-5 > + qtdeclarative-5 > + qtquickcontrols2-5)) Ditto. > + (home-page "https://github.com/Serial-Studio/Serial-Studio") > + (synopsis "Multi-purpose serial data visualization & processing > program") Replace "&" with "and". > + (description > + "This package provides multi-purpose serial data visualization > +and processing GUI program.") This leaves me wanting to know a bit more, but upstream doesn't provide much help, so OK. > + (license license:expat))) > + > (define-public single-application-qt5 > ;; Change in function signature, nheko requires at least this commit > (let ((commit "dc8042b5db58f36e06ba54f16f38b16c5eea9053")) -- Thanks, Maxim
X-Loop: help-debbugs@HIDDEN Subject: [bug#59762] Add serial-studio Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: guix-patches@HIDDEN Resent-Date: Mon, 16 Jan 2023 14:34:02 +0000 Resent-Message-ID: <handler.59762.B59762.167387963924767 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 59762 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: phodina <phodina@HIDDEN> Cc: 59762 <at> debbugs.gnu.org Received: via spool by 59762-submit <at> debbugs.gnu.org id=B59762.167387963924767 (code B ref 59762); Mon, 16 Jan 2023 14:34:02 +0000 Received: (at 59762) by debbugs.gnu.org; 16 Jan 2023 14:33:59 +0000 Received: from localhost ([127.0.0.1]:60983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pHQYg-0006RO-T1 for submit <at> debbugs.gnu.org; Mon, 16 Jan 2023 09:33:59 -0500 Received: from mail-qt1-f174.google.com ([209.85.160.174]:34566) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>) id 1pHQYd-0006R8-E4 for 59762 <at> debbugs.gnu.org; Mon, 16 Jan 2023 09:33:57 -0500 Received: by mail-qt1-f174.google.com with SMTP id e8so3763617qts.1 for <59762 <at> debbugs.gnu.org>; Mon, 16 Jan 2023 06:33:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=AJFs0Sq8wAOb+LBAgul3yNNF/XHQ3toEo3huqSAJBA4=; b=GJajwwzd+YOGH+W8jyiLXoAe6DfYEen9Ijar3BKrdbSnahuaB+sb93wNjN9A5fGg6y DFWeWc+i6bzSkXbySeipaB8zfeEfkXrtyC6FfhjEa3FTGnpi2+dt+9mEQYQa+KLyCzM8 zussfP4RMhjMcNJE5YkcATzVXaspZt/Ws8RkV1qHkYUagKlNdHSaLp8l0fjAkQINEpTa EhogE0z3FahVf2POIIprNdXsD0V35jKWIR5+ckr0s97ka0UcRKURiu0k2NiYzE+x6zEr eHwyE/dLJCvTKJ8vbJvz3Ol5lEA3CdkID5MGFnteFB8v2JUv9qnK5/Qz0VSgfbFTfd5b IMMg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AJFs0Sq8wAOb+LBAgul3yNNF/XHQ3toEo3huqSAJBA4=; b=z0Lh5ZVoGvEQR2yrWSHeS3vBvccjvijUyopoEidwLHim5yOEtSVLlMHBgBDSP6+y0l u1TFDsp7w66DA0YLKy8DLCgkqgvNGKepXxedN50BnMjDNdoXXe82PBPbCcMaDvJ/fHJP FqNhFbOFlQzU4UIoBVMXfo3HU2wi9NKgx+JJffV6Qc1FFXr8bkDlBIorIoBJbBqlfeqJ JJyr3Y7yHQ4ld4YvNOIruONbnGrPA019sLKULAPhLA3LGajIJktNpIMpNckuuPtlcYHm 5k1LEckMlF92CCwykdLa15sQL+4gOs2lwOK5HVeAfWRasY+19gYHkRuTVNEG5Nj8FRIx 0aYw== X-Gm-Message-State: AFqh2kobgU47yWAl9KCd1IRx/Gm1hHRyQW6udjMNKLxl6vm3bRosU9AF gIXk0rtLSqNfKlFzIV60mQQu2wVMTGTgm8wZ X-Google-Smtp-Source: AMrXdXsc9k/PIoN8LxYdZipKCxfE3Kk7ApKQ7XnZEzRD0OkLgIjijQwzhj3DY6ezcGuuAm6QVZ7+yw== X-Received: by 2002:ac8:60d9:0:b0:3b2:1003:37e5 with SMTP id i25-20020ac860d9000000b003b2100337e5mr19351311qtm.55.1673879629626; Mon, 16 Jan 2023 06:33:49 -0800 (PST) Received: from hurd (dsl-10-130-209.b2b2c.ca. [72.10.130.209]) by smtp.gmail.com with ESMTPSA id x10-20020ac87a8a000000b003a7eb5baf3csm14524229qtr.69.2023.01.16.06.33.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 06:33:49 -0800 (PST) From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> References: <FdB-RhExef-IOU04kHFAgSyRYyFcI76Ucn3z4Yt_-DmYQlFfBtgJClhjBbedMiC0spsbCItfpkC0oygW5EVNeu8BNx--m-JB5X30JsfWV8E=@protonmail.com> Date: Mon, 16 Jan 2023 09:33:48 -0500 In-Reply-To: <FdB-RhExef-IOU04kHFAgSyRYyFcI76Ucn3z4Yt_-DmYQlFfBtgJClhjBbedMiC0spsbCItfpkC0oygW5EVNeu8BNx--m-JB5X30JsfWV8E=@protonmail.com> (phodina@HIDDEN's message of "Fri, 02 Dec 2022 05:29:47 +0000") Message-ID: <87y1q2a6r7.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hello! Reviewing patch 2/4. phodina <phodina@HIDDEN> writes: > Hi, > > this adds a nice GUI program to monitor communication on serial interfaces (e.g. UART). > > ---- > Petr > > From 367d7da4a143949d11fbc76495f935dff7a3f25c Mon Sep 17 00:00:00 2001 > From: Petr Hodina <phodina@HIDDEN> > Date: Sun, 16 Jan 2022 17:59:22 +0100 > Subject: [PATCH 1/4] gnu: Add qmqtt. > > * gnu/packages/qt.scm (qmqtt): New variable. > > diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm > index 30bf429897..6aaa9c47c2 100644 > --- a/gnu/packages/qt.scm > +++ b/gnu/packages/qt.scm > @@ -3363,6 +3363,68 @@ (define-public python-qt.py > bindings (PySide, PySide2, PyQt4 and PyQt5).") > (license license:expat))) > > +(define-public qmqtt > + (package > + (name "qmqtt") > + (version "1.0.0") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/alex-spataru/qmqtt") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (modules '((guix build utils) (ice-9 ftw) > + (srfi srfi-1))) Only (guix build utils) is needed. > + (snippet `(begin > + (delete-file-recursively "tests/gtest/gtest"))) Extraneous 'begin' directive. > + (sha256 > + (base32 > + "1l96cssa9hjmabds9k9nzisxnzr3ndi3r82m3lgwq9ip94kz05nw")))) > + (build-system cmake-build-system) > + (arguments > + `(#:phases (modify-phases %standard-phases Please use plain list + gexps for new packages. > + (replace 'configure > + (lambda* (#:key outputs #:allow-other-keys) > + (invoke "qmake"))) Extraneous OUTPUTS argument. > + (replace 'install > + (lambda* (#:key outputs source #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) (lib (string-append > + out "/lib")) > + (include (string-append out "/include"))) After switching to gexps, use gexp variables such as #$output. Extraneous SOURCE argument. > + (mkdir-p lib) > + (mkdir-p include) > + (chdir "..") ;we were in dir tests Prefer active tense (;navigate up from test directore), avoid 'we' as much as possible. > + (copy-recursively "lib" lib) > + (chdir "src/mqtt") > + (for-each (lambda (file) > + (install-file (string-append file) include)) > + '("qmqtt_client.h" "qmqtt_frame.h" > + "qmqtt_global.h" > + "qmqtt.h" > + "qmqtt_message.h" > + "qmqtt_networkinterface.h" > + "qmqtt_routedmessage.h" > + "qmqtt_router.h" > + "qmqtt_routesubscription.h" > + "qmqtt_socketinterface.h" > + "qmqtt_timerinterface.h" > + "qmqtt_message.h"))))) > + (replace 'check > + (lambda* (#:key tests? test-options parallel- + > + #:allow-other-keys) Remove extraneous arguments (test-options, parallel-). > + (when tests? > + (chdir "tests") > + (substitute* "gtest/gtest.pro" > + (("gtest") "")) > + (invoke "qmake"))))))) > + (native-inputs (list googletest perl python)) > + (inputs (list qtbase-5 openssl qtwebsockets)) > + (home-page "https://github.com/alex-spataru/qmqtt") > + (synopsis "MQTT Client") "MQTT client" > + (description "Provides an MQTT Client with SSL support and Websockets.") > + (license license:expat))) Please use make it a full sentence starting with a subject, e.g. "This package provides an MQTT client with [...]". -- Thanks, Maxim
X-Loop: help-debbugs@HIDDEN Subject: [bug#59762] Add serial-studio Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: guix-patches@HIDDEN Resent-Date: Mon, 16 Jan 2023 14:38:02 +0000 Resent-Message-ID: <handler.59762.B59762.167387985225178 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 59762 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: phodina <phodina@HIDDEN> Cc: 59762 <at> debbugs.gnu.org Received: via spool by 59762-submit <at> debbugs.gnu.org id=B59762.167387985225178 (code B ref 59762); Mon, 16 Jan 2023 14:38:02 +0000 Received: (at 59762) by debbugs.gnu.org; 16 Jan 2023 14:37:32 +0000 Received: from localhost ([127.0.0.1]:60995 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pHQc7-0006Y1-UN for submit <at> debbugs.gnu.org; Mon, 16 Jan 2023 09:37:32 -0500 Received: from mail-vs1-f42.google.com ([209.85.217.42]:34362) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>) id 1pHQc6-0006Xj-IH for 59762 <at> debbugs.gnu.org; Mon, 16 Jan 2023 09:37:30 -0500 Received: by mail-vs1-f42.google.com with SMTP id k6so20284591vsk.1 for <59762 <at> debbugs.gnu.org>; Mon, 16 Jan 2023 06:37:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=wLFNj9WNOnBo/vWHc4Nh+tBSD/ypShd3tJ2Ckj3aulo=; b=Tqxynnq5vGuLNF/C7FJ/0k7PLE8MT0j3qSQRB6+JAg6ROJUvJ4njN6zKIbEwidQ/IY SacVW5Vokz/89ztQU8UMcdEzY2+tT8CDDgcBep7OHkX8JMm+L1XMbtb07sqZSNI/C10F FA1T3VUFIEpjMDSv5lizA5ZzRw/rb8AJVqXPGpWh3xhuZ41IetCTJPDmAkRP+GFJb3WK hA+J25bsUWcuJNXfdztJab9P6Ir0GDZSggjlGPCtkmGY/jbe+2HnvTECwgu7RqApucx0 6yfYS6yU9/eZmER1d/7MeFuMHqWDkP0rUyy9/BhovS/Ms5PdEh7WqwrgmXrnxcCPLBO8 uHIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wLFNj9WNOnBo/vWHc4Nh+tBSD/ypShd3tJ2Ckj3aulo=; b=xJaEfO3AgiSBoVcdTXuy3i+CXzZqueVm2MGG0zWPQzLcLV5n+njoyUlaHqcq9AOUPi YzSo6uRF3x0IdFRXUCHvX1oEGghhX0ux97ddEZy+gt6y8kB7SOXabS3k4m2wUZrQxBP/ ooQYAMLCxIJatBkijRRoaV+CzVZrXMV2yDgB6IU0CKr4AMedyZqBFV1UfZIn0i8uu3SV M1J8TQdWnhrlqQiTSxLhlUx+pnpBy5aeLlWzm57DXB4dzD7HnbYNX0XpjpinKvVn7gQ4 DS/zlTvRaYKqINyke0ss2/6jBCU0fwlseGrkd8v185/sfhG9Dsr09aZWHgbx26/mM5Oj /UkQ== X-Gm-Message-State: AFqh2kq+0X66QNDgzniySXrTaunOkH5YksyFzwIPXfgZQZAs/LMVW9ug hvM4PCY7jBkeYFV47NXANOAzkMXq+wictkUX X-Google-Smtp-Source: AMrXdXuiLNtdJ4AkHrJ8eusi69Mg/TDOGJlxZiM+Krzb7nY8NM19yQHMjH3b9w/h0tAeQZGGsHbsFA== X-Received: by 2002:a05:6102:3384:b0:3d0:ce65:da25 with SMTP id i4-20020a056102338400b003d0ce65da25mr14338672vsh.8.1673879844826; Mon, 16 Jan 2023 06:37:24 -0800 (PST) Received: from hurd (dsl-10-130-209.b2b2c.ca. [72.10.130.209]) by smtp.gmail.com with ESMTPSA id bm16-20020a05620a199000b006e16dcf99c8sm18304227qkb.71.2023.01.16.06.37.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 06:37:24 -0800 (PST) From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> References: <FdB-RhExef-IOU04kHFAgSyRYyFcI76Ucn3z4Yt_-DmYQlFfBtgJClhjBbedMiC0spsbCItfpkC0oygW5EVNeu8BNx--m-JB5X30JsfWV8E=@protonmail.com> Date: Mon, 16 Jan 2023 09:37:23 -0500 In-Reply-To: <FdB-RhExef-IOU04kHFAgSyRYyFcI76Ucn3z4Yt_-DmYQlFfBtgJClhjBbedMiC0spsbCItfpkC0oygW5EVNeu8BNx--m-JB5X30JsfWV8E=@protonmail.com> (phodina@HIDDEN's message of "Fri, 02 Dec 2022 05:29:47 +0000") Message-ID: <87tu0qa6l8.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hello, Reviewing patch 3 out of 4! phodina <phodina@HIDDEN> writes: > Hi, > > this adds a nice GUI program to monitor communication on serial interfaces (e.g. UART). > > ---- > Petr > > > From d4846647b80f28f71f9a0e779a98716f7e582f56 Mon Sep 17 00:00:00 2001 > From: Petr Hodina <phodina@HIDDEN> > Date: Fri, 21 Jan 2022 06:31:23 +0100 > Subject: [PATCH 3/4] gnu: qwt: Update to 6.2.0. > > * gnu/packages/qt.scm (qwt): Update to 6.2.0. > > diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm > index 71c8aafe3c..4621de0dad 100644 > --- a/gnu/packages/qt.scm > +++ b/gnu/packages/qt.scm > @@ -3731,7 +3731,7 @@ (define-public qtsolutions > (define-public qwt > (package > (name "qwt") > - (version "6.1.5") > + (version "6.2.0") > (source > (origin > (method url-fetch) > @@ -3739,7 +3739,7 @@ (define-public qwt > (string-append "mirror://sourceforge/qwt/qwt/" > version "/qwt-" version ".tar.bz2")) > (sha256 > - (base32 "0hf0mpca248xlqn7xnzkfj8drf19gdyg5syzklvq8pibxiixwxj0")))) > + (base32 "0c0mnyqa8rvs2bx946mbmfbh2ik4a0bmhwgn01rzvl2m758zd54i")))) > (build-system gnu-build-system) > (inputs > (list qtbase-5 qtsvg-5 qttools-5)) LGTM (you can push this one already), if you've verified it doesn't break dependent packages. -- Thanks, Maxim
X-Loop: help-debbugs@HIDDEN Subject: [bug#59762] Add serial-studio Resent-From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> Resent-CC: guix-patches@HIDDEN Resent-Date: Mon, 16 Jan 2023 14:43:01 +0000 Resent-Message-ID: <handler.59762.B59762.167388016125817 <at> debbugs.gnu.org> Resent-Sender: help-debbugs@HIDDEN X-GNU-PR-Message: followup 59762 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: phodina <phodina@HIDDEN> Cc: 59762 <at> debbugs.gnu.org Received: via spool by 59762-submit <at> debbugs.gnu.org id=B59762.167388016125817 (code B ref 59762); Mon, 16 Jan 2023 14:43:01 +0000 Received: (at 59762) by debbugs.gnu.org; 16 Jan 2023 14:42:41 +0000 Received: from localhost ([127.0.0.1]:32784 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1pHQh7-0006iJ-Dx for submit <at> debbugs.gnu.org; Mon, 16 Jan 2023 09:42:41 -0500 Received: from mail-qt1-f172.google.com ([209.85.160.172]:42552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>) id 1pHQh5-0006i5-JT for 59762 <at> debbugs.gnu.org; Mon, 16 Jan 2023 09:42:40 -0500 Received: by mail-qt1-f172.google.com with SMTP id fd15so14760401qtb.9 for <59762 <at> debbugs.gnu.org>; Mon, 16 Jan 2023 06:42:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=o17Zz2iocql32YBuyhhFhRjEG1CI6KNUnYbd3adPMgo=; b=Jov+F3Xj0rblpP8AKo7namSbWj9Cud9fprF1lst8qzf0gTjmXVbAbXKHiujd0XuHJk IzSllwFSIIk2BijHZ5zpQfV3+loWbPDYvXIfBlBaPUEj3KXySH2psn9nQa5V8g+F+3wN 8kYLoTYVPVa5DnD9yTBxpCVgEdKzNFVqqe155xLZ6uMyfHDeN0plQitv7uvJobMPSM3B WEU7DahdhKzLgwFU8KsPU6dljvFLuvgI2sl9ai+ECwsW9REHvp473Pp8/UxSVA+YHvMw d/+JWmkn4EUxC4pS3vM666orCtKw86TfBhTMng1byOiUbBzAbvRftHXVkgrbOyvPEbAF DRjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:message-id:in-reply-to:date:references :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=o17Zz2iocql32YBuyhhFhRjEG1CI6KNUnYbd3adPMgo=; b=v6HB4KF7Ln8vQdcBK6zQAL/8u/YkWIacy5YNsK6kzBA9Ibl/DRdNkl3PX5KtaLTkIU 0veYwsR6sSv0vFb1bhsPbXephdwKFPp9apUrJEMkI3mTRNHIdQghAMz+MrxxCRGAEmAL 5bQQXclRwxLqJprNmsvMlJK1kQZmO6FXAJgpIDYZC4xkxY3RQJacNpE8Y1LpnPb6May/ 5Ir5AhkTGfJYQuqktEDA5X0tPkO6Mn97ABHnrHq/934eXTNQ8Yz+qGEkEMDA2c4oPceW Iwx9nZw4cMtwhRbdoiR9K6PqBrDymVNC7xNTl3jcD8DhfYe2l3lfWIuhUdRTu1mEy9xX qlDA== X-Gm-Message-State: AFqh2koyG1pjGH75aZK3DZr6w5VNCfCFH5ibYhbXpX/X0/14uCc8gX22 q878OVH4NCfOFtizVdtANaKmhMxLb83zS5F/ X-Google-Smtp-Source: AMrXdXtz5DYDknPxjRrT9Nd7wZA8QOuLMV6JXRGk0NCbloYsvLotSxxjA+xhXKksKL0ok1svQLWbuw== X-Received: by 2002:ac8:530a:0:b0:3b6:31e3:1a57 with SMTP id t10-20020ac8530a000000b003b631e31a57mr4770548qtn.8.1673880153873; Mon, 16 Jan 2023 06:42:33 -0800 (PST) Received: from hurd (dsl-10-130-209.b2b2c.ca. [72.10.130.209]) by smtp.gmail.com with ESMTPSA id u15-20020a05620a454f00b006ce76811a07sm18572377qkp.75.2023.01.16.06.42.33 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Jan 2023 06:42:33 -0800 (PST) From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> References: <FdB-RhExef-IOU04kHFAgSyRYyFcI76Ucn3z4Yt_-DmYQlFfBtgJClhjBbedMiC0spsbCItfpkC0oygW5EVNeu8BNx--m-JB5X30JsfWV8E=@protonmail.com> Date: Mon, 16 Jan 2023 09:42:32 -0500 In-Reply-To: <FdB-RhExef-IOU04kHFAgSyRYyFcI76Ucn3z4Yt_-DmYQlFfBtgJClhjBbedMiC0spsbCItfpkC0oygW5EVNeu8BNx--m-JB5X30JsfWV8E=@protonmail.com> (phodina@HIDDEN's message of "Fri, 02 Dec 2022 05:29:47 +0000") Message-ID: <87pmbea6cn.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi again! phodina <phodina@HIDDEN> writes: > Hi, > > this adds a nice GUI program to monitor communication on serial interfaces (e.g. UART). > > ---- > Petr > > > > From 6b25d088bd158ad2c5baa7548c49a04bd0f09664 Mon Sep 17 00:00:00 2001 > From: Petr Hodina <phodina@HIDDEN> > Date: Wed, 19 Jan 2022 12:01:22 +0100 > Subject: [PATCH 2/4] gnu: Add qtcsv. > > * gnu/packages/qt.scm (qtcsv): New variable. > > diff --git a/gnu/packages/qt.scm b/gnu/packages/qt.scm > index 6aaa9c47c2..71c8aafe3c 100644 > --- a/gnu/packages/qt.scm > +++ b/gnu/packages/qt.scm > @@ -1283,6 +1283,58 @@ (define-public qtconnectivity > (description "The Qt Connectivity modules provides modules for interacting > with Bluetooth and NFC."))) > > +(define-public qtcsv > + (package > + (name "qtcsv") > + (version "1.6") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/iamantony/qtcsv") > + (commit (string-append "v" version)))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "109nbspnhaczm85wp1fqazmamdj2bh9wfv3anlslvll606lrfgir")))) > + (build-system cmake-build-system) > + (arguments > + `(#:phases (modify-phases %standard-phases Please switch to list + gexps. > + (replace 'configure > + (lambda* (#:key outputs #:allow-other-keys) > + (invoke "qmake"))) Use plain lambda without arguments (lambda _). > + (add-after 'unpack 'fix-install > + (lambda* (#:key outputs #:allow-other-keys) Ditto. > + (let* ((out (assoc-ref outputs "out"))) > Use gexps variables. > + (substitute* "qtcsv.pro" > + (("/usr") out) > + (("\\$\\$PWD") out))))) > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) (lib (string-append > + out "/lib")) Ditto :-). > + (include (string-append out "/include"))) > + (mkdir-p include) > + (mkdir-p lib) > + (chdir "..") ;we were in dir tests Same comment bout active tense as earlier... but it seems that'd no longer be needed with the next comment implemented? > + (copy-recursively "include" include) > + (for-each (lambda (file) > + (install-file (string-append file) lib)) > + '("libqtcsv.so" "libqtcsv.so.1" > + "libqtcsv.so.1.6" "libqtcsv.so.1.6.0"))))) > + (replace 'check > + (lambda* (#:key tests? test-options parallel-tests? > + #:allow-other-keys) > + (when tests? > + (chdir "tests") > + (invoke "qmake"))))))) If qmake has a switch like make to change directory, e.g. -C, that'd be preferable, else "with-directory-excursion" to avoid keeping state in other phases. Otherwise, this patch LGTM. -- Thanks, Maxim
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.