Received: (at 59920) by debbugs.gnu.org; 9 Dec 2022 12:25:33 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 09 07:25:33 2022 Received: from localhost ([127.0.0.1]:35737 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1p3cRY-0007Ao-Se for submit <at> debbugs.gnu.org; Fri, 09 Dec 2022 07:25:33 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40396) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1p3cRX-0007Ah-Mn for 59920 <at> debbugs.gnu.org; Fri, 09 Dec 2022 07:25:31 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1p3cRQ-00072d-Mr; Fri, 09 Dec 2022 07:25:26 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=4JIecWgWFwbJNn9yMNV/4SCTQusj+I1z+O22Um3n7+0=; b=kgpMHQT7Gj8+ AMADnRqezbpCMglV81wuIkvVSDReccrFWiLQiPxMPLqPEUz4X4qCGQ9ww7YrFuZ7f0VL2ixKxbhRY wXs2uRof6dvGGfPVeKMWOqkbcmzVqRrMtE2fB1RmV5EbCcC28a+kFeiEIKmT+WqZBHt9jzifCvzHL hm+pkWgnboIwgMLKpfzUoLCa0NZ/JxxzvBkFIgfK6Dg3hEbEgtLsKFC3wN8BoDl1nMdXEZMDHPlS8 AcDVkC7QhrHoRX0/rSoCWaW0T848+AKjFmahYp0NQ6HoHtCQfYSXpdp8QE30uk2DBLt9hc/WEHBYA cKjsj/NweoW2EnokdrH7gw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1p3cRD-000443-7m; Fri, 09 Dec 2022 07:25:22 -0500 Date: Fri, 09 Dec 2022 14:25:04 +0200 Message-Id: <83v8mkzrvj.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <CADwFkm=J3znL61PFONbQR1+R9Cjc2Eb1KD6WBJj=3TYiS2=N2Q@HIDDEN> (message from Stefan Kangas on Fri, 9 Dec 2022 02:10:16 -0800) Subject: Re: bug#59920: [PATCH] Make checkdoc warn if not using lexical-binding References: <CADwFkm=J3znL61PFONbQR1+R9Cjc2Eb1KD6WBJj=3TYiS2=N2Q@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59920 Cc: 59920 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Stefan Kangas <stefankangas@HIDDEN> > Date: Fri, 9 Dec 2022 02:10:16 -0800 > > The attached patch makes checkdoc warn if there's no lexical-binding > cookie. Thanks, but I think this should be optional behavior. checkdoc is not only used by us.
bug-gnu-emacs@HIDDEN:bug#59920; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 9 Dec 2022 10:10:23 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 09 05:10:23 2022 Received: from localhost ([127.0.0.1]:35051 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1p3aKk-0005af-S6 for submit <at> debbugs.gnu.org; Fri, 09 Dec 2022 05:10:23 -0500 Received: from lists.gnu.org ([209.51.188.17]:41976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1p3aKj-0005aZ-MU for submit <at> debbugs.gnu.org; Fri, 09 Dec 2022 05:10:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <stefankangas@HIDDEN>) id 1p3aKi-0003e7-PM for bug-gnu-emacs@HIDDEN; Fri, 09 Dec 2022 05:10:20 -0500 Received: from mail-oi1-x234.google.com ([2607:f8b0:4864:20::234]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <stefankangas@HIDDEN>) id 1p3aKg-0002B2-Qo for bug-gnu-emacs@HIDDEN; Fri, 09 Dec 2022 05:10:20 -0500 Received: by mail-oi1-x234.google.com with SMTP id e205so4064093oif.11 for <bug-gnu-emacs@HIDDEN>; Fri, 09 Dec 2022 02:10:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:subject:message-id:date:mime-version:from:from:to:cc:subject :date:message-id:reply-to; bh=dCMsPnGXTJBTi5WvR6XfzUmaYgaIbHcd1aSihKtKgsU=; b=TdVxiyFn/FzX5cOl7sRBOwAFE6+yv2Curvuub3CKT7bH6bSGqe58LKyxml0SGvQMc9 lVuFHygOm0KKWGQdl0ScjWqLV1TIKFQfLmktTGQE3yYxP9R/UWmZNcMkBwP5V2OjM7Rn CZWOhtSS95lXMbt32ZY5U5cD3t0jQDcdLyOrjiwqGDNH2gGLF0uk+bnu5w1jj05CIz87 LMhWJRto0ruRw4Y8NQoUIxYeZq6SsaYGu9p1jkd+VZuuz0HxumLRbwpadPdeliDK2AjD Zii01Ya/TFCv8fm8olr/e2j6t9JuDWzLLofoOzYbz1AF1ZlAZopk49+KPeNCnek1vI2d o53Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:subject:message-id:date:mime-version:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=dCMsPnGXTJBTi5WvR6XfzUmaYgaIbHcd1aSihKtKgsU=; b=n1h5se+oxKQa/5Lr540Z5neaas3Y/4nB5MPYjPJURJjb/sOJgXvR/0SSjKmtoHy7Oq +wY9W1FXJGI/O1diX2llOOLVEbrKaFl8UykhD5CnCTwFoLuWDWLHrqiMjoUgvA+d5fQG f3LmgmsLtmqeRSF0I5okrbRc8HNtPED6hcAt63MlI2jFzsROPy7coMNlDe7q5nMHnsCN NlR2VLlyda0MNyH8IhX0rwm8hXxqzHGxoOZeses393jxZwBQcGRvv9FQq6EYRV3H5+Pv DF8ON8EwhHPIwkNr3t8BFBgEdFvOJJz5dLFHQnpp0k6lG1UYpU7DPXMd7vjmmwEU/Dlz FSww== X-Gm-Message-State: ANoB5pkNWCWWBiSZL7TbB4KXasDD/uGuExxh24HMnzZ7GX0B+Q9K0V/S tpYJp9OQ9iHIY/Yyl05rQf0rarmEvF9V6bjrIs2qRM7Q X-Google-Smtp-Source: AA0mqf4Pyn9BNr1jqFX7scpMoh4iLE3VzkxTJHwAlUgp/L/aH9E9bfr6K+DNWeMtRBIAEIoXHnV1wiMdsWOmJ9nEqV8= X-Received: by 2002:a05:6808:1287:b0:359:dc32:4f9e with SMTP id a7-20020a056808128700b00359dc324f9emr36959565oiw.92.1670580617253; Fri, 09 Dec 2022 02:10:17 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Fri, 9 Dec 2022 02:10:16 -0800 From: Stefan Kangas <stefankangas@HIDDEN> X-Hashcash: 1:20:221209:bug-gnu-emacs@HIDDEN::2FyAwhTUI9MlujJ9:0kHL MIME-Version: 1.0 Date: Fri, 9 Dec 2022 02:10:16 -0800 Message-ID: <CADwFkm=J3znL61PFONbQR1+R9Cjc2Eb1KD6WBJj=3TYiS2=N2Q@HIDDEN> Subject: [PATCH] Make checkdoc warn if not using lexical-binding To: bug-gnu-emacs@HIDDEN Content-Type: multipart/mixed; boundary="00000000000042aca105ef625c43" Received-SPF: pass client-ip=2607:f8b0:4864:20::234; envelope-from=stefankangas@HIDDEN; helo=mail-oi1-x234.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) --00000000000042aca105ef625c43 Content-Type: text/plain; charset="UTF-8" Severity: wishlist The attached patch makes checkdoc warn if there's no lexical-binding cookie. --00000000000042aca105ef625c43 Content-Type: text/x-diff; charset="US-ASCII"; name="0001-Make-checkdoc-warn-if-not-using-lexical-binding.patch" Content-Disposition: attachment; filename="0001-Make-checkdoc-warn-if-not-using-lexical-binding.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 5d57d73f1dfd4344_0.1 RnJvbSAyNDE4ZTBhYTc3MGRiYWIyNWY3MzE4NWQ5YTMwYWNkYmZkOWQ4NmFiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5rYW5nYXNAZ21haWwuY29t PgpEYXRlOiBGcmksIDkgRGVjIDIwMjIgMTA6NTg6MjIgKzAxMDAKU3ViamVjdDogW1BBVENIXSBN YWtlIGNoZWNrZG9jIHdhcm4gaWYgbm90IHVzaW5nIGxleGljYWwtYmluZGluZwoKKiBsaXNwL2Vt YWNzLWxpc3AvY2hlY2tkb2MuZWwgKGNoZWNrZG9jLWZpbGUtY29tbWVudHMtZW5naW5lKToKV2Fy biBpZiB0aGVyZSBpcyBubyBsZXhpY2FsLWJpbmRpbmcgY29va2llLgotLS0KIGV0Yy9ORVdTICAg ICAgICAgICAgICAgICAgICB8ICA3ICsrKysrKysKIGxpc3AvZW1hY3MtbGlzcC9jaGVja2RvYy5l bCB8IDI0ICsrKysrKysrKysrKysrKysrKysrKysrKwogMiBmaWxlcyBjaGFuZ2VkLCAzMSBpbnNl cnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvZXRjL05FV1MgYi9ldGMvTkVXUwppbmRleCA3ZjA3M2M0 ZTJkLi4xMDI1ZjQzMjA3IDEwMDY0NAotLS0gYS9ldGMvTkVXUworKysgYi9ldGMvTkVXUwpAQCAt NTYsNiArNTYsMTMgQEAgc3dpdGNoZXMgZm9yIHNob3J0bG9ncywgc3VjaCBhcyB0aGUgb25lIHBy b2R1Y2VkIGJ5ICdDLXggdiBMJy4KIFlvdSBjYW4gbm93IGNvbmZpZ3VyZSBob3cgdG8gZGlzcGxh eSB0aGUgIipidWZmZXItc2VsZWN0aW9uKiIgYnVmZmVyCiB1c2luZyB0aGlzIG5ldyBvcHRpb24u ICAoT3Igc2V0ICdkaXNwbGF5LWJ1ZmZlci1hbGlzdCcgZGlyZWN0bHkuKQogCisqKiBjaGVja2Rv YworCistLS0KKyoqKiBOZXcgY2hlY2tkb2NrIHdhcm5pbmcgaWYgbm90IHVzaW5nIGxleGljYWwt YmluZGluZy4KK0NoZWNrZG9jIG5vdyB3YXJucyBpZiB0aGUgZmlyc3QgbGluZSBvZiBhbiBFbWFj cyBMaXNwIGZpbGUgZG9lcyBub3QKK2VuZCB3aXRoIGEgIi0qLSBsZXhpY2FsLWJpbmRpbmc6IHQg LSotIiBjb29raWUuCisKIAwKICogTmV3IE1vZGVzIGFuZCBQYWNrYWdlcyBpbiBFbWFjcyAzMC4x CiAKZGlmZiAtLWdpdCBhL2xpc3AvZW1hY3MtbGlzcC9jaGVja2RvYy5lbCBiL2xpc3AvZW1hY3Mt bGlzcC9jaGVja2RvYy5lbAppbmRleCAzYmRkYjkzYjY0Li40ZWY2ZjBhMjEyIDEwMDY0NAotLS0g YS9saXNwL2VtYWNzLWxpc3AvY2hlY2tkb2MuZWwKKysrIGIvbGlzcC9lbWFjcy1saXNwL2NoZWNr ZG9jLmVsCkBAIC0yMzY5LDYgKzIzNjksMzAgQEAgY2hlY2tkb2MtZmlsZS1jb21tZW50cy1lbmdp bmUKIAkgICAgICAocG9pbnQtbWluKSAoc2F2ZS1leGN1cnNpb24gKGdvdG8tY2hhciAocG9pbnQt bWluKSkKIAkJCQkJICAobGluZS1lbmQtcG9zaXRpb24pKSkpCiAJIG5pbCkpCisgICAgICAoc2V0 cQorICAgICAgIGVycgorICAgICAgIDs7IExleGljYWwgYmluZGluZyBjb29raWUuCisgICAgICAg KGlmIChub3QgKHNhdmUtZXhjdXJzaW9uCisgICAgICAgICAgICAgICAgICAoc2F2ZS1yZXN0cmlj dGlvbgorICAgICAgICAgICAgICAgICAgICAoZ290by1jaGFyIChwb2ludC1taW4pKQorICAgICAg ICAgICAgICAgICAgICAobmFycm93LXRvLXJlZ2lvbiAocG9pbnQpIChwb3MtZW9sKSkKKyAgICAg ICAgICAgICAgICAgICAgKHJlLXNlYXJjaC1mb3J3YXJkCisgICAgICAgICAgICAgICAgICAgICAo cnggIi0qLSIgKCogKCogbm9ubCkgIjsiKQorICAgICAgICAgICAgICAgICAgICAgICAgICgqIHNw YWNlKSAibGV4aWNhbC1iaW5kaW5nOiIgKCogc3BhY2UpICJ0IiAoKiBzcGFjZSkKKyAgICAgICAg ICAgICAgICAgICAgICAgICAoKiAiOyIgKCogbm9ubCkpCisgICAgICAgICAgICAgICAgICAgICAg ICAgIi0qLSIpCisgICAgICAgICAgICAgICAgICAgICBuaWwgdCkpKSkKKyAgICAgICAgICAgKGxl dCAoKHBvcyAoc2F2ZS1leGN1cnNpb24gKGdvdG8tY2hhciAocG9pbnQtbWluKSkKKyAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKGdvdG8tY2hhciAocG9zLWVvbCkpCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIChwb2ludCkpKSkKKyAgICAgICAgICAg IChpZiAoY2hlY2tkb2MteS1vci1uLXAgIlRoZXJlIGlzIG5vIGxleGljYWwtYmluZGluZyBjb29r aWUhICBBZGQgb25lPyIpCisgICAgICAgICAgICAgICAgKHByb2duCisgICAgICAgICAgICAgICAg ICAoZ290by1jaGFyIHBvcykKKyAgICAgICAgICAgICAgICAgIChpbnNlcnQgIiAgLSotIGxleGlj YWwtYmluZGluZzogdCAtKi0iKSkKKyAgICAgICAgICAgICAgKGNoZWNrZG9jLWNyZWF0ZS1lcnJv cgorICAgICAgICAgICAgICAgIlRoZSBmaXJzdCBsaW5lIHNob3VsZCBlbmQgd2l0aCBcIi0qLSBs ZXhpY2FsLWJpbmRpbmc6IHQgLSotXCIiCisgICAgICAgICAgICAgICBwb3MgKDErIHBvcykgdCkp KQorICAgICAgICAgbmlsKSkKICAgICAgIChzZXRxCiAgICAgICAgZXJyCiAgICAgICAgKG9yCi0t IAoyLjM1LjEKCg== --00000000000042aca105ef625c43--
Stefan Kangas <stefankangas@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#59920; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.