GNU bug report logs - #59929
[PATCH]: Eglot, request progress notification on server init

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59929 in the body.
You can then email your comments to 59929 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Danny Freeman <danny <at> dfreeman.email>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH]: Eglot, request progress notification on server init
Date: Fri, 09 Dec 2022 14:55:05 -0500

[Message part 1 (text/plain, inline)]

I would like to propose a change to Eglot that builds on my last patch
in bug 59149.

What I did not realize at the time of writing that patch, is that
clients can opt into receiving progress notifications for server
initialization when sending the `:initialize` request.
This is useful for slow starting servers or large projects that require
the lsp server to do a lot of analysis on startup. The server of course
has to be able to send these progress reports. Not all of them do and
may ignore this parameter.

If users do not want to see this, they can set `eglot-report-progress`
to `nil`.

There are other requests that extend the WorkDoneProgressParams
interface that this could also be done for. It may be worth looking
through the spec and seeing if it makes sense to send this param with
other requests. Many of them are for typically quick requests like
`textDocument/definition`

Thank you,
-- 
Danny Freeman

[0001-Eglot-show-progress-reports-for-slow-starting-server.patch (text/x-patch, attachment)]

Message #8 received at 59929 <at> debbugs.gnu.org (full text, mbox):

From: Danny Freeman <danny <at> dfreeman.email>
To: 59929 <at> debbugs.gnu.org
Subject: Re: [PATCH]: Eglot, request progress notification on server init
Date: Fri, 09 Dec 2022 15:59:24 -0500

[Message part 1 (text/plain, inline)]

Another patch for consideration related to the first in this thread,
I've confirmed that clients can signal to servers that they are willing
to accept server initiated progress notifications with the client
capability in the attached patch. 

Note: there is still no server capability for this that can be ignored,
and the `eglot-report-progress` defcustom remains relevant here. Any
server initiated progress report will be ignored if
`eglot-report-progress` is `nil`.

Server will send a `window/workDoneProgress/create` request, but nothing
needs to be done with it. That request will be followed by the already
implemented $/progress notifications.

I need to find a server that I can test this with before this patch is
applied. I will report back in this thread once I've done that.

-- 
Danny Freeman

[0001-Eglot-Enable-server-initiated-progress-reports.patch (text/x-patch, attachment)]

Message #13 received at 59929 <at> debbugs.gnu.org (full text, mbox):

From: Danny Freeman <danny <at> dfreeman.email>
To: 59929 <at> debbugs.gnu.org, João Távora
 <joaotavora <at> gmail.com>
Subject: Re: [PATCH]: Eglot, request progress notification on server init
Date: Sat, 25 Mar 2023 15:10:20 -0400

Danny Freeman <danny <at> dfreeman.email> writes:

> Another patch for consideration related to the first in this thread,
> I've confirmed that clients can signal to servers that they are willing
> to accept server initiated progress notifications with the client
> capability in the attached patch. 
>
> Note: there is still no server capability for this that can be ignored,
> and the `eglot-report-progress` defcustom remains relevant here. Any
> server initiated progress report will be ignored if
> `eglot-report-progress` is `nil`.
>
> Server will send a `window/workDoneProgress/create` request, but nothing
> needs to be done with it. That request will be followed by the already
> implemented $/progress notifications.
>
> I need to find a server that I can test this with before this patch is
> applied. I will report back in this thread once I've done that.

I think this bug can be closed. It is old and I lost track of it, but
some recent commits in Emacs I think addressed this

- 82523dc621ace104d8f379509a436fcb03c48c26
- 47d8e4b0d3835f5e0b0b6ab76f242ef0aa25bda7

Thank you,
Danny Freeman

Message #18 received at 59929-done <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Danny Freeman <danny <at> dfreeman.email>, 59929-done <at> debbugs.gnu.org
Subject: Re: [PATCH]: Eglot, request progress notification on server init
Date: Sat, 25 Mar 2023 19:15:29 +0000

On Sat, Mar 25, 2023 at 7:12 PM Danny Freeman <danny <at> dfreeman.email> wrote:
>
>
> Danny Freeman <danny <at> dfreeman.email> writes:
>
> > Another patch for consideration related to the first in this thread,
> > I've confirmed that clients can signal to servers that they are willing
> > to accept server initiated progress notifications with the client
> > capability in the attached patch.
> >
> > Note: there is still no server capability for this that can be ignored,
> > and the `eglot-report-progress` defcustom remains relevant here. Any
> > server initiated progress report will be ignored if
> > `eglot-report-progress` is `nil`.
> >
> > Server will send a `window/workDoneProgress/create` request, but nothing
> > needs to be done with it. That request will be followed by the already
> > implemented $/progress notifications.
> >
> > I need to find a server that I can test this with before this patch is
> > applied. I will report back in this thread once I've done that.
>
> I think this bug can be closed. It is old and I lost track of it, but
> some recent commits in Emacs I think addressed this
>
> - 82523dc621ace104d8f379509a436fcb03c48c26
> - 47d8e4b0d3835f5e0b0b6ab76f242ef0aa25bda7
>
> Thank you,
> Danny Freeman

Yes, I think so to.  I had lost track of this bug,
thanks for reminding me.

João

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.