Stefan Kangas <stefankangas@HIDDEN>
to control <at> debbugs.gnu.org
.
Full text available.Received: (at 59961) by debbugs.gnu.org; 11 Dec 2022 10:52:15 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 11 05:52:15 2022 Received: from localhost ([127.0.0.1]:46318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1p4JwM-0000IQ-Qr for submit <at> debbugs.gnu.org; Sun, 11 Dec 2022 05:52:15 -0500 Received: from out162-62-57-252.mail.qq.com ([162.62.57.252]:38491) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <lx@HIDDEN>) id 1p4JwJ-0000IK-1w for 59961 <at> debbugs.gnu.org; Sun, 11 Dec 2022 05:52:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1670755923; bh=lsX7Ke2rJNXhL6BYskYnpElyOjKxEgKVL4zNfgvH5Qk=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=xNNjVP+vhIjTA9aElbh8g7lebyqrxxoSvc65KtsceGSj5FkaA57F8WbgfBaVVcwC5 C296wLWMst/EMnprcqv3pX2B4ELn9a7o/lYOzKqoYROgtYmyy8QOzzd9c3VM8uUHKM Jjw5kx1V/X5fK6g4MSbdV8BhPZ8+Ylscb7hrApBo= Received: from lx-pc ([240e:399:e6f:ee32:f815:4044:ba50:97f9]) by newxmesmtplogicsvrszc2-0.qq.com (NewEsmtp) with SMTP id D0135E1E; Sun, 11 Dec 2022 18:52:01 +0800 X-QQ-mid: xmsmtpt1670755921twacvi6vd Message-ID: <tencent_686D39C367DA6A2E6A10EE10E55FC33B8209@HIDDEN> X-QQ-XMAILINFO: N/WmRbclY25GtURlGiSAdc6ZdZf8pUyMHJxBrHGnabsK5/uzzqsgEfcjU73bL5 4+/PMZ+iE5hRGrJmkdoKJbqYl1G9Gkheh4mpHjPM6/ZDSFEv9+Hl+81tSukMx6eNXBDl/ddQm7Mq WXvGYq3v9p1WPVM5cKRlQDbZnogELJFghgWfpmSiaWYHEGXjNo6jBNjDlaaDydTW4gkzQtr+lluB HQL7DX4y4OgFNh8oRtSx0BYRURnWq81nj/6mt8Hmiz6WQC9JU1aehkubmo776iq2wGXt8LsJNXff 79F0mIzadMW2vXD8PbV+u7X4tC5y2zX+/RbgYYEJGxcKNmu37vv52myFZB4ASsQ0RLkeufr9wAQk nOMcM9mIzNJ4UVaj4MgmHPde/Gdw+UXnUF671VDnesiP31M4+nqAwi1FI66vPtdMf8xbwEKVmmWk /XcYSEl37R2LQSAbjCrvOwnzwZfKgwBj8QxxMBIJ6BKj3nJD+8JL84haBSvA/MA7YcQZm4oe/PQL JySZDgRE2eb9Flp+zdGL5Xv+K99joykz2Nw+N3FMb0wYSQ7HncNt4GzL9SrUNvYe/DoBP38p2N+p 6zMy8VLzoanqLkWO/NaZ2NaQpmSiY39K57MLFv8WbVB5zH5+tMcM5DYG6Av8lY5FoYdAokOP74OL XdoWliItLhWh/sgVwdeUgJGMAa0JkRC7ckeg3govtiEg1GWKW6Lqmx7gjpAOwlIn6lLf5jlrckV3 RQ/nrhrRaKAdzajYzWLS0TJg4y6bXO1GUHCbTrC5yJDL1H4nZa+XRqFXawTKPbsSOBjqcLvjdJnX k9MV/3+Q2VibAz8zXNzYtkn8b56I/HDYOIlEE7iWZVpQ9J8psMpW6V7AtZnrsG152fs1luEGM3iI P+Hol+W6e8rcgwTx9pH7mc7QQPHiLZRwFU33aM97MGS14jbwDv/QV9a60cBo3akge99zth1UAvOM cSDMM+gPLrMp8cvqIsKY1dHCAn13mJAv7zNMEcsT4l+VyAx9/19+oh2M0g0b7uoVYX1ux5d5XGdC LPBiynh8npTGM1VLmw Date: Sun, 11 Dec 2022 18:51:59 +0800 From: lux <lx@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#59961: [PATCH] ; * lib-src/emacsclient.c: Add parameters option information. X-OQ-MSGID: <20221211185159.3e166aa1@lx-pc> In-Reply-To: <83a63uuth3.fsf@HIDDEN> References: <tencent_138785D7074B73DACCCCD54CD528DE89C80A@HIDDEN> <83a63uuth3.fsf@HIDDEN> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.35; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Spam-Score: 3.6 (+++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Sun, 11 Dec 2022 12:26:16 +0200 Eli Zaretskii <eliz@HIDDEN> wrote: > The --help message already says that. Why do we need that in an error > message as well? Because when I forgot `server-start`, the information given was not intuitive enough, and I needed to use `--help` again. And these three parameters themselves need to provide value, so adding them wi [...] Content analysis details: (3.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [162.62.57.252 listed in wl.mailspike.net] -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [162.62.57.252 listed in list.dnswl.org] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS 3.2 HELO_DYNAMIC_IPADDR Relay HELO'd using suspicious hostname (IP addr 1) X-Debbugs-Envelope-To: 59961 Cc: 59961 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: 2.6 (++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: On Sun, 11 Dec 2022 12:26:16 +0200 Eli Zaretskii <eliz@HIDDEN> wrote: > The --help message already says that. Why do we need that in an error > message as well? Because when I forgot `server-start`, the information given was not intuitive enough, and I needed to use `--help` again. And these three parameters themselves need to provide value, so adding them wi [...] Content analysis details: (2.6 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [162.62.57.252 listed in list.dnswl.org] -0.0 RCVD_IN_MSPIKE_H2 RBL: Average reputation (+2) [162.62.57.252 listed in wl.mailspike.net] 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.0 SPF_NONE SPF: sender does not publish an SPF Record 0.4 RDNS_DYNAMIC Delivered to internal network by host with dynamic-looking rDNS -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager 3.2 HELO_DYNAMIC_IPADDR Relay HELO'd using suspicious hostname (IP addr 1) On Sun, 11 Dec 2022 12:26:16 +0200 Eli Zaretskii <eliz@HIDDEN> wrote: > The --help message already says that. Why do we need that in an error > message as well? Because when I forgot `server-start`, the information given was not intuitive enough, and I needed to use `--help` again. And these three parameters themselves need to provide value, so adding them will be more intuitive. Thanks.
bug-gnu-emacs@HIDDEN
:bug#59961
; Package emacs
.
Full text available.Received: (at 59961) by debbugs.gnu.org; 11 Dec 2022 10:26:24 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 11 05:26:24 2022 Received: from localhost ([127.0.0.1]:46296 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1p4JXM-0008Qs-D9 for submit <at> debbugs.gnu.org; Sun, 11 Dec 2022 05:26:24 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49672) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1p4JXL-0008Qk-H6 for 59961 <at> debbugs.gnu.org; Sun, 11 Dec 2022 05:26:23 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1p4JXF-0001fx-J5; Sun, 11 Dec 2022 05:26:17 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=References:Subject:In-Reply-To:To:From:Date: mime-version; bh=03LiFdkZtUTSXK8CN8UX4dybLRnUTBLJg3sOjn9Tcvo=; b=Vu1lEzIgCMT/ JTu0dyCoe44DWhiOWnjvawkOoeLHHegBkrJJ9GdcFk26sGMXea1iVy41Vf8nlMqnmcpqoigfuhz2c GFPGCwGIw8BmXlEEsiBsc2ivdvDv9dKWNS13CQteDsoU7S4BGB3vS4CxClCHrzbvdBXzHMcUFBZ06 DVXbG/IeehuAKSZYmm3J1xlj3hH50HaunvEo/NY4pixUlhuXXfP3L6PZ9r5YsbSXziB27ZmxG9+9m 6zbe0k7Bn5GHhlRXra7yZGBNALqpn5WWgJ415cP9rlmHg9rVMql9UsDKRmtG0Klo64+3WDBQuMTJb SfMg8uZdJ6ElMjTsuVoHyg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1p4JXF-00058G-3O; Sun, 11 Dec 2022 05:26:17 -0500 Date: Sun, 11 Dec 2022 12:26:16 +0200 Message-Id: <83a63uuth3.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: lu4nx <lx@HIDDEN> In-Reply-To: <tencent_138785D7074B73DACCCCD54CD528DE89C80A@HIDDEN> (message from lu4nx on Sun, 11 Dec 2022 17:32:32 +0800) Subject: Re: bug#59961: [PATCH] ; * lib-src/emacsclient.c: Add parameters option information. References: <tencent_138785D7074B73DACCCCD54CD528DE89C80A@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 59961 Cc: 59961 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Cc: lu4nx <lx@HIDDEN> > From: lu4nx <lx@HIDDEN> > Date: Sun, 11 Dec 2022 17:32:32 +0800 > > --- > lib-src/emacsclient.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/lib-src/emacsclient.c b/lib-src/emacsclient.c > index af488128ba..a0c5b84bc5 100644 > --- a/lib-src/emacsclient.c > +++ b/lib-src/emacsclient.c > @@ -1669,10 +1669,10 @@ set_socket (bool no_exit_if_error) > /* No implicit or explicit socket, and no alternate editor. */ > message (true, "%s: No socket or alternate editor. Please use:\n\n" > #ifdef SOCKETS_IN_FILE_SYSTEM > -"\t--socket-name\n" > +"\t--socket-name=SOCKET\n" > #endif > -"\t--server-file (or environment variable EMACS_SERVER_FILE)\n\ > -\t--alternate-editor (or environment variable ALTERNATE_EDITOR)\n", > +"\t--server-file=SERVER (or environment variable EMACS_SERVER_FILE)\n\ > +\t--alternate-editor=EDITOR (or environment variable ALTERNATE_EDITOR)\n", > progname); > exit (EXIT_FAILURE); > } The --help message already says that. Why do we need that in an error message as well?
bug-gnu-emacs@HIDDEN
:bug#59961
; Package emacs
.
Full text available.Received: (at submit) by debbugs.gnu.org; 11 Dec 2022 09:33:09 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Sun Dec 11 04:33:09 2022 Received: from localhost ([127.0.0.1]:46237 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1p4Ihp-0007mA-7P for submit <at> debbugs.gnu.org; Sun, 11 Dec 2022 04:33:09 -0500 Received: from lists.gnu.org ([209.51.188.17]:41480) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <lx@HIDDEN>) id 1p4Ihl-0007m4-KB for submit <at> debbugs.gnu.org; Sun, 11 Dec 2022 04:33:08 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <lx@HIDDEN>) id 1p4Ihk-0008Pz-KS for bug-gnu-emacs@HIDDEN; Sun, 11 Dec 2022 04:33:05 -0500 Received: from out162-62-58-211.mail.qq.com ([162.62.58.211]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <lx@HIDDEN>) id 1p4Ihe-0001gc-Uq for bug-gnu-emacs@HIDDEN; Sun, 11 Dec 2022 04:33:03 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qq.com; s=s201512; t=1670751169; bh=RDHD1k0L88jUl9Bd9vm5kkhSY4zXw7YAeYfiUKYQ4t8=; h=From:To:Cc:Subject:Date; b=uexAMQqGg/5ngHHGYZgdD6wNZTfYMnSHuBQUxY1O+MP7UuwGfMEyV+Gox6n7Xl5bO hACjqRE+DQCCaddMSC3IeSxSECHJ6Z/yIBm9IQjYWAIcr7VP0qyqIl28j241bsqyEZ x+G0zOD2G6Js11Mf8Hb5qGsLzuNgXyTGdZ0k5pXM= Received: from lx-pc ([240e:399:e6f:ee32:f815:4044:ba50:97f9]) by newxmesmtplogicsvrszb6-0.qq.com (NewEsmtp) with SMTP id 82F9D620; Sun, 11 Dec 2022 17:32:47 +0800 X-QQ-mid: xmsmtpt1670751167thldclnb2 Message-ID: <tencent_138785D7074B73DACCCCD54CD528DE89C80A@HIDDEN> X-QQ-XMAILINFO: NMGzQWUSIfvT4TvD0ZHoTYSU1ME+9Gmjybm4zuQ6jPJmwIFO853FBphJQrm9dM 2XKwDsP0F0oanKRh5sA5SAd2+kSZ/p1/GtPlVCEBzJqjMNe6pDPcvVVELxSABctrmdV0CbBfBeTz wO/odtGZNa0QhnKRKj0ckKz28nxwguFF21f9ymIgK4GIzqCEHmq/+S8iwbYy/v51baxtUyM+83AN 3CwfRqhMiHAvJZAuGyxKu3BxCzwBXmV3lHWDRx8+b2psbzv3SGThiP7VFi7BLzwcFX7+RjxBkYF5 O7QQrOMaZFunz3ELhIlOrZ0aIDH9AyZZR9tSYASlqQNJpCRLdHUpapuqVPVDpzpRbXuMTQU3Lg73 VSWPad56Z3dQrOf5UVkxwRyyN7o5ZOtEkh7zDf/qb8MRs0IfUC6LXkrymJq+rGuLCZncTi4QCxNU 4+0Ch73qosxeesBPNkPSJDmIDyt6Lq1Y41QKd+ftnx2s0oJmlZBHhY7b/kY1oZWRYZOfjMpCAy6f 6R0FCiHvtWCCmli1HtJ0qfsvDTR2HX0dsqdednYzCBmZYdpg7KcRmX2G+jp6K0WMxN1/v12fkx5s Oou3zk2Jk1ctfM67M4d5AIoIUcvo0UEH2ymic3BGUi2NtXvCigVwnNt3XunO5eJg1Ud5c7hD7bKQ 5u/IFvvB60LzToBjI+2/FTdFIdSn0jVxQGphic1Vnrjnr2TRRLVlM7ndsmrNzc4/83c4pgOX9v/n dK1gjQaJjq59tQUoZIm9woc8SLE93O2TY1d74/9QOgCZX1XB9YJs++extiIvcdcWTXljmlADV99U x24/9JrNCsgD1VbLa1mfE+8Jw8p1t2MQbb7LsyXG+LaDVL6PxqQNV2CPfCD3/NKZk8xS4CZpLi3w cGrr9v+sol/ruO+K+xmL+v33R6nSu7/n9YFhf2LShgvgQjb23TMmn860Pl019sQKN7drQprMHrq3 Tk8HKMfd5A6sX0C29j3Rsx+ZF9uWGMrmyfs8pyaqeFEU6/tzY/ng== From: lu4nx <lx@HIDDEN> To: bug-gnu-emacs@HIDDEN Subject: [PATCH] ; * lib-src/emacsclient.c: Add parameters option information. Date: Sun, 11 Dec 2022 17:32:32 +0800 X-OQ-MSGID: <20221211093232.152593-1-lx@HIDDEN> X-Mailer: git-send-email 2.38.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=162.62.58.211; envelope-from=lx@HIDDEN; helo=out162-62-58-211.mail.qq.com X-Spam_score_int: 10 X-Spam_score: 1.0 X-Spam_bar: + X-Spam_report: (1.0 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, HELO_DYNAMIC_IPADDR=1.951, RCVD_IN_DNSWL_NONE=-0.0001, RDNS_DYNAMIC=0.982, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: lu4nx <lx@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) --- lib-src/emacsclient.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lib-src/emacsclient.c b/lib-src/emacsclient.c index af488128ba..a0c5b84bc5 100644 --- a/lib-src/emacsclient.c +++ b/lib-src/emacsclient.c @@ -1669,10 +1669,10 @@ set_socket (bool no_exit_if_error) /* No implicit or explicit socket, and no alternate editor. */ message (true, "%s: No socket or alternate editor. Please use:\n\n" #ifdef SOCKETS_IN_FILE_SYSTEM -"\t--socket-name\n" +"\t--socket-name=SOCKET\n" #endif -"\t--server-file (or environment variable EMACS_SERVER_FILE)\n\ -\t--alternate-editor (or environment variable ALTERNATE_EDITOR)\n", +"\t--server-file=SERVER (or environment variable EMACS_SERVER_FILE)\n\ +\t--alternate-editor=EDITOR (or environment variable ALTERNATE_EDITOR)\n", progname); exit (EXIT_FAILURE); } -- 2.38.1
lu4nx <lx@HIDDEN>
:bug-gnu-emacs@HIDDEN
.
Full text available.bug-gnu-emacs@HIDDEN
:bug#59961
; Package emacs
.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.