GNU bug report logs - #59990
[PATCH] tests: depcomp: ensure make_ok() fails when run_make fails

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59990 in the body.
You can then email your comments to 59990 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Frederic Berat <fberat <at> redhat.com>
To: automake-patches <at> gnu.org
Cc: Frédéric Bérat <fberat <at> redhat.com>
Subject: [PATCH] tests: depcomp: ensure make_ok() fails when run_make fails
Date: Mon, 12 Dec 2022 07:32:13 +0100

From: Frédéric Bérat <fberat <at> redhat.com>

While running automake tests with -std-gnu=c99, the compiler report
errors which lead to make to fail. Yet, these failures are ignored
during the tests, which considers them to be successful as stderror is
check for one specific pattern.

If make fails, investigation should be made to discover why, whatever
the reason for the failure is.
---
 t/ax/depcomp.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/t/ax/depcomp.sh b/t/ax/depcomp.sh
index f23635086..e4e7565df 100644
--- a/t/ax/depcomp.sh
+++ b/t/ax/depcomp.sh
@@ -160,7 +160,7 @@ case $depcomp_with_libtool in
     echo lib_LTLIBRARIES = libfoo.la >> Makefile.am
     make_ok ()
     {
-      run_make -M -- ${1+"$@"}
+      run_make -M -- ${1+"$@"} || return 1
       $FGREP 'unknown directive' output && return 1
       rm -f output
       # Checks for stray files possibly left around by less common
-- 
2.38.1

Message #8 received at 59990 <at> debbugs.gnu.org (full text, mbox):

From: Mike Frysinger <vapier <at> gentoo.org>
To: Frederic Berat <fberat <at> redhat.com>
Cc: 59990 <at> debbugs.gnu.org
Subject: Re: [PATCH] tests: depcomp: ensure make_ok() fails when run_make fails
Date: Sun, 15 Jan 2023 21:55:00 +0000 (UTC)

thanks, lgtm, merged
-mike

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.