GNU bug report logs - #59991
[PATCH 0/2] Port tests to modern C

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 59991 in the body.
You can then email your comments to 59991 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Frederic Berat <fberat <at> redhat.com>
To: automake-patches <at> gnu.org
Subject: [PATCH 0/2] Port tests to modern C
Date: Mon, 12 Dec 2022 08:05:52 +0100

Hello,

There is ongoing work from both GCC and Clang community to set the C99 standard
as the default one, in an effort to improve security overall.
In this context, Fedora packages were rebuilt with some warnings turned as
errors to simulate the change. This leads to failures in Automake, that are
attempted to be fixed, mainly in this patchset.

Another patch dedicated to Flex related tests will follow.

Fred.

---
Frédéric Bérat (2):
  tests: Fix 'type defaults' error in link_cond due to main not being
    properly declared
  tests: Fix implicit function declaration errors

 t/ax/depcomp.sh              |  4 ++--
 t/c-demo.sh                  |  1 +
 t/cond35.sh                  |  2 ++
 t/dist-vs-built-sources.sh   |  1 +
 t/lex-clean.sh               |  1 +
 t/lex-multiple.sh            |  4 ++++
 t/lex-nodist.sh              |  2 ++
 t/link_cond.sh               |  2 +-
 t/ltcond2.sh                 |  2 ++
 t/ltconv.sh                  |  6 ++++++
 t/subobj-clean-lt-pr10697.sh | 10 +++++++++-
 t/subobj-clean-pr10697.sh    | 10 +++++++++-
 t/tags-pr12372.sh            |  3 ++-
 t/yacc-basic.sh              |  1 +
 t/yacc-clean.sh              |  4 ++++
 t/yacc-nodist.sh             |  2 ++
 16 files changed, 49 insertions(+), 6 deletions(-)

-- 
2.38.1

Message #8 received at 59991 <at> debbugs.gnu.org (full text, mbox):

From: Karl Berry <karl <at> freefriends.org>
To: fberat <at> redhat.com, zack <at> owlfolio.org
Cc: 59991 <at> debbugs.gnu.org
Subject: Re: [bug#59991] [PATCH 0/2] Port tests to modern C
Date: Mon, 12 Dec 2022 15:57:28 -0700

    There is ongoing work from both GCC and Clang community to set the
    C99 standard as the default one, 

Sounds inevitable.

    in an effort to improve security overall.

How does C99 improve security? Just wondering.

    failures in Automake, that are attempted to be fixed, mainly in this
    patchset.

Thanks for all that work. Unfortunately there is no chance I will be
able to look at it any time soon. I doubt Jim has any time available,
either, though I'd be glad to be wrong.

Zack, would you like be co-maintainer or at least co-developer of
Automake? There is, evidently, no one else in the world interested in
being actively involved with Automake on the maintainer side.

    Another patch dedicated to Flex related tests will follow.

Just wondering again, is an upstream flex still actively maintained by
anyone, anywhere?  Looks like https://github.com/westes/flex was touched
6 months ago, so that's good, but there hasn't been a release for over
five years.

Thanks,
Karl

Message #11 received at 59991 <at> debbugs.gnu.org (full text, mbox):

From: Sam James <sam <at> gentoo.org>
To: Karl Berry <karl <at> freefriends.org>
Cc: Frederic Berat <fberat <at> redhat.com>, Zack Weinberg <zack <at> owlfolio.org>,
 59991 <at> debbugs.gnu.org
Subject: Re: [bug#59991] [PATCH 0/2] Port tests to modern C
Date: Mon, 12 Dec 2022 23:05:56 +0000

[Message part 1 (text/plain, inline)]

> On 12 Dec 2022, at 22:57, Karl Berry <karl <at> freefriends.org> wrote:
>    Another patch dedicated to Flex related tests will follow.
> 
> Just wondering again, is an upstream flex still actively maintained by
> anyone, anywhere?  Looks like https://github.com/westes/flex was touched
> 6 months ago, so that's good, but there hasn't been a release for over
> five years.
> 

I've started investigating using reflex (https://invisible-island.net/reflex/reflex.html)
for this reason.

There's a long story with how flex broke with glibc-2.26/2.27 or so with reallocrray()
and implicit function declarations and there hasn't been a release to fix that (https://github.com/westes/flex/issues/499)
so all distros have to backport a bunch of patches to fix it:
- https://github.com/westes/flex/commit/4b5111d9772b5c160340ca96f08d30d7f6db5cda
- https://github.com/westes/flex/commit/24fd0551333e7eded87b64dd36062da3df2f6380
- https://github.com/westes/flex/commit/0db9f8903a446e7026874be519b8dc55a471f014
- https://github.com/westes/flex/commit/a17d79e9c722a6735b6d2a8f152287404f27df32
- https://github.com/westes/flex/commit/4081efa0831b15d7e4e4255401c225ad8262426d
- https://github.com/westes/flex/commit/1985bb3c7abed940e91ad816504ef08a18c3b7c1

Note that some of these affect the generated programs. It's possible that some
of these might actually make the automake patch obsolete, although given there's
no flex release definitely on the horizon, it's probably worth at least working around
it in automake.

See also:
- https://github.com/westes/flex/issues/436
- https://bugs.gentoo.org/705800
- https://developers.redhat.com/blog/2019/04/22/implicit-function-declarations-flexs-use-of-reallocarray

Best,
sam

[signature.asc (application/pgp-signature, attachment)]

Message #14 received at 59991 <at> debbugs.gnu.org (full text, mbox):

From: "Zack Weinberg" <zack <at> owlfolio.org>
To: "Karl Berry" <karl <at> freefriends.org>, "Frederic Berat" <fberat <at> redhat.com>
Cc: 59991 <at> debbugs.gnu.org, Automake development <automake <at> gnu.org>
Subject: Re: [bug#59991] [PATCH 0/2] Port tests to modern C
Date: Tue, 13 Dec 2022 16:00:27 -0500

On Mon, Dec 12, 2022, at 5:57 PM, Karl Berry wrote:
> Zack, would you like be co-maintainer or at least co-developer of
> Automake? There is, evidently, no one else in the world interested in
> being actively involved with Automake on the maintainer side.

I have to decline; I don't have anything like the time required and also I am almost completely unfamiliar with the innards of Automake (except for the handful of Perl modules shared with Autoconf).

zw

Message #17 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Frederic Berat <fberat <at> redhat.com>
To: automake-patches <at> gnu.org
Cc: Frédéric Bérat <fberat <at> redhat.com>
Subject: [bug#59991][PATCH v2 0/3] Port tests to modern C
Date: Fri, 16 Dec 2022 07:17:16 +0100

From: Frédéric Bérat <fberat <at> redhat.com>

Hello,

There is ongoing work from both GCC and Clang community to set the C99 standard
as the default one.
In this context, Fedora packages were rebuilt with some warnings turned as
errors to simulate the change. This leads to failures in Automake, that are
attempted to be fixed, mainly in this patchset.

Fred.

Changes from v1:
  - [PATCH 2/2] has been split in 2, in order to properly detail changes
    related to depcomp.sh. The code is untouched.

---
Frédéric Bérat (3):
  tests: Fix 'type defaults' error in link_cond due to main not being
    properly declared
  tests: Fix implicit function declaration errors
  tests: Fix implicit function declaration in ax/depcomp.sh

 t/ax/depcomp.sh              |  4 ++--
 t/c-demo.sh                  |  1 +
 t/cond35.sh                  |  2 ++
 t/dist-vs-built-sources.sh   |  1 +
 t/lex-clean.sh               |  1 +
 t/lex-multiple.sh            |  4 ++++
 t/lex-nodist.sh              |  2 ++
 t/link_cond.sh               |  2 +-
 t/ltcond2.sh                 |  2 ++
 t/ltconv.sh                  |  6 ++++++
 t/subobj-clean-lt-pr10697.sh | 10 +++++++++-
 t/subobj-clean-pr10697.sh    | 10 +++++++++-
 t/tags-pr12372.sh            |  3 ++-
 t/yacc-basic.sh              |  1 +
 t/yacc-clean.sh              |  4 ++++
 t/yacc-nodist.sh             |  2 ++
 16 files changed, 49 insertions(+), 6 deletions(-)

-- 
2.38.1

Message #20 received at 59991 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Frederic Berat <fberat <at> redhat.com>
Cc: 59991 <at> debbugs.gnu.org
Subject: Re: [bug#59991] [PATCH v2 0/3] Port tests to modern C
Date: Fri, 3 Feb 2023 23:15:19 -0800

On Thu, Dec 15, 2022 at 10:19 PM Frederic Berat <fberat <at> redhat.com> wrote:
> From: Frédéric Bérat <fberat <at> redhat.com>
> Hello,
>
> There is ongoing work from both GCC and Clang community to set the C99 standard
> as the default one.
> In this context, Fedora packages were rebuilt with some warnings turned as
> errors to simulate the change. This leads to failures in Automake, that are
> attempted to be fixed, mainly in this patchset.
>
> Fred.
>
> Changes from v1:
>   - [PATCH 2/2] has been split in 2, in order to properly detail changes
>     related to depcomp.sh. The code is untouched.
>
> ---
> Frédéric Bérat (3):
>   tests: Fix 'type defaults' error in link_cond due to main not being
>     properly declared
>   tests: Fix implicit function declaration errors
>   tests: Fix implicit function declaration in ax/depcomp.sh
>
>  t/ax/depcomp.sh              |  4 ++--
>  t/c-demo.sh                  |  1 +
>  t/cond35.sh                  |  2 ++
>  t/dist-vs-built-sources.sh   |  1 +
>  t/lex-clean.sh               |  1 +
>  t/lex-multiple.sh            |  4 ++++
>  t/lex-nodist.sh              |  2 ++
>  t/link_cond.sh               |  2 +-
>  t/ltcond2.sh                 |  2 ++
>  t/ltconv.sh                  |  6 ++++++
>  t/subobj-clean-lt-pr10697.sh | 10 +++++++++-
>  t/subobj-clean-pr10697.sh    | 10 +++++++++-
>  t/tags-pr12372.sh            |  3 ++-
>  t/yacc-basic.sh              |  1 +
>  t/yacc-clean.sh              |  4 ++++
>  t/yacc-nodist.sh             |  2 ++
>  16 files changed, 49 insertions(+), 6 deletions(-)

Hi Frederic,
Thanks for the work.
However, neither in this mail, nor in your original did I find a
corresponding patch.
Would you please resend them?

I looked here, too: https://bugs.gnu.org/59991

Message #23 received at 59991 <at> debbugs.gnu.org (full text, mbox):

From: Karl Berry <karl <at> freefriends.org>
To: jim <at> meyering.net
Cc: fberat <at> redhat.com, 59991 <at> debbugs.gnu.org
Subject: Re: [bug#59991] [PATCH v2 0/3] Port tests to modern C
Date: Sat, 4 Feb 2023 15:29:29 -0700

    However, neither in this mail, nor in your original did I find a
    corresponding patch.

Hi Jim - they ended up with separate bug#s, since separate emails.
At least I think these are those:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59992 (applied by mike?)
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59993

BTW, see also the next bug,
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59994
for more from Frederic, about flex madness.

karl

Message #26 received at 59991 <at> debbugs.gnu.org (full text, mbox):

From: Frederic Berat <fberat <at> redhat.com>
To: Karl Berry <karl <at> freefriends.org>
Cc: jim <at> meyering.net, 59991 <at> debbugs.gnu.org
Subject: Re: [bug#59991] [PATCH v2 0/3] Port tests to modern C
Date: Mon, 6 Feb 2023 13:54:31 +0100

[Message part 1 (text/plain, inline)]

Yes, they got separated bug IDs, next time I should probably consider
modifying the patch headers so that they are sent in reply to the cover
letter.

The first patch has been merged (
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59992).
The second has been divided in 2:
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59993#23
and
https://debbugs.gnu.org/cgi/bugreport.cgi?bug=60962 (I replied to the wrong
message when sending the v3)

Fred.




On Sat, Feb 4, 2023 at 11:29 PM Karl Berry <karl <at> freefriends.org> wrote:

>     However, neither in this mail, nor in your original did I find a
>     corresponding patch.
>
> Hi Jim - they ended up with separate bug#s, since separate emails.
> At least I think these are those:
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59992 (applied by mike?)
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59993
>
> BTW, see also the next bug,
> https://debbugs.gnu.org/cgi/bugreport.cgi?bug=59994
> for more from Frederic, about flex madness.
>
> karl
>
>

[Message part 2 (text/html, inline)]

Message #29 received at 59991 <at> debbugs.gnu.org (full text, mbox):

From: Karl Berry <karl <at> freefriends.org>
To: fberat <at> redhat.com, 59991 <at> debbugs.gnu.org
Subject: Re: [bug#59991] [PATCH v2 0/3] Port tests to modern C
Date: Wed, 15 Nov 2023 14:26:42 -0700

    Subject: [bug#59991] [PATCH v2 0/3] Port tests to modern C

I believe this "header patch" 59991 can be closed (so doing),
since 59992, 59993, and 60962 have been merged.
The related flex patch 59994 has also been merged.

Let me know if anything along these lines is outstanding. --thanks, karl.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.