GNU bug report logs - #59994
[PATCH] tests: Don't try to prevent flex to include unistd.h

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Package: automake-patches; Reported by: Frederic Berat <fberat@HIDDEN>; Keywords: patch; dated Mon, 12 Dec 2022 08:44:06 UTC; Maintainer for automake-patches is automake-patches@HIDDEN.

Message received at 59994 <at> debbugs.gnu.org:


Received: (at 59994) by debbugs.gnu.org; 13 Jan 2023 06:30:22 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Jan 13 01:30:22 2023
Received: from localhost ([127.0.0.1]:49308 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pGDa2-0002rO-7V
	for submit <at> debbugs.gnu.org; Fri, 13 Jan 2023 01:30:22 -0500
Received: from woodpecker.gentoo.org ([140.211.166.183]:42940
 helo=smtp.gentoo.org) by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <vapier@HIDDEN>) id 1pGDZy-0002Ol-N4
 for 59994 <at> debbugs.gnu.org; Fri, 13 Jan 2023 01:30:19 -0500
Received: by smtp.gentoo.org (Postfix, from userid 559)
 id 346F4340A8E; Fri, 13 Jan 2023 06:30:13 +0000 (UTC)
From: Mike Frysinger <vapier@HIDDEN>
To: fberat@HIDDEN
Subject: Re: [bug#59994] [PATCH] tests: Don't try to prevent flex to include
 unistd.h
User-Agent: GNU debbugs/0
Message-Id: <20230113063013.346F4340A8E@HIDDEN>
Date: Fri, 13 Jan 2023 06:30:13 +0000 (UTC)
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 59994
Cc: 59994 <at> debbugs.gnu.org, Zack Weinberg <zack@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)

On Mon, 12 Dec 2022 15:20:46 -0500, Zack Weinberg wrote:
> On 2022-12-12 2:07 AM, Frederic Berat wrote:
> > 
> > This patch is mainly a proposal. While the macro can simply be removed
> > as explained below, another possibility it to add a flex option
> > "--never-interactive" to prevent flex to make use of "isatty".
> >
> > This is related to an effort to prepare Automake for future GCC/Clang
> > versions which set c99 as default standard to be used.
> > 
> > Future version of flex make the "NO_UNISTD" flag a no-op, and include
> > unistd.h by default.
> > 
> > In current version of flex, not having this header leads to implicit
> > function declarations that are not compatible with c99 standard.
> > 
> > On top of that, while flex dedicated test were having this macro set,
> > the yacc ones didn't have it despise their use of Flex. Thus, if this
> > macro was ever useful, it looks like nobody actually cared.
>
> I'm guessing that the idea here was to avoid using unistd.h on platforms 
> that don't supply that header at all.  I suggest that we should apply 
> your patch *and* consistently test flex with "--never-interactive".

sounds fine.  want to update your patch Frederic ?
-mike
Information forwarded to automake-patches@HIDDEN:
bug#59994; Package automake-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 12 Dec 2022 20:20:52 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Dec 12 15:20:52 2022
Received: from localhost ([127.0.0.1]:55125 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1p4pIC-0003Sd-H9
	for submit <at> debbugs.gnu.org; Mon, 12 Dec 2022 15:20:52 -0500
Received: from lists.gnu.org ([209.51.188.17]:56334)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <zack@HIDDEN>) id 1p4pIB-0003SX-BM
 for submit <at> debbugs.gnu.org; Mon, 12 Dec 2022 15:20:51 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <zack@HIDDEN>) id 1p4pIB-0006In-32
 for automake-patches@HIDDEN; Mon, 12 Dec 2022 15:20:51 -0500
Received: from out4-smtp.messagingengine.com ([66.111.4.28])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <zack@HIDDEN>) id 1p4pI9-0004QR-LC
 for automake-patches@HIDDEN; Mon, 12 Dec 2022 15:20:50 -0500
Received: from compute2.internal (compute2.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id 6A7535C0166
 for <automake-patches@HIDDEN>; Mon, 12 Dec 2022 15:20:47 -0500 (EST)
Received: from mailfrontend1 ([10.202.2.162])
 by compute2.internal (MEProxy); Mon, 12 Dec 2022 15:20:47 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=owlfolio.org; h=
 cc:content-transfer-encoding:content-type:date:date:from:from
 :in-reply-to:in-reply-to:message-id:mime-version:references
 :reply-to:sender:subject:subject:to:to; s=fm1; t=1670876447; x=
 1670962847; bh=XQUNeOMYODDKYQeloWwUz46/cDfwVrAgY9+OuTZEpRc=; b=m
 bg2drYRjCaWZvhNB9jvYj2Y97QT3eFCF7erNEvvv/TifuoycNsdsdVb4gfRRd9HH
 KxY1zCi7vdmAPPaXA45XkogjDR9ZE9Tv6Q4sXW3hByZwI5w2JrDsVCGVub3yrgxi
 ojr+YCWv43Mgpg9YLYi5qNFIe1nSuSc232miPqVJOTLIh5mWDP2CZMZEO5vYysR1
 HdcSu0tuJBkUlUxwAJfj0PAnq2us7YWyzTE+KTOeJZ9MtbDWF2niw4b76IYNu6WV
 Ea0+H1fn8+Pn4Mit+klJvt7zqj9I9YySasyfSSE3wDNsFOQ40Ho/BpimCj89JqUj
 esCuWSL4gfasbMNrTC0mA==
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:date:feedback-id:feedback-id:from:from:in-reply-to
 :in-reply-to:message-id:mime-version:references:reply-to:sender
 :subject:subject:to:to:x-me-proxy:x-me-proxy:x-me-sender
 :x-me-sender:x-sasl-enc; s=fm2; t=1670876447; x=1670962847; bh=X
 QUNeOMYODDKYQeloWwUz46/cDfwVrAgY9+OuTZEpRc=; b=gE2/sSG2PpplSTtNT
 7aT/aZCMK6kJZzdim3BhjybKvs9LA9gTcQwTPnfm8MBy8rs9VeVVoUxWvZaNekL8
 uGH6MEcEeiKB9Nf7sVVTbJqHZrtfjXjmvjCLc3woFnYbDJk1wU0yJ6eH4faQYzFi
 dmtfNvqgnY9DLtmqrOugsZ0rppOiLwtEdPJvk9qqNo/0b72vgqvNmuiPOQnnwpP5
 QmfGm9Kr4dwFJRqTwdMml3vjJgH5Q9YiXkmplrqnH5qC9+yPTrFjeZwHIRtYXDRq
 j5zqg3m/VjofADCjgM1OxYZAxxq9v7IV84MQ011zeaOd3Ny6pm2ME++saZA8LJuQ
 +9oEg==
X-ME-Sender: <xms:H42XY-ihbjffc1SLdFxFzopcFozrf0fTjprTZ3fjS2NfQNNEfTMDLA>
 <xme:H42XY_B7Z7k0r2vdLTlgtSt0t1DOOe7E6HwoFCZZX4D5dXV8xqSlYPJnUVp4KKg0r
 Yoo7XRSn6Cjf7QJlgs>
X-ME-Received: <xmr:H42XY2G9CUOO18i4e4yATjXJ8J83lc-uRh1B-vBGu30P31UJESs-F9OljebydqlT7hqPTYAw3AWe_JgNuYbKyA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvdekgdduuddvucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucenucfjughrpefkffggfgfuvfhfhfgjtgfgsehtje
 ertddtfeejnecuhfhrohhmpegkrggtkhcuhggvihhnsggvrhhguceoiigrtghksehofihl
 fhholhhiohdrohhrgheqnecuggftrfgrthhtvghrnhepgedvueegveefudfhvdffudejhf
 fgleektdduvdeffedvueeuhfduiefgtdevjeefnecuvehluhhsthgvrhfuihiivgeptden
 ucfrrghrrghmpehmrghilhhfrhhomhepiigrtghksehofihlfhholhhiohdrohhrgh
X-ME-Proxy: <xmx:H42XY3Q0mkOzsCwlXUn0wLvG33lAPMYRirsffJhLvnqhcUSpd8cBag>
 <xmx:H42XY7xR_IJ9HmrEV-16R0_KhddiDdQCv3j5LduiV4LJ9kNK7qRbsA>
 <xmx:H42XY15RFFmLAUQ0BRmC6KQ-rTaR-eelhsCDiY0LT09GXBH1hrVC9w>
 <xmx:H42XY8s8xZVUoK7Tyhda17oWZD2DtWhu4RuEHmYCa5uDyPTrt5Rvfg>
Feedback-ID: i876146a2:Fastmail
Received: by mail.messagingengine.com (Postfix) with ESMTPA for
 <automake-patches@HIDDEN>; Mon, 12 Dec 2022 15:20:47 -0500 (EST)
Message-ID: <6cbed749-0346-f89d-28e0-5e459cbca47d@HIDDEN>
Date: Mon, 12 Dec 2022 15:20:46 -0500
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101
 Thunderbird/102.5.1
Subject: Re: [bug#59994] [PATCH] tests: Don't try to prevent flex to include
 unistd.h
Content-Language: en-US
To: automake-patches@HIDDEN
References: <20221212070752.1635797-1-fberat@HIDDEN>
From: Zack Weinberg <zack@HIDDEN>
In-Reply-To: <20221212070752.1635797-1-fberat@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Received-SPF: pass client-ip=66.111.4.28; envelope-from=zack@HIDDEN;
 helo=out4-smtp.messagingengine.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-0.001,
 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001,
 SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.7 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.7 (--)

On 2022-12-12 2:07 AM, Frederic Berat wrote:
> 
> This patch is mainly a proposal. While the macro can simply be removed
> as explained below, another possibility it to add a flex option
> "--never-interactive" to prevent flex to make use of "isatty".
>
> This is related to an effort to prepare Automake for future GCC/Clang
> versions which set c99 as default standard to be used.
> 
> Future version of flex make the "NO_UNISTD" flag a no-op, and include
> unistd.h by default.
> 
> In current version of flex, not having this header leads to implicit
> function declarations that are not compatible with c99 standard.
> 
> On top of that, while flex dedicated test were having this macro set,
> the yacc ones didn't have it despise their use of Flex. Thus, if this
> macro was ever useful, it looks like nobody actually cared.

I'm guessing that the idea here was to avoid using unistd.h on platforms 
that don't supply that header at all.  I suggest that we should apply 
your patch *and* consistently test flex with "--never-interactive".

zw
Information forwarded to automake-patches@HIDDEN:
bug#59994; Package automake-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 12 Dec 2022 08:43:16 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Dec 12 03:43:16 2022
Received: from localhost ([127.0.0.1]:51443 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1p4eP5-0004px-Ea
	for submit <at> debbugs.gnu.org; Mon, 12 Dec 2022 03:43:16 -0500
Received: from lists.gnu.org ([209.51.188.17]:34576)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <fberat@HIDDEN>) id 1p4cuz-0001IX-QA
 for submit <at> debbugs.gnu.org; Mon, 12 Dec 2022 02:08:06 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <fberat@HIDDEN>) id 1p4cuy-0004VM-C2
 for automake-patches@HIDDEN; Mon, 12 Dec 2022 02:08:05 -0500
Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124])
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <fberat@HIDDEN>) id 1p4cuw-00076B-IN
 for automake-patches@HIDDEN; Mon, 12 Dec 2022 02:08:04 -0500
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
 s=mimecast20190719; t=1670828881;
 h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
 content-transfer-encoding:content-transfer-encoding;
 bh=2XDiVNI3ZAMJ94Kltsaq9KCdZ7A2mBEr25zTZ5VD4us=;
 b=O/pyMRLxHxBFVlvXTk+BW4QkwBzGkuk/S74TBsWcHCIZw3LUx06hBJSqPhNq7hnJF+tDxo
 WwEPs+X3w/8B7mRp5pXcVrKt4M5kVYEuLide6xZ3L8m/Gwnv5aCk3iw1jr6PyDc8fQ9IO6
 0v18mN7vLSselcocRZbgoP6ZNfM8/Uk=
Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com
 [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS
 (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id
 us-mta-561-k3NC3U5bObO5Y-JYGn4uwg-1; Mon, 12 Dec 2022 02:08:00 -0500
X-MC-Unique: k3NC3U5bObO5Y-JYGn4uwg-1
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.rdu2.redhat.com
 [10.11.54.5])
 (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 1D01529AA2E3
 for <automake-patches@HIDDEN>; Mon, 12 Dec 2022 07:08:00 +0000 (UTC)
Received: from Nymeria-redhat.redhat.com (unknown [10.39.192.133])
 by smtp.corp.redhat.com (Postfix) with ESMTPS id 5947E53A7;
 Mon, 12 Dec 2022 07:07:59 +0000 (UTC)
From: Frederic Berat <fberat@HIDDEN>
To: automake-patches@HIDDEN
Subject: [PATCH] tests: Don't try to prevent flex to include unistd.h
Date: Mon, 12 Dec 2022 08:07:52 +0100
Message-Id: <20221212070752.1635797-1-fberat@HIDDEN>
MIME-Version: 1.0
X-Scanned-By: MIMEDefang 3.1 on 10.11.54.5
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=170.10.129.124; envelope-from=fberat@HIDDEN;
 helo=us-smtp-delivery-124.mimecast.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001,
 DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Mon, 12 Dec 2022 03:43:10 -0500
Cc: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20B=C3=A9rat?= <fberat@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

From: Frédéric Bérat <fberat@HIDDEN>

Hello,

This patch is mainly a proposal. While the macro can simply be removed
as explained below, another possibility it to add a flex option
"--never-interactive" to prevent flex to make use of "isatty".

-- 8< --

This is related to an effort to prepare Automake for future GCC/Clang
versions which set c99 as default standard to be used.

Future version of flex make the "NO_UNISTD" flag a no-op, and include
unistd.h by default.

In current version of flex, not having this header leads to implicit
function declarations that are not compatible with c99 standard.

On top of that, while flex dedicated test were having this macro set,
the yacc ones didn't have it despise their use of Flex. Thus, if this
macro was ever useful, it looks like nobody actually cared.

---
 t/cond35.sh       | 3 ---
 t/lex-clean.sh    | 3 ---
 t/lex-depend.sh   | 3 ---
 t/lex-header.sh   | 3 ---
 t/lex-lib.sh      | 3 ---
 t/lex-libobj.sh   | 3 ---
 t/lex-line.sh     | 3 ---
 t/lex-multiple.sh | 3 ---
 t/lex-nodist.sh   | 3 ---
 t/lex-noyywrap.sh | 3 ---
 t/lex3.sh         | 3 ---
 t/lex5.sh         | 3 ---
 t/lexvpath.sh     | 9 ---------
 t/silent-lex.sh   | 3 ---
 14 files changed, 48 deletions(-)

diff --git a/t/cond35.sh b/t/cond35.sh
index bad133970..435e02ffc 100644
--- a/t/cond35.sh
+++ b/t/cond35.sh
@@ -58,9 +58,6 @@ $FGREP 'tparse.h' Makefile.in # For debugging.
 test $($FGREP -c 'tparse.h:' Makefile.in) -eq 1
 
 cat > tscan.l << 'END'
-%{
-#define YY_NO_UNISTD_H 1
-%}
 %%
 "END"   return EOF;
 %%
diff --git a/t/lex-clean.sh b/t/lex-clean.sh
index e53da8fd2..6ab451173 100644
--- a/t/lex-clean.sh
+++ b/t/lex-clean.sh
@@ -52,9 +52,6 @@ LDADD = $(LEXLIB)
 END
 
 cat > lexer.l << 'END'
-%{
-#define YY_NO_UNISTD_H 1
-%}
 %%
 "GOOD"   return EOF;
 .
diff --git a/t/lex-depend.sh b/t/lex-depend.sh
index c6fde8c1f..7fbf60370 100644
--- a/t/lex-depend.sh
+++ b/t/lex-depend.sh
@@ -42,9 +42,6 @@ test-obj-updated: joe.$(OBJEXT)
 END
 
 cat > joe.l << 'END'
-%{
-#define YY_NO_UNISTD_H 1
-%}
 %%
 "foo" return EOF;
 .
diff --git a/t/lex-header.sh b/t/lex-header.sh
index 73beb95b6..46e8be60c 100644
--- a/t/lex-header.sh
+++ b/t/lex-header.sh
@@ -45,9 +45,6 @@ END
 
 cat > lexer.l << 'END'
 %option noyywrap
-%{
-#define YY_NO_UNISTD_H 1
-%}
 %%
 "GOOD"   return EOF;
 .
diff --git a/t/lex-lib.sh b/t/lex-lib.sh
index a251534d5..4ec75abe4 100644
--- a/t/lex-lib.sh
+++ b/t/lex-lib.sh
@@ -47,9 +47,6 @@ int yywrap (void)
 END
 
 cat > foo.l <<'END'
-%{
-#define YY_NO_UNISTD_H 1
-%}
 %%
 "END" return EOF;
 .
diff --git a/t/lex-libobj.sh b/t/lex-libobj.sh
index 5d4c13ebd..50ac10bb0 100644
--- a/t/lex-libobj.sh
+++ b/t/lex-libobj.sh
@@ -45,9 +45,6 @@ int yywrap (void)
 END
 
 cat > foo.l <<'END'
-%{
-#define YY_NO_UNISTD_H 1
-%}
 %%
 "END" return EOF;
 .
diff --git a/t/lex-line.sh b/t/lex-line.sh
index ef2a2a808..6107d0664 100644
--- a/t/lex-line.sh
+++ b/t/lex-line.sh
@@ -57,9 +57,6 @@ dir/quux.@OBJEXT@: dir/quux.c
 END
 
 cat > zardoz.l << 'END'
-%{
-#define YY_NO_UNISTD_H 1
-%}
 %%
 "END"  return EOF;
 .
diff --git a/t/lex-multiple.sh b/t/lex-multiple.sh
index bf119ec84..5f4695deb 100644
--- a/t/lex-multiple.sh
+++ b/t/lex-multiple.sh
@@ -76,9 +76,6 @@ int main (int argc, char *argv[])
 END
 
 cat > 0.l << 'END'
-%{
-#define YY_NO_UNISTD_H 1
-%}
 %%
 "VANILLA" { printf (":%s:\n", yytext); return 121; }
 . { printf (":%s:\n", yytext); return 1; }
diff --git a/t/lex-nodist.sh b/t/lex-nodist.sh
index 187dd5437..4a4d0f01c 100644
--- a/t/lex-nodist.sh
+++ b/t/lex-nodist.sh
@@ -45,9 +45,6 @@ check-local: test-build test-dist
 lexer.l:
 	rm -f $@ $@-t
 	:; { : \
-	  && echo '%{' \
-	  && echo '#define YY_NO_UNISTD_H 1' \
-	  && echo '%}' \
 	  && echo '%%' \
 	  && echo '"GOOD" return EOF;' \
 	  && echo '.'; \
diff --git a/t/lex-noyywrap.sh b/t/lex-noyywrap.sh
index c11813429..0451dbcf5 100644
--- a/t/lex-noyywrap.sh
+++ b/t/lex-noyywrap.sh
@@ -37,9 +37,6 @@ END
 
 cat > foo.l << 'END'
 %option noyywrap
-%{
-#define YY_NO_UNISTD_H 1
-%}
 %%
 "GOOD"   return EOF;
 .
diff --git a/t/lex3.sh b/t/lex3.sh
index 7de5fe2a6..9e54e7abf 100644
--- a/t/lex3.sh
+++ b/t/lex3.sh
@@ -33,9 +33,6 @@ foo_SOURCES = foo.l
 END
 
 cat > foo.l << 'END'
-%{
-#define YY_NO_UNISTD_H 1
-%}
 %%
 "GOOD"   return EOF;
 .
diff --git a/t/lex5.sh b/t/lex5.sh
index 0563a35ee..da354e2ac 100644
--- a/t/lex5.sh
+++ b/t/lex5.sh
@@ -36,9 +36,6 @@ END
 mkdir foo
 
 cat > foo/foo.l << 'END'
-%{
-#define YY_NO_UNISTD_H 1
-%}
 %%
 "END"   return EOF;
 .
diff --git a/t/lexvpath.sh b/t/lexvpath.sh
index 84187a916..33fab0a80 100644
--- a/t/lexvpath.sh
+++ b/t/lexvpath.sh
@@ -44,9 +44,6 @@ END
 
 # Original lexer, with a "foobar" comment
 cat > lexer.l << 'END'
-%{
-#define YY_NO_UNISTD_H 1
-%}
 %%
 "END" return EOF;
 .
@@ -89,9 +86,6 @@ $sleep
 
 # New lexer, with 'fubar' comment.
 cat > ../lexer.l << 'END'
-%{
-#define YY_NO_UNISTD_H 1
-%}
 %%
 "END" return EOF;
 .
@@ -112,9 +106,6 @@ $sleep
 
 # New lexer, with 'maude' comment.
 cat > ../lexer.l << 'END'
-%{
-#define YY_NO_UNISTD_H 1
-%}
 %%
 "END" return EOF;
 .
diff --git a/t/silent-lex.sh b/t/silent-lex.sh
index f319eee93..c15a30a9d 100644
--- a/t/silent-lex.sh
+++ b/t/silent-lex.sh
@@ -50,9 +50,6 @@ LDADD = $(LEXLIB)
 EOF
 
 cat > foo.l <<'EOF'
-%{
-#define YY_NO_UNISTD_H 1
-%}
 %%
 "END"   return EOF;
 .
-- 
2.38.1
Acknowledgement sent to Frederic Berat <fberat@HIDDEN>:
New bug report received and forwarded. Copy sent to automake-patches@HIDDEN. Full text available.
Report forwarded to automake-patches@HIDDEN:
bug#59994; Package automake-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Fri, 13 Jan 2023 06:45:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.