GNU bug report logs - #60001
[PATCH] Improve completion of treesit-check-indent command

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60001 in the body.
You can then email your comments to 60001 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Martín <mardani29 <at> yahoo.es>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Improve completion of treesit-check-indent command
Date: Mon, 12 Dec 2022 11:53:00 +0100

[Message part 1 (text/plain, inline)]

Tags: patch


The treesit-check-indent command is not really related to Tree-sitter
and could be in a more general place than treesit.el.  WDYT?

In any case, I have a patch to improve this command a bit by offering
more accurate completion for major modes, not Emacs commands.  I have
also tried to improve its documentation a bit.

Thanks.

[0001-Improve-completion-of-treesit-check-indent-command.patch (text/patch, attachment)]

Message #8 received at 60001 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Daniel Martín <mardani29 <at> yahoo.es>
Cc: 60001 <at> debbugs.gnu.org
Subject: Re: bug#60001: [PATCH] Improve completion of treesit-check-indent
 command
Date: Mon, 12 Dec 2022 16:00:24 +0200

> Date: Mon, 12 Dec 2022 11:53:00 +0100
> From:  Daniel Martín via "Bug reports for GNU Emacs,
>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> 
> The treesit-check-indent command is not really related to Tree-sitter
> and could be in a more general place than treesit.el.  WDYT?

I agree, but then we'd need a definition for it that doesn't need
tree-sitter support.  Is that easy to provide?

> In any case, I have a patch to improve this command a bit by offering
> more accurate completion for major modes, not Emacs commands.  I have
> also tried to improve its documentation a bit.

How about a read-major-mode function in subr.el?

But I think all these generalizations and improvements should go to
master.  On the release branch, I'd prefer to leave
treesit-check-indent alone.

Message #13 received at 60001 <at> debbugs.gnu.org (full text, mbox):

From: Yuan Fu <casouri <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 60001 <at> debbugs.gnu.org, Daniel Martín <mardani29 <at> yahoo.es>
Subject: Re: bug#60001: [PATCH] Improve completion of treesit-check-indent 
 command
Date: Sat, 7 Jan 2023 15:13:54 -0800

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Date: Mon, 12 Dec 2022 11:53:00 +0100
>> From:  Daniel Martín via "Bug reports for GNU Emacs,
>>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> 
>> The treesit-check-indent command is not really related to Tree-sitter
>> and could be in a more general place than treesit.el.  WDYT?
>
> I agree, but then we'd need a definition for it that doesn't need
> tree-sitter support.  Is that easy to provide?
>
>> In any case, I have a patch to improve this command a bit by offering
>> more accurate completion for major modes, not Emacs commands.  I have
>> also tried to improve its documentation a bit.
>
> How about a read-major-mode function in subr.el?
>
> But I think all these generalizations and improvements should go to
> master.  On the release branch, I'd prefer to leave
> treesit-check-indent alone.

Has this patch been pushed to master? Should I close this report?

Yuan

Message #16 received at 60001 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Yuan Fu <casouri <at> gmail.com>
Cc: 60001 <at> debbugs.gnu.org, mardani29 <at> yahoo.es
Subject: Re: bug#60001: [PATCH] Improve completion of treesit-check-indent 
 command
Date: Sun, 08 Jan 2023 13:53:33 +0200

> From: Yuan Fu <casouri <at> gmail.com>
> Date: Sat, 7 Jan 2023 15:13:54 -0800
> Cc: Daniel Martín <mardani29 <at> yahoo.es>,
>  60001 <at> debbugs.gnu.org
> 
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> Date: Mon, 12 Dec 2022 11:53:00 +0100
> >> From:  Daniel Martín via "Bug reports for GNU Emacs,
> >>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
> >> 
> >> The treesit-check-indent command is not really related to Tree-sitter
> >> and could be in a more general place than treesit.el.  WDYT?
> >
> > I agree, but then we'd need a definition for it that doesn't need
> > tree-sitter support.  Is that easy to provide?
> >
> >> In any case, I have a patch to improve this command a bit by offering
> >> more accurate completion for major modes, not Emacs commands.  I have
> >> also tried to improve its documentation a bit.
> >
> > How about a read-major-mode function in subr.el?
> >
> > But I think all these generalizations and improvements should go to
> > master.  On the release branch, I'd prefer to leave
> > treesit-check-indent alone.
> 
> Has this patch been pushed to master?

No, I don't think so.

> Should I close this report?

If you agree with the change, please install it.

Message #19 received at 60001 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 60001 <at> debbugs.gnu.org, Yuan Fu <casouri <at> gmail.com>, mardani29 <at> yahoo.es
Subject: Re: bug#60001: [PATCH] Improve completion of treesit-check-indent
 command
Date: Mon, 4 Sep 2023 13:02:23 -0700

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Yuan Fu <casouri <at> gmail.com>
>> Date: Sat, 7 Jan 2023 15:13:54 -0800
>> Cc: Daniel Martín <mardani29 <at> yahoo.es>,
>>  60001 <at> debbugs.gnu.org
>>
>>
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>
>> >> Date: Mon, 12 Dec 2022 11:53:00 +0100
>> >> From:  Daniel Martín via "Bug reports for GNU Emacs,
>> >>  the Swiss army knife of text editors" <bug-gnu-emacs <at> gnu.org>
>> >>
>> >> The treesit-check-indent command is not really related to Tree-sitter
>> >> and could be in a more general place than treesit.el.  WDYT?
>> >
>> > I agree, but then we'd need a definition for it that doesn't need
>> > tree-sitter support.  Is that easy to provide?
>> >
>> >> In any case, I have a patch to improve this command a bit by offering
>> >> more accurate completion for major modes, not Emacs commands.  I have
>> >> also tried to improve its documentation a bit.
>> >
>> > How about a read-major-mode function in subr.el?
>> >
>> > But I think all these generalizations and improvements should go to
>> > master.  On the release branch, I'd prefer to leave
>> > treesit-check-indent alone.
>>
>> Has this patch been pushed to master?
>
> No, I don't think so.
>
>> Should I close this report?
>
> If you agree with the change, please install it.

It seems like this patch was never installed.  Should it be?

Message #22 received at 60001 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 60001 <at> debbugs.gnu.org, casouri <at> gmail.com, mardani29 <at> yahoo.es
Subject: Re: bug#60001: [PATCH] Improve completion of treesit-check-indent
 command
Date: Tue, 05 Sep 2023 13:51:31 +0300

> From: Stefan Kangas <stefankangas <at> gmail.com>
> Date: Mon, 4 Sep 2023 13:02:23 -0700
> Cc: Yuan Fu <casouri <at> gmail.com>, 60001 <at> debbugs.gnu.org, mardani29 <at> yahoo.es
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> Should I close this report?
> >
> > If you agree with the change, please install it.
> 
> It seems like this patch was never installed.  Should it be?

I think so, yes.

Message #27 received at 60001-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 60001-done <at> debbugs.gnu.org, casouri <at> gmail.com, mardani29 <at> yahoo.es
Subject: Re: bug#60001: [PATCH] Improve completion of treesit-check-indent
 command
Date: Tue, 5 Sep 2023 13:40:53 -0700

Version: 30.1

Eli Zaretskii <eliz <at> gnu.org> writes:

>> From: Stefan Kangas <stefankangas <at> gmail.com>
>> Date: Mon, 4 Sep 2023 13:02:23 -0700
>> Cc: Yuan Fu <casouri <at> gmail.com>, 60001 <at> debbugs.gnu.org, mardani29 <at> yahoo.es
>>
>> Eli Zaretskii <eliz <at> gnu.org> writes:
>>
>> >> Should I close this report?
>> >
>> > If you agree with the change, please install it.
>>
>> It seems like this patch was never installed.  Should it be?
>
> I think so, yes.

Thanks, pushed to master as commit cd6dcfad107.

Message #30 received at 60001 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: 60001 <at> debbugs.gnu.org
Cc: stefankangas <at> gmail.com, mardani29 <at> yahoo.es
Subject: Re: bug#60001: [PATCH] Improve completion of treesit-check-indent
 command
Date: Wed, 06 Sep 2023 09:53:05 +0300

>>> > If you agree with the change, please install it.
>>>
>>> It seems like this patch was never installed.  Should it be?
>>
>> I think so, yes.
>
> Thanks, pushed to master as commit cd6dcfad107.

Would it be possible to avoid code duplication in
'treesit--read-major-mode' with the same code as in
'read-file-local-variable-mode'?

Maybe by creating a new core function to read a major mode?

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.