GNU bug report logs - #60022
configure.ac fix for C99 compatibility

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60022 in the body.
You can then email your comments to 60022 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Florian Weimer <fweimer <at> redhat.com>
To: bug-guile <at> gnu.org
Subject: configure.ac fix for C99 compatibility
Date: Mon, 12 Dec 2022 22:35:33 +0100

This patch is needed to improve C99 compatibility:

diff --git a/configure.ac b/configure.ac
index b3879df1f..cc865a028 100644
--- a/configure.ac
+++ b/configure.ac
@@ -904,7 +904,7 @@ AC_CACHE_VAL(guile_cv_localtime_cache,
 AC_RUN_IFELSE([AC_LANG_SOURCE([[#include <time.h>
 #include <stdlib.h>
 extern char **environ;
-unset_TZ ()
+int unset_TZ ()
 {
   char **from, **to;
   for (to = from = environ; (*to = *from); from++)
@@ -913,7 +913,7 @@ unset_TZ ()
 }
 char TZ_GMT0[] = "TZ=GMT0";
 char TZ_PST8[] = "TZ=PST8";
-main()
+int main()
 {
   time_t now = time ((time_t *) 0);
   int hour_GMT0, hour_unset;

Future compilers are likely to reject implicit int types by default.

Found via:

  <https://fedoraproject.org/wiki/Changes/PortingToModernC>
  <https://fedoraproject.org/wiki/Toolchain/PortingToModernC>

Thanks,
Florian

Message #10 received at 60022-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Florian Weimer <fweimer <at> redhat.com>
Cc: 60022-done <at> debbugs.gnu.org
Subject: Re: bug#60022: configure.ac fix for C99 compatibility
Date: Mon, 16 Jan 2023 23:19:27 +0100

Hi Florian,

Florian Weimer <fweimer <at> redhat.com> skribis:

> This patch is needed to improve C99 compatibility:
>
> diff --git a/configure.ac b/configure.ac
> index b3879df1f..cc865a028 100644
> --- a/configure.ac
> +++ b/configure.ac

Applied, thanks.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.