Maxim Cournoyer <maxim.cournoyer@HIDDEN>
to control <at> debbugs.gnu.org
.
Full text available.Received: (at 60069) by debbugs.gnu.org; 14 Dec 2022 18:33:37 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 14 13:33:36 2022 Received: from localhost ([127.0.0.1]:40869 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1p5WZU-0006K7-Ic for submit <at> debbugs.gnu.org; Wed, 14 Dec 2022 13:33:36 -0500 Received: from mail-qt1-f179.google.com ([209.85.160.179]:42944) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>) id 1p5WZS-0006Jz-81 for 60069 <at> debbugs.gnu.org; Wed, 14 Dec 2022 13:33:35 -0500 Received: by mail-qt1-f179.google.com with SMTP id i20so3172514qtw.9 for <60069 <at> debbugs.gnu.org>; Wed, 14 Dec 2022 10:33:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=4MIQSjdRVCh/DcdPNSMD97BB2BNrPahVHI27ObVR+b0=; b=PQwOqnWIZ7c1pxsQlu8S1m0Pexy4aq7F6ad8EUOFTrVWsr64dBGbGcj+Rs1Aism/3k akUSNZlR42r4lZm9fNLcb0RLeIQezZ30L1aooTnBGGuGecnBEsgGnypIEU7O+4ElBrUw M1WPHp5OcJi96ZBC1TQofRUqr8RL+yZBXXRdH45dnZEQY5SZz9UvVP/W5OCIavkVsdJW peLvGZO+BJicBl40/jcMn1y+cNHxTZB0lFg07lwP6/yawDYkkF3x3nKJyjjs4om/V534 sZLp6D628/UXbI2T/C0/NpmOSne4Ql3z4kacLmZ2IHtmdRx70zbwWCmcZi+NIpfIVZlv oLNg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=4MIQSjdRVCh/DcdPNSMD97BB2BNrPahVHI27ObVR+b0=; b=WNJ+N2B8COctMuyzwpCciOnW5vEQQuhFtRGbIz0uR2wfcVnhhZue4fxXl3QOMz1zEr iPIAzA4LGPfl+qxh9GhCt8yUH3ZfNElSq7tMyI09Xblo5tA2ctSxBXXpUhCi20tgXjxB GNNdZPBTS8dZOKiBGNYqz1FgnrVMJZNHMCwSexb3zsqyuC+4bhfkjhNO7IiS8clL0F8q dqpZsWDJIE4MCIr9AgUFJd21G3/khynGRWYRQo9/Lp2XIHZY7z6axMSDxbGEK249Lt5t ExNIJWD/E4PLFUl3vt2MyI4jE3XbWRo/BlxgX0GgeimaonbzFZvvEgQDnIQkCiqYTJ4g AIRA== X-Gm-Message-State: ANoB5pn7mkramZvLk5YRGfdMInc0kDrMCd9ymB4yQFqMnGCxqyM1JtYV Dv9vF3BdhAmLAutbl7kR1VVklEj1hc9S4A== X-Google-Smtp-Source: AA0mqf7eoIkHH6hdwRlsHAdUaKcRDbT0Q5Q3zBz2DaBai+2bi6h0U7epX2rtca/p0paZzqCrCdNwpQ== X-Received: by 2002:a05:622a:1a1a:b0:3a8:cf9:d33d with SMTP id f26-20020a05622a1a1a00b003a80cf9d33dmr34325900qtb.4.1671042808555; Wed, 14 Dec 2022 10:33:28 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1006]) by smtp.gmail.com with ESMTPSA id m5-20020ac84445000000b003a68f5d98c1sm2060006qtn.93.2022.12.14.10.33.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 10:33:28 -0800 (PST) From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> To: Tobias Geerinckx-Rice <me@HIDDEN> Subject: Re: bug#60069: [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require. References: <20221214155603.29381-1-maxim.cournoyer@HIDDEN> <20221214155603.29381-2-maxim.cournoyer@HIDDEN> <871qp2c54w.fsf@nckx> <875yed4zp5.fsf@HIDDEN> Date: Wed, 14 Dec 2022 13:33:26 -0500 In-Reply-To: <875yed4zp5.fsf@HIDDEN> (Maxim Cournoyer's message of "Wed, 14 Dec 2022 13:17:42 -0500") Message-ID: <87sfhh3keh.fsf_-_@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60069 Cc: 60069 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi, Maxim Cournoyer <maxim.cournoyer@HIDDEN> writes: > Hi Tobias, > > Tobias Geerinckx-Rice <me@HIDDEN> writes: > >> Maxim Cournoyer =E5=86=99=E9=81=93=EF=BC=9A >>> - [ "${#warn}" -ne 0 ] && >>> - { _err "${ERR}Missing commands: ${warn[*]}."; >>> - return 1; } >>> - + [ "${#warn}" -ne 0 ] && die "Missing commands: >>> ${warn[*]}." >>> + >> >> I did not run this, but will it not itself trigger -e when the test >> is false? > > This apparently falls in the special casing by Bash of what is > considered a failure when using 'set -e'; here's a test: > > $ cat test.sh > #!/usr/bin/env bash > > set -e > > [ false ] && echo "hey, we made it!" > > $ ./test.sh > hey, we made it! The above example was bogus and unnecessary; looking at it more closely, the test would return true when the 'warn' array contains 1 or more items (missing commands), which would cause the die command to be invoked and the script to exit. The first test handling isn't modified, so it'll chain though the second part the same as it does now. I hope that's a better explanation. --=20 Thanks, Maxim
guix-patches@HIDDEN
:bug#60069
; Package guix-patches
.
Full text available.Received: (at 60069) by debbugs.gnu.org; 14 Dec 2022 18:17:53 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 14 13:17:53 2022 Received: from localhost ([127.0.0.1]:40789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1p5WKG-000690-QY for submit <at> debbugs.gnu.org; Wed, 14 Dec 2022 13:17:53 -0500 Received: from mail-qt1-f172.google.com ([209.85.160.172]:36588) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>) id 1p5WKE-00068f-0d for 60069 <at> debbugs.gnu.org; Wed, 14 Dec 2022 13:17:50 -0500 Received: by mail-qt1-f172.google.com with SMTP id fz10so3166276qtb.3 for <60069 <at> debbugs.gnu.org>; Wed, 14 Dec 2022 10:17:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=N3O5yoMWfCq4+RuSkSbTsCwToRoFDvtSI0ksz7f4p1Y=; b=fA75nu5uT0pbo11/BmQEVQQqwM5CgfhyRsRJzRpnoICWmALvx3CZfwj77uL3yF9q/P aLpqm6WkZX9PZdjhZWvNeJR4tsMozUMQ2I+RkyCTBaqfBKxf/3+bk0++54GqAsg8yM1K 6/8/0dEpm3CYdIQUba3FLKPwMpaxo/o0ZmM8pp70AAPvQCL3TfTh+eIBry/nXO+O/QlJ bpda+We6dmPAZNIp7jjmzA6XWLS9V8SrgWMph2yV/Ge+qQZwJnVpu23sBLZNHP7xD7Oe EBws7Icn4/z4wzyP9UC/b0blHVEMrNr8YqyElQUdC/Rtn9vAnI7mZZL4ub5m+LXJKIoY n6yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=N3O5yoMWfCq4+RuSkSbTsCwToRoFDvtSI0ksz7f4p1Y=; b=cURkpDW+dCEKpiqADf3YvHwtoQrd3ivI+x1O6mDM3oQLqKfEmvhbH+1aDHLqDrFJ8w m0ptFa7FR5nUDFemr4T6zReyk/RR+W/1DyVyavp2JeAjYMcpmALLqQrIDaxDJDwfLIE4 GPxRi/POHIvnHUyVevX79NelDRXhQGPzHVY0XoXRFVOLBpZOhXNVErxg4AesgqQxN2WJ gFJOh3sisHXztysYDoZKellHgIO+7Td59ijPUK7BtgnRDHCVvmkPnpUSedrav+ThD9hX uYWzs3UzNLReggZZNvQw8X1/otAA4XrPDvB8tPXvM4xhlhk9AsSEoF0P3JkLWtPDraP5 Hzww== X-Gm-Message-State: ANoB5pk2nzwgSpGhZdFiJ8LkoXLz8OkdhW7t6H8BKi5uyqrccYxiQ05O eMKv2voRM/bD5jLhleKGdLokOsJMMe+3Mw== X-Google-Smtp-Source: AA0mqf6fqqSFxCaMCnVhxXn9Hl8DAzz7TNBRs+SQSgmZPy2orbjFDORzVISHFL6ilgI9LG0hZy7Lpg== X-Received: by 2002:ac8:6042:0:b0:3a8:12be:4136 with SMTP id k2-20020ac86042000000b003a812be4136mr11029521qtm.8.1671041864372; Wed, 14 Dec 2022 10:17:44 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1006]) by smtp.gmail.com with ESMTPSA id h9-20020ac81389000000b003a7ef7a758dsm2020260qtj.59.2022.12.14.10.17.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 10:17:43 -0800 (PST) From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> To: Tobias Geerinckx-Rice <me@HIDDEN> Subject: Re: [bug#60069] [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require. References: <20221214155603.29381-1-maxim.cournoyer@HIDDEN> <20221214155603.29381-2-maxim.cournoyer@HIDDEN> <871qp2c54w.fsf@nckx> Date: Wed, 14 Dec 2022 13:17:42 -0500 In-Reply-To: <871qp2c54w.fsf@nckx> (Tobias Geerinckx-Rice's message of "Wed, 14 Dec 2022 17:37:19 +0100") Message-ID: <875yed4zp5.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 60069 Cc: 60069 <at> debbugs.gnu.org, guix-patches@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Hi Tobias, Tobias Geerinckx-Rice <me@HIDDEN> writes: > Maxim Cournoyer =E5=86=99=E9=81=93=EF=BC=9A >> - [ "${#warn}" -ne 0 ] && >> - { _err "${ERR}Missing commands: ${warn[*]}."; >> - return 1; } >> - + [ "${#warn}" -ne 0 ] && die "Missing commands: >> ${warn[*]}." >> + > > I did not run this, but will it not itself trigger -e when the test > is false? This apparently falls in the special casing by Bash of what is considered a failure when using 'set -e'; here's a test: --8<---------------cut here---------------start------------->8--- $ cat test.sh #!/usr/bin/env bash set -e [ false ] && echo "hey, we made it!" --8<---------------cut here---------------end--------------->8--- --8<---------------cut here---------------start------------->8--- $ ./test.sh hey, we made it! --8<---------------cut here---------------end--------------->8--- I hope this answers your question. --=20 Thanks, Maxim
guix-patches@HIDDEN
:bug#60069
; Package guix-patches
.
Full text available.Received: (at submit) by debbugs.gnu.org; 14 Dec 2022 18:17:50 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 14 13:17:50 2022 Received: from localhost ([127.0.0.1]:40786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1p5WKE-00068o-2k for submit <at> debbugs.gnu.org; Wed, 14 Dec 2022 13:17:50 -0500 Received: from lists.gnu.org ([209.51.188.17]:44776) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>) id 1p5WKB-00068i-Dr for submit <at> debbugs.gnu.org; Wed, 14 Dec 2022 13:17:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <maxim.cournoyer@HIDDEN>) id 1p5WKB-0000V0-9Q for guix-patches@HIDDEN; Wed, 14 Dec 2022 13:17:47 -0500 Received: from mail-qt1-x831.google.com ([2607:f8b0:4864:20::831]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <maxim.cournoyer@HIDDEN>) id 1p5WK9-0003EZ-Lc for guix-patches@HIDDEN; Wed, 14 Dec 2022 13:17:47 -0500 Received: by mail-qt1-x831.google.com with SMTP id c7so3138553qtw.8 for <guix-patches@HIDDEN>; Wed, 14 Dec 2022 10:17:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=N3O5yoMWfCq4+RuSkSbTsCwToRoFDvtSI0ksz7f4p1Y=; b=fA75nu5uT0pbo11/BmQEVQQqwM5CgfhyRsRJzRpnoICWmALvx3CZfwj77uL3yF9q/P aLpqm6WkZX9PZdjhZWvNeJR4tsMozUMQ2I+RkyCTBaqfBKxf/3+bk0++54GqAsg8yM1K 6/8/0dEpm3CYdIQUba3FLKPwMpaxo/o0ZmM8pp70AAPvQCL3TfTh+eIBry/nXO+O/QlJ bpda+We6dmPAZNIp7jjmzA6XWLS9V8SrgWMph2yV/Ge+qQZwJnVpu23sBLZNHP7xD7Oe EBws7Icn4/z4wzyP9UC/b0blHVEMrNr8YqyElQUdC/Rtn9vAnI7mZZL4ub5m+LXJKIoY n6yA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:message-id :in-reply-to:date:references:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=N3O5yoMWfCq4+RuSkSbTsCwToRoFDvtSI0ksz7f4p1Y=; b=C0VnObTN8DbjHxq7U6Emur+VMrBPjNunkqAAsHtpjjRbwRGtcOUhyI3SnlSEc4RWmQ LMIRtUuDCFRSE92Kbqf3XfbQHM7fPINWX3VdxAKQ2GWFqJs9cSd15D3lvsa24Gi9oKU8 8b78maevtwzkiTFS4hKbp4YmxfL0fHCZtyoc5XKYRyvxuq+mpyVwSbmBabbcQCzvlviK cUOYFNzXPeKgRnGJ4PIMaVZTwIzcgu4mimy2GxoEX8Vl+VhgpXUQ1EOB8TAAsa3Ft6UR AjWldT25SXSFATMwTXe8CWNz1TRrxvcEHOXx3CLONT0W2wdd4cIaZxU4YIy8Q7HvC+hh 4qMA== X-Gm-Message-State: ANoB5pmnxHYqUuSbSTvUg2WKKWjO8Rh21Xugv1hac8LMhlefMb1hZ7rn mrOjeATs2v48kpG46ONC2fKQBSHPM9EwSQ== X-Google-Smtp-Source: AA0mqf6fqqSFxCaMCnVhxXn9Hl8DAzz7TNBRs+SQSgmZPy2orbjFDORzVISHFL6ilgI9LG0hZy7Lpg== X-Received: by 2002:ac8:6042:0:b0:3a8:12be:4136 with SMTP id k2-20020ac86042000000b003a812be4136mr11029521qtm.8.1671041864372; Wed, 14 Dec 2022 10:17:44 -0800 (PST) Received: from hurd ([2607:fad8:4:3::1006]) by smtp.gmail.com with ESMTPSA id h9-20020ac81389000000b003a7ef7a758dsm2020260qtj.59.2022.12.14.10.17.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 10:17:43 -0800 (PST) From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> To: Tobias Geerinckx-Rice <me@HIDDEN> Subject: Re: [bug#60069] [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require. References: <20221214155603.29381-1-maxim.cournoyer@HIDDEN> <20221214155603.29381-2-maxim.cournoyer@HIDDEN> <871qp2c54w.fsf@nckx> Date: Wed, 14 Dec 2022 13:17:42 -0500 In-Reply-To: <871qp2c54w.fsf@nckx> (Tobias Geerinckx-Rice's message of "Wed, 14 Dec 2022 17:37:19 +0100") Message-ID: <875yed4zp5.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Received-SPF: pass client-ip=2607:f8b0:4864:20::831; envelope-from=maxim.cournoyer@HIDDEN; helo=mail-qt1-x831.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: 60069 <at> debbugs.gnu.org, guix-patches@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) Hi Tobias, Tobias Geerinckx-Rice <me@HIDDEN> writes: > Maxim Cournoyer =E5=86=99=E9=81=93=EF=BC=9A >> - [ "${#warn}" -ne 0 ] && >> - { _err "${ERR}Missing commands: ${warn[*]}."; >> - return 1; } >> - + [ "${#warn}" -ne 0 ] && die "Missing commands: >> ${warn[*]}." >> + > > I did not run this, but will it not itself trigger -e when the test > is false? This apparently falls in the special casing by Bash of what is considered a failure when using 'set -e'; here's a test: --8<---------------cut here---------------start------------->8--- $ cat test.sh #!/usr/bin/env bash set -e [ false ] && echo "hey, we made it!" --8<---------------cut here---------------end--------------->8--- --8<---------------cut here---------------start------------->8--- $ ./test.sh hey, we made it! --8<---------------cut here---------------end--------------->8--- I hope this answers your question. --=20 Thanks, Maxim
guix-patches@HIDDEN
:bug#60069
; Package guix-patches
.
Full text available.Received: (at 60069) by debbugs.gnu.org; 14 Dec 2022 16:36:46 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 14 11:36:46 2022 Received: from localhost ([127.0.0.1]:40252 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1p5UkP-00050C-Ps for submit <at> debbugs.gnu.org; Wed, 14 Dec 2022 11:36:46 -0500 Received: from tobias.gr ([80.241.217.52]:41646) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <me@HIDDEN>) id 1p5UkO-000506-IM for 60069 <at> debbugs.gnu.org; Wed, 14 Dec 2022 11:36:45 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=HQWdtX9z4rVL9 4fA4/3z189dhAr7Swfr5EOHsgR9Ykg=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=kFkeeUlSn2xtEB1SxFpG0iYtdG3MDeAsDw0QRn vsp5E4N4hHfnUceXYurzrSmrU/BTsy2hzWtChCYEh4smppEkDnaN+rpfHnvUC+EFGu/IzS fbddBpkLbYkVfYSg0LNCxFuc8RWu+GdROA6WnSv0tD2MnWqiI2CNyO7oj6SyG35WbMZEJE 8VoU3DkT6XqS4xRWNZvR5nr7IaqqI1rpRL/RCNbQEzYklXmUCFw776i0NHhnLIUqv7ELuL sY0yt+mwlZgdVlF52ZBrTQ6uajX8GaG9uiJXzUk6z/Wluio2cuZBSwBlZK8zsldLPeCFHC YzlBeIbdWZsU7eoQBFrrindA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id e9f87e7c (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 14 Dec 2022 16:36:41 +0000 (UTC) References: <20221214155603.29381-1-maxim.cournoyer@HIDDEN> <20221214155603.29381-2-maxim.cournoyer@HIDDEN> From: Tobias Geerinckx-Rice <me@HIDDEN> To: Maxim Cournoyer <maxim.cournoyer@HIDDEN> Subject: Re: [bug#60069] [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require. Date: Wed, 14 Dec 2022 17:37:19 +0100 In-reply-to: <20221214155603.29381-2-maxim.cournoyer@HIDDEN> BIMI-Selector: v=BIMI1; s=default; Message-ID: <871qp2c54w.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60069 Cc: 60069 <at> debbugs.gnu.org, guix-patches@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Maxim Cournoyer =E5=86=99=E9=81=93=EF=BC=9A > - [ "${#warn}" -ne 0 ] && > - { _err "${ERR}Missing commands: ${warn[*]}."; > - return 1; } > -=20=20=20=20 > + [ "${#warn}" -ne 0 ] && die "Missing commands: ${warn[*]}." > + I did not run this, but will it not itself trigger -e when the=20 test is false? Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCY5n7/w0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW153VEBAMZc1COX05j1JvkESrO5nlRi50eA3a+azXu7O3HW KAJoAQDMJihIBA5fp84NNcckxHto8PMi+dC9sXNcDFCU23NzAg== =1EgH -----END PGP SIGNATURE----- --=-=-=--
guix-patches@HIDDEN
:bug#60069
; Package guix-patches
.
Full text available.Received: (at submit) by debbugs.gnu.org; 14 Dec 2022 16:36:53 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 14 11:36:53 2022 Received: from localhost ([127.0.0.1]:40260 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1p5UkX-00050b-B0 for submit <at> debbugs.gnu.org; Wed, 14 Dec 2022 11:36:53 -0500 Received: from lists.gnu.org ([209.51.188.17]:58238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <me@HIDDEN>) id 1p5UkS-00050O-8D for submit <at> debbugs.gnu.org; Wed, 14 Dec 2022 11:36:48 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <me@HIDDEN>) id 1p5UkR-0001JY-Ba for guix-patches@HIDDEN; Wed, 14 Dec 2022 11:36:48 -0500 Received: from tobias.gr ([2a02:c205:2020:6054::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <me@HIDDEN>) id 1p5UkP-0006EP-Ft for guix-patches@HIDDEN; Wed, 14 Dec 2022 11:36:47 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; s=2018; bh=HQWdtX9z4rVL9 4fA4/3z189dhAr7Swfr5EOHsgR9Ykg=; h=in-reply-to:date:subject:cc:to: from:references; d=tobias.gr; b=kFkeeUlSn2xtEB1SxFpG0iYtdG3MDeAsDw0QRn vsp5E4N4hHfnUceXYurzrSmrU/BTsy2hzWtChCYEh4smppEkDnaN+rpfHnvUC+EFGu/IzS fbddBpkLbYkVfYSg0LNCxFuc8RWu+GdROA6WnSv0tD2MnWqiI2CNyO7oj6SyG35WbMZEJE 8VoU3DkT6XqS4xRWNZvR5nr7IaqqI1rpRL/RCNbQEzYklXmUCFw776i0NHhnLIUqv7ELuL sY0yt+mwlZgdVlF52ZBrTQ6uajX8GaG9uiJXzUk6z/Wluio2cuZBSwBlZK8zsldLPeCFHC YzlBeIbdWZsU7eoQBFrrindA== Received: by submission.tobias.gr (OpenSMTPD) with ESMTPSA id e9f87e7c (TLSv1.3:AEAD-AES256-GCM-SHA384:256:NO); Wed, 14 Dec 2022 16:36:41 +0000 (UTC) References: <20221214155603.29381-1-maxim.cournoyer@HIDDEN> <20221214155603.29381-2-maxim.cournoyer@HIDDEN> From: Tobias Geerinckx-Rice <me@HIDDEN> To: Maxim Cournoyer <maxim.cournoyer@HIDDEN> Subject: Re: [bug#60069] [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require. Date: Wed, 14 Dec 2022 17:37:19 +0100 In-reply-to: <20221214155603.29381-2-maxim.cournoyer@HIDDEN> BIMI-Selector: v=BIMI1; s=default; Message-ID: <871qp2c54w.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" Received-SPF: pass client-ip=2a02:c205:2020:6054::1; envelope-from=me@HIDDEN; helo=tobias.gr X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit Cc: 60069 <at> debbugs.gnu.org, guix-patches@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.6 (--) --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Maxim Cournoyer =E5=86=99=E9=81=93=EF=BC=9A > - [ "${#warn}" -ne 0 ] && > - { _err "${ERR}Missing commands: ${warn[*]}."; > - return 1; } > -=20=20=20=20 > + [ "${#warn}" -ne 0 ] && die "Missing commands: ${warn[*]}." > + I did not run this, but will it not itself trigger -e when the=20 test is false? Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iIMEARYKACsWIQT12iAyS4c9C3o4dnINsP+IT1VteQUCY5n7/w0cbWVAdG9iaWFz LmdyAAoJEA2w/4hPVW153VEBAMZc1COX05j1JvkESrO5nlRi50eA3a+azXu7O3HW KAJoAQDMJihIBA5fp84NNcckxHto8PMi+dC9sXNcDFCU23NzAg== =1EgH -----END PGP SIGNATURE----- --=-=-=--
guix-patches@HIDDEN
:bug#60069
; Package guix-patches
.
Full text available.Received: (at submit) by debbugs.gnu.org; 14 Dec 2022 15:56:24 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 14 10:56:24 2022 Received: from localhost ([127.0.0.1]:40036 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1p5U7M-0004aj-AT for submit <at> debbugs.gnu.org; Wed, 14 Dec 2022 10:56:24 -0500 Received: from lists.gnu.org ([209.51.188.17]:40692) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <maxim.cournoyer@HIDDEN>) id 1p5U7J-0004aW-4J for submit <at> debbugs.gnu.org; Wed, 14 Dec 2022 10:56:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <maxim.cournoyer@HIDDEN>) id 1p5U7I-0000Pw-Rg for guix-patches@HIDDEN; Wed, 14 Dec 2022 10:56:20 -0500 Received: from mail-qt1-x82b.google.com ([2607:f8b0:4864:20::82b]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <maxim.cournoyer@HIDDEN>) id 1p5U7H-0005aw-9d for guix-patches@HIDDEN; Wed, 14 Dec 2022 10:56:20 -0500 Received: by mail-qt1-x82b.google.com with SMTP id fz10so2800590qtb.3 for <guix-patches@HIDDEN>; Wed, 14 Dec 2022 07:56:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=r1e7GD9O2+hfD7OLoW8NerYiWInDFB5EbjU5xiHA/w8=; b=eAC9CsjU+4SXqay2a+y8/ziKameiGIy9B/Pb3DS5yQ0C9ITog4Ofi1DAfPzaAL1hyC iKlc47IkQWjFlxU6BMJ0iF+GOjau7M2enEMXodXe3ldRUvvqY7otH5RYIfiLc1M+EVwl MN692sw0Ecw8wn6hT4mFUwSaGJQz36XOiyZ7dlL1d6LaYlrh7cV/p+ChkHxBPsHIZ1t5 sGGVDAz9JqVTt8Z0so4vYTmpTWggmvRHATjrynxwHE44CkX7X1onXfhev+8mq9XyeRS9 9LZZfL1Gm3uhAZkeY8WwkBSXcdI7xRnDxaayZPuCSB7fazeNaz3I1FS63/n3/1wCYs5r lDjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=r1e7GD9O2+hfD7OLoW8NerYiWInDFB5EbjU5xiHA/w8=; b=VT2q7/qHdnpqjy0Ya67wYq1LH6pbrteDyxzScIh4HrLIn+LGrCtWR2IE616+3+6/PP z7Qk45RYK+0PIvEBmOFiXi7uMcIAgyOquohFU5dY8XJglUO9USz1khG3URgDnHemcF9v o9ocUzN8jVUl05JJuqLUt8mwr9WKCUcaM29KnPc35o5c5j6a9taXJ45XfctsWZlTq3xM f/oPIDqwguMuDw593RyLhN45jyqWbe9RTHz5H3d+dX9CD0HAcZsEzEi3Fn2ZJ+QkKBal jqSZcrdvZs8hLSo03ijTuK8llJvDAwKhQwQQ4VRnNdyc5PX3q6c5245dmn9oFfpwPN5P evvQ== X-Gm-Message-State: ANoB5plhXiAdZ+MWk3YlL3sEmtka8gLo821Z3kb63AmIKVUQVihUC8m7 vfc3fMhUhEkkLRVTDWVe6yWyJqEPvQWiAA== X-Google-Smtp-Source: AA0mqf6uRwO1InbTRP97WvgEsbf2Iecwrno9NYY/R+nGTX9CFEQ6eaqzt0Q41E+yWV26BZjebSz1Rw== X-Received: by 2002:ac8:545a:0:b0:3a8:649:8d0a with SMTP id d26-20020ac8545a000000b003a806498d0amr27485103qtq.30.1671033378078; Wed, 14 Dec 2022 07:56:18 -0800 (PST) Received: from localhost.localdomain ([2607:fad8:4:3::1006]) by smtp.gmail.com with ESMTPSA id k10-20020ac8074a000000b00397b1c60780sm1829150qth.61.2022.12.14.07.56.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Dec 2022 07:56:17 -0800 (PST) From: Maxim Cournoyer <maxim.cournoyer@HIDDEN> To: guix-patches@HIDDEN Subject: [PATCH 2/2] guix-install.sh: Directly exit in case of errors in chk_require. Date: Wed, 14 Dec 2022 10:56:03 -0500 Message-Id: <20221214155603.29381-2-maxim.cournoyer@HIDDEN> X-Mailer: git-send-email 2.38.1 In-Reply-To: <20221214155603.29381-1-maxim.cournoyer@HIDDEN> References: <20221214155603.29381-1-maxim.cournoyer@HIDDEN> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::82b; envelope-from=maxim.cournoyer@HIDDEN; helo=mail-qt1-x82b.google.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Maxim Cournoyer <maxim.cournoyer@HIDDEN> X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) * etc/guix-install.sh (chk_require): Directly exit in case of errors in chk_require, instead of relying on 'set -e'. --- etc/guix-install.sh | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/etc/guix-install.sh b/etc/guix-install.sh index 06730f7e3f..0ca12f8b66 100755 --- a/etc/guix-install.sh +++ b/etc/guix-install.sh @@ -137,10 +137,8 @@ chk_require() command -v "$c" &>/dev/null || warn+=("$c") done - [ "${#warn}" -ne 0 ] && - { _err "${ERR}Missing commands: ${warn[*]}."; - return 1; } - + [ "${#warn}" -ne 0 ] && die "Missing commands: ${warn[*]}." + _msg "${PAS}verification of required commands completed" } -- 2.38.1
Maxim Cournoyer <maxim.cournoyer@HIDDEN>
:guix-patches@HIDDEN
.
Full text available.guix-patches@HIDDEN
:bug#60069
; Package guix-patches
.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.