GNU bug report logs - #60093
29.0.60; imenu: Variables defined via defvar-keymap are not listed

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60093 in the body.
You can then email your comments to 60093 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: bug-gnu-emacs <at> gnu.org
Subject: 29.0.60; imenu: Variables defined via defvar-keymap are not listed
Date: Thu, 15 Dec 2022 15:49:31 +0100

Keymaps defined via `defvar-keymap' are not available in the Imenu. It is
necessary to extend `imenu-generic-expression'.

In GNU Emacs 29.0.60 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo
 version 1.16.0, Xaw scroll bars) of 2022-12-11 built on projects
Repository revision: f221105723dc8d3ee9f3c8d1c2717058afbc6666
Repository branch: emacs-29
Windowing system distributor 'The X.Org Foundation', version 11.0.12004000
System Description: Debian GNU/Linux 10 (buster)

Message #8 received at 60093 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: 60093 <at> debbugs.gnu.org
Subject: Re: bug#60093: 29.0.60;
 imenu: Variables defined via defvar-keymap are not listed
Date: Sat, 17 Dec 2022 14:53:40 +0200

> From: Daniel Mendler <mail <at> daniel-mendler.de>
> Date: Thu, 15 Dec 2022 15:49:31 +0100
> 
> Keymaps defined via `defvar-keymap' are not available in the Imenu. It is
> necessary to extend `imenu-generic-expression'.

Thanks.  Would you like to suggest a patch to fix this?

Message #11 received at 60093 <at> debbugs.gnu.org (full text, mbox):

From: Daniel Mendler <mail <at> daniel-mendler.de>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: 60093 <at> debbugs.gnu.org
Subject: Re: bug#60093: 29.0.60; imenu: Variables defined via defvar-keymap
 are not listed
Date: Mon, 19 Dec 2022 10:54:27 +0100

On 12/17/22 13:53, Eli Zaretskii wrote:
>> From: Daniel Mendler <mail <at> daniel-mendler.de>
>> Date: Thu, 15 Dec 2022 15:49:31 +0100
>>
>> Keymaps defined via `defvar-keymap' are not available in the Imenu. It is
>> necessary to extend `imenu-generic-expression'.
> 
> Thanks.  Would you like to suggest a patch to fix this?

I don't have a patch ready. Currently I use the following line in my
configuration which also recognizes Embark keymaps. Would we want to
list keymaps as a separate Imenu category "Keymaps" or as "Variables"?

(add-to-list 'imenu-generic-expression '("Keymaps"
"^[^;]*(\\(?:embark-define-keymap\\|defvar-keymap\\)\\s-+\\(\\(?:\\sw\\|\\s_\\)+\\)"
1) 'append))))

Message #14 received at 60093 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: 60093 <at> debbugs.gnu.org
Subject: Re: bug#60093: 29.0.60; imenu: Variables defined via defvar-keymap
 are not listed
Date: Mon, 19 Dec 2022 14:46:13 +0200

> Date: Mon, 19 Dec 2022 10:54:27 +0100
> Cc: 60093 <at> debbugs.gnu.org
> From: Daniel Mendler <mail <at> daniel-mendler.de>
> 
> > Thanks.  Would you like to suggest a patch to fix this?
> 
> I don't have a patch ready. Currently I use the following line in my
> configuration which also recognizes Embark keymaps. Would we want to
> list keymaps as a separate Imenu category "Keymaps" or as "Variables"?

I think we want it with "Variables", since its name hints on that.

Message #17 received at 60093 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Daniel Mendler <mail <at> daniel-mendler.de>
Cc: 60093 <at> debbugs.gnu.org
Subject: Re: bug#60093: 29.0.60; imenu: Variables defined via defvar-keymap
 are not listed
Date: Wed, 6 Sep 2023 02:14:32 -0700

forcemerge 64831 60093
thanks

Daniel Mendler <mail <at> daniel-mendler.de> writes:

> Keymaps defined via `defvar-keymap' are not available in the Imenu. It is
> necessary to extend `imenu-generic-expression'.

This was fixed in

commit bcadb728e2f46263ca69a4702b70ff2c3bb62deb
Author: Brian Leung <leungbk <at> posteo.net>
Date:   Mon Jul 24 04:32:19 2023 -0700

    lisp-mode.el: Add defvar-keymap to lisp-imenu-generic-expression

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.