Received: (at 60187) by debbugs.gnu.org; 10 Jan 2024 22:36:24 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Jan 10 17:36:23 2024 Received: from localhost ([127.0.0.1]:43493 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1rNhBP-0002Rj-Fn for submit <at> debbugs.gnu.org; Wed, 10 Jan 2024 17:36:23 -0500 Received: from mail-ed1-x531.google.com ([2a00:1450:4864:20::531]:45562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <stefankangas@HIDDEN>) id 1rNhBN-0002RW-CP for 60187 <at> debbugs.gnu.org; Wed, 10 Jan 2024 17:36:21 -0500 Received: by mail-ed1-x531.google.com with SMTP id 4fb4d7f45d1cf-5588a83e0d0so192328a12.3 for <60187 <at> debbugs.gnu.org>; Wed, 10 Jan 2024 14:36:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1704926176; x=1705530976; darn=debbugs.gnu.org; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:from:to:cc:subject:date:message-id:reply-to; bh=I8n4Pt+myEq8q8o5UJL2e7tQhXfsDz6rW314koYLS2E=; b=fB9OZSbX5MPCLvWE9Sd3jBUWJUGk6WcVyqKvmuxNVaZL3aPimy4OkfbZUdCZvJUpuX F6+KxhC23O+sgu9Ozkzp6DTaCjP163ti90XA5Nzu9hDWbV3gjc1rseHcrFGPM9v3wChk TW1AlDu3Ptxbdgn7U9buwBrXuix/nLB2o5gAz9VDzoJwdF9bPjvcRG6S4NE+HL8edQr6 szCcc/Mt/q/6mZGESmE6jZlu7wBS+DKSea/m+qVmTvbxGELNqmAGSTLFdQKbTK7jzjwP XVVT0QVXuaIIX8mxSTsBWGlDYKabY1RuSTbz3lhiFccvQt2H9IW8x58ts/D4Kf2w8bVa ieXA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704926176; x=1705530976; h=cc:to:subject:message-id:date:mime-version:references:in-reply-to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=I8n4Pt+myEq8q8o5UJL2e7tQhXfsDz6rW314koYLS2E=; b=rIufTBThjGxRKvY+MbTU+PZw5iwo2Mv0/5iKh2js6w/14FymT4LBpzCP0pdw15T5Qn R7bwUscsJf6N534u17jzcIyIHSXOeaBETb3qR8zuJAiY0egQvbohIQn7uHae5SGLZIJc wsuEMBhTQhSaoORS29iCoCXcJsB83t7LxsdqTkuRM4a/dQwJBjitC0ZI3fDq2ymPG4zB xgPUS04d0JUzL8p89QfEI9k11yf7WI5O9ARUlOSJpFMGBGGz2oACN40osyHoGqEM3tNW ELj30a7BIv5XXgfAv2w+mZt8F5UqPz5QTNNXaWs6864k58riJ8z6O/rvaZxUy+tilIge W2sw== X-Gm-Message-State: AOJu0YyHzxNXO/aOHaWoV2Y8/MVFDeQ3B2el8ied1zmaVZEiCqMmK2lA AcoqF5ml/kVmE+jeJFxMFaieB+LI/M8+ezjfJKTUQ1PGfm1UOA== X-Google-Smtp-Source: AGHT+IG97r42yqJdwBITw/rKndXUdGMJ+UdG/r5SyjPTRfdYq9CgO/fUtF72V7q2ygFz4bWs/ncBzh2LPXWNkgdQe8o= X-Received: by 2002:a05:6402:326:b0:557:7f96:1d12 with SMTP id q6-20020a056402032600b005577f961d12mr71382edw.44.1704926176564; Wed, 10 Jan 2024 14:36:16 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 10 Jan 2024 14:36:16 -0800 From: Stefan Kangas <stefankangas@HIDDEN> In-Reply-To: <28c4b5f7-79ab-c87d-889a-96e0c7390b95@HIDDEN> (Richard Hansen's message of "Mon, 19 Dec 2022 00:03:39 -0500") References: <28c4b5f7-79ab-c87d-889a-96e0c7390b95@HIDDEN> MIME-Version: 1.0 Date: Wed, 10 Jan 2024 14:36:16 -0800 Message-ID: <CADwFkm=9_Q7L=LoprwAtMavquvshNXkQB7uAPzFFAs1Ch=0fHQ@HIDDEN> Subject: Re: bug#60187: [PATCH] whitespace: Clear bob and eob markers in `whitespace-color-off' To: Richard Hansen <rhansen@HIDDEN> Content-Type: text/plain; charset="UTF-8" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 60187 Cc: 60187 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Richard Hansen <rhansen@HIDDEN> writes: > See attached. Thanks for the patch and apologies for taking so long to reply. Does this fix any particular issue or is this just a cleanup? > From 225dc1f32c865a3b36eb9c6d3881b298c871e3a3 Mon Sep 17 00:00:00 2001 > From: Richard Hansen <rhansen@HIDDEN> > Date: Wed, 14 Dec 2022 01:57:17 -0500 > Subject: [PATCH] whitespace: Clear bob and eob markers in > `whitespace-color-off' > > * lisp/whitespace.el (whitespace-color-off): Clear markers when > turning off `whitespace-mode'. > * test/lisp/whitespace-tests.el (whitespace-tests--clear-markers): Add > a test. > --- > lisp/whitespace.el | 4 +++- > test/lisp/whitespace-tests.el | 6 ++++++ > 2 files changed, 9 insertions(+), 1 deletion(-) > > diff --git a/lisp/whitespace.el b/lisp/whitespace.el > index 558be1841a..b747293eb4 100644 > --- a/lisp/whitespace.el > +++ b/lisp/whitespace.el > @@ -2220,7 +2220,9 @@ whitespace-color-off > (remove-hook 'clone-buffer-hook #'whitespace--clone t) > (remove-hook 'clone-indirect-buffer-hook #'whitespace--clone t) > (font-lock-remove-keywords nil whitespace-font-lock-keywords) > - (font-lock-flush))) > + (font-lock-flush) > + (set-marker whitespace-bob-marker nil) > + (set-marker whitespace-eob-marker nil))) > > (defun whitespace-point--used (start end) > (let ((ostart (overlay-start whitespace-point--used))) > diff --git a/test/lisp/whitespace-tests.el b/test/lisp/whitespace-tests.el > index 7079c1ea5e..1780d6246d 100644 > --- a/test/lisp/whitespace-tests.el > +++ b/test/lisp/whitespace-tests.el > @@ -64,6 +64,12 @@ whitespace-tests--cleanup-string > (whitespace-cleanup) > (buffer-string))) > > +(ert-deftest whitespace-tests--clear-markers () > + (whitespace-tests--with-test-buffer '(face empty) > + (whitespace-mode -1) > + (should (null (marker-buffer whitespace-bob-marker))) > + (should (null (marker-buffer whitespace-eob-marker))))) > + > (ert-deftest whitespace-cleanup-eob () > (let ((whitespace-style '(empty))) > (should (equal (whitespace-tests--cleanup-string "a\n")
bug-gnu-emacs@HIDDEN:bug#60187; Package emacs.
Full text available.Received: (at submit) by debbugs.gnu.org; 19 Dec 2022 05:04:02 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Mon Dec 19 00:04:02 2022 Received: from localhost ([127.0.0.1]:37873 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1p78Jm-0005tm-01 for submit <at> debbugs.gnu.org; Mon, 19 Dec 2022 00:04:02 -0500 Received: from lists.gnu.org ([209.51.188.17]:34918) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <rhansen@HIDDEN>) id 1p78Je-0005tZ-ES for submit <at> debbugs.gnu.org; Mon, 19 Dec 2022 00:04:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <rhansen@HIDDEN>) id 1p78Jd-0000Eh-P9 for bug-gnu-emacs@HIDDEN; Mon, 19 Dec 2022 00:03:53 -0500 Received: from spork.scientician.org ([2600:3c03:e000:66::1]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <rhansen@HIDDEN>) id 1p78JV-0003cK-R9 for bug-gnu-emacs@HIDDEN; Mon, 19 Dec 2022 00:03:48 -0500 X-Submitted: to spork.scientician.org (Postfix) with ESMTPSA id 3351B4852D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-spork; t=1671426224; bh=ZwkRmwcBGVfZ3qM3tFt3avWu0R9251BA9aBxM9qVP38=; h=Date:To:From:Subject:From; b=Hd/IcHdxm7cHORXFE05emzIW8ddyij4hadaN3ZvM/e354cvWh7KFw4JebBhnN56Hg wkMJk34x++85UIckv+MG5lP2a0GLMaFj+LdOXZ9ywVcSTY22WgokJaiAQw/mqoRo+n VmHOWVUS7W8alsrbbVBkhQeBKZb+gx5vnZ3IE5Wg= X-Submitted: to mail.scientician.org (Postfix) with ESMTPSA id 30EBD2009D DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rhansen.org; s=20130902-mail; t=1671426222; bh=ZwkRmwcBGVfZ3qM3tFt3avWu0R9251BA9aBxM9qVP38=; h=Date:To:From:Subject:From; b=qCBB8fmp7CrbFUIqRItvG27rwa9Mkc7Ha9XZyOK4J60QmAza6WiGH0GrZqGnnvuI/ SQjSm/1r/U8OA1h0i1J6G0ZP7EAx4tq97zuGil/PKeotHBEf9zB1cPMg97oezAgzFI KOdBI25ndLg4cM9RN6fFEe9yrYRjzYdGMeNg7YXg= Message-ID: <28c4b5f7-79ab-c87d-889a-96e0c7390b95@HIDDEN> Date: Mon, 19 Dec 2022 00:03:39 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.1 To: bug-gnu-emacs@HIDDEN Content-Language: en-US From: Richard Hansen <rhansen@HIDDEN> Subject: [PATCH] whitespace: Clear bob and eob markers in `whitespace-color-off' Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="------------6ShxqrvrbnjgfCDi0rF0xH2m" Received-SPF: pass client-ip=2600:3c03:e000:66::1; envelope-from=rhansen@HIDDEN; helo=spork.scientician.org X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -2.3 (--) This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --------------6ShxqrvrbnjgfCDi0rF0xH2m Content-Type: multipart/mixed; boundary="------------QT9GwP7XM2kgiJLzbAqhCuVF"; protected-headers="v1" From: Richard Hansen <rhansen@HIDDEN> To: bug-gnu-emacs@HIDDEN Message-ID: <28c4b5f7-79ab-c87d-889a-96e0c7390b95@HIDDEN> Subject: [PATCH] whitespace: Clear bob and eob markers in `whitespace-color-off' --------------QT9GwP7XM2kgiJLzbAqhCuVF Content-Type: multipart/mixed; boundary="------------Q6CjlasnnH0aPJBoTIJi7vkk" --------------Q6CjlasnnH0aPJBoTIJi7vkk Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: base64 U2VlIGF0dGFjaGVkLg0K --------------Q6CjlasnnH0aPJBoTIJi7vkk Content-Type: text/x-patch; charset=UTF-8; name="0001-whitespace-Clear-bob-and-eob-markers-in-whitespace-c.patch" Content-Disposition: attachment; filename*0="0001-whitespace-Clear-bob-and-eob-markers-in-whitespace-c.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSAyMjVkYzFmMzJjODY1YTNiMzZlYjljNmQzODgxYjI5OGM4NzFlM2EzIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBSaWNoYXJkIEhhbnNlbiA8cmhhbnNlbkByaGFuc2Vu Lm9yZz4KRGF0ZTogV2VkLCAxNCBEZWMgMjAyMiAwMTo1NzoxNyAtMDUwMApTdWJqZWN0OiBb UEFUQ0hdIHdoaXRlc3BhY2U6IENsZWFyIGJvYiBhbmQgZW9iIG1hcmtlcnMgaW4KIGB3aGl0 ZXNwYWNlLWNvbG9yLW9mZicKCiogbGlzcC93aGl0ZXNwYWNlLmVsICh3aGl0ZXNwYWNlLWNv bG9yLW9mZik6IENsZWFyIG1hcmtlcnMgd2hlbgp0dXJuaW5nIG9mZiBgd2hpdGVzcGFjZS1t b2RlJy4KKiB0ZXN0L2xpc3Avd2hpdGVzcGFjZS10ZXN0cy5lbCAod2hpdGVzcGFjZS10ZXN0 cy0tY2xlYXItbWFya2Vycyk6IEFkZAphIHRlc3QuCi0tLQogbGlzcC93aGl0ZXNwYWNlLmVs ICAgICAgICAgICAgfCA0ICsrKy0KIHRlc3QvbGlzcC93aGl0ZXNwYWNlLXRlc3RzLmVsIHwg NiArKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgOSBpbnNlcnRpb25zKCspLCAxIGRlbGV0aW9u KC0pCgpkaWZmIC0tZ2l0IGEvbGlzcC93aGl0ZXNwYWNlLmVsIGIvbGlzcC93aGl0ZXNwYWNl LmVsCmluZGV4IDU1OGJlMTg0MWEuLmI3NDcyOTNlYjQgMTAwNjQ0Ci0tLSBhL2xpc3Avd2hp dGVzcGFjZS5lbAorKysgYi9saXNwL3doaXRlc3BhY2UuZWwKQEAgLTIyMjAsNyArMjIyMCw5 IEBAIHdoaXRlc3BhY2UtY29sb3Itb2ZmCiAgICAgKHJlbW92ZS1ob29rICdjbG9uZS1idWZm ZXItaG9vayAjJ3doaXRlc3BhY2UtLWNsb25lIHQpCiAgICAgKHJlbW92ZS1ob29rICdjbG9u ZS1pbmRpcmVjdC1idWZmZXItaG9vayAjJ3doaXRlc3BhY2UtLWNsb25lIHQpCiAgICAgKGZv bnQtbG9jay1yZW1vdmUta2V5d29yZHMgbmlsIHdoaXRlc3BhY2UtZm9udC1sb2NrLWtleXdv cmRzKQotICAgIChmb250LWxvY2stZmx1c2gpKSkKKyAgICAoZm9udC1sb2NrLWZsdXNoKQor ICAgIChzZXQtbWFya2VyIHdoaXRlc3BhY2UtYm9iLW1hcmtlciBuaWwpCisgICAgKHNldC1t YXJrZXIgd2hpdGVzcGFjZS1lb2ItbWFya2VyIG5pbCkpKQogCiAoZGVmdW4gd2hpdGVzcGFj ZS1wb2ludC0tdXNlZCAoc3RhcnQgZW5kKQogICAobGV0ICgob3N0YXJ0IChvdmVybGF5LXN0 YXJ0IHdoaXRlc3BhY2UtcG9pbnQtLXVzZWQpKSkKZGlmZiAtLWdpdCBhL3Rlc3QvbGlzcC93 aGl0ZXNwYWNlLXRlc3RzLmVsIGIvdGVzdC9saXNwL3doaXRlc3BhY2UtdGVzdHMuZWwKaW5k ZXggNzA3OWMxZWE1ZS4uMTc4MGQ2MjQ2ZCAxMDA2NDQKLS0tIGEvdGVzdC9saXNwL3doaXRl c3BhY2UtdGVzdHMuZWwKKysrIGIvdGVzdC9saXNwL3doaXRlc3BhY2UtdGVzdHMuZWwKQEAg LTY0LDYgKzY0LDEyIEBAIHdoaXRlc3BhY2UtdGVzdHMtLWNsZWFudXAtc3RyaW5nCiAgICAg KHdoaXRlc3BhY2UtY2xlYW51cCkKICAgICAoYnVmZmVyLXN0cmluZykpKQogCisoZXJ0LWRl ZnRlc3Qgd2hpdGVzcGFjZS10ZXN0cy0tY2xlYXItbWFya2VycyAoKQorICAod2hpdGVzcGFj ZS10ZXN0cy0td2l0aC10ZXN0LWJ1ZmZlciAnKGZhY2UgZW1wdHkpCisgICAgKHdoaXRlc3Bh Y2UtbW9kZSAtMSkKKyAgICAoc2hvdWxkIChudWxsIChtYXJrZXItYnVmZmVyIHdoaXRlc3Bh Y2UtYm9iLW1hcmtlcikpKQorICAgIChzaG91bGQgKG51bGwgKG1hcmtlci1idWZmZXIgd2hp dGVzcGFjZS1lb2ItbWFya2VyKSkpKSkKKwogKGVydC1kZWZ0ZXN0IHdoaXRlc3BhY2UtY2xl YW51cC1lb2IgKCkKICAgKGxldCAoKHdoaXRlc3BhY2Utc3R5bGUgJyhlbXB0eSkpKQogICAg IChzaG91bGQgKGVxdWFsICh3aGl0ZXNwYWNlLXRlc3RzLS1jbGVhbnVwLXN0cmluZyAiYVxu IikKLS0gCjIuMzkuMAoK --------------Q6CjlasnnH0aPJBoTIJi7vkk-- --------------QT9GwP7XM2kgiJLzbAqhCuVF-- --------------6ShxqrvrbnjgfCDi0rF0xH2m Content-Type: application/pgp-signature; name="OpenPGP_signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="OpenPGP_signature" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfoCctB7fyOzE09bW0GvrRa1X4hQFAmOf8KsACgkQ0GvrRa1X 4hRkxg/6AzYris+GEZd39fSIlk+SCR1xrMr3dDUEOagYfSzqqhH3Ldd5cRFzCRtz Zg7kU2zxlEpF04KBOttXmU1lcHcsupHwHpG35D6ukzHFyKxy4OzKBz5iavOkv8x4 LY3aix8baCr778kkW51yAE6DR2Paha2L1N+8Plhl2oBvqS20Z3JmQi7926LbvfKs J3e8ICpfzXSuef9ZoaktC4TP9q8FuAoKXAo67gUwDcTiIJchEJ+alT+YuuaX7mGQ iJARSVfXB6fgmiIRQoGwUrgLLE1jxYCG7ZaE3np9PIS1tVrfZWGOnYS6XG3r82WH 3VIUmSr1/sVDRmyODrBnE07nqT0gBfIqRugBOdjdSLxymbtLGmkuyd3sXj43/lK3 09fgnNWchPjUMnFjWBUecJEzEwqSi7fHFhTy/VWH0pR6ZyDJgB5eDBLING10OFgh Dn79Y6CLJo2ONJwaUZ0MfyTsnE2wRbGaPC3GAOwcI1JpwI09/50YlI0IasURt/or LLJwu6JIvj64+tvueCJtfq3jfkryFtW2gsSjpdSyzOvvS2WzZ2+PsRune0RukYhz AHvVSWuVI9Qkb78J33x87XYR//LEAWUjhPXR/6hVanT9irLnK0kLD1Rnf9iAmvVG USfnV3BiGyFa6MNBP78RUcZWqF9zyWyBqRI/XmBKSfXf4djYOsw= =oDD2 -----END PGP SIGNATURE----- --------------6ShxqrvrbnjgfCDi0rF0xH2m--
Richard Hansen <rhansen@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#60187; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.