GNU bug report logs - #60191
[PATCH] Fix `rcirc-buffer-process' not working on channel buffers

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60191 in the body.
You can then email your comments to 60191 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Thuna <thuna.cing <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Fix `rcirc-buffer-process' not working on channel buffers
Date: Mon, 19 Dec 2022 09:47:57 +0100

[Message part 1 (text/plain, inline)]

Currently `rcirc-buffer-process' with no BUFFER argument defaults to
current buffer's `rcirc-server-buffer' instead of the current buffer
itself which leads to `rcirc-buffer-process' not working with channel
buffers.

This patch should hopefully fix that.

[0001-Fix-rcirc-buffer-process-not-working-on-channel-buff.patch (text/x-patch, attachment)]

Message #8 received at 60191 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Thuna <thuna.cing <at> gmail.com>
Cc: 60191 <at> debbugs.gnu.org
Subject: Re: bug#60191: [PATCH] Fix `rcirc-buffer-process' not working on
 channel buffers
Date: Mon, 01 May 2023 12:05:09 +0000

Thuna <thuna.cing <at> gmail.com> writes:

> Currently `rcirc-buffer-process' with no BUFFER argument defaults to
> current buffer's `rcirc-server-buffer' instead of the current buffer
> itself which leads to `rcirc-buffer-process' not working with channel
> buffers.

I do not understand what you mean by "not working" here, the code
appears to do the same thing pre- and post-patch, in the process and the
channel buffers.

> This patch should hopefully fix that.
>
>>From d17e7cbb34cf83098561c57b383f90d6a7bde50e Mon Sep 17 00:00:00 2001
> From: Thuna <thuna.cing <at> gmail.com>
> Date: Mon, 19 Dec 2022 09:33:29 +0100
> Subject: [PATCH] Fix `rcirc-buffer-process' not working on channel buffers
>
> * lisp/net/rcirc.el (rcirc-buffer-process): Look at BUFFER's
> `rcirc-server-buffer's `rcirc-process' instead.  Signal an error if it
> has none.
> ---
>  lisp/net/rcirc.el | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/lisp/net/rcirc.el b/lisp/net/rcirc.el
> index 96109dcd5c9..7afb625407e 100644
> --- a/lisp/net/rcirc.el
> +++ b/lisp/net/rcirc.el
> @@ -1179,11 +1179,11 @@ rcirc-send-ctcp
>  (defun rcirc-buffer-process (&optional buffer)
>    "Return the process associated with channel BUFFER.
>  With no argument or nil as argument, use the current buffer."
> -  (let ((buffer (or buffer (and (buffer-live-p rcirc-server-buffer)
> -                                rcirc-server-buffer))))
> -    (if buffer
> -        (buffer-local-value 'rcirc-process buffer)
> -      rcirc-process)))
> +  (let ((buffer (or buffer (current-buffer))))
> +    (buffer-local-value
> +     'rcirc-process
> +     (or (buffer-local-value 'rcirc-server-buffer buffer)
> +         (error "Not an rcirc buffer: %S" buffer)))))
>  
>  (defun rcirc-server-name (process)
>    "Return PROCESS server name, given by the 001 response."

Message #11 received at 60191 <at> debbugs.gnu.org (full text, mbox):

From: Thuna <thuna.cing <at> gmail.com>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 60191 <at> debbugs.gnu.org
Subject: Re: bug#60191: [PATCH] Fix `rcirc-buffer-process' not working on
 channel buffers
Date: Mon, 01 May 2023 22:05:35 +0200

> I do not understand what you mean by "not working" here, the code
> appears to do the same thing pre- and post-patch, in the process and the
> channel buffers.

The problem is that when `rcirc-buffer-process' is explicitly called
with a channel buffer it returns nil, as the local variable
`rcirc-process' is set only in server buffers and the function checks
the server buffer only if the BUFFER argument is nil.

This leads to a situation where `(rcirc-buffer-process)' and
`(rcirc-buffer-process (current-buffer))' do not behave in the same way
when called from channel buffers.

Message #14 received at 60191 <at> debbugs.gnu.org (full text, mbox):

From: Philip Kaludercic <philipk <at> posteo.net>
To: Thuna <thuna.cing <at> gmail.com>
Cc: 60191 <at> debbugs.gnu.org
Subject: Re: bug#60191: [PATCH] Fix `rcirc-buffer-process' not working on
 channel buffers
Date: Mon, 01 May 2023 20:09:09 +0000

Thuna <thuna.cing <at> gmail.com> writes:

>> I do not understand what you mean by "not working" here, the code
>> appears to do the same thing pre- and post-patch, in the process and the
>> channel buffers.
>
> The problem is that when `rcirc-buffer-process' is explicitly called
> with a channel buffer it returns nil, as the local variable
> `rcirc-process' is set only in server buffers and the function checks
> the server buffer only if the BUFFER argument is nil.
>
> This leads to a situation where `(rcirc-buffer-process)' and
> `(rcirc-buffer-process (current-buffer))' do not behave in the same way
> when called from channel buffers.

OK, I get what you mean and the patch should be applied.  But IIUC you
haven't signed the FSF CA, right?  If that is so, I am afraid I am not
allowed to apply /your/ change myself...

Message #17 received at 60191 <at> debbugs.gnu.org (full text, mbox):

From: Thuna <thuna.cing <at> gmail.com>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 60191 <at> debbugs.gnu.org
Subject: Re: bug#60191: [PATCH] Fix `rcirc-buffer-process' not working on
 channel buffers
Date: Mon, 01 May 2023 23:34:01 +0200

> OK, I get what you mean and the patch should be applied.  But IIUC you
> haven't signed the FSF CA, right?  If that is so, I am afraid I am not
> allowed to apply /your/ change myself...

It will have to be on hold until the CA can be finalized, I'm afraid.
My other patches are in a similar situation.

I have applied for the CA quite a long time ago but unfortunately, my
school is not being very receptive when it comes to the copyright
disclaimer.  

I have mostly entrusted the matter with Craig Topham at
<craigt <at> fsf.org>, so you will have to contact them for any updates.

Message #22 received at 60191-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Philip Kaludercic <philipk <at> posteo.net>
Cc: 60191-done <at> debbugs.gnu.org, Thuna <thuna.cing <at> gmail.com>
Subject: Re: bug#60191: [PATCH] Fix `rcirc-buffer-process' not working on
 channel buffers
Date: Tue, 11 Feb 2025 19:09:52 -0800

Version: 31.1

Philip Kaludercic <philipk <at> posteo.net> writes:

> Thuna <thuna.cing <at> gmail.com> writes:
>
>>> I do not understand what you mean by "not working" here, the code
>>> appears to do the same thing pre- and post-patch, in the process and the
>>> channel buffers.
>>
>> The problem is that when `rcirc-buffer-process' is explicitly called
>> with a channel buffer it returns nil, as the local variable
>> `rcirc-process' is set only in server buffers and the function checks
>> the server buffer only if the BUFFER argument is nil.
>>
>> This leads to a situation where `(rcirc-buffer-process)' and
>> `(rcirc-buffer-process (current-buffer))' do not behave in the same way
>> when called from channel buffers.
>
> OK, I get what you mean and the patch should be applied.  But IIUC you
> haven't signed the FSF CA, right?  If that is so, I am afraid I am not
> allowed to apply /your/ change myself...

The copyright assignment is now done, so I went ahead and installed this
patch as commit fb90e21af1b.  I'm therefore closing this bug report.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.