GNU bug report logs - #60198
30.0.50; Eglot: Spelling error for vscode-json-languageserver

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60198 in the body.
You can then email your comments to 60198 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Benjamin Orthen <benjamin <at> orthen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; Eglot: Spelling error for vscode-json-languageserver
Date: Mon, 19 Dec 2022 11:13:32 +0100

[Message part 1 (text/plain, inline)]

In lisp/progmodes/eglot.el:192,
"vscode-json-languageserver"
(https://www.npmjs.com/package/vscode-json-languageserver) is spelled as "vscode-json-language-server",
which causes eglot to fail to find the executable.

[Message part 2 (text/html, inline)]

Message #8 received at 60198 <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <leungbk <at> posteo.net>
To: Benjamin Orthen <benjamin <at> orthen.net>
Cc: 60198 <at> debbugs.gnu.org
Subject: Re: bug#60198: 30.0.50; Eglot: Spelling error for
 vscode-json-languageserver
Date: Mon, 19 Dec 2022 12:42:54 +0000

Benjamin Orthen <benjamin <at> orthen.net> writes:

> In lisp/progmodes/eglot.el:192,
> "vscode-json-languageserver"
> (https://www.npmjs.com/package/vscode-json-languageserver) is spelled as "vscode-json-language-server",
> which causes eglot to fail to find the executable.

It's not a spelling error;
https://github.com/hrsh7th/vscode-langservers-extracted exposes an
executable with that name. If you happen to use Nix, the
nodePackages.vscode-langservers-extracted provides additional
executables for HTML, CSS, and more.

We could add vscode-json-languageserver as an additional executable to eglot-server-programs.

Message #11 received at 60198 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Benjamin Orthen <benjamin <at> orthen.net>, João Távora
 <joaotavora <at> gmail.com>
Cc: 60198 <at> debbugs.gnu.org
Subject: Re: bug#60198: 30.0.50;
 Eglot: Spelling error for vscode-json-languageserver
Date: Mon, 19 Dec 2022 14:53:25 +0200

> Date: Mon, 19 Dec 2022 11:13:32 +0100
> From: Benjamin Orthen <benjamin <at> orthen.net>
> 
> In lisp/progmodes/eglot.el:192,
> "vscode-json-languageserver"
> (https://www.npmjs.com/package/vscode-json-languageserver) is spelled as "vscode-json-language-server",
> which causes eglot to fail to find the executable.

João, it looks like all the vscode-* servers have the same problem in
the eglot DB?

Message #14 received at 60198 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Brian Leung <leungbk <at> posteo.net>
Cc: benjamin <at> orthen.net, 60198 <at> debbugs.gnu.org
Subject: Re: bug#60198: 30.0.50;
 Eglot: Spelling error for vscode-json-languageserver
Date: Mon, 19 Dec 2022 15:00:09 +0200

> Cc: 60198 <at> debbugs.gnu.org
> From: Brian Leung <leungbk <at> posteo.net>
> Date: Mon, 19 Dec 2022 12:42:54 +0000
> 
> Benjamin Orthen <benjamin <at> orthen.net> writes:
> 
> > In lisp/progmodes/eglot.el:192,
> > "vscode-json-languageserver"
> > (https://www.npmjs.com/package/vscode-json-languageserver) is spelled as "vscode-json-language-server",
> > which causes eglot to fail to find the executable.
> 
> It's not a spelling error;
> https://github.com/hrsh7th/vscode-langservers-extracted exposes an
> executable with that name. If you happen to use Nix, the
> nodePackages.vscode-langservers-extracted provides additional
> executables for HTML, CSS, and more.
> 
> We could add vscode-json-languageserver as an additional executable to eglot-server-programs.

Is the same true for the other 2 servers we have in
eglot-server-programs?

Thanks.

Message #17 received at 60198 <at> debbugs.gnu.org (full text, mbox):

From: Benjamin Orthen <benjamin <at> orthen.net>
To: Brian Leung <leungbk <at> posteo.net>
Cc: 60198 <at> debbugs.gnu.org
Subject: Re: bug#60198: 30.0.50; Eglot: Spelling error for vscode-json-languageserver
Date: Mon, 19 Dec 2022 15:17:07 +0100

[Message part 1 (text/plain, inline)]

Alright thanks, I wasn't aware of the extracted versions.

I still think vscode-json-languageserver should be included, as this is the "original" program and not everybody might know or use the extracted langservers you're quoting.

On December 19, 2022 1:42:54 PM GMT+01:00, Brian Leung <leungbk <at> posteo.net> wrote:
>Benjamin Orthen <benjamin <at> orthen.net> writes:
>
>> In lisp/progmodes/eglot.el:192,
>> "vscode-json-languageserver"
>> (https://www.npmjs.com/package/vscode-json-languageserver) is spelled as "vscode-json-language-server",
>> which causes eglot to fail to find the executable.
>
>It's not a spelling error;
>https://github.com/hrsh7th/vscode-langservers-extracted exposes an
>executable with that name. If you happen to use Nix, the
>nodePackages.vscode-langservers-extracted provides additional
>executables for HTML, CSS, and more.
>
>We could add vscode-json-languageserver as an additional executable to eglot-server-programs.
>

[Message part 2 (text/html, inline)]

Message #20 received at 60198 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Benjamin Orthen <benjamin <at> orthen.net>, 60198 <at> debbugs.gnu.org
Subject: Re: bug#60198: 30.0.50;
 Eglot: Spelling error for vscode-json-languageserver
Date: Mon, 19 Dec 2022 14:19:08 +0000

[Message part 1 (text/plain, inline)]

That might be, Eli.  When people submit changes to the Eglot
eglot-server-programs, I rarely double-check to see if they actually
work.  As Brian points out, it does seem to work in some installations
of this language server.

Just as a data point, I myself almost always start my servers with
C-u M-x eglot and then proceed to find the right server using Emacs's
completion system. Even if the invocation is complicated, it will last
me through the session and  be available in my next session with
C-u M-x eglot M-p RET (because I use savehist-mode).

João

[Message part 2 (text/html, inline)]

Message #23 received at 60198 <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <leungbk <at> posteo.net>
To: Benjamin Orthen <benjamin <at> orthen.net>
Cc: 60198 <at> debbugs.gnu.org,
 João Távora <joaotavora <at> gmail.com>
Subject: Re: bug#60198: 30.0.50; Eglot: Spelling error for
 vscode-json-languageserver
Date: Mon, 19 Dec 2022 23:04:18 +0000

[Message part 1 (text/plain, inline)]

Benjamin Orthen <benjamin <at> orthen.net> writes:

> Alright thanks, I wasn't aware of the extracted versions.
>
> I still think vscode-json-languageserver should be included, as 
> this is the "original" program and not everybody might know
> or use the extracted langservers you're quoting.

OK, see attached for a patch. I added only 
vscode-json-languageserver since I could not find anything named 
vscode-{html,css}-languageserver on NPM. CCing João.

[0001-eglot.el-Add-vscode-json-languageserver.patch (text/x-patch, attachment)]

Message #26 received at 60198 <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <leungbk <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: benjamin <at> orthen.net, 60198 <at> debbugs.gnu.org
Subject: Re: bug#60198: 30.0.50; Eglot: Spelling error for
 vscode-json-languageserver
Date: Mon, 19 Dec 2022 23:07:51 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

>> Cc: 60198 <at> debbugs.gnu.org
>> From: Brian Leung <leungbk <at> posteo.net>
>> Date: Mon, 19 Dec 2022 12:42:54 +0000
>> 
>> Benjamin Orthen <benjamin <at> orthen.net> writes:
>> 
>> > In lisp/progmodes/eglot.el:192,
>> > "vscode-json-languageserver"
>> > (https://www.npmjs.com/package/vscode-json-languageserver) is 
>> > spelled as "vscode-json-language-server",
>> > which causes eglot to fail to find the executable.
>> 
>> It's not a spelling error;
>> https://github.com/hrsh7th/vscode-langservers-extracted exposes 
>> an
>> executable with that name. If you happen to use Nix, the
>> nodePackages.vscode-langservers-extracted provides additional
>> executables for HTML, CSS, and more.
>> 
>> We could add vscode-json-languageserver as an additional 
>> executable to eglot-server-programs.
>
> Is the same true for the other 2 servers we have in
> eglot-server-programs?
>
> Thanks.

Yes, I've used those other two servers before via Eglot with no 
further modifications.

Message #29 received at 60198 <at> debbugs.gnu.org (full text, mbox):

From: João Távora <joaotavora <at> gmail.com>
To: Brian Leung <leungbk <at> posteo.net>
Cc: Benjamin Orthen <benjamin <at> orthen.net>, 60198 <at> debbugs.gnu.org
Subject: Re: bug#60198: 30.0.50;
 Eglot: Spelling error for vscode-json-languageserver
Date: Tue, 20 Dec 2022 01:12:27 +0000

[Message part 1 (text/plain, inline)]

OK with me.  Are we sure that we can't just have one of them?  Maybe
those other distributions which create the "language-server" variety
_also_ create the "languageserver" version? Anyway, again, looks
ok to me, but let's try not to get too slippery on this slope.
Sometimes a misspelling is just a misspelling and we shouldn't
help perpetuate it.

João

[Message part 2 (text/html, inline)]

Message #32 received at 60198 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Brian Leung <leungbk <at> posteo.net>
Cc: benjamin <at> orthen.net, 60198 <at> debbugs.gnu.org
Subject: Re: bug#60198: 30.0.50; Eglot: Spelling error for
 vscode-json-languageserver
Date: Tue, 20 Dec 2022 05:36:17 +0200

> From: Brian Leung <leungbk <at> posteo.net>
> Cc: benjamin <at> orthen.net, 60198 <at> debbugs.gnu.org
> Date: Mon, 19 Dec 2022 23:07:51 +0000
> 
> 
> Eli Zaretskii <eliz <at> gnu.org> writes:
> 
> >> Cc: 60198 <at> debbugs.gnu.org
> >> From: Brian Leung <leungbk <at> posteo.net>
> >> Date: Mon, 19 Dec 2022 12:42:54 +0000
> >> 
> >> Benjamin Orthen <benjamin <at> orthen.net> writes:
> >> 
> >> > In lisp/progmodes/eglot.el:192,
> >> > "vscode-json-languageserver"
> >> > (https://www.npmjs.com/package/vscode-json-languageserver) is 
> >> > spelled as "vscode-json-language-server",
> >> > which causes eglot to fail to find the executable.
> >> 
> >> It's not a spelling error;
> >> https://github.com/hrsh7th/vscode-langservers-extracted exposes 
> >> an
> >> executable with that name. If you happen to use Nix, the
> >> nodePackages.vscode-langservers-extracted provides additional
> >> executables for HTML, CSS, and more.
> >> 
> >> We could add vscode-json-languageserver as an additional 
> >> executable to eglot-server-programs.
> >
> > Is the same true for the other 2 servers we have in
> > eglot-server-programs?
> >
> > Thanks.
> 
> Yes, I've used those other two servers before via Eglot with no 
> further modifications.

I'm not sure I understand the answer.  I was asking whether the other
two also have two varieties.  If they do, I think we want to have both
in the DB.

Message #37 received at 60198 <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <leungbk <at> posteo.net>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: benjamin <at> orthen.net, 60198 <at> debbugs.gnu.org
Subject: Re: bug#60198: 30.0.50; Eglot: Spelling error for
 vscode-json-languageserver
Date: Tue, 20 Dec 2022 10:21:12 +0000

Eli Zaretskii <eliz <at> gnu.org> writes:

> I'm not sure I understand the answer.  I was asking whether the 
> other
> two also have two varieties.  If they do, I think we want to 
> have both
> in the DB.

I don't think the others have vscode-{html,css}languageserver 
variants:

https://www.npmjs.com/search?q=vscode%20languageserver

You will find on that page the NPM packages 
vscode-{css,html}-languageserver-bin, but those are already 
accounted for in Eglot, via the executables named 
{css,html}-languageserver.

Message #40 received at 60198 <at> debbugs.gnu.org (full text, mbox):

From: Brian Leung <leungbk <at> posteo.net>
To: João Távora <joaotavora <at> gmail.com>
Cc: Benjamin Orthen <benjamin <at> orthen.net>, 60198 <at> debbugs.gnu.org
Subject: Re: bug#60198: 30.0.50; Eglot: Spelling error for
 vscode-json-languageserver
Date: Tue, 20 Dec 2022 10:25:14 +0000

João Távora <joaotavora <at> gmail.com> writes:

> OK with me.  Are we sure that we can't just have one of them? 
> Maybe
> those other distributions which create the "language-server" 
> variety 
> _also_ create the "languageserver" version? Anyway, again, looks
> ok to me, but let's try not to get too slippery on this slope.
> Sometimes a misspelling is just a misspelling and we shouldn't
> help perpetuate it.
>
> João

See 
https://github.com/nixos/nixpkgs/blob/6844c91781fdad8ad523b77ec9d1f35ff407a8e6/pkgs/development/node-packages/node-packages.json#L383-L387.

It appears that there are no executables named 
vscode-{css,html}-languageserver, so the only way of accessing 
those corresponding executables (at least in Nix) is via 
nodePackages.vscode-langservers-extracted, which provides 
vscode-{css,html,json}-language-server. Meanwhile, 
vscode-{css,html}-languageserver-bin are already accounted for in 
eglot-server-programs via the executables 
{css,html}-languageserver.

So I think we should keep support for the "language-server" 
variants as well.

Message #43 received at 60198 <at> debbugs.gnu.org (full text, mbox):

From: Eli Zaretskii <eliz <at> gnu.org>
To: Brian Leung <leungbk <at> posteo.net>
Cc: benjamin <at> orthen.net, 60198 <at> debbugs.gnu.org, joaotavora <at> gmail.com
Subject: Re: bug#60198: 30.0.50;
 Eglot: Spelling error for vscode-json-languageserver
Date: Tue, 20 Dec 2022 16:32:39 +0200

> Cc: Benjamin Orthen <benjamin <at> orthen.net>, 60198 <at> debbugs.gnu.org
> From: Brian Leung <leungbk <at> posteo.net>
> Date: Tue, 20 Dec 2022 10:25:14 +0000
> 
> 
> João Távora <joaotavora <at> gmail.com> writes:
> 
> > OK with me.  Are we sure that we can't just have one of them? 
> > Maybe
> > those other distributions which create the "language-server" 
> > variety 
> > _also_ create the "languageserver" version? Anyway, again, looks
> > ok to me, but let's try not to get too slippery on this slope.
> > Sometimes a misspelling is just a misspelling and we shouldn't
> > help perpetuate it.
> >
> > João
> 
> See 
> https://github.com/nixos/nixpkgs/blob/6844c91781fdad8ad523b77ec9d1f35ff407a8e6/pkgs/development/node-packages/node-packages.json#L383-L387.
> 
> It appears that there are no executables named 
> vscode-{css,html}-languageserver, so the only way of accessing 
> those corresponding executables (at least in Nix) is via 
> nodePackages.vscode-langservers-extracted, which provides 
> vscode-{css,html,json}-language-server. Meanwhile, 
> vscode-{css,html}-languageserver-bin are already accounted for in 
> eglot-server-programs via the executables 
> {css,html}-languageserver.
> 
> So I think we should keep support for the "language-server" 
> variants as well.

Thanks, so I've now installed your patch on the emacs-29 branch, and
I'm closing this bug.

Message #48 received at 60198-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: Brian Leung <leungbk <at> posteo.net>, benjamin <at> orthen.net,
 60198-done <at> debbugs.gnu.org, joaotavora <at> gmail.com
Subject: Re: bug#60198: 30.0.50;
 Eglot: Spelling error for vscode-json-languageserver
Date: Tue, 5 Sep 2023 16:51:03 -0700

Eli Zaretskii <eliz <at> gnu.org> writes:

> Thanks, so I've now installed your patch on the emacs-29 branch, and
> I'm closing this bug.

This was accidentally left open, so I'm closing it now.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.