GNU logs - #60251, boring messages

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#60251: 29.0.60; Consider the language at point for tree sitter treesit-inspect-node-at-point
Resent-From: Wilhelm H Kirschbaum <wilhelm@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Thu, 22 Dec 2022 08:57:02 +0000
Resent-Message-ID: <handler.60251.B.167169940117716 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: 60251 <at> debbugs.gnu.org
From: Wilhelm H Kirschbaum <wilhelm@HIDDEN>
User-agent: mu4e 1.9.3; emacs 29.0.60
Date: Thu, 22 Dec 2022 10:42:03 +0200
Message-ID: <87lemzes0b.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; format=flowed
Received-SPF: pass client-ip=2a00:1450:4864:20::336;
 envelope-from=wilhelm@HIDDEN; helo=mail-wm1-x336.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)


The following change will make it possible to inspect a node when 
using
an embedded language, otherwise it will assume the first specified
language without allowing specifying the language. This assumes 
that
treesit-language-at-point-function has been correctly set. 

diff --git a/lisp/treesit.el b/lisp/treesit.el
index 6407669118..74dfd26776 100644
--- a/lisp/treesit.el
+++ b/lisp/treesit.el
@@ -1931,7 +1931,7 @@ treesit-inspect-node-at-point
   (interactive "p")
   ;; NODE-LIST contains all the node that starts at point.
   (let* ((node-list
-          (cl-loop for node = (treesit-node-at (point))
+          (cl-loop for node = (treesit-node-at (point) 
(treesit-language-at (point)))
                    then (treesit-node-parent node)
                    while node
                    if (eq (treesit-node-start node)


Another option might be to allow parser-or-lang as an argument, 
but
thinking that as an interactive function for debugging the above 
might
be more useful, but either way it does not seem possible to
inspect-node-at-point for multiple language configuration.

Regards,
Wilhelm

Message sent:

Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-Mailer: MIME-tools 5.505 (Entity 5.505)
Content-Type: text/plain; charset=utf-8
X-Loop: help-debbugs@HIDDEN
From: help-debbugs@HIDDEN (GNU bug Tracking System)
To: Wilhelm H Kirschbaum <wilhelm@HIDDEN>
Subject: bug#60251: Acknowledgement (29.0.60; Consider the language at
 point for tree sitter treesit-inspect-node-at-point)
Message-ID: <handler.60251.B.167169940117716.ack <at> debbugs.gnu.org>
References: <87lemzes0b.fsf@HIDDEN>
X-Gnu-PR-Message: ack 60251
X-Gnu-PR-Package: emacs
Reply-To: 60251 <at> debbugs.gnu.org
Date: Thu, 22 Dec 2022 08:57:02 +0000

Thank you for filing a new bug report with debbugs.gnu.org.

This is an automatically generated reply to let you know your message
has been received.

Your message is being forwarded to the package maintainers and other
interested parties for their attention; they will reply in due course.

Your message has been sent to the package maintainer(s):
 bug-gnu-emacs@HIDDEN

If you wish to submit further information on this problem, please
send it to 60251 <at> debbugs.gnu.org.

Please do not send mail to help-debbugs@HIDDEN unless you wish
to report a problem with the Bug-tracking system.

--=20
60251: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D60251
GNU Bug Tracking System
Contact help-debbugs@HIDDEN with problems

Message sent to bug-gnu-emacs@HIDDEN:

Subject: bug#60251: 29.0.60; Consider the language at point for tree sitter treesit-inspect-node-at-point
Resent-From: Stefan Kangas <stefankangas@HIDDEN>
Original-Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
Resent-CC: bug-gnu-emacs@HIDDEN
Resent-Date: Tue, 05 Sep 2023 23:33:01 +0000
Resent-Message-ID: <handler.60251.B60251.16939567418525 <at> debbugs.gnu.org>
Resent-Sender: help-debbugs@HIDDEN
To: Wilhelm H Kirschbaum <wilhelm@HIDDEN>
Cc: Yuan Fu <casouri@HIDDEN>, 60251 <at> debbugs.gnu.org
From: Stefan Kangas <stefankangas@HIDDEN>
In-Reply-To: <87lemzes0b.fsf@HIDDEN> (Wilhelm H. Kirschbaum's message of
 "Thu, 22 Dec 2022 10:42:03 +0200")
References: <87lemzes0b.fsf@HIDDEN>
MIME-Version: 1.0
Date: Tue, 5 Sep 2023 16:32:12 -0700
Message-ID: <CADwFkmndn+8qA9z=q-fNRJ7wxdP3pB90iRJWhoZJZnu37YQh2A@HIDDEN>
Content-Type: text/plain; charset="UTF-8"
Precedence: list
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>

Wilhelm H Kirschbaum <wilhelm@HIDDEN> writes:

> The following change will make it possible to inspect a node when using
> an embedded language, otherwise it will assume the first specified
> language without allowing specifying the language. This assumes that
> treesit-language-at-point-function has been correctly set. diff --git

Yuan, do you have any comments on the below patch?  Thanks in advance.

> a/lisp/treesit.el b/lisp/treesit.el
> index 6407669118..74dfd26776 100644
> --- a/lisp/treesit.el
> +++ b/lisp/treesit.el
> @@ -1931,7 +1931,7 @@ treesit-inspect-node-at-point
>   (interactive "p")
>   ;; NODE-LIST contains all the node that starts at point.
>   (let* ((node-list
> -          (cl-loop for node = (treesit-node-at (point))
> +          (cl-loop for node = (treesit-node-at (point) (treesit-language-at
> (point)))
>                    then (treesit-node-parent node)
>                    while node
>                    if (eq (treesit-node-start node)
>
>
> Another option might be to allow parser-or-lang as an argument, but
> thinking that as an interactive function for debugging the above might
> be more useful, but either way it does not seem possible to
> inspect-node-at-point for multiple language configuration.
>
> Regards,
> Wilhelm

Last modified: Tue, 5 Sep 2023 23:45:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.