GNU bug report logs - #60288
[RESEND #2] [PATCH v1 0/2] Start adding ZIM file(s)

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN>; Keywords: patch; dated Fri, 23 Dec 2022 22:09:01 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 60288 <at> debbugs.gnu.org:


Received: (at 60288) by debbugs.gnu.org; 28 Dec 2022 18:14:30 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 28 13:14:30 2022
Received: from localhost ([127.0.0.1]:58618 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pAawg-0004pX-38
	for submit <at> debbugs.gnu.org; Wed, 28 Dec 2022 13:14:30 -0500
Received: from mira.cbaines.net ([212.71.252.8]:42072)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1pAawe-0004pO-Ab
 for 60288 <at> debbugs.gnu.org; Wed, 28 Dec 2022 13:14:28 -0500
Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:3a91:a0a4:ecee:f157])
 by mira.cbaines.net (Postfix) with ESMTPSA id 447AB27BBE9;
 Wed, 28 Dec 2022 18:14:27 +0000 (GMT)
Received: from felis (localhost [127.0.0.1])
 by localhost (OpenSMTPD) with ESMTP id 3394dc86;
 Wed, 28 Dec 2022 18:14:26 +0000 (UTC)
References: <20221220052349.4965-1-GNUtoo@HIDDEN>
User-agent: mu4e 1.8.11; emacs 28.2
From: Christopher Baines <mail@HIDDEN>
To: Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN>
Subject: Re: [bug#60288] [RESEND #2] [PATCH v1 0/2] Start adding ZIM file(s)
Date: Wed, 28 Dec 2022 18:10:54 +0000
In-reply-to: <20221220052349.4965-1-GNUtoo@HIDDEN>
Message-ID: <87bknn2y67.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 60288
Cc: 60288 <at> debbugs.gnu.org, guix-patches@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN> writes:

> Here are two small patches.
>
> The first one add #:substitutable? to the copy-build system.
>
> I don't know how to check if it works as intended though. It's
> similar to the commit d0050ea8ad1c32d94cf5ba6725a0fc961bb23f38
> ("build-system/go: Add #:substitutable? argument.") so normally
> it shouldn't be an issue, but if someone can double check it it
> would be best as it would avoid keeping around substitutes of
> very big sizes.
>
> The second patch adds a ZIM file. I'll most likely send more
> patches to add additional ZIM files packages (about 10) later
> on. I prefer doing it this way as it avoids having to deal with
> potential rebases breaking if there is something wrong with my
> second patch.
>
> Denis 'GNUtoo' Carikli (2):
>   build-system/copy: Add #:substitutable? argument.
>   gnu: Add wikipedia_en_all_maxi

I haven't looked at this in detail, but one comment on the QA
failures. Building the package for this large file involves copying it
from the store, to another place in the store. This requires 2x the
space which this large file takes up, which is a pretty wasteful
approach.

This is the reason behind the build failures I've seen, the build
machines run out of space when attempting the file copy. Maybe an
alternative if you want to have a package would be to symlink to the
source. That way, there's only a large file and a symlink in the store,
rather than two copies of the same large file.

Chris

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmOsh4BfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9Xe3HA//ZH8Wp4Sg/muK1kak62JcRLbFNFDGpCMe
yoOuTBlnySZkG6/g5AWcu/m3TXwwo3MePO2WZ0bqhCYLLo+fuzYn7vaKfSQTVbbe
eRz+n/8PRgfHnBYeT9EvDLndELGkhzAz4FDhRyAsfqUoiHil+Fg6GWRs6pvAEuav
9GwpYhMtnxzzn/l3dLi4UpBIOdUl8jsfnTMQiPmzYPnXFhLATi3oQHNwSmOR8UiJ
EXGiuhuFjVcd5y0hdR46CDw/KjeSrjdOJEJzAjlzSOxuto7TgD1jCLdPqcj5oLwT
cxxbsHPK4Htce3FuLPKxmM2S6E87ga7ku66TcMHpU+H8Bi7XU3meJsAnAN//3BqD
PfJTc8On46sQgaoW5yctwJK/pbURUGYufd/OEKlwA7yRK9/CUikU1IqEk9fCiNZV
KYjeo1m8qEQxB9Hhjfd/NzWVMlLzUOzWqf07sVn0Q69m8PgOcXCWj8uviFdOZsg9
QotG2KVyhLO04MX4Ccykf/BiTj2+6snCbvs2NcMMmd72DmBPD+1pq7rHDywm4X1d
O00niQ/KzqP9a5DEd8cJtAohxvmlkXzgEYLaB0bSC5/GJl2fSlthCDPGx6bcepP4
9HjmXDhRr4UTshFDJCuuw9LgmuJoyrA0s5eQlCO3rk8jZYJs23ECW1U4SGT0t7nf
YVfys+yvSOs=
=CtrP
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#60288; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 28 Dec 2022 18:14:35 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Dec 28 13:14:35 2022
Received: from localhost ([127.0.0.1]:58621 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1pAawl-0004pq-D0
	for submit <at> debbugs.gnu.org; Wed, 28 Dec 2022 13:14:35 -0500
Received: from lists.gnu.org ([209.51.188.17]:58748)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <mail@HIDDEN>) id 1pAawi-0004pg-3s
 for submit <at> debbugs.gnu.org; Wed, 28 Dec 2022 13:14:32 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <mail@HIDDEN>) id 1pAawh-0000Y3-Tq
 for guix-patches@HIDDEN; Wed, 28 Dec 2022 13:14:31 -0500
Received: from mira.cbaines.net ([2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27])
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <mail@HIDDEN>) id 1pAawg-0002B1-Bc
 for guix-patches@HIDDEN; Wed, 28 Dec 2022 13:14:31 -0500
Received: from localhost (unknown [IPv6:2a02:8010:68c1:0:3a91:a0a4:ecee:f157])
 by mira.cbaines.net (Postfix) with ESMTPSA id 447AB27BBE9;
 Wed, 28 Dec 2022 18:14:27 +0000 (GMT)
Received: from felis (localhost [127.0.0.1])
 by localhost (OpenSMTPD) with ESMTP id 3394dc86;
 Wed, 28 Dec 2022 18:14:26 +0000 (UTC)
References: <20221220052349.4965-1-GNUtoo@HIDDEN>
User-agent: mu4e 1.8.11; emacs 28.2
From: Christopher Baines <mail@HIDDEN>
To: Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN>
Subject: Re: [bug#60288] [RESEND #2] [PATCH v1 0/2] Start adding ZIM file(s)
Date: Wed, 28 Dec 2022 18:10:54 +0000
In-reply-to: <20221220052349.4965-1-GNUtoo@HIDDEN>
Message-ID: <87bknn2y67.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="=-=-=";
 micalg=pgp-sha512; protocol="application/pgp-signature"
Received-SPF: pass client-ip=2a01:7e00:e000:2f8:fd4d:b5c7:13fb:3d27;
 envelope-from=mail@HIDDEN; helo=mira.cbaines.net
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
Cc: 60288 <at> debbugs.gnu.org, guix-patches@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

--=-=-=
Content-Type: text/plain
Content-Transfer-Encoding: quoted-printable


Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN> writes:

> Here are two small patches.
>
> The first one add #:substitutable? to the copy-build system.
>
> I don't know how to check if it works as intended though. It's
> similar to the commit d0050ea8ad1c32d94cf5ba6725a0fc961bb23f38
> ("build-system/go: Add #:substitutable? argument.") so normally
> it shouldn't be an issue, but if someone can double check it it
> would be best as it would avoid keeping around substitutes of
> very big sizes.
>
> The second patch adds a ZIM file. I'll most likely send more
> patches to add additional ZIM files packages (about 10) later
> on. I prefer doing it this way as it avoids having to deal with
> potential rebases breaking if there is something wrong with my
> second patch.
>
> Denis 'GNUtoo' Carikli (2):
>   build-system/copy: Add #:substitutable? argument.
>   gnu: Add wikipedia_en_all_maxi

I haven't looked at this in detail, but one comment on the QA
failures. Building the package for this large file involves copying it
from the store, to another place in the store. This requires 2x the
space which this large file takes up, which is a pretty wasteful
approach.

This is the reason behind the build failures I've seen, the build
machines run out of space when attempting the file copy. Maybe an
alternative if you want to have a package would be to symlink to the
source. That way, there's only a large file and a symlink in the store,
rather than two copies of the same large file.

Chris

--=-=-=
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAmOsh4BfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF
ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh
aW5lcy5uZXQACgkQXiijOwuE9Xe3HA//ZH8Wp4Sg/muK1kak62JcRLbFNFDGpCMe
yoOuTBlnySZkG6/g5AWcu/m3TXwwo3MePO2WZ0bqhCYLLo+fuzYn7vaKfSQTVbbe
eRz+n/8PRgfHnBYeT9EvDLndELGkhzAz4FDhRyAsfqUoiHil+Fg6GWRs6pvAEuav
9GwpYhMtnxzzn/l3dLi4UpBIOdUl8jsfnTMQiPmzYPnXFhLATi3oQHNwSmOR8UiJ
EXGiuhuFjVcd5y0hdR46CDw/KjeSrjdOJEJzAjlzSOxuto7TgD1jCLdPqcj5oLwT
cxxbsHPK4Htce3FuLPKxmM2S6E87ga7ku66TcMHpU+H8Bi7XU3meJsAnAN//3BqD
PfJTc8On46sQgaoW5yctwJK/pbURUGYufd/OEKlwA7yRK9/CUikU1IqEk9fCiNZV
KYjeo1m8qEQxB9Hhjfd/NzWVMlLzUOzWqf07sVn0Q69m8PgOcXCWj8uviFdOZsg9
QotG2KVyhLO04MX4Ccykf/BiTj2+6snCbvs2NcMMmd72DmBPD+1pq7rHDywm4X1d
O00niQ/KzqP9a5DEd8cJtAohxvmlkXzgEYLaB0bSC5/GJl2fSlthCDPGx6bcepP4
9HjmXDhRr4UTshFDJCuuw9LgmuJoyrA0s5eQlCO3rk8jZYJs23ECW1U4SGT0t7nf
YVfys+yvSOs=
=CtrP
-----END PGP SIGNATURE-----
--=-=-=--




Information forwarded to guix-patches@HIDDEN:
bug#60288; Package guix-patches. Full text available.

Message received at 60288 <at> debbugs.gnu.org:


Received: (at 60288) by debbugs.gnu.org; 23 Dec 2022 22:20:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 23 17:20:55 2022
Received: from localhost ([127.0.0.1]:39144 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1p8qPP-0002fR-2X
	for submit <at> debbugs.gnu.org; Fri, 23 Dec 2022 17:20:55 -0500
Received: from cyberdimension.org ([80.67.179.20]:45664
 helo=gnutoo.cyberdimension.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <GNUtoo@HIDDEN>) id 1p8qPK-0002f9-Fi
 for 60288 <at> debbugs.gnu.org; Fri, 23 Dec 2022 17:20:51 -0500
Received: from gnutoo.cyberdimension.org (localhost [127.0.0.1])
 by cyberdimension.org (OpenSMTPD) with ESMTP id 5569228d;
 Fri, 23 Dec 2022 22:16:32 +0000 (UTC)
Received: from localhost.localdomain (localhost [::1])
 by gnutoo.cyberdimension.org (OpenSMTPD) with ESMTP id b8bd9555;
 Fri, 23 Dec 2022 22:16:32 +0000 (UTC)
From: Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN>
To: 60288 <at> debbugs.gnu.org
Subject: [PATCH v1 2/2] gnu: Add wikipedia_en_all_maxi
Date: Fri, 23 Dec 2022 23:20:24 +0100
Message-Id: <20221223222024.13805-2-GNUtoo@HIDDEN>
X-Mailer: git-send-email 2.38.1
In-Reply-To: <20221223222024.13805-1-GNUtoo@HIDDEN>
References: <20221223222024.13805-1-GNUtoo@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 60288
Cc: Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* gnu/packages/zim-files.scm (wikipedia_en_all_maxi): New variable.
---
 gnu/local.mk               |  1 +
 gnu/packages/zim-files.scm | 86 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 87 insertions(+)
 create mode 100644 gnu/packages/zim-files.scm

diff --git a/gnu/local.mk b/gnu/local.mk
index 5b8944f568..8957554fc2 100644
--- a/gnu/local.mk
+++ b/gnu/local.mk
@@ -643,6 +643,7 @@ GNU_SYSTEM_MODULES =				\
   %D%/packages/xfce.scm				\
   %D%/packages/zig.scm				\
   %D%/packages/zile.scm				\
+  %D%/packages/zim-files.scm			\
   %D%/packages/zwave.scm			\
 						\
   %D%/services.scm				\
diff --git a/gnu/packages/zim-files.scm b/gnu/packages/zim-files.scm
new file mode 100644
index 0000000000..49b7accb52
--- /dev/null
+++ b/gnu/packages/zim-files.scm
@@ -0,0 +1,86 @@
+;;; GNU Guix --- Functional package management for GNU
+;;; Copyright © 2022 Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN>
+;;;
+;;; This file is part of GNU Guix.
+;;;
+;;; GNU Guix is free software; you can redistribute it and/or modify it
+;;; under the terms of the GNU General Public License as published by
+;;; the Free Software Foundation; either version 3 of the License, or (at
+;;; your option) any later version.
+;;;
+;;; GNU Guix is distributed in the hope that it will be useful, but
+;;; WITHOUT ANY WARRANTY; without even the implied warranty of
+;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+;;; GNU General Public License for more details.
+;;;
+;;; You should have received a copy of the GNU General Public License
+;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
+
+(define-module (gnu packages zim-files)
+  #:use-module (gnu packages)
+  #:use-module (guix build-system copy)
+  #:use-module (guix download)
+  #:use-module (guix gexp)
+  #:use-module (guix utils)
+  #:use-module ((guix licenses) #:prefix license:)
+  #:use-module (guix packages))
+
+;;; Commentary:
+;;;
+;;; Many Guix contributors have a tendency to update packages in this
+;;; way: they only update the package revision and then launch a build
+;;; that fails just to make Guix tell them the right base32 hash. They
+;;; then update the base32 hash and launch the build again.
+;;;
+;;; However some ZIM files are quite big. At the time of writing,
+;;; wikipedia_en_all_maxi_2022-05.zim is about 89 GiB.
+;;;
+;;; So this approach will be time consuming as the second time Guix
+;;; will restart downloading the same file from scratch.
+;;;
+;;; The solution to this issue is to download the sha256sums (for that
+;;; simply append .sha256 to the URL of the ZIM file). It will give a
+;;; file like that:
+;;; f12163513307893c87fd75009b1d61677bae675627eaadf4cb0fa63953eea021  wikipedia_en_all_maxi_2022-05.zim
+;;;
+;;; You can then use this hash to compute the base32 with nix-hash:
+;;; $ nix-hash --type sha256 --to-base32 \
+;;; f12163513307893c87fd75009b1d61677bae675627eaadf4cb0fa63953eea021
+;;; 08d0xr9kk9hgrgsavsi7arkswyv7c4frn03mzn3kr2876d8n68gi
+
+(define-public wikipedia-en-all-maxi
+  (package
+    (name "wikipedia-en-all-maxi")
+    (version "2022-05")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append
+                    "https://mirror.download.kiwix.org/zim/wikipedia/"
+                    (string-replace-substring name "-" "_")
+                    "_" version ".zim"))
+              (sha256
+               (base32
+                "08d0xr9kk9hgrgsavsi7arkswyv7c4frn03mzn3kr2876d8n68gi"))))
+    (build-system copy-build-system)
+    (arguments
+     (list
+      ;; We are not (yet) generating the zim file, so it doesn't make sense to
+      ;; build substitutes.
+      #:substitutable? #f
+      ;; If we use kiwix-serve, the path of the ZIM file needs to be passed to
+      ;; it. And if the filename has a version in it, we'd need to update the
+      ;; path manually each time the package is updated. We also need to
+      ;; change the filename to match the package name.
+      #:install-plan #~'((#$(string-append
+                             (string-replace-substring name "-" "_")
+                             "_" version ".zim")
+                          #$(string-append "share/" name ".zim")))))
+    (synopsis
+     "Complete English Wikipedia packed in a ZIM file, for offline usage with
+Kiwix")
+    (description
+     "Wikipedia is a free Encyclopedia.  This is the English version.  It
+contains all the articles, and all the medias (images, etc) present in
+the articles in a scaled down resolution.")
+    (home-page "https://en.wikipedia.org/wiki/Main_Page")
+    (license license:cc-by-sa3.0)))
-- 
2.38.1





Information forwarded to guix-patches@HIDDEN:
bug#60288; Package guix-patches. Full text available.

Message received at 60288 <at> debbugs.gnu.org:


Received: (at 60288) by debbugs.gnu.org; 23 Dec 2022 22:20:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 23 17:20:51 2022
Received: from localhost ([127.0.0.1]:39141 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1p8qPK-0002fF-R0
	for submit <at> debbugs.gnu.org; Fri, 23 Dec 2022 17:20:51 -0500
Received: from cyberdimension.org ([80.67.179.20]:45664
 helo=gnutoo.cyberdimension.org)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <GNUtoo@HIDDEN>) id 1p8qPJ-0002f9-Mo
 for 60288 <at> debbugs.gnu.org; Fri, 23 Dec 2022 17:20:50 -0500
Received: from gnutoo.cyberdimension.org (localhost [127.0.0.1])
 by cyberdimension.org (OpenSMTPD) with ESMTP id d94ef718;
 Fri, 23 Dec 2022 22:16:32 +0000 (UTC)
Received: from localhost.localdomain (localhost [::1])
 by gnutoo.cyberdimension.org (OpenSMTPD) with ESMTP id 47a51e70;
 Fri, 23 Dec 2022 22:16:32 +0000 (UTC)
From: Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN>
To: 60288 <at> debbugs.gnu.org
Subject: [PATCH v1 1/2] build-system/copy: Add #:substitutable? argument.
Date: Fri, 23 Dec 2022 23:20:23 +0100
Message-Id: <20221223222024.13805-1-GNUtoo@HIDDEN>
X-Mailer: git-send-email 2.38.1
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 60288
Cc: Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)

* guix/build-system/copy.scm (copy-build): Add 'substitutable?'
  argument.
---
 guix/build-system/copy.scm | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/guix/build-system/copy.scm b/guix/build-system/copy.scm
index 4894ba46fb..bb4d2daaa8 100644
--- a/guix/build-system/copy.scm
+++ b/guix/build-system/copy.scm
@@ -96,7 +96,8 @@ (define* (copy-build name inputs
                      (target #f)
                      (imported-modules %copy-build-system-modules)
                      (modules '((guix build copy-build-system)
-                                (guix build utils))))
+                                (guix build utils)))
+                     (substitutable? #t))
   "Build SOURCE using INSTALL-PLAN, and with INPUTS."
   (define builder
     (with-imported-modules imported-modules
@@ -129,6 +130,7 @@ (define builder
     (gexp->derivation name builder
                       #:system system
                       #:target #f
+                      #:substitutable? substitutable?
                       #:guile-for-build guile)))
 
 (define copy-build-system
-- 
2.38.1





Information forwarded to guix-patches@HIDDEN:
bug#60288; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 23 Dec 2022 22:08:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Dec 23 17:08:02 2022
Received: from localhost ([127.0.0.1]:39076 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1p8qCw-0002Xm-29
	for submit <at> debbugs.gnu.org; Fri, 23 Dec 2022 17:08:02 -0500
Received: from lists.gnu.org ([209.51.188.17]:38228)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <GNUtoo@HIDDEN>) id 1p8qCu-0002Xc-3k
 for submit <at> debbugs.gnu.org; Fri, 23 Dec 2022 17:08:00 -0500
Received: from eggs.gnu.org ([2001:470:142:3::10])
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <GNUtoo@HIDDEN>)
 id 1p8qCt-0003AW-U4
 for guix-patches@HIDDEN; Fri, 23 Dec 2022 17:07:59 -0500
Received: from cyberdimension.org ([2001:910:1314:ffff::1]
 helo=gnutoo.cyberdimension.org)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256)
 (Exim 4.90_1) (envelope-from <GNUtoo@HIDDEN>)
 id 1p8qCs-0002S5-C6
 for guix-patches@HIDDEN; Fri, 23 Dec 2022 17:07:59 -0500
Received: from gnutoo.cyberdimension.org (localhost [127.0.0.1])
 by cyberdimension.org (OpenSMTPD) with ESMTP id 5f323909;
 Fri, 23 Dec 2022 22:03:41 +0000 (UTC)
Received: from primary_laptop (localhost [::1])
 by gnutoo.cyberdimension.org (OpenSMTPD) with ESMTP id ce71ce7d;
 Fri, 23 Dec 2022 22:03:41 +0000 (UTC)
Date: Fri, 23 Dec 2022 23:07:31 +0100
From: Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN>
To: guix-patches@HIDDEN
Subject: [RESEND #2] [PATCH v1 0/2] Start adding ZIM file(s)
Message-ID: <20221220052349.4965-1-GNUtoo@HIDDEN>
X-Mailer: Claws Mail 4.1.1 (GTK 3.24.30; i686-pc-linux-gnu)
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/w_TNHNTWrz/qmLV53Fhwj4H";
 protocol="application/pgp-signature"; micalg=pgp-sha256
Received-SPF: pass client-ip=2001:910:1314:ffff::1;
 envelope-from=GNUtoo@HIDDEN; helo=gnutoo.cyberdimension.org
X-Spam_score_int: -18
X-Spam_score: -1.9
X-Spam_bar: -
X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
Cc: Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

--Sig_/w_TNHNTWrz/qmLV53Fhwj4H
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi,

Here are two small patches.=20

The first one add #:substitutable? to the copy-build system.

I don't know how to check if it works as intended though. It's
similar to the commit d0050ea8ad1c32d94cf5ba6725a0fc961bb23f38=20
("build-system/go: Add #:substitutable? argument.") so normally
it shouldn't be an issue, but if someone can double check it it
would be best as it would avoid keeping around substitutes of
very big sizes.

The second patch adds a ZIM file. I'll most likely send more
patches to add additional ZIM files packages (about 10) later
on. I prefer doing it this way as it avoids having to deal with
potential rebases breaking if there is something wrong with my
second patch.

Denis 'GNUtoo' Carikli (2):
  build-system/copy: Add #:substitutable? argument.
  gnu: Add wikipedia_en_all_maxi

 gnu/local.mk               |  1 +
 gnu/packages/zim-files.scm | 86 ++++++++++++++++++++++++++++++++++++++
 guix/build-system/copy.scm |  4 +-
 3 files changed, 90 insertions(+), 1 deletion(-)
 create mode 100644 gnu/packages/zim-files.scm


base-commit: c193b5203b31246a6d74270c8086c45851561947
--=20
2.38.1


--Sig_/w_TNHNTWrz/qmLV53Fhwj4H
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCAAdFiEEeC+d2+Nrp/PU3kkGX138wUF34mMFAmOmJqQACgkQX138wUF3
4mNvnQ//Vxn8qW97pKPuNKidpl4iL2/uxXaxzk2aRQ6IdS/PS+S6VZxl1FSW3efK
Gg1fPlUCaR0X2LxqqAMe9LANP0sAVGOQEYm76+JQ70Yrs/EFryreQMA7+dHBuxlA
hRgSE9TxteoEy1w9lBHDgxPGpG9Sda+luHr5oNDcq0HSB43qd3StD+UmC+mAOmnQ
yWX341sDDaDNMIqCNql84PgjBaBFqIzfOhb3W0K1wRRUCAQ7ZuqXzWQwIUJ4XGUZ
voX3Rg5YlEM2/fZGXeNyWQ8UFhtl4n4rkgH3xa6IYYsqZ7V/5wSm2K1CZGX7B2Jq
oE6c9LwQj91r1A39Zq5+/yIkC77ABIszVtYqe74QqlmJviYhHhSXOJU9PPpQyOR1
GdnVZXchtLlH4b9XCr9hUpJ878bIrpTWSftldvxbI36o+JCFezjddY3vvvYMUEp+
rGb47YjJRl2dtjoVRYzGjUxJ3qV5Rkeep80r0NKdokUlAlln6Sx6yUvY3hrlzhlr
YpTZ+UJ4dq6g/C0nzSZTV0rgw8Zxjj0QlEb1VQYSpKzVekiCLPiwHqOUpwQAZU3u
fl/Z646eBrg4NyibiEjpOxMr6CRcLeZg6ve0+Ir0yeRfq53HUjIgPwlwMY935nhk
+4PAg/uWdiIQWHEGwxEQrnamOu4SlEP+pAavwv38BpLDpGvIi/U=
=DAyV
-----END PGP SIGNATURE-----

--Sig_/w_TNHNTWrz/qmLV53Fhwj4H--




Acknowledgement sent to Denis 'GNUtoo' Carikli <GNUtoo@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#60288; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Wed, 28 Dec 2022 18:15:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.