GNU bug report logs - #60328
30.0.50; [PATCH] Replace newsticker--lists-intersect-p.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60328 in the body.
You can then email your comments to 60328 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: LdBeth <andpuke <at> foxmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 30.0.50; [PATCH] Replace newsticker--lists-intersect-p.
Date: Sun, 25 Dec 2022 19:07:40 -0600

[Message part 1 (text/plain, inline)]

All the patterns that calls `newsticker--lists-intersect-p' in
lisp/net/newst-plainview.el like:

(newsticker--lists-intersect-p
 (get-text-property (point) 'invisible)
  buffer-invisibility-spec)

Can be replace by `(invisible-p (point))' accordingly to reduce
boilerplate.

This patch would also remove the definition of
`newsticker--lists-intersect-p' from lisp/net/newst-backend.el
since is it not referenced elsewhere.

---
ldb

[0001-newsticker-Remove-newsticker-lists-intersect-p.patch (text/plain, attachment)]

Message #8 received at 60328 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: LdBeth <andpuke <at> foxmail.com>
Cc: 60328 <at> debbugs.gnu.org, Ulf Jasper <ulf.jasper <at> web.de>
Subject: Re: bug#60328: 30.0.50; [PATCH] Replace newsticker--lists-intersect-p.
Date: Fri, 1 Sep 2023 21:55:39 +0200

LdBeth <andpuke <at> foxmail.com> writes:

> All the patterns that calls `newsticker--lists-intersect-p' in
> lisp/net/newst-plainview.el like:
>
> (newsticker--lists-intersect-p
>  (get-text-property (point) 'invisible)
>   buffer-invisibility-spec)
>
> Can be replace by `(invisible-p (point))' accordingly to reduce
> boilerplate.
>
> This patch would also remove the definition of
> `newsticker--lists-intersect-p' from lisp/net/newst-backend.el
> since is it not referenced elsewhere.

Ulf, do you have any comments on this patch?

Message #11 received at 60328 <at> debbugs.gnu.org (full text, mbox):

From: Ulf Jasper <ulf.jasper <at> web.de>
To: Stefan Kangas <stefankangas <at> gmail.com>
Cc: 60328 <at> debbugs.gnu.org, LdBeth <andpuke <at> foxmail.com>
Subject: Re: bug#60328: 30.0.50; [PATCH] Replace newsticker--lists-intersect-p.
Date: Sat, 02 Sep 2023 10:21:06 +0200

Am 01.09.2023 um 21:55 (+0200) schrieb Stefan Kangas:
> Ulf, do you have any comments on this patch?

I did not try it out but that patch looks good to me.  Go ahead!

Message #16 received at 60328-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefankangas <at> gmail.com>
To: Ulf Jasper <ulf.jasper <at> web.de>
Cc: 60328-done <at> debbugs.gnu.org, LdBeth <andpuke <at> foxmail.com>
Subject: Re: bug#60328: 30.0.50; [PATCH] Replace newsticker--lists-intersect-p.
Date: Sat, 2 Sep 2023 10:35:49 +0200

Version: 30.1

Ulf Jasper <ulf.jasper <at> web.de> writes:

> Am 01.09.2023 um 21:55 (+0200) schrieb Stefan Kangas:
> > Ulf, do you have any comments on this patch?
>
> I did not try it out but that patch looks good to me.  Go ahead!

Thanks, so let's install it.  I fixed the commit message to include a
ChangeLog and pushed to master as commit 03a7e448a26.

LdBeth, please include a ChangeLog according to CONTRIBUTE with your
next patch.  It will save us some work when we apply it.  Thanks in
advance.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.