GNU bug report logs - #60345
[PATCH] gnu: perl-image-exiftool: Update to 12.50, use new package style.

Previous Next

Package: guix-patches;

Reported by: kiasoc5 <kiasoc5 <at> disroot.org>

Date: Mon, 26 Dec 2022 21:02:01 UTC

Severity: normal

Tags: patch

Done: Christopher Baines <mail <at> cbaines.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 60345 in the body.
You can then email your comments to 60345 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#60345; Package guix-patches. (Mon, 26 Dec 2022 21:02:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to kiasoc5 <kiasoc5 <at> disroot.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 26 Dec 2022 21:02:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: kiasoc5 <kiasoc5 <at> disroot.org>
To: guix-patches <at> gnu.org
Cc: kiasoc5 <kiasoc5 <at> disroot.org>
Subject: [PATCH] gnu: perl-image-exiftool: Update to 12.50,
 use new package style.
Date: Mon, 26 Dec 2022 16:01:33 -0500
* gnu/packages/photo.scm (perl-image-exiftool): Update to 12.50.
[arguments]: Use G-expresisons. Remove trailing #t. Use #$output instead of assoc-ref.
---
 gnu/packages/photo.scm | 27 ++++++++++++---------------
 1 file changed, 12 insertions(+), 15 deletions(-)

diff --git a/gnu/packages/photo.scm b/gnu/packages/photo.scm
index 4d85611101..2a8a8de25d 100644
--- a/gnu/packages/photo.scm
+++ b/gnu/packages/photo.scm
@@ -299,7 +299,7 @@ (define-public gphoto2
 (define-public perl-image-exiftool
   (package
     (name "perl-image-exiftool")
-    (version "12.16")
+    (version "12.50")
     (source
      (origin
        (method url-fetch)
@@ -309,24 +309,21 @@ (define-public perl-image-exiftool
              ;; New releases may take a while to hit CPAN.
              (string-append "https://www.sno.phy.queensu.ca/~phil/exiftool/"
                             "Image-ExifTool-" version ".tar.gz")))
-       (patches (search-patches "perl-image-exiftool-CVE-2021-22204.patch"))
        (sha256
         (base32
-         "0skm22b3gg1bfk0amklrprpva41m6mkrhqp0gi7z1nmcf9ypjh61"))))
+         "1a605rz00d7p866a22sw0s63m5a6y4xqqrzp7q7jyc0hbky43s5w"))))
     (build-system perl-build-system)
     (arguments
-     '(#:phases
-       (modify-phases %standard-phases
-         (add-after 'install 'post-install
-           (lambda* (#:key outputs #:allow-other-keys)
-             ;; Make sure the 'exiftool' commands finds the library.
-             ;; XXX: Shouldn't it be handled by PERL-BUILD-SYSTEM?
-             (let* ((out (assoc-ref outputs "out"))
-                    (pm  (find-files out "^ExifTool\\.pm$"))
-                    (lib (dirname (dirname (car pm)))))
-               (wrap-program (string-append out "/bin/exiftool")
-                 `("PERL5LIB" prefix (,lib)))
-               #t))))))
+     (list #:phases
+           #~(modify-phases %standard-phases
+               (add-after 'install 'post-install
+                 (lambda* (#:key outputs #:allow-other-keys)
+                   ;; Make sure the 'exiftool' commands finds the library.
+                   ;; XXX: Shouldn't it be handled by PERL-BUILD-SYSTEM?
+                   (let* ((pm  (find-files #$output "^ExifTool\\.pm$"))
+                          (lib (dirname (dirname (car pm)))))
+                     (wrap-program (string-append #$output "/bin/exiftool")
+                       `("PERL5LIB" prefix (,lib)))))))))
     (home-page "https://metacpan.org/release/Image-ExifTool")
     (synopsis "Program and Perl library to manipulate EXIF and other metadata")
     (description "This package provides the @code{exiftool} command and the

base-commit: 7c476873e0300711bf92668cf01abd28f7295ead
-- 
2.39.0





Information forwarded to guix-patches <at> gnu.org:
bug#60345; Package guix-patches. (Mon, 16 Jan 2023 20:40:01 GMT) Full text and rfc822 format available.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: kiasoc5 <kiasoc5 <at> disroot.org>
Cc: 60345-done <at> debbugs.gnu.org, guix-patches <at> gnu.org
Subject: Re: [bug#60345] [PATCH] gnu: perl-image-exiftool: Update to 12.50,
 use new package style.
Date: Mon, 16 Jan 2023 20:39:03 +0000
[Message part 1 (text/plain, inline)]
kiasoc5 via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/photo.scm (perl-image-exiftool): Update to 12.50.
> [arguments]: Use G-expresisons. Remove trailing #t. Use #$output instead of assoc-ref.
> ---
>  gnu/packages/photo.scm | 27 ++++++++++++---------------
>  1 file changed, 12 insertions(+), 15 deletions(-)

Looks good to me, pushed to master as
ab09e8e578480463bafd8e21451acf9dd6ddd74f.

Thanks,

Chris
[signature.asc (application/pgp-signature, inline)]

Reply sent to Christopher Baines <mail <at> cbaines.net>:
You have taken responsibility. (Mon, 16 Jan 2023 20:40:02 GMT) Full text and rfc822 format available.

Notification sent to kiasoc5 <kiasoc5 <at> disroot.org>:
bug acknowledged by developer. (Mon, 16 Jan 2023 20:40:02 GMT) Full text and rfc822 format available.

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 14 Feb 2023 12:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 1 year and 43 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.